GNU bug report logs - #42302
[PATCH] gnu: Add xssproxy

Previous Next

Full log

Message #8 received at 42302 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: 42302 <at> debbugs.gnu.org
Subject: Re: [bug#42302] [PATCH] gnu: Add xssproxy
Date: Fri, 10 Jul 2020 22:49:13 +0200

Hi,

Ivan Kozlov <kanichos <at> yandex.ru> skribis:

> xssproxy is a tiny daemon that provides an Idle Inhibition Service specification conformant D-Bus interface to libXss. It allows programs that support only this interface (like older Firefox and IceCat) to inhibit screen locking or blanking on systems without a conformant screen locker program.
>
> * gnu/packages/xdisorg.scm (xssproxy): New variable.

Nice!  Note: you don’t need to provide a description of the package in
the commit log.

Overall the patch looks good to me, modulo minor issues reported by
‘guix lint’ (see below for how to address them):

--8<---------------cut here---------------start------------->8---
gnu/packages/xdisorg.scm:1384:12: xssproxy <at> 1.0.0: 'pkg-config' should probably be a native input
gnu/packages/xdisorg.scm:1368:12: xssproxy <at> 1.0.0: the source file name should contain the package name
gnu/packages/xdisorg.scm:1368:12: xssproxy <at> 1.0.0: the source URI should not be an autogenerated tarball
--8<---------------cut here---------------end--------------->8---

> +(define xssproxy

Use ‘define-public’ instead.

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/timakro/xssproxy/archive/v"
> +                                  version
> +                                  ".tar.gz"))

Use ’git-fetch’ instead of ‘url-fetch’ to fetch the source over Git
instead of an autogenerated tarball, and add a ‘file-name’ field.

> +    (synopsis "Forward freedesktop.org Idle Inhibition Service calls to Xss")
> +    (description "xssproxy implements the org.freedesktop.ScreenSaver D-Bus interface
> +described in the Idle Inhibition Service Draft by the freedesktop.org developers.
> +The inhibition of the screensaver is then controlled using the XScreenSaverSuspend
> +function from the Xss (X11 Screen Saver extension) library.")

You can use markup for clarity, for instance
@code{org.freedesktop.ScreenSaver}.

Could you send an updated patch?

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.