Subject: Re: bug#42301: [PATCH] gnu: solfage: fix build.

From: Nicolas Goaziou <[email-masked]>
Date: Sun, 09 Aug 2020 13:08:52 +0200

Hello,

Michael Rohleder <[email-masked]> writes:

> * gnu/packages/music.scm (solfage): fix build (http://issues.guix.gnu.org/42301).
> ---
>  gnu/packages/music.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index db2f1ff8d6..af65c40193 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -1361,6 +1361,9 @@ re-sequencer LV2 plugin.")
>               (substitute* '("solfege/parsetree.py"
>                              "solfege/presetup.py")
>                 (("#!/usr/bin/python") (string-append "#!" (which "python"))))
> +             ;; fix build, see https://issues.guix.gnu.org/42301
> +             (with-fluids ((%default-port-encoding "ISO-8859-1"))
> +               (substitute* '("README") (("Malm.") "Malmoe")))

Thank you. Unfortunately, the build fails later on with the following
unrelated message, probably related to the latest Lilypond release:

    fatal error: Uninitialized variable `write-performances-midis' in module (lily)

Besides, you are adding this snippet to an unrelated phase, about Python
wrapping.

BTW, would it make sense to provide 3.23.4 release instead? It is
a development version, but development has stalled anyway. Also, it
relies on Python 3 intead of Python 2.

I tried to update it with the following source:

     (origin
       (method url-fetch)
       (uri (string-append "http://alpha.gnu.org/gnu/solfege/solfege-"
                           version ".tar.gz"))
       (sha256
        (base32 "0sc17vf4xz6gy0s0z9ghi68yskikdmyb4gdaxx6imrm40734k8mp")))

but it fails in the same way.

WDYT?

Regards,
-- 
Nicolas Goaziou