GNU bug report logs - #42295
[PATCH] gnu: rust-1.44: Add rustfmt output.

Previous Next

Full log

Message #17 received at 42295 <at> debbugs.gnu.org (full text, mbox):

From: Matthew Kraai <kraai <at> ftbfs.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 42295 <at> debbugs.gnu.org
Subject: Re: [bug#42295] [PATCH] gnu: rust-1.44: Add rustfmt output.
Date: Wed, 2 Dec 2020 05:29:25 -0800

[Message part 1 (text/plain, inline)]

Hi John,

On 11/26/20 8:51 AM, John Soo wrote:
> Matthew Kraai <kraai <at> ftbfs.org> writes:
>> According to https://github.com/rust-lang/rustfmt, rustfmt was made a
>> component in 1.24.0.  Would it be better to add this support to the
>> rust-1.24 package instead?  I've attached the patch I'm currently testing.
> Keep it on rust <at> 1.44. Even though guix refresh --list-dependent will
> report not many dependents, changing a current rust version would
> trigger many rebuilds. There would be enough rebuilds to require it to
> be applied to staging.
>
> I've also attached a work in progress patch to add rls as an output,
> too.  I would love if all the "extended" tools can be included. Some
> tools like clippy and the rust-src component would be very helpful.
>
> One other thing:
>
>> +      (outputs '("out" "doc" "cargo" "rustfmt"))
> should probably be: (cons "rustfmt" (package-outputs base-rust))
>
> to be more resistant to changes to older packages.
Here is an updated patch.  I modified the rust-1.46 package, used your 
suggestion to add rustfmt to the list of outputs, did not modify the 
mkdir-prefix-paths phase (which doesn't seem to be necessary), and 
updated the delete-install-logs phase.

-- 
Matthew Kraai

[0001-gnu-rust-1.46-Add-rustfmt-output.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.