From unknown Fri Jun 13 09:53:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42283 <42283@debbugs.gnu.org> To: bug#42283 <42283@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add adlplug. Reply-To: bug#42283 <42283@debbugs.gnu.org> Date: Fri, 13 Jun 2025 16:53:46 +0000 retitle 42283 [PATCH] gnu: Add adlplug. reassign 42283 guix-patches submitter 42283 Alexandros Theodotou severity 42283 normal tag 42283 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 08 17:48:27 2020 Received: (at submit) by debbugs.gnu.org; 8 Jul 2020 21:48:27 +0000 Received: from localhost ([127.0.0.1]:39282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtHvX-0003Vb-Bf for submit@debbugs.gnu.org; Wed, 08 Jul 2020 17:48:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:43656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtHvV-0003VT-MY for submit@debbugs.gnu.org; Wed, 08 Jul 2020 17:48:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHvV-0006Uo-9z for guix-patches@gnu.org; Wed, 08 Jul 2020 17:48:25 -0400 Received: from mout02.posteo.de ([185.67.36.142]:35845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHvT-0004j3-0i for guix-patches@gnu.org; Wed, 08 Jul 2020 17:48:24 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8F9D12400FB for ; Wed, 8 Jul 2020 23:48:21 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B2CbL3hp3z6tmb for ; Wed, 8 Jul 2020 23:47:57 +0200 (CEST) Message-ID: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> Subject: [PATCH] gnu: Add adlplug. From: Alexandros Theodotou To: Guix patches Date: Wed, 08 Jul 2020 22:47:42 +0100 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-LLMhqj6ijjhXHznm0do2" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Received-SPF: pass client-ip=185.67.36.142; envelope-from=alex@zrythm.org; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/08 15:43:25 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-LLMhqj6ijjhXHznm0do2 Content-Type: multipart/mixed; boundary="=-6TooXc2q8jdTrayFARZM" --=-6TooXc2q8jdTrayFARZM Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, This patch adds the ADLPlug LV2 plugin. Thanks, Alex --=-6TooXc2q8jdTrayFARZM Content-Disposition: attachment; filename="0001-gnu-Add-adlplug.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-adlplug.patch"; charset="UTF-8" RnJvbSA5ZmI2NWU4NmQ3ZDE3NWI3NjgwNzc3ZmI3NDA4MjQ5MTY0MmJmZTFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kcm9zIFRoZW9kb3RvdSA8YWxleEB6cnl0aG0ub3Jn PgpEYXRlOiBXZWQsIDggSnVsIDIwMjAgMjI6NDY6MzggKzAxMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IEFkZCBhZGxwbHVnLgoKKiBnbnUvcGFja2FnZXMvbXVzaWMuc2NtIChhZGxwbHVnKTogTmV3 IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9tdXNpYy5zY20gfCA0MiArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL211c2ljLnNjbSBiL2dudS9wYWNrYWdl cy9tdXNpYy5zY20KaW5kZXggMGI4YjhkZjIyNi4uMTFjZDBkYzI0NiAxMDA2NDQKLS0tIGEvZ251 L3BhY2thZ2VzL211c2ljLnNjbQorKysgYi9nbnUvcGFja2FnZXMvbXVzaWMuc2NtCkBAIC0xNDIy LDYgKzE0MjIsNDggQEAgc2Vzc2lvbnMuICBTb2xmZWdlIGlzIGFsc28gZGVzaWduZWQgdG8gYmUg ZXh0ZW5zaWJsZSBzbyB5b3UgY2FuIGVhc2lseSB3cml0ZQogeW91ciBvd24gbGVzc29ucy4iKQog ICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkKIAorKGRlZmluZS1wdWJsaWMgYWRscGx1Zwor ICAocGFja2FnZQorICAgIChuYW1lICJhZGxwbHVnIikKKyAgICAodmVyc2lvbiAiMS4wLjEiKQor ICAgIChzb3VyY2UKKyAgICAgIChvcmlnaW4KKyAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisg ICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICh1cmwgImh0dHBzOi8v Z2l0aHViLmNvbS9qcGNpbWEvQURMcGx1Zy5naXQiKQorICAgICAgICAgICAgICAgKGNvbW1pdCAo c3RyaW5nLWFwcGVuZCAidiIgdmVyc2lvbikpCisgICAgICAgICAgICAgICAocmVjdXJzaXZlPyAj dCkpKSA7IHVzZXMgM3JkIHBhcnR5IHN1Ym1vZHVsZXMKKyAgICAgICAgKGZpbGUtbmFtZSAoZ2l0 LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAoc2hhMjU2CisgICAgICAgICAoYmFz ZTMyCisgICAgICAgICAgIjBuOXNyZGxnbDFqNTI4YXA1eG1sbHJxczF3NmliYzV5ZjlzcGh2bDFx OWtqbml6eHJzMmMiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQtc3lzdGVtKQor ICAgKGFyZ3VtZW50cworICAgIGAoIzp0ZXN0cz8gI2YgIDsgbm8gdGVzdHMKKyAgICAgICM6Y29u ZmlndXJlLWZsYWdzIGAoIi1EQURMcGx1Z19WU1QyPU9GRiIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgIi1EQURMcGx1Z19WU1QzPU9GRiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIi1E QURMcGx1Z19MVjI9T04iCisgICAgICAgICAgICAgICAgICAgICAgICAgICItREFETHBsdWdfU3Rh bmRhbG9uZT1PTiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIi1EQURMcGx1Z19KYWNrPU9O IgorICAgICAgICAgICAgICAgICAgICAgICAgICAiLURBRExwbHVnX0NISVA9T1BMMyIpKSkKKyAg IChpbnB1dHMKKyAgICBgKCgiYWxzYS1saWIiICxhbHNhLWxpYikKKyAgICAgICgiZnJlZXR5cGUi ICxmcmVldHlwZSkKKyAgICAgICgiamFjayIgLGphY2stMSkKKyAgICAgICgibGlieDExIiAsbGli eDExKQorICAgICAgKCJsaWJ4Y3Vyc29yIiAsbGlieGN1cnNvcikKKyAgICAgICgibGlieGluZXJh bWEiICxsaWJ4aW5lcmFtYSkKKyAgICAgICgibGlieHJhbmRyIiAsbGlieHJhbmRyKSkpCisgICAo bmF0aXZlLWlucHV0cworICAgIGAoKCJwa2ctY29uZmlnIiAscGtnLWNvbmZpZykpKQorICAgIChz eW5vcHNpcyAiRk0gY2hpcCBzeW50aGVzaXplciBwbHVnaW4iKQorICAgIChkZXNjcmlwdGlvbgor ICAgICAgIlRoaXMgcGFja2FnZSBwcm92aWRlcyBGTSBzeW50aGVzaXplciBwbHVnaW5zLCBiYXNl ZCBvbgorT1BMMyBhbmQgT1BOMiBzb3VuZCBjaGlwIGVtdWxhdGlvbnMuICBUaGUgZW11bGF0aW9u cyBhbmQgdGhlIGRyaXZlcnMgYXJlCitwcm92aWRlZCBieSBsaWJBRExNSURJIGFuZCBsaWJPUE5N SURJLiIpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2pwY2ltYS9BRExwbHVn IikKKyAgICAobGljZW5zZSBsaWNlbnNlOmJvb3N0MS4wKSkpCisKIChkZWZpbmUtcHVibGljIHBv d2VydGFiZWRpdG9yCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgInBvd2VydGFiZWRpdG9yIikKLS0g CjIuMjcuMAoK --=-6TooXc2q8jdTrayFARZM-- --=-LLMhqj6ijjhXHznm0do2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl8GPv4ACgkQAi6uQjE9 cPNqvAf7BnvQEivuIFsKZAQtC/hbtuIcAetAWJ4iNeaIRkQCTrVPnveKzYRvN+95 eXVlj07+32Npt4dlEKE+9Sd1iNxYVoq+RbEMxEhE04ahevbgT9gNap2+pjUktUg1 WH+fd1P/O+wm8eiF/KOWuXsxWS0qj5tuJjsqPVq33qN4UKsxGouYoZ2mKPOMSgkw kbxa70+b47WDAa6dwPNYKWl1xWUVeW+Udghxjc4GGigqWKyVQBcWgvLiAtkSWWkK DbAcRtD0FVY4JcceB/ZKwYK0iZR3uzwDJpaWq0w2oOT9q4+CoxOkozIRt83k2JE9 LSkMnB+H2zPZj3IFMyhN4knosmU1eg== =VW3/ -----END PGP SIGNATURE----- --=-LLMhqj6ijjhXHznm0do2-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 18:55:53 2020 Received: (at 42283) by debbugs.gnu.org; 20 Jul 2020 22:55:54 +0000 Received: from localhost ([127.0.0.1]:36629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxehN-0000mO-LO for submit@debbugs.gnu.org; Mon, 20 Jul 2020 18:55:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxehL-0000mB-I9 for 42283@debbugs.gnu.org; Mon, 20 Jul 2020 18:55:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42839) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxehF-0006sM-37; Mon, 20 Jul 2020 18:55:45 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:59914 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxehE-0000Sy-3H; Mon, 20 Jul 2020 18:55:44 -0400 From: Marius Bakke To: Alexandros Theodotou , 42283@debbugs.gnu.org Subject: Re: [bug#42283] [PATCH] gnu: Add adlplug. In-Reply-To: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> References: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> Date: Tue, 21 Jul 2020 00:55:34 +0200 Message-ID: <87365lhk49.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42283 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros Theodotou writes: > Hi, > > This patch adds the ADLPlug LV2 plugin. [...] > * gnu/packages/music.scm (adlplug): New variable. [...] =20=20 > +(define-public adlplug > + (package > + (name "adlplug") > + (version "1.0.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/jpcima/ADLplug.git") > + (commit (string-append "v" version)) > + (recursive? #t))) ; uses 3rd party submodules Is it possible to package these modules separately? One of the submodules, uses a seemingly non-free license: https://juce.com/juce-5-license Interestingly, it becomes a free license (GPL3) once you exceed a certain revenue!? IANAL and only had a cursory look, but am not comfortable adding this without a larger discussion. A good first step would be to package JUCE separately and take it from there. The other bundled packages seem fine, but it would be comforting to have them in Guix even if this package needs the bundled versions. I also think we should mention their licenses -- especially since vst3sdk is available as either a proprietary license or GPL3, and taking the latter implies that this package _also_ becomes GPL3. (btw, the bundled fmt library is already available) So, this will be a tricky one. Do you think you can look into packaging the bundled components separately? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8WIOcACgkQoqBt8qM6 VPrahgf/QYXThvOKFx3O6Qk4uwX4A0yIGWo1nDK1CbHmBeN1PvkVilT8FoPv+5fZ f77OOaTDH5ICZza457HrHjPz7oKJEgYN0VbCp5pNvRGurGsiyb8V7/uL3kNB5FBD ZE5bi9YDeupLqcTpPIDf+YBWNykqaStwfM/zA0eGzOpl00Jz3VS1cXyoYAdY7Sdg 7wxnqHIOnM0KKOKxKgY7ovbRnAj6aD8HBcxvAmb8F/mU9+8a9fnjBEPt/WgXgwtm yG6qXa3vre68omz4QS/N7sHMmz9uOBljJfAlAqta+Zf+9pz0SWR1R/7lqlmR4CK4 aLwA/UICyfZiT8xAWmH53nM5sYQ3kA== =6Zxn -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 19:18:24 2020 Received: (at 42283) by debbugs.gnu.org; 20 Jul 2020 23:18:24 +0000 Received: from localhost ([127.0.0.1]:36680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxf3A-0001LQ-Hg for submit@debbugs.gnu.org; Mon, 20 Jul 2020 19:18:24 -0400 Received: from mout01.posteo.de ([185.67.36.141]:51655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxf38-0001LD-UG for 42283@debbugs.gnu.org; Mon, 20 Jul 2020 19:18:23 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A32DE16005F for <42283@debbugs.gnu.org>; Tue, 21 Jul 2020 01:18:16 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B9d1z01pTz9rxD; Tue, 21 Jul 2020 01:18:14 +0200 (CEST) Message-ID: <5153a083968f85ddc3efd61d912733e32ee4a329.camel@zrythm.org> Subject: Re: [bug#42283] [PATCH] gnu: Add adlplug. From: Alexandros Theodotou To: Marius Bakke , 42283@debbugs.gnu.org Date: Tue, 21 Jul 2020 00:18:09 +0100 In-Reply-To: <87365lhk49.fsf@gnu.org> References: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> <87365lhk49.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-CgKW1Sky4Hn+5gMqki9n" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42283 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-CgKW1Sky4Hn+5gMqki9n Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Thanks for the review. On Tue, 2020-07-21 at 00:55 +0200, Marius Bakke wrote: > > + (uri (git-reference > > + (url "https://github.com/jpcima/ADLplug.git") > > + (commit (string-append "v" version)) > > + (recursive? #t))) ; uses 3rd party submodules >=20 > Is it possible to package these modules separately? >=20 > One of the submodules, uses a seemingly non-free license: >=20 > https://juce.com/juce-5-license >=20 > Interestingly, it becomes a free license (GPL3) once you exceed a > certain revenue!? >=20 > IANAL and only had a cursory look, but am not comfortable adding this > without a larger discussion. A good first step would be to package > JUCE > separately and take it from there. The thing is that this is a fork of JUCE with some extra commits. The original JUCE doesn't include an LV2 exporter for example (after ignoring requests and patches to add it for years, it's still not there. fun thread: https://github.com/juce-framework/JUCE/issues/123 ) so I think this fork adds the LV2 exporter among other things (I also see various other commits that are not in other JUCE forks I know of). Re the license: JUCE is dual-licened under a proprietary license and GPL3+, and some modules are under the ISC license. adlplug has its source code licensed under boost, but since it includes JUCE it's essentially covered by the GPL3+ >=20 > The other bundled packages seem fine, but it would be comforting to > have > them in Guix even if this package needs the bundled versions. I also > think we should mention their licenses -- especially since vst3sdk is > available as either a proprietary license or GPL3, and taking the > latter > implies that this package _also_ becomes GPL3. Yes same as JUCE. I'll send an updated patch that mentions all the licenses. It would be nice to have the libraries in Guix anyway but I don't have much time/interest in them at the moment to do that. >=20 > (btw, the bundled fmt library is already available) >=20 > So, this will be a tricky one. Do you think you can look into > packaging > the bundled components separately? I checked them, and they seem to be fixed to specific commits and not releases. I am not sure if there's something specific in those commits that's not included in the releases that the plugin needs. I'd play it safe and use the submodules here. Thanks, Alex --=-CgKW1Sky4Hn+5gMqki9n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl8WJjEACgkQAi6uQjE9 cPOsYAf/YLfbWT8o0vibOZBMp7pnNj7eDV6OZ1UXQDz6by/6fWJs98Txpdn+9Xyy PqcM7qKVqGx4BWpYqkBdR9vT5b91MfoDAn8vYly/S9f2aAWjdqTRLku26UcVRbXQ a2EXwgIH816Og7x6BewjQkkS3cM2yhv9Zw+pifjrnOuYCeePi+6ii5Lne6vUWHxs T5TLf0vIRU/39wYIH5WdsjyF6IXrqPE9B+j7joQ9qOpN84Z2P+erEJeI7dlzzXT8 ia4W1Yp2EhERYej6vIq67rfIHlPcvXWh404XHHeG83sPZ96EmoMS20pUwdErys6q XO7hUJApFcpGt2io49vJL06X7bj+bw== =MqoS -----END PGP SIGNATURE----- --=-CgKW1Sky4Hn+5gMqki9n--