GNU bug report logs - #42280
[PATCH 1/2] gnu: Add bshapr.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alexandros Theodotou <alex <at> zrythm.org>
Subject: bug#42280: closed (Re: [bug#42280] [PATCH 1/2] gnu: Add bshapr.)
Date: Mon, 20 Jul 2020 22:18:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#42280: [PATCH 1/2] gnu: Add bshapr.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 42280 <at> debbugs.gnu.org.

-- 
42280: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42280
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42280-done <at> debbugs.gnu.org
Subject: Re: [bug#42280] [PATCH 1/2] gnu: Add bshapr.
Date: Tue, 21 Jul 2020 00:17:41 +0200

[Message part 3 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> These patches add bshapr and bjumblr, 2 LV2 plugins. I used inheritance
> from bsequencer since they are by the same author and use the same
> build procedure/system.

Inheritance is a double-edged sword: someone making changes to
bsequencer may not realize that it affects these two packages.  I've
ignored that for now, but would not mind a patch to 'un-inherit' them.

[...]

> * gnu/packages/music.scm (bjumblr): New variable.

[...]
  
> +(define-public bjumblr
> +  (package
> +    (inherit bsequencer)
> +    (name "bjumblr")
> +    (version "0.2")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/sjaehn/BJumblr.git")

I removed the .git suffix from these patches, as well as the ninja2
patch earlier, ref commit b0e7b6992f3f845e83cfbca4d700b51dba50b4d5.

> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "14z8113zkwykbhm1a8h2xs972dgifvlfij92b08jckyc7cbz84ys"))))

Also, indentation is off for both patches (but fixed!).

[...]

> +    (description "B.Shapr is a beat/envelope shaper LV2 plugin")

Missing punctuation (also fixed).  :-)

Applied!

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add bshapr.
Date: Wed, 08 Jul 2020 22:36:56 +0100

[Message part 6 (text/plain, inline)]

Hi,

These patches add bshapr and bjumblr, 2 LV2 plugins. I used inheritance
from bsequencer since they are by the same author and use the same
build procedure/system.

Thanks,
Alex

[0002-gnu-Add-bjumblr.patch (text/x-patch, attachment)]

[0001-gnu-Add-bshapr.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.