GNU bug report logs - #42278
[PATCH] gnu: Add ninjas2.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <marius <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#42278: closed ([PATCH] gnu: Add ninjas2.)
Date: Mon, 20 Jul 2020 21:58:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 20 Jul 2020 23:57:32 +0200
with message-id <87imehhmsz.fsf <at> gnu.org>
and subject line Re: [bug#42278] [PATCH] gnu: Add ninjas2.
has caused the debbugs.gnu.org bug report #42278,
regarding [PATCH] gnu: Add ninjas2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
42278: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42278
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add ninjas2.
Date: Wed, 08 Jul 2020 22:23:22 +0100

[Message part 3 (text/plain, inline)]

Hi,

This patch adds ninjas2 (lv2 plugin).

Thanks,
Alex

[0001-gnu-Add-ninjas2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42278-done <at> debbugs.gnu.org
Subject: Re: [bug#42278] [PATCH] gnu: Add ninjas2.
Date: Mon, 20 Jul 2020 23:57:32 +0200

[Message part 7 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> This patch adds ninjas2 (lv2 plugin).

Applied with these changes:

[diff (text/x-patch, inline)]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 4943249705..989c65a932 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -923,17 +923,17 @@ Sega Master System/Mark III, Sega Genesis/Mega Drive, BBC Micro
         (git-reference
          (url "https://github.com/clearly-broken-software/ninjas2.git")
          (commit (string-append "v" version))
-         ;; bundles a specific commit of the DISTRHO plugin framework
+         ;; Bundles a specific commit of the DISTRHO plugin framework.
          (recursive? #t)))
        (file-name (git-file-name name version))
        (sha256
         (base32 "1kwp6pmnfar2ip9693gprfbcfscklgri1k1ycimxzlqr61nkd2k9"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f                      ; no "check" target
+     `(#:tests? #f                      ;no tests
        #:make-flags
        (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
-             "CC=gcc")
+             (string-append "CC=" ,(cc-for-target)))
        #:phases
        (modify-phases %standard-phases
          (delete 'configure)            ;no configure target
@@ -973,7 +973,7 @@ Sega Master System/Mark III, Sega Genesis/Mega Drive, BBC Micro
     (description
      "Ninjas 2 is a rewrite of the Ninjas sample slicer audio plugin.
 Its goal is to be an easy to use sample slicer with quick slicing of samples
-and auto-mapping slices to midi note numbers.")
+and auto-mapping slices to MIDI note numbers.")
     (home-page "https://github.com/clearly-broken-software/ninjas2")
     (license license:gpl3+)))
 

[Message part 9 (text/plain, inline)]

Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.