GNU bug report logs - #42249
[PATCH] gnu: Add font-libertinus.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42249 in the body.
You can then email your comments to 42249 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Van den Langenbergh <tmt_vdl <at> gmx.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add font-libertinus.
Date: Tue, 7 Jul 2020 17:18:21 +0200

[Message part 1 (text/plain, inline)]

Hello,

I am rather fond of the Libertinus Mono font for Emacs, as I like my Monospace fonts to have Serifs. As others may like the font as well I have created a patch to add it to the fonts package.

This being the first patch I have ever submitted to Guix I'm not entirely sure I did everything right, I followed the Submitting Patches part of the manual as close as I could, but I may have made a mistake somewhere, so feel free to correct me where needed.

I have included the patch generated by git format-patch as an attachment.

Sincerely yours,

-Tim Van den Langenbergh

[0001-gnu-Add-font-libertinus.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 42249 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Tim Van den Langenbergh <tmt_vdl <at> gmx.com>
Cc: 42249 <at> debbugs.gnu.org
Subject: Re: [bug#42249] [PATCH] gnu: Add font-libertinus.
Date: Tue, 07 Jul 2020 20:02:13 +0200

[Message part 1 (text/plain, inline)]

Tim,

Tim Van den Langenbergh 写道：
> I am rather fond of the Libertinus Mono font for Emacs, as I 
> like my Monospace fonts to have Serifs.

Interesting…

> As others may like the font as well I have created a patch to 
> add it to the fonts package.

Thank you!

> This being the first patch I have ever submitted to Guix I'm not 
> entirely sure I did everything right, I followed the Submitting 
> Patches part of the manual as close as I could, but I may have 
> made a mistake somewhere, so feel free to correct me where 
> needed.

Your first commit message is flawless; congratulations! :-)

However, [how] did you install and test this package?  This:

+    (source (origin
+         (method git-fetch)
+         (uri (string-append 
"https://github.com/alerque/libertinus/"
+                                  "commit/"
+ 
"800155085d4a1592dc6e76b34cd625794cd0fcdf"))
+         (sha256
+          (base32 
"1mj0d84k1x15hsgksca0qjhc3mmzyaqaqa2vyrbb6s96ycsfsgq3"))))

isn't a valid GIT-FETCH origin:

--8<---------------cut here---------------start------------->8---
~/guix master λ guix build font-libertinus
Backtrace:
In ice-9/boot-9.scm:
 1736:10  4 (with-exception-handler _ _ #:unwind? _ 
 #:unwind-for-type _)
In unknown file:
          3 (apply-smob/0 #<thunk 72848587f160>)
In ice-9/boot-9.scm:
   718:2  2 (call-with-prompt _ _ #<procedure 
   default-prompt-handler (k proc)>)
In ice-9/eval.scm:
   619:8  1 (_ #(#(#<directory (guile-user) 72848546ff00>)))
In guix/ui.scm:
 1953:12  0 (run-guix-command _ . _)

guix/ui.scm:1953:12: In procedure run-guix-command:
In procedure struct-vtable: Wrong type argument in position 1 
(expecting struct): 
"https://github.com/alerque/libertinus/commit/800155085d4a1592dc6e76b34cd625794cd0fcdf"
--8<---------------cut here---------------end--------------->8---

I replaced it with:

+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/alerque/libertinus")
+             (commit (string-append "v" version))))
+       (sha256
+   (base32 
"0flj3xwj8x938wh614ch295j040ccnha1nzmlg5sgpsyxg5gjsbf"))))

Note the ‘commit’ that isn't.

If you're lucky (which is most of the time), upstream will tag 
releases & you won't need to hard-code the commit.  This makes 
updating the package later much easier.

I don't know GitHub well enough to link to it directly, but you 
can find a list of tags under the top-left ‘Branch: main’ 
drop-down here[0].

Now I get an encoding error which is probably not your ‘fault’… 
Guile can be picky when it comes to locales.  I'll poke at it some 
more.

Kind regards,

T G-R

[0]: https://github.com/alerque/libertinus

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42249 <at> debbugs.gnu.org (full text, mbox):

From: Tim Van den Langenbergh <tmt_vdl <at> gmx.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 42249 <at> debbugs.gnu.org
Subject: Re: [bug#42249] [PATCH] gnu: Add font-libertinus.
Date: Tue, 7 Jul 2020 20:18:53 +0200

[Message part 1 (text/plain, inline)]

Hello again,

I actually did switch to using a release URL instead of a git fetch, but I forgot to update the patch, sorry about that! I have added the updated patch.

Regarding the locale, my system (OpenSUSE) is running en_GB.UTF-8, I can try building in a GuixSD VM if that helps?

Thanks for the quick response!

-Tim

On Tuesday, 7 July 2020 20:02:13 CEST you wrote:
> Tim,
> 
> Tim Van den Langenbergh 写道：
> > I am rather fond of the Libertinus Mono font for Emacs, as I 
> > like my Monospace fonts to have Serifs.
> 
> Interesting…
> 
> > As others may like the font as well I have created a patch to 
> > add it to the fonts package.
> 
> Thank you!
> 
> > This being the first patch I have ever submitted to Guix I'm not 
> > entirely sure I did everything right, I followed the Submitting 
> > Patches part of the manual as close as I could, but I may have 
> > made a mistake somewhere, so feel free to correct me where 
> > needed.
> 
> Your first commit message is flawless; congratulations! :-)
> 
> However, [how] did you install and test this package?  This:
> 
> +    (source (origin
> +         (method git-fetch)
> +         (uri (string-append 
> "https://github.com/alerque/libertinus/"
> +                                  "commit/"
> + 
> "800155085d4a1592dc6e76b34cd625794cd0fcdf"))
> +         (sha256
> +          (base32 
> "1mj0d84k1x15hsgksca0qjhc3mmzyaqaqa2vyrbb6s96ycsfsgq3"))))
> 
> isn't a valid GIT-FETCH origin:
> 
> --8<---------------cut here---------------start------------->8---
> ~/guix master λ guix build font-libertinus
> Backtrace:
> In ice-9/boot-9.scm:
>   1736:10  4 (with-exception-handler _ _ #:unwind? _ 
>   #:unwind-for-type _)
> In unknown file:
>            3 (apply-smob/0 #<thunk 72848587f160>)
> In ice-9/boot-9.scm:
>     718:2  2 (call-with-prompt _ _ #<procedure 
>     default-prompt-handler (k proc)>)
> In ice-9/eval.scm:
>     619:8  1 (_ #(#(#<directory (guile-user) 72848546ff00>)))
> In guix/ui.scm:
>   1953:12  0 (run-guix-command _ . _)
> 
> guix/ui.scm:1953:12: In procedure run-guix-command:
> In procedure struct-vtable: Wrong type argument in position 1 
> (expecting struct): 
> "https://github.com/alerque/libertinus/commit/800155085d4a1592dc6e76b34cd625794cd0fcdf"
> --8<---------------cut here---------------end--------------->8---
> 
> I replaced it with:
> 
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/alerque/libertinus")
> +             (commit (string-append "v" version))))
> +       (sha256
> +   (base32 
> "0flj3xwj8x938wh614ch295j040ccnha1nzmlg5sgpsyxg5gjsbf"))))
> 
> Note the ‘commit’ that isn't.
> 
> If you're lucky (which is most of the time), upstream will tag 
> releases & you won't need to hard-code the commit.  This makes 
> updating the package later much easier.
> 
> I don't know GitHub well enough to link to it directly, but you 
> can find a list of tags under the top-left ‘Branch: main’ 
> drop-down here[0].
> 
> Now I get an encoding error which is probably not your ‘fault’… 
> Guile can be picky when it comes to locales.  I'll poke at it some 
> more.
> 
> Kind regards,
> 
> T G-R
> 
> [0]: https://github.com/alerque/libertinus
> 

[0001-gnu-Add-font-libertinus.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 42249-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Tim Van den Langenbergh <tmt_vdl <at> gmx.com>
Cc: 42249-done <at> debbugs.gnu.org
Subject: Re: [bug#42249] [PATCH] gnu: Add font-libertinus.
Date: Thu, 09 Jul 2020 15:06:42 +0200

[Message part 1 (text/plain, inline)]

Tim,

Tim Van den Langenbergh 写道：
> I actually did switch to using a release URL instead of a git 
> fetch, but I forgot to update the patch, sorry about that! I 
> have added the updated patch.

I've pushed it as 5abed7ca3c611bbe30b59293f1837d62c08f05f4, with a 
copyright line for you and some synopsis/description fiddling 
(hope you don't mind).

Thank you very much!  This has replaced Libertine proper on my 
laptop now.

> Regarding the locale, my system (OpenSUSE) is running 
> en_GB.UTF-8, I can try building in a GuixSD VM if that helps?

Nah, the tarball worked fine so let's leave it at that.

Side note: we dropped the ‘SD’ a few years ago.  Now it's just 
‘Guix’ the package manager and ‘Guix System’ for entire operating 
systems.  It's been an enlightening lesson in how hard it is to 
rebrand things!  :-)

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.