GNU bug report logs - #42237
[PATCH] Clean up Tramp version check

Previous Next

Full log

Message #16 received at 42237 <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 42237 <at> debbugs.gnu.org, tramp-devel <at> gnu.org
Subject: Re: [PATCH] Clean up Tramp version check
Date: Sun, 12 Jul 2020 14:54:57 -0500

[Message part 1 (text/plain, inline)]

> Thanks. However,
>
> > +  (let ((tramp-minimum-emacs-version "30.1"))
> > +    (should-error (tramp-check-version))))
>
> this does not work as expected. What is this check good for? I
> understand your intention, but do we need to test this case?

That test has already justified its existence, for it has revealed a
flaw in the implementation! TRAMP_EMACS_REQUIRED_VERSION was getting
substituted in two separate places, so tramp-check-version wasn't
checking against tramp-minimum-emacs-version, but rather a hardcoded
value. I've attached a new version of the patch. Hopefully this one is
right.

[0001-Clean-up-Tramp-version-check.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.