GNU bug report logs - #42237
[PATCH] Clean up Tramp version check

Previous Next

Full log

Message #13 received at 42237 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Nicholas Drozd <nicholasdrozd <at> gmail.com>
Cc: 42237 <at> debbugs.gnu.org, tramp-devel <at> gnu.org
Subject: Re: [PATCH] Clean up Tramp version check
Date: Sun, 12 Jul 2020 15:48:40 +0200

Nicholas Drozd <nicholasdrozd <at> gmail.com> writes:

Hi Nicholas,

> This turned out to be quite a piece of code indeed. I think this
> change respects all the existing requirements. As I said before, this
> shouldn't change any behavior, apart from adding the new function and
> variable. Feel free to reject.

Thanks. However,

> +  (let ((tramp-minimum-emacs-version "30.1"))
> +    (should-error (tramp-check-version))))

this does not work as expected. What is this check good for? I
understand your intention, but do we need to test this case?

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.