From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Nicholas Drozd Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jul 2020 22:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 42237@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159407401013153 (code B ref -1); Mon, 06 Jul 2020 22:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jul 2020 22:20:10 +0000 Received: from localhost ([127.0.0.1]:35054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsZT8-0003Q4-69 for submit@debbugs.gnu.org; Mon, 06 Jul 2020 18:20:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:57190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsZT4-0003Pt-FH for submit@debbugs.gnu.org; Mon, 06 Jul 2020 18:20:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsZT4-0005CK-4k for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 18:20:06 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:40940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsZT1-0001tr-6V for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 18:20:05 -0400 Received: by mail-ej1-x629.google.com with SMTP id o18so40031218eje.7 for ; Mon, 06 Jul 2020 15:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=mRqqDbZY5pf1osbuWNAte/38LEzOFHoK1o9ojL2rW0Y=; b=ifO2vvK37SAolgNLpBnIBPOxlkwIgkfRSctRr44KaT/ziaSv2opedZzWb41wFWN5r1 6DFA/0HaSWhSyRaR4z7jH2G4NaYYhNO3SuSoTOKaD3b1ybxjODEEdmwC+LMCSM0+mQ+/ e/Ih/jb4LoZBoUWSR01iVJ/Kl8U5c9KuqdmAQaT7EA/BYS3SXIW2xTbxzLOryDJa5y4L d3YRq68zrdDodAKW5Vn6rhOCP+vLRkiI4wjY19ln+VFTP8z/GZ2jBDZ9rKQ2Zv1CMe3M ClJ0lKhkJgdtjKGs3f3YZkXMX7LVfpWU+UjVcjZ+asaCVAmZgW+/ULGo25YGMRzE1KQm 52MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mRqqDbZY5pf1osbuWNAte/38LEzOFHoK1o9ojL2rW0Y=; b=elC3jj8ShZi3VPK+A29VsoKTh6ohUSuZ7T8IM/RLCg87L7Yw84jtZvvBIe8I/s/MOw fBkMRCK1301NIcrd6BwWbVw7NqcWGZdIaqWsLQ/pvxLqYBO9Ap8WgWTIB0dGy/ZCc94C sAM0qZ1yM0JIKRuKysxeDI6YdC+xR0nJwL1R3ttcFiZJK+JMHFFx/Ulj5p9xsv8QrViP 17rCKvAZGHh0VWeQVpGczWRk/6Qm8ilBRuPuvRsgfSPE9KDf0SopAs214e7ZLxO4LPaR hBNL2lYon1QZwmcFkJedC7LcxPhYifoSIJiVSybT1vVtY7Kbd9mV/56EJy1zwGFTrKdM ATQg== X-Gm-Message-State: AOAM530sCtGPr3doylZE3dWuJimoBMKDG18oy+3oaOVQmeZZHA8zzebX 4wRQVy6eIl1lBI7FRhT9yeKeG2URYILAZCheYYY+TLWe X-Google-Smtp-Source: ABdhPJxNG2ntYgccv6ArY5Ywaa328xc0dPoj1W7t4zFqA6aC+3r2pC4UUKsoDRoo8eOnQh1XtGOEcJa01ExRPlMuzDY= X-Received: by 2002:a17:906:3009:: with SMTP id 9mr28678609ejz.220.1594074000662; Mon, 06 Jul 2020 15:20:00 -0700 (PDT) MIME-Version: 1.0 From: Nicholas Drozd Date: Mon, 6 Jul 2020 17:19:48 -0500 Message-ID: Content-Type: multipart/mixed; boundary="0000000000008e469a05a9cd4615" Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=nicholasdrozd@gmail.com; helo=mail-ej1-x629.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000008e469a05a9cd4615 Content-Type: text/plain; charset="UTF-8" I actually saw the "not fit for" error message in the wild. The source looked a little strange, so I cleaned it up. This shouldn't change any behavior. --0000000000008e469a05a9cd4615 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Clean-up-Tramp-version-check.patch" Content-Disposition: attachment; filename="0001-Clean-up-Tramp-version-check.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcb2d6dw0 RnJvbSAzNzE2OWU1NDkwOTRlYTQyNmQ2NDI5ZjA4ODUxNWU1ZmM0MTY3ODVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCA0IEp1bCAyMDIwIDExOjQyOjQ5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gQ2xl YW4gdXAgVHJhbXAgdmVyc2lvbiBjaGVjawoKKiBsaXNwL25ldC90cmFtcHZlci5lbAoodHJhbXAt bWluaW11bS1lbWFjcy12ZXJzaW9uLCB0cmFtcC1jaGVjay12ZXJzaW9uKTogTmV3IGNvbnN0YW50 LCBuZXcgZnVuY3Rpb24KKiB0ZXN0L2xpc3AvbmV0L3RyYW1wLXRlc3RzLmVsCih0cmFtcC10ZXN0 NDYtdmVyc2lvbik6IE5ldyB0ZXN0Ci0tLQogbGlzcC9uZXQvdHJhbXB2ZXIuZWwgICAgICAgICB8 IDE2ICsrKysrKysrKystLS0tLS0KIHRlc3QvbGlzcC9uZXQvdHJhbXAtdGVzdHMuZWwgfCAgOCAr KysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L3RyYW1wdmVyLmVsIGIvbGlzcC9uZXQvdHJhbXB2ZXIu ZWwKaW5kZXggOGQyMTEzM2IzYi4uNDJkOTg0ZGFlMyAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvdHJh bXB2ZXIuZWwKKysrIGIvbGlzcC9uZXQvdHJhbXB2ZXIuZWwKQEAgLTY5LDEyICs2OSwxNiBAQCB0 cmFtcC1yZXBvc2l0b3J5LXZlcnNpb24KIAkgICAoZW1hY3MtcmVwb3NpdG9yeS1nZXQtdmVyc2lv biBkaXIpKSkpCiAgICJUaGUgcmVwb3NpdG9yeSByZXZpc2lvbiBvZiB0aGUgVHJhbXAgc291cmNl cy4iKQogCi07OyBDaGVjayBmb3IgRW1hY3MgdmVyc2lvbi4KLShsZXQgKCh4ICAgKGlmIChub3Qg KHN0cmluZy1sZXNzcCBlbWFjcy12ZXJzaW9uICIyNS4xIikpCi0gICAgICAib2siCi0gICAgKGZv cm1hdCAiVHJhbXAgMi41LjAtcHJlIGlzIG5vdCBmaXQgZm9yICVzIgotICAgICAgICAgICAgKHJl cGxhY2UtcmVnZXhwLWluLXN0cmluZyAiXG4iICIiIChlbWFjcy12ZXJzaW9uKSkpKSkpCi0gICh1 bmxlc3MgKHN0cmluZy1lcXVhbCAib2siIHgpIChlcnJvciAiJXMiIHgpKSkKKyhkZWZjb25zdCB0 cmFtcC1taW5pbXVtLWVtYWNzLXZlcnNpb24gIjI1LjEiCisgICJUaGUgbWluaW11bSBFbWFjcyB2 ZXJzaW9uIHJlcXVpcmVkIGJ5IFRyYW1wLiIpCisKKyhkZWZ1biB0cmFtcC1jaGVjay12ZXJzaW9u ICgpCisgICJFcnJvciBpZiBgZW1hY3MtdmVyc2lvbicgaXMgbGVzcyB0aGFuIGB0cmFtcC1taW5p bXVtLWVtYWNzLXZlcnNpb24nLiIKKyAgKHdoZW4gKHN0cmluZy1sZXNzcCBlbWFjcy12ZXJzaW9u IHRyYW1wLW1pbmltdW0tZW1hY3MtdmVyc2lvbikKKyAgICAoZXJyb3IgIlRyYW1wIDIuNS4wLXBy ZSBpcyBub3QgZml0IGZvciAlcyIKKyAgICAgICAgICAgKHJlcGxhY2UtcmVnZXhwLWluLXN0cmlu ZyAiXG4iICIiIChlbWFjcy12ZXJzaW9uKSkpKSkKKworKHRyYW1wLWNoZWNrLXZlcnNpb24pCiAK IDs7IFRyYW1wIHZlcnNpb25zIGludGVncmF0ZWQgaW50byBFbWFjcy4gIElmIGEgdXNlciBvcHRp b24gZGVjbGFyZXMgYQogOzsgYDpwYWNrYWdlLXZlcnNpb24nIHdoaWNoIGRvZXNuJ3QgYmVsb25n IHRvIGFuIGludGVncmF0ZWQgVHJhbXAKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9uZXQvdHJhbXAt dGVzdHMuZWwgYi90ZXN0L2xpc3AvbmV0L3RyYW1wLXRlc3RzLmVsCmluZGV4IDFmMjRiYTI3ODYu LmZmMTEyZTljODIgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9uZXQvdHJhbXAtdGVzdHMuZWwKKysr IGIvdGVzdC9saXNwL25ldC90cmFtcC10ZXN0cy5lbApAQCAtNjU1Nyw2ICs2NTU3LDE0IEBAIHRy YW1wLXRlc3Q0NS11bmxvYWQKIAkgIChpZ25vcmUtZXJyb3JzIChhbGwtY29tcGxldGlvbnMgInRy YW1wIiAoc3ltYm9sLXZhbHVlIHgpKSkKIAkgIChlcnQtZmFpbCAoZm9ybWF0ICJIb29rIGAlcycg c3RpbGwgY29udGFpbnMgVHJhbXAgZnVuY3Rpb24iIHgpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IHRy YW1wLXRlc3Q0Ni12ZXJzaW9uICgpCisgICJDaGVjayB0aGF0IHRoZSB2ZXJzaW9uIGNoZWNrIGNo ZWNrcyBvdXQuIgorICAodHJhbXAtY2hlY2stdmVyc2lvbikKKyAgKGxldCAoKGVtYWNzLXZlcnNp b24gIjI0LjMiKSkKKyAgICAoc2hvdWxkLWVycm9yICh0cmFtcC1jaGVjay12ZXJzaW9uKSkpCisg IChsZXQgKCh0cmFtcC1taW5pbXVtLWVtYWNzLXZlcnNpb24gIjMwLjEiKSkKKyAgICAoc2hvdWxk LWVycm9yICh0cmFtcC1jaGVjay12ZXJzaW9uKSkpKQorCiAoZGVmdW4gdHJhbXAtdGVzdC1hbGwg KCZvcHRpb25hbCBpbnRlcmFjdGl2ZSkKICAgIlJ1biBhbGwgdGVzdHMgZm9yIFxcW3RyYW1wXS4K IElmIElOVEVSQUNUSVZFIGlzIG5vbi1uaWwsIHRoZSB0ZXN0cyBhcmUgcnVuIGludGVyYWN0aXZl bHkuIgotLSAKMi4xNy4xCgo= --0000000000008e469a05a9cd4615-- From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jul 2020 07:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicholas Drozd Cc: 42237@debbugs.gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159410635031883 (code B ref 42237); Tue, 07 Jul 2020 07:20:02 +0000 Received: (at 42237) by debbugs.gnu.org; 7 Jul 2020 07:19:10 +0000 Received: from localhost ([127.0.0.1]:35412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jshsk-0008IB-Hu for submit@debbugs.gnu.org; Tue, 07 Jul 2020 03:19:10 -0400 Received: from mout.gmx.net ([212.227.17.22]:52207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jshsh-0008Hl-Qa for 42237@debbugs.gnu.org; Tue, 07 Jul 2020 03:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594106341; bh=h77axYdSxd6r2A1lqO3uEyl1ah6h7wDMfeEVkFXKOmg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lr83p0TREhc50KPC85hLXyXwodz+Nz5FAHGVlKWUjHpjvYK1sv6pbfCqCPnxaFwDL Y1mJb6g6vlme4h0o+pQhbX0iGbChcXO0gk3f1o5UqAlWx0o91vKUnFk2EIX787zhzq 2ePmp+3PJqoKL7dbJ300xEGprXDQSc3Zjf98Z0EA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.118.167]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N33Ib-1ktrPU0P2D-013PdE; Tue, 07 Jul 2020 09:19:01 +0200 From: Michael Albinus References: Date: Tue, 07 Jul 2020 09:19:00 +0200 In-Reply-To: (Nicholas Drozd's message of "Mon, 6 Jul 2020 17:19:48 -0500") Message-ID: <87sge3g5cr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:7pNpqMDCpwIR/wTg7zbYpOJ8eIvuMLEmTSeAeoP5v6mUeZq3l1y miXXcCJzRt2l0alnZtalokvoCWGIiAnyXeqT+nz1LporPySKcptuC2U2H2sw5jq+FOpksLH Q3k2n645lqh6HfcSI6U04W3Hid+F4v37dKEDKDCxmW6siya44OTuoavW6Cy/cDeLBNzWgb0 te1v0QLYK/9dFczLS5Mog== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7f4OmduElhM=:r4zWH8XKwVi3hUrCEL2Wxm R0P8P6Qij1E243vWpWmVMi5kLctKpB0ioCSqVJj5n+kiadWwOD5seRGVtkdRI0ElpSQPMoYX7 tMVxci9a7TKbNn2ylxtaipXlGPJ2qHKdR36N0MvEYI9Qa/I9nlIAWrGqY4wiKUeIlozQXRi34 vVcbQxZ12ZawrrMPOJ/I+gceBq/gx/k/OV22aZ3GqvmPZJtwBcHjLK7mOLDqKhRLpvyBNNkWa DsxJ9OOyGP9/AZZS+E8V8X3EqQMCAiYBppLb7xuk6fJAAgDhU0eWT5E1Tj8FuMHLJPqCVPfrV l8JNJ+ICCCT3WhR297IAlMY8C5usumm8qXfKnAA7+ht28NIaloVGNko7MZGjC/DygvyOPtbSM HC8O0WeIWTKZhzqZokWWcnZ+ZaVtVjZ38+icAr+gYtAyWBKoyM/X6nx4VyhzgrI1ZO+g2NkOX CaRNAn6VSup9hUhVa4gOIj6DtUR5synzpR6bb75o/0s0p241dvD29hrhFspU0NS/+vmUI16ys Z5TYdOLoFl4hiC1z0+5Gpehk8PUgiHBEvYtEi+9EDTYC8jlJOi3IeH4SHYJov9SIeJvsE4sU7 Tb4WkCkTwPxLsJufXGY6SJmntz7U186GBayaHYjp2nSvJfXFXNSXtNhsoWykfx5HgwZxE81PV wdRFjPz1/PBHogkKZPUk+TY+OtFKgm4TGWeWtgSmuvFXQsG/WCZ3dR8X0CMstzaczWFadp/PV Rc9UGoJxHPVOQo6XlMfYoBA25m4sNrEbVrOPkkQDKGCWROLdDjd202lZ4xhdZ0SVLrkAz2JzR LCgYCjiWkFLbcSuzgtqZk5187FOXbry+d/zUvwny+cQwnG867nAeyEg3tBiRc4FE6VHLRrBAH pQll5iM/tMRlmdtRKxKOFHImXEyPODwp8P0tpLTXvNyImynOTA0xXjap/OB2A03qqSuOwZqQo WeZAEAY4gPzj+KkW/DQYmyf645zo+PzLxc9meKIA2ERpL57XT0Dk7vCVaO53lhOYFZE8nV+ZK yv0wuAJyRA/Kl5NJ8qNKIHuPPU/F7dS/QclDi0OFi5BKPDi6KUddXHXZV+onWyFeOrJ+6dEXv uqBkaOQbUUg3jWNlY2NdCSc/od3fqWRrQqLg45U+iuJOdWAxnj65ZcH+C5iB5q+YnyFZVXaHR VPk/2Duns0CapoDiBEXRA34JNBBshv6jU9XDS8CLUDdgVnBB0nm52RYMAXaMMGZB5RguvKD3z kmB8CI7/LMuB7j8mXomk39n08sUI5d2ofk/4agA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicholas Drozd writes: Hi Nicholas, Thanks for working on Tramp. > I actually saw the "not fit for" error message in the wild. The source > looked a little strange, so I cleaned it up. This shouldn't change any > behavior. Well, this code snippet has its history. Initially, it was (and still is) used in the Tramp git repository, file aclocal.m4. And that code snippet is also propagated to trampver.el via template trampver.el.in. If you want to improve the code, please change only these two files. The Tramp git repository is located at (see also the Tramp manual). > +(ert-deftest tramp-test46-version () > + "Check that the version check checks out." > + (tramp-check-version) > + (let ((emacs-version "24.3")) > + (should-error (tramp-check-version))) > + (let ((tramp-minimum-emacs-version "30.1")) > + (should-error (tramp-check-version)))) This is a nice extension :-) From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 07 03:21:45 2020 Received: (at control) by debbugs.gnu.org; 7 Jul 2020 07:21:45 +0000 Received: from localhost ([127.0.0.1]:35416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jshvF-0008NI-0g for submit@debbugs.gnu.org; Tue, 07 Jul 2020 03:21:45 -0400 Received: from mout.gmx.net ([212.227.17.21]:51335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jshvA-0008N2-Ox for control@debbugs.gnu.org; Tue, 07 Jul 2020 03:21:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594106495; bh=omqnfoNbIiYO9NVLBH3KK8Ni9vYlmIPo9NaDQtx2WNM=; h=X-UI-Sender-Class:Date:To:From:Subject; b=Nnb++iEyBbmSt6WSyS4nizdtdV0y8+BwzP+EXOT2jzx2nH9ukhaebua/Fx2v7doMD EmUckL8wQIezv8t0n2amkAvnsdNQwiJmkpaZn8A7/t3dWcIGUhU+FMzm8D4Go1fwEN +GuEzRiDep8VpR48wjyAiv+tvPyj+Pd0FwQDxN4k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.118.167]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MY6Cb-1kOwfj32hZ-00YV3V for ; Tue, 07 Jul 2020 09:21:34 +0200 Date: Tue, 07 Jul 2020 09:21:34 +0200 Message-Id: <87r1tng58h.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #42237 X-Provags-ID: V03:K1:dSQjMJy1rHIXmlLvxq7v6i6OyEQ5EN/YGRLfaQi4eTMiorfdD+5 7+0AO2YNDNl8qhVg1VFd4+9A8U24O8Bl7KKdOeDxKV7go4nFvA+/W3Lc4wP8a6TDXt4wQfX Ef4ncrXulvJOiPfchtZGTDYDV7RLnz49HovndIr8QsYqUKHkMF1klc8v6wRS2jO64Yrg2N5 t8TCUxpFlwgjA84/Y3Qtw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:d2dn4gfz08A=:upXKLp1/pkREQX+jIG3f6a /UE0NVAd5g6BAO2Gy+unjmVaZhtFBypiwzmuDWeAMhK/QE/GNZfdjGnYBxk7WMpJlxpCW4uFL lxLWVNJ+COpkbadv6/Bvxan9ybxP6ZpYU7CPH/vvndr9mYKznW7jGlR+LS3YsC3ZWq/GVBKLm bHIMU1BiSmLHN9ZNG+/77pyVd29ydnm8Bs5Jx0sOtNjZ1Mnc3adYeMCFe3clr6VO5wftXoFMU AFNAZkBicyLOasHirtpCu1QohXWfJhf9r1u53WPGQ3DlJOFpx1kxVjbKVE3Y1XU3Vynt56cLw YZnepIPK21bu6/ctpChI3H3MYChRCtHQHxvsukOWmekwbJF+Phcl6Qtdi6XHrlZkWnDVJ2yvZ bnFks5FrnU0XY+9dk2qyCaa/jdDriaQ6dN9b9pU3v8FE8j+Ob/g/O9y0xepwBiDbi4fDl63Ai oVOhbFvx/uKwWKi2neES+OjnwVuN5ikVFbjDZNSrbOAU1QZqmmSThWAkz3FpWxqmU1E4mhve4 efkQ71h/bruDgI74Bgy5fH9uDN1g3AVt5r2m91L8jUDHPLeQ4LaHTAloR9xkjSOL+3BQ9Mfn1 pcRcz0XBaKR+QGVZKRTTc8FWsdrRv4SKGO/DKiCiyPfhpmx6O8YQx5PGBFBskU5Pr2ASutzhd 20v6QNgfg8lhj16XIPYzEw41OT8g0r6VlyRxu/yNqfIZRL2C3bssxDnkPCJeFJ+NYhW7Az2na 8ffODoQlCDFUrTT2xFn3V1wS+RilOMUK5d/HlD8Lc32R0ENSDYJwDYWf1Swd4AQlkXX0jkU+T E6U0OHCfwSIsKxcpL99hYgolO99uNEW6fq13cOSamJmcUa9lF6Sr8s/J0yIvUtj+1mN704lV0 tuMrMn9ZgSmCU3V+N7YDSqiAYyMWM4INL+b17lwySdbSXY/leGaeXHJciDA2uMq8PkNFuP2se LFg3xJ5lcOFjcRXCPldKjGQJWpmq2aSiagqC141Fdg8Luf7Zpp97u4AOp+2O9VqiW2KSwBWgr DmdRezEVY45yMTLCTeTs5Gqh0jZsI26qUqNkLmGnO2EOc5qMSQ5xBCj0RVD9M3mQtkBRzFo2j dO63BgOJWY9peAbw7CmlnXUdMb0exy/XkfVBodNbEa2BKO/VbGblIqZNlgHfNYl49QWgOs2u0 CAAl3Fik3zT4ryHm6wAncFkaPhV/j6E5+K7WsDSKAIdHmwQJ9aivlmLmuE7g33vx/WmG/c84K GLL8V+4UY0iysQ0NRsC0b1n44f4j64c5BQ91UMg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) severity 42237 minor quit From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jul 2020 13:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicholas Drozd Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159456173222044 (code B ref 42237); Sun, 12 Jul 2020 13:49:01 +0000 Received: (at 42237) by debbugs.gnu.org; 12 Jul 2020 13:48:52 +0000 Received: from localhost ([127.0.0.1]:45592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jucLb-0005jU-AZ for submit@debbugs.gnu.org; Sun, 12 Jul 2020 09:48:51 -0400 Received: from mout.gmx.net ([212.227.15.19]:57621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jucLY-0005jE-8z for 42237@debbugs.gnu.org; Sun, 12 Jul 2020 09:48:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594561721; bh=LAKZ9BFFlu0SXQJq40wxYXKH+igR95AdchiOR3OkeSc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OVAF1hG6OQtVMIN6hmGuvAuZP2qhjeskVa9WHmx9Y0wLzpgDO1ijJnfW/7aPGIN3L m4ceSyffOuVBsWWnmRJmYRbiTAvC7umbg9XoExyqROEb/Efr8nTp/o4A1PSqyxs7Ad OhSnY6NL/B5Lc03bdTskeDVa6ywPnCVqmMNQ9r8c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.47.60]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M1poA-1jsQU51j5c-002Gna; Sun, 12 Jul 2020 15:48:41 +0200 From: Michael Albinus References: Date: Sun, 12 Jul 2020 15:48:40 +0200 In-Reply-To: (Nicholas Drozd's message of "Sat, 11 Jul 2020 12:12:19 -0500") Message-ID: <87tuyczvwn.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ReDXtU6aeUuaUyRuQvBJ4CFg/B90NuHExk4RyGzg3IC0dU2iYOq DCEZL962Vu9TFv5QyuNrcfIurLhbArZoXHBS3rtek4WT5dhk3Zn6s6TZ0pawylNtuYprCDW FhYH1wQgHT4WKx2/fDfIbdRw/qKEM81T8BXd9Q2tWl++RMMhYnGcLWPYot9E4m7BmNSdvi3 H60MRmtai64sDzBPn4Iiw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ekz5aguNIDA=:h5+4CN1v0ihNI3dobPqpRz FDI+R0EltxRUFZ1a+rOdSN4PycJBgiJNxHzle5xUR7siXi6SLL+eQFfQXCgQV7/adjrUt7RKZ 7ZozwSMlECc8SvqMPxUp9Bv5LVuUPhT40JWDSEqmsnal0rOgC/7mhR2pa6rcsx2fwhBAuYIXR edzpZ+sDDGCRWdsqEoQhbVICm4UYsOCDBMFZlyCMydJfajC5R4EOUykS058kMbhTFVAXbOJ1J qUyiY7He7quSrw6d6zDGa9RTVGMijNnaHr2pgyzrDjBamxwY+uwFXDiIqBqjrRnXUHOlzqXsO sM6CrGNuSoSxCtHPjIe4ip55y5ILNkRl7CmU6nEUVsBUWCYCvV7wQPygXv+MxillBN297ItN1 4Kmh6Xv7JStgFKLvRcT2vscxzMB3lZ82Sib1kvJgd8z4HePNLP+vOOZreTmuojUfqGi+oRhqE Hy+zF0PTsxec/Md8+jCHyStyuMCaHWodQq9/xzPns5WfFaXkXO8h88w+uRxbBZ0NXKr9QuUyy N4kJ4q09B5s4tZK4vLL0fV7xmnYnxh+/I7Poy/lnSRTUH6bLob3W5+wcH33jGQThhaDM7hzEA oh44YeKqioIuqtHKfJ6EjK8/plrsHaJlU0oymiTyUwzuEynuwaiTgjsqLCi7+w5ibs7iM8rzj vGwg0cJPC0Tezg+gl2loeamAVqeaEPag//OaYX8FM0FN9qivUrOccfza9rh3XNqkEbwg8ZZfX 1EnvGM5yMnoKNZvGkCsCDBEctEAr7IAvcWKhCzf6w0l+vHfhckbISTwopKsq1NF7pjFOvz0MA zBg0ZZi/vyYSCLEt5jVyNjogSDfCInb5WkziRonjdP5zerF0/9dmw4v/y9tGh48brZVZEQCVw CjSJW919oXGqWd7dPYJ+pXsP783pZVip2HAapu7zaw57ytMUdhoXYN8EKAvO8bCEzoOZBO7Xt ZyqgD3q9n8KPxSVI0w2o+bMFdIrWH/KUTFCVJJBRVEKw8RTWppeTLSOS5Y46ZAUVTyyxxzfiv hT4AENZ1U27FFwlLZHvp7CXTHEveNLHV2GLMGNnPkvbsysgREvTW/7JNWqJVzlEs8/ep8Hauv K6lqjgpKZ3VGmPZQSfUE0jg8eNeyI+Da0anrsVyft94vBto7CSCwT+An09LG0NWDz0vMxw7NJ p/uppvMqURoazSOpGhbvnxsQDfdcI2upcQorUlpWjICa81J4q6IZX6hyeO7vJGYvRukJWfvoC l4Snx3P3Foy0FsnxwzM1BCXAdsO6im/p93Dy+3w== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicholas Drozd writes: Hi Nicholas, > This turned out to be quite a piece of code indeed. I think this > change respects all the existing requirements. As I said before, this > shouldn't change any behavior, apart from adding the new function and > variable. Feel free to reject. Thanks. However, > + (let ((tramp-minimum-emacs-version "30.1")) > + (should-error (tramp-check-version)))) this does not work as expected. What is this check good for? I understand your intention, but do we need to test this case? Best regards, Michael. From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Nicholas Drozd Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jul 2020 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.1594583718363 (code B ref 42237); Sun, 12 Jul 2020 19:56:02 +0000 Received: (at 42237) by debbugs.gnu.org; 12 Jul 2020 19:55:18 +0000 Received: from localhost ([127.0.0.1]:46807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jui4E-00005m-3Y for submit@debbugs.gnu.org; Sun, 12 Jul 2020 15:55:18 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:36569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jui4C-00005Y-At for 42237@debbugs.gnu.org; Sun, 12 Jul 2020 15:55:17 -0400 Received: by mail-ed1-f44.google.com with SMTP id dg28so9814008edb.3 for <42237@debbugs.gnu.org>; Sun, 12 Jul 2020 12:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qvXFfC4p8jlnqaTO1fnG9Oj71J3FomnbyY7mfBd0aj8=; b=hMdqVphtdP9odsizF+9+yQr16Fm/lbUaOJ+LK0Jq6zcOy1DpbkD3J1fKh/G1UD8SFT bBrwtyKjV2AXxjN9sjpCrxEV/MyLFkTl5E9Zm/BCHPstcT1p8PczFLDMxVn3cEW3nnZe wN5bv1G5LHPxWRf51RgsLj9LCWIHr1lziXU4CXFRrcOAsYB4F4dYBrUR5WBVp1f/bOpm gGoFdrU8VPtHpnQ8TjtF0X4zJAc5B6pO1xt+vboNg+gtes15CoskZTZrV/p3dmd/ra06 B9zRiJnx+QQAlfuoavyN2DSXVModS0YFaWbhHYYVqsmgtXdBPUwpP8Jt+eeClggReyIe PUyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qvXFfC4p8jlnqaTO1fnG9Oj71J3FomnbyY7mfBd0aj8=; b=h677SW46dXBiP9y1efR5JuOWlP2NHjabaJ48vDbbFYW1vT6Wf2RXvGR/opo5awggEt owbdWGLo1eFUdf8/iUXLIG5LtTHA5DbQ7FvY1U7iwCFtlLeqUC/ztwCrmg85F0npKb0A OkY7pms9qG13FUcPZrKLIrpj57KkUgKvGdZlvu9kJOaubLAxaq3MTwvGheN+KbIZwU9L 0PEVHsFsuartFQtuzy/wg4a/4XWktZ0ofPuokAHCBTQOTTXAhLPk2PeJnfw7rRJn4c3m o2cLN+qRxf0O4hIwl1H5jw4gdVNnhApAlUAmsoXkigrmhg5TBXZf+UUY/hDdaHWqQ//g 0syA== X-Gm-Message-State: AOAM530Yt1kmG8pZXPn4ettNg8zN4lTUfSyByrvH5+S9Kb/VZjGhzI4W VeMPSFXlebPluwY6wAVXyZZl7RlibgHm0rqth+Q= X-Google-Smtp-Source: ABdhPJxb3tLoR1ZnTV6ClMQivr53hhW84mljAbot7YPtme1qz7JpfcjLf0tcqywUvDY93B44WjXfeC490+vruI/3wt0= X-Received: by 2002:a50:ee07:: with SMTP id g7mr74584805eds.320.1594583710288; Sun, 12 Jul 2020 12:55:10 -0700 (PDT) MIME-Version: 1.0 References: <87tuyczvwn.fsf@gmx.de> In-Reply-To: <87tuyczvwn.fsf@gmx.de> From: Nicholas Drozd Date: Sun, 12 Jul 2020 14:54:57 -0500 Message-ID: Content-Type: multipart/mixed; boundary="0000000000009dea7405aa43f3d9" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009dea7405aa43f3d9 Content-Type: text/plain; charset="UTF-8" > Thanks. However, > > > + (let ((tramp-minimum-emacs-version "30.1")) > > + (should-error (tramp-check-version)))) > > this does not work as expected. What is this check good for? I > understand your intention, but do we need to test this case? That test has already justified its existence, for it has revealed a flaw in the implementation! TRAMP_EMACS_REQUIRED_VERSION was getting substituted in two separate places, so tramp-check-version wasn't checking against tramp-minimum-emacs-version, but rather a hardcoded value. I've attached a new version of the patch. Hopefully this one is right. --0000000000009dea7405aa43f3d9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Clean-up-Tramp-version-check.patch" Content-Disposition: attachment; filename="0001-Clean-up-Tramp-version-check.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcjhx9l00 RnJvbSAxYjQ3ZmQ4NWZlZjI1OTBhN2RhMjUyZDBhMmY1ZDlkY2MzYWNlODFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAxMSBKdWwgMjAyMCAxMDowMjoyNyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIENs ZWFuIHVwIFRyYW1wIHZlcnNpb24gY2hlY2sKCiogYWNsb2NhbC5tNAooVFJBTVBfRU1BQ1NfVkVS U0lPTl9DSEVDSyk6IFJld3JpdGUKKiB0cmFtcHZlci5lbC5pbgoodHJhbXAtbWluaW11bS1lbWFj cy12ZXJzaW9uKTogTmV3IHZhcmlhYmxlCih0cmFtcC1jaGVjay12ZXJzaW9uKTogTmV3IGZ1bmN0 aW9uCih0cmFtcC10ZXN0cy5lbCk6IE5ldyB0ZXN0Ci0tLQogYWNsb2NhbC5tNCAgICAgICAgICB8 IDE3ICsrKysrKysrKysrKystLS0tCiBsaXNwL3RyYW1wdmVyLmVsLmluIHwgIDQgKy0tLQogdGVz dC90cmFtcC10ZXN0cy5lbCB8ICA4ICsrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDIyIGluc2Vy dGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYWNsb2NhbC5tNCBiL2FjbG9j YWwubTQKaW5kZXggZDRhODJjZjkuLjQ5NDBmYmVmIDEwMDY0NAotLS0gYS9hY2xvY2FsLm00Cisr KyBiL2FjbG9jYWwubTQKQEAgLTc1LDEwICs3NSwxOSBAQCBBQ19ERUZVTihBQ19FTUFDU19JTkZP LCBbCiAgIEFDX1NVQlNUKFRSQU1QX0VNQUNTX1JFUVVJUkVEX1ZFUlNJT04pCiAgIGRubCBTdGFy dGluZyB3aXRoIEVtYWNzIDI2LjEsIHdlIGNvdWxkIHVzZSBgc3RyaW5nLXZlcnNpb24tbGVzc3An LgogICBUUkFNUF9FTUFDU19WRVJTSU9OX0NIRUNLPSJcCi0gIChpZiAobm90IChzdHJpbmctbGVz c3AgZW1hY3MtdmVyc2lvbiBcIiR7VFJBTVBfRU1BQ1NfUkVRVUlSRURfVkVSU0lPTn1cIikpCi0g ICAgICBcIm9rXCIKLSAgICAoZm9ybWF0IFwiJHtQQUNLQUdFX1NUUklOR30gaXMgbm90IGZpdCBm b3IgJXNcIgotICAgICAgICAgICAgKHJlcGxhY2UtcmVnZXhwLWluLXN0cmluZyBcIlxcblwiIFwi XCIgKGVtYWNzLXZlcnNpb24pKSkpIgorKHByb2duICA7IDwtLSBkb24ndCB0b3VjaCB0aGlzIHBy b2duCisgIChkZWZjb25zdCB0cmFtcC1taW5pbXVtLWVtYWNzLXZlcnNpb24gXCIke1RSQU1QX0VN QUNTX1JFUVVJUkVEX1ZFUlNJT059XCIKKyAgICBcIlRoZSBtaW5pbXVtIEVtYWNzIHZlcnNpb24g cmVxdWlyZWQgYnkgVHJhbXAuXCIpCisKKyAgKGRlZnVuIHRyYW1wLWNoZWNrLXZlcnNpb24gKCkK KyAgICBcIkVycm9yIGlmIGBlbWFjcy12ZXJzaW9uJyBpcyBsZXNzIHRoYW4gYHRyYW1wLW1pbmlt dW0tZW1hY3MtdmVyc2lvbicuXCIKKyAgICAocHJvZ24gIDsgPC0tIGRvbid0IHRvdWNoIHRoaXMg cHJvZ24KKyAgICAgICh3aGVuIChzdHJpbmctbGVzc3AgZW1hY3MtdmVyc2lvbiB0cmFtcC1taW5p bXVtLWVtYWNzLXZlcnNpb24pCisgICAgICAgIChlcnJvciBcIiR7UEFDS0FHRV9WRVJTSU9OfSBp cyBub3QgZml0IGZvciAlc1wiCisgICAgICAgICAgICAgICAocmVwbGFjZS1yZWdleHAtaW4tc3Ry aW5nIFwiXG5cIiBcIlwiIChlbWFjcy12ZXJzaW9uKSkpKQorICAgICAgXCJva1wiKSkKKworICAo dHJhbXAtY2hlY2stdmVyc2lvbikpIgogICBBQ19TVUJTVChUUkFNUF9FTUFDU19WRVJTSU9OX0NI RUNLKQogCiAgIEFDX01TR19DSEVDS0lORyhbZm9yICRFTUFDUyB2ZXJzaW9uXSkKZGlmZiAtLWdp dCBhL2xpc3AvdHJhbXB2ZXIuZWwuaW4gYi9saXNwL3RyYW1wdmVyLmVsLmluCmluZGV4IGY0ODdi MzMyLi4wNGRkNDAwNiAxMDA2NDQKLS0tIGEvbGlzcC90cmFtcHZlci5lbC5pbgorKysgYi9saXNw L3RyYW1wdmVyLmVsLmluCkBAIC02OSw5ICs2OSw3IEBACiAJICAgKGVtYWNzLXJlcG9zaXRvcnkt Z2V0LXZlcnNpb24gZGlyKSkpKQogICAiVGhlIHJlcG9zaXRvcnkgcmV2aXNpb24gb2YgdGhlIFRy YW1wIHNvdXJjZXMuIikKIAotOzsgQ2hlY2sgZm9yIEVtYWNzIHZlcnNpb24uCi0obGV0ICgoeCBA VFJBTVBfRU1BQ1NfVkVSU0lPTl9DSEVDS0ApKQotICAodW5sZXNzIChzdHJpbmctZXF1YWwgIm9r IiB4KSAoZXJyb3IgIiVzIiB4KSkpCitAVFJBTVBfRU1BQ1NfVkVSU0lPTl9DSEVDS0AKIAogOzsg VHJhbXAgdmVyc2lvbnMgaW50ZWdyYXRlZCBpbnRvIEVtYWNzLiAgSWYgYSB1c2VyIG9wdGlvbiBk ZWNsYXJlcyBhCiA7OyBgOnBhY2thZ2UtdmVyc2lvbicgd2hpY2ggZG9lc24ndCBiZWxvbmcgdG8g YW4gaW50ZWdyYXRlZCBUcmFtcApkaWZmIC0tZ2l0IGEvdGVzdC90cmFtcC10ZXN0cy5lbCBiL3Rl c3QvdHJhbXAtdGVzdHMuZWwKaW5kZXggNTE3MjIyMTAuLmYwZjhkMDc5IDEwMDY0NAotLS0gYS90 ZXN0L3RyYW1wLXRlc3RzLmVsCisrKyBiL3Rlc3QvdHJhbXAtdGVzdHMuZWwKQEAgLTY2NzAsNiAr NjY3MCwxNCBAQCBTaW5jZSBpdCB1bmxvYWRzIFRyYW1wLCBpdCBzaGFsbCBiZSB0aGUgbGFzdCB0 ZXN0IHRvIHJ1bi4iCiAJICAoaWdub3JlLWVycm9ycyAoYWxsLWNvbXBsZXRpb25zICJ0cmFtcCIg KHN5bWJvbC12YWx1ZSB4KSkpCiAJICAoZXJ0LWZhaWwgKGZvcm1hdCAiSG9vayBgJXMnIHN0aWxs IGNvbnRhaW5zIFRyYW1wIGZ1bmN0aW9uIiB4KSkpKSkpCiAKKyhlcnQtZGVmdGVzdCB0cmFtcC10 ZXN0NDctdmVyc2lvbiAoKQorICAiQ2hlY2sgdGhhdCB0aGUgdmVyc2lvbiBjaGVjayBjaGVja3Mg b3V0LiIKKyAgKHNob3VsZCAoc3RyaW5nLWVxdWFsICJvayIgKHRyYW1wLWNoZWNrLXZlcnNpb24p KSkKKyAgKGxldCAoKGVtYWNzLXZlcnNpb24gIjIwLjMiKSkKKyAgICAoc2hvdWxkLWVycm9yICh0 cmFtcC1jaGVjay12ZXJzaW9uKSkpCisgIChsZXQgKCh0cmFtcC1taW5pbXVtLWVtYWNzLXZlcnNp b24gIjQwLjEiKSkKKyAgICAoc2hvdWxkLWVycm9yICh0cmFtcC1jaGVjay12ZXJzaW9uKSkpKQor CiAoZGVmdW4gdHJhbXAtdGVzdC1hbGwgKCZvcHRpb25hbCBpbnRlcmFjdGl2ZSkKICAgIlJ1biBh bGwgdGVzdHMgZm9yIFxcW3RyYW1wXS4KIElmIElOVEVSQUNUSVZFIGlzIG5vbi1uaWwsIHRoZSB0 ZXN0cyBhcmUgcnVuIGludGVyYWN0aXZlbHkuIgotLSAKMi4xNy4xCgo= --0000000000009dea7405aa43f3d9-- From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jul 2020 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicholas Drozd Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159464559626802 (code B ref 42237); Mon, 13 Jul 2020 13:07:01 +0000 Received: (at 42237) by debbugs.gnu.org; 13 Jul 2020 13:06:36 +0000 Received: from localhost ([127.0.0.1]:47771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juyAG-0006yE-A9 for submit@debbugs.gnu.org; Mon, 13 Jul 2020 09:06:36 -0400 Received: from mout.gmx.net ([212.227.15.18]:34549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juyAB-0006xx-KL for 42237@debbugs.gnu.org; Mon, 13 Jul 2020 09:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594645585; bh=iJ/V1+osLtRPmQvsSg/Zbu31unarxrWG3RY1+C9Wz80=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Ka8t0LRAXS4RoE968aRGz7asyZrnEVZS6FnMpbHtskVmJwK6RTRGVrAn/0SnQzj84 bOuMjO2H5E+yd4genMUE+cPElx+heyQA30Xwk5hxfa4RKM/1ef8JNm0JtmTZkKt12R fxgJkB1qstJVw97pONh9PgQTyF46o9IMrCglhP4k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([178.20.93.90]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MIMbO-1k757M3vtM-00EQtg; Mon, 13 Jul 2020 15:06:25 +0200 From: Michael Albinus References: <87tuyczvwn.fsf@gmx.de> Date: Mon, 13 Jul 2020 15:06:23 +0200 In-Reply-To: (Nicholas Drozd's message of "Sun, 12 Jul 2020 14:54:57 -0500") Message-ID: <87lfjnzhrk.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:O72Cv8ydA/W0rUkpzTahCYMuWAxK1fQjX09HZ+IMu2g0X8psyaQ GwvRE5L31C5Pe/CqxTkqlXF0fciJi7OFF5bcNRntgrrO+AZS0W2Jr4d4SPG29VplGnUSp4j HBGebfwA0I811nqyl5NFTqWN/mvShBl7ldNR2wHwbQ5zgo3QbegUxYL2HEY78TRXwQ7yGLa 8co6A8/KBOpsdzXESWw5Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:blvvK4y5Mu4=:FhK+6BfYW36OSyPUMdG5bY eW0HgEYGdlzyVYGUQStK2a+YmuxulAPM/q9+b11mUMYBf19PIF4QPHFPV7yqrRE1Pj2dMl97k vm1cxidqsGVK5PJk+qb/VL8QX5j/gSXB/CeeGg3rzWI7ioXhJ/vEFKDrRANDi5hLxvdE2zq6P fK0kMr16r4LqZqa6P/SQxGu0mbmnt+IZyzXzBU6jr/rsWq6nE4Jjf0jZcEkPAgbpbsD1WQ67n IofRjGvK10D1nz/JQSANz/2vJ6FolHD7jI/6JwXUwX8i4WVUoNs832Hg3AkcJPRtgk1VcpSuy JWVUvzpqeoAscYmWyf1RvcuDCBvXWXN8jj6/byZgSJYYlOkjCA4WB+iQOmkTOOnzEEumYF/4Q EXEUg9MBzM1j5XK9YpAP5XsZ7CYChYuDHwx7zydGWsEEzIg5D7c74XNSSE3NWqBFifgc36RFp aM/WnoiryJOIb+sXkAgCt4eYZbiJs4l/Gq2vEftxYbqtogZdN1G4gvc07lOT0AkgwATsO4Z7y HD8OmNY/os5EK/Xn14riZVWNgsym9U/g51TLcv68oa0oCUwfmmccPUaGzpdnYmMGH1mW9R3zn GFOIPbe5lWyoMpDymZwufwIHYptlq4tM1kEkgy24hXAjmWIuALKLfh2qtx5e5ITW6JrddFCoY pZNQTJ6ENbOVRUpq2AInwXOgXoxNv0Io+e2gmvWk2JgFixq4/KAM5MLUBWW2t+s3J8vWlfYiy bJAXtmAwVWrs5m7A36jc7Ua9k35umQjWNHLGCgNIu3Yz8xhBmUr8VOdeTIelOjHRDr2MAD1Yo UCs701PvsCeGe/DNeyvUtkw2TA+QUuhY/o/limQGWhNGAbdP+S/VPOGhIetDFW2Ioak5Wf+PU OXHsOOFxJ/tac7faaE0Lxpoh3asDfbC1SoMpVe08Wy1Yr87ga4dqn+h3Im2bN0bQ8ec9PlBEM k1bHCDxYPd26el5PpgfrOOnS5aVqtAkXiLXFRRY/JzPwt0X2fkt7QVUkMGvqOavrAWmjQ2B4s oTGnKt9gx6p9gANWSGpggFCUED54ILPlhZBMZLFkZTVuOrQv9benTaroOHa5FzJfNMywnIurM FHeBfCF430XkIrYuff6rjF6oi6tjYLHt5RxayVGAGIWeiuxdPqxVUhOLqwcaRbi6zAkW48THD E4rL51WeBWgzX6B7JpcRZ0c+6FSTpsrxyCutC7hP1uxzFgkyPE4uu2OjcksLMQbKGMPrXau8k lK/MHQ3vwa614s+YeJNWTh7EwwKCb9DXvdaYslQ== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicholas Drozd writes: Hi Nicholas, > I've attached a new version of the patch. Hopefully this one is right. Still problems: =2D-8<---------------cut here---------------start------------->8--- # ./configure configure: Tramp 2.5.0-pre checking for gmake... no checking for make... make checking for reasonable make version... ok checking whether make sets $(MAKE)... yes checking for emacs... /usr/local/bin/emacs ./configure: command substitution: line 1880: unexpected EOF while looking= for matching `'' ./configure: command substitution: line 1881: syntax error: unexpected end= of file checking for /usr/local/bin/emacs version... ok ... =2D-8<---------------cut here---------------end--------------->8--- And this: =2D-8<---------------cut here---------------start------------->8--- # ./configure --with-emacs=3D~/src/emacs-25/src/emacs configure: Tramp 2.5.0-pre checking for gmake... no checking for make... make checking for reasonable make version... ok checking whether make sets $(MAKE)... yes checking for ~/src/emacs-25/src/emacs... no configure: error: no not found =2D-8<---------------cut here---------------end--------------->8--- Best regards, Michael. From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jul 2020 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicholas Drozd Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159464854932506 (code B ref 42237); Mon, 13 Jul 2020 13:56:02 +0000 Received: (at 42237) by debbugs.gnu.org; 13 Jul 2020 13:55:49 +0000 Received: from localhost ([127.0.0.1]:48955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juyvt-0008SE-IH for submit@debbugs.gnu.org; Mon, 13 Jul 2020 09:55:49 -0400 Received: from mout.gmx.net ([212.227.17.21]:54635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juyvq-0008S7-5k for 42237@debbugs.gnu.org; Mon, 13 Jul 2020 09:55:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594648539; bh=L2n33Q3E57Kh32yJbbgIP4gcQGGf6e7aPjG91V6ZZvw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=O+5FFCijkYZbBZ0SP95IWAwdsfiSpPQXdPJ6rAiuaGnDZYIRjn9AUZugkvlrIdHgA 5jDmtdPfqn1CVwapTVPa+Y2qr8EqblYClnkSjmbJ7erDrckfwQc6ducaPQ1o1eGsJb bdF1uZmri70eproHscGaS8LsUGjLIJP9cE+dy2Yc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([178.20.93.90]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5VD8-1kxNvF0RR4-0170gC; Mon, 13 Jul 2020 15:55:39 +0200 From: Michael Albinus References: <87tuyczvwn.fsf@gmx.de> <87lfjnzhrk.fsf@gmx.de> Date: Mon, 13 Jul 2020 15:55:37 +0200 In-Reply-To: <87lfjnzhrk.fsf@gmx.de> (Michael Albinus's message of "Mon, 13 Jul 2020 15:06:23 +0200") Message-ID: <87ft9vzfhi.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:6MAl71NSJ6+k9ZipaP5StcKKRX6Td02MHBVBBt8sph5fSCnE0ac KlpIk8JjffCsutq98VTLiwuQGlmzUmXiQ/7ztXcwOCDqZIkB4NWOE7Uhko1Q6VigR0nmgwo XsN1xI/iVsjPbzTjw3kphcSVO6zFAK/PQDzHGxI5PojBJvS4+SoMnith3DbC/BjylF/oX3S ZCb327aQRC1kxBszEZS5g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jYvbTTdEUsA=:oxjGOLMQvEQAAiDWtUCOSR FOdrule2GjjbE+E/J1C8KJX14vnxUq1z258DqeMWaSgCgcnYRO4PvLqqgHXfDfAgk/UBpRQ1t olv70UjQ7ZoLoidRVA6DF7yxtcrcae0xpXgh7a9zXBRPtvDrv3WBzNdtvXc2HVTjm1MmJx6iX 8GUtHxvgBhJlaX+dHVEGTa74TAqunKFIvSgIqgnhOy5ZPF0mYX+oABk+R5hdjQ5eDHgBMF6WL ZGfsF7viGLcbaLtTFKZUInTHRg5uFPX0ighfVEq+A96BPsNiYHBjYD4kYWnYf6NFEzDyBztJC yp5C+95GdTEQwlbfBnAlXA3xaPrqBxGvPr/CbfosBff77h81qyqdNXSBOD3WcovVFlgzoMp7a sWWE3QTMkovAR6CJWTWk4z6D0j9u1cd2vJ5Ai0Cooy0JKSJDvxxPufcf9cF+0k32Ju17CJHyn A+pAF8ImLbdoRvFWLOmzGHhDy3y3xFbnZluZ3977ms70ahdRTceJsHWcxrc9Teh59yUmLud9l 82f2Uu7c9E6q+EklLzanYecYlbjG+29tMQ/ZJGML2QPF+5MAMclAjbZmoykJ3SQS873IPTzTp mv14qa5CszkkEo8BYWNgWwSUjPjQWuA6yIbwFyHXHwo2fCIJrcdBwWCIoS3JMxwtDzLgvLhex h4v/si4zpJxrCxfUPUdeygd4trT5+VugUVNqk8Rmrlyhx7aJ4al+Q1o225wfBFOXuyDQIiRM7 591r+dpVcL94Q7CvPhne1aJhD0a9ykrS72Ss0zgKykkmwf+As5AFQpLraOVWrphjtmmio8gg7 gRb0p2rF72Qy43FmFhJaEUkUhEWd3Xcn1W6jmhNq1dnVnsVqlbm46dqRchrY7kR5AWiRyA1K9 o4cX3ivS/vfB7l4wwSj+zzKYora9xNM5A6MKM6clEXEGveUoeqhJ0vwFtgdaF96nAxySviPFw 8OHdQYVTYA5dsfzq+kDwcIcMSPlIsS0DESE30MGatiQ6HJYBK8YUT7oWfCanFoD0nG9PGiYPX FSonMiRc0B9EC4vseyIDEezUgXGX/UxrkyG9TyeX1yOyF3z3pV1twVfmrGJBolFhwvNhGuxBy R8p6ohZC0vl0esq4THhJrNlQ8WHPxUYi2OXt7ZNTLIYmi1UCBZkdVucpFJoznYPZZ1XXceFp6 yadq1Zs2DM2gzcYMr4YEzzxogA+0H5kUybpg80yr+ce8VAbhTiXIcGZ0hCdhcEdqCcpERdOse +wugn5i8akc2zNaaIAIdjNsfNlRif1FLTSL7+cQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi Nicholas, > # ./configure --with-emacs=~/src/emacs-25/src/emacs > configure: Tramp 2.5.0-pre > checking for gmake... no > checking for make... make > checking for reasonable make version... ok > checking whether make sets $(MAKE)... yes > checking for ~/src/emacs-25/src/emacs... no > configure: error: no not found Sorry, this wasn't caused by your patch. I've fixed this error. Best regards, Michael. From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicholas Drozd Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org, Michael Albinus Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159739663932571 (code B ref 42237); Fri, 14 Aug 2020 09:18:02 +0000 Received: (at 42237) by debbugs.gnu.org; 14 Aug 2020 09:17:19 +0000 Received: from localhost ([127.0.0.1]:51800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Vpv-0008T2-8b for submit@debbugs.gnu.org; Fri, 14 Aug 2020 05:17:19 -0400 Received: from mail-yb1-f172.google.com ([209.85.219.172]:40549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Vpu-0008O6-CF for 42237@debbugs.gnu.org; Fri, 14 Aug 2020 05:17:18 -0400 Received: by mail-yb1-f172.google.com with SMTP id q3so4844135ybp.7 for <42237@debbugs.gnu.org>; Fri, 14 Aug 2020 02:17:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=GyquSYUp5bnzGhaL0KIBJA/59oV1KpG7Cr+kWmvQ2jg=; b=uoN1iBIEfnIAteBmPMEEfTgGkI/WxiGt8YMeSWhUeuPEnpzwAKYEM8jZSdRcCJt180 OfioxhxtgDynADRDnREqkbiPj/BBu5cIx0XmFI53TBgTHlkd9qMoQ6g2+90Y2vQJpORB sRhohESkaHO0Tzc7YulsBPImJCW1dPoxw92ZRc82xfC2m2FZKL7Mg4sCOSqOfJktMy0k HYAbNFO3a1c73bC9ywXeqkEnEu5To4NTjWbzoWbaOsDKMi7jADz1SB/zmc2j/uTQql7k EwnHo1DMbtaioQS+I9tdWs9g0PrO5C0KqCIzURCvdVCfTGRkVCamiovY1fazqYJk9ICq IAJw== X-Gm-Message-State: AOAM530icMwwuOJhq8CzHh8gI55ZGjYe4M7CbnU2xfBWNp/7qBKWP0ne hhgqWNtwAc2h5FGiMaK/ZZke9U1ESANQhNJk64U= X-Google-Smtp-Source: ABdhPJyFG9LgVxIlqG8sA7x5ec7jSSmbvntD7pXZj3xAMHXBkXn3X67zvRLYKUGp8/MTF0aENqRNTZSO/oKc9uFEtls= X-Received: by 2002:a25:7007:: with SMTP id l7mr2372976ybc.85.1597396632878; Fri, 14 Aug 2020 02:17:12 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 02:17:12 -0700 From: Stefan Kangas In-Reply-To: (Nicholas Drozd's message of "Sun, 12 Jul 2020 14:54:57 -0500") References: <87tuyczvwn.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 14 Aug 2020 02:17:12 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicholas Drozd writes: > I've attached a new version of the patch. Hopefully this one is right. Should the patch here be installed? Michael mentioned an issue that then turned out to be unrelated. Best regards, Stefan Kangas From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org, Nicholas Drozd Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159749884623221 (code B ref 42237); Sat, 15 Aug 2020 13:41:02 +0000 Received: (at 42237) by debbugs.gnu.org; 15 Aug 2020 13:40:46 +0000 Received: from localhost ([127.0.0.1]:54455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6wQQ-00062T-Ai for submit@debbugs.gnu.org; Sat, 15 Aug 2020 09:40:46 -0400 Received: from mout.gmx.net ([212.227.15.15]:56893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6wQM-00062B-SF for 42237@debbugs.gnu.org; Sat, 15 Aug 2020 09:40:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597498835; bh=kiEmlxkFBhRWeuJXjdZhaePS3Srmu17EXBm7PN2boIk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=eOw1j+svXfJIj41Kg8s6v6EneU5C9bcAvJat2LNZHveq4Ee2dEdT9uWklHSv5XV8E 9lK+4oIgAijlosGZL3l3hA6fIfFmuHTPQm/W5RfGUcyY312YFvQqYq3o+JIoWa3N9O o1sQ5DV9AWrmYYBMAhyADCG8NN6A38bV7VXMa9bM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.63.243]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M4s4r-1k50se1LVv-001yel; Sat, 15 Aug 2020 15:40:35 +0200 From: Michael Albinus References: <87tuyczvwn.fsf@gmx.de> Date: Sat, 15 Aug 2020 15:40:33 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 14 Aug 2020 02:17:12 -0700") Message-ID: <87mu2wkoxa.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wqUzy1ZDXmzE58R41HAx+ajTlM9aF68ITzRJoPCDhKKhnsq89Vc a97GfM5Y39yygKAJCTmmz5nR8o8UI+lRF1TnWQ52ouXbCJgaCdMMVtipIPXyCGw4n2I4alZ dCtYyFwJZtqushckdZKg4Dy9FyjCMzdhHSZBv2X2vPMlDsXh9AbhjNPFYmtDotIC0EXQQuG IBNkIHQvchOyFn0hzq19A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jLYXfCOOreA=:h7tpxpBVR2V8GiCxuE7B1+ rMRHkB9HkLyRRpuwpI4AHe99ZecHNPXPuH0NbOrTkWV6FtsoPr5AJKlMAR1BySBGAyfQEEnTT 6Iibyqqp8tbjg23rl/G4uGjwtsQSyIEcCBssTBa+AAXW7LnPB4xRjDMKC4gIbfJXxmapdiqkN aYkAhjDcFNXW9VDFCXFPg55WrrIqT0V3gISuRRfBrZzMMXSptO4N9uem1HzyX86033gZreLs4 7ise9LzEGx4UG+T/cnxocJqu0vVuXlNyzPV8IZe4R44cYO9YDBInsSjzTwUGkYsbRNztCHfjQ 3bF2k0ZMqZg5cih+gy7NBN+YDbAk8+hv7dM34oLP6C3M41MePSDousqKGkNqbRcHJjF+op4Bb 3YhXr21DLkXtdygowiBWZWxT7w/I467XC42+zHC6CKdCIs9aVrjftJwy75FtKVCITloaAUMQF cZCnsH4MbrWgocVRil075yF0tJWuKBB1hgPeNJDWKN7+gMjfpdRX/g36jD1rDIIl32Gm2+gzH JN5a1/gKOIvqFR2Mhnk36cKiTxRX+FJMO7kBlrliUKS05E/zcu/d90/LE+HwtPYprKsQQkxlU CiobqDFZJ3fU4hea0Sw5eANLYBjTthdGoeF4WXCz8hxYM/kzKjO3legM4lSzoGqnezC7ClgYD 9NXA9lGUj5PcMREFvCodLWBy9xwtnn/qRGkbhfcaKZJLGwSIGW8zYTdPJ+w8CnuP9t/8uOOQU JPhrlSLerhybEq8tqF916cWxa/Ias3ghkPx58FZj7CrMVohhSk9CNTtGmhVLk4W1dgPo3xjkD XXTTJMjmZ2DGwN/C722CaYLjFd6u8MNBLvM9JK/NnK4zQLl6RnMj9pj0X/clDSVm6dAoIivj9 0Wso+cfMoCGWxwLCekwMlQDuwxddHN/9Bf0aHSpSUiDm0C3p3BuQWYU9Zh5Hcu8+5UjEATogW 3yJqy9rmfNKCG4phDfpsAM3FLzbG0sWHW/G19bDsP8D2zkC4qT+jxlxC5EiMr4VTA7Zhv59rA QzE4r6Y+HJEk4T1Jun1abF5Gn0NtDaqENlwJwBpEb7QgSKl7DWniHL0g8FP1P0MA5YSEFP5Oj hsHRgMRTPcmOOshXZmC/MLLhqXrwu0EFbcSRAZ1jtl1cj1eb7P408bYn4L2yNNHQojfMI9UZL 0b9HZw5UDhqUE8yGY47l1NB8kPVrfW4PpIU8Q8YSkwSmpMFRLWT3dDKRsrMYQ2ipkUiKhx/R2 HHMs+vMk/xUkZ0ILkrpqsVthEP1+en5/7cICFRw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: Hi Stefan, > Nicholas Drozd writes: > >> I've attached a new version of the patch. Hopefully this one is right. > > Should the patch here be installed? Michael mentioned an issue that > then turned out to be unrelated. This patch is intended for the *Tramp* git repo. No need to do smething for Emacs (yet). > Best regards, > Stefan Kangas Best regards, Michael. From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Oct 2020 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicholas Drozd Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.160303399725746 (code B ref 42237); Sun, 18 Oct 2020 15:14:01 +0000 Received: (at 42237) by debbugs.gnu.org; 18 Oct 2020 15:13:17 +0000 Received: from localhost ([127.0.0.1]:38907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUAN2-0006hC-Rw for submit@debbugs.gnu.org; Sun, 18 Oct 2020 11:13:17 -0400 Received: from mout.gmx.net ([212.227.17.21]:45781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUAN1-0006gz-Ha for 42237@debbugs.gnu.org; Sun, 18 Oct 2020 11:13:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603033989; bh=qCBgAXAFtotLMyJviT+8Mc2rPVHVv/n9EkSWhPLdel0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=PggGHME9i/Y+iX0R0YKEK6RrT1sbsgPs8GfLKFMaiUgWs+umt3JY8xS7XVDCMBZm1 wTLavRYizr/YwoSE0eIf5MQ9Eupxb17SlWFVBCxoHY0TsTdl4vBegtyfyRxC2ZDEIK ZUw6v8Y1Y0BVcOsMpgH3InevhXDbU9K64wOq4fGY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.52.21]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MG9kC-1ke4wS4952-00Garw; Sun, 18 Oct 2020 17:13:09 +0200 From: Michael Albinus References: <87tuyczvwn.fsf@gmx.de> <87lfjnzhrk.fsf@gmx.de> <87ft9vzfhi.fsf@gmx.de> Date: Sun, 18 Oct 2020 17:13:07 +0200 In-Reply-To: <87ft9vzfhi.fsf@gmx.de> (Michael Albinus's message of "Mon, 13 Jul 2020 15:55:37 +0200") Message-ID: <877drn1sak.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:t5reULOIFKoGGWkjwUhAVJwdvVaus3OGcA0DQMjpTng9TUc5R7C PppxCh6KFR5TQozoHAzz0U/tI8oiy5CgcBECpbPpuM9Ks0dDcrIOXrlEeePJuWLZylZjCIP OtWoH/ECAPQqaag+5Z+beAOtJz3zbifQUlVWYdy6FS4RrbGlG3CQSpLDUnXHbhm34s+zqtf he3JWJKRmXpXrJ9jiL13w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:77I+GREx874=:TYi2mHK/SvvixnxPuwEvhE keSFS5MlLjar2Nivv/TAQ+Ru7WnzAwl/XmhrpwGll+32adCqiA6PMh0S4kvL86rKNi31eaExU FHKLbCo2lhHIQQWmgLhQhruKkjtxWX4qWmDJ/voLDy0pXquL6VWJT5aMfOt3VZ59/mVLpDuH5 egxeknlwfZ8OSAL+01IwEqYbHZE7HDRGVCdBD9DZHDQGWfJXp5oLmgVBGn+ne+KfT7fnmi3MY Jv5/cRxKV4Fs4fy/Hz/dati1mAyiEuZM0YtQtNcui64tmS/uVuI4RERwahvV/mn4aV8WcOBws WzNwyBkjLHTtlwwy6KRIC3C8704yPdI6zN0+z7qi8OjzC3pg9VskceVLiF4M96aAxyMJqvOnD XV80efvZ9DTl4kh5QWcz+/qjIbkzVZeQbNI+ggQAQ1zfhJqC+0goSklEpg1PLdKhbajxZxzGr pHpvj6GkYiIy7N0q/BuxCZH0PpoSjuzBdXCe1m9D/9YuhKTiU1KJYXbMzPMuyU78OIiSYpTPe GFOjZ0oZ7UQYk0iexBjgcEDfqyxNi+xzOxdZwZQvlTRgLGg8u9UNgf9hWE8udCIMSc6+PI3c5 2jOLyKxKh7Bl/6McdKYY0feltJEimFNSpg5jeTfnqDf99wDY37phtwrx6OeoM29WMjxkb2C6L V5ZffqxEPeBjJxRGWFfAoKXv68LG3eidDZGPxRMzmNRyAqteSwWyPfDb8Mq2kMv5IL5lPxOuC nyS3UwQX3Hv2qljDNLpc8nOPWPr1FOTtjOq0KpYIQkwV8EVILx2QXrzaA2qUncxVWH9JQbBwi k9Kf8QxTphp7InWGeMwhT0ridgeb57ydcs652aubDLMTo5OKbvcF+TLRT3F3Ae25dhKHDA0b0 9LoK6Kau3gPI02ioXQgA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Nicholas, Are you still working on this? Best regards, Michael. From unknown Fri Sep 05 08:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42237: [PATCH] Clean up Tramp version check Resent-From: Nicholas Drozd Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2020 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.16031272774161 (code B ref 42237); Mon, 19 Oct 2020 17:08:01 +0000 Received: (at 42237) by debbugs.gnu.org; 19 Oct 2020 17:07:57 +0000 Received: from localhost ([127.0.0.1]:42232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUYdY-000153-NF for submit@debbugs.gnu.org; Mon, 19 Oct 2020 13:07:56 -0400 Received: from mail-ej1-f48.google.com ([209.85.218.48]:42753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUYdW-00014l-AJ for 42237@debbugs.gnu.org; Mon, 19 Oct 2020 13:07:54 -0400 Received: by mail-ej1-f48.google.com with SMTP id h24so65751ejg.9 for <42237@debbugs.gnu.org>; Mon, 19 Oct 2020 10:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D3K4ZcS1NTQ0d2vFlUoOAprtKwu4BTRQQLVKNgyUMUc=; b=uXo4Gk0BdxupPeOFoiCIK42xiAiUWFXDypJ7teT7aBzEA6N9K8Hos+NAX90jMKJ/xh HaRLSkQVSU6Kt5RV+5joPQ67SiC/bpmBz12iowWuRj2/rlqM1pZQRHkreWWca7KAS93x IWjoS4Ot9ocWc3j4ac1y9rqKJyHRUjbhCQUk7jP7mQYpH3MKSmvDCNqYaiR3cCC9x1UI I4dDrZyNm9OaL/Xm+mDZqvoGhov4LmzPZkLAAlRQaglZTiwDLtrH2qo4/9YthnX3/5gj zU60tNfqYSp3FUV9axdBbyDPm0zXHD+TAQV70WZI28nMx4lnzQN79hg4Fzk9RcGBDuwk oQGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D3K4ZcS1NTQ0d2vFlUoOAprtKwu4BTRQQLVKNgyUMUc=; b=dexdIOAa+xgwVGo9r0n23L+oH//mJCQS+JKJdIz1zDCusNA5nTlCh3aOU/c5IB82ff GtK8PQTHvLMo9Q0HUPe/YdRHMxIokPsaCPZKodSai848AMYHvRPr80Zoy57JVGcVteIE lGz3ZnrezlMoDetcVPyBEonOGG5kDBW+HaZ54MWbUsBJhiNBNqiiKXVcb7FYIPRThAlU NB3yHgrG+cqjBax+FB+xmmFGHRBvfP9vphc9RfDsaQO9MsJ7TnurWeOzRxM5nMiRfzyI KMIyXdj2ng5yyqFUoexKjDeIAPSfK7gr+WYUHTfCcTwhu5DXTBdEkWa8ZhIj6ZXdLogQ PTkQ== X-Gm-Message-State: AOAM530C1aiKTbL5eIR/x9Fs7+JlYZS3e88VIwvuUt627NaCJpAQ8GmW dca+c8KKhzlSpQtvit9Isio+4MIYSfbJSDXA3No= X-Google-Smtp-Source: ABdhPJxi2p+BhHnFCx+z5AcTcPr5x85izxLloELRzAeN8hbgX3R8igK14W1DBeYmUDusOam5yEj0Iza8VsCJDHacG3o= X-Received: by 2002:a17:906:b80c:: with SMTP id dv12mr865771ejb.220.1603127268393; Mon, 19 Oct 2020 10:07:48 -0700 (PDT) MIME-Version: 1.0 References: <87tuyczvwn.fsf@gmx.de> <87lfjnzhrk.fsf@gmx.de> <87ft9vzfhi.fsf@gmx.de> <877drn1sak.fsf@gmx.de> In-Reply-To: <877drn1sak.fsf@gmx.de> From: Nicholas Drozd Date: Mon, 19 Oct 2020 12:07:35 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Michael, sorry about the delay. I swear I had this working before, but now the new test isn't passing. Because this is just a clean-up change that doesn't actually fix anything, I don't want to put any more effort into it. Feel free to try and salvage the patch or to trash it. On Sun, Oct 18, 2020 at 10:13 AM Michael Albinus wrote: > > Hi Nicholas, > > Are you still working on this? > > Best regards, Michael. From unknown Fri Sep 05 08:44:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicholas Drozd Subject: bug#42237: closed (Re: bug#42237: [PATCH] Clean up Tramp version check) Message-ID: References: <87v9f5b5wn.fsf@gmx.de> X-Gnu-PR-Message: they-closed 42237 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 42237@debbugs.gnu.org Date: Tue, 20 Oct 2020 09:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1603186322-4191-1" This is a multi-part message in MIME format... ------------=_1603186322-4191-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42237: [PATCH] Clean up Tramp version check which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42237@debbugs.gnu.org. --=20 42237: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42237 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1603186322-4191-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42237-done) by debbugs.gnu.org; 20 Oct 2020 09:31:15 +0000 Received: from localhost ([127.0.0.1]:43577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUnz9-00014W-K3 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 05:31:15 -0400 Received: from mout.gmx.net ([212.227.15.19]:55601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUnz7-00014F-Pi for 42237-done@debbugs.gnu.org; Tue, 20 Oct 2020 05:31:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603186267; bh=Yn1ZLa9QF1XnY1KFyZIoNf6AL2i20roigZVSA44F1DA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=EI9M8YiRB4yZhKvwpweTKL1ptTy2aoHy5mzmSqiPR3kxdtj+ZhfFyJY6ESQA1caQ3 T5ujStlHp/UMSUxYL57siQC1bYtpOX2rWv9GeNF2ez+XdXzVxcmBwRqysuEBi5bL+B DrsO3OYXz6Jfu/3iB/FtbQh3stkW5Ptr8S89xtGI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.58.0]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mzyya-1kFtl632rG-00x2NG; Tue, 20 Oct 2020 11:31:06 +0200 From: Michael Albinus To: Nicholas Drozd Subject: Re: bug#42237: [PATCH] Clean up Tramp version check References: <87tuyczvwn.fsf@gmx.de> <87lfjnzhrk.fsf@gmx.de> <87ft9vzfhi.fsf@gmx.de> <877drn1sak.fsf@gmx.de> Date: Tue, 20 Oct 2020 11:31:04 +0200 In-Reply-To: (Nicholas Drozd's message of "Mon, 19 Oct 2020 12:07:35 -0500") Message-ID: <87v9f5b5wn.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:sN255y73vO6Zy/w5pdczyWC1VcFRvRD++Rukw+wk9UmQNfD4PMc y1b8svPjm0P3zYFI84ndAzm8oJq6RI/dikDR9+3/MhsQdhjhpaPNPp2NBNo11NKMVYyplAZ 3Egyt6dseDkmFvJf0L4jpmeVzR0362dSZyD1xtZfOKXkp5AgpsOYO9OCI24VZcxLKu29wcU 76gJbvWkI6O78yHiFax0w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:A4nDlk5Lp2E=:oFL2BUco/W7ZJrzslJ3nrT QlE6BkOghsqcjEjikYGPkNOi+BXfx35Zce1GgnEc9BV289qWL9Cer49jGoFyn2OZf/i1b641y gCEki1Mr/PwdDTV+8IzSJcTB45LYVNyr2j6pcHnU+qJHo9F8sRpOIv/FvisNlcpVSzXsO5HII yMMltk8sJSR2Pi1ReD8/sO0dnvaGKCnS8k5Ak1/mZUKNon4KHJvNNrTwl8/8IiJKyoevNvb90 WT93sxpIAIzejMAM3zRXczPbOJqHSQrqA8C4IHXx3nOchpHNNSDlHWiOsA0FJHiNw2cGaDDlb UCHSPeXi+vRvqYW2ZXOOFuiDbQ4wiat3eE7jkJQHK5hJ5qGK29WYIbdrWCcqID7835khVZapa 1J9ygXchnTwVdMC4wSMiyBW/cki6xva9RpoMn0T/4EB2E5urBSCtYJ4kx8hBSPXGr+lmkXnck bVEvLWadVCEOV+py1xj0sCDKbHglMn9HHMlQI4lpmcx/rdJv46sWicax6fnKsPqcNivTX+Om0 NDiHoTuLCiuLE9ncdO5QHcZDvlxZ8paGLyus9gxOfekDlPDYLMBiEEB6ZhgBHIszGcpNSNAp5 xcb8S7CnM9DYUhfNiIRtPxSQPpKZtA98FaWraYRbxoNKpuPGRXYZFcpN/qFFhb4t8dQIb0zk4 P2tuCR/Yp1VVX28N3IhU0dpjaiJtUv02G3VdXDDyTtSHXUSlS1wF8YqrGdxaZhPrJT9ypc1D1 +5ayZY0Pt3Qh2TfbSJf5D40/jURo0sAsrsT1FGwNohAkVh/RUfE8Z2dLO8EuOTeC+se4KrdEB HVf2NMQdeH7+eEO3iDHwyf5FgvpIJ8paHr+VLtcItM7J57EB3xzEaUR0ihKn/VuscaUlDVl8j NsQK1W5xtpGNbaqKP8HQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42237-done Cc: tramp-devel@gnu.org, 42237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicholas Drozd writes: > Hi Michael, Hi Nicholas, > sorry about the delay. I swear I had this working before, > but now the new test isn't passing. Because this is just a clean-up > change that doesn't actually fix anything, I don't want to put any > more effort into it. Feel free to try and salvage the patch or to > trash it. Thanks for the feedback, I'm closing the bug. Fell free to come back if you want to continue. Best regards, Michael. ------------=_1603186322-4191-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jul 2020 22:20:10 +0000 Received: from localhost ([127.0.0.1]:35054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsZT8-0003Q4-69 for submit@debbugs.gnu.org; Mon, 06 Jul 2020 18:20:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:57190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsZT4-0003Pt-FH for submit@debbugs.gnu.org; Mon, 06 Jul 2020 18:20:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsZT4-0005CK-4k for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 18:20:06 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:40940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsZT1-0001tr-6V for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 18:20:05 -0400 Received: by mail-ej1-x629.google.com with SMTP id o18so40031218eje.7 for ; Mon, 06 Jul 2020 15:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=mRqqDbZY5pf1osbuWNAte/38LEzOFHoK1o9ojL2rW0Y=; b=ifO2vvK37SAolgNLpBnIBPOxlkwIgkfRSctRr44KaT/ziaSv2opedZzWb41wFWN5r1 6DFA/0HaSWhSyRaR4z7jH2G4NaYYhNO3SuSoTOKaD3b1ybxjODEEdmwC+LMCSM0+mQ+/ e/Ih/jb4LoZBoUWSR01iVJ/Kl8U5c9KuqdmAQaT7EA/BYS3SXIW2xTbxzLOryDJa5y4L d3YRq68zrdDodAKW5Vn6rhOCP+vLRkiI4wjY19ln+VFTP8z/GZ2jBDZ9rKQ2Zv1CMe3M ClJ0lKhkJgdtjKGs3f3YZkXMX7LVfpWU+UjVcjZ+asaCVAmZgW+/ULGo25YGMRzE1KQm 52MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mRqqDbZY5pf1osbuWNAte/38LEzOFHoK1o9ojL2rW0Y=; b=elC3jj8ShZi3VPK+A29VsoKTh6ohUSuZ7T8IM/RLCg87L7Yw84jtZvvBIe8I/s/MOw fBkMRCK1301NIcrd6BwWbVw7NqcWGZdIaqWsLQ/pvxLqYBO9Ap8WgWTIB0dGy/ZCc94C sAM0qZ1yM0JIKRuKysxeDI6YdC+xR0nJwL1R3ttcFiZJK+JMHFFx/Ulj5p9xsv8QrViP 17rCKvAZGHh0VWeQVpGczWRk/6Qm8ilBRuPuvRsgfSPE9KDf0SopAs214e7ZLxO4LPaR hBNL2lYon1QZwmcFkJedC7LcxPhYifoSIJiVSybT1vVtY7Kbd9mV/56EJy1zwGFTrKdM ATQg== X-Gm-Message-State: AOAM530sCtGPr3doylZE3dWuJimoBMKDG18oy+3oaOVQmeZZHA8zzebX 4wRQVy6eIl1lBI7FRhT9yeKeG2URYILAZCheYYY+TLWe X-Google-Smtp-Source: ABdhPJxNG2ntYgccv6ArY5Ywaa328xc0dPoj1W7t4zFqA6aC+3r2pC4UUKsoDRoo8eOnQh1XtGOEcJa01ExRPlMuzDY= X-Received: by 2002:a17:906:3009:: with SMTP id 9mr28678609ejz.220.1594074000662; Mon, 06 Jul 2020 15:20:00 -0700 (PDT) MIME-Version: 1.0 From: Nicholas Drozd Date: Mon, 6 Jul 2020 17:19:48 -0500 Message-ID: Subject: [PATCH] Clean up Tramp version check To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000008e469a05a9cd4615" Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=nicholasdrozd@gmail.com; helo=mail-ej1-x629.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000008e469a05a9cd4615 Content-Type: text/plain; charset="UTF-8" I actually saw the "not fit for" error message in the wild. The source looked a little strange, so I cleaned it up. This shouldn't change any behavior. --0000000000008e469a05a9cd4615 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Clean-up-Tramp-version-check.patch" Content-Disposition: attachment; filename="0001-Clean-up-Tramp-version-check.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcb2d6dw0 RnJvbSAzNzE2OWU1NDkwOTRlYTQyNmQ2NDI5ZjA4ODUxNWU1ZmM0MTY3ODVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCA0IEp1bCAyMDIwIDExOjQyOjQ5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gQ2xl YW4gdXAgVHJhbXAgdmVyc2lvbiBjaGVjawoKKiBsaXNwL25ldC90cmFtcHZlci5lbAoodHJhbXAt bWluaW11bS1lbWFjcy12ZXJzaW9uLCB0cmFtcC1jaGVjay12ZXJzaW9uKTogTmV3IGNvbnN0YW50 LCBuZXcgZnVuY3Rpb24KKiB0ZXN0L2xpc3AvbmV0L3RyYW1wLXRlc3RzLmVsCih0cmFtcC10ZXN0 NDYtdmVyc2lvbik6IE5ldyB0ZXN0Ci0tLQogbGlzcC9uZXQvdHJhbXB2ZXIuZWwgICAgICAgICB8 IDE2ICsrKysrKysrKystLS0tLS0KIHRlc3QvbGlzcC9uZXQvdHJhbXAtdGVzdHMuZWwgfCAgOCAr KysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L3RyYW1wdmVyLmVsIGIvbGlzcC9uZXQvdHJhbXB2ZXIu ZWwKaW5kZXggOGQyMTEzM2IzYi4uNDJkOTg0ZGFlMyAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvdHJh bXB2ZXIuZWwKKysrIGIvbGlzcC9uZXQvdHJhbXB2ZXIuZWwKQEAgLTY5LDEyICs2OSwxNiBAQCB0 cmFtcC1yZXBvc2l0b3J5LXZlcnNpb24KIAkgICAoZW1hY3MtcmVwb3NpdG9yeS1nZXQtdmVyc2lv biBkaXIpKSkpCiAgICJUaGUgcmVwb3NpdG9yeSByZXZpc2lvbiBvZiB0aGUgVHJhbXAgc291cmNl cy4iKQogCi07OyBDaGVjayBmb3IgRW1hY3MgdmVyc2lvbi4KLShsZXQgKCh4ICAgKGlmIChub3Qg KHN0cmluZy1sZXNzcCBlbWFjcy12ZXJzaW9uICIyNS4xIikpCi0gICAgICAib2siCi0gICAgKGZv cm1hdCAiVHJhbXAgMi41LjAtcHJlIGlzIG5vdCBmaXQgZm9yICVzIgotICAgICAgICAgICAgKHJl cGxhY2UtcmVnZXhwLWluLXN0cmluZyAiXG4iICIiIChlbWFjcy12ZXJzaW9uKSkpKSkpCi0gICh1 bmxlc3MgKHN0cmluZy1lcXVhbCAib2siIHgpIChlcnJvciAiJXMiIHgpKSkKKyhkZWZjb25zdCB0 cmFtcC1taW5pbXVtLWVtYWNzLXZlcnNpb24gIjI1LjEiCisgICJUaGUgbWluaW11bSBFbWFjcyB2 ZXJzaW9uIHJlcXVpcmVkIGJ5IFRyYW1wLiIpCisKKyhkZWZ1biB0cmFtcC1jaGVjay12ZXJzaW9u ICgpCisgICJFcnJvciBpZiBgZW1hY3MtdmVyc2lvbicgaXMgbGVzcyB0aGFuIGB0cmFtcC1taW5p bXVtLWVtYWNzLXZlcnNpb24nLiIKKyAgKHdoZW4gKHN0cmluZy1sZXNzcCBlbWFjcy12ZXJzaW9u IHRyYW1wLW1pbmltdW0tZW1hY3MtdmVyc2lvbikKKyAgICAoZXJyb3IgIlRyYW1wIDIuNS4wLXBy ZSBpcyBub3QgZml0IGZvciAlcyIKKyAgICAgICAgICAgKHJlcGxhY2UtcmVnZXhwLWluLXN0cmlu ZyAiXG4iICIiIChlbWFjcy12ZXJzaW9uKSkpKSkKKworKHRyYW1wLWNoZWNrLXZlcnNpb24pCiAK IDs7IFRyYW1wIHZlcnNpb25zIGludGVncmF0ZWQgaW50byBFbWFjcy4gIElmIGEgdXNlciBvcHRp b24gZGVjbGFyZXMgYQogOzsgYDpwYWNrYWdlLXZlcnNpb24nIHdoaWNoIGRvZXNuJ3QgYmVsb25n IHRvIGFuIGludGVncmF0ZWQgVHJhbXAKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9uZXQvdHJhbXAt dGVzdHMuZWwgYi90ZXN0L2xpc3AvbmV0L3RyYW1wLXRlc3RzLmVsCmluZGV4IDFmMjRiYTI3ODYu LmZmMTEyZTljODIgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9uZXQvdHJhbXAtdGVzdHMuZWwKKysr IGIvdGVzdC9saXNwL25ldC90cmFtcC10ZXN0cy5lbApAQCAtNjU1Nyw2ICs2NTU3LDE0IEBAIHRy YW1wLXRlc3Q0NS11bmxvYWQKIAkgIChpZ25vcmUtZXJyb3JzIChhbGwtY29tcGxldGlvbnMgInRy YW1wIiAoc3ltYm9sLXZhbHVlIHgpKSkKIAkgIChlcnQtZmFpbCAoZm9ybWF0ICJIb29rIGAlcycg c3RpbGwgY29udGFpbnMgVHJhbXAgZnVuY3Rpb24iIHgpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IHRy YW1wLXRlc3Q0Ni12ZXJzaW9uICgpCisgICJDaGVjayB0aGF0IHRoZSB2ZXJzaW9uIGNoZWNrIGNo ZWNrcyBvdXQuIgorICAodHJhbXAtY2hlY2stdmVyc2lvbikKKyAgKGxldCAoKGVtYWNzLXZlcnNp b24gIjI0LjMiKSkKKyAgICAoc2hvdWxkLWVycm9yICh0cmFtcC1jaGVjay12ZXJzaW9uKSkpCisg IChsZXQgKCh0cmFtcC1taW5pbXVtLWVtYWNzLXZlcnNpb24gIjMwLjEiKSkKKyAgICAoc2hvdWxk LWVycm9yICh0cmFtcC1jaGVjay12ZXJzaW9uKSkpKQorCiAoZGVmdW4gdHJhbXAtdGVzdC1hbGwg KCZvcHRpb25hbCBpbnRlcmFjdGl2ZSkKICAgIlJ1biBhbGwgdGVzdHMgZm9yIFxcW3RyYW1wXS4K IElmIElOVEVSQUNUSVZFIGlzIG5vbi1uaWwsIHRoZSB0ZXN0cyBhcmUgcnVuIGludGVyYWN0aXZl bHkuIgotLSAKMi4xNy4xCgo= --0000000000008e469a05a9cd4615-- ------------=_1603186322-4191-1-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 05:38:37 2020 Received: (at control) by debbugs.gnu.org; 20 Oct 2020 09:38:37 +0000 Received: from localhost ([127.0.0.1]:43610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUo6G-0001HO-OQ for submit@debbugs.gnu.org; Tue, 20 Oct 2020 05:38:36 -0400 Received: from mout.gmx.net ([212.227.17.21]:38713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUo6E-0001HB-P0 for control@debbugs.gnu.org; Tue, 20 Oct 2020 05:38:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603186706; bh=lR0PdyfoD0rZ+QJdR+inN3TvwKXWETycniDXvlD+fmw=; h=X-UI-Sender-Class:Date:To:From:Subject; b=foK9XjtbLHKJb+EUEm9XkOGmKTy/+TT+covbDb/V3hxGM4p0YkAEjW1E/blJK7JWj AnEtcWWsIcVF+qSAGiEiqf0ZNyncolQ+EJSZyrjTqWxI/C3xMmPB8QYW8kN0OPPkpr yKZHOCyRdUUy3+/iqYG8TKb9ov+YyPaVCiAnHEvE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.58.0]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mr9Bu-1k6ybk3GZK-00oJZ3 for ; Tue, 20 Oct 2020 11:38:26 +0200 Date: Tue, 20 Oct 2020 11:38:25 +0200 Message-Id: <87pn5db5ke.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #42237 X-Provags-ID: V03:K1:HCGUcqT636Wk+7/8iGXFhZ8+B3bK2VI0sdCT5PWjHINzSb0xukx dxiyl3ygVMdFoqUlYtQvjYwSDeSghfVn3om2rFXJzM0fEMa6iuYtSHdBk89vVc/M3jkCtUO 2QNGXk4+BZs0hzabX3IB8It74vxrMl33cWrYlOOtNLSS/8cooh8oqdKf9BSGVARmYR3atyJ TDOMi6WzgWVHUM//sPbUQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:E9vJ/pD3N1w=:hm16XL32RJ0I+6FI3d5QDZ RrgLDB2YRUzdN3S7tU61xVpRon0EAKX8LVn6Q73CKhCxH96PPTTFaAtaccznLegJ+8ebayUoM FYAEz8k9ySOO2d8/fEygFHH2WHR50ns13pTtu+s8pQV9vqsjJ7sXpopNKUNM1rbOqq0kjSLfo q+RwtKGcLTz7l8JE7dFrbwuaTHEYnadmVgsZ4kRuf72sOt1K3IYwh1Ef2DFsS+CJQ9jhFdnW+ /XSMhHtZMH1g7fUDhHtj2K/U8d3uRTvZu2q29qk7eoJ0mI64jCENyeqB6ZlY3Z1l/R221F7yQ 7T6/0IYwd3lb/gom6fdbpXvbHJea9934A7ndYzx4VOiUS8I2v81fSXyERFgubfEHQfoxSCbLc MkFboDTu8R8RJJcszxrlf846SGdBQY4YeY5gru9sEhUoRXqfQdBR6K1GOavOw0Suz+uywldmu IE4xtXoQki/oJwIv9Sti0hIPhEhhLKDIqu5nO9PH2Tpp6aZXlhfX/R+5wFgmabQNmz2zz6ekd n887RrP9VmmFRBOwj/p+Jt3EmmnCOdzGutcoFQqpv+ml9OaXlX8vu3m4tKZqeLvK4DHRZxZBf QK2RRtrwkY1kJayib6god8TETW+YI4oFitR5PJWi531B06I+MvcVIB+n0+Xhyrhyr8CVuPM/l gXW3Ol9X+IgdCp2cL9WGNvbULnidhaTve8aQ4eyKcqsu2smqO8HOhooMyNiUAvVDRCx/DQL4l F68KWAZG/jMZ0FFkNKFfcu41ZlvpdMlJyREIjRxwfuaoFvqVgu0Gad+jvcMJtxNyLYkqUnI3u 2palFYkZQdzeCtIvILHdRrbKWZybuQTcykzfwv1UFoLkJ/NHYVL+UQC0cNVWDzQE+AipMgjol z6hU9EevhVMkCAIWFMVw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 42237 + wontfix quit