GNU bug report logs - #42230
[PATCH] gnu: Add emacs-rime.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#42230: closed ([PATCH] gnu: Add emacs-rime.)
Date: Tue, 07 Jul 2020 12:21:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 07 Jul 2020 14:20:05 +0200
with message-id <87lfjv7c0a.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#42230] [PATCH] gnu: Add emacs-rime.
has caused the debbugs.gnu.org bug report #42230,
regarding [PATCH] gnu: Add emacs-rime.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
42230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42230
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Peng Mei Yu <i <at> pengmeiyu.com>
To: guix-patches <at> gnu.org
Cc: Peng Mei Yu <i <at> pengmeiyu.com>
Subject: [PATCH] gnu: Add emacs-rime.
Date: Mon,  6 Jul 2020 15:38:42 +0800

* gnu/packages/emacs-xyz.scm (emacs-rime): New variable.
---
 gnu/packages/emacs-xyz.scm | 49 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a67fe06610..76c9056603 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -77,6 +77,7 @@
 ;;; Copyright © 2020 Ryan Desfosses <rdes <at> protonmail.com>
 ;;; Copyright © 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
+;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -122,6 +123,7 @@
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages haskell-apps)
+  #:use-module (gnu packages ibus)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-xyz)
@@ -23526,3 +23528,50 @@ easily.  Four pre-set options are: @samp{shell}, @samp{terminal},
 @samp{ansi-term}, and @samp{eshell}.  You can also set your custom shell if
 you use some other configuration.")
       (license license:gpl3+))))
+
+(define-public emacs-rime
+  (package
+    (name "emacs-rime")
+    (version "1.0.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/DogLooksGood/emacs-rime.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08rzkiqwcl8j3i2yyibll5lcsj8720plzm9zfdgmxgkw7vhcyix5"))))
+    (build-system emacs-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-rime-data-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (make-file-writable "rime.el")
+             (emacs-substitute-variables "rime.el"
+               ("rime-share-data-dir"
+                (string-append (assoc-ref inputs "rime-data")
+                               "/share/rime-data")))
+             #t))
+         (add-before 'install 'build-emacs-module
+           (lambda _
+             (invoke "make" "lib")))
+         (add-after 'install 'install-emacs-module
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "librime-emacs.so"
+                           (string-append (assoc-ref outputs "out")
+                                          "/share/emacs/site-lisp"))
+             #t)))))
+    (inputs
+     `(("librime" ,librime)
+       ("rime-data" ,rime-data)))
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-popup" ,emacs-popup)
+       ("emacs-posframe" ,emacs-posframe)))
+    (home-page "https://github.com/DogLooksGood/emacs-rime")
+    (synopsis "Rime input method in Emacs")
+    (description "@dfn{emacs-rime} is an Emacs internal input method built
+upon Rime input method engine.")
+    (license license:gpl3)))
-- 
2.27.0

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Peng Mei Yu via Guix-patches via <guix-patches <at> gnu.org>
Cc: Peng Mei Yu <i <at> pengmeiyu.com>, 42230-done <at> debbugs.gnu.org
Subject: Re: [bug#42230] [PATCH] gnu: Add emacs-rime.
Date: Tue, 07 Jul 2020 14:20:05 +0200

Hello,

Peng Mei Yu via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-rime): New variable.

Thank you.

I changed the licence to gpl3+, slightly reworded the description (the
library itself is named "Rime", not "Emacs Rime"), and moved the package
out of the end of the emacs-xyz.scm file, since this location is more
likely to introduce merge conflicts. Eventually, I applied the patch.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.