GNU bug report logs - #42225
[PATCH 0/5] Add 'guix git-authenticate' command

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Mon, 6 Jul 2020 08:39:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#42225: closed (Re: [bug#42225] [PATCH 0/5] Add 'guix
 git-authenticate' command)
Date: Sat, 11 Jul 2020 11:03:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#42225: [PATCH 0/5] Add 'guix git-authenticate' command

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 42225 <at> debbugs.gnu.org.

-- 
42225: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42225
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 42225-done <at> debbugs.gnu.org
Subject: Re: [bug#42225] [PATCH 0/5] Add 'guix git-authenticate' command
Date: Sat, 11 Jul 2020 13:01:59 +0200
Hi!

I pushed this after renaming the command to ‘guix git authenticate’
after all:

  62b8bbc2c2 news: Add entry for 'guix git authenticate'.
  96bf434c70 maint: Remove 'build-aux/git-authenticate.scm'.
  a98712785e Add 'guix git authenticate'.
  69db2993b5 git: Add 'with-git-error-handling'.
  4b9b8b2ec2 Add 'etc/historical-authorizations'.
  838f2bdfa8 git-authenticate: Factorize 'authenticate-repository'.

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/5] Add 'guix git-authenticate' command
Date: Mon,  6 Jul 2020 10:37:55 +0200
Hello Guix!

This patch series factorizes Git repo authentication and adds a
‘guix git-authenticate’ command that’s essentially an interface
to (guix git-authenticate).  Not surprisingly I guess.

The nice thing is that people will be able to use it for external
channels (otherwise they would have to use ‘guix pull’ to check
that everything’s alright).  And we’ll be able to use it for
other Git repositories as well, such as maintenance.git, but
really any Git repo.

I put the “Invoking” node under “Development”, not sure if that’s
the best place.  Also, I considered doing a ‘guix git’ command,
of which ‘authenticate’ would be one sub-command and maybe ‘clone’
another one.  But for ‘clone’ I thought that ‘guix download’ would
be a better fit.  So I concluded that ‘guix git-authenticate’ was
a good choice in the end.

Feedback welcome!

Ludo’.

Ludovic Courtès (5):
  git-authenticate: Factorize 'authenticate-repository'.
  Add 'etc/historical-authorizations'.
  git: Add 'with-git-error-handling'.
  Add 'guix git-authenticate'.
  maint: Remove 'build-aux/git-authenticate.scm'.

 Makefile.am                       |  15 +-
 build-aux/git-authenticate.scm    | 322 ------------------------------
 doc/guix.texi                     |  83 +++++++-
 etc/historical-authorizations     | 179 +++++++++++++++++
 guix/channels.scm                 | 118 +++--------
 guix/git-authenticate.scm         | 101 +++++++++-
 guix/git.scm                      |  19 ++
 guix/scripts/git-authenticate.scm | 176 ++++++++++++++++
 guix/scripts/pull.scm             |  18 --
 guix/scripts/time-machine.scm     |   4 +-
 po/guix/POTFILES.in               |   1 +
 tests/guix-git-authenticate.sh    |  56 ++++++
 12 files changed, 655 insertions(+), 437 deletions(-)
 delete mode 100644 build-aux/git-authenticate.scm
 create mode 100644 etc/historical-authorizations
 create mode 100644 guix/scripts/git-authenticate.scm
 create mode 100644 tests/guix-git-authenticate.sh

-- 
2.26.2




This bug report was last modified 4 years and 311 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.