From unknown Sat Sep 20 14:39:44 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals Reply-To: Dan Nicolaescu , 4221@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 21 Aug 2009 04:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4221 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12508291658554 (code B ref -1); Fri, 21 Aug 2009 04:40:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Aug 2009 04:32:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L4Whog008502 for ; Thu, 20 Aug 2009 21:32:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeLnv-0007rk-BF for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeLns-0007rY-0Y for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:43 -0400 Received: from [199.232.76.173] (port=38785 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeLnr-0007rV-P5 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:39 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:40369) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MeLnq-0004Tu-VI for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:39 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7L4Uvru006430 for ; Thu, 20 Aug 2009 21:30:57 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7L4Uvjq015595; Thu, 20 Aug 2009 21:30:57 -0700 (PDT) Date: Thu, 20 Aug 2009 21:30:57 -0700 (PDT) Message-Id: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs@gnu.org Lines: 41 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7L4Uvru006430 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) The patch below uses the high contrast "yellow" color for font-lock-comment-face on low color terminals using a dark background color. Yellow is not used by many other font-lock faces on such terminals. This will enable us to eliminate the need for the font-lock-comment-delimiter-face. (which the patch does not do, it just makes it identical to font-lock-comment-face, it will be done in an incremental patch). Index: lisp/font-lock.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/font-lock.el,v retrieving revision 1.351 diff -u -3 -p -r1.351 font-lock.el --- lisp/font-lock.el 2 Aug 2009 14:20:10 -0000 1.351 +++ lisp/font-lock.el 19 Aug 2009 05:15:42 -0000 @@ -1853,19 +1853,13 @@ Sets various variables using `font-lock- (((class color) (min-colors 8) (background light)) (:foreground "red")) (((class color) (min-colors 8) (background dark)) - ) + (:foreground "yellow")) (t (:weight bold :slant italic))) "Font Lock mode face used to highlight comments." :group 'font-lock-faces) (defface font-lock-comment-delimiter-face - '((default :inherit font-lock-comment-face) - (((class grayscale))) - (((class color) (min-colors 16))) - (((class color) (min-colors 8) (background light)) - :foreground "red") - (((class color) (min-colors 8) (background dark)) - :foreground "red1")) + '((default :inherit font-lock-comment-face)) "Font Lock mode face used to highlight comment delimiters." :group 'font-lock-faces) From lekktu@gmail.com Thu Oct 22 02:35:31 2009 Received: (at control) by emacsbugs.donarmstrong.com; 22 Oct 2009 09:35:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f213.google.com (mail-fx0-f213.google.com [209.85.220.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9M9ZTNW004084 for ; Thu, 22 Oct 2009 02:35:31 -0700 Received: by fxm9 with SMTP id 9so9696363fxm.1 for ; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=8EmqKmTQZFxRHmBqMf0mAHPBq3MFliknc0lztWoJq6Y=; b=HxQYupT4FFltZz1ItMJj0h3XTFYNK5e7ryT0Cek2T3YESYQLNQM8G9V9i2CKiMAEbc EvYuLj8f7w1qApk14qvzihjcYCGQUOU+1DBevO5UhGKLQhzQ6+vBiuihHNGFYaXeeEYe kJYg0CmwEGM5xp9e/Qz4pt4br7Ml4TcpNJkWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Y5ybjjcxlLdLgAFAm7oQwPF4q6enZ/vhDgoBesbKLPsYfKZBy2gNxuVUArd1lZsA9C Mqc9bcUQhekOxrkhuBrM/oRLNjZDm8m0DPtCnEMhvvK6rKfs9H9j6QMJR6VObUwlfUeo 7VB35jQ8OYFrwvpcsbgPdQA8bmjmcb1XFRU14= MIME-Version: 1.0 Received: by 10.239.145.8 with SMTP id q8mr761204hba.122.1256204124158; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) From: Juanma Barranquero Date: Thu, 22 Oct 2009 11:35:04 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 reassign 4326 emacs,ns merge 4261 4434 merge 1589 3359 4207 merge 3829 4077 tags 4781 + patch tags 4747 + patch tags 4579 + patch tags 4471 + patch tags 4434 + patch tags 4234 + patch tags 4221 + patch tags 4147 + patch tags 4144 + patch tags 4139 + patch tags 4023 + patch tags 4736 + moreinfo unreproducible tags 4547 + notabug tags 4451 + notabug tags 4448 + moreinfo tags 4427 + moreinfo tags 4373 + notabug tags 4360 + notabug tags 4271 + moreinfo tags 4236 + moreinfo tags 4143 + moreinfo unreproducible tags 4120 + moreinfo unreproducible tags 4070 + moreinfo unreproducible severity 4422 wishlist severity 4396 minor severity 4394 minor severity 4341 wishlist severity 4300 minor severity 4263 minor severity 4178 minor severity 4172 wishlist severity 4110 wishlist severity 4056 wishlist close 4772 close 4700 close 4599 close 4515 close 4463 close 4445 close 4395 close 4334 close 4289 close 4219 quit From unknown Sat Sep 20 14:39:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2011 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dan Nicolaescu Cc: 4221@debbugs.gnu.org Received: via spool by 4221-submit@debbugs.gnu.org id=B4221.131050491512773 (code B ref 4221); Tue, 12 Jul 2011 21:09:02 +0000 Received: (at 4221) by debbugs.gnu.org; 12 Jul 2011 21:08:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgkBz-0003Jm-Pm for submit@debbugs.gnu.org; Tue, 12 Jul 2011 17:08:35 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgkBu-0003JU-Pb for 4221@debbugs.gnu.org; Tue, 12 Jul 2011 17:08:30 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QgkBg-0005tj-PW; Tue, 12 Jul 2011 23:08:12 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 20 Aug 2009 21:30:57 -0700 (PDT)") Date: Tue, 12 Jul 2011 23:06:56 +0200 Message-ID: References: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Peter Gabriel's _Plays Live (1)_: "Not One Of Us" X-Hashcash: 1:23:110712:dann@ics.uci.edu::59/HxmRu4bGGs85u:0E+HA X-Hashcash: 1:23:110712:4221@debbugs.gnu.org::AgtjjdcX1qgEtz3Y:00000000000000000000000000000000000000000FPPn MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QgkBg-0005tj-PW X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311109693.28471@A/rB6HsObHZ3YMOpWOr+lg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Dan Nicolaescu writes: > The patch below uses the high contrast "yellow" color for > font-lock-comment-face on low color terminals using a dark background > color. > Yellow is not used by many other font-lock faces on such terminals. > > This will enable us to eliminate the need for the > font-lock-comment-delimiter-face. (which the patch does not do, it just > makes it identical to font-lock-comment-face, it will be done in an > incremental patch). That will make the delimiters the same colour as the comments. Is that what we want? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sat Sep 20 14:39:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 04:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Magne Ingebrigtsen Cc: Dan Nicolaescu , 4221@debbugs.gnu.org Received: via spool by 4221-submit@debbugs.gnu.org id=B4221.13105308665472 (code B ref 4221); Wed, 13 Jul 2011 04:22:01 +0000 Received: (at 4221) by debbugs.gnu.org; 13 Jul 2011 04:21:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgqwa-0001QA-If for submit@debbugs.gnu.org; Wed, 13 Jul 2011 00:21:06 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgqwY-0001PX-Ey for 4221@debbugs.gnu.org; Wed, 13 Jul 2011 00:21:03 -0400 Received: from cpe-66-108-39-217.nyc.res.rr.com ([66.108.39.217]:43113 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QgqwR-0002vX-7l; Wed, 13 Jul 2011 00:20:55 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 4FB96660D5; Wed, 13 Jul 2011 00:20:54 -0400 (EDT) From: Stefan Monnier Message-ID: References: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> Date: Wed, 13 Jul 2011 00:20:54 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 12 Jul 2011 23:06:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> The patch below uses the high contrast "yellow" color for >> font-lock-comment-face on low color terminals using a dark background >> color. >> Yellow is not used by many other font-lock faces on such terminals. >> >> This will enable us to eliminate the need for the >> font-lock-comment-delimiter-face. (which the patch does not do, it just >> makes it identical to font-lock-comment-face, it will be done in an >> incremental patch). > That will make the delimiters the same colour as the comments. Is that > what we want? I've always disliked the addition of font-lock-comment-delimiter-face, so yes, I do want that. Stefan From unknown Sat Sep 20 14:39:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Dan Nicolaescu , 4221@debbugs.gnu.org Received: via spool by 4221-submit@debbugs.gnu.org id=B4221.13105712811465 (code B ref 4221); Wed, 13 Jul 2011 15:35:01 +0000 Received: (at 4221) by debbugs.gnu.org; 13 Jul 2011 15:34:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1SP-0000NS-0h for submit@debbugs.gnu.org; Wed, 13 Jul 2011 11:34:40 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1SG-0000N5-OY for 4221@debbugs.gnu.org; Wed, 13 Jul 2011 11:34:32 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh1Rp-0004Az-PX; Wed, 13 Jul 2011 17:34:01 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Wed, 13 Jul 2011 00:20:54 -0400") Date: Wed, 13 Jul 2011 17:33:40 +0200 Message-ID: References: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Talking Heads's _Speaking in Tongues_: "I Get Wild-Wild Gravity" X-Hashcash: 1:23:110713:dann@ics.uci.edu::MUlM8TRIdeJPqrjB:065jH X-Hashcash: 1:23:110713:4221@debbugs.gnu.org::03cT/VEimKassBaV:00000000000000000000000000000000000000000MPEK X-Hashcash: 1:23:110713:monnier@iro.umontreal.ca::vvQeTYuMphZ/MB9G:0000000000000000000000000000000000000POR+ MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh1Rp-0004Az-PX X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311176043.96967@eaXUgRQ79sGu4Rd2zw/6mg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: > I've always disliked the addition of font-lock-comment-delimiter-face, > so yes, I do want that. Ok; I've now applied the patch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 11:36:27 2011 Received: (at control) by debbugs.gnu.org; 13 Jul 2011 15:36:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1UB-0000QF-0f for submit@debbugs.gnu.org; Wed, 13 Jul 2011 11:36:27 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1U9-0000Q3-H7 for control@debbugs.gnu.org; Wed, 13 Jul 2011 11:36:25 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh1RX-000446-MU for control@debbugs.gnu.org; Wed, 13 Jul 2011 17:33:43 +0200 Date: Wed, 13 Jul 2011 17:33:42 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #4221 X-MailScanner-ID: 1Qh1RX-000446-MU X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311176025.30342@AhrelwHt7KQU5sTYn//EBw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 4221 fixed close 4221 24.1