GNU bug report logs - #4221
improve font-lock-comment-face on dark background low color terminals

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4221 in the body.
You can then email your comments to 4221 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: improve font-lock-comment-face on dark background low color terminals
Date: Thu, 20 Aug 2009 21:30:57 -0700 (PDT)

The patch below uses the high contrast "yellow" color for
font-lock-comment-face on low color terminals using a dark background
color.
Yellow is not used by many other font-lock faces on such terminals.

This will enable us to eliminate the need for the
font-lock-comment-delimiter-face. (which the patch does not do, it just
makes it identical to font-lock-comment-face, it will be done in an
incremental patch).


Index: lisp/font-lock.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/font-lock.el,v
retrieving revision 1.351
diff -u -3 -p -r1.351 font-lock.el
--- lisp/font-lock.el 2 Aug 2009 14:20:10 -0000 1.351
+++ lisp/font-lock.el 19 Aug 2009 05:15:42 -0000
@@ -1853,19 +1853,13 @@ Sets various variables using `font-lock-
     (((class color) (min-colors 8) (background light))
      (:foreground "red"))
     (((class color) (min-colors 8) (background dark))
-     )
+     (:foreground "yellow"))
     (t (:weight bold :slant italic)))
   "Font Lock mode face used to highlight comments."
   :group 'font-lock-faces)
 
 (defface font-lock-comment-delimiter-face
-  '((default :inherit font-lock-comment-face)
-    (((class grayscale)))
-    (((class color) (min-colors 16)))
-    (((class color) (min-colors 8) (background light))
-     :foreground "red")
-    (((class color) (min-colors 8) (background dark))
-     :foreground "red1"))
+  '((default :inherit font-lock-comment-face))
   "Font Lock mode face used to highlight comment delimiters."
   :group 'font-lock-faces)
 

Message #8 received at 4221 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 4221 <at> debbugs.gnu.org
Subject: Re: improve font-lock-comment-face on dark background low color
	terminals
Date: Tue, 12 Jul 2011 23:06:56 +0200

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> The patch below uses the high contrast "yellow" color for
> font-lock-comment-face on low color terminals using a dark background
> color.
> Yellow is not used by many other font-lock faces on such terminals.
>
> This will enable us to eliminate the need for the
> font-lock-comment-delimiter-face. (which the patch does not do, it just
> makes it identical to font-lock-comment-face, it will be done in an
> incremental patch).

That will make the delimiters the same colour as the comments.  Is that
what we want?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #11 received at 4221 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Dan Nicolaescu <dann <at> ics.uci.edu>, 4221 <at> debbugs.gnu.org
Subject: Re: bug#4221: improve font-lock-comment-face on dark background low
	color terminals
Date: Wed, 13 Jul 2011 00:20:54 -0400

>> The patch below uses the high contrast "yellow" color for
>> font-lock-comment-face on low color terminals using a dark background
>> color.
>> Yellow is not used by many other font-lock faces on such terminals.
>> 
>> This will enable us to eliminate the need for the
>> font-lock-comment-delimiter-face. (which the patch does not do, it just
>> makes it identical to font-lock-comment-face, it will be done in an
>> incremental patch).

> That will make the delimiters the same colour as the comments.  Is that
> what we want?

I've always disliked the addition of font-lock-comment-delimiter-face,
so yes, I do want that.


        Stefan

Message #14 received at 4221 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Dan Nicolaescu <dann <at> ics.uci.edu>, 4221 <at> debbugs.gnu.org
Subject: Re: bug#4221: improve font-lock-comment-face on dark background low
	color terminals
Date: Wed, 13 Jul 2011 17:33:40 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> I've always disliked the addition of font-lock-comment-delimiter-face,
> so yes, I do want that.

Ok; I've now applied the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.