From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 19:05:21 2020 Received: (at submit) by debbugs.gnu.org; 4 Jul 2020 23:05:21 +0000 Received: from localhost ([127.0.0.1]:59807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrrDk-0002zh-NU for submit@debbugs.gnu.org; Sat, 04 Jul 2020 19:05:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:33694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrrDj-0002zZ-4y for submit@debbugs.gnu.org; Sat, 04 Jul 2020 19:05:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrrDi-0000Qf-6q for guix-patches@gnu.org; Sat, 04 Jul 2020 19:05:19 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:53462) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrrDf-0005xo-4V for guix-patches@gnu.org; Sat, 04 Jul 2020 19:05:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/Nehu3ORYLq6pB8XMRPNtJ361oGjWVJ8R+9BfjpGUQ4=; b=LJ8VPCzkgnWBYkbhd6R8e2aH1u B0Cgtq8euUgA9jPq1vxIYKmTBk1EDuBp6pu76OUt6aZ/r2YQPR3nC/bp4gu7DNSkiWNZPjs4PvL+i 8/rCrHkAmTL4kr0kHylgmfD8WTn7VeKgSV2f61CaU5O7hKubMHPSQZafh+RJ2mht3vIY=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrrDY-0008yE-6k; Sun, 05 Jul 2020 04:35:08 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH 0/1] weather: Print 0.0% correctly. Date: Sun, 5 Jul 2020 04:35:04 +0530 Message-Id: <20200704230504.6763-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/04 17:37:28 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a bit of a nitpick. When there are no substitues, `guix weather` reports it as ".0% substitutes available". It should instead report it as "0.0% substitutes unavailable". I didn't know what the '2' specifying width in ~2,1f was for. Hence, I have removed it. Feel free to correct me if I did something wrong. Arun Isaac (1): weather: Print 0.0% correctly. guix/scripts/weather.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 19:07:54 2020 Received: (at 42208) by debbugs.gnu.org; 4 Jul 2020 23:07:54 +0000 Received: from localhost ([127.0.0.1]:59815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrrGE-00033s-Kf for submit@debbugs.gnu.org; Sat, 04 Jul 2020 19:07:54 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:60296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrrGB-00033i-PX for 42208@debbugs.gnu.org; Sat, 04 Jul 2020 19:07:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fmegEX1zcnfmRR7BDjIfRIZH5vmBKOmwbUpoJTO0HKk=; b=C2nuG/8Yb3oQ/WYs9zc9yFmN8z 8HbOFvnYnNX+nMM+zVYavQclcMT65j2psz3EPiw+fPbDn3Z4ADGkGJMpaSKRmm1MCG1K+3equvHgu 5QDWkFeMpQHRwXdPG9UJiwPntIjtF25bQzXtaNKwDXmkJsbJJipIV9uRQ/1XJYeDGMTk=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrrG8-0009FX-LP; Sun, 05 Jul 2020 04:37:48 +0530 From: Arun Isaac To: 42208@debbugs.gnu.org Subject: [PATCH] weather: Print 0.0% correctly. Date: Sun, 5 Jul 2020 04:37:47 +0530 Message-Id: <20200704230747.6870-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42208 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/weather.scm (report-server-coverage): Report 0% coverage as 0.0%, not as .0%. --- guix/scripts/weather.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/weather.scm b/guix/scripts/weather.scm index 475d989357..3035ff6ca8 100644 --- a/guix/scripts/weather.scm +++ b/guix/scripts/weather.scm @@ -190,7 +190,7 @@ Return the coverage ratio, an exact number between 0 and 1." narinfos)) (time (+ (time-second time) (/ (time-nanosecond time) 1e9)))) - (format #t (G_ " ~2,1f% substitutes available (~h out of ~h)~%") + (format #t (G_ " ~,1f% substitutes available (~h out of ~h)~%") (* 100. (/ obtained requested 1.)) obtained requested) (let ((total (/ (reduce + 0 sizes) MiB))) -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 05 03:54:45 2020 Received: (at 42208) by debbugs.gnu.org; 5 Jul 2020 07:54:45 +0000 Received: from localhost ([127.0.0.1]:59960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrzU5-0007U0-Lf for submit@debbugs.gnu.org; Sun, 05 Jul 2020 03:54:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrzU1-0007Tl-HT for 42208@debbugs.gnu.org; Sun, 05 Jul 2020 03:54:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58653) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrzTu-00067A-QP; Sun, 05 Jul 2020 03:54:34 -0400 Received: from [2a01:e0a:fa:a50:84fd:6270:81db:82dd] (port=52518 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jrzTo-0006Jq-TR; Sun, 05 Jul 2020 03:54:34 -0400 From: Mathieu Othacehe To: Arun Isaac Subject: Re: [bug#42208] [PATCH 0/1] weather: Print 0.0% correctly. References: <20200704230504.6763-1-arunisaac@systemreboot.net> Date: Sun, 05 Jul 2020 09:54:26 +0200 In-Reply-To: <20200704230504.6763-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Sun, 5 Jul 2020 04:35:04 +0530") Message-ID: <87y2nyjt1p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42208 Cc: 42208@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Arun, > "0.0% substitutes unavailable". I didn't know what the '2' specifying width in > ~2,1f was for. Hence, I have removed it. Feel free to correct me if I did > something wrong. This "2" is the width argument of the ~f parameter (see https://www.gnu.org/software/guile/manual/html_node/Formatted-Output.html). It's supposed to pad left with spaces if the output is less than "2" characters. Anyway, the zero case is not handled properly as you noticed, so this looks good to me. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 05 06:46:27 2020 Received: (at 42208-done) by debbugs.gnu.org; 5 Jul 2020 10:46:27 +0000 Received: from localhost ([127.0.0.1]:60086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js2AF-0003CS-BB for submit@debbugs.gnu.org; Sun, 05 Jul 2020 06:46:27 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:60382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js2AD-0003CI-0Z for 42208-done@debbugs.gnu.org; Sun, 05 Jul 2020 06:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QlUSNjbgfyhgCtudlDQygzHrRScvbg2NrG+GT7V+jM0=; b=qXIKCrmhW1J4z7HtA8dzMhCx0 eZTTWteSbjhbgxj0a+aLoDTsFDJsVF9/tYBlEdfByBbqAbq3KADPyAEDWltag2Kf2WuPiDSKxEvrv tz1bs30GslDlmmnyYvEXx/1hYwWSbHHXpJhtr2kZeSHOAKEWLu/8kC39/CrR+M9A57jX8=; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1js2A9-000Fx2-3k; Sun, 05 Jul 2020 16:16:21 +0530 From: Arun Isaac To: Mathieu Othacehe Subject: Re: [bug#42208] [PATCH 0/1] weather: Print 0.0% correctly. In-Reply-To: <87y2nyjt1p.fsf@gnu.org> References: <20200704230504.6763-1-arunisaac@systemreboot.net> <87y2nyjt1p.fsf@gnu.org> Date: Sun, 05 Jul 2020 16:16:20 +0530 Message-ID: <87v9j2tf2b.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42208-done Cc: 42208-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Pushed to master, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl8Br3wACgkQLiXui2GA K7MvtAf+Ny9QdzbYCcq+UxdyRkSs/CRc3isbNYGn8IWLs361wm3evXW+MQ+Avsqd 1qH+b2L0ZAmEDs9yi4YAPeeWdDRCVqpUueBwxalU++77QYyWSSSGK20FiHGeTBCw Ahkuw4ZV5VxNGoNTJUkNvUbQgOSDOnbPIQQ+kBul9xu7cQ9D470coxY2yhdoGVaT 2KqIaoH7eJU6A5cDR1GlIYoN+cRktKAyeKmESA3vvbycZJJGn31tpJ5rxOgr7Sao 3NHYADxD+VvOUtYtki4lkiwwwEvmEnC5DrAHL1z0O0dI6h2VWCu5RdnOrGlLsg9B KKBHp1ZQiX68F7ASdypFRl667b9HrA== =TpAa -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Aug 19 12:49:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Aug 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator