GNU bug report logs - #42205
[PATCH] discovery: Fix typo.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42205 in the body.
You can then email your comments to 42205 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] discovery: Fix typo.
Date: Sun,  5 Jul 2020 03:46:13 +0530

* guix/discovery.scm (fold-module-public-variables*): In the docstring,
replace (PROC MODULE SYMBOL VARIABLE) with (PROC MODULE SYMBOL VARIABLE
RESULT).
---
 guix/discovery.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/guix/discovery.scm b/guix/discovery.scm
index 7c5fed7f0e..b84b9ff370 100644
--- a/guix/discovery.scm
+++ b/guix/discovery.scm
@@ -153,9 +153,9 @@ SUB-DIRECTORY. Modules are listed in the order they appear on the path."
   (reverse (fold-modules cons '() path #:warn warn)))
 
 (define (fold-module-public-variables* proc init modules)
-  "Call (PROC MODULE SYMBOL VARIABLE) for each variable exported by one of MODULES,
-using INIT as the initial value of RESULT.  It is guaranteed to never traverse
-the same object twice."
+  "Call (PROC MODULE SYMBOL VARIABLE RESULT) for each variable exported by one
+of MODULES, using INIT as the initial value of RESULT.  It is guaranteed to
+never traverse the same object twice."
   ;; Here SEEN is populated by variables; if two different variables refer to
   ;; the same object, we still let them through.
   (identity                                       ;discard second return value
-- 
2.26.2

Message #8 received at 42205 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 42205 <at> debbugs.gnu.org
Subject: Re: [bug#42205] [PATCH] discovery: Fix typo.
Date: Sun, 05 Jul 2020 10:00:45 +0200

Hey,

>  (define (fold-module-public-variables* proc init modules)
> -  "Call (PROC MODULE SYMBOL VARIABLE) for each variable exported by one of MODULES,
> -using INIT as the initial value of RESULT.  It is guaranteed to never traverse
> -the same object twice."
> +  "Call (PROC MODULE SYMBOL VARIABLE RESULT) for each variable exported by one
> +of MODULES, using INIT as the initial value of RESULT.  It is guaranteed to
> +never traverse the same object twice."
>    ;; Here SEEN is populated by variables; if two different variables refer to
>    ;; the same object, we still let them through.
>    (identity                                       ;discard second return value

This looks fine. Do not hesitate to proceed without reviewing for those
typo fixing patches :).

Thanks for your patch,

Mathieu

Message #13 received at 42205-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 42205-done <at> debbugs.gnu.org
Subject: Re: [bug#42205] [PATCH] discovery: Fix typo.
Date: Sun, 05 Jul 2020 16:10:15 +0530

[Message part 1 (text/plain, inline)]

> This looks fine. Do not hesitate to proceed without reviewing for those
> typo fixing patches :).

Ok, thanks! :-) Pushed to master.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.