From unknown Sun Jun 22 04:08:05 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42192] [PATCH 0/3] Improve launchpad updater Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jul 2020 18:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42192@debbugs.gnu.org Cc: Arun Isaac X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159388716717414 (code B ref -1); Sat, 04 Jul 2020 18:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jul 2020 18:26:07 +0000 Received: from localhost ([127.0.0.1]:59578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmrX-0004Wo-2u for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:26:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:52994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmrT-0004We-5O for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:26:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrmrS-00023g-4q for guix-patches@gnu.org; Sat, 04 Jul 2020 14:26:02 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:53970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrmrO-000126-Pb for guix-patches@gnu.org; Sat, 04 Jul 2020 14:26:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c7pqnoUa+At0fMsb55JB8k7van84gyxyy+GdfrUxfrU=; b=eIFgCxbbUYUbCMa1WJUrhK41YK 2ufwtM1dNUlWdxpiw92tz+mYN22uEj9dyLnOuD12yQ1KGONuEyjMEg2eWSqYtURlbp61cKZXd7RMq wqTHf8Mbm259LGBic8PMLhA/9xaEsvFe2hTqscQ3X1WX7n6JQGVH+2kS9hLw60NLYJOE=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrmrG-0000GW-Uv; Sat, 04 Jul 2020 23:55:51 +0530 From: Arun Isaac Date: Sat, 4 Jul 2020 23:55:48 +0530 Message-Id: <20200704182548.25280-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/04 14:25:53 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This patchset fixes a bug in the launchpad importer, and improves it to recognize more URLs and extensions. `guix refresh --list-updaters` reports an improvement in coverage from 0.1% to 0.2%. On a side note, all our updaters try to detect the URL format through a series of guesses. But, all our packages already encode information about how to construct the source URL from the version. If we could somehow tap into that information, our updaters would be much simpler. Unfortunately, all the uri fields of packages are strings. We would need them to be functions that take the version as an argument. This is a major conversion. Is it feasible? Any better ideas? Arun Isaac (3): import: launchpad: Handle list of source URLs correctly. import: launchpad: Recognize the .orig.tar.gz extension. import: launchpad: Recognize more URLs. guix/import/launchpad.scm | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) -- 2.26.2 From unknown Sun Jun 22 04:08:05 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42192] [PATCH 1/3] import: launchpad: Handle list of source URLs correctly. References: <20200704182548.25280-1-arunisaac@systemreboot.net> In-Reply-To: <20200704182548.25280-1-arunisaac@systemreboot.net> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jul 2020 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42192@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 42192-submit@debbugs.gnu.org id=B42192.159388762118208 (code B ref 42192); Sat, 04 Jul 2020 18:34:02 +0000 Received: (at 42192) by debbugs.gnu.org; 4 Jul 2020 18:33:41 +0000 Received: from localhost ([127.0.0.1]:59598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmyr-0004ja-Af for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:33:41 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:34720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmyp-0004jE-5L for 42192@debbugs.gnu.org; Sat, 04 Jul 2020 14:33:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n4MSeyDGBg+yYUagf43iqkAMBptC/QihtHQxlAdQW7E=; b=GtUgHIKD1YXSY3pvhtkcTcdqHS UFG8JsXW72jzLm2bL8otqMAh8vO9MgXNnLMFvaOROF8RukEU6yq4F6WX9vcDqjoY1xR6xnqg+2X6J Lpyk4Hnj2XkqJ8TtPmltT9caJc7KwGT6Y+FqhLMP5Cw+m8BnFzYFPyKySJSU7/HsWMUM=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrmyl-0004Fh-Ov; Sun, 05 Jul 2020 00:03:35 +0530 From: Arun Isaac Date: Sun, 5 Jul 2020 00:03:30 +0530 Message-Id: <20200704183332.25445-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/import/launchpad.scm (updated-launchpad-url): Return updated URL when package has a list of URLs, not the old URL. --- guix/import/launchpad.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guix/import/launchpad.scm b/guix/import/launchpad.scm index c7375837c7..1162cbe123 100644 --- a/guix/import/launchpad.scm +++ b/guix/import/launchpad.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2019 Arun Isaac +;;; Copyright © 2019, 2020 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -66,7 +66,7 @@ false if none is recognized" ((? string?) (updated-url source-uri)) ((source-uri ...) - (find updated-url source-uri)))))) + (any updated-url source-uri)))))) (_ #f))) (define (launchpad-package? package) -- 2.26.2 From unknown Sun Jun 22 04:08:05 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42192] [PATCH 3/3] import: launchpad: Recognize more URLs. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jul 2020 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42192@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 42192-submit@debbugs.gnu.org id=B42192.159388762918225 (code B ref 42192); Sat, 04 Jul 2020 18:34:02 +0000 Received: (at 42192) by debbugs.gnu.org; 4 Jul 2020 18:33:49 +0000 Received: from localhost ([127.0.0.1]:59600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmyr-0004jd-HF for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:33:49 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:34722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmyp-0004jG-4r for 42192@debbugs.gnu.org; Sat, 04 Jul 2020 14:33:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=v8m9yMJiZ/em8UnHU6jMll5EpQLiM5b4olljWqIPC0E=; b=qNtdUeTgvSoP92D6kF8cFpGKff f2qB6qrxNkDlwHdhmmg2p9BX630SORv9lL7nlueEKaq3BQAA1Lg7CGvdmp3V8MzjKilBoKr4ofz6F Fcxmmeb47sUO10b5ssb+f9qCO97sTt72Itad0Axn/RUep78kF5sBhyp90Q/3nhCtRnI8=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrmym-0004Fh-BW; Sun, 05 Jul 2020 00:03:36 +0530 From: Arun Isaac Date: Sun, 5 Jul 2020 00:03:32 +0530 Message-Id: <20200704183332.25445-3-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200704183332.25445-1-arunisaac@systemreboot.net> References: <20200704183332.25445-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/import/launchpad.scm (updated-launchpad-url): Recognize more URLs. --- guix/import/launchpad.scm | 32 ++++++++++++++++++++++++++------ 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/guix/import/launchpad.scm b/guix/import/launchpad.scm index c991ccfe6e..fd3cfa8444 100644 --- a/guix/import/launchpad.scm +++ b/guix/import/launchpad.scm @@ -46,15 +46,35 @@ false if none is recognized" (version (package-version old-package)) (repo (launchpad-repository url))) (cond - ((and - (>= (length (string-split version #\.)) 2) - (string=? (string-append "https://launchpad.net/" - repo "/" (version-major+minor version) - "/" version "/+download/" repo "-" version ext) - url)) + ((< (length (string-split version #\.)) 2) #f) + ((string=? (string-append "https://launchpad.net/" + repo "/" (version-major+minor version) + "/" version "/+download/" repo "-" version ext) + url) (string-append "https://launchpad.net/" repo "/" (version-major+minor new-version) "/" new-version "/+download/" repo "-" new-version ext)) + ((string=? (string-append "https://launchpad.net/" + repo "/" (version-major+minor version) + "/" version "/+download/" repo "_" version ext) + url) + (string-append "https://launchpad.net/" + repo "/" (version-major+minor new-version) + "/" new-version "/+download/" repo "-" new-version ext)) + ((string=? (string-append "https://launchpad.net/" + repo "/trunk/" version "/+download/" + repo "-" version ext) + url) + (string-append "https://launchpad.net/" + repo "/trunk/" new-version + "/+download/" repo "-" new-version ext)) + ((string=? (string-append "https://launchpad.net/" + repo "/trunk/" version "/+download/" + repo "_" version ext) + url) + (string-append "https://launchpad.net/" + repo "/trunk/" new-version + "/+download/" repo "_" new-version ext)) (#t #f))))) ; Some URLs are not recognised. (match (package-source old-package) -- 2.26.2 From unknown Sun Jun 22 04:08:05 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42192] [PATCH 2/3] import: launchpad: Recognize the .orig.tar.gz extension. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jul 2020 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42192@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 42192-submit@debbugs.gnu.org id=B42192.159388763018231 (code B ref 42192); Sat, 04 Jul 2020 18:34:02 +0000 Received: (at 42192) by debbugs.gnu.org; 4 Jul 2020 18:33:50 +0000 Received: from localhost ([127.0.0.1]:59602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmyz-0004ju-RM for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:33:50 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:34718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmyp-0004jD-5h for 42192@debbugs.gnu.org; Sat, 04 Jul 2020 14:33:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3W6fy5MkKhH2bA5vO+ymntKkXztGBPquX5g8ZIDJFPI=; b=Okmva8HqDkftOFqCM5WjJBPv0e /MN49ev1NcZwnBg6dPsAh0mvhO0VbYnavOmTSGpYNUhPzpawB5Su8zWQTrXLB3s14Q/45zUSK5qcN Z/3c7D0iN01mbbzJzYgRMw3dVujaiaLCnp1zguC6XvACaiSU7nurHpNc4YAy7NRVlU7c=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrmyl-0004Fh-Up; Sun, 05 Jul 2020 00:03:36 +0530 From: Arun Isaac Date: Sun, 5 Jul 2020 00:03:31 +0530 Message-Id: <20200704183332.25445-2-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200704183332.25445-1-arunisaac@systemreboot.net> References: <20200704183332.25445-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/import/launchpad.scm (find-extension): Recognize the .orig.tar.gz extension. --- guix/import/launchpad.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/launchpad.scm b/guix/import/launchpad.scm index 1162cbe123..c991ccfe6e 100644 --- a/guix/import/launchpad.scm +++ b/guix/import/launchpad.scm @@ -32,7 +32,7 @@ "Return the extension of the archive e.g. '.tar.gz' given a URL, or false if none is recognized" (find (lambda (x) (string-suffix? x url)) - (list ".tar.gz" ".tar.bz2" ".tar.xz" + (list ".orig.tar.gz" ".tar.gz" ".tar.bz2" ".tar.xz" ".zip" ".tar" ".tgz" ".tbz" ".love"))) (define (updated-launchpad-url old-package new-version) -- 2.26.2 From unknown Sun Jun 22 04:08:05 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42192] [PATCH 0/3] Improve launchpad updater Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Aug 2020 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 42192@debbugs.gnu.org Received: via spool by 42192-submit@debbugs.gnu.org id=B42192.159888058725849 (code B ref 42192); Mon, 31 Aug 2020 13:30:02 +0000 Received: (at 42192) by debbugs.gnu.org; 31 Aug 2020 13:29:47 +0000 Received: from localhost ([127.0.0.1]:51835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjsZ-0006ir-8P for submit@debbugs.gnu.org; Mon, 31 Aug 2020 09:29:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjsW-0006id-KK for 42192@debbugs.gnu.org; Mon, 31 Aug 2020 09:29:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56100) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjsP-0001DE-S5; Mon, 31 Aug 2020 09:29:37 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36212 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCjsO-0007Id-NI; Mon, 31 Aug 2020 09:29:37 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200704182548.25280-1-arunisaac@systemreboot.net> Date: Mon, 31 Aug 2020 15:29:34 +0200 In-Reply-To: <20200704182548.25280-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Sat, 4 Jul 2020 23:55:48 +0530") Message-ID: <87pn77c5a9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Arun, Arun Isaac skribis: > This patchset fixes a bug in the launchpad importer, and improves it to > recognize more URLs and extensions. `guix refresh --list-updaters` report= s an > improvement in coverage from 0.1% to 0.2%. All three patches LGTM, thank you! > On a side note, all our updaters try to detect the URL format through a s= eries > of guesses. But, all our packages already encode information about how to > construct the source URL from the version. If we could somehow tap into t= hat > information, our updaters would be much simpler. Unfortunately, all the u= ri > fields of packages are strings. We would need them to be functions that t= ake > the version as an argument. This is a major conversion. Is it feasible? A= ny > better ideas? I sympathize with the idea, but I think it=E2=80=99s a bit too ambitious. = All in all, what we currently have seems like a reasonable tradeoff. Ludo=E2=80=99. From unknown Sun Jun 22 04:08:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Arun Isaac Subject: bug#42192: closed (Re: [bug#42192] [PATCH 0/3] Improve launchpad updater) Message-ID: References: <87zh691ki9.fsf@systemreboot.net> <20200704182548.25280-1-arunisaac@systemreboot.net> X-Gnu-PR-Message: they-closed 42192 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 42192@debbugs.gnu.org Date: Tue, 01 Sep 2020 17:21:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1598980861-22010-1" This is a multi-part message in MIME format... ------------=_1598980861-22010-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42192: [PATCH 0/3] Improve launchpad updater which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42192@debbugs.gnu.org. --=20 42192: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42192 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1598980861-22010-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42192-done) by debbugs.gnu.org; 1 Sep 2020 17:20:55 +0000 Received: from localhost ([127.0.0.1]:57126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD9xn-0005iY-1S for submit@debbugs.gnu.org; Tue, 01 Sep 2020 13:20:55 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:44844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD9xi-0005iN-NT for 42192-done@debbugs.gnu.org; Tue, 01 Sep 2020 13:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=akxCslo2wf3xvTOHe6lcLspBmLU28QdSiQEu0KIcVF4=; b=p+1Jv+D9g9H+/ex5AOJicXrlDS AzlbsSDQ1NuO+KjgRP6ufLLI09IFgwy5ro/3C9rpx0iabzWceAEz/0v2XTtpS+BSTUh+jwh4ADrHH tIFdrh2CECmeXDLOylMpUxbZIBnO+K3qTpe/2AzieQogFFNRqB51fpiuUccUN5x3sf/EfN+7zo+pk C9kzR9oDLL+neLzHc9mgnc5FaEMesRX4hBKroCsGKTTNwTrfID6de0VgGhlEcrQc6eHyQ8b96yHGK m1jWH9HRxIWRx4Q8kk7cpB55YZWTZyfylwcKx2B+EhZeO20QfwwxWuiWXWmQhC4jzrzcifbX1Fmv7 qM12kpag==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kD9ww-000EJf-DY; Tue, 01 Sep 2020 22:50:02 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#42192] [PATCH 0/3] Improve launchpad updater In-Reply-To: <87pn77c5a9.fsf@gnu.org> References: <20200704182548.25280-1-arunisaac@systemreboot.net> <87pn77c5a9.fsf@gnu.org> Date: Tue, 01 Sep 2020 22:50:46 +0530 Message-ID: <87zh691ki9.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42192-done Cc: 42192-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> This patchset fixes a bug in the launchpad importer, and improves it to >> recognize more URLs and extensions. `guix refresh --list-updaters` repor= ts an >> improvement in coverage from 0.1% to 0.2%. > > All three patches LGTM, thank you! Pushed to master, thanks for the review! > I sympathize with the idea, but I think it=E2=80=99s a bit too ambitious.= All > in all, what we currently have seems like a reasonable tradeoff. Fair enough. :-) ------------=_1598980861-22010-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jul 2020 18:26:07 +0000 Received: from localhost ([127.0.0.1]:59578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmrX-0004Wo-2u for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:26:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:52994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrmrT-0004We-5O for submit@debbugs.gnu.org; Sat, 04 Jul 2020 14:26:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrmrS-00023g-4q for guix-patches@gnu.org; Sat, 04 Jul 2020 14:26:02 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:53970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrmrO-000126-Pb for guix-patches@gnu.org; Sat, 04 Jul 2020 14:26:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c7pqnoUa+At0fMsb55JB8k7van84gyxyy+GdfrUxfrU=; b=eIFgCxbbUYUbCMa1WJUrhK41YK 2ufwtM1dNUlWdxpiw92tz+mYN22uEj9dyLnOuD12yQ1KGONuEyjMEg2eWSqYtURlbp61cKZXd7RMq wqTHf8Mbm259LGBic8PMLhA/9xaEsvFe2hTqscQ3X1WX7n6JQGVH+2kS9hLw60NLYJOE=; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jrmrG-0000GW-Uv; Sat, 04 Jul 2020 23:55:51 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH 0/3] Improve launchpad updater Date: Sat, 4 Jul 2020 23:55:48 +0530 Message-Id: <20200704182548.25280-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/04 14:25:53 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This patchset fixes a bug in the launchpad importer, and improves it to recognize more URLs and extensions. `guix refresh --list-updaters` reports an improvement in coverage from 0.1% to 0.2%. On a side note, all our updaters try to detect the URL format through a series of guesses. But, all our packages already encode information about how to construct the source URL from the version. If we could somehow tap into that information, our updaters would be much simpler. Unfortunately, all the uri fields of packages are strings. We would need them to be functions that take the version as an argument. This is a major conversion. Is it feasible? Any better ideas? Arun Isaac (3): import: launchpad: Handle list of source URLs correctly. import: launchpad: Recognize the .orig.tar.gz extension. import: launchpad: Recognize more URLs. guix/import/launchpad.scm | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) -- 2.26.2 ------------=_1598980861-22010-1--