GNU bug report logs - #42184
27.0.91; org-fontify-whole-heading-line does not work in emacs 27

Previous Next

Full log

Message #44 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#42184: 27.0.91;
 org-fontify-whole-heading-line does not work in emacs 27
Date: Thu, 06 Aug 2020 11:32:18 +0200

[Message part 1 (text/plain, inline)]

Kyle Meyer <kyle <at> kyleam.com> writes:

> Kévin Le Gouguec writes:
>
>> Here is a variant of the previous patch, which correctly resets :extend
>> to nil if the user disables the relevant options (after reverting the
>> current buffer, or for newly opened ones).
>>
>> This ends up looking similar to what Org does for org-hide; IMO this
>> seems like the most straightforward short-term fix.  In the long run,
>> these user options would probably deserve :set functions.
>
> Thanks for working on this fix.  I of course can't speak for Bastien or
> Nicolas, but this patch looks fine to me.  Assuming it's okay with Eli,
> I'd suggest applying it to the emacs-27 branch.  (Once applied, I'd port
> it to the Org repo, as I do with other changes in the Emacs repo that
> touch Org files.)

Thank you for the review.  I hope this can make it into 27.1 since this
bug seems to be getting some attention[1][2], but the (tentative?)
etc/HISTORY file on the emacs-27 branch makes me wonder if we aren't too
close to the release day…

> Upstream in the thread you wrote:
>
>> Relatedly (but not crucial to solving this bug), should org-block and
>> org-block-background also have :extend t?  It would make sense to me
>> since they delimit visual "blocks".
>
> That would make sense to me as well.

OK, here's a patch to do that for org-block:

[0001-lisp-org-org-faces.el-org-block-Set-face-extension-b.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

>                                       (org-block-background hasn't
> existed since v8.3, though.)

Huh!  I guess that calls for a further patch:

[0001-etc-themes-leuven-theme.el-class-Remove-obsolete-fac.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

(AFAICT this was the only reference to org-block-background in all Elisp
files.)

All three patches squashed together:

[0001-Fix-org-fontify-whole-line-by-setting-face-extension.patch (text/x-patch, attachment)]

[Message part 7 (text/plain, inline)]

[1] https://orgmode.org/list/87365za8yk.fsf <at> gmail.com/t/#mac68a8ca95f64cb3fe7161bb44454253aad39fd6
[2] https://old.reddit.com/r/emacs/comments/i26n46/why_does_my_orgmode_look_different_to_leuven/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.