Subject: Re: [bug#42180] [PATCH v2 21/23] gnu: Add erlang-rebar3-git-vsn.

From: Maxime Devos <[email-masked]>
Date: Wed, 06 Oct 2021 20:43:33 +0200

Hartmut Goebel schreef op wo 06-10-2021 om 17:20 [+0200]:
> * gnu/packages/erlang.scm (erlang-rebar3-git-vsn): New variable.
> ---
>  gnu/packages/erlang.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index 6003bec251..0e8a277970 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -38,6 +38,7 @@
>    #:use-module (gnu packages gl)
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages perl)
> +  #:use-module (gnu packages version-control)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages wxwidgets))
>  
> @@ -511,6 +512,35 @@ testing of stateful systems.")
>      (description "This package provides an Erlang providers library.")
>      (license license:asl2.0)))
>  
> +(define-public erlang-rebar3-git-vsn
> +  (package
> +    (name "erlang-rebar3-git-vsn")
> +    (version "1.1.1")
> +    (source
> +      (origin
> +        (method hexpm-fetch)
> +        (uri (hexpm-uri "rebar3_git_vsn" version))
> +        (sha256
> +          (base32 "1ra4xjyc40r97aqb8aq2rll1v8wkf9jyisnbk34xdqcgv9s9iw7d"))))
> +    (build-system rebar3-build-system)
> +    (inputs
> +     `(("git" ,git)))
> +    (arguments
> +     `(#:tests? #f ;; depends on rebar TODO: remove this dependency

I think you meant: ‘TODO: add this dependency here’.
I notice there's a ‘rebar’ package, which is also an implicit
input of rebar5-build-system, so maybe this ‘TODO: ’ has already been
resolved, and #:tests? can be set to #true?

Likewise for other packages.

Greetings,
Maxime