From unknown Wed Jun 18 23:07:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42168 <42168@debbugs.gnu.org> To: bug#42168 <42168@debbugs.gnu.org> Subject: Status: 26.1; cperl-mode: Bad interpretation of $a++ / $b Reply-To: bug#42168 <42168@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:07:24 +0000 retitle 42168 26.1; cperl-mode: Bad interpretation of $a++ / $b reassign 42168 emacs submitter 42168 Harald J=C3=B6rg severity 42168 minor tag 42168 confirmed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 02 15:36:53 2020 Received: (at submit) by debbugs.gnu.org; 2 Jul 2020 19:36:53 +0000 Received: from localhost ([127.0.0.1]:55687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jr50u-0007xh-LC for submit@debbugs.gnu.org; Thu, 02 Jul 2020 15:36:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:52478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jr3o4-00062x-VD for submit@debbugs.gnu.org; Thu, 02 Jul 2020 14:19:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr3o4-0003KX-Q5 for bug-gnu-emacs@gnu.org; Thu, 02 Jul 2020 14:19:32 -0400 Received: from mout01.posteo.de ([185.67.36.65]:38039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr3ny-0007Hr-Ka for bug-gnu-emacs@gnu.org; Thu, 02 Jul 2020 14:19:32 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 22F39160061 for ; Thu, 2 Jul 2020 20:19:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1593713963; bh=29I2E1dWMYgLl91oZJM//4WnhTgpzO5OcoMRFcqM8cQ=; h=To:Subject:From:Autocrypt:Date:From; b=oAaUpSSMZo4UZ26cc2ZCJahZ8OmriX2FUA5iujIgwTXKgxuLorepWKLroilOVaXux 6r1qEInLQeT3trsO068EOjxp71c2YbjYJ7kXUtOMTWHQu8haEfnIQCttsM47iTEFvO 3GK6UX94rwJDR1g7PltQXFPmpJn7gB/2TSP5AdZn7RYWNb7yDrSyEQNGcwl2IHViqx hXEO5Hfbpb3Qs1Z8cFhxjwwOtmhgsuFb6hp6lM20uCZKdsXQM4c2sF61P5ziqC35or VqHrl59BntQDVKYelJBFFhKf7RNgIdTM0HwFe/ueESw7UcNXJwA4WgJYjjNStg9rGx jQTsHXM4glYLw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49yRFQ3fq9z6tmN for ; Thu, 2 Jul 2020 20:19:22 +0200 (CEST) To: bug-gnu-emacs@gnu.org Subject: 26.1; cperl-mode: Bad interpretation of $a++ / $b From: =?UTF-8?Q?Harald_J=c3=b6rg?= Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: Date: Thu, 2 Jul 2020 20:19:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7ECC07DA57C47CBF210F3B2F" Content-Language: en-US Received-SPF: pass client-ip=185.67.36.65; envelope-from=haj@posteo.de; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 14:19:23 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 02 Jul 2020 15:36:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------7ECC07DA57C47CBF210F3B2F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit How to reproduce: In a buffer, activate cperl-mode (M-x cperl-mode), then enter: $a++ / $b; This is supposed to be a division. However, cperl-mode interprets the slash as the start of a regular expression. Accordingly, the following text is displayed with the wrong face, and also cperl-mode might complain that it can't find the end of the regular expression. Emacs does not crash. Attached: A patch which fixes the issue for $a++ and $a--, and also includes a test to verify that the very similar text "$a+ / $b" is still correctly interpreted as a regular expression. Disclaimer: I'm rather new to elisp and even newer to ERT. Cheers, haj --------------7ECC07DA57C47CBF210F3B2F Content-Type: text/x-patch; charset=UTF-8; name="postincrement.diff" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="postincrement.diff" diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index cdbb59a5ad..2ba6921643 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -3978,6 +3978,9 @@ the sections using `cperl-pod-head-face', `cperl-pod-face', (and (eq (preceding-char) ?.) (eq (char-after (- (point) 2)) ?.)) (bobp)) + ;; { $a++ / $b } doesn't start a regex, nor does $a-- + (not (and (memq (preceding-char) '(?+ ?-)) + (eq (preceding-char) (char-before (1- (point)))))) ;; m|blah| ? foo : bar; (not (and (eq c ?\?) diff --git a/test/lisp/progmodes/cperl-mode/cperl-fontification-tests.el b/test/lisp/progmodes/cperl-mode/cperl-fontification-tests.el new file mode 100644 index 0000000000..4148db036c --- /dev/null +++ b/test/lisp/progmodes/cperl-mode/cperl-fontification-tests.el @@ -0,0 +1,55 @@ +;;; cperl-fontification-tests.el --- Test fontification in cperl-mode -*- lexical-binding: t -*- + +;; Copyright (C) 2020-2020 ...to be decided ... + +;; Author: Harald Jörg +;; Maintainer: Harald Jörg +;; Keywords: internal +;; Human-Keywords: internal +;; Homepage: https://github.com/HaraldJoerg/cperl-mode + +;;; Commentary: + +;; This is a collection of Tests for the fontification of CPerl-mode. +;; The primary target is to verify that the refactoring we're doing +;; right now (May 2020 - ...) doesn't change any behavior, or does the +;; right thing in cases where new fontification rules are enabled. + +;; Run these tests interactively: +;; (ert-run-tests-interactively '(tag :fontification)) + +(defun cperl-test-face (text regexp) + "Returns the face of the first character matched by REGEXP in TEXT." + (interactive) + (with-temp-buffer + (let ((cperl-hairy nil) + (cperl-font-lock nil)) ;; Does this matter? + (insert text) + (cperl-mode) + (font-lock-fontify-buffer) + (goto-char (point-min)) + (re-search-forward regexp) + (message "%s" (match-string 0)) + (get-text-property (match-beginning 0) 'face)))) + +(ert-deftest jrockway-issue-45 () + "Verify that '/' is a division after ++ or --, not a regexp. +Reported in https://github.com/jrockway/cperl-mode/issues/45. +If seen as regular expression, then the slash is displayed using +font-lock-constant-face. If seen as a division, then it doesn't +have a face property." + :tags '(:fontification) + ;; The next two Perl expressions have divisions. Perl "punctuation" + ;; operators don't get a face. The comment at the end of line + ;; prevents cperl-mode from tripping over "End of ‘/ ... /’ + ;; string/RE not found" if it gets it wrong + (let ((code "{ $a++ / $b } # /")) + (should (equal (cperl-test-face code "/" ) nil))) + (let ((code "{ $a-- / $b } # /")) + (should (equal (cperl-test-face code "/" ) nil))) + ;; The next two Perl expressions have regular expressions. The + ;; delimiter of a RE is fontified with font-lock-constant-face. + (let ((code "{ $a+ / $b } # /")) + (should (equal (cperl-test-face code "/" ) font-lock-constant-face))) + (let ((code "{ $a- / $b } # /")) + (should (equal (cperl-test-face code "/" ) font-lock-constant-face)))) --------------7ECC07DA57C47CBF210F3B2F-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 11 05:54:07 2020 Received: (at 42168) by debbugs.gnu.org; 11 Jul 2020 09:54:08 +0000 Received: from localhost ([127.0.0.1]:43849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juCCt-0000md-MA for submit@debbugs.gnu.org; Sat, 11 Jul 2020 05:54:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juCCr-0000m9-HW for 42168@debbugs.gnu.org; Sat, 11 Jul 2020 05:54:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53872) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juCCl-0006Oi-LZ; Sat, 11 Jul 2020 05:53:59 -0400 Received: from [176.228.60.248] (port=4274 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1juCCl-0000Hi-24; Sat, 11 Jul 2020 05:53:59 -0400 Date: Sat, 11 Jul 2020 12:53:49 +0300 Message-Id: <83v9iunzrm.fsf@gnu.org> From: Eli Zaretskii To: Harald =?utf-8?Q?J=C3=B6rg?= In-Reply-To: (message from Harald =?utf-8?Q?J=C3=B6rg?= on Thu, 2 Jul 2020 20:19:21 +0200) Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42168 Cc: 42168@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Harald Jörg > Date: Thu, 2 Jul 2020 20:19:21 +0200 > > How to reproduce: > In a buffer, activate cperl-mode (M-x cperl-mode), then enter: > > $a++ / $b; > > This is supposed to be a division. However, cperl-mode interprets the > slash as the start of a regular expression. Accordingly, the following > text is displayed with the wrong face, and also cperl-mode might > complain that it can't find the end of the regular expression. > > Emacs does not crash. > > Attached: A patch which fixes the issue for $a++ and $a--, and also > includes a test to verify that the very similar text "$a+ / $b" is still > correctly interpreted as a regular expression. Thanks. To accept a substantial contribution such as this one, we will need you to assign the copyright of your code to the FSF. If you are okay with starting your legal paperwork, I will send you the form to sign and email. Thank you for your interest in Emacs. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 20:40:29 2020 Received: (at 42168) by debbugs.gnu.org; 13 Aug 2020 00:40:29 +0000 Received: from localhost ([127.0.0.1]:46079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k61ID-0007FY-D8 for submit@debbugs.gnu.org; Wed, 12 Aug 2020 20:40:29 -0400 Received: from mail-yb1-f176.google.com ([209.85.219.176]:40988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k61I9-0007Ey-HN for 42168@debbugs.gnu.org; Wed, 12 Aug 2020 20:40:26 -0400 Received: by mail-yb1-f176.google.com with SMTP id s195so2362352ybc.8 for <42168@debbugs.gnu.org>; Wed, 12 Aug 2020 17:40:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=WdLDsgDIej8ZgM0EpBCN7KQO10Ow1PbG2jTUhPaHXpk=; b=GRgmoH/H+iy79vO0pIGQhzcRLUDnJz7pnjLzfQD3xoOyI/TYhIN4o7YuNb266m5gVv pDFl5H3sRbXOO0z0Kn18BMYOcFXLlPg9DaBVTBmWRa6FcLLhOBBHvKSbWc/1QE6cWUA5 uPtfQPW44IY0aYWQEVFDhAGLhZBPfuYY8r1ba2zd3R++zIPZM58vAbHTZk7uW04FGyPZ 5YtRmP8qJHBRGhw+RK3IDfudTxlYaWNX/KPx5jULTigBHLujEn7kBwb2px3sJYmQ3B67 gmqnaQtlibQCtDdNJhR0hHl6aUPnRfav0ree8iUmR8EvSsSwnQQ/x+7z4CXWaG8QwDAV bsGQ== X-Gm-Message-State: AOAM532vbg1v8PlDQ5yl8/hatXUzznZg/7pFoKtYFfL7b1W8h83UTAM5 m1GULlrXSv2XHkG0gl9Wh5m202AL+KOHxpvCRtScse/E6IU= X-Google-Smtp-Source: ABdhPJwuV9WmWouPqpg8XuCPN33q2XC1Rg9EZc42MINQ1a1pRtF0uJWxxPq1AkgQj4F/slAeO4Abm+7D7KNLLRqjwLk= X-Received: by 2002:a5b:508:: with SMTP id o8mr3267507ybp.43.1597279220064; Wed, 12 Aug 2020 17:40:20 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Aug 2020 17:40:19 -0700 From: Stefan Kangas In-Reply-To: <83v9iunzrm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Jul 2020 12:53:49 +0300") References: <83v9iunzrm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 12 Aug 2020 17:40:19 -0700 Message-ID: Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42168 Cc: 42168@debbugs.gnu.org, =?UTF-8?B?SGFyYWxkIErDtnJn?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Harald J=C3=B6rg >> Date: Thu, 2 Jul 2020 20:19:21 +0200 >> >> How to reproduce: >> In a buffer, activate cperl-mode (M-x cperl-mode), then enter: >> >> $a++ / $b; >> >> This is supposed to be a division. However, cperl-mode interprets the >> slash as the start of a regular expression. Accordingly, the following >> text is displayed with the wrong face, and also cperl-mode might >> complain that it can't find the end of the regular expression. >> >> Emacs does not crash. >> >> Attached: A patch which fixes the issue for $a++ and $a--, and also >> includes a test to verify that the very similar text "$a+ / $b" is still >> correctly interpreted as a regular expression. > > Thanks. > > To accept a substantial contribution such as this one, we will need > you to assign the copyright of your code to the FSF. If you are okay > with starting your legal paperwork, I will send you the form to sign > and email. > > Thank you for your interest in Emacs. Harald, would you be willing to sign the copyright papers? Please find out more about the reason for this here: https://www.gnu.org/licenses/why-assign.html Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 03:30:51 2020 Received: (at 42168) by debbugs.gnu.org; 13 Aug 2020 07:30:51 +0000 Received: from localhost ([127.0.0.1]:46642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k67hL-00087E-Cf for submit@debbugs.gnu.org; Thu, 13 Aug 2020 03:30:51 -0400 Received: from mout01.posteo.de ([185.67.36.65]:48529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k67hJ-00086z-I3 for 42168@debbugs.gnu.org; Thu, 13 Aug 2020 03:30:50 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id F0BD9160060 for <42168@debbugs.gnu.org>; Thu, 13 Aug 2020 09:30:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1597303843; bh=HGCfydUwfgObESXudqv0YZUsO6kQVFgWDtbokH26VBw=; h=Subject:To:Cc:From:Autocrypt:Date:From; b=Pt0CnHeZ/IrzF24qDtNTK3ZYB5ZRWdOG7QN3RE6zV216SBGoy5Pq6q6+gXFsf88+f a8ugPofwBM6TgbUP4Dztv0ODhjkbf0NgJUJ000DPSZbDfe3Wp4M2FzxhzsEMmoWxSo QFWW8zSSGK27H/xyHkK292oLtgb5md5IyJRRd0faG/kmPGT8pCsQ5EiAxKO9NRSNuG TL5O6W5Co/9Wm02cVTv/ONhCgPuUN0DvErzR3bqabPVHI79Lk9skplmqGE/ovo0/wM N1q0AzMwCxzQhLtbKZnC32nPbG53V7mWAhZp/mbPnlCQcbLZ5Q3ZeC3Jy2wGXjvVB4 dtVAArhkhts5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BRysZ08xtz6tmM; Thu, 13 Aug 2020 09:30:41 +0200 (CEST) Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b To: Stefan Kangas , Eli Zaretskii References: <83v9iunzrm.fsf@gnu.org> From: =?UTF-8?Q?Harald_J=c3=b6rg?= Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: <69f18471-a64d-98cd-5ece-f99ba6486831@posteo.de> Date: Thu, 13 Aug 2020 09:30:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42168 Cc: 42168@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 8/13/20 2:40 AM, Stefan Kangas wrote: > Eli Zaretskii writes: > >>> From: Harald Jörg >>> [...] >> Thanks. >> >> To accept a substantial contribution such as this one, we will need >> you to assign the copyright of your code to the FSF. If you are okay >> with starting your legal paperwork, I will send you the form to sign >> and email. >> >> Thank you for your interest in Emacs. > > Harald, would you be willing to sign the copyright papers? Please find > out more about the reason for this here: > > https://www.gnu.org/licenses/why-assign.html I forgot to inform anyone, but this process has already been completed! According to Lars Ingebrigtsen my name is already on "the list", so the legal stuff should be out of the way. -- Cheers, haj From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 03:55:38 2020 Received: (at 42168) by debbugs.gnu.org; 13 Aug 2020 07:55:38 +0000 Received: from localhost ([127.0.0.1]:46674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k685K-0000GG-82 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 03:55:38 -0400 Received: from mail-yb1-f178.google.com ([209.85.219.178]:36394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k685I-0000Fx-3s for 42168@debbugs.gnu.org; Thu, 13 Aug 2020 03:55:37 -0400 Received: by mail-yb1-f178.google.com with SMTP id g3so2845609ybc.3 for <42168@debbugs.gnu.org>; Thu, 13 Aug 2020 00:55:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=28Q6SwZpi+1c6g5J0Z44mFcDoVT1NajoN6Kvtm0Gqog=; b=Oc6blSxMM9vN+628XD3hPH4hp4zu0HZi5k1KVFf+LKhGmtKQ5y+mLI72Ou2jDyzoBn Z/W8gMULuVLKpWM7V4QCDRvTOOcGI7aLWkWlIKw0qoIEk7OXvDDpmme94Ikj/M0tj9rz J+Z/A/fCpxUBTYdRXVMIjSbNbBSxu857lgoWO6jcsrwRj9OxTvT8hVQ8MZTlMFQKAReo vuQJ0q4Rr1fzRtdd3xYsg09Uk4uaOBMPc3iDX77BGUbXAQaPqooFCTqNggYYNDDEqw/a 4iIfLnajLADegmNSUow+AW0b47qqF9CUMn9pE5PzsP1190v8xstcSH1/gEctp9KAD6Re nQIg== X-Gm-Message-State: AOAM532aJPCEFAZjYzAsPGQ9Q7B+qDZiU3mxSEInVHlH3yM8nWi41PqC gmGb2p2dkGo4W1h8fMiHol+UTypX4nZFC8dutbQ= X-Google-Smtp-Source: ABdhPJxm0N/nX0GEhyG7aADZaGTYx543+gWgv93c++LXEiJTzsbCEpkyoOrVV1tqmOFJ+0kD5z2P+ttxEMYCXNMrLQE= X-Received: by 2002:a5b:508:: with SMTP id o8mr5225893ybp.43.1597305330655; Thu, 13 Aug 2020 00:55:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 00:55:30 -0700 From: Stefan Kangas In-Reply-To: <69f18471-a64d-98cd-5ece-f99ba6486831@posteo.de> References: <83v9iunzrm.fsf@gnu.org> <69f18471-a64d-98cd-5ece-f99ba6486831@posteo.de> MIME-Version: 1.0 Date: Thu, 13 Aug 2020 00:55:30 -0700 Message-ID: Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b To: =?UTF-8?B?SGFyYWxkIErDtnJn?= , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42168 Cc: 42168@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > I forgot to inform anyone, but this process has already been completed! > According to Lars Ingebrigtsen my name is already on "the list", so the > legal stuff should be out of the way. Excellent, welcome to Emacs! I will review your patch now. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 04:18:07 2020 Received: (at 42168) by debbugs.gnu.org; 13 Aug 2020 08:18:07 +0000 Received: from localhost ([127.0.0.1]:46715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68R4-00033s-TZ for submit@debbugs.gnu.org; Thu, 13 Aug 2020 04:18:07 -0400 Received: from mail-yb1-f177.google.com ([209.85.219.177]:44479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68R3-00033N-KX for 42168@debbugs.gnu.org; Thu, 13 Aug 2020 04:18:06 -0400 Received: by mail-yb1-f177.google.com with SMTP id i10so2847859ybt.11 for <42168@debbugs.gnu.org>; Thu, 13 Aug 2020 01:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=vkmhd6MtubjkKkh7YDKmhR+9ZwtzidNVgOuSx9u2pPI=; b=pBwTS8MD1nsNFiJiy4Zu6MD10oQi7OcbSt9vyb5MsP94oAL1Xwlp0pzOobioPhyKZB EBE719biSKd4veL2QeJCbZow+FPMmrxfRwGIGS+i5CL1tIko3p6FKmDLN+qXjYNASZfH f4IMn+4vO4QQsgyNBcgO4JhBRU5T+ytoLwVt/2LDVq4Qv3/do0EfZNcdFQLn3rXBa1JU /k/RcYsyCe8N73OCfw4qjEBn9dF5p1WcfcFXe48A8MVARHouTGc65V+aQGvikGJLv0Vf 2AEA3K1P0m0mV69ODieDtDaQ8R3LikUfBfQXGRcECDNNF3rVzWYDcVwVMu96tgbNiFZW PNdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=vkmhd6MtubjkKkh7YDKmhR+9ZwtzidNVgOuSx9u2pPI=; b=W1yGBIy4fzdCDXYWZK8oOZwBwyGrhl5BztDnjeT0BwkWqdR4Rb74bEbdCQDIR4Wpis 1/7mqKIOdRNbZaEmDFtpY8GCXee4vf4okfQ4O5n5C8PDdj9WZAMkIhxu/cOKb0X5HALL MajB6OI1pv+NaPMb7/Ksc0ec8/qOZEaqdLXhnBNJh/bn3Ph3HNczoTTSi7V6wBZj1beh W+uqPa/ErPy94eeE7bD1CVxYo04B/crVekmkR44iiclesORVEyj0RmrjTiP02p0kA0DK xMt6usKRr5MwcAPOuMRPH4TuH8gWz7s0EriEpHA8BxqgxVo5DtwQIxEkjKHLH2zcvMq5 Hngw== X-Gm-Message-State: AOAM530fIZ71c7d9RojlH770OHyaxmySF8ADIgUCUGnHju3qCSnahX0Z oMSHrm0Ucg3UdjJkDgXYAv4Nq9jHaDpBmBbQMhQ= X-Google-Smtp-Source: ABdhPJzAQ94dghdFWO8xNY/gJ5KRQ2PkEWVDbPlmkjhD73Djen9Us9PIPrprWaUNQSUq22yvs0zMc8+HV6fuS9WlQDY= X-Received: by 2002:a25:7007:: with SMTP id l7mr4770311ybc.85.1597306680021; Thu, 13 Aug 2020 01:18:00 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 01:17:59 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Thu, 13 Aug 2020 01:17:59 -0700 Message-ID: Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b To: =?UTF-8?B?SGFyYWxkIErDtnJn?= , 42168@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42168 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Harald, Please see my comments on your patch below. Harald J=C3=B6rg writes: > diff --git a/test/lisp/progmodes/cperl-mode/cperl-fontification-tests.el = b/test/lisp/progmodes/cperl-mode/cperl-fontification-tests.el > new file mode 100644 > index 0000000000..4148db036c > --- /dev/null > +++ b/test/lisp/progmodes/cperl-mode/cperl-fontification-tests.el Great initiative to also write tests for this bug. For now, I think you should simply place the file directly at: lisp/progmodes/cperl-mode-tests.el We could always break it up into several files later when it gets bigger and there is a need to do so. > @@ -0,0 +1,55 @@ > +;;; cperl-fontification-tests.el --- Test fontification in cperl-mode -*= - lexical-binding: t -*- > + > +;; Copyright (C) 2020-2020 ...to be decided ... All files in GNU Emacs should be following this template: ;; Copyright (C) 2020 Free Software Foundation, Inc. (Note that you only need a range if there's more than one year.) > +;; Author: Harald J=C3=B6rg > +;; Maintainer: Harald J=C3=B6rg > +;; Keywords: internal > +;; Human-Keywords: internal Nit: I think we can skip Human-Keywords here. > +;; Homepage: https://github.com/HaraldJoerg/cperl-mode > + > +;;; Commentary: > + > +;; This is a collection of Tests for the fontification of CPerl-mode. Typo: "tests" shouldn't have a capital letter. > +;; The primary target is to verify that the refactoring we're doing > +;; right now (May 2020 - ...) doesn't change any behavior, or does the > +;; right thing in cases where new fontification rules are enabled. I think these three lines here could be removed, maybe? It seems to me that they are describing the purpose of all tests, namely to stop regressions from happening. > +;; Run these tests interactively: > +;; (ert-run-tests-interactively '(tag :fontification)) Nit: Missing this header here: ;;; Code: > + > +(defun cperl-test-face (text regexp) > + "Returns the face of the first character matched by REGEXP in TEXT." > + (interactive) > + (with-temp-buffer > + (let ((cperl-hairy nil) > + (cperl-font-lock nil)) ;; Does this matter? Does it matter? Not sure, what happens if you remove it? :-) > + (insert text) > + (cperl-mode) > + (font-lock-fontify-buffer) > + (goto-char (point-min)) > + (re-search-forward regexp) > + (message "%s" (match-string 0)) > + (get-text-property (match-beginning 0) 'face)))) It is good practice to remove calls to 'message' in the tests, since they mostly make the tests more noisy. If it's really useful during development of tests, you could comment it out or make it dependent upon a new variable like > +(ert-deftest jrockway-issue-45 () Is probably better named as: cperl-mode-test-bug-42168 to refer back to our own bug in the name. We already have the link to jrockway in the doc string, which is useful if one needs to dig deeper. > + "Verify that '/' is a division after ++ or --, not a regexp. > +Reported in https://github.com/jrockway/cperl-mode/issues/45. > +If seen as regular expression, then the slash is displayed using > +font-lock-constant-face. If seen as a division, then it doesn't > +have a face property." > + :tags '(:fontification) > + ;; The next two Perl expressions have divisions. Perl "punctuation" > + ;; operators don't get a face. The comment at the end of line > + ;; prevents cperl-mode from tripping over "End of =E2=80=98/ ... /=E2= =80=99 > + ;; string/RE not found" if it gets it wrong Do we need the comment at the end of the below code fragments with your patch as well? If not, couldn't we just remove them? I think that would make the intention a little bit clearer, maybe. > + (let ((code "{ $a++ / $b } # /")) > + (should (equal (cperl-test-face code "/" ) nil))) > + (let ((code "{ $a-- / $b } # /")) > + (should (equal (cperl-test-face code "/" ) nil))) > + ;; The next two Perl expressions have regular expressions. The > + ;; delimiter of a RE is fontified with font-lock-constant-face. > + (let ((code "{ $a+ / $b } # /")) > + (should (equal (cperl-test-face code "/" ) font-lock-constant-face))= ) > + (let ((code "{ $a- / $b } # /")) > + (should (equal (cperl-test-face code "/" ) font-lock-constant-face))= )) The rest looks good to me. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 04:20:14 2020 Received: (at control) by debbugs.gnu.org; 13 Aug 2020 08:20:14 +0000 Received: from localhost ([127.0.0.1]:46733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68T8-00038H-Cu for submit@debbugs.gnu.org; Thu, 13 Aug 2020 04:20:14 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:46415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68T3-00037t-Fm for control@debbugs.gnu.org; Thu, 13 Aug 2020 04:20:13 -0400 Received: by mail-yb1-f170.google.com with SMTP id x10so2840397ybj.13 for ; Thu, 13 Aug 2020 01:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=3WrPYFdsYUPUv7+8w7kQFtbmVqp2eGlbyZkVzsxBylY=; b=PYFLB/4WUpt4Ja5hEqvxlmvAQcKRLeF2SY+ypQGW+Fo7hBWbb7SZizhOF0Zg1ZYf5S 6BZDv2wj38cTZl0p8aXuExk1LObZ7EaAmhKfoh2Gr/hlKMOIEhppz97c1q49d2SYuSMP VvtYCkBY7r0LlYctifEFXnDVkXY4zFHspTHJEn1lukMsIn1yxLMEQ0CpHYjw2Ssd60S+ r9HmRM9lT6X326wzYizrhCovu+3rXZlXSPua9zhDzHjC9eox4cCYrMtSfD7mB8+tucqc bnDY/VMb+ZYyjGY15k9dzE4+ywF/d6EFVsd2LiYuUCIMKUSqeT1LS4DPt2+3PkwLQkmJ 97uA== X-Gm-Message-State: AOAM5313ogUivvmIDSFDx8Lef14QcPyY4/mu9g52mNUBdqfvh1PP6bfI 4iv/2qk65UDJ1UIlRqHqjW5dhP0+UDKMUb+ovKR+c721/bM= X-Google-Smtp-Source: ABdhPJyZYndvvJggUbczJTSaaB2bRvDrTCYJl7eWpM/KRCssenqP9qgPlwwADnaWE28DFQ/zr0py0RX5Zch1NRvSoe8= X-Received: by 2002:a25:880e:: with SMTP id c14mr4896037ybl.181.1597306803976; Thu, 13 Aug 2020 01:20:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 01:20:03 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 13 Aug 2020 01:20:03 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 42168 + patch confirmed found 42168 28.0.50 thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.170 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.170 listed in wl.mailspike.net] 0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 42168 + patch confirmed found 42168 28.0.50 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 12:24:04 2020 Received: (at control) by debbugs.gnu.org; 13 Aug 2020 16:24:04 +0000 Received: from localhost ([127.0.0.1]:50806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6G1M-0001ix-49 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 12:24:04 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:33713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6G1G-0001hm-T9 for control@debbugs.gnu.org; Thu, 13 Aug 2020 12:24:00 -0400 Received: by mail-ej1-f52.google.com with SMTP id jp10so6848226ejb.0 for ; Thu, 13 Aug 2020 09:23:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to; bh=EH8UAuqf4Gy47SP3Zu1nD3p+br37iNhILZDXO9Lfk00=; b=mVTD6HWc4eV+aLayL/EAENDNQ0E3wKAy2iB/zVOSCpxVU0kkBoeB4h9rJ9zyYLFMFn RAAJ26i8ZDpxlkH1jgmTqYwNSLqX8OrebJB48qzfTZMHb8Dlp7oV/Miq/vZ4ew4riAYB BKsjVCf8vO08KYVX9isXu26GY81S7pwosQzKmrq9HbAS1N6Y7Ripx6JiyafIKYXE9N2l z93w6hoUf/KBf6B6gwiwSqdoY/CMMVgEB7Lg2fo9JLNp8z3w9xBasBOoVAxTS3yuG54u tkEd2f0528SrIRP3yMYAbt+OBCICmBNybrEPZb0E7ZDLeUAJcZYkrZ5cO7WE0XdQLjSo EoUA== X-Gm-Message-State: AOAM532bVW3AiWHUN0ENkn+FJOqmGQyLsQ/nxdSTnD2GMevx/c8N34Ry 1zELPLduPUmY9HY4rw1EnsqjA1VSs4mDHfPUhW7bpPYu2v4= X-Google-Smtp-Source: ABdhPJzV7HUo/3oVHyavDZIyKNbAfMrm3WRrWCLJ7sjWlb8XOcEKs3VjvsXrMEibUSBcWQFt+KwNy9cbZ8moaCfNl8Q= X-Received: by 2002:a17:906:80c:: with SMTP id e12mr5668439ejd.128.1597335831510; Thu, 13 Aug 2020 09:23:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 09:23:50 -0700 From: Stefan Kangas In-Reply-To: (Stefan Kangas's message of "Thu, 13 Aug 2020 01:20:03 -0700") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Thu, 13 Aug 2020 09:23:50 -0700 Message-ID: Subject: Re: none To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 42168 - patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 16:40:48 2020 Received: (at 42168) by debbugs.gnu.org; 13 Aug 2020 20:40:49 +0000 Received: from localhost ([127.0.0.1]:51237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6K1o-0004Vm-K3 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 16:40:48 -0400 Received: from mout01.posteo.de ([185.67.36.65]:35390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6K1l-0004VV-Mq for 42168@debbugs.gnu.org; Thu, 13 Aug 2020 16:40:47 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 2046E160060 for <42168@debbugs.gnu.org>; Thu, 13 Aug 2020 22:40:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1597351239; bh=FjEm3oXL2VquugJr67NrAJNvlcdRiImc+iTeGERoUO8=; h=Subject:To:From:Autocrypt:Date:From; b=EKnDptsgy+gDzDYm36rGhEagzP/bmGe7tEL6uQu1JduzrZIa/CdpBByapMaUkcxOK su3NY5iD1BOTnL5b6qMzTikQgQ3r3t9MvfggtUKZnJZaUmJvqJKa4TjuoxQUzFR7uu U9PdoTSVAelV8eFRCpraHSKa4mIV9rk5sIZRPjeOkpCNs616ajdi5WrGxhXMiRJmVi 8a8MRq9Y+pRQ1Jw+l3gTnovMdp88SOw3fX9/IL2NTdtsZyIDlrCt+MNssWL/H2MsmA 8LOmXFaKUnqsJmnpa1J9F5OPbiHqkY+ge2cJTYPwVxuv/ktjP3zTar0UMcIyTxxTxZ ha3UG3fJh/SEA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BSJP22tcjz6tmM; Thu, 13 Aug 2020 22:40:38 +0200 (CEST) Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b To: Stefan Kangas , 42168@debbugs.gnu.org References: From: =?UTF-8?Q?Harald_J=c3=b6rg?= Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: Date: Thu, 13 Aug 2020 22:40:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------77300BFC19DA6A45DE5492E2" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42168 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------77300BFC19DA6A45DE5492E2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hello Stefan, Thank you for your thorough review. I'm rather new to Emacs Lisp, and also to the Emacs development workflows, so this is highly appreciated. Here I've attached a new version of the patch. - Copyright notice is now as it should be (now that the paperwork permits it) - All the stuff you suggested to be removed has been removed - The test has been renamed as suggested In one place I've changed your suggestion: > For now, I think you should simply place the file directly at: > > lisp/progmodes/cperl-mode-tests.el I guess this was meant to read test/lisp/progmodes/cperl-mode-tests.el. Also, I've added a ChangeLog-style attachment, as suggested by Lars Ingebrigtsen in his comment to Bug#42355. -- Cheers, haj --------------77300BFC19DA6A45DE5492E2 Content-Type: text/x-patch; charset=UTF-8; name="postincrement_1.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="postincrement_1.diff" diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index 6122caf518..2d2713a36a 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -3979,6 +3979,9 @@ cperl-find-pods-heres (and (eq (preceding-char) ?.) (eq (char-after (- (point) 2)) ?.)) (bobp)) + ;; { $a++ / $b } doesn't start a regex, nor does $a-- + (not (and (memq (preceding-char) '(?+ ?-)) + (eq (preceding-char) (char-before (1- (point)))))) ;; m|blah| ? foo : bar; (not (and (eq c ?\?) diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmode= s/cperl-mode-tests.el new file mode 100644 index 0000000000..030bdbe3db --- /dev/null +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -0,0 +1,48 @@ +;;; cperl-mode-tests --- Test for cperl-mode -*- lexical-binding: t -*- + +;; Copyright (C) 2020 Free Software Foundation, Inc. + +;; Author: Harald J=C3=B6rg +;; Maintainer: Harald J=C3=B6rg +;; Keywords: internal +;; Homepage: https://github.com/HaraldJoerg/cperl-mode + +;;; Commentary: + +;; This is a collection of tests for the fontification of CPerl-mode. + +;; Run these tests interactively: +;; (ert-run-tests-interactively '(tag :fontification)) + +;;; Code: + +(defun cperl-test-face (text regexp) + "Returns the face of the first character matched by REGEXP in TEXT." + (interactive) + (with-temp-buffer + (insert text) + (cperl-mode) + (font-lock-fontify-buffer) + (goto-char (point-min)) + (re-search-forward regexp) + (get-text-property (match-beginning 0) 'face))) + +(ert-deftest cperl-mode-test-bug-42168 () + "Verify that '/' is a division after ++ or --, not a regexp. +Reported in https://github.com/jrockway/cperl-mode/issues/45. +If seen as regular expression, then the slash is displayed using +font-lock-constant-face. If seen as a division, then it doesn't +have a face property." + :tags '(:fontification) + ;; The next two Perl expressions have divisions. Perl "punctuation" + ;; operators don't get a face. + (let ((code "{ $a++ / $b }")) + (should (equal (cperl-test-face code "/" ) nil))) + (let ((code "{ $a-- / $b }")) + (should (equal (cperl-test-face code "/" ) nil))) + ;; The next two Perl expressions have regular expressions. The + ;; delimiter of a RE is fontified with font-lock-constant-face. + (let ((code "{ $a+ / $b } # /")) + (should (equal (cperl-test-face code "/" ) font-lock-constant-face))= ) + (let ((code "{ $a- / $b } # /")) + (should (equal (cperl-test-face code "/" ) font-lock-constant-face))= )) --------------77300BFC19DA6A45DE5492E2 Content-Type: text/plain; charset=UTF-8; name="ChangeLog.Bug42168" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="ChangeLog.Bug42168" MjAyMC0wOC0xMyAgSGFyYWxkIErDtnJnICA8aGFqQHBvc3Rlby5kZT4KCgkqIGxpc3AvcHJv Z21vZGVzL2NwZXJsLW1vZGUuZWwgKGNwZXJsLWZpbmQtcG9kcy1oZXJlcyk6IEZpeCAoQnVn IzQyMTY4KQoJUmVjb2duaXplIHskYSsrIC8gJGJ9IGNvcnJlY3RseSBhcyBkaXZpc2lvbi4K CgkqIHRlc3QvbGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS10ZXN0cy5lbDogTmV3IHRlc3Qg dmVyaWZ5aW5nIHRoZSBmaXgKCWZvciAoQnVnIzQyMTY4KS4KCg== --------------77300BFC19DA6A45DE5492E2-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 16:54:47 2020 Received: (at control) by debbugs.gnu.org; 13 Aug 2020 20:54:47 +0000 Received: from localhost ([127.0.0.1]:51278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6KFL-00074O-4m for submit@debbugs.gnu.org; Thu, 13 Aug 2020 16:54:47 -0400 Received: from mail-yb1-f174.google.com ([209.85.219.174]:33042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6KFJ-000748-Uo for control@debbugs.gnu.org; Thu, 13 Aug 2020 16:54:46 -0400 Received: by mail-yb1-f174.google.com with SMTP id p191so4058735ybg.0 for ; Thu, 13 Aug 2020 13:54:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=n+v3b3FpyFpr0BBDHXJBnTsvx7GMDy/KDktHVH3EtPE=; b=E76Kc2JUf4k+rZnr3lEd11BklERh0x9eeTzOsF3yz3WYyS2857eV/jkLiVQUScZPK9 x6HmweWrz9mEVAWHJLzBjLb7p4g8j8MdXyXmNFSM/s1kbvpvGfov22xmbBw7uhC3NYRL jPCTMIqwyAWz+mhlJiZ69fcUApS3B2U327TgifaeemR9trG0Q/S3ai5G1Car53c2yw93 +kUm25Wv0grD9QZMc+yHpbRcwjwaBryIuFRJeIwMmbbX88M4dlj15+0PkDAVCa9JvHK/ m5s03wRoes28VYxL/k7irESjZrv3eaxAD3NNeEMbXogoe33/HCJUC/ftyWfvSqS0dWNc RjOA== X-Gm-Message-State: AOAM530nWKbzVDTkspYAYhDa4unD67pUTtsXZJKUKKJZ5SC8U6a36ArM NEUzgA501ZIvuAHFwEb5pV6+zRQs4ekt6XqLCeg6aMecRmc= X-Google-Smtp-Source: ABdhPJyLbv3R3uDDw5uZbBohdew78u38Z8nigrekSd6IMQUMXrpjLsSlq67KoL0XLGdzV0ZmJZB98r3CUFkb4+Ive1g= X-Received: by 2002:a25:9843:: with SMTP id k3mr9453960ybo.466.1597352080400; Thu, 13 Aug 2020 13:54:40 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 13:54:40 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 13 Aug 2020 13:54:40 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 42168 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.174 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.174 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 42168 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 05:06:55 2020 Received: (at 42168) by debbugs.gnu.org; 14 Aug 2020 09:06:55 +0000 Received: from localhost ([127.0.0.1]:51791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Vfr-0006Jz-55 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 05:06:55 -0400 Received: from mail-yb1-f172.google.com ([209.85.219.172]:35979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Vfo-0006Jd-O9 for 42168@debbugs.gnu.org; Fri, 14 Aug 2020 05:06:53 -0400 Received: by mail-yb1-f172.google.com with SMTP id g3so4851428ybc.3 for <42168@debbugs.gnu.org>; Fri, 14 Aug 2020 02:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=6SlZmQ077A2etCRhegaU2pt5kyoyGC3z9AP3ID317hw=; b=EipNWIT1NKhqYiPvDVuk1zgzXwFMoKwUtcFBXx2hS7JltDRXe7FzEjLB+5evhpRbcF u5S97CI0Ph7s3czFSiY2n2JblDUNEP3PRG4x+Rxj4BAnLvFKGVeYpo+qv5DmtZVaF6an EfqkowkE2pWUIupBT/9X8csn7ijGYbgiu+dik28pe3Nwht7/j1AiWrIL2cnm/Q/NoSyj B/1e7fZRma2E85ge9QQEZGfN+QHYyn9JaKYmIwM6si5s6hBmxwizQjOvtObJel7+2Z3D 4PH2DPjfzfyHuTr1C089+iTVb7950VAyw+wK9cYVj1WK3+jgkCz0/IofslQclSlHVuQd vqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=6SlZmQ077A2etCRhegaU2pt5kyoyGC3z9AP3ID317hw=; b=PVI43O2Dlma2mj0ebUfQ0Z8+z9bwuyCvYCXUl/f4GV0qCsO8j4F95qP6SEqUwiO7RQ qkV67DoAnnwz6PwNerJTpBprV/053SSxWppfNh0HyIUPneoxKZKZm0s6m+HOdWLcHXL1 mSiJfP3vPuBOFtxZodIO6b4kHtwGSBZBDq4ZGcTBmCRqVrD8ptKR1hB2T7LT2xQA0eeS 809blsbbrqGoYqnqyCBKmKyYmJY1U+QEUslAm8tMv8CSUJRdtcqLjoNrX++jgXiH/bps +lliXTCRrf1JebQUnuOnm+p790Yrl6zQPmOFRWH9nu0ccexKtsKPh4H3M5PqtfEcX6gi ncUg== X-Gm-Message-State: AOAM5314I4IUEczsLDsj6N+0txzj+Af7Gq6dI2bmueNrP5ymhJCGI+pC WnCSe50wnROQPg4JUxVqGXa50Ml7B+ibRNccNOg= X-Google-Smtp-Source: ABdhPJxFeQ4VmmUXgBvuqL0yPW8W6VyGPcw+rzAo87A80pGIv2LfAgG4VJa8Z2WDUPfZrCAOoYJXMM0+fIvAk0vzhqQ= X-Received: by 2002:a25:9843:: with SMTP id k3mr2445033ybo.466.1597396007114; Fri, 14 Aug 2020 02:06:47 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 02:06:46 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Fri, 14 Aug 2020 02:06:46 -0700 Message-ID: Subject: Re: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b To: =?UTF-8?B?SGFyYWxkIErDtnJn?= , 42168@debbugs.gnu.org Content-Type: multipart/mixed; boundary="00000000000091fb7f05acd2bdfa" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42168 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000091fb7f05acd2bdfa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable close 42168 28.1 thanks Hi Harald, Harald J=C3=B6rg writes: > Thank you for your thorough review. I'm rather new to Emacs Lisp, and > also to the Emacs development workflows, so this is highly > appreciated. Happy to help, we've all been there at one point. >> lisp/progmodes/cperl-mode-tests.el > > I guess this was meant to read test/lisp/progmodes/cperl-mode-tests.el. Indeed. > Also, I've added a ChangeLog-style attachment, as suggested by Lars > Ingebrigtsen in his comment to Bug#42355. Thanks. Your diff looks good, so I've installed the attached patch with some minor fixes, and I'm closing the bug with this message. Next time, could you please add the ChangeLog entry to the git commit message and send the result of `git format-patch -1` as an attachment? That saves time when installing the change. Please see the attached for an example, and you can read more in CONTRIBUTE in emacs.git. It is also useful to consult the git log for more examples. Welcome again as an Emacs contributor! Best regards, Stefan Kangas --00000000000091fb7f05acd2bdfa Content-Type: text/x-diff; charset="utf-8"; name="0001-cperl-mode-Highlight-a-b-correctly.patch" Content-Disposition: attachment; filename="0001-cperl-mode-Highlight-a-b-correctly.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: acda5e10cee4eb2a_0.1 RnJvbSBmM2ZmNTEyODhmYTAzNzBhOWVhMzMzMTJiMTg4NTY1ZTRmMmI1OTVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SGFyYWxkPTIwSj1DMz1CNnJnPz0gPGhhakBw b3N0ZW8uZGU+CkRhdGU6IEZyaSwgMTQgQXVnIDIwMjAgMTA6MDE6MzAgKzAyMDAKU3ViamVjdDog W1BBVENIXSBjcGVybC1tb2RlOiBIaWdobGlnaHQgJ3skYSsrIC8gJGJ9JyBjb3JyZWN0bHkKCiog bGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS5lbCAoY3BlcmwtZmluZC1wb2RzLWhlcmVzKToKUmVj b2duaXplIHskYSsrIC8gJGJ9IGNvcnJlY3RseSBhcyBkaXZpc2lvbi4gIChCdWcjNDIxNjgpCiog dGVzdC9saXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLXRlc3RzLmVsOiBOZXcgZmlsZSB3aXRoIHRl c3QKdmVyaWZ5aW5nIHRoZSBmaXguCi0tLQogbGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS5lbCAg ICAgICAgICAgIHwgIDMgKysKIHRlc3QvbGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS10ZXN0cy5l bCB8IDUwICsrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNTMgaW5z ZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9wcm9nbW9kZXMvY3Blcmwt bW9kZS10ZXN0cy5lbAoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUuZWwg Yi9saXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLmVsCmluZGV4IDYxMjJjYWY1MTguLjJkMjcxM2Ez NmEgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvY3BlcmwtbW9kZS5lbApAQCAtMzk3OSw2ICszOTc5LDkgQEAgY3BlcmwtZmluZC1w b2RzLWhlcmVzCiAJCQkJICAgIChhbmQgKGVxIChwcmVjZWRpbmctY2hhcikgPy4pCiAJCQkJCSAo ZXEgKGNoYXItYWZ0ZXIgKC0gKHBvaW50KSAyKSkgPy4pKQogCQkJCSAgICAoYm9icCkpCisJCQkJ OzsgeyAkYSsrIC8gJGIgfSBkb2Vzbid0IHN0YXJ0IGEgcmVnZXgsIG5vciBkb2VzICRhLS0KKwkJ CQkobm90IChhbmQgKG1lbXEgKHByZWNlZGluZy1jaGFyKSAnKD8rID8tKSkKKwkJCQkJICAoZXEg KHByZWNlZGluZy1jaGFyKSAoY2hhci1iZWZvcmUgKDEtIChwb2ludCkpKSkpKQogCQkJCTs7ICBt fGJsYWh8ID8gZm9vIDogYmFyOwogCQkJCShub3QKIAkJCQkgKGFuZCAoZXEgYyA/XD8pCmRpZmYg LS1naXQgYS90ZXN0L2xpc3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUtdGVzdHMuZWwgYi90ZXN0L2xp c3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUtdGVzdHMuZWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMC4uZjM5ZjFiYTY1OAotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvbGlzcC9w cm9nbW9kZXMvY3BlcmwtbW9kZS10ZXN0cy5lbApAQCAtMCwwICsxLDUwIEBACis7OzsgY3Blcmwt bW9kZS10ZXN0cyAtLS0gVGVzdCBmb3IgY3BlcmwtbW9kZSAgLSotIGxleGljYWwtYmluZGluZzog dCAtKi0KKworOzsgQ29weXJpZ2h0IChDKSAyMDIwIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwg SW5jLgorCis7OyBBdXRob3I6IEhhcmFsZCBKw7ZyZyA8aGFqQHBvc3Rlby5kZT4KKzs7IE1haW50 YWluZXI6IEhhcmFsZCBKw7ZyZworOzsgS2V5d29yZHM6IGludGVybmFsCis7OyBIb21lcGFnZTog aHR0cHM6Ly9naXRodWIuY29tL0hhcmFsZEpvZXJnL2NwZXJsLW1vZGUKKworOzs7IENvbW1lbnRh cnk6CisKKzs7IFRoaXMgaXMgYSBjb2xsZWN0aW9uIG9mIHRlc3RzIGZvciB0aGUgZm9udGlmaWNh dGlvbiBvZiBDUGVybC1tb2RlLgorCis7OyBSdW4gdGhlc2UgdGVzdHMgaW50ZXJhY3RpdmVseToK Kzs7IChlcnQtcnVuLXRlc3RzLWludGVyYWN0aXZlbHkgJyh0YWcgOmZvbnRpZmljYXRpb24pKQor Cis7OzsgQ29kZToKKworKGRlZnVuIGNwZXJsLXRlc3QtZmFjZSAodGV4dCByZWdleHApCisgICJS ZXR1cm5zIHRoZSBmYWNlIG9mIHRoZSBmaXJzdCBjaGFyYWN0ZXIgbWF0Y2hlZCBieSBSRUdFWFAg aW4gVEVYVC4iCisgIChpbnRlcmFjdGl2ZSkKKyAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgIChp bnNlcnQgdGV4dCkKKyAgICAgIChjcGVybC1tb2RlKQorICAgICAgKGZvbnQtbG9jay1lbnN1cmUg KHBvaW50LW1pbikgKHBvaW50LW1heCkpCisgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQor ICAgICAgKHJlLXNlYXJjaC1mb3J3YXJkIHJlZ2V4cCkKKyAgICAgIChnZXQtdGV4dC1wcm9wZXJ0 eSAobWF0Y2gtYmVnaW5uaW5nIDApICdmYWNlKSkpCisKKyhlcnQtZGVmdGVzdCBjcGVybC1tb2Rl LXRlc3QtYnVnLTQyMTY4ICgpCisgICJWZXJpZnkgdGhhdCAnLycgaXMgYSBkaXZpc2lvbiBhZnRl ciArKyBvciAtLSwgbm90IGEgcmVnZXhwLgorUmVwb3J0ZWQgaW4gaHR0cHM6Ly9naXRodWIuY29t L2pyb2Nrd2F5L2NwZXJsLW1vZGUvaXNzdWVzLzQ1LgorSWYgc2VlbiBhcyByZWd1bGFyIGV4cHJl c3Npb24sIHRoZW4gdGhlIHNsYXNoIGlzIGRpc3BsYXllZCB1c2luZworZm9udC1sb2NrLWNvbnN0 YW50LWZhY2UuICBJZiBzZWVuIGFzIGEgZGl2aXNpb24sIHRoZW4gaXQgZG9lc24ndAoraGF2ZSBh IGZhY2UgcHJvcGVydHkuIgorICA6dGFncyAnKDpmb250aWZpY2F0aW9uKQorICA7OyBUaGUgbmV4 dCB0d28gUGVybCBleHByZXNzaW9ucyBoYXZlIGRpdmlzaW9ucy4gIFBlcmwgInB1bmN0dWF0aW9u IgorICA7OyBvcGVyYXRvcnMgZG9uJ3QgZ2V0IGEgZmFjZS4KKyAgKGxldCAoKGNvZGUgInsgJGEr KyAvICRiIH0iKSkKKyAgICAoc2hvdWxkIChlcXVhbCAoY3BlcmwtdGVzdC1mYWNlIGNvZGUgIi8i ICkgbmlsKSkpCisgIChsZXQgKChjb2RlICJ7ICRhLS0gLyAkYiB9IikpCisgICAgKHNob3VsZCAo ZXF1YWwgKGNwZXJsLXRlc3QtZmFjZSBjb2RlICIvIiApIG5pbCkpKQorICA7OyBUaGUgbmV4dCB0 d28gUGVybCBleHByZXNzaW9ucyBoYXZlIHJlZ3VsYXIgZXhwcmVzc2lvbnMuICBUaGUKKyAgOzsg ZGVsaW1pdGVyIG9mIGEgUkUgaXMgZm9udGlmaWVkIHdpdGggZm9udC1sb2NrLWNvbnN0YW50LWZh Y2UuCisgIChsZXQgKChjb2RlICJ7ICRhKyAvICRiIH0gIyAvIikpCisgICAgKHNob3VsZCAoZXF1 YWwgKGNwZXJsLXRlc3QtZmFjZSBjb2RlICIvIiApIGZvbnQtbG9jay1jb25zdGFudC1mYWNlKSkp CisgIChsZXQgKChjb2RlICJ7ICRhLSAvICRiIH0gIyAvIikpCisgICAgKHNob3VsZCAoZXF1YWwg KGNwZXJsLXRlc3QtZmFjZSBjb2RlICIvIiApIGZvbnQtbG9jay1jb25zdGFudC1mYWNlKSkpKQor Cis7OzsgY3BlcmwtbW9kZS10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMjguMAoK --00000000000091fb7f05acd2bdfa-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 16:10:18 2020 Received: (at control) by debbugs.gnu.org; 26 Aug 2020 20:10:19 +0000 Received: from localhost ([127.0.0.1]:40913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kB1kQ-0004ST-PM for submit@debbugs.gnu.org; Wed, 26 Aug 2020 16:10:18 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:40246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kB1kO-0004SE-5w for control@debbugs.gnu.org; Wed, 26 Aug 2020 16:10:17 -0400 Received: by mail-yb1-f170.google.com with SMTP id q3so1647501ybp.7 for ; Wed, 26 Aug 2020 13:10:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=QbPi4syoL+PGfPpyZv/qyEFmV/dVgR3lmzRrVvoRQic=; b=Oj9ErNNKHKmHE4u+m4XwUtQsdTqujZRFPly8tQHEhO7vZzGS/r+nxbsjJC2XY06zST vofRPP1zgeb1Mu76u/2mCyV58U9AcpfXSqeLmre3Env93adUp4cK1x+URj55aMgEXwPl LB7GvJRIwRwJdljbNPUCIrbd4/0nll9C2Hh16khhrlmAqY+paFr61J0gejGXHt4KJqaw /lIvNal+/odtwKu6BKe8CwS623va7q0lXRtI+361/D2Me8TPrRnpVw88mlKuA5djLlmb jWhGqnESMPYUIGbKdynW2i/G4tB2xBd8i92AMwXBO6mDRuLzWgaUOjVdQTlsDIDhU4aH VnkA== X-Gm-Message-State: AOAM533AAbak9nwXUCpgSb23EWK+cW+mvFv7o3+aNWV8mgMaOkphJ4ho 0vi/NySyzbzwkEZ7sP+LEPvZagpUyO+iGq6erNhFF5YPv1c= X-Google-Smtp-Source: ABdhPJzONm1xYJtIiPN5SI+gycD15Hc7Tq6uviWvCANMme0vahYN9ubMCIurbbjzqdqLwx5uBSq1EcviJLzgxgvYwZ8= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr24949764ybb.129.1598472610650; Wed, 26 Aug 2020 13:10:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Aug 2020 13:10:10 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 26 Aug 2020 13:10:10 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 42168 minor thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.170 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.170 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 42168 minor thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.170 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.170 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines severity 42168 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 16:32:34 2020 Received: (at control) by debbugs.gnu.org; 26 Aug 2020 20:32:34 +0000 Received: from localhost ([127.0.0.1]:40938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kB25y-0007Dd-K8 for submit@debbugs.gnu.org; Wed, 26 Aug 2020 16:32:34 -0400 Received: from mail-yb1-f177.google.com ([209.85.219.177]:34836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kB25w-0007DQ-S4 for control@debbugs.gnu.org; Wed, 26 Aug 2020 16:32:34 -0400 Received: by mail-yb1-f177.google.com with SMTP id y134so1697392yby.2 for ; Wed, 26 Aug 2020 13:32:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=24Y8yHgy12eSBZJ97DxAkhtvmY11I8qNjIvlniSzqMQ=; b=t5rbhFpuk/bXzbkLNoYm+1Jx5RvKIWzJc8zgzhSSiyIqW8wtO5KIFBvCKRdLNmcHtK gEpBxRutNwyUGTjg7glsFFAS0fA6qWkWfWfKpDuJgT1473FUtprPKZn03LXVLJyz2CyU evj2R+rKA8HghbUryqfmywPOZBsIKdadsJKJmCJOJCOXrZnwVCIl7R7CuB6NjE8iwaBn G5HxRWfgUlpSuLwPgOPr9faEnLufXi/n9JJNzZLSpYk6psKvdGwHtsYa3ZQ/Vyn4MhU+ UHKAUamjTZrks0WLui18b5pa9EqJMzYLizQWHa7Pd51RfPLtCu1ExiVdc4WwNstEIks+ eGBw== X-Gm-Message-State: AOAM5338rt0uBLarMwwbE3fbHcN7wEoQCOJojhnoUdSzxDWc7QUkalx1 VX9Z4Ka/Q8rc23BhBJM0CN7qha7J4S5LElxqA6KZE+hebXw= X-Google-Smtp-Source: ABdhPJyH86E47CdbiUgsaqfoUwpF4Zcg8xJtXur9lnQeJ+nXdC31NIdnIkTESXX/ZMiKUJG676nU2OiF4rK7yby+cpA= X-Received: by 2002:a25:4609:: with SMTP id t9mr23075698yba.231.1598473946981; Wed, 26 Aug 2020 13:32:26 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Aug 2020 13:32:26 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 26 Aug 2020 13:32:26 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: forcemerge 42168 36946 thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.177 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.177 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: forcemerge 42168 36946 thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.177 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.177 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines forcemerge 42168 36946 thanks From unknown Wed Jun 18 23:07:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Sep 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator