GNU bug report logs - #42158
python-grequests broken, add zope dependencies to fix.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#42158: closed (python-grequests broken, add zope dependencies
 to fix.)
Date: Thu, 02 Jul 2020 12:17:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 02 Jul 2020 08:16:37 -0400
with message-id <87a70iyuvu.fsf <at> dustycloud.org>
and subject line Re: bug#42158: python-grequests broken, add zope dependencies to fix.
has caused the debbugs.gnu.org bug report #42158,
regarding python-grequests broken, add zope dependencies to fix.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
42158: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42158
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: bug-guix <at> gnu.org
Subject: python-grequests broken, add zope dependencies to fix.
Date: Wed, 01 Jul 2020 16:39:05 -0400

[Message part 3 (text/plain, inline)]

Fix attached.  Ok to push?

[0001-gnu-python-grequests-Fix-tests-by-adding-zope-depend.patch (text/x-patch, inline)]

From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Date: Wed, 1 Jul 2020 16:36:29 -0400
Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.

* gnu/packages/python-web.scm (python-grequests): Add zope
  dependencies to native-inputs for tests.
---
 gnu/packages/python-web.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 030abef9c2..c929e254f7 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2010,7 +2010,9 @@ library.")
      `(("python-gevent" ,python-gevent)
        ("python-requests" ,python-requests)))
     (native-inputs
-     `(("python-nose" ,python-nose)))
+     `(("python-nose" ,python-nose)
+       ("python-zope.interface" ,python-zope-interface)
+       ("python-zope.event" ,python-zope-event)))
     (home-page "https://github.com/kennethreitz/grequests")
     (synopsis "Python library for asynchronous HTTP requests")
     (description "GRequests is a Python library that allows you to use
-- 
2.26.2

[Message part 5 (message/rfc822, inline)]

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 42158-done <at> debbugs.gnu.org
Subject: Re: bug#42158: python-grequests broken, add zope dependencies to fix.
Date: Thu, 02 Jul 2020 08:16:37 -0400

Efraim Flashner writes:

> On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
>> Fix attached.  Ok to push?
>> 
>
> Looks good to me. I will note however that the test suite doesn't seem
> to actually be run.

Huh.  Well at least it's no longer breaking, which is what was happening
for me before.

>> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
>> Date: Wed, 1 Jul 2020 16:36:29 -0400
>> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
>> 
>> * gnu/packages/python-web.scm (python-grequests): Add zope
>>   dependencies to native-inputs for tests.
>
> should be:
>
> * gnu/packages/python-web.scm (python-grequests)[native-inputs]:
> Add python-zope.interface, python-zope.event.
>

Done.  Changed and pushed!

>> ---
>>  gnu/packages/python-web.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
>> index 030abef9c2..c929e254f7 100644
>> --- a/gnu/packages/python-web.scm
>> +++ b/gnu/packages/python-web.scm
>> @@ -2010,7 +2010,9 @@ library.")
>>       `(("python-gevent" ,python-gevent)
>>         ("python-requests" ,python-requests)))
>>      (native-inputs
>> -     `(("python-nose" ,python-nose)))
>> +     `(("python-nose" ,python-nose)
>> +       ("python-zope.interface" ,python-zope-interface)
>> +       ("python-zope.event" ,python-zope-event)))
>>      (home-page "https://github.com/kennethreitz/grequests")
>>      (synopsis "Python library for asynchronous HTTP requests")
>>      (description "GRequests is a Python library that allows you to use
>> -- 
>> 2.26.2
>> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.