Subject: bug#42158: closed (Re: bug#42158: python-grequests broken, add zope dependencies to fix.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 02 Jul 2020 12:17:02 +0000

Your bug report

#42158: python-grequests broken, add zope dependencies to fix.

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
42158: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42158
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#42158: python-grequests broken, add zope dependencies to fix.
From: Christopher Lemmer Webber <[email-masked]>
To: Efraim Flashner <[email-masked]>
Cc: [email-masked]
Date: Thu, 02 Jul 2020 08:16:37 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Efraim Flashner writes:

> On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
>> Fix attached.  Ok to push?
>> 
>
> Looks good to me. I will note however that the test suite doesn't seem
> to actually be run.

Huh.  Well at least it's no longer breaking, which is what was happening
for me before.

>> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <[email-masked]>
>> Date: Wed, 1 Jul 2020 16:36:29 -0400
>> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
>> 
>> * gnu/packages/python-web.scm (python-grequests): Add zope
>>   dependencies to native-inputs for tests.
>
> should be:
>
> * gnu/packages/python-web.scm (python-grequests)[native-inputs]:
> Add python-zope.interface, python-zope.event.
>

Done.  Changed and pushed!

>> ---
>>  gnu/packages/python-web.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
>> index 030abef9c2..c929e254f7 100644
>> --- a/gnu/packages/python-web.scm
>> +++ b/gnu/packages/python-web.scm
>> @@ -2010,7 +2010,9 @@ library.")
>>       `(("python-gevent" ,python-gevent)
>>         ("python-requests" ,python-requests)))
>>      (native-inputs
>> -     `(("python-nose" ,python-nose)))
>> +     `(("python-nose" ,python-nose)
>> +       ("python-zope.interface" ,python-zope-interface)
>> +       ("python-zope.event" ,python-zope-event)))
>>      (home-page "https://github.com/kennethreitz/grequests")
>>      (synopsis "Python library for asynchronous HTTP requests")
>>      (description "GRequests is a Python library that allows you to use
>> -- 
>> 2.26.2
>> 

Subject: python-grequests broken, add zope dependencies to fix.
From: Christopher Lemmer Webber <[email-masked]>
To: [email-masked]
Date: Wed, 01 Jul 2020 16:39:05 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Fix attached.  Ok to push?

>From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
From: Christopher Lemmer Webber <[email-masked]>
Date: Wed, 1 Jul 2020 16:36:29 -0400
Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.

* gnu/packages/python-web.scm (python-grequests): Add zope
  dependencies to native-inputs for tests.
---
 gnu/packages/python-web.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 030abef9c2..c929e254f7 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2010,7 +2010,9 @@ library.")
      `(("python-gevent" ,python-gevent)
        ("python-requests" ,python-requests)))
     (native-inputs
-     `(("python-nose" ,python-nose)))
+     `(("python-nose" ,python-nose)
+       ("python-zope.interface" ,python-zope-interface)
+       ("python-zope.event" ,python-zope-event)))
     (home-page "https://github.com/kennethreitz/grequests")
     (synopsis "Python library for asynchronous HTTP requests")
     (description "GRequests is a Python library that allows you to use
-- 
2.26.2