GNU bug report logs - #42151
[PATCH 0/3] offload to Childhurd fails: setting synchronous mode: locking protocol

Previous Next

Full log

Message #86 received at 42151 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Jan \(janneke\) Nieuwenhuizen" <janneke <at> gnu.org>
Cc: 42151 <at> debbugs.gnu.org
Subject: Re: bug#42151: [PATCH v3 2/2] image: Do not set journal_model=WAL for
 the Hurd.
Date: Sat, 11 Jul 2020 16:22:18 +0200

"Jan (janneke) Nieuwenhuizen" <janneke <at> gnu.org> skribis:

> This fixes <https://bugs.gnu.org/42151>.
>
> * gnu/system/images/hurd.scm (hurd-initialize-root-partition): Use #:wal-mode #f
> in call to ...
> * gnu/build/image.scm (initialize-root-partition): ... this, add #:wal-mode?
> parameter, pass it to ...
> (register-closure): ... this, add #:wal-mode? parameter, pass it to ...
> * guix/store/database.scm (with-database): ... this, add #:wal-mode?
> parameter, pass it to ...
> (call-with-database): ... this, add #:wal-mode? parameter; when
> set to #f, do not set journal_model=WAL.

[...]

> +++ b/gnu/system/images/hurd.scm
> @@ -61,8 +61,8 @@
>    #~(lambda* (#:rest args)
>        (apply initialize-root-partition
>               (append args
> -                     (list #:make-device-nodes
> -                           make-hurd-device-nodes)))))
> +                     (list #:make-device-nodes make-hurd-device-nodes
> +                           #:wal-mode? #f)))))

IWBN to have an XXX comment here stating why we disable WAL mode on
GNU/Hurd, possibly referencing this issue.  That way, we can eventually
revisit the issue and hopefully get rid of this workaround.

Apart from that the patch LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.