From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 29 16:02:04 2020 Received: (at submit) by debbugs.gnu.org; 29 Jun 2020 20:02:04 +0000 Received: from localhost ([127.0.0.1]:49553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpzye-0000pp-C6 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 16:02:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:45470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpzyb-0000pW-Nn for submit@debbugs.gnu.org; Mon, 29 Jun 2020 16:02:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpzyb-00017n-EG for bug-guix@gnu.org; Mon, 29 Jun 2020 16:02:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37477) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpzyb-0007ru-3d for bug-guix@gnu.org; Mon, 29 Jun 2020 16:02:01 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:33634 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpzyZ-0006YV-2o for bug-guix@gnu.org; Mon, 29 Jun 2020 16:01:59 -0400 From: Marius Bakke To: bug-guix@gnu.org Subject: guix-install.sh does not add build users to kvm group Date: Mon, 29 Jun 2020 22:01:54 +0200 Message-ID: <875zb91w0d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, guix-install.sh should add the build users to the 'kvm' group if present so that commands that require use of KVM can succeed. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl76SLIACgkQoqBt8qM6 VPr3TQf+KGRK89tr9pxnafJhtPbd2m+V5/5f+D32m+mkFnt/aei7nQ+J8KpmZV4/ x4YpmS2hOrnTqs9KOoAANEMRgJCZME2VBvvUOlj4OPzKtTq5uWjn13oaAyykkv2d Xk6vPhD5z7e2dR1vfjcFHsZmcKGa+ltGxiBtqaAmEOy3tO5qT3maJkuKdbMAslb/ 7Gb8lnaOJ9Aeqv+1IQsq+fSI9MYoZcGzzcbBITxzXQxWHt3AiRqJTjtLKzdygdoF z5Vc4owy6RtWFGAhe/83fiOhqlMC+XFtH9DSOnaifKh1BXy7wZIv3CnTIkwEOa/U MI6ZbFGsqaOOp+k8ru4aXCMYJKKknA== =0nkO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 01 09:21:40 2021 Received: (at control) by debbugs.gnu.org; 1 Apr 2021 13:21:40 +0000 Received: from localhost ([127.0.0.1]:56659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRxGW-0001gP-84 for submit@debbugs.gnu.org; Thu, 01 Apr 2021 09:21:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRxGU-0001g5-3V for control@debbugs.gnu.org; Thu, 01 Apr 2021 09:21:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54472) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRxGO-0000Tg-Uz for control@debbugs.gnu.org; Thu, 01 Apr 2021 09:21:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56190 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lRxGK-0002xQ-GG for control@debbugs.gnu.org; Thu, 01 Apr 2021 09:21:32 -0400 Date: Thu, 01 Apr 2021 15:21:27 +0200 Message-Id: <87eefu87jc.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #42129 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) severity 42129 important quit From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 02 03:46:24 2021 Received: (at control) by debbugs.gnu.org; 2 Apr 2021 07:46:24 +0000 Received: from localhost ([127.0.0.1]:59087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSEVc-0004Yx-GD for submit@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSEVa-0004Yk-Kv for control@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44451) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSEVV-0001z2-9r for control@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59718 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lSEVU-0006xv-IC for control@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:17 -0400 Date: Fri, 02 Apr 2021 09:46:15 +0200 Message-Id: <8735w93z94.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #42129 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 42129 + easy quit From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 02 03:46:50 2021 Received: (at control) by debbugs.gnu.org; 2 Apr 2021 07:46:50 +0000 Received: from localhost ([127.0.0.1]:59093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSEW2-0004Zp-1N for submit@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSEW0-0004Zc-3Z for control@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44454) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSEVu-0002Mp-Sr for control@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:42 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59724 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lSEVu-000745-8X for control@debbugs.gnu.org; Fri, 02 Apr 2021 03:46:42 -0400 Date: Fri, 02 Apr 2021 09:46:41 +0200 Message-Id: <87zgyh2kny.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #47297 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 47297 by 42129 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 08 18:39:09 2021 Received: (at 42129) by debbugs.gnu.org; 8 Apr 2021 22:39:09 +0000 Received: from localhost ([127.0.0.1]:48488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUdIr-0004TX-9I for submit@debbugs.gnu.org; Thu, 08 Apr 2021 18:39:09 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUdIp-0004T9-9M for 42129@debbugs.gnu.org; Thu, 08 Apr 2021 18:39:08 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 279D05C00B8; Thu, 8 Apr 2021 18:39:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 08 Apr 2021 18:39:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=xmPrvDxukJVNLoRh/2792Cl9 fHYApFDxzyn7MYwkGQ8=; b=mhwUb8XLVINA8zEp/zwgous/7D34JQjEnEVtRN+M n2l9e3Tl5VQpxnWFvCxO1Ih6M0sbMFsZvnOD/YAUVTtRG1YDOqcj4qYm+zmHa3dv O6ZrfUOtQrU6etzTh/LBV98oHgK3qi1hwlR97UCFUcwimB8Tq1xhhWi/GrojFtNu pOM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xmPrvD xukJVNLoRh/2792Cl9fHYApFDxzyn7MYwkGQ8=; b=I/vp8FX7neVJgGi+95/EDr BuMKrIgFTFhoyAxfwdJwOey+9cINzQq+Op6DPHhitgtVsp+s7hQDhJQFKsekl+O1 3P+QmzVwFpa2PKrrGif6JpSRq2AHGH2B5BIMB98oPj8mn/BGkRqv6upNITxbVE75 RWgaTWsURZXYeTPOwlChTbjv4gB+px34LXntPBSkTJ3KRmt/xy/yCuuLzBwwY6xf IqJQbb5tNbelHVFIB7RWymy8oApbw+FOAakQ5Ahlyp1vAF9sHkL9CyNO7Jt6Drg5 4BZ3nILAa8f79MHctn9013pJPZazwM+d1ERp76FI0Okks8E2aiEq7rGKKwB2erdQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudektddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 9F46F240065; Thu, 8 Apr 2021 18:39:01 -0400 (EDT) Date: Thu, 8 Apr 2021 18:38:59 -0400 From: Leo Famulari To: Marius Bakke Subject: Re: bug#42129: guix-install.sh does not add build users to kvm group Message-ID: References: <875zb91w0d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0Siuxbb1LkUtNrSn" Content-Disposition: inline In-Reply-To: <875zb91w0d.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42129 Cc: 42129@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --0Siuxbb1LkUtNrSn Content-Type: multipart/mixed; boundary="war7xvZVd7f2FQ+H" Content-Disposition: inline --war7xvZVd7f2FQ+H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 29, 2020 at 10:01:54PM +0200, Marius Bakke wrote: > guix-install.sh should add the build users to the 'kvm' group if present > so that commands that require use of KVM can succeed. Here is a patch (untested) that makes sure a 'kvm' group exists and adds it to the guixbuilders' groups. --war7xvZVd7f2FQ+H Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-guix-install.sh-Add-the-build-users-to-the-kvm-group.patch" Content-Transfer-Encoding: quoted-printable =46rom 929102f7b52d00f731a9f61fb2fe32bad441f1dd Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Thu, 8 Apr 2021 18:34:43 -0400 Subject: [PATCH] guix-install.sh: Add the build users to the 'kvm' group. * etc/guix-install.sh (sys_create_build_user): Ensure that a 'kvm' group ex= ists, and add it to the guixbuilders' lists of supplementary groups. --- etc/guix-install.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index c84e7b7577..15fa44f1e2 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -330,15 +330,22 @@ sys_create_build_user() _msg "${PAS}group created" fi =20 + if [ $(getent group kvm) ]; then + _msg "${INF}group kvm exists" + else + groupadd --system kvm + _msg "${PAS}group created" + fi + for i in $(seq -w 1 10); do if id "guixbuilder${i}" &>/dev/null; then _msg "${INF}user is already in the system, reset" - usermod -g guixbuild -G guixbuild \ + usermod -g guixbuild -G guixbuild,kvm \ -d /var/empty -s "$(which nologin)" \ -c "Guix build user $i" \ "guixbuilder${i}"; else - useradd -g guixbuild -G guixbuild \ + useradd -g guixbuild -G guixbuild,kvm \ -d /var/empty -s "$(which nologin)" \ -c "Guix build user $i" --system \ "guixbuilder${i}"; --=20 2.31.1 --war7xvZVd7f2FQ+H-- --0Siuxbb1LkUtNrSn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmBvhgMACgkQJkb6MLrK fwgM1xAA2mP7NRqSGW2sCjZUhYY1IvCCoFrCfnd2jqnV1n8BtsYcTUDnlnfdILOZ ufMbSyfMyn0rZQHjdR9zJCAZcD1NKLRku9iFotVu3ai8qa72mJ+XA1gNX55r6xdV FGAhp4kAYJxRYY58hUO/mYQ69HHoy0hHuCCl+H/VfMuqNkHn1ukip9F1I90q9qdn uwnda3GuL5eFdtqio5MaVuVf6eDNhX+yaXYUAY/D361Q3v5b6l4BxEjQHa7bbgjd cAHLWxbxGROtqBZ7JLZk6b7zxso85a6euQCFTCnHwS+oLAORNW/Bqi80GfQ2RLoW DoqekRpDUJ68XfVXva+8Y5O6RBfMqrKLAdiIh3ptgcUZAJal5N8ClWtKR4VQOc4X AUuN08LFome0k1B9wWVKwU1lM5EHC3Ah9cbE3K4le1m679wNkrbALdnmc9YExwl6 IutG3hkzhWa7zKaZF6nMpaQayAxXBxEbJcx5faWmWUhnIlPsPW99K5BUb5ZOqg9s h46W39sVXjOPiPuEKkoD7qtaeVAdJ9xa2NikTwXH6yfTO3Vvj3jY1ep7BtKqk9o5 2Ikk6Qt5VNKktoOpk3cGD/oMz7MUxeSxsXrxYHtgr6pHhH8DRhBFhZ1LChpbX935 CrWqbmR5qVkPkjLAyRhkPKtP+1/5QimQ7IOOzkeL3w8pT5VOBuQ= =vyZm -----END PGP SIGNATURE----- --0Siuxbb1LkUtNrSn-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 08 19:03:40 2021 Received: (at 42129) by debbugs.gnu.org; 8 Apr 2021 23:03:40 +0000 Received: from localhost ([127.0.0.1]:48501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUdgZ-000562-SL for submit@debbugs.gnu.org; Thu, 08 Apr 2021 19:03:40 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUdgU-00055n-Kc for 42129@debbugs.gnu.org; Thu, 08 Apr 2021 19:03:38 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6B79A5C0110; Thu, 8 Apr 2021 19:03:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 08 Apr 2021 19:03:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=AtioJLFirfruDsaF51rtPesw 9/+rZMmYzQjEoAhqkiw=; b=iiVZx63nBkle4TITkPYC7MfxEicfXnna9r6KxGTE /9xun1TaBPSOnmh7VhVV/Xxoh6xNdhZJab2hTKmUCyQmjEdujKmgbI7PfK+NVY27 U/FhVkxnDJQjme2hWyZ9EyZfEmUR7mE8EN6mwrltJUiqYWUVKy7Ku1zT3tSBd23k mv8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=AtioJL FirfruDsaF51rtPesw9/+rZMmYzQjEoAhqkiw=; b=jr6MjJf08h69x5x41ZpOLK TlQqOaM9WvHEqAT19iyJL1jEpwBbSv+43AkD5Gn/aHzKyv15skBWXhxibNPDqIhd zwZX5uq3nphbEQfg5mgzBbDfwjiP0JOURc4gNAKtYR1/YrMZqhqb9e6MTBwsl+Gs ERpDX/qAsqIWzb/xV23iRgUOxaAoz2KD0yZL0AgjMwM+gglHwT8aEDOMrLS5z44V 7kOnLWXqwS7/AoSFIlqp+D4VbRv0gPTmqh4us8ZqKr8CzEC8NFMFwXYntnKuwhum E9mC/PdSRS0T9yIZCOqMx9d6JMJsooTrsRNQG7jGRWxjoqoIQ6dvKwlCYbLmFWsA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudektddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id C3AED1080054; Thu, 8 Apr 2021 19:03:28 -0400 (EDT) Date: Thu, 8 Apr 2021 19:03:26 -0400 From: Leo Famulari To: Marius Bakke Subject: Re: bug#42129: guix-install.sh does not add build users to kvm group Message-ID: References: <875zb91w0d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8KmPfIRurEaBZdlT" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42129 Cc: 42129@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --8KmPfIRurEaBZdlT Content-Type: multipart/mixed; boundary="Ya3vWrCHcsQLbnTX" Content-Disposition: inline --Ya3vWrCHcsQLbnTX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 08, 2021 at 06:38:59PM -0400, Leo Famulari wrote: > On Mon, Jun 29, 2020 at 10:01:54PM +0200, Marius Bakke wrote: > > guix-install.sh should add the build users to the 'kvm' group if present > > so that commands that require use of KVM can succeed. >=20 > Here is a patch (untested) that makes sure a 'kvm' group exists and adds > it to the guixbuilders' groups. I realized that you specified that the build users should be added to the kvm group 'if' it is present. So, here is a revised patch. --Ya3vWrCHcsQLbnTX Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="v2-0001-guix-install.sh-Add-the-build-users-to-the-kvm-gr.patch" Content-Transfer-Encoding: quoted-printable =46rom 1a9fd7decd843f21c36d8ec4d1e218f478b983cf Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Thu, 8 Apr 2021 18:34:43 -0400 Subject: [PATCH v2] guix-install.sh: Add the build users to the 'kvm' group. * etc/guix-install.sh (sys_create_build_user): If a 'kvm' group exists, add it to the guixbuilders' lists of supplementary groups. --- etc/guix-install.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index c84e7b7577..f3fcbf5d05 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -330,15 +330,20 @@ sys_create_build_user() _msg "${PAS}group created" fi =20 + if [ $(getent group kvm) ]; then + _msg "${INF}group kvm exists and build users will be added to it" + local KVMGROUP=3D,kvm + fi + for i in $(seq -w 1 10); do if id "guixbuilder${i}" &>/dev/null; then _msg "${INF}user is already in the system, reset" - usermod -g guixbuild -G guixbuild \ + usermod -g guixbuild -G guixbuild{$KVMGROUP} \ -d /var/empty -s "$(which nologin)" \ -c "Guix build user $i" \ "guixbuilder${i}"; else - useradd -g guixbuild -G guixbuild \ + useradd -g guixbuild -G guixbuild{$KVMGROUP} \ -d /var/empty -s "$(which nologin)" \ -c "Guix build user $i" --system \ "guixbuilder${i}"; --=20 2.31.1 --Ya3vWrCHcsQLbnTX-- --8KmPfIRurEaBZdlT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmBvi74ACgkQJkb6MLrK fwhpxQ//dyXoDK/WMy2lEeEB7UlUt7ImGZkj3TMh+sxJnwmMyNykC6mxxxUQuiwR y2ziqdNcUI/WdxLj3oTeZ17BLqrsKHLawJFNSqH8qVFksPHkljssfSFrYMCElIMc GnjQ72iVe/jg/iYfyl22A/qYibuH8c2JGbxpOxD2WUHInOIwsNXaizpIQYJgw6tb F5cXPn4rMW/JtwcOe5pYgWic/z5eCE81+RjMqpMlYrpESiZ4CReSt1aCJlL3rmoT /ERSezNAcnASlt6KTUfe6DJHAKtdQf9siywe8Jt/m5junZMr4VA98Y1AJVyUvysf Z8ixZlSLiSpGlQIHYeTM3SqWmjpJbGYmjJtoqX0zBViRhpii9pYGqG6kW/yp4UaP ZZPZ971LkZKiEbPdN3QjGqqPjoMN3AcibnAiyoHasLbVOypS0zbCa49KIl0UEvgg MOON/0LemIme2LzltpOlCxk7+e3izYbTq4vE1np3lffX+y+iEqAA5TE9L+eWGHnP AC7tWuGT6Rfyl4lp38/g/8FXh9i40nVmrgZT9VidL4J4lkjCdVEHGoQwhAWa2ui7 lLh+U+A8yNJHCZYPd2+NaWrnduZiB3ze9dmjRIq7MVrqA3L1BEkLSavwBqEKqh/X cI2gn/bPf9zoYnNHCbeB97rOuIfa4oPw5+RVCrXWK+iBWJlYTVE= =e4ui -----END PGP SIGNATURE----- --8KmPfIRurEaBZdlT-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 14 15:33:59 2021 Received: (at 42129-done) by debbugs.gnu.org; 14 Apr 2021 19:34:00 +0000 Received: from localhost ([127.0.0.1]:35767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWlGx-0002mW-Nf for submit@debbugs.gnu.org; Wed, 14 Apr 2021 15:33:59 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWlGw-0002mI-CS for 42129-done@debbugs.gnu.org; Wed, 14 Apr 2021 15:33:59 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3796E5C00C4; Wed, 14 Apr 2021 15:33:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 14 Apr 2021 15:33:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=5l2t7Bcv2pzpLAJWSYkL7moi Ye1VmC83nFWfQPOEIxQ=; b=PSutJ0Dm8x/hkh9c3KPZ/EJs1qLqanKFAwaOKWOB PuwMlisTznwObrltqZ0K/8h5or3ffhD6OYLuHwI9sPWQYrgtHk1QWshuj9oMGuuB 1BDAdpXbLrYQMBcyF36QBVkMhAustiSG0Nse01Bu907ut3Y4FVOvuDgoHF3DB7Pe jx4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5l2t7B cv2pzpLAJWSYkL7moiYe1VmC83nFWfQPOEIxQ=; b=EkE5r/6+YD7IKMXwCq9ivE V/lhvH7orsLA/ZJS+Rm4oRgnzPzNzp3tMS5kg9mGL/p1d/kgNdFi0AA3IIMoxosP lJaxGecrqEOE2WKkesFgj74EcCslgO0LhjmafjwW6omPciERLER7CVdU3MM+McPE 5LW5hxsMwDVk5GXZJk3C48JuVQxyFfcm6jAguJdIySZCrebfCc4SepTsXi6mPMK/ OcYX6yEr0xnAxJ1alPp+8umYSg/0EdHMGO+HX0h+SgbsanRLuDPibT+LvdcsDBnC 4sf1OdNBikzS+bvAqpsF9R5Q/ZBA7Qh1ATmkadTXdumkzt0p1WZSeWhRbYbjMGng == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepudekveegteekleetgfeitdejgfejkeffudethedvhfeukeduleeikeejfeeh ffetnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id AD7AA1080063; Wed, 14 Apr 2021 15:33:52 -0400 (EDT) Date: Wed, 14 Apr 2021 15:33:46 -0400 From: Leo Famulari To: Marius Bakke Subject: Re: bug#42129: guix-install.sh does not add build users to kvm group Message-ID: References: <875zb91w0d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mAL9AYMCSNnIg7Rk" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42129-done Cc: 42129-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --mAL9AYMCSNnIg7Rk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 08, 2021 at 07:03:26PM -0400, Leo Famulari wrote: > From 1a9fd7decd843f21c36d8ec4d1e218f478b983cf Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Thu, 8 Apr 2021 18:34:43 -0400 > Subject: [PATCH v2] guix-install.sh: Add the build users to the 'kvm' gro= up. >=20 > * etc/guix-install.sh (sys_create_build_user): If a 'kvm' group exists, > add it to the guixbuilders' lists of supplementary groups. I tested, fixed bugs, and pushed as 8e214c53a48a841887a59f24a20e7392b5e59b55 --mAL9AYMCSNnIg7Rk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmB3Q5oACgkQJkb6MLrK fwhUpxAA6cDg9ih/ochJxkcIJe+C6hueYYumzbohQmVgsOBPz6ubSuy+wCNJFXtt 3wFtq+ogVKIW4s2/6WFRIEsZAduRKCzfuRr/gKxq6Rh4GaXrIfhjclzv/UVEO+et rgpd2SxYJ+gytr7VHCV6kewpQboS8aVuh0x0YCTRGgkibkJN9JHTnJG8jUoAaMez 0u8VDemkGAk09jhO0ylTplqooLw3jM2tzuwR8BssGdamk1d6cPTfeC3fODguD4Rm KYoyCKeaMXhapiPzh9yiIVruzqcKw39vmMvB57uhO7qM9p+JhFKl3QhhvdrTGokP zjePGF5FuB/zxEO4WwmBrAOIiRDXmaZcJ739AcDVh04yavwG/qjYb9/lWrS1HK/1 NCIIXAUUi81TYFwfmrGHk0IU7HduU7ouR98SEYlngJ/HYN1/8kUu7Nho3yF509Uv NRmS/+pdma0vtkI5R9mES7/gf4zU0KgnySlk2iT9PL6kMbckUyp73Nh/DJxRozVx DzHrr+Q35Ttjsm45NjH1HH7y7a/83+7xOPCq12W1D+bY7nLt1S+j9vk096sHl/dp 9qyEFtLsvuTzT0hFlvh05T5TbM8n8Ll8T6gRBGh4FMxTQ3owOcIPoXt316sBBxjF FMCVLvgHLVQcmnHsvingbywtJhKVWntm4C1x0lbjGPabxgP0Wvg= =hMQP -----END PGP SIGNATURE----- --mAL9AYMCSNnIg7Rk-- From unknown Tue Jun 17 01:43:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 13 May 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator