From unknown Sat Aug 09 01:35:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42111: tests/syscalls.scm stumbles on network interface aliases Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 28 Jun 2020 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42111 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 42111@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159335955017096 (code B ref -1); Sun, 28 Jun 2020 15:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jun 2020 15:52:30 +0000 Received: from localhost ([127.0.0.1]:46814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpZba-0004Rg-Cd for submit@debbugs.gnu.org; Sun, 28 Jun 2020 11:52:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:50830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpZbV-0004RU-JY for submit@debbugs.gnu.org; Sun, 28 Jun 2020 11:52:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpZbV-0001eG-B5 for bug-guix@gnu.org; Sun, 28 Jun 2020 11:52:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44218) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpZbT-0001ha-4k for bug-guix@gnu.org; Sun, 28 Jun 2020 11:52:25 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:54576 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpZbS-00075n-Ib for bug-guix@gnu.org; Sun, 28 Jun 2020 11:52:22 -0400 From: Marius Bakke Date: Sun, 28 Jun 2020 17:52:20 +0200 Message-ID: <87y2o7b32j.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello, The "network-interface-names" test from tests/syscalls.scm fails if a network interface alias is configured. I.e. this command: ip addr add 127.0.0.2/8 dev lo label lo:lcat causes the interface to show up in (network-interface-names), but not (all-network-interface-names), breaking the test. I could not find a procfs file that displays network aliases, so ISTM we either need to add syscalls to check IFLA_IFALIAS, or simply ignore interfaces with a colon (which seems to be required). This patch does the latter and makes the test succeed: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=diff Content-Transfer-Encoding: quoted-printable diff --git a/tests/syscalls.scm b/tests/syscalls.scm index 6acaa0b131..7aa16ce3f4 100644 =2D-- a/tests/syscalls.scm +++ b/tests/syscalls.scm @@ -382,7 +382,10 @@ (member "lo" names)))) =20 (test-assert "network-interface-names" =2D (match (network-interface-names) + (match (filter (lambda (if) + ;; Ignore interface aliases. + (not (string-contains if ":"))) + (network-interface-names)) (((? string? names) ..1) (lset<=3D string=3D? names (all-network-interface-names))))) =20 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl74vLQACgkQoqBt8qM6 VPqy0AgA1ayZ5xwX81s2CnxRJltT0DCBZNNr8Ob8BcecJu3jlcHFJTA2gqMPaDeu nKF7l7s3pdNecb9Dc4BbOWKdH1xrRTCg1rsFPg1hO2SsqinBo/r+7VFvsBBj8XIu zT48pxRnmpOn0JM53QfVYJCHFUAAjViT7uX2LMPoE/8PMhaBWiWu8jVDjoQaBfBW BuCXpNVsrGxEjxuvNMOfo8DixU4fCNU1v1kkPqRikcNhBY1JiecJNewh+fJjAaEv lTUlf2jSYJBZbY36PtC6VZTCRdjHZvSWAuXaJaL7A/oVdQrittvUObTBSNxhQlZ1 EijuYebEjcEmYg5oM+M/qlo/eCXJrw== =5nLf -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Aug 09 01:35:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42111: tests/syscalls.scm stumbles on network interface aliases Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 28 Jun 2020 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42111 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Marius Bakke Cc: 42111@debbugs.gnu.org Received: via spool by 42111-submit@debbugs.gnu.org id=B42111.15933781408083 (code B ref 42111); Sun, 28 Jun 2020 21:03:02 +0000 Received: (at 42111) by debbugs.gnu.org; 28 Jun 2020 21:02:20 +0000 Received: from localhost ([127.0.0.1]:47073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpeRQ-00026J-8w for submit@debbugs.gnu.org; Sun, 28 Jun 2020 17:02:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpeRM-000264-Bw for 42111@debbugs.gnu.org; Sun, 28 Jun 2020 17:02:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47999) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpeRH-0001Em-2k for 42111@debbugs.gnu.org; Sun, 28 Jun 2020 17:02:11 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpeRF-0004zX-V7; Sun, 28 Jun 2020 17:02:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y2o7b32j.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Jun 2020 23:02:08 +0200 In-Reply-To: <87y2o7b32j.fsf@gnu.org> (Marius Bakke's message of "Sun, 28 Jun 2020 17:52:20 +0200") Message-ID: <877dvqgazz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Marius Bakke skribis: > The "network-interface-names" test from tests/syscalls.scm fails if a > network interface alias is configured. > > I.e. this command: > > ip addr add 127.0.0.2/8 dev lo label lo:lcat Woow. =F0=9F=90=88 > diff --git a/tests/syscalls.scm b/tests/syscalls.scm > index 6acaa0b131..7aa16ce3f4 100644 > --- a/tests/syscalls.scm > +++ b/tests/syscalls.scm > @@ -382,7 +382,10 @@ > (member "lo" names)))) >=20=20 > (test-assert "network-interface-names" > - (match (network-interface-names) > + (match (filter (lambda (if) > + ;; Ignore interface aliases. Perhaps add =E2=80=9Csince they don=E2=80=99t show up in (all-network-inter= face-names)=E2=80=9D. > + (not (string-contains if ":"))) > + (network-interface-names)) You can use =E2=80=98remove=E2=80=99 instead of =E2=80=98filter=E2=80=99 + = =E2=80=98not=E2=80=99. Otherwise LGTM, thanks! Ludo=E2=80=99. From unknown Sat Aug 09 01:35:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Marius Bakke Subject: bug#42111: closed (Re: bug#42111: tests/syscalls.scm stumbles on network interface aliases) Message-ID: References: <87r1tyc1oc.fsf@gnu.org> <87y2o7b32j.fsf@gnu.org> X-Gnu-PR-Message: they-closed 42111 X-Gnu-PR-Package: guix Reply-To: 42111@debbugs.gnu.org Date: Sun, 28 Jun 2020 21:38:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1593380281-11854-1" This is a multi-part message in MIME format... ------------=_1593380281-11854-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42111: tests/syscalls.scm stumbles on network interface aliases which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42111@debbugs.gnu.org. --=20 42111: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42111 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1593380281-11854-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42111-done) by debbugs.gnu.org; 28 Jun 2020 21:37:18 +0000 Received: from localhost ([127.0.0.1]:47104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpezG-00034J-0k for submit@debbugs.gnu.org; Sun, 28 Jun 2020 17:37:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpezD-000342-M6 for 42111-done@debbugs.gnu.org; Sun, 28 Jun 2020 17:37:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48487) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpez8-0006NC-DM; Sun, 28 Jun 2020 17:37:10 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:58342 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpez7-0001ba-R3; Sun, 28 Jun 2020 17:37:10 -0400 From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#42111: tests/syscalls.scm stumbles on network interface aliases In-Reply-To: <877dvqgazz.fsf@gnu.org> References: <87y2o7b32j.fsf@gnu.org> <877dvqgazz.fsf@gnu.org> Date: Sun, 28 Jun 2020 23:37:07 +0200 Message-ID: <87r1tyc1oc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42111-done Cc: 42111-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> diff --git a/tests/syscalls.scm b/tests/syscalls.scm >> index 6acaa0b131..7aa16ce3f4 100644 >> --- a/tests/syscalls.scm >> +++ b/tests/syscalls.scm >> @@ -382,7 +382,10 @@ >> (member "lo" names)))) >>=20=20 >> (test-assert "network-interface-names" >> - (match (network-interface-names) >> + (match (filter (lambda (if) >> + ;; Ignore interface aliases. > > Perhaps add =E2=80=9Csince they don=E2=80=99t show up in (all-network-int= erface-names)=E2=80=9D. > >> + (not (string-contains if ":"))) >> + (network-interface-names)) > > You can use =E2=80=98remove=E2=80=99 instead of =E2=80=98filter=E2=80=99 = + =E2=80=98not=E2=80=99. ah, much clearer with those suggestions, thanks! Pushed in 5e113cf4424b2746cbf3633cd2106c62b89e5b49. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl75DYMACgkQoqBt8qM6 VPowGAf+PmSbKu/Gs7IjA8+YSSJ88tZFBgvWSBzLmR05EnmpHCsS0kbixNjR5x15 n/oZvxKsZeuWyKJsZkzGR8aOXgNo2mBHcxsubNQOqK//e3575XWGC+ZGWXqGQVD9 Q0E3lRNLYvrSUEe0HAuFhYsoE5ybCYzZK034B1TGb1VbpInWdK4iJ7j308PEibp5 S3nutELLGCp8KGpYZfS75qCkjRT3smVOxDWnkL5cusfe2oYv7Twg1YAa2AlwOEvS TcSe7iqpXurqXrn693Aqv/Cz6GAQ4QFdHq7X2PvVfVuZ7Tu+/vpRKIiQnkwclCp7 3J+ZVXc8SmkqaSTDmFr1Yq8Q7qjY3w== =nwxv -----END PGP SIGNATURE----- --=-=-=-- ------------=_1593380281-11854-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jun 2020 15:52:30 +0000 Received: from localhost ([127.0.0.1]:46814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpZba-0004Rg-Cd for submit@debbugs.gnu.org; Sun, 28 Jun 2020 11:52:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:50830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpZbV-0004RU-JY for submit@debbugs.gnu.org; Sun, 28 Jun 2020 11:52:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpZbV-0001eG-B5 for bug-guix@gnu.org; Sun, 28 Jun 2020 11:52:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44218) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpZbT-0001ha-4k for bug-guix@gnu.org; Sun, 28 Jun 2020 11:52:25 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:54576 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpZbS-00075n-Ib for bug-guix@gnu.org; Sun, 28 Jun 2020 11:52:22 -0400 From: Marius Bakke To: bug-guix@gnu.org Subject: tests/syscalls.scm stumbles on network interface aliases Date: Sun, 28 Jun 2020 17:52:20 +0200 Message-ID: <87y2o7b32j.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello, The "network-interface-names" test from tests/syscalls.scm fails if a network interface alias is configured. I.e. this command: ip addr add 127.0.0.2/8 dev lo label lo:lcat causes the interface to show up in (network-interface-names), but not (all-network-interface-names), breaking the test. I could not find a procfs file that displays network aliases, so ISTM we either need to add syscalls to check IFLA_IFALIAS, or simply ignore interfaces with a colon (which seems to be required). This patch does the latter and makes the test succeed: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=diff Content-Transfer-Encoding: quoted-printable diff --git a/tests/syscalls.scm b/tests/syscalls.scm index 6acaa0b131..7aa16ce3f4 100644 =2D-- a/tests/syscalls.scm +++ b/tests/syscalls.scm @@ -382,7 +382,10 @@ (member "lo" names)))) =20 (test-assert "network-interface-names" =2D (match (network-interface-names) + (match (filter (lambda (if) + ;; Ignore interface aliases. + (not (string-contains if ":"))) + (network-interface-names)) (((? string? names) ..1) (lset<=3D string=3D? names (all-network-interface-names))))) =20 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl74vLQACgkQoqBt8qM6 VPqy0AgA1ayZ5xwX81s2CnxRJltT0DCBZNNr8Ob8BcecJu3jlcHFJTA2gqMPaDeu nKF7l7s3pdNecb9Dc4BbOWKdH1xrRTCg1rsFPg1hO2SsqinBo/r+7VFvsBBj8XIu zT48pxRnmpOn0JM53QfVYJCHFUAAjViT7uX2LMPoE/8PMhaBWiWu8jVDjoQaBfBW BuCXpNVsrGxEjxuvNMOfo8DixU4fCNU1v1kkPqRikcNhBY1JiecJNewh+fJjAaEv lTUlf2jSYJBZbY36PtC6VZTCRdjHZvSWAuXaJaL7A/oVdQrittvUObTBSNxhQlZ1 EijuYebEjcEmYg5oM+M/qlo/eCXJrw== =5nLf -----END PGP SIGNATURE----- --==-=-=-- ------------=_1593380281-11854-1--