From tromey@redhat.com Wed Aug 19 14:20:44 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 19 Aug 2009 21:20:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7JLKhsB024355 for ; Wed, 19 Aug 2009 14:20:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdsaI-00084x-GY for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 17:20:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdsaE-00080d-Rc for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 17:20:42 -0400 Received: from [199.232.76.173] (port=47172 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdsaE-00080a-Mz for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 17:20:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24983) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MdsaE-00042Z-56 for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 17:20:38 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7JLKZxp017137 for ; Wed, 19 Aug 2009 17:20:35 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7JLKY4h028956; Wed, 19 Aug 2009 17:20:35 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7JLKXjC023182; Wed, 19 Aug 2009 17:20:34 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 27E8F3782EF; Wed, 19 Aug 2009 15:20:32 -0600 (MDT) From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 23.1; vc-dir bug with git Reply-To: Tom Tromey X-Attribution: Tom Date: Wed, 19 Aug 2009 15:20:32 -0600 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I ran vc-dir on a git checkout that I have. I have some unregistered subdirectories in this checkout, for example autom4te.cache (created by autoconf). In the *vc-dir* buffer I see: gdb/testsuite/autom4te.cache/ unregistered gdb/testsuite/autom4te.cache/ That is, the directory is listed twice. This seems weird to me. Is this intentional? I think it should only be listed once. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5) of 2009-08-03 on x86-5.fedora.phx.redhat.com Windowing system distributor `The X.Org Foundation', version 11.0.10601901 configured using `configure '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-spelling-mode: t erc-truncate-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t gnus-undo-mode: t highlight-changes-visible-mode: t erc-status-mode: t erc-services-mode: t erc-networks-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x o C-x 1 M-> " s e t SPC v a r i a b l e " I SPC u s u a l l y SPC j u s t SPC u s e SPC " p r i n t " SPC s h o t h o u g h l i k e SPC : S-SPC SPC p SPC x SPC = SPC 5 C-c b C-c b C-z o C-x b * g u q y C-c b C-e C-a C-p C-p C-k C-k C-k C-o C-n C-e M-b M-b M-b M-b TAB C-n TAB C-a C-n C-p C-p C-e C-k M-SPC C-n C-a C-M-SPC C-M-\ C-M-f } C-a C-u C-u C-p C-l C-p C-p C-p C-s = C-b C-a C-u C-u C-p C-l C-x C-s C-c b C-z o C-x b * G 1 g C-z o C-x v d a r C-x 1 C-u C-n C-n C-n C-n C-h c i C-h c I C-h w v c - i g C-g C-g C-g C-h c d C-u C-n C-n C-n C-n f C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-x k C-z o C-z o M-x r e p o r t - e m Recent messages: Wrote /home/tromey/Mail/mail/other/275197 Wrote /home/tromey/Mail/mail/other/275198 nnml: Reading incoming mail (15 new)...done Opening nnml server on private...done Opening nnml server...done Checking new news...done i runs the command vc-register I is undefined Quit [3 times] d is undefined call-interactively: End of buffer Tom From dann@godzilla.ics.uci.edu Thu Aug 20 21:14:15 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 21 Aug 2009 04:14:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L4EECX005071 for <4206@emacsbugs.donarmstrong.com>; Thu, 20 Aug 2009 21:14:15 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7L4E1Uo000216; Thu, 20 Aug 2009 21:14:01 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7L4E1w0015475; Thu, 20 Aug 2009 21:14:01 -0700 (PDT) Date: Thu, 20 Aug 2009 21:14:01 -0700 (PDT) Message-Id: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Tom Tromey Cc: 4206@debbugs.gnu.org Subject: Re: bug#4206: 23.1; vc-dir bug with git References: X-Debbugs-No-Ack: yes In-Reply-To: (Tom Tromey's message of "Wed, 19 Aug 2009 15:20:32 -0600") Lines: 33 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7L4E1Uo000216 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Tom Tromey writes: > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. > > Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, > and to the gnu.emacs.bug news group. > > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > > I ran vc-dir on a git checkout that I have. > I have some unregistered subdirectories in this checkout, > for example autom4te.cache (created by autoconf). > > In the *vc-dir* buffer I see: > > gdb/testsuite/autom4te.cache/ > unregistered gdb/testsuite/autom4te.cache/ > > That is, the directory is listed twice. > > This seems weird to me. Is this intentional? > I think it should only be listed once. Not really intentional. vc-dir assumes that vc-git-dir-status returns only files, that's why it gets confused when it gets a directory with the "unregistered" state. What's the right thing to do here? vc-git-register does not support (yet?) passing directories as an argument. From tromey@redhat.com Fri Aug 21 10:46:13 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 21 Aug 2009 17:46:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.1 required=4.0 tests=AWL,HAS_BUG_NUMBER, SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7LHkCDL020864 for <4206@emacsbugs.donarmstrong.com>; Fri, 21 Aug 2009 10:46:13 -0700 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7LHk7ue011477; Fri, 21 Aug 2009 13:46:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7LHk69n007140; Fri, 21 Aug 2009 13:46:06 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7LHk5nB000719; Fri, 21 Aug 2009 13:46:05 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C62383782EF; Fri, 21 Aug 2009 11:46:04 -0600 (MDT) From: Tom Tromey To: Dan Nicolaescu Cc: 4206@debbugs.gnu.org Subject: Re: bug#4206: 23.1; vc-dir bug with git References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> Reply-To: Tom Tromey X-Attribution: Tom Date: Fri, 21 Aug 2009 11:46:04 -0600 In-Reply-To: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 20 Aug 2009 21:14:01 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 >>>>> "Dan" == Dan Nicolaescu writes: Dan> What's the right thing to do here? Dan> vc-git-register does not support (yet?) passing directories as an Dan> argument. I think the best situation would be for vc-dir to understand unregistered directories (and not display them twice), and for vc-git-register to be able to run "git add" on a directory. "git add DIR" usually does the right thing and in any case if it "overshoots" it can be corrected. Tom From dann@godzilla.ics.uci.edu Sun Aug 23 04:57:32 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 23 Aug 2009 11:57:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7NBvVVM006091 for <4206@emacsbugs.donarmstrong.com>; Sun, 23 Aug 2009 04:57:32 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7NBvE66015022; Sun, 23 Aug 2009 04:57:14 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7NBvErL011081; Sun, 23 Aug 2009 04:57:14 -0700 (PDT) Date: Sun, 23 Aug 2009 04:57:14 -0700 (PDT) Message-Id: <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Tom Tromey Cc: 4206@debbugs.gnu.org Subject: Re: bug#4206: 23.1; vc-dir bug with git References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Tom Tromey's message of "Fri, 21 Aug 2009 11:46:04 -0600") Lines: 97 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7NBvE66015022 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Tom Tromey writes: > >>>>> "Dan" == Dan Nicolaescu writes: > > Dan> What's the right thing to do here? > Dan> vc-git-register does not support (yet?) passing directories as an > Dan> argument. > > I think the best situation would be for vc-dir to understand > unregistered directories (and not display them twice), and for > vc-git-register to be able to run "git add" on a directory. The patch below helps. But the *vc-dir* buffer does not get updated correctly. Maybe vc-git-dir-status-files does not work quite right, but it's hard to tell without being a low level git expert. > "git add DIR" usually does the right thing and in any case if it "overshoots" it > can be corrected. It seems that vc-git-revert does not revert files in the 'added state to 'unregistered state. It does not seem that all VC backends behave consistently in this situation :-( --- vc-dir.el.~1.40.~ 2009-08-20 23:40:25.000000000 -0700 +++ vc-dir.el 2009-08-23 04:02:01.000000000 -0700 @@ -326,8 +326,9 @@ If BODY uses EVENT, it should be a varia (or (vc-dir-fileinfo->directory data) ;; Otherwise compute it from the file name. (file-name-directory - (expand-file-name - (vc-dir-fileinfo->name data)))))) + (directory-file-name + (expand-file-name + (vc-dir-fileinfo->name data))))))) (defun vc-dir-update (entries buffer &optional noinsert) "Update BUFFER's ewoc from the list of ENTRIES. @@ -343,8 +344,10 @@ If NOINSERT, ignore elements on ENTRIES ;; names too many times (sort entries (lambda (entry1 entry2) - (let ((dir1 (file-name-directory (expand-file-name (car entry1)))) - (dir2 (file-name-directory (expand-file-name (car entry2))))) + (let ((dir1 (file-name-directory + (directory-file-name (expand-file-name (car entry1))))) + (dir2 (file-name-directory + (directory-file-name (expand-file-name (car entry2)))))) (cond ((string< dir1 dir2) t) ((not (string= dir1 dir2)) nil) @@ -362,7 +365,8 @@ If NOINSERT, ignore elements on ENTRIES (while (and entry node) (let* ((entryfile (car entry)) - (entrydir (file-name-directory (expand-file-name entryfile))) + (entrydir (file-name-directory (directory-file-name + (expand-file-name entryfile)))) (nodedir (vc-dir-node-directory node))) (cond ;; First try to find the directory. @@ -406,7 +410,8 @@ If NOINSERT, ignore elements on ENTRIES (unless (or node noinsert) (let ((lastdir (vc-dir-node-directory (ewoc-nth vc-ewoc -1)))) (dolist (entry entries) - (let ((entrydir (file-name-directory (expand-file-name (car entry))))) + (let ((entrydir (file-name-directory + (directory-file-name (expand-file-name (car entry)))))) ;; Insert a directory node if needed. (unless (string-equal lastdir entrydir) (setq lastdir entrydir) Index: vc-git.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/vc-git.el,v retrieving revision 1.86 diff -u -3 -p -u -p -r1.86 vc-git.el --- vc-git.el 21 Aug 2009 03:37:37 -0000 1.86 +++ vc-git.el 23 Aug 2009 11:06:39 -0000 @@ -425,7 +425,15 @@ If nil, use the value of `vc-diff-switch (defun vc-git-register (files &optional rev comment) "Register FILE into the git version-control system." - (vc-git-command nil 0 files "update-index" "--add" "--")) + (let (flist dlist) + (dolist (crt files) + (if (file-directory-p crt) + (push crt dlist) + (push crt flist))) + (when flist + (vc-git-command nil 0 flist "update-index" "--add" "--")) + (when dlist + (vc-git-command nil 0 dlist "add")))) (defalias 'vc-git-responsible-p 'vc-git-root) From monnier@IRO.UMontreal.CA Tue Aug 25 10:54:15 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 25 Aug 2009 17:54:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7PHsCaG003118 for <4206@emacsbugs.donarmstrong.com>; Tue, 25 Aug 2009 10:54:14 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n7PHsBHA028113; Tue, 25 Aug 2009 13:54:11 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 8733E3A06B; Tue, 25 Aug 2009 13:54:11 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4206@debbugs.gnu.org, Tom Tromey Subject: Re: bug#4206: 23.1; vc-dir bug with git Message-ID: References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> Date: Tue, 25 Aug 2009 13:54:11 -0400 In-Reply-To: <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 23 Aug 2009 04:57:14 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3348=0 > It seems that vc-git-revert does not revert files in the 'added state to > 'unregistered state. It does not seem that all VC backends behave > consistently in this situation :-( The first thing to do is to decide which behavior is preferable, and to document it in the leading comments of vc.el. Stefan From dann@godzilla.ics.uci.edu Tue Aug 25 11:48:35 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 25 Aug 2009 18:48:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7PImY2d012029 for <4206@emacsbugs.donarmstrong.com>; Tue, 25 Aug 2009 11:48:35 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7PImJMu023603; Tue, 25 Aug 2009 11:48:19 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7PImJbN012726; Tue, 25 Aug 2009 11:48:19 -0700 (PDT) Message-Id: <200908251848.n7PImJbN012726@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4206@debbugs.gnu.org, Tom Tromey Subject: Re: bug#4206: 23.1; vc-dir bug with git Date: Tue, 25 Aug 2009 11:14:36 -0700 References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes Lines: 14 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7PImJMu023603 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > It seems that vc-git-revert does not revert files in the 'added state to > > 'unregistered state. It does not seem that all VC backends behave > > consistently in this situation :-( > > The first thing to do is to decide which behavior is preferable, and > to document it in the leading comments of vc.el. IMO it would be better if vc-revert of a file in 'added state should put it to 'unregistered. We don't have another way to do this in VC, and this is a very intuitive UI. WDYT? From monnier@IRO.UMontreal.CA Tue Aug 25 14:16:30 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 25 Aug 2009 21:16:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7PLGSWl004753 for <4206@emacsbugs.donarmstrong.com>; Tue, 25 Aug 2009 14:16:30 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n7PLGSkH010237; Tue, 25 Aug 2009 17:16:28 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id EFF013A06F; Tue, 25 Aug 2009 17:16:27 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4206@debbugs.gnu.org, Tom Tromey Subject: Re: bug#4206: 23.1; vc-dir bug with git Message-ID: References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> <200908251848.n7PImJbN012726@godzilla.ics.uci.edu> Date: Tue, 25 Aug 2009 17:16:27 -0400 In-Reply-To: <200908251848.n7PImJbN012726@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 25 Aug 2009 11:14:36 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3348=0 >> > It seems that vc-git-revert does not revert files in the 'added state to >> > 'unregistered state. It does not seem that all VC backends behave >> > consistently in this situation :-( >> >> The first thing to do is to decide which behavior is preferable, and >> to document it in the leading comments of vc.el. > IMO it would be better if vc-revert of a file in 'added state should > put it to 'unregistered. We don't have another way to do this in VC, > and this is a very intuitive UI. Agreed. Stefan From dann@godzilla.ics.uci.edu Thu Dec 10 11:44:49 2009 Received: (at 4206) by emacsbugs.donarmstrong.com; 10 Dec 2009 19:44:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.3 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBAJimOv014336 for <4206@emacsbugs.donarmstrong.com>; Thu, 10 Dec 2009 11:44:49 -0800 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nBAJiaGS015754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Dec 2009 11:44:36 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nBAJiarK014710; Thu, 10 Dec 2009 11:44:36 -0800 (PST) Date: Thu, 10 Dec 2009 11:44:36 -0800 (PST) Message-Id: <200912101944.nBAJiarK014710@godzilla.ics.uci.edu> From: Dan Nicolaescu To: 4206@debbugs.gnu.org Cc: Tom Tromey Subject: Re: bug#4206: 23.1; vc-dir bug with git References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 23 Aug 2009 04:57:14 -0700 (PDT)") Lines: 1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nBAJiaGS015754 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Is this still a problem with the current CVS? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 20:40:54 2010 Received: (at control) by debbugs.gnu.org; 20 Jan 2010 01:40:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXPYz-0007Wd-5s for submit@debbugs.gnu.org; Tue, 19 Jan 2010 20:40:53 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXPYl-0007WW-Uj for control@debbugs.gnu.org; Tue, 19 Jan 2010 20:40:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NXPYi-0007Sl-Bs; Tue, 19 Jan 2010 20:40:36 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19286.24340.350706.582414@gargle.gargle.HOWL> Date: Tue, 19 Jan 2010 20:40:36 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: cyan X-Ran: 8WU:4P)DBN*0i&7=5k?sw9O_ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) close 2951 tags 4206 moreinfo tags 3098 patch tags 2499 patch tags 5297 patch tags 5290 patch tags 1975 patch tags 4470 patch tags 5055 patch tags 3541 patch tags 2527 patch tags 5119 patch tags 2404 patch From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 27 15:00:17 2012 Received: (at 4206-done) by debbugs.gnu.org; 27 Mar 2012 19:00:17 +0000 Received: from localhost ([127.0.0.1]:41589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SCbcn-0004mz-5U for submit@debbugs.gnu.org; Tue, 27 Mar 2012 15:00:17 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:57437) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SCbcl-0004ms-CH for 4206-done@debbugs.gnu.org; Tue, 27 Mar 2012 15:00:07 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SCb8U-00039K-3v; Tue, 27 Mar 2012 14:28:50 -0400 From: Glenn Morris To: 4206-done@debbugs.gnu.org Subject: Re: bug#4206: 23.1; vc-dir bug with git References: <200908210414.n7L4E1w0015475@godzilla.ics.uci.edu> <200908231157.n7NBvErL011081@godzilla.ics.uci.edu> <200912101944.nBAJiarK014710@godzilla.ics.uci.edu> X-Spook: rs9512c Rubin assassination benelux top secret AGT. AMME X-Ran: RA{'os22jjxYJ"Yx/7mi0lXv[jwtf&RL:k!e6RQ1,cAFQGKdWm(i',ef9t%`gX|xm/:44x X-Hue: blue X-Attribution: GM Date: Tue, 27 Mar 2012 14:28:49 -0400 In-Reply-To: <200912101944.nBAJiarK014710@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 10 Dec 2009 11:44:36 -0800 (PST)") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 4206-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Version: 23.2 Dan Nicolaescu wrote: > Is this still a problem with the current CVS? AFAICS, this is fixed in 23.2 and later. From unknown Thu Jun 19 14:11:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Apr 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator