From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 24 08:58:00 2020 Received: (at submit) by debbugs.gnu.org; 24 Jun 2020 12:58:00 +0000 Received: from localhost ([127.0.0.1]:37945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jo4yV-00026V-QD for submit@debbugs.gnu.org; Wed, 24 Jun 2020 08:58:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:33986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jo4yU-00026O-Pj for submit@debbugs.gnu.org; Wed, 24 Jun 2020 08:57:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jo4yU-0000Bm-H9 for guix-patches@gnu.org; Wed, 24 Jun 2020 08:57:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49342) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jo4yT-0000QS-J4; Wed, 24 Jun 2020 08:57:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59798 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jo4yS-0003ix-8c; Wed, 24 Jun 2020 08:57:56 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] channels: Error out when the 'guix' channel lacks an introduction. Date: Wed, 24 Jun 2020 14:57:49 +0200 Message-Id: <20200624125749.10908-1-ludo@gnu.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/channels.scm (latest-channel-instance): Raise an error instead of warning when 'guix is unauthenticated. * tests/channels.scm ("latest-channel-instances, missing introduction for 'guix'"): New test. --- guix/channels.scm | 13 ++++++++++--- tests/channels.scm | 21 +++++++++++++++++++++ 2 files changed, 31 insertions(+), 3 deletions(-) Hi! This patch makes it an error to have a 'guix' channel without an introduction. Before that, it was just a warning, which is easily overlooked. (Similarly, wget or your browser stop if they cannot authenticate the host you're connecting to over HTTPS.) Note that when using the "official" 'guix' channel, (guix channels) automatically adds the introduction (see commit c3f6f564e909ebefe752d24b325871a4e3a02d40). It will work similarly for people who maintain forks. Thanks, Ludo'. diff --git a/guix/channels.scm b/guix/channels.scm index 3eec5df883..1016b95045 100644 --- a/guix/channels.scm +++ b/guix/channels.scm @@ -406,9 +406,16 @@ their relation. When AUTHENTICATE? is false, CHANNEL is not authenticated." ;; TODO: Warn for all the channels once the authentication interface ;; is public. (when (guix-channel? channel) - (warning (G_ "channel '~a' lacks an introduction and \ -cannot be authenticated~%") - (channel-name channel)))) + (raise (condition + (&message + (message (format #f (G_ "channel '~a' lacks an \ +introduction and cannot be authenticated~%") + (channel-name channel)))) + (&fix-hint + (hint (G_ "Add the missing introduction to your +channels file to address the issue. Alternatively, you can pass +@option{--disable-authentication}, at the risk of running unauthenticated and +thus potentially malicious code."))))))) (warning (G_ "channel authentication disabled~%"))) (when (guix-channel? channel) diff --git a/tests/channels.scm b/tests/channels.scm index 3a2c1d429b..d7202f8cbf 100644 --- a/tests/channels.scm +++ b/tests/channels.scm @@ -402,6 +402,27 @@ (channel-news-for-commit channel commit5 commit1)) '(#f "tag-for-first-news-entry"))))))) +(unless (which (git-command)) (test-skip 1)) +(test-assert "latest-channel-instances, missing introduction for 'guix'" + (with-temporary-git-repository directory + '((add "a.txt" "A") + (commit "first commit") + (add "b.scm" "#t") + (commit "second commit")) + (with-repository directory repository + (let* ((commit1 (find-commit repository "first")) + (commit2 (find-commit repository "second")) + (channel (channel (url (string-append "file://" directory)) + (name 'guix)))) + + (guard (c ((message-condition? c) + (->bool (string-contains (condition-message c) + "introduction")))) + (with-store store + ;; Attempt a downgrade from NEW to OLD. + (latest-channel-instances store (list channel)) + #f)))))) + (unless (gpg+git-available?) (test-skip 1)) (test-equal "authenticate-channel, wrong first commit signer" #t -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 24 17:13:57 2020 Received: (at 42030) by debbugs.gnu.org; 24 Jun 2020 21:13:58 +0000 Received: from localhost ([127.0.0.1]:39229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joCiT-0005xu-Ov for submit@debbugs.gnu.org; Wed, 24 Jun 2020 17:13:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joCiO-0005xb-E0 for 42030@debbugs.gnu.org; Wed, 24 Jun 2020 17:13:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55836) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joCiI-0007sN-EJ; Wed, 24 Jun 2020 17:13:46 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:57328 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joCiH-0005nD-V4; Wed, 24 Jun 2020 17:13:46 -0400 From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 42030@debbugs.gnu.org Subject: Re: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. In-Reply-To: <20200624125749.10908-1-ludo@gnu.org> References: <20200624125749.10908-1-ludo@gnu.org> Date: Wed, 24 Jun 2020 23:13:43 +0200 Message-ID: <87d05o6ubc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42030 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > * guix/channels.scm (latest-channel-instance): Raise an error instead of > warning when 'guix is unauthenticated. > * tests/channels.scm ("latest-channel-instances, missing introduction for= 'guix'"): > New test. The hunk in tests/channels.scm does not apply. :-) LGTM, anyway. I think we should export %guix-channel-introduction, or alternatively add a %default-guix-channel that can be inherited, for easy access in custom channels.scm files. WDYT? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7zwgcACgkQoqBt8qM6 VPpUuAf+MTG6r6+AVdye8mmcaW3atI/HzlJGRm8rxFhbrfqur6jZrNkuJK3iqDMn w5bQjVoWXwdrZCOD8mQuYtB3gHnO+qvlSF/qAs8LCiJ2xSUGGgdKpdDKamwdSsEE JnX5j3V35ZFWGNMsff33wHMt45N76VP0v2XykXSFsdXcNGLFl4pyXyF0Z7O09qzI bMxPhmv17tH/32KBNoVSxIz+raLTdV39i12uNcScAMuSKxGgZQR4eiZ4D44hWfEI +Cyx7Jh8SfXf5FTJPQ48l/PDZvNpr4TTUSb5cpE7D4uiF4hsvIN7E9H4+Pjpq3be W+hnJz9TNjvqtJE6IcV/2yNKSMB74g== =7trw -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 05:29:21 2020 Received: (at 42030) by debbugs.gnu.org; 25 Jun 2020 09:29:21 +0000 Received: from localhost ([127.0.0.1]:39702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joOC9-0000mJ-JO for submit@debbugs.gnu.org; Thu, 25 Jun 2020 05:29:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joOC6-0000m6-87 for 42030@debbugs.gnu.org; Thu, 25 Jun 2020 05:29:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36937) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joOC1-0003eA-0Y for 42030@debbugs.gnu.org; Thu, 25 Jun 2020 05:29:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33492 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joOBz-0006w3-92; Thu, 25 Jun 2020 05:29:12 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marius Bakke Subject: Re: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Messidor an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 25 Jun 2020 11:29:07 +0200 In-Reply-To: <87d05o6ubc.fsf@gnu.org> (Marius Bakke's message of "Wed, 24 Jun 2020 23:13:43 +0200") Message-ID: <87r1u3trx8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42030 Cc: 42030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> * guix/channels.scm (latest-channel-instance): Raise an error instead of >> warning when 'guix is unauthenticated. >> * tests/channels.scm ("latest-channel-instances, missing introduction fo= r 'guix'"): >> New test. > > The hunk in tests/channels.scm does not apply. :-) LGTM, anyway. Ah, maybe because you were too fast: it depends on a18d02def9862dfb9b7a5e3d5aa3b541b066d198, which I pushed yesterday. > I think we should export %guix-channel-introduction, or alternatively > add a %default-guix-channel that can be inherited, for easy access in > custom channels.scm files. WDYT? The idea was to expose only =E2=80=98%default-channels=E2=80=99, which leav= es room for the possibility of having multiple channels by default. I=E2=80=99d rather avoid exposing the individual bits as that=E2=80=99s a bit of an additional committment. But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix chann= el is automatically added anyway (commit c3f6f564e909ebefe752d24b325871a4e3a02d40). Thanks for your feedback! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 28 17:31:28 2020 Received: (at 42030-done) by debbugs.gnu.org; 28 Jun 2020 21:31:28 +0000 Received: from localhost ([127.0.0.1]:47091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpetc-0002tm-3i for submit@debbugs.gnu.org; Sun, 28 Jun 2020 17:31:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpeta-0002tY-HH for 42030-done@debbugs.gnu.org; Sun, 28 Jun 2020 17:31:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48419) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpetV-0005Bz-81 for 42030-done@debbugs.gnu.org; Sun, 28 Jun 2020 17:31:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42736 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpetS-0006CD-FD; Sun, 28 Jun 2020 17:31:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 42030-done@debbugs.gnu.org Subject: Re: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. References: <20200624125749.10908-1-ludo@gnu.org> Date: Sun, 28 Jun 2020 23:31:16 +0200 In-Reply-To: <20200624125749.10908-1-ludo@gnu.org> ("Ludovic \=\?utf-8\?Q\?Cou\?\= \=\?utf-8\?Q\?rt\=C3\=A8s\=22's\?\= message of "Wed, 24 Jun 2020 14:57:49 +0200") Message-ID: <87lfk6ev2z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42030-done Cc: Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > * guix/channels.scm (latest-channel-instance): Raise an error instead of > warning when 'guix is unauthenticated. > * tests/channels.scm ("latest-channel-instances, missing introduction for= 'guix'"): > New test. > --- > guix/channels.scm | 13 ++++++++++--- > tests/channels.scm | 21 +++++++++++++++++++++ > 2 files changed, 31 insertions(+), 3 deletions(-) Pushed as ead5c46147ebf352ad4804d52a766dcf105eda4f. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 29 07:48:00 2020 Received: (at 42030) by debbugs.gnu.org; 29 Jun 2020 11:48:00 +0000 Received: from localhost ([127.0.0.1]:48183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpsGW-0006ay-H4 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 07:48:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpsGT-0006ai-Ku for 42030@debbugs.gnu.org; Mon, 29 Jun 2020 07:47:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57936) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpsGO-0006Gd-Ay; Mon, 29 Jun 2020 07:47:52 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:41002 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpsGM-0001hH-UG; Mon, 29 Jun 2020 07:47:51 -0400 From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. In-Reply-To: <87r1u3trx8.fsf@gnu.org> References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> <87r1u3trx8.fsf@gnu.org> Date: Mon, 29 Jun 2020 13:47:48 +0200 Message-ID: <87o8p2ayaj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42030 Cc: 42030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! Sorry for the late reply. Ludovic Court=C3=A8s writes: >> I think we should export %guix-channel-introduction, or alternatively >> add a %default-guix-channel that can be inherited, for easy access in >> custom channels.scm files. WDYT? > > The idea was to expose only =E2=80=98%default-channels=E2=80=99, which le= aves room for > the possibility of having multiple channels by default. I=E2=80=99d rath= er > avoid exposing the individual bits as that=E2=80=99s a bit of an addition= al > committment. > > But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix cha= nnel is > automatically added anyway (commit > c3f6f564e909ebefe752d24b325871a4e3a02d40). It is only added for people using the default channel URL, and not for local mirrors that may well be authenticated. E.g. (url "/some/dir") or (url "https://github.com/guix-mirror/guix"). Would it make sense to remove the %default-channel-url check from ensure-default-introductions? I think we can safely assume that a channel named 'guix is _the_ Guix channel regardless of where it came from, and if users need to override the introduction they can just do that. Currently I do this to access the channel introduction, which seems needlessly complicated: =2D-8<---------------cut here---------------start------------->8--- (use-modules (srfi srfi-1)) (let ((guix-channel (find (lambda (channel) (eq? 'guix (channel-name channel))) %default-channels))) (list [other channels omitted] (channel (inherit guix-channel) (url "/home/marius/src/guix")))) =2D-8<---------------cut here---------------end--------------->8--- --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl751OQACgkQoqBt8qM6 VPoNGwf9FZQX5ao1Vaw389waMK6k1MS+D0Xul+QSEROrPuzOp1gsIP0oXDamkGR4 Fj+ycbAyBsnyVhH8rb34iTEvRaDDQRAwdzuji/stSoGhs7BfiwiVFyjLlIyK1uFQ 3a9WPRz9ZV+4cSPn1FQRNYJ5lZcz0a+5QzwjUBjnMM0YP5q56RcEWERsqxDt/xho T0d8YTZPy1NEymISSG4CKPCCwU2ZfmimNNRBoT098h/uQOyZGEYYu/Gj03/oJmo0 jczK44Q4b6wEmzuTGUg11cA091GEbG2cHlkknZTQ98tBt41cSV963RN4dQ69x03u gVXoPJLvvP3oGLojQJlUttS4ECyYmA== =V1uG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 29 11:14:52 2020 Received: (at 42030) by debbugs.gnu.org; 29 Jun 2020 15:14:52 +0000 Received: from localhost ([127.0.0.1]:49094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpvUi-0007LI-89 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 11:14:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpvUf-0007L1-Ti for 42030@debbugs.gnu.org; Mon, 29 Jun 2020 11:14:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33102) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpvUa-0008Q2-I8 for 42030@debbugs.gnu.org; Mon, 29 Jun 2020 11:14:44 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38888 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpvUZ-0006Zb-Mh; Mon, 29 Jun 2020 11:14:43 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marius Bakke Subject: Re: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> <87r1u3trx8.fsf@gnu.org> <87o8p2ayaj.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Messidor an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 29 Jun 2020 17:14:40 +0200 In-Reply-To: <87o8p2ayaj.fsf@gnu.org> (Marius Bakke's message of "Mon, 29 Jun 2020 13:47:48 +0200") Message-ID: <87h7utc3a7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42030 Cc: 42030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >>> I think we should export %guix-channel-introduction, or alternatively >>> add a %default-guix-channel that can be inherited, for easy access in >>> custom channels.scm files. WDYT? >> >> The idea was to expose only =E2=80=98%default-channels=E2=80=99, which l= eaves room for >> the possibility of having multiple channels by default. I=E2=80=99d rat= her >> avoid exposing the individual bits as that=E2=80=99s a bit of an additio= nal >> committment. >> >> But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix ch= annel is >> automatically added anyway (commit >> c3f6f564e909ebefe752d24b325871a4e3a02d40). > > It is only added for people using the default channel URL, and not for > local mirrors that may well be authenticated. E.g. (url "/some/dir") or > (url "https://github.com/guix-mirror/guix"). > > Would it make sense to remove the %default-channel-url check from > ensure-default-introductions? I think we can safely assume that a > channel named 'guix is _the_ Guix channel regardless of where it came > from, and if users need to override the introduction they can just do > that. I don=E2=80=99t think we can do that: if someone who=E2=80=99s not currentl= y a committer wants to publish a fork, they=E2=80=99ll also publish a different introduct= ion, pointing to the first commit where they=E2=80=99re in =E2=80=98.guix-author= izations=E2=80=99. > Currently I do this to access the channel introduction, which seems > needlessly complicated: > > (use-modules (srfi srfi-1)) > (let ((guix-channel (find (lambda (channel) > (eq? 'guix (channel-name channel))) > %default-channels))) You can write: (find guix-channel? %default-channels). > (list [other channels omitted] > (channel > (inherit guix-channel) > (url "/home/marius/src/guix")))) I=E2=80=99m hesitant. We can publish =E2=80=98%guix-channel-introduction= =E2=80=99 if it helps, but it=E2=80=99s a slight maintenance constraint for a slight improvement. = :-) WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 25 11:05:35 2020 Received: (at 42030-done) by debbugs.gnu.org; 25 Jul 2020 15:05:35 +0000 Received: from localhost ([127.0.0.1]:50801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLjy-0003Fi-Ug for submit@debbugs.gnu.org; Sat, 25 Jul 2020 11:05:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLjx-0003FW-Bn for 42030-done@debbugs.gnu.org; Sat, 25 Jul 2020 11:05:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45306) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLjr-0000Ky-Oa; Sat, 25 Jul 2020 11:05:27 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:38510 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jzLjq-0002uz-FR; Sat, 25 Jul 2020 11:05:27 -0400 From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. In-Reply-To: <87h7utc3a7.fsf@gnu.org> References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> <87r1u3trx8.fsf@gnu.org> <87o8p2ayaj.fsf@gnu.org> <87h7utc3a7.fsf@gnu.org> Date: Sat, 25 Jul 2020 17:05:08 +0200 Message-ID: <87pn8jvdnf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42030-done Cc: 42030-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Marius Bakke skribis: > >> Ludovic Court=C3=A8s writes: >> >>>> I think we should export %guix-channel-introduction, or alternatively >>>> add a %default-guix-channel that can be inherited, for easy access in >>>> custom channels.scm files. WDYT? >>> >>> The idea was to expose only =E2=80=98%default-channels=E2=80=99, which = leaves room for >>> the possibility of having multiple channels by default. I=E2=80=99d ra= ther >>> avoid exposing the individual bits as that=E2=80=99s a bit of an additi= onal >>> committment. >>> >>> But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix c= hannel is >>> automatically added anyway (commit >>> c3f6f564e909ebefe752d24b325871a4e3a02d40). >> >> It is only added for people using the default channel URL, and not for >> local mirrors that may well be authenticated. E.g. (url "/some/dir") or >> (url "https://github.com/guix-mirror/guix"). >> >> Would it make sense to remove the %default-channel-url check from >> ensure-default-introductions? I think we can safely assume that a >> channel named 'guix is _the_ Guix channel regardless of where it came >> from, and if users need to override the introduction they can just do >> that. > > I don=E2=80=99t think we can do that: if someone who=E2=80=99s not curren= tly a committer > wants to publish a fork, they=E2=80=99ll also publish a different introdu= ction, > pointing to the first commit where they=E2=80=99re in =E2=80=98.guix-auth= orizations=E2=80=99. Right. >> Currently I do this to access the channel introduction, which seems >> needlessly complicated: >> >> (use-modules (srfi srfi-1)) >> (let ((guix-channel (find (lambda (channel) >> (eq? 'guix (channel-name channel))) >> %default-channels))) > > You can write: (find guix-channel? %default-channels). Ah, much better. >> (list [other channels omitted] >> (channel >> (inherit guix-channel) >> (url "/home/marius/src/guix")))) > > I=E2=80=99m hesitant. We can publish =E2=80=98%guix-channel-introduction= =E2=80=99 if it helps, > but it=E2=80=99s a slight maintenance constraint for a slight improvement= . :-) > WDYT? I'm happy with the 'find guix-channel?' trick for now. Let's see if other users report workflow issues before changing anything. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cSiQACgkQoqBt8qM6 VPpGeAf/eJCvs5Sln+YY2Jq16FBmLq2oRNtxC/vYrPUsK0rI/Gqxr1gDGoX0X8SX cBwr0oDuBYHSOIUbAdTGImCqhE0CBbjnxb5K1FNu0YUHBNylMboOiwK6a0YnHYZg PP7MCJ0TpLaz2X0fWn+Qw5G+k8EjT0ON9WxRBS2flREUx/tnHaR2IRRFVyGmwefJ IXTV/vI4wT1Ig6cEBbpslRjV4QfspPGZjkc/bRQW79uEGDcOaKIShl+JJ/NaTKnG LZU3uoOdMGYpUx7x3Oo4SngoF6LAz08AHUsUzC/KFOVZc1fUa7oqR5dfZbwUUDPX FIr+xvgDEKfDja9cHrHfREzVJ+ZP6Q== =RmKC -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 17 22:12:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Aug 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator