From unknown Fri Jun 20 07:10:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42029 <42029@debbugs.gnu.org> To: bug#42029 <42029@debbugs.gnu.org> Subject: Status: `gnus-registry-spool-action' gets field beyond message headers Reply-To: bug#42029 <42029@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:10:29 +0000 retitle 42029 `gnus-registry-spool-action' gets field beyond message headers reassign 42029 emacs,gnus submitter 42029 tomotaka.suwa@gmail.com severity 42029 normal tag 42029 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 24 07:51:09 2020 Received: (at submit) by debbugs.gnu.org; 24 Jun 2020 11:51:09 +0000 Received: from localhost ([127.0.0.1]:37901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jo3vo-0000Yo-LE for submit@debbugs.gnu.org; Wed, 24 Jun 2020 07:51:09 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:45249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jo3u1-0000VW-FJ for submit@debbugs.gnu.org; Wed, 24 Jun 2020 07:49:21 -0400 Received: by mail-pg1-f172.google.com with SMTP id l63so1289428pge.12 for ; Wed, 24 Jun 2020 04:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=n9TDiPPvsy22cscvP2J/BRqHHCM7IQu0vKouWwARP58=; b=mmLWs3fEFP8ZtkSFdn4bfjsD5CAUDPwjcJLJp1zBgoz+L5e4s4j4oBk7TLQQ7578sJ /YtaodgzeiX04g/OPVqfNV5hGUSW1fwSDQ0QKRCWbq6a6fswaYRdZb5BJvwHoPMTwjv2 Pd20ox9g1PQqgCVe7yoUOrCel9sI4p+byqcbsOIaVhMGxvQ03GpkNXa04E7XrSGDNyw0 v+MaXdmtAtqCX+nDMTkn/etZrmk7h8TKLPkfmaLCfFdz0WwmH3p8PPtvMRx0H2aljI5T YtpTxZulmf8SE/05wQkTHaVszvYdtQeG5av9iXQ++vbUux/+BsKkpTA1IZws63w9YrDx Avzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=n9TDiPPvsy22cscvP2J/BRqHHCM7IQu0vKouWwARP58=; b=SG+WQvKERigEUrcVYSyXfUpmtuc1xUAGFijuq+XtvO9wqm/4yUdMIaEVkSLNU8KQ// JbfRlvdrjGSzViLwoGnaypQOMn1bErQhuoqdcPyWZpjpqjl8bgVCpvicVlHv8zUPBhpu uuGQQIYF+AOYlbYoJQwxo7DZuVY/dhWt9qe5gP+WK3ZHCPfsMY2F/gK9O+VJq44Nz+ya H7hFKNAxuVroQzgCnkctspwsXwpIFzOOvriZXuHstySht4/jlSa6MD1i1Vo7hUtoO3kV XbYTuE7X9bWEVbkJ1eQIS5LmsfTUnAznxVjs2H+Di0X1LSYOPcRQVH7ilWpzk9FSgP0g ERwg== X-Gm-Message-State: AOAM531S7OOglg3ex5vFHUv2jVJGzsmOO+N02/ha9pnJTK0KiDnXPc4I PvfPf886/AmW0vw3iLElRdG4Rhoj X-Google-Smtp-Source: ABdhPJzgw+6goBr/zK3FuQZcBnO5Q9k0iRoO/vaf1Kd7G9TA5maXgfy7SiMqrjl3+NMLQm08SdNrwQ== X-Received: by 2002:a62:3645:: with SMTP id d66mr30233944pfa.275.1592999351012; Wed, 24 Jun 2020 04:49:11 -0700 (PDT) Received: from 17C30-A04 ([210.167.63.193]) by smtp.gmail.com with ESMTPSA id v7sm19211919pfn.147.2020.06.24.04.49.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jun 2020 04:49:10 -0700 (PDT) From: tomotaka.suwa@gmail.com To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: `gnus-registry-spool-action' gets field beyond message headers X-Debbugs-Version: 5.13 X-Debbugs-Package: emacs,gnus Date: Wed, 24 Jun 2020 20:49:03 +0900 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 24 Jun 2020 07:51:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, I've been suffering from `mail-source-crash-box' on getting new mail. After some debug and investigation, I noticed that `mail-extract-address-components' was failing by invalid addresses. The issue happened in `gnus-registry-spool-action' and invalid addresses are passed by calling `message-fetch-field' on the buffer not narrowed to message headers. Below snippet reproduce the root issue: (with-temp-buffer (save-excursion ;; mail header (insert "From: from@bar.com\n" "To: to@bar.com\n" "Subject: test\n") (newline) ;; mail body (insert "message\n" "Cc: >,@ \n")) ;; by incorrect decode (gnus-registry-spool-action 1 "test")) In stead of `message-fetch-field', calling `message-field-value' would solve the problem since it ensures the buffer is narrowed at first. diff -u "d:/msys64/mingw64/share/emacs/26.3/lisp/gnus/gnus-registry.el.orig" "d:/msys64/mingw64/share/emacs/26.3/lisp/gnus/gnus-registry.el" --- d:/msys64/mingw64/share/emacs/26.3/lisp/gnus/gnus-registry.el.orig 2020-06-24 11:10:49.458397900 +0900 +++ d:/msys64/mingw64/share/emacs/26.3/lisp/gnus/gnus-registry.el 2020-06-23 11:08:23.170050000 +0900 @@ -405,10 +405,10 @@ (let ((to (gnus-group-guess-full-name-from-command-method group)) (recipients (or recipients (gnus-registry-sort-addresses - (or (message-fetch-field "cc") "") - (or (message-fetch-field "to") "")))) - (subject (or subject (message-fetch-field "subject"))) - (sender (or sender (message-fetch-field "from")))) + (or (message-field-value "cc") "") + (or (message-field-value "to") "")))) + (subject (or subject (message-field-value "subject"))) + (sender (or sender (message-field-value "from")))) (when (and (stringp id) (string-match "\r$" id)) (setq id (substring id 0 -1))) (gnus-message 7 "Gnus registry: article %s spooled to %s" Diff finished. Wed Jun 24 11:13:17 2020 Gnus v5.13 GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2020-04-04 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 24 13:25:52 2020 Received: (at 42029) by debbugs.gnu.org; 24 Jun 2020 17:25:52 +0000 Received: from localhost ([127.0.0.1]:38816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jo99k-0000I9-EG for submit@debbugs.gnu.org; Wed, 24 Jun 2020 13:25:52 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:46282 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jo99h-0000Hv-3B for 42029@debbugs.gnu.org; Wed, 24 Jun 2020 13:25:51 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 96783FA0AC; Wed, 24 Jun 2020 17:25:42 +0000 (UTC) From: Eric Abrahamsen To: tomotaka.suwa@gmail.com Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers References: Date: Wed, 24 Jun 2020 10:25:41 -0700 In-Reply-To: (tomotaka suwa's message of "Wed, 24 Jun 2020 20:49:03 +0900") Message-ID: <87o8p8v0iy.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42029 Cc: 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tomotaka.suwa@gmail.com writes: > Hi, > > I've been suffering from `mail-source-crash-box' on getting new mail. > > After some debug and investigation, I noticed that > `mail-extract-address-components' was failing by invalid addresses. > > The issue happened in `gnus-registry-spool-action' and invalid addresses > are passed by calling `message-fetch-field' on the buffer not narrowed > to message headers. > > Below snippet reproduce the root issue: > > (with-temp-buffer > (save-excursion > ;; mail header > (insert "From: from@bar.com\n" > "To: to@bar.com\n" > "Subject: test\n") > (newline) > ;; mail body > (insert "message\n" > "Cc: >,@ \n")) ;; by incorrect decode > (gnus-registry-spool-action 1 "test")) > > In stead of `message-fetch-field', calling `message-field-value' would > solve the problem since it ensures the buffer is narrowed at first. Thanks for this report. It might be simpler to wrap the whole thing in a single save-restriction+narrow-to-headers, since the function gets called four times. What do you think? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 24 21:59:35 2020 Received: (at 42029) by debbugs.gnu.org; 25 Jun 2020 01:59:35 +0000 Received: from localhost ([127.0.0.1]:39529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joHAq-0006jn-OD for submit@debbugs.gnu.org; Wed, 24 Jun 2020 21:59:35 -0400 Received: from mail-il1-f178.google.com ([209.85.166.178]:44520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joG8S-0000qi-Jj for 42029@debbugs.gnu.org; Wed, 24 Jun 2020 20:53:00 -0400 Received: by mail-il1-f178.google.com with SMTP id b13so3789899ilq.11 for <42029@debbugs.gnu.org>; Wed, 24 Jun 2020 17:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OJma1nf4gNNyE/iGFXqdWAJJHRZTx7kCYgU/aQKcUtU=; b=LxdEKt2k53WATDpKF9F+IJIE3u07cPNAUmh9suWKPGGaOGYBjUVDpRY3L1HLRIjYI0 pdFtlqBscO8V/Vx2u/rpskZvkDwWikX4z17VlmuyQFIy3IAYwJn+SQEf1sXsguxzQEjj L6ifI8MwX+wfUcU6QuLDpd03Jo4nATW2mwaBA7BVRt7u94XTzKAXG8N2ubqCuoTkvX2r sh9gJpNWt9vm4YqYduehniZClRuFH3PQINlZePsiuAaf/7XuISRdMK1l7/C79XlvLilP jp4XidOorA5fC8ynlCu18YSq3XHwdKgeNjHNuF0SixHGxQPY3SlwzCqKQ472TY6up7At 1gKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OJma1nf4gNNyE/iGFXqdWAJJHRZTx7kCYgU/aQKcUtU=; b=tZS0bMkdu/ic5Aw6EIn04H2tJCqwGQgiGz2ADollhtw6KCaNbYBX2SeBxXSwntzzxP fu8jR9q9AHPS2HqsaLMYZ3W9zU2hPnBxo5XRajOCcjJJzq9Ewp7nkJLt1lz0m5/MK0LE tultNe01EEsRCtpTnaV7Q6nzEB2VkpQfKXfzy2Mktp1TD4kRejIu8kOZ38bRpryb775I 3TgALVwY7Bdtp0Km7aJclLoCA/IkiFy6x0iPWK15qJZn55K+shwQlsVyjtKZNy5QE26s 24b2O0LqsuBDj8paI88XEaj7tlPav5tqEf4u9G01CYDzBZyyeGqXU16vSZgDZJ9wpbu1 q4Ow== X-Gm-Message-State: AOAM530B2CUkoERtKHkHrJ5ZdoqiYeFs3MRpbmWGkppXKmGPf3DdG1am rzHtFs/3RhxCNwpuRbD95NqP1JDMA3a8ZitIlEZm+pTG X-Google-Smtp-Source: ABdhPJxa/jyiZ3zbLId4YOEGcNCRlGtl+CjK2RYOwKbCUIaTeL2Ac1gT3FTBwjYuOpRIGhy0ftTmSFiYF/jWFOaXnhc= X-Received: by 2002:a92:c784:: with SMTP id c4mr20683576ilk.23.1593046374839; Wed, 24 Jun 2020 17:52:54 -0700 (PDT) MIME-Version: 1.0 References: <87o8p8v0iy.fsf@ericabrahamsen.net> In-Reply-To: <87o8p8v0iy.fsf@ericabrahamsen.net> From: Tomotaka SUWA Date: Thu, 25 Jun 2020 09:52:43 +0900 Message-ID: Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers To: Eric Abrahamsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42029 X-Mailman-Approved-At: Wed, 24 Jun 2020 21:59:31 -0400 Cc: 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks for this report. It might be simpler to wrap the whole thing in a > single save-restriction+narrow-to-headers, since the function gets > called four times. What do you think? I wrote the patch paying attention to minimize side effects since I'm not familiar with that functionality. So if `gnus-registry-spool-action' is interested in only mail headers, your proposal is much better. -- Tomotaka SUWA From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 26 14:32:33 2020 Received: (at 42029) by debbugs.gnu.org; 26 Jun 2020 18:32:33 +0000 Received: from localhost ([127.0.0.1]:43029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jot9M-0002sg-Uf for submit@debbugs.gnu.org; Fri, 26 Jun 2020 14:32:33 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:45268 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jot9H-0002sG-03 for 42029@debbugs.gnu.org; Fri, 26 Jun 2020 14:32:31 -0400 Received: from localhost (75-172-112-137.tukw.qwest.net [75.172.112.137]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 0E13CFA0AD; Fri, 26 Jun 2020 18:32:20 +0000 (UTC) From: Eric Abrahamsen To: Tomotaka SUWA Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers References: <87o8p8v0iy.fsf@ericabrahamsen.net> Date: Fri, 26 Jun 2020 11:32:19 -0700 In-Reply-To: (Tomotaka SUWA's message of "Thu, 25 Jun 2020 09:52:43 +0900") Message-ID: <87mu4pu18s.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42029 Cc: 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Tomotaka SUWA writes: >> Thanks for this report. It might be simpler to wrap the whole thing in a >> single save-restriction+narrow-to-headers, since the function gets >> called four times. What do you think? > > I wrote the patch paying attention to minimize side effects since I'm not > familiar with that functionality. So if `gnus-registry-spool-action' is > interested in only mail headers, your proposal is much better. Okay! Would you be willing to give the attached diff a quick test? Thanks, Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=protect-registry-spool-action.diff diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index f306889a7f..a36095c1ec 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -449,19 +449,21 @@ gnus-registry-action to subject sender recipients))) (defun gnus-registry-spool-action (id group &optional subject sender recipients) - (let ((to (gnus-group-guess-full-name-from-command-method group)) - (recipients (or recipients - (gnus-registry-sort-addresses - (or (message-fetch-field "cc") "") - (or (message-fetch-field "to") "")))) - (subject (or subject (message-fetch-field "subject"))) - (sender (or sender (message-fetch-field "from")))) - (when (and (stringp id) (string-match "\r$" id)) - (setq id (substring id 0 -1))) - (gnus-message 7 "Gnus registry: article %s spooled to %s" - id - to) - (gnus-registry-handle-action id nil to subject sender recipients))) + (save-excursion + (message-narrow-to-headers-or-head) + (let ((to (gnus-group-guess-full-name-from-command-method group)) + (recipients (or recipients + (gnus-registry-sort-addresses + (or (message-fetch-field "cc") "") + (or (message-fetch-field "to") "")))) + (subject (or subject (message-fetch-field "subject"))) + (sender (or sender (message-fetch-field "from")))) + (when (and (stringp id) (string-match "\r$" id)) + (setq id (substring id 0 -1))) + (gnus-message 7 "Gnus registry: article %s spooled to %s" + id + to) + (gnus-registry-handle-action id nil to subject sender recipients)))) (defun gnus-registry-handle-action (id from to subject sender &optional recipients) @@ -1064,7 +1066,7 @@ gnus-registry-get-article-marks Uses process/prefix conventions. For multiple articles, only the last one's marks are returned." (interactive (gnus-summary-work-articles 1)) - (let* ((article (last articles)) + (let* ((article (car (last articles))) (id (gnus-registry-fetch-message-id-fast article)) (marks (when id (gnus-registry-get-id-key id 'mark)))) (when (called-interactively-p 'any) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 26 17:24:41 2020 Received: (at 42029) by debbugs.gnu.org; 26 Jun 2020 21:24:41 +0000 Received: from localhost ([127.0.0.1]:43212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jovpx-0006zS-G9 for submit@debbugs.gnu.org; Fri, 26 Jun 2020 17:24:41 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:42348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jovpv-0006zE-P6 for 42029@debbugs.gnu.org; Fri, 26 Jun 2020 17:24:41 -0400 Received: by mail-wr1-f49.google.com with SMTP id o11so10764235wrv.9 for <42029@debbugs.gnu.org>; Fri, 26 Jun 2020 14:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=v1RCuZFez73jNI9qyoIvyjhahRvou9KjedKnU4v8tKQ=; b=I3ApQgbE6d+AQnJI16e0dxe9kDmbO7KDnmIMrRlAAlVzJ6jafISYWZuP9PRPp0fhW+ 2zUY29m232Upo3rmQ9VSvyyWkeKQFReXQzVTtjScHxvW8tls65UN7a+VvtRaNUPD+nqZ ioFnGxUyS4HzJBHBR4eadejC6hmBZMm4pOQ5F0fgdCFTshRDkNFmuo27j8F7ixDRNjYp qMh0/t6FJtgnOrJKssJpCkR4jxpRFUdbWlPNZfYud/sFAtXupJEfXmWL8f0WGDFphrQm L71bSV8r5yqKe4FIi6LLOma28QnvFRSn/P7EjCZVKfwUXkKWIS8o4i07aaIP/HRKo+Fn rX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=v1RCuZFez73jNI9qyoIvyjhahRvou9KjedKnU4v8tKQ=; b=CL+Tl7aXBmKxAtXskexwHJNhlJQMBKm/8xdASYe0jXLR1T1x/bp8VxjDxOW+6JqJ5G 5nIMON+9zrv4OlJNPY4EpVdJea5PF5n5AHSWFiGMDs27Jp8AffBarkrG1i9m54x0Rwbz ZRcA3Iy09KKESVet7HL+SvupaUVz8cHCjrCAqJBteZAOftREQBAz4vaTK74e5dq8hBc7 Nq4+nmF7Zr2VCIm3auYwhONDrQFT60H1h4A0NF4ggWsJJh5n+eY6IenUhxZJUItJq3td YP6yiiDus4OeIbK5A28z7sIxhdOazW2AamVhiVPNS0N7qTruzH8943rTtzuMx181LnkB StKw== X-Gm-Message-State: AOAM533I231fJ6Gp+dcES0BDAbXXkIwL2n19TLuZyXZO2eQweXGVuYtw LhEwrGhvdifRvDmGRYX0hZxIdw== X-Google-Smtp-Source: ABdhPJwk/zwRzWjTdLm14hIpFFxyDCRfHB3EfXYorjiSZeD5F4qXRyRuyh6q20XRiPWBt+KTmYX/tw== X-Received: by 2002:adf:aad7:: with SMTP id i23mr5666935wrc.331.1593206673573; Fri, 26 Jun 2020 14:24:33 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id v20sm17702511wmh.26.2020.06.26.14.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 14:24:31 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers References: <87o8p8v0iy.fsf@ericabrahamsen.net> <87mu4pu18s.fsf@ericabrahamsen.net> Date: Fri, 26 Jun 2020 22:24:30 +0100 In-Reply-To: <87mu4pu18s.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 26 Jun 2020 11:32:19 -0700") Message-ID: <87a70pldv5.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42029 Cc: Tomotaka SUWA , 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > + (save-excursion > + (message-narrow-to-headers-or-head) Shouldn't this additionally or instead be wrapped in save-restriction? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 26 18:01:14 2020 Received: (at 42029) by debbugs.gnu.org; 26 Jun 2020 22:01:14 +0000 Received: from localhost ([127.0.0.1]:43238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jowPK-0007rH-5y for submit@debbugs.gnu.org; Fri, 26 Jun 2020 18:01:14 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:38438 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jowPG-0007r0-Rq for 42029@debbugs.gnu.org; Fri, 26 Jun 2020 18:01:12 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 03CE6FA0AD; Fri, 26 Jun 2020 22:01:03 +0000 (UTC) From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers References: <87o8p8v0iy.fsf@ericabrahamsen.net> <87mu4pu18s.fsf@ericabrahamsen.net> <87a70pldv5.fsf@tcd.ie> Date: Fri, 26 Jun 2020 15:01:02 -0700 In-Reply-To: <87a70pldv5.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Jun 2020 22:24:30 +0100") Message-ID: <875zbdfpwh.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42029 Cc: Tomotaka SUWA , 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 06/26/20 22:24 PM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> + (save-excursion >> + (message-narrow-to-headers-or-head) > > Shouldn't this additionally or instead be wrapped in save-restriction? Bleagh, you're right, sorry about that. It was supposed to be `save-restriction'. Thanks! Eric From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 28 22:27:08 2020 Received: (at 42029) by debbugs.gnu.org; 29 Jun 2020 02:27:08 +0000 Received: from localhost ([127.0.0.1]:47300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpjVj-0002IL-UA for submit@debbugs.gnu.org; Sun, 28 Jun 2020 22:27:08 -0400 Received: from mail-il1-f174.google.com ([209.85.166.174]:33048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpjVf-0002Ho-5W for 42029@debbugs.gnu.org; Sun, 28 Jun 2020 22:27:06 -0400 Received: by mail-il1-f174.google.com with SMTP id a11so4884874ilk.0 for <42029@debbugs.gnu.org>; Sun, 28 Jun 2020 19:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zZJzt/5AKTMzzd8vU14hfSr6EfinRpOF1WPBAWwQ9r4=; b=ee1Y5+CWQQeKl7AgQfP8R18lg3n2Vje9NyCFgHEkbyShh8Kzd6Qa5l0FLDgkax/DwD J69aNQ8RFUlD3o1iUvkbscRyFdEmNmTjbT3B6yXI13QNkJr68rZr99Zq6lZUEmx7VBuW yFRPrxpRjg7oRaG6sskpRaUJfdbm9l6Erc1Fz4aL+Oy32FgYcqs1H7NwUwqVLgQyqXnc 7qM2vNqwjVGlcN1v2FKk3c2jCkXWAU9DwH0Fwt2prTF2EsYd41vZkvYkuQTG1kJ/2bRn 5Kkczm5ewCvEPqgse9mluK1HWMv0iV05hQXsO4GTFFH5yEsGZUlmHbDgFdmjomnM21qD C36w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zZJzt/5AKTMzzd8vU14hfSr6EfinRpOF1WPBAWwQ9r4=; b=q/9X6xWr5SfNFbNav+9fsjSqksDDVNn6cTFFI8NzJwjz+sWCVh/EgYn2Ad6C3xZ0pk zsfH7sLMYoyUWvL6JLq3R7k98Xcgy6chRm3reGroMzYoHUnjvzwXJNt6YTme9u3dZgDZ GQ62dIrEe9BhroiUtRRHIxZ8VHnkCMMsKri/tUBBqdynehrU0/AbQDola7bLSKjTM9h1 LOIIUVr+sYuFwu1SH+I3h7EwyE4SyZOjOt8319wp0REqVV4XZTdcLY70vc9C+LrXknAt RHcoLVP89gzx5+g1UK7vKuAmV+P2757df9Y3ThvjqTTGTcsJgtNGNuqKsZ8B5K5Zx3LI p4lw== X-Gm-Message-State: AOAM5310HbQVQyuWduHvk7Z8CtZEJQKITzPlfjJQxaTspl6B4556VX6a ysP67OJevvms67n0da58j+atzr7IcEHtgnj+c9ZfkctY X-Google-Smtp-Source: ABdhPJzOBHwKnNmsEB5kXoSGgm5FddNByOSzEf7tLsEuAAsNNGAM6Guk4Dma9VNbzyTKM9bqRzUQoQbbrAoF32Xhqic= X-Received: by 2002:a05:6e02:6cf:: with SMTP id p15mr14148053ils.206.1593397617450; Sun, 28 Jun 2020 19:26:57 -0700 (PDT) MIME-Version: 1.0 References: <87o8p8v0iy.fsf@ericabrahamsen.net> <87mu4pu18s.fsf@ericabrahamsen.net> In-Reply-To: <87mu4pu18s.fsf@ericabrahamsen.net> From: Tomotaka SUWA Date: Mon, 29 Jun 2020 11:26:46 +0900 Message-ID: Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers To: Eric Abrahamsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42029 Cc: 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Okay! Would you be willing to give the attached diff a quick test? Sure. I gave a test with the `save-restriction' version and it worked well. By the way, does the change of `gnus-registry-get-article-marks' have any relation to this issue? Thanks, -- Tomotaka SUWA From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 20:20:34 2020 Received: (at 42029) by debbugs.gnu.org; 19 Jul 2020 00:20:34 +0000 Received: from localhost ([127.0.0.1]:59480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwx4D-0003Qn-Vq for submit@debbugs.gnu.org; Sat, 18 Jul 2020 20:20:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwx4C-0003QY-Lp for 42029@debbugs.gnu.org; Sat, 18 Jul 2020 20:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/LIzJPggudheG5RSvPPdANRTe6sPyPZVQNt+J6vtyUk=; b=n3Ye7Zb7WW+TdwXRt9zyRG1eLc eqjFCRZkhCeiLzClisfvV00fTNMiBp9R7fi2yaEJWE4Bi4+Xocwi3DWyDcUkKoMbp1/i0KvZVq6vI OvdAdAkVke3F0l1q6QDsZIw//kI+pILuOWgR3egg13J2MazINCxpR3zsbBGpRew6XBJU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwx43-0006xT-Su; Sun, 19 Jul 2020 02:20:26 +0200 From: Lars Ingebrigtsen To: Tomotaka SUWA Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers References: <87o8p8v0iy.fsf@ericabrahamsen.net> <87mu4pu18s.fsf@ericabrahamsen.net> Date: Sun, 19 Jul 2020 02:20:22 +0200 In-Reply-To: (Tomotaka SUWA's message of "Mon, 29 Jun 2020 11:26:46 +0900") Message-ID: <87y2ngice1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tomotaka SUWA writes: >> Okay! Would you be willing to give the attached diff a quick test? > > Sure. I gave a test with the `save-restriction' version and it > worked well. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42029 Cc: Eric Abrahamsen , 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tomotaka SUWA writes: >> Okay! Would you be willing to give the attached diff a quick test? > > Sure. I gave a test with the `save-restriction' version and it > worked well. Thanks for testing; I've now applied Eric's patch (with the additional fix from Basil) to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 20:20:40 2020 Received: (at control) by debbugs.gnu.org; 19 Jul 2020 00:20:40 +0000 Received: from localhost ([127.0.0.1]:59483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwx4K-0003R5-6Q for submit@debbugs.gnu.org; Sat, 18 Jul 2020 20:20:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwx4I-0003Ql-NC for control@debbugs.gnu.org; Sat, 18 Jul 2020 20:20:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a38XVMJWdUc2ji+8q+2b3gduYkLxlONuCc1eABskbuo=; b=NdfRd4YfhhZiN/jEKbN4T19vfd 1JXnmM4h2JTXPipDCfwWao3lkxCmXuTz6tltQZ0+rWwlvN7+oRIEe3Xp6FYJKbH0RZQoeRdvEGcmC 9fEZF4ZSPdgC/rph2beViL36QbzsmXa45Q7VMEPSPW1C4/lDJA46mYGNAGkX+uOhewIE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwx4A-0006xa-V2 for control@debbugs.gnu.org; Sun, 19 Jul 2020 02:20:33 +0200 Date: Sun, 19 Jul 2020 02:20:29 +0200 Message-Id: <87wo30icdu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #42029 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 42029 fixed close 42029 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 42029 fixed close 42029 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 23:05:46 2020 Received: (at 42029) by debbugs.gnu.org; 19 Jul 2020 03:05:46 +0000 Received: from localhost ([127.0.0.1]:59794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwze6-0003dK-15 for submit@debbugs.gnu.org; Sat, 18 Jul 2020 23:05:46 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:36470 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwze2-0003d5-Th for 42029@debbugs.gnu.org; Sat, 18 Jul 2020 23:05:44 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 99A23FA0B2; Sun, 19 Jul 2020 03:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1595127936; bh=yDvVt3X5Tid3+613iL3SGG3vWl0c9WeEZ1dAUsnsIKU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SKSBisf0TXFmpXYaXvAkP+qBcwD8+iouTneqWz8hCMBaCBMN8zkcXcNkAj5ePolRg r2nszleZHnm8CQouNiwHzMMyloeunfAmVbgTdY0UZyO/ne0uge7ArfL9XyWz/hS92U 31qBfZ8GXJxwhOBB6aTE56cwkF3z3OYqrBY1ETW8= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#42029: `gnus-registry-spool-action' gets field beyond message headers References: <87o8p8v0iy.fsf@ericabrahamsen.net> <87mu4pu18s.fsf@ericabrahamsen.net> <87y2ngice1.fsf@gnus.org> Date: Sat, 18 Jul 2020 20:05:35 -0700 In-Reply-To: <87y2ngice1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 19 Jul 2020 02:20:22 +0200") Message-ID: <87eep8cigw.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42029 Cc: Tomotaka SUWA , 42029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 07/19/20 02:20 AM, Lars Ingebrigtsen wrote: > Tomotaka SUWA writes: > >>> Okay! Would you be willing to give the attached diff a quick test? >> >> Sure. I gave a test with the `save-restriction' version and it >> worked well. > > Thanks for testing; I've now applied Eric's patch (with the additional > fix from Basil) to Emacs 28. Thanks! I've had almost no time for coding recently... From unknown Fri Jun 20 07:10:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Aug 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator