Subject: bug#42024: closed (Re: [bug#42024] [PATCH] nix: Tweak .gitignore files.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 24 Jun 2020 19:01:01 +0000

Your bug report

#42024: [PATCH] nix: Tweak .gitignore files.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
42024: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42024
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#42024] [PATCH] nix: Tweak .gitignore files.
From: Christopher Baines <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Wed, 24 Jun 2020 20:00:18 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Christopher Baines <[email-masked]> skribis:
>
>> Remove .gitignore entries where they match source files that are tracked in
>> Git.  This is relevant to me at least, as some code searching tools use
>> .gitignore files and will ignore matched files.
>>
>> * nix/boost/.gitignore: Delete this file.
>> * nix/libutils/.gitignore: Delete this file.
>> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
>> (/schema.sql.hh): New entry.
>
> LGTM!  I don’t know what the rationale was.
>
> BTW, no need to bother with ChangeLog entries for this.

Great, I've removed the ChangeLog entries and pushed this as
cd43b55da7ab51c996a7a3449c78f2a493616106.

Thanks,

Chris

Subject: [PATCH] nix: Tweak .gitignore files.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Date: Tue, 23 Jun 2020 18:27:17 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Remove .gitignore entries where they match source files that are tracked in
Git.  This is relevant to me at least, as some code searching tools use
.gitignore files and will ignore matched files.

* nix/boost/.gitignore: Delete this file.
* nix/libutils/.gitignore: Delete this file.
* nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
(/schema.sql.hh): New entry.
---
 nix/boost/.gitignore    | 3 ---
 nix/libstore/.gitignore | 3 +--
 nix/libutil/.gitignore  | 2 --
 3 files changed, 1 insertion(+), 7 deletions(-)
 delete mode 100644 nix/boost/.gitignore
 delete mode 100644 nix/libutil/.gitignore

diff --git a/nix/boost/.gitignore b/nix/boost/.gitignore
deleted file mode 100644
index 1f188e3b65..0000000000
--- a/nix/boost/.gitignore
+++ /dev/null
@@ -1,3 +0,0 @@
-*.hpp
-*.cpp
-*.cc
diff --git a/nix/libstore/.gitignore b/nix/libstore/.gitignore
index 512a0d022f..805301d6d7 100644
--- a/nix/libstore/.gitignore
+++ b/nix/libstore/.gitignore
@@ -1,3 +1,2 @@
-*.cc
-*.hh
 /schema.sql
+/schema.sql.hh
diff --git a/nix/libutil/.gitignore b/nix/libutil/.gitignore
deleted file mode 100644
index e539428b1b..0000000000
--- a/nix/libutil/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@
-*.cc
-*.hh
-- 
2.26.2