From unknown Sun Jun 22 03:56:00 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4201: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem) Reply-To: Matthieu Moy , 4201@debbugs.gnu.org Resent-From: Matthieu Moy Original-Sender: Matthieu Moy Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 20 Aug 2009 20:34:49 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4201 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125068927612359 (code B ref -1); Thu, 20 Aug 2009 20:34:49 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 19 Aug 2009 13:41:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.6 required=4.0 tests=AWL,IMPRONONCABLE_2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7JDfF6v012356 for ; Wed, 19 Aug 2009 06:41:16 -0700 Received: from mx10.gnu.org ([199.232.76.166]:35638) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MdlPe-0000Gc-MS for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:14 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MdlPc-0000em-C4 for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:14 -0400 Received: from mx2.imag.fr ([129.88.30.17]:50505 helo=rominette.imag.fr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MdlPa-0000dr-IB for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:11 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id n7JDdYhr006476 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 19 Aug 2009 15:39:34 +0200 Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1MdlPR-0003vt-7D; Wed, 19 Aug 2009 15:41:01 +0200 Received: from moy by bauges.imag.fr with local (Exim 4.63) (envelope-from ) id 1MdlPR-00072W-5n; Wed, 19 Aug 2009 15:41:01 +0200 To: emacs-pretest-bug@gnu.org References: From: Matthieu Moy Date: Wed, 19 Aug 2009 15:41:01 +0200 In-Reply-To: (Matthieu Moy's message of "Wed\, 19 Aug 2009 14\:21\:05 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Matthieu Moy X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Wed, 19 Aug 2009 15:39:34 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: n7JDdYhr006476 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr MailScanner-NULL-Check: 1251293976.91015@qUS2RIomKKohcMPpbcrb5Q X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Matthieu Moy writes: > Fine, I thought, my dbus is too old, I don't need it, I'll disable it. > But compiling with --without-dbus, it doesn't work either: > > Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc > Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el > Loading tramp... > > In toplevel form: > ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus > make[2]: *** [...] Error 1 This happens since this revision below (thanks to 'git bisect' ;-) ). Reverting it fixes the problem for me. I guess the important part was the (when (and (featurep 'dbusbind) (not (featurep 'dbus))) which got lost in the process. commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2 Author: Michael Albinus Date: Wed Aug 19 07:08:57 2009 +0000 * net/dbus.el (top): Apply `dbus-init-bus' for the :session bus only if it is running already. diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el index c1222a6..159fcb6 100644 --- a/lisp/net/dbus.el +++ b/lisp/net/dbus.el @@ -41,15 +41,6 @@ (defvar dbus-debug) (defvar dbus-registered-functions-table) -;; Initialize :system and :session buses. This adds their file -;; descriptors to input_wait_mask, in order to detect incoming -;; messages immediately. -;; We must avoid to call the function twice for a bus, because the -;; DBusWatch will be removed then. -(when (and (featurep 'dbusbind) (not (featurep 'dbus))) - (dbus-init-bus :system) - (dbus-init-bus :session)) - ;; Pacify byte compiler. (eval-when-compile (require 'cl)) @@ -841,6 +832,14 @@ name of the property, and its value. If there are no properties, (cons property (dbus-get-property bus service path interface property)) 'append))))) +;; Initialize :system and :session buses. This adds their file +;; descriptors to input_wait_mask, in order to detect incoming +;; messages immediately. +(dbus-ignore-errors + (dbus-init-bus :system) + (when (getenv "DBUS_SESSION_BUS_ADDRESS") + (dbus-init-bus :session))) + (provide 'dbus) ;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd -- Matthieu From rgm@gnu.org Thu Aug 20 18:09:19 2009 Received: (at control) by emacsbugs.donarmstrong.com; 21 Aug 2009 01:09:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,ONEWORD,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L19H7w000999 for ; Thu, 20 Aug 2009 18:09:19 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MeId3-0004Zc-5w; Thu, 20 Aug 2009 21:09:17 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19085.62397.105518.639079@fencepost.gnu.org> Date: Thu, 20 Aug 2009 21:09:17 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes merge 4185 4202 merge 4186 4201 severity 4192 wishlist reassign 4192 emacs,cc-mode reassign 4143 emacs,ns reassign 4146 emacs,cc-mode severity 4164 minor reassign 4180 emacs,ns reassign 4187 emacs,cc-mode forcemerge 2868 4194