From unknown Sat Aug 09 15:55:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41977 <41977@debbugs.gnu.org> To: bug#41977 <41977@debbugs.gnu.org> Subject: Status: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Reply-To: bug#41977 <41977@debbugs.gnu.org> Date: Sat, 09 Aug 2025 22:55:49 +0000 retitle 41977 28.0.50; [PATCH]: eval-when-compile eshell in project.el reassign 41977 emacs submitter 41977 Theodor Thornhill severity 41977 normal tag 41977 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 07:33:29 2020 Received: (at submit) by debbugs.gnu.org; 21 Jun 2020 11:33:29 +0000 Received: from localhost ([127.0.0.1]:59297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmyE5-0007AA-72 for submit@debbugs.gnu.org; Sun, 21 Jun 2020 07:33:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:59136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmyE2-0007A2-Rd for submit@debbugs.gnu.org; Sun, 21 Jun 2020 07:33:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmyE2-0002aN-Ki for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 07:33:26 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:55546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmyDz-0001Wo-6V for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 07:33:25 -0400 Date: Sun, 21 Jun 2020 11:33:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592739197; bh=zx+5vTrDgdF6wOVTw1coqwAkCfhIIaQ4cjwgOcD49UE=; h=Date:To:From:Reply-To:Subject:From; b=URxXdyb3VA+f6CeeKDuPm0F+WoyTvEQraJbvNDrxBYUXNUTZuQC8+wTQMhvSQCEsv 1kMIO7TtB0crH7MNxkOQeK5hIUsZM/o2KKUwt1HmaHdEZVkkt+bM/0BSlrk+1Bvhm3 v/SbBM1TOmhGsmzVlFGsX0Vx5jcjwLzgk774fKvX+UkOOY/crbk6IMK0l7QmEcb9K/ eeOTK9FG/l3oNHXipb4bdo7TKvZi5Jrn5/tLIT3561DqVSxwJgGvl56CAydDnhWjwS whDw4AblGua1yr2O1k3xp3hREkzqq8g5Aw/cSJA6UJptS2E/fehxyVdULLhsIIdTio nA9VnYGd7pA0A== To: bug-gnu-emacs@gnu.org From: Theodor Thornhill Subject: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Message-ID: <87sgeo7ixe.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_KV3PTXV00gPdQOGA2htMAghTkkTh6LTZfG34d8X4i50" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.131; envelope-from=theo@thornhill.no; helo=mail-40131.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/21 07:33:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_KV3PTXV00gPdQOGA2htMAghTkkTh6LTZfG34d8X4i50 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! I saw a little too late that the latest patch to 'project-eshell' didn't apply correctly when compiling emacs. As such you would get old behavior until you eval 'project-eshell'. A quick fix as far as I can tell is the below patch. Theo --b1_KV3PTXV00gPdQOGA2htMAghTkkTh6LTZfG34d8X4i50 Content-Type: text/x-patch; name=0001-project.el-eval-when-compile-eshell.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-project.el-eval-when-compile-eshell.patch RnJvbSA0YjNmODNhNGVhMzYyNTJmN2Y3NTUyYjU4NTI5Njg4ZjZiNGMzYzlmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGVvZG9yIFRob3JuaGlsbCA8dGhlb0B0aG9ybmhpbGwubm8+ CkRhdGU6IFN1biwgMjEgSnVuIDIwMjAgMTM6MDk6NDIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9qZWN0LmVsIC0gZXZhbC13aGVuLWNvbXBpbGUgZXNoZWxsCgoqIGxpc3AvcHJvZ21vZGVzL3By b2plY3QuZWw6IGV2YWwtd2hlbi1jb21waWxlIEVzaGVsbCBzbyB3ZSBjYW4gdXNlCidlc2hlbGwt YnVmZmVyLW5hbWUnIGluICdwcm9qZWN0LWVzaGVsbCcKLS0tCiBsaXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsIHwgNCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbCBiL2xpc3AvcHJv Z21vZGVzL3Byb2plY3QuZWwKaW5kZXggNzQ0OTVjZjA3YS4uYjc3MzE3Yjk4ZCAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0 LmVsCkBAIC05MSw3ICs5MSw5IEBACiA7OzsgQ29kZToKIAogKHJlcXVpcmUgJ2NsLWdlbmVyaWMp Ci0oZXZhbC13aGVuLWNvbXBpbGUgKHJlcXVpcmUgJ3N1YnIteCkpCisoZXZhbC13aGVuLWNvbXBp bGUKKyAgKHJlcXVpcmUgJ3N1YnIteCkKKyAgKHJlcXVpcmUgJ2VzaGVsbCkpCiAKIChkZWZncm91 cCBwcm9qZWN0IG5pbAogICAiT3BlcmF0aW9ucyBvbiB0aGUgY3VycmVudCBwcm9qZWN0LiIKLS0g CjIuMjcuMAoK --b1_KV3PTXV00gPdQOGA2htMAghTkkTh6LTZfG34d8X4i50-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 08:25:42 2020 Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 12:25:42 +0000 Received: from localhost ([127.0.0.1]:59332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmz2c-0008V4-Hh for submit@debbugs.gnu.org; Sun, 21 Jun 2020 08:25:42 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:45365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmz2a-0008Un-4U for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 08:25:41 -0400 Received: by mail-qk1-f172.google.com with SMTP id q8so13162126qkm.12 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mFtcZIOB1j8o25ZD1ECcpbdqFhvQ3oo0xE/pEYTNb1E=; b=SUeS+Bo43hUUf2eFYzeaFDfkEF7dZ+9qTTz4wuuD7dhwhnz28WqLrqgM3J+sNl1B7b 7Nyiv9d5Oz5L45jSlPJjqSx9hb/vLYnunLMs4ZlCnWnOWqAM29uW0IljzD0kVJcWlmFP FCJ8oXoeFrBd7jYFW5i75lfMK0gJj8fz65iUVkZvMgw1urs3J005ay0puf9RmBJqVOGI BdYYANik1uzwRvhxJF1ZClX1y5r6IVe8CnnrS7DsfYGN2YjQdaHV1sGzdLwNv8gw7xTd BMLHvUag6y5HSU/ZabpXria9/MXBL3E/6xcrQHQ1GuQss5mLrhf9Y6d3vi2UihE4oEEo EgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mFtcZIOB1j8o25ZD1ECcpbdqFhvQ3oo0xE/pEYTNb1E=; b=oIivchsfMZtutUmAflRoCnhzy0fYHe6Oo1xNjzGPJ38vKcuCs9Yem6MYwtk4rVKv56 6AJXHmc6OGXW01t6gbkz0c+EhfZtOQGrddIf1HGc5ph3JRcF0nrZ+8AaDf1oy359qZG0 etbROxPNYLN5puIIjzHVL4zUw7KNWTIWD2rPzv6NZFUYY8B8GxjH0r7Wwvw84w/oWKls Ss8pmiTQFtHtFKB/9yQnQez2qqrPwJlFMW/KSz51IRZ+MqAMiJ4NbmSUwHqKs2OOOD4G XZkSGn3cT/51RB3L2Dmpt5agcBJLXvNtqVP6o6YiI+Vc6tIVxGefrA8z6okNKDXzPF2Q u1Jw== X-Gm-Message-State: AOAM530DjXEWS/a2zOAg4sV3Q+XaxwHThYJDNDt5L+MuCznSBakCIxqH 1bstxB9F5jZpgRZ7gs3XHH8YmbvOYug= X-Google-Smtp-Source: ABdhPJzLMM17aAoaO4pwXJQJ0LJWov58I3taOvUQm17AbhhC8Ri0Rr0xycISMRUYLTtLtFIsCarbQA== X-Received: by 2002:a37:f505:: with SMTP id l5mr11260258qkk.118.1592742334420; Sun, 21 Jun 2020 05:25:34 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id 59sm10517573qtf.41.2020.06.21.05.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 05:25:33 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el References: <87sgeo7ixe.fsf@thornhill.no> Date: Sun, 21 Jun 2020 13:25:31 +0100 In-Reply-To: <87sgeo7ixe.fsf@thornhill.no> (Theodor Thornhill's message of "Sun, 21 Jun 2020 11:33:06 +0000") Message-ID: <87h7v4ip1g.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41977 Cc: 41977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > From 4b3f83a4ea36252f7f7552b58529688f6b4c3c9f Mon Sep 17 00:00:00 2001 > From: Theodor Thornhill > Date: Sun, 21 Jun 2020 13:09:42 +0200 > Subject: [PATCH] project.el - eval-when-compile eshell > > * lisp/progmodes/project.el: eval-when-compile Eshell so we can use > 'eshell-buffer-name' in 'project-eshell' Since eshell-buffer-name is a variable, eval-when-compile is not the right thing to do here. Instead, there should be a (defvar eshell-buffer-name) inside project-eshell declaring the symbol as special. Right? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 13:44:36 2020 Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 17:44:36 +0000 Received: from localhost ([127.0.0.1]:60873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn41D-0002Rp-QT for submit@debbugs.gnu.org; Sun, 21 Jun 2020 13:44:36 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:41963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn41B-0002RW-Np for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 13:44:35 -0400 Date: Sun, 21 Jun 2020 17:44:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592761467; bh=V6qDdl4BBtgkXXt7gjw/K01UJWBSjtRmh0zbmd5tRGo=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=vmLDKyfyTsdXbSZbkBLRtnV9n0SyKoD1LoPd5mInZmpRrw+yikLhXl58jl2YI7BOT SUN6yU4SKBvViTJNrsjpi2+ww7JlvtRT59Jf8rNb3RtSC9sIPka79OBTfmt0rut5ND rQ75Wj1QfIuytvWAaYSBMC/vPEEt1fXTYmKa35X6ZMPsb+tnkM8Vajmprx8468AODd c5MJ4LuWyUie/4ZJiEDFGOibrONwXnCD1x1+9KOYppeamOu9V+q4oQx9P5ZEM1lpl9 H1mCz1D8qGIgvd77JmNZr04bSlTaIw0nnD2W65/cvJuAGpZ2xBJcJlyEw7Hd2LARGC TUra1SqpTZymQ== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Message-ID: <87lfkg48lr.fsf@thornhill.no> In-Reply-To: <87h7v4ip1g.fsf@tcd.ie> References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41977 Cc: 41977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Basil L. Contovounesios" writes: > Since eshell-buffer-name is a variable, eval-when-compile is not the > right thing to do here. Instead, there should be a > (defvar eshell-buffer-name) inside project-eshell declaring the symbol > as special. Right? You are absolutely correct, and TIL - thanks :) Below is another patch doing this. Works fine in emacs -Q Theo --b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ Content-Type: text/x-patch; name=0001-Forward-declare-eshell-buffer-name-in-project-eshell.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Forward-declare-eshell-buffer-name-in-project-eshell.patch RnJvbSAyYzE2YWI4N2UzNjlhYjMxNWQ0M2Q1ZTFkNjk2NWYxMjc4YzJjMjQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGVvZG9yIFRob3JuaGlsbCA8dGhlb0B0aG9ybmhpbGwubm8+ CkRhdGU6IFN1biwgMjEgSnVuIDIwMjAgMTk6MTU6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG b3J3YXJkIGRlY2xhcmUgZXNoZWxsLWJ1ZmZlci1uYW1lIGluIHByb2plY3QtZXNoZWxsCgoqIGxp c3AvcHJvZ21vZGVzL3Byb2plY3QuZWw6IEZvcndhcmQgZGVjbGFyZXMgJ2VzaGVsbC1idWZmZXIt bmFtZScgc28KdGhhdCAncHJvamVjdC1lc2hlbGwnIGNhbiB1c2UgdGhlIHNwZWNpYWwgdmFyaWFi bGUgaW4gZXNoZWxsLgotLS0KIGxpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgfCAxICsKIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3By b2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0LmVsCmluZGV4IDc0NDk1Y2YwN2EuLjcx NWYwNDgwYmIgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlz cC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAtNzQwLDYgKzc0MCw3IEBAIHByb2plY3QtZXNoZWxs CiBXaXRoIFxcW3VuaXZlcnNhbC1hcmd1bWVudF0gcHJlZml4LCBjcmVhdGUgYSBuZXcgRXNoZWxs IGJ1ZmZlcgogd2l0aCB1bmlxdWlmaWVkIG5hbWUuIgogICAoaW50ZXJhY3RpdmUpCisgIChkZWZ2 YXIgZXNoZWxsLWJ1ZmZlci1uYW1lKQogICAobGV0KiAoKGRlZmF1bHQtZGlyZWN0b3J5IChwcm9q ZWN0LXJvb3QgKHByb2plY3QtY3VycmVudCB0KSkpCiAgICAgICAgICAoZXNoZWxsLWJ1ZmZlci1u YW1lCiAgICAgICAgICAgIChjb25jYXQgIioiIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5Ci0tIAoy LjI3LjAKCg== --b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 13:55:45 2020 Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 17:55:45 +0000 Received: from localhost ([127.0.0.1]:60877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn4C0-0002jk-SV for submit@debbugs.gnu.org; Sun, 21 Jun 2020 13:55:45 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:36981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn4By-0002jU-6X for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 13:55:43 -0400 Received: by mail-wm1-f44.google.com with SMTP id y20so13636364wmi.2 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 10:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IzL1FojvVaTry0LpTScQBaIUf8PV+Of0nxMe09n4SFU=; b=0KrWMDsDTnI1t+O2/5dpZt/hppeeQZ+k28Jr42k0KmT57olAzf6B/xDD81uusgC8so mUmratte3vG8UDV4aIGrOMt7ZbAlqEfbpGfqjiUF6Ka4KDIrQJ/RrFGW08JgDkc3LOeL GGpC73PrS/FvgfYbyHm9AXMYfs6U/OL/K2BRhCQ783i2tc3tPLx8Wvuz0jfU/GMKKg4X BgulLx9yVYNMJOcRTJGF2+8Vpt9bA7ZEgztTRn+F7TkcE0RA81W2y4md6c+0vp1GvcRo YoEU4K0Jdy9N5jn3uakbbpk0LsvuEKFY/ISz8tP+cJCX5/5z9L7WPw5kTbXF6G2pIqte LHtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IzL1FojvVaTry0LpTScQBaIUf8PV+Of0nxMe09n4SFU=; b=XEAC4a7K8ak/pWQQ8Qn8YX0Ye2cXs9D8/8GhLNdnIHfkjwV2iXji0uvUzJt4ceuUnA cOv8DxUuq0swd7LIgTv7/U7gqkmiD+6Hbh4SXKsGZSWpXtJqTKnpQHvuZnuwBJy6f53R v0lFW6KmMSmm4bL0VedbpBWdecqXlxJZXkQDLWVrqb49udRhi7pxpgye98j8SUup2ilb IYcxSN6wNtLTb3ScY/QdFkdmjl3ZKhhRU937GuOen5SSWrxspWR+z6rZUIItzm6CAJpA 2vsAJJwK0UTcJotVAOGEK8fXY2FHgVczKEJI4Nl5w9yHNmIaaxL20F0gygpMszdFyhSw 1ZAA== X-Gm-Message-State: AOAM532W2xrZMpW0DSVO1kQwpVc8ELkz34LXZpEvaHxw18EkUboGh7SF 2V/j5w7l+MjQ7ldJVL/D7G3yJA== X-Google-Smtp-Source: ABdhPJy3zgsMa/0RYcgY2ZowZVYmY09PNv4HFrOkI94BIKvrdwS7W1IvjJuEX5KAeSbuLEv8z4Sf+Q== X-Received: by 2002:a7b:ce14:: with SMTP id m20mr5821421wmc.129.1592762136245; Sun, 21 Jun 2020 10:55:36 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id b19sm20740238wmj.0.2020.06.21.10.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 10:55:35 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> <87lfkg48lr.fsf@thornhill.no> Date: Sun, 21 Jun 2020 18:55:34 +0100 In-Reply-To: <87lfkg48lr.fsf@thornhill.no> (Theodor Thornhill's message of "Sun, 21 Jun 2020 17:44:24 +0000") Message-ID: <87y2og8fs9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41977 Cc: 41977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > "Basil L. Contovounesios" writes: > >> Since eshell-buffer-name is a variable, eval-when-compile is not the >> right thing to do here. Instead, there should be a >> (defvar eshell-buffer-name) inside project-eshell declaring the symbol >> as special. Right? > > You are absolutely correct, and TIL - thanks :) > > Below is another patch doing this. Works fine in emacs -Q Thanks, LGTM. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 18:52:27 2020 Received: (at 41977-done) by debbugs.gnu.org; 21 Jun 2020 22:52:27 +0000 Received: from localhost ([127.0.0.1]:32797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn8p8-0005lo-UE for submit@debbugs.gnu.org; Sun, 21 Jun 2020 18:52:27 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:53982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn8p5-0005la-Oh for 41977-done@debbugs.gnu.org; Sun, 21 Jun 2020 18:52:25 -0400 Received: by mail-wm1-f53.google.com with SMTP id l26so13178855wme.3 for <41977-done@debbugs.gnu.org>; Sun, 21 Jun 2020 15:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fjJ7ohl/WNHBrbbH+wbp9lubgjVrSjUWiauTpCnG4EU=; b=cIdibHW+6VJ1cmCnVJrMwQ+hQQiVJx4T63YwLyejsmuTIzgbP8bgEqPQkgP69KY24k ar8dVQpO1z2sC/F9QxhzqjJWppXA2c4Bzf28J8ooxfZQWiLbOquA837ja/caPHCDg5WM LX4E9lD9uDrtxJ5qWg91ILPJfv2qXa8XystntjhSXxvHHf8IfPVqsN8OTeh73t7TS0fM ERAkAjywU4mu1I//+tscppwViSn+Bf2ckxtKD6mLw5xi7ykhjvLWiuIsXNkRKIYC+Vcc eWHfw/YyFfG18vjY8ZvnujN6MrY4XYD2FCz+n5V5gYXi5BVW3tGudw9+AILJOEDSx1Sj UvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fjJ7ohl/WNHBrbbH+wbp9lubgjVrSjUWiauTpCnG4EU=; b=A3V3lpgxLn+mfrd7QwIoJvTsPIsmWxIORj7qOSjQ6lJcAYfYYgR4/YohJjuE2VRJNJ PmNVrCLRgKUrpNOOOD9c3b98TB0nxpLpkoGhZNCS9yHuARc140Key8bh+fBo6KiAdDWN OAm3SIOujW9FTxrndRxJYUCU5kVbZwDYjC2VxtVFF+MzmMoASkxkNOH+1h6DF14dtiXZ AI3Tawc8YnneQ3EmwJRqdil8e91xAuyc+kv1KB2hCczlU8FE4WyF2Z4n0hjNPWT6Wt/3 gzrZ5n5UNaHj11T4esjQh+xxEmLKEdsmSG6fzqZPH2vV9YZsg0RSBXd3Fczht4DtspjE DfjQ== X-Gm-Message-State: AOAM533ZwdeDGJX7W3yO9t0Z3edtno4uEHqWyeUkLHntq8CcOr9ZxcTO ztvwl7YXlFZBYyXw+tQLnCb/v3fr X-Google-Smtp-Source: ABdhPJxuF9q+F0l8qGUkACfcSb+McN1uLmpWQp9Z/RtdZuHbAUID9PVJlHt2XFOET3mhQYD577//bQ== X-Received: by 2002:a7b:c5c1:: with SMTP id n1mr14297482wmk.21.1592779937605; Sun, 21 Jun 2020 15:52:17 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u23sm898714wru.94.2020.06.21.15.52.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2020 15:52:17 -0700 (PDT) Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el To: "Basil L. Contovounesios" , Theodor Thornhill References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> <87lfkg48lr.fsf@thornhill.no> <87y2og8fs9.fsf@tcd.ie> From: Dmitry Gutov Message-ID: <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru> Date: Mon, 22 Jun 2020 01:52:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87y2og8fs9.fsf@tcd.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41977-done Cc: 41977-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 21.06.2020 20:55, Basil L. Contovounesios wrote: >> You are absolutely correct, and TIL - thanks:) >> >> Below is another patch doing this. Works fine in emacs -Q > Thanks, LGTM. Thanks all! Pushed (after rephrasing the commit message in the imperative mood). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 19:02:37 2020 Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 23:02:37 +0000 Received: from localhost ([127.0.0.1]:32804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn8yy-00061w-Uf for submit@debbugs.gnu.org; Sun, 21 Jun 2020 19:02:37 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn8yv-00061h-2Q for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 19:02:35 -0400 Received: by mail-wr1-f66.google.com with SMTP id b6so14800172wrs.11 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 16:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BYXru6zKI3xoeq8Blnro2zZor51NPf6i0xtagKnVZ84=; b=FwejegVxhgKIBMDjHEsn06zBz2OTUkaencgewf8kCe6HRFAFqRLFwcmVBJmk0Dorpt Peelzol1nRIn5zsTQ7HXWKsmXnP7HghYZxi97wZ7zCZ+ezG28+hcqkChlpH5wRhH/FQi 5bwmfBFZi1t7LxR5S/NHkFR0A+1YeIti4L54UOGIMQSKPUpwZ5LzIPsq8cJ6VBo1OcEZ Cw11NwNYis+XVGUCWn1a9y12VI0LBpis3DKRpsVT7NJPH7D0smmJ1FjBkPOiNxWKbe0Q 46+mNVomkRNIJAQL9EW6cM9ATkJmFky1pdeVYzFlbutqzZyDdxjlhbCtkKX9usSHtGNE T8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BYXru6zKI3xoeq8Blnro2zZor51NPf6i0xtagKnVZ84=; b=HO13/hSp0NFDn3bulwLzewNKIDPlZGUE/i9/f24YDzFGykBEROHECGk6zN1CvxjYzh FGOEssEwpeCJZpHFnfw/lcjBosWnCYSryTZ5LfJGeNop2EjLF/z8llfj6EZqEf2LLCjU Bwhky5AeBPHet9nplN4op6Hf6F/DuTXlXSlnC7Lmd4vhLZ81UdirHk0CnhJHZwcr2goN GqsY7+KsEfBy76/8ZXWwTfb1o81mWam2ffp5FPoGYZOFmj/LV39JZ0PjHNV/nPcrz5+I xa2woSjzx0Hhz/U6fDUpSS/1npdgPgzCkx3U+Z6Yv86Hhfd59AbjL/LbjdXjdy2vVwCS ti1Q== X-Gm-Message-State: AOAM533u/fSig9Dq8hrXkUZMtySwiwTmRB6kpNhXgik+Rv6Bo9+n9mN2 XT5wpveZcz6cGUyc+7J8Oglv7w== X-Google-Smtp-Source: ABdhPJwVfSGADfVmlEafnabacvdQ0c++Vfqdum6I2gusXTbaGR2wLbFH45kYdsK4BnKR8C0/47HUhQ== X-Received: by 2002:a5d:45cb:: with SMTP id b11mr15294963wrs.235.1592780547108; Sun, 21 Jun 2020 16:02:27 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id b143sm14637614wme.20.2020.06.21.16.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 16:02:26 -0700 (PDT) From: "Basil L. Contovounesios" To: Dmitry Gutov Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> <87lfkg48lr.fsf@thornhill.no> <87y2og8fs9.fsf@tcd.ie> <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru> Date: Mon, 22 Jun 2020 00:02:25 +0100 In-Reply-To: <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru> (Dmitry Gutov's message of "Mon, 22 Jun 2020 01:52:15 +0300") Message-ID: <87h7v46n0e.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41977 Cc: Theodor Thornhill , 41977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 21.06.2020 20:55, Basil L. Contovounesios wrote: >>> You are absolutely correct, and TIL - thanks:) >>> >>> Below is another patch doing this. Works fine in emacs -Q >> Thanks, LGTM. > > Thanks all! > > Pushed (after rephrasing the commit message in the imperative mood). In the future it should also be rephrased to include a reference to the bug#number. ;) (Sorry, I didn't notice either.) Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 19:07:40 2020 Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 23:07:40 +0000 Received: from localhost ([127.0.0.1]:32808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn93s-00069C-Kd for submit@debbugs.gnu.org; Sun, 21 Jun 2020 19:07:40 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:53005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn93p-00068x-7R for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 19:07:39 -0400 Received: by mail-wm1-f52.google.com with SMTP id r9so13199320wmh.2 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 16:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MAiew/SoYj6eWisXHr6WXTQOcE72sy4OG1HXCy8Emkc=; b=O9xcX2eMOrHTi7ySF1/dKmRxL0LYmwaySCNQqBMz3tJsKCcUQ4oSvmF7n8TWs3Ktkj nB9aMYAiQ8v567/fAtmhBIv4fIQOqm28tiFwGCyVSXQDyvHD28x3KRjd1R397MkzJOkX 2B+gh7k/sGo9s9qfwx7nz/6ZMYNXsoarsgpTuIptxrnioS9GC0U74OK1bA/T5SvtKIdG sZqlwGbWUWc64j95LweFLoxoSigzizsz4gxx4ryvEpPKEwqBY3n6avXxAJEKHm+dRyBW e7BVTKh+VSwQssUQUiA6f5iigKoCj6yeqIRIWBN2hX8zbQrwSdeh3mpwS3Zi3l18WSmt 6PPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MAiew/SoYj6eWisXHr6WXTQOcE72sy4OG1HXCy8Emkc=; b=lITvpH175rxVZ6P/cYOcj2blTHsABcE9+0h2hnJoBLqMKpyy6d2cQ9WC1rAEF6R2mw RRMf5MVDZ6EOp8KbDTzKT+xMGfh1tF9J8Ij+b2zjkE+qI0EXZuUtKN+Rrc4Zf3q0f+s1 mxXjhTPp4wJ8LKu2pLS6kvra9f/Y2hYoUwfQyjKaKdfv7kqGbpgO02yvfudTT5WXCIvV rESYp/ipEXG/S3uFTHQogj+w6lO153cmHYKkNAQC2h0daCpYmdqQXDa9DjBjax12VDYf ge7ioqiCjjdBlwEtx5L+DWUy0/FxprKUm6dXUYoAsNDvyRGgDkrLlfxezkLxua2w0rP8 Z42A== X-Gm-Message-State: AOAM533s+Jw6NV5tice6dlT8PFwl75U5dNfvgrhUqpf1OKtgRLPiNg6+ o4rk2swhU5J2jyayRkcW80f2Yv52 X-Google-Smtp-Source: ABdhPJw8GNLAP2WEKxzz1k9AOL1yWMPKVPlVQPpYrphtOIjF1ZbC8u8XtnKbmg5ign42cuH4IbgJ6Q== X-Received: by 2002:a7b:c944:: with SMTP id i4mr15174013wml.22.1592780851218; Sun, 21 Jun 2020 16:07:31 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 1sm9964450wmf.21.2020.06.21.16.07.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2020 16:07:30 -0700 (PDT) Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el To: "Basil L. Contovounesios" References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> <87lfkg48lr.fsf@thornhill.no> <87y2og8fs9.fsf@tcd.ie> <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru> <87h7v46n0e.fsf@tcd.ie> From: Dmitry Gutov Message-ID: Date: Mon, 22 Jun 2020 02:07:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87h7v46n0e.fsf@tcd.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41977 Cc: Theodor Thornhill , 41977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22.06.2020 02:02, Basil L. Contovounesios wrote: > In the future it should also be rephrased to include a reference to the > bug#number.;) Indeed. I often forget to do this here, especially when working with debbugs. :-( From unknown Sat Aug 09 15:55:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Jul 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator