Subject: bug#41977: closed (Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 21 Jun 2020 22:53:02 +0000

Your bug report

#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41977: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41977
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
From: Dmitry Gutov <[email-masked]>
To: "Basil L. Contovounesios" <[email-masked]>, Theodor Thornhill <[email-masked]>
Cc: [email-masked]
Date: Mon, 22 Jun 2020 01:52:15 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>> You are absolutely correct, and TIL - thanks:)
>>
>> Below is another patch doing this. Works fine in emacs -Q
> Thanks, LGTM.

Thanks all!

Pushed (after rephrasing the commit message in the imperative mood).

Subject: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
From: Theodor Thornhill <[email-masked]>
To: [email-masked]
Date: Sun, 21 Jun 2020 11:33:06 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi!

I saw a little too late that the latest patch to 'project-eshell' didn't
apply correctly when compiling emacs.  As such you would get old
behavior until you eval 'project-eshell'.

A quick fix as far as I can tell is the below patch.

Theo

From 4b3f83a4ea36252f7f7552b58529688f6b4c3c9f Mon Sep 17 00:00:00 2001
From: Theodor Thornhill <[email-masked]>
Date: Sun, 21 Jun 2020 13:09:42 +0200
Subject: [PATCH] project.el - eval-when-compile eshell

* lisp/progmodes/project.el: eval-when-compile Eshell so we can use
'eshell-buffer-name' in 'project-eshell'
---
 lisp/progmodes/project.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 74495cf07a..b77317b98d 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -91,7 +91,9 @@
 ;;; Code:
 
 (require 'cl-generic)
-(eval-when-compile (require 'subr-x))
+(eval-when-compile
+  (require 'subr-x)
+  (require 'eshell))
 
 (defgroup project nil
   "Operations on the current project."
-- 
2.27.0