GNU bug report logs - #41974
28.0.50; Some vc commands refuse to work when called on non-file buffer

Previous Next

Full log

Message #11 received at 41974 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 41974 <at> debbugs.gnu.org
Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called
 on non-file buffer
Date: Mon, 22 Jun 2020 01:51:20 +0300

> On 21.06.2020 02:55, Juri Linkov wrote:
>> I think this restriction should be lifted, so vc commands should
>> work even when called on non-file buffers whose default-directory
>> is inside the vc project.
>
> Agreed.
>
> Does this patch help, or does it miss more cases?
>
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 9b12d44978..36013fcdc9 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -2563,7 +2563,7 @@ vc-print-branch-log
>      (vc-read-revision "Branch to log: ")))
>    (when (equal branch "")
>      (error "No branch specified"))
> -  (let* ((backend (vc-responsible-backend default-directory))
> +  (let* ((backend (vc-deduce-backend))
>           (rootdir (vc-call-backend backend 'root default-directory)))
>      (vc-print-log-internal backend
>                             (list rootdir) branch t

Strange, this patch has no effect, the same error remains.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.