From unknown Sun Aug 10 16:51:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41974 <41974@debbugs.gnu.org> To: bug#41974 <41974@debbugs.gnu.org> Subject: Status: 28.0.50; Some vc commands refuse to work when called on non-file buffer Reply-To: bug#41974 <41974@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:51:54 +0000 retitle 41974 28.0.50; Some vc commands refuse to work when called on non-f= ile buffer reassign 41974 emacs submitter 41974 Juri Linkov severity 41974 normal tag 41974 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 19:59:08 2020 Received: (at submit) by debbugs.gnu.org; 20 Jun 2020 23:59:08 +0000 Received: from localhost ([127.0.0.1]:58949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnO8-0002Hw-Ho for submit@debbugs.gnu.org; Sat, 20 Jun 2020 19:59:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:35838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnO3-0002Hh-M3 for submit@debbugs.gnu.org; Sat, 20 Jun 2020 19:59:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmnO3-0004du-B6 for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 19:59:03 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:44823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmnO1-00014a-8p for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 19:59:03 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C61C140002 for ; Sat, 20 Jun 2020 23:58:56 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Some vc commands refuse to work when called on non-file buffer Organization: LINKOV.NET Date: Sun, 21 Jun 2020 02:55:47 +0300 Message-ID: <87a70x8f7g.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/20 19:58:57 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) For example, typing M-x vc-print-branch-log RET on the project's *compilation* buffer signals the error: "Buffer *compilation* is not associated with a file" I think this restriction should be lifted, so vc commands should work even when called on non-file buffers whose default-directory is inside the vc project. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 20:07:50 2020 Received: (at 41974) by debbugs.gnu.org; 21 Jun 2020 00:07:50 +0000 Received: from localhost ([127.0.0.1]:58956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnWY-0002Vq-EH for submit@debbugs.gnu.org; Sat, 20 Jun 2020 20:07:50 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnWX-0002Vd-9Q for 41974@debbugs.gnu.org; Sat, 20 Jun 2020 20:07:49 -0400 Received: by mail-wr1-f67.google.com with SMTP id x6so13179013wrm.13 for <41974@debbugs.gnu.org>; Sat, 20 Jun 2020 17:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e0dvIuaj6xwaa21z8pyuyViS/WPr7kLBfINqlLXiPPs=; b=FpXANJazLnTQDglE0IwkGaWJJ8cB0HZHqptZOZQYq2OAeLfX4nms+XJX57BNwIVxsk GgO7n+dyZczJjeUIT7fhHTovRLaGXKgJb9byp6lM51RHuDO6PORsQL6nUfXHfsU8WuAr cru76EBCFMEYxqQsWVF6AYZuNjxXdr1eEu38C6r+gJht15E074Injw+Cmfw9WFCm06xo w2mcwTw5kdYmMAuBckXq3AP3ok/MACmHok5UvaCOcXEQJQfWEqw9/VBlrhfaZrm9qzfq 7e66DtKp2nf7ym5rS2Cz7a/B0HiaHlqmi86k+47RORNlTTOB5HSKRR0q+ab8dGbRcjMx 30OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e0dvIuaj6xwaa21z8pyuyViS/WPr7kLBfINqlLXiPPs=; b=cvK6+Jfm91HZSwswVa7RdqvrkxDaVQplPDevjW9sUKu0f/GLPmU6coxkY5JWBWrWsN rXxQ/HgtspsjQzutFSUMsL5Pb9v7bltcSyhgb6Xnh3NV6mi8nHOPpsmzN00B9Bt0j2+F 9y8Rq4QUrrCz3r5D6eDKj+xcVY+vIf03ENCJRk3+Ep+dD5w7QLS/b3VyfTjTSBFVQ4Qj vL8mKI6pz+P5gqQQPdxQgdnNP3UJnGWkfxI30esIA0U/RzJBfByc977nbwMXYGe6f+Vh jOg/0wexNFGOUiq9G6CrtGHWp2lHYroQ6dGAe6EYozb+JaZmYJyOFm0sRd/u/XDxL8aq 64Hg== X-Gm-Message-State: AOAM532DLIsUOEUB0AbZXIHp72mLOg4+B1xDn3WJHcDtiIXYFp7HKRzd UaDL/h5K2xy4aM3ZeXkmz3SEfZQi X-Google-Smtp-Source: ABdhPJyIdctC3fsGTEMIxhwqzN/xF98XXrpgNfETyX+HH6NQTy56AF84ylmE6KbSX6YkK3Ary9uzDg== X-Received: by 2002:a5d:60c3:: with SMTP id x3mr10901413wrt.48.1592698063147; Sat, 20 Jun 2020 17:07:43 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id z9sm11116972wmi.41.2020.06.20.17.07.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2020 17:07:42 -0700 (PDT) Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer To: Juri Linkov , 41974@debbugs.gnu.org References: <87a70x8f7g.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Sun, 21 Jun 2020 03:07:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87a70x8f7g.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41974 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.06.2020 02:55, Juri Linkov wrote: > I think this restriction should be lifted, so vc commands should > work even when called on non-file buffers whose default-directory > is inside the vc project. Agreed. Does this patch help, or does it miss more cases? diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 9b12d44978..36013fcdc9 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2563,7 +2563,7 @@ vc-print-branch-log (vc-read-revision "Branch to log: "))) (when (equal branch "") (error "No branch specified")) - (let* ((backend (vc-responsible-backend default-directory)) + (let* ((backend (vc-deduce-backend)) (rootdir (vc-call-backend backend 'root default-directory))) (vc-print-log-internal backend (list rootdir) branch t From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 19:19:23 2020 Received: (at 41974) by debbugs.gnu.org; 21 Jun 2020 23:19:23 +0000 Received: from localhost ([127.0.0.1]:32820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn9FD-0006Qe-8q for submit@debbugs.gnu.org; Sun, 21 Jun 2020 19:19:23 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:56299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn9FB-0006QB-0d for 41974@debbugs.gnu.org; Sun, 21 Jun 2020 19:19:21 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id E86861BF203; Sun, 21 Jun 2020 23:19:13 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Organization: LINKOV.NET References: <87a70x8f7g.fsf@mail.linkov.net> Date: Mon, 22 Jun 2020 01:51:20 +0300 In-Reply-To: (Dmitry Gutov's message of "Sun, 21 Jun 2020 03:07:40 +0300") Message-ID: <87wo40ghht.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41974 Cc: 41974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 21.06.2020 02:55, Juri Linkov wrote: >> I think this restriction should be lifted, so vc commands should >> work even when called on non-file buffers whose default-directory >> is inside the vc project. > > Agreed. > > Does this patch help, or does it miss more cases? > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 9b12d44978..36013fcdc9 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -2563,7 +2563,7 @@ vc-print-branch-log > (vc-read-revision "Branch to log: "))) > (when (equal branch "") > (error "No branch specified")) > - (let* ((backend (vc-responsible-backend default-directory)) > + (let* ((backend (vc-deduce-backend)) > (rootdir (vc-call-backend backend 'root default-directory))) > (vc-print-log-internal backend > (list rootdir) branch t Strange, this patch has no effect, the same error remains. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 20:59:49 2020 Received: (at 41974) by debbugs.gnu.org; 22 Jun 2020 00:59:49 +0000 Received: from localhost ([127.0.0.1]:32938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnAoP-0002sF-HG for submit@debbugs.gnu.org; Sun, 21 Jun 2020 20:59:49 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:38235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnAoN-0002rx-5g for 41974@debbugs.gnu.org; Sun, 21 Jun 2020 20:59:47 -0400 Received: by mail-wm1-f51.google.com with SMTP id f18so1572669wml.3 for <41974@debbugs.gnu.org>; Sun, 21 Jun 2020 17:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K9gHk7uNBFMLbjNCriF0eyP14kTflPuCoo5P/qhP4G0=; b=J2IODVE7cIxQpMNXE9ijoYq4a0deZYl42Y2OaeITIG2IM2Vqml1yU2ZUtZZwpVgjRr oryDyKvJa6eM+SH+QEKz6hGISKgNs+IQdYIRqG/l0P7KBfXcPK67AmT4cuM8MZnTBPLs RtgMWjTx72znUYnMiEW7aXX/FiO3fjKia59nv5d3W7jOrY/8lnvHFroKIshphjY+vAcz wQbZM78tLaDQhhsBpBwaAzAt/EhQaS61u7f2pzKAgLz+i3XutF3KxbVADPCqhlvhVb9C SYViqtlH0r1vqxS5cpg3cQkftUnCm0Xr1B4ZqLiUFUAVo5Yz1DW9XQbZcwUvpk3QH4Pn TpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K9gHk7uNBFMLbjNCriF0eyP14kTflPuCoo5P/qhP4G0=; b=MfvftR7R4rZkt71KpA/ZNJpmeJZvxJeLqL7KrVBlPkSjXo0vFD5diPYmgFxUvTkPM9 lAuVlnfqIIpRjOXclkGFs6/MlRRz8+gpmhPWquiP8LVB9RQHBZ12iIZhn9iQHI9KHKhg 3mX0bXaK5qbdUrO1GMxToy/oyO9/3J/9VmFM3vzFPIA9SVmDfrIMDvOlH4jna4OvQIms 74JAHwhgkHezNR0zx7ktZ4LazsL31yF6ITPEkLJDfVAiWO/2deiJN+rahYfr2Ui2v0oF r6SdoQI2eyhGZEmakzIpjdHKIbFZShj//b0hJB9IuL+bbdyYDcOp35HfuHqywP9+iLlS mEGw== X-Gm-Message-State: AOAM532QDlt4s2DcGNCvgpx2XQtxxHOeJqiftKFryod1E8zJJby/SSHp JbLK+sTOplHAaqIKu63Ei5Akt++c X-Google-Smtp-Source: ABdhPJys3FaAUJrZG1h3Oq3uCPlfeKGoEUu4E1OkfB/LD3wZxbnPabbY/7XY0sqUdPdgNe6TEAGBhg== X-Received: by 2002:a7b:cb4c:: with SMTP id v12mr15526749wmj.43.1592787581048; Sun, 21 Jun 2020 17:59:41 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v20sm1957614wmh.26.2020.06.21.17.59.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2020 17:59:40 -0700 (PDT) Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer To: Juri Linkov References: <87a70x8f7g.fsf@mail.linkov.net> <87wo40ghht.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 22 Jun 2020 03:59:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87wo40ghht.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41974 Cc: 41974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22.06.2020 01:51, Juri Linkov wrote: > Strange, this patch has no effect, the same error remains. Sorry, that was a brain fart. How about this: diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 9b12d44978..6bb72d8976 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1074,11 +1074,11 @@ vc-deduce-fileset (progn ;FIXME: Why not `with-current-buffer'? --Stef. (set-buffer vc-parent-buffer) (vc-deduce-fileset not-state-changing allow-unregistered state-model-only-files))) - ((and (derived-mode-p 'log-view-mode) + ((and (not buffer-file-name) (setq backend (vc-responsible-backend default-directory))) (list backend nil)) ((not buffer-file-name) - (error "Buffer %s is not associated with a file" (buffer-name))) + (error "Buffer %s is not recognized by any VC backend" (buffer-name))) ((and allow-unregistered (not (vc-registered buffer-file-name))) (if state-model-only-files (list (vc-backend-for-registration (buffer-file-name)) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 20:15:28 2020 Received: (at 41974) by debbugs.gnu.org; 23 Jun 2020 00:15:28 +0000 Received: from localhost ([127.0.0.1]:34950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWb1-000704-Tz for submit@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:28 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWaz-0006zn-RX for 41974@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:26 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AD54EFF804; Tue, 23 Jun 2020 00:15:18 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Organization: LINKOV.NET References: <87a70x8f7g.fsf@mail.linkov.net> <87wo40ghht.fsf@mail.linkov.net> Date: Tue, 23 Jun 2020 02:38:39 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 22 Jun 2020 03:59:38 +0300") Message-ID: <87eeq67k9k.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41974 Cc: 41974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > How about this: > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 9b12d44978..6bb72d8976 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -1074,11 +1074,11 @@ vc-deduce-fileset > (progn ;FIXME: Why not > `with-current-buffer'? --Stef. > (set-buffer vc-parent-buffer) > (vc-deduce-fileset not-state-changing allow-unregistered > state-model-only-files))) > - ((and (derived-mode-p 'log-view-mode) > + ((and (not buffer-file-name) > (setq backend (vc-responsible-backend default-directory))) > (list backend nil)) Thanks for finding the right place to fix, and it should also fix all other vc commands that failed on non-file buffers. > ((not buffer-file-name) > - (error "Buffer %s is not associated with a file" (buffer-name))) > + (error "Buffer %s is not recognized by any VC backend" It seems this code is not necessary anymore because before this code gets executed, vc-responsible-backend already signals its error "No VC backend is responsible for file". From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 20:34:46 2020 Received: (at 41974) by debbugs.gnu.org; 23 Jun 2020 00:34:46 +0000 Received: from localhost ([127.0.0.1]:34990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWti-0007Ts-4U for submit@debbugs.gnu.org; Mon, 22 Jun 2020 20:34:46 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:33840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWtZ-0007TD-J6 for 41974@debbugs.gnu.org; Mon, 22 Jun 2020 20:34:38 -0400 Received: by mail-wm1-f50.google.com with SMTP id u26so1068594wmn.1 for <41974@debbugs.gnu.org>; Mon, 22 Jun 2020 17:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/xmHxnDnJFYxxUnRS8/D46KdBqgPys8e31K0CiwWzFo=; b=Qr3JCV4URetcCfN39Y8/4HfSQ290ncgN0yLlHlSp3rWaZKrJTkav2HZlmeJi2HDT5+ cQg6D/TJdpebEmznyvDlVo78AWDGJ10hITMhpdaPq0oBNESZnBHaA2vz5D2q0W9L48of cbDViVvt7xBzCETP4nAwcvMBcgkFYW0NFADLM6ak3MrkrRs/uTqFd8i7E5j4uq4hS3yF IrbHncawMzYsZ0nIzhfAEmVkulL2VvSy24gVEP9WothRf3IJid7EEl5E/R77yxRDZCo1 jJp2Ehmgb07YCE+ISyOTZPQLtIvhL+oY75pmZxRjyCJF9fayW049ZOpZfsbXsifh8W7k ouGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/xmHxnDnJFYxxUnRS8/D46KdBqgPys8e31K0CiwWzFo=; b=lNKdnwbn88+W3nhe/QzW438z1Lra7hjOxa78dErFvp/Drk1Yb7vM+CqezZGtWkpvi/ etSV28Zx4K+hpXnS0ihitjbYwWSFd/sCN5eT0c2nguvjNHYOGCrBYNwvzkQwjMLb3uw3 Cg4tXADuJI5rloBWGdqbBQDnYr9dV8La/cbvMcuUr8Culxn3G5a+tVqe/7aH8KNERkSz O5pJKOQRjpp+02f41P8+JDV4ESGBaEu3WtV3Wp2bLxVhuqRGNyP8G/F9AKhln8tKVPFG beKzNBbAxb09dZnKVotboakVYaloxxBkcobwvsjr4jwTwzdAS+7n+wVLZVYy1Hwfjq5I msmA== X-Gm-Message-State: AOAM530A5j/vm6Yg++T+40IoiX5caPwbQcAgab6jE7VK8Dlt0T7dZA5J 1epmidE1Rp+nWVlMwFHwMj5cfSKZ X-Google-Smtp-Source: ABdhPJzT7Hf4AlV+z9kE1lfTFF0MaSqrRBPL6KW7tYTwUxhFoOuedan4fvC5dRKAZyyWHQJury/K+w== X-Received: by 2002:a7b:c952:: with SMTP id i18mr22383896wml.65.1592872471398; Mon, 22 Jun 2020 17:34:31 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o15sm1363866wmm.31.2020.06.22.17.34.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 17:34:30 -0700 (PDT) Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer To: Juri Linkov References: <87a70x8f7g.fsf@mail.linkov.net> <87wo40ghht.fsf@mail.linkov.net> <87eeq67k9k.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <7a08d8b8-aed5-b130-1d8e-34d90781a64a@yandex.ru> Date: Tue, 23 Jun 2020 03:34:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87eeq67k9k.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41974 Cc: 41974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 23.06.2020 02:38, Juri Linkov wrote: >> ((not buffer-file-name) >> - (error "Buffer %s is not associated with a file" (buffer-name))) >> + (error "Buffer %s is not recognized by any VC backend" > It seems this code is not necessary anymore because before this code > gets executed, vc-responsible-backend already signals its error > "No VC backend is responsible for file". Even better. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 23 20:04:41 2020 Received: (at 41974) by debbugs.gnu.org; 24 Jun 2020 00:04:41 +0000 Received: from localhost ([127.0.0.1]:37423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnsu9-0002FP-2q for submit@debbugs.gnu.org; Tue, 23 Jun 2020 20:04:41 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:38291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnsu6-0002F5-9c; Tue, 23 Jun 2020 20:04:40 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C74F3C0006; Wed, 24 Jun 2020 00:04:30 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Organization: LINKOV.NET References: <87a70x8f7g.fsf@mail.linkov.net> <87wo40ghht.fsf@mail.linkov.net> <87eeq67k9k.fsf@mail.linkov.net> <7a08d8b8-aed5-b130-1d8e-34d90781a64a@yandex.ru> Date: Wed, 24 Jun 2020 02:54:58 +0300 In-Reply-To: <7a08d8b8-aed5-b130-1d8e-34d90781a64a@yandex.ru> (Dmitry Gutov's message of "Tue, 23 Jun 2020 03:34:28 +0300") Message-ID: <87r1u5xrql.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41974 Cc: 41974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 41974 fixed close 41974 28.0.50 quit >>> ((not buffer-file-name) >>> - (error "Buffer %s is not associated with a file" (buffer-name))) >>> + (error "Buffer %s is not recognized by any VC backend" >> It seems this code is not necessary anymore because before this code >> gets executed, vc-responsible-backend already signals its error >> "No VC backend is responsible for file". > > Even better. Thanks, pushed to master. From unknown Sun Aug 10 16:51:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator