GNU bug report logs - #41950
gnu: Add poke.

Previous Next

Full log

View this message in rfc822 format

From: elaexuotee <at> wilsonb.com
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 41950-done <at> debbugs.gnu.org
Subject: [bug#41950] gnu: Add poke.
Date: Mon, 22 Jun 2020 11:45:28 +0900

[Message part 1 (text/plain, inline)]

Awesome. Thanks for merging this.

By the way, that indentation was intentional. The form that etc/indent-code.el
wants is kind of awkward in this case:

    (invoke "./bootstrap" "--no-git"
            "--no-bootstrap-sync"
            "--gnulib-srcdir=gnulib")

I think it makes more sense to line up *command options* rather than the
arguments to `invoke'. This is what I originally had:

    (invoke "./bootstrap" "--no-git"
                          "--no-bootstrap-sync"
                          "--gnulib-srcdir=gnulib")

Does this make sense? For future reference, is there a better way to format
this that also plays well with indent-code.el?

Mathieu Othacehe <othacehe <at> gnu.org> wrote:
> 
> Hey,
> 
> > Anyway, I am still somewhat new to packaging, so let me know if I missed
> > anything obvious.
> 
> No, everything looks fine :) I fixed a small indentation mistake and
> pushed!
> 
> Thanks,
> 
> Mathieu

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.