From unknown Sat Aug 16 19:17:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41944: cp: default to --reflink=auto, revisted Resent-From: Chris Murphy Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 19 Jun 2020 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41944 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 41944@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15925317016688 (code B ref -1); Fri, 19 Jun 2020 01:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jun 2020 01:55:01 +0000 Received: from localhost ([127.0.0.1]:54750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm6FB-0001jn-2y for submit@debbugs.gnu.org; Thu, 18 Jun 2020 21:55:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:58244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm6F8-0001jf-LB for submit@debbugs.gnu.org; Thu, 18 Jun 2020 21:54:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm6F8-0005kX-Cn for bug-coreutils@gnu.org; Thu, 18 Jun 2020 21:54:58 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:51755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jm6F6-0007GK-D8 for bug-coreutils@gnu.org; Thu, 18 Jun 2020 21:54:58 -0400 Received: by mail-wm1-x336.google.com with SMTP id b82so7007267wmb.1 for ; Thu, 18 Jun 2020 18:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=colorremedies-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=TUvssW0lxv46E+LLu8z1NDGvGKkK3RDOXngdewBkcaI=; b=StUrGkvnhmsOtUvAjG/qjGetFKhuBpKoZZTdkeZkwvbeJNEtfm+AjFlUuL3LnEEGsy 8ZeRaVPSFAW1pduzUiZJIjXGPGkVRo77dduCXXMpBA41b8HV66Gzzu/DltZnwwWF2hHh uRi172DV/fgBvf1EXQfzclSDThUXiNtvKMv9H9myxGStQqAjhjim4NQ8vEhJdsGmdMGX t5vMr0ZHZAmIVqlZf6Pw1y6kw2m6wBdguT2WK2FWZJvkVq4P5Lxnfh1TlCTpm7yhNJgq aI24DDJwi27Gm6w/l6tAE3HSOatpfJmJetHNzgKjBu7hWrQ05B2bxiPRCZKyhqd/1GSj LLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TUvssW0lxv46E+LLu8z1NDGvGKkK3RDOXngdewBkcaI=; b=h9wQ+vgSXAyg8f+PRuHlX7CHG9QQMfwoCvaT08gUJNsppcPSEY+vYnXV/zoNENbjcy xQbf+NUomfG1eJUwP+Jd/CGjYLCCH/2O1KS5upxeVWg5TMTzRaL/bK6KB0Jrc7sf4NWV 90dynZTsyP/NbiOvioKGxuK6Tetn+vLWZOUaXIiTs+mk2ZIG+++qoBuGSWhcz5G2LQzX GPo3MsMpLOQoPrKMjFUxBb6kjO5dZwDA12JWRPYojU3eQvW1342KaulWCOvJUbec6EsS usaHmmNS3g5QlPQrvqBr6lU2pTq9xrWwVeTVBJzxsYVqwy1ypCdDzFYY24xiSm4rzQAF VDYA== X-Gm-Message-State: AOAM5322OebpdOmFKaFj+/vzytX5/wA20LFSPT2J/4g5ot+xCG84KM3q c/V+57vRyGoRJ4tZAPMZWs3CGfmu0J+4TFieXxqwsZC5nYWXxQ== X-Google-Smtp-Source: ABdhPJzKetK7fkqcB4xbsDtZAy/PF19ApTIRf0SeMdTl77I2q0JvrmcpRKsuOf8OeqxegYsPwMOuh7ZwEyKXXG4SxRA= X-Received: by 2002:a7b:c2a9:: with SMTP id c9mr1155989wmk.11.1592531693959; Thu, 18 Jun 2020 18:54:53 -0700 (PDT) MIME-Version: 1.0 From: Chris Murphy Date: Thu, 18 Jun 2020 19:54:38 -0600 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=chris@colorremedies.com; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, The most recent discussion I found about this: https://lists.gnu.org/archive/html/bug-coreutils/2016-09/msg00015.html It's definitely currently never. https://github.com/coreutils/coreutils/blob/master/src/cp.c#L796 However for mv, it is used (which I understand it's a different thing, the optimization for cp+rm makes even more sense than for cp alone). https://github.com/coreutils/coreutils/blob/master/src/mv.c#L113 Thanks, -- Chris Murphy From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 01:36:15 2020 Received: (at control) by debbugs.gnu.org; 19 Jun 2020 05:36:15 +0000 Received: from localhost ([127.0.0.1]:54829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9hG-0007Iz-SE for submit@debbugs.gnu.org; Fri, 19 Jun 2020 01:36:15 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9hE-0007Ik-Ti for control@debbugs.gnu.org; Fri, 19 Jun 2020 01:36:13 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91E521600E4 for ; Thu, 18 Jun 2020 22:36:07 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id A7pGWU6hmBxR for ; Thu, 18 Jun 2020 22:36:07 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EB5BA1600E9 for ; Thu, 18 Jun 2020 22:36:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tyODkFl6qCxM for ; Thu, 18 Jun 2020 22:36:06 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C999B1600E4 for ; Thu, 18 Jun 2020 22:36:06 -0700 (PDT) To: control@debbugs.gnu.org From: Paul Eggert Subject: merge 24400 to 41944 Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDUGdRVEFRSUFL QVVDVElCeQpaQUliQXdVSkVzd0RBQVlMQ1FnSEF3SUdGUWdDQ1FvTEJCWUNBd0VDSGdFQ0Y0 QUFDZ2tRN1pmcERtS3FmalJSCkd3LytJajAzZGhZZllsL2dYVlJpdXpWMWdHcmJIayt0bmZy SS9DN2ZBZW9GelE1dFZnVmluU2hhUGtabzBIVFAKZjE4eDZJREVkQWlPOE1xbzF5cDBDdEht ekdNQ0o1MG80R3JnZmpscjZnLyt2dEVPS2JobGVzek4yWHBKdnB3TQoyUWdHdm4vbGFUTFV1 OFBIOWFSV1RzN3FKSlpLS0tBYjRzeFljOTJGZWhQdTZGT0QwZERpeWhsREFxNGxPVjJtCmRC cHpRYmlvam9aelFMTVF3anBnQ1RLMjU3MmVLOUVPRVF5U1VUaFhyU0l6NkFTZW5wNE5ZVEZI czl0dUpRdlgKazlnWkRkUFNsM2JwKzQ3ZEd4bHhFV0xwQklNN3pJT053NGtzNGF6Z1Q4bnZE WnhBNUlaSHR2cUJsSkxCT2JZWQowTGU2MVdwMHkzVGxCRGgycWRLOGVZTDQyNlc0c2NFTVN1 aWc1Z2I4T0F0UWlCVzZrMnNHVXh4ZWl2OG92V3U4CllBWmdLSmZ1b1dJK3VSbk1FZGRydVk4 SnNvTTU0S2FLdlppa2tLczJiZzFuZHRMVnpIcEo2cUZaQzdRVmplSFUKaDYvQm1ndmRqV1Ba WUZUdE4rS0E5Q1dYM0dRS0tnTjN1dTk4OHl6bkQ3TG5COThUNEVVSDFIQS9HbmZCcU1WMQpn cHpUdlBjNHFWUWluQ21Ja0VGcDgzemwrRzVmQ2pKSjNXN2l2ekNuWW80S2hLTHBGVW05N29r VEtSMkxXM3haCnpFVzRjTFNXTzM4N01USzNDekRPeDVxZTZzNGE5MVp1Wk0vai9UUWRUTERh cU5uODNrQTRIcTQ4VUhYWXhjSWgKK05kOGsvM3c2bEZ1b0swd3JPRml5d2pMeCswdXI1am1t YmVjQkdIYzF4ZGhBRkc1QWcwRVRJQnlaQUVRQUthRgo2NzhUOXd5SDR3alRyVjFQejNjREVv U25WLzBaVXJPVDM3cDFkY0d5ai9JWHExeDY3MEhSVmFoQW1rMHNacFljCjI1UEY5RDVHUFlI RldsTmp1UFU5NnJEbmRYQjNoZWRtQlJoTGRDNGJBWGpJNERWK2JtZFZlK3EvSU1ubFpSYVYK bG05RWlNQ1ZBUjZ3MTNzUmV1N3FYa1c5cjNSd1kyQXpYc2twL3RBZTRCUktyMVptYnZpMm5i blE2ZXBFQzQycgpSYngwQjFFaGpiSVFaNUpIR2syNGlQVDdMZEJnbk5tb3M1d1lqendObGtN UUQ1VDBZZHpoazdKK1V4d0E1bTQ2Cm1PaFJEQzJyRlYvQTBnbTVUTHk4RFhqdi9Fc2M0Z1lu WWFpNlNRcW5VRVZoNUx1VjhZQ0pCbmlqcytUaXc3MXgKMWljbW42eEdJNDVFdWdKT2dlYyty THlwWWdwVnA0eDBISTVUODhxQlJZQ2t4SDNLZzhRbytFV05BOUE0TFJROQpEWDhuam9uYTBn ZjBzMDN0b2NLOGtCTjY2VW9xcVB0SEJuYzRlTWdCeW1DZmxLMTJlS2ZkMllZeG55ZzljWmF6 CldBNVZzbHZUeHBtNzZoYmc1b2lBRUgvVmcvOE14SHlBblBoZnJnd3lQcm1KRWNWQmFmZHNw Sm5ZUXhCWU5jbzIKTEZQSWhsT3ZXaDhyNGF0K3MrTTNMYjI2b1VUY3psZ2RXMVNmM1NEQTc3 Qk1SbkYwRlF5RSs3QXpWNzlNQk40eQpraXFhZXpReHRhRjFGeS90dmtoZmZTbzh1K2R3RzBF Z0poK3RlMzhnVGNJU1ZyMEdJUHBsTHo2WWhqcmJIclBSCkYxQ041VXVMOURCR2p4dU4zNVJM TlZFZnRhNlJVRmxSNk5jdFRqdnJBQkVCQUFHSkFpVUVHQUVDQUE4RkFreUEKY21RQ0d3d0ZD UkxNQXdBQUNna1E3WmZwRG1LcWZqU3JIQS8rS3pBS3ZUeFJoQTlNV05MeEl5SjdTNXVKMTZn cwpUM29DalpyQktHRWhLTU9HWDRPMEdBNlZPRXJ5TzdRUkNDWWFoM294U0czOElBbk5laXdK WGdVOUJ6a2s4NVVHCmJQRWQ3SEdGL1ZTZUhDUXdXb3U2anFVRFRTRHZuOVloTlRkRzBLWFBN NzRhQyt4cjJab3cxTzJtaFhpaGdXS0QKMER3KzBMWVBuVU9zUTBLT0Z4SFhYWUhtUnJTMU9a UFU1OUJMdmMrVFJoSWhhZlNIS0x3YlhLKzZja2t4Qng2aAo4ejVjY3BHMFFzNGJGaGRGWW5G ckVpZURMb0dtbkUyWUxoZFY2c3dKOVZOQ1M2cExpRW9oVDNmbTdhWG0xNXRaCk9JeXpNWmhI UlNBUGJsWHhRMFpTV2pxOG9ScmNZTkZ4YzRXMVVScEFrQkNPWUpvWHZRZkQ1TDNscUFsOFRD cUQKVXpZeGhIL3RKaGJEZEhycUhINzY3amFEYVRCMStUYWxwLzJBTUt3Y1hOT2Rpa2xHeGJt SFZHNllHbDZnOExyYgpzdTlOWkVJNHlMbEh6dWlrdGhKV2d6KzN2WmhWR3lObHQrSE5Jb0Y2 Q2pETDJvbXU1Y0VxNFJESE00NFFxUGs2Cmw3TzBwVXZOMW1UNEIrUzFiMDhSS3BxbS9mZjAx NUUzN0hOVi9waUl2Smx4R0FZejhQU2Z1R0NCMXRoTVlxbG0KZ2RoZDkvQmFiR0ZiR0dZSEE2 VTQvVDV6cVUrZjZ4SHkxU3NBUVoxTVNLbEx3ZWtCSVQrNC9jTFJHcUNIam5WMApxNUgvVDZh N3Q1bVBrYnpTck9MU280cHVqK0lUb05qWXlZSURCV3pobEExOWF2T2ErcnZVam1IdEQzc0ZO N2NYCld0a0dvaThidU5jYnk0VT0KPUFMNm8KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkgQkxP Q0stLS0tLQo= Organization: UCLA Computer Science Department Message-ID: <597f55e3-165e-5735-1b3e-cb64546982e4@cs.ucla.edu> Date: Thu, 18 Jun 2020 22:36:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 41944 wishlist merge 24400 41944 From unknown Sat Aug 16 19:17:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Chris Murphy Subject: bug#41944: closed (Re: bug#41944: cp: default to --reflink=auto, revisted) Message-ID: References: X-Gnu-PR-Message: they-closed 41944 X-Gnu-PR-Package: coreutils Reply-To: 41944@debbugs.gnu.org Date: Fri, 19 Jun 2020 05:40:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1592545202-28447-1" This is a multi-part message in MIME format... ------------=_1592545202-28447-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41944: cp: default to --reflink=3Dauto, revisted which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 41944@debbugs.gnu.org. --=20 41944: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41944 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1592545202-28447-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41944-done) by debbugs.gnu.org; 19 Jun 2020 05:39:23 +0000 Received: from localhost ([127.0.0.1]:54834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9kJ-0007Nt-9q for submit@debbugs.gnu.org; Fri, 19 Jun 2020 01:39:23 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9kE-0007Nd-5X for 41944-done@debbugs.gnu.org; Fri, 19 Jun 2020 01:39:22 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CDC391600E4; Thu, 18 Jun 2020 22:39:12 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6OkqYA3w1HIu; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CE0281600E9; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bjeZPk6P-jsX; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A3B0E1600E4; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) Subject: Re: bug#41944: cp: default to --reflink=auto, revisted To: Chris Murphy , 41944-done@debbugs.gnu.org References: From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDUGdRVEFRSUFL QVVDVElCeQpaQUliQXdVSkVzd0RBQVlMQ1FnSEF3SUdGUWdDQ1FvTEJCWUNBd0VDSGdFQ0Y0 QUFDZ2tRN1pmcERtS3FmalJSCkd3LytJajAzZGhZZllsL2dYVlJpdXpWMWdHcmJIayt0bmZy SS9DN2ZBZW9GelE1dFZnVmluU2hhUGtabzBIVFAKZjE4eDZJREVkQWlPOE1xbzF5cDBDdEht ekdNQ0o1MG80R3JnZmpscjZnLyt2dEVPS2JobGVzek4yWHBKdnB3TQoyUWdHdm4vbGFUTFV1 OFBIOWFSV1RzN3FKSlpLS0tBYjRzeFljOTJGZWhQdTZGT0QwZERpeWhsREFxNGxPVjJtCmRC cHpRYmlvam9aelFMTVF3anBnQ1RLMjU3MmVLOUVPRVF5U1VUaFhyU0l6NkFTZW5wNE5ZVEZI czl0dUpRdlgKazlnWkRkUFNsM2JwKzQ3ZEd4bHhFV0xwQklNN3pJT053NGtzNGF6Z1Q4bnZE WnhBNUlaSHR2cUJsSkxCT2JZWQowTGU2MVdwMHkzVGxCRGgycWRLOGVZTDQyNlc0c2NFTVN1 aWc1Z2I4T0F0UWlCVzZrMnNHVXh4ZWl2OG92V3U4CllBWmdLSmZ1b1dJK3VSbk1FZGRydVk4 SnNvTTU0S2FLdlppa2tLczJiZzFuZHRMVnpIcEo2cUZaQzdRVmplSFUKaDYvQm1ndmRqV1Ba WUZUdE4rS0E5Q1dYM0dRS0tnTjN1dTk4OHl6bkQ3TG5COThUNEVVSDFIQS9HbmZCcU1WMQpn cHpUdlBjNHFWUWluQ21Ja0VGcDgzemwrRzVmQ2pKSjNXN2l2ekNuWW80S2hLTHBGVW05N29r VEtSMkxXM3haCnpFVzRjTFNXTzM4N01USzNDekRPeDVxZTZzNGE5MVp1Wk0vai9UUWRUTERh cU5uODNrQTRIcTQ4VUhYWXhjSWgKK05kOGsvM3c2bEZ1b0swd3JPRml5d2pMeCswdXI1am1t YmVjQkdIYzF4ZGhBRkc1QWcwRVRJQnlaQUVRQUthRgo2NzhUOXd5SDR3alRyVjFQejNjREVv U25WLzBaVXJPVDM3cDFkY0d5ai9JWHExeDY3MEhSVmFoQW1rMHNacFljCjI1UEY5RDVHUFlI RldsTmp1UFU5NnJEbmRYQjNoZWRtQlJoTGRDNGJBWGpJNERWK2JtZFZlK3EvSU1ubFpSYVYK bG05RWlNQ1ZBUjZ3MTNzUmV1N3FYa1c5cjNSd1kyQXpYc2twL3RBZTRCUktyMVptYnZpMm5i blE2ZXBFQzQycgpSYngwQjFFaGpiSVFaNUpIR2syNGlQVDdMZEJnbk5tb3M1d1lqendObGtN UUQ1VDBZZHpoazdKK1V4d0E1bTQ2Cm1PaFJEQzJyRlYvQTBnbTVUTHk4RFhqdi9Fc2M0Z1lu WWFpNlNRcW5VRVZoNUx1VjhZQ0pCbmlqcytUaXc3MXgKMWljbW42eEdJNDVFdWdKT2dlYyty THlwWWdwVnA0eDBISTVUODhxQlJZQ2t4SDNLZzhRbytFV05BOUE0TFJROQpEWDhuam9uYTBn ZjBzMDN0b2NLOGtCTjY2VW9xcVB0SEJuYzRlTWdCeW1DZmxLMTJlS2ZkMllZeG55ZzljWmF6 CldBNVZzbHZUeHBtNzZoYmc1b2lBRUgvVmcvOE14SHlBblBoZnJnd3lQcm1KRWNWQmFmZHNw Sm5ZUXhCWU5jbzIKTEZQSWhsT3ZXaDhyNGF0K3MrTTNMYjI2b1VUY3psZ2RXMVNmM1NEQTc3 Qk1SbkYwRlF5RSs3QXpWNzlNQk40eQpraXFhZXpReHRhRjFGeS90dmtoZmZTbzh1K2R3RzBF Z0poK3RlMzhnVGNJU1ZyMEdJUHBsTHo2WWhqcmJIclBSCkYxQ041VXVMOURCR2p4dU4zNVJM TlZFZnRhNlJVRmxSNk5jdFRqdnJBQkVCQUFHSkFpVUVHQUVDQUE4RkFreUEKY21RQ0d3d0ZD UkxNQXdBQUNna1E3WmZwRG1LcWZqU3JIQS8rS3pBS3ZUeFJoQTlNV05MeEl5SjdTNXVKMTZn cwpUM29DalpyQktHRWhLTU9HWDRPMEdBNlZPRXJ5TzdRUkNDWWFoM294U0czOElBbk5laXdK WGdVOUJ6a2s4NVVHCmJQRWQ3SEdGL1ZTZUhDUXdXb3U2anFVRFRTRHZuOVloTlRkRzBLWFBN NzRhQyt4cjJab3cxTzJtaFhpaGdXS0QKMER3KzBMWVBuVU9zUTBLT0Z4SFhYWUhtUnJTMU9a UFU1OUJMdmMrVFJoSWhhZlNIS0x3YlhLKzZja2t4Qng2aAo4ejVjY3BHMFFzNGJGaGRGWW5G ckVpZURMb0dtbkUyWUxoZFY2c3dKOVZOQ1M2cExpRW9oVDNmbTdhWG0xNXRaCk9JeXpNWmhI UlNBUGJsWHhRMFpTV2pxOG9ScmNZTkZ4YzRXMVVScEFrQkNPWUpvWHZRZkQ1TDNscUFsOFRD cUQKVXpZeGhIL3RKaGJEZEhycUhINzY3amFEYVRCMStUYWxwLzJBTUt3Y1hOT2Rpa2xHeGJt SFZHNllHbDZnOExyYgpzdTlOWkVJNHlMbEh6dWlrdGhKV2d6KzN2WmhWR3lObHQrSE5Jb0Y2 Q2pETDJvbXU1Y0VxNFJESE00NFFxUGs2Cmw3TzBwVXZOMW1UNEIrUzFiMDhSS3BxbS9mZjAx NUUzN0hOVi9waUl2Smx4R0FZejhQU2Z1R0NCMXRoTVlxbG0KZ2RoZDkvQmFiR0ZiR0dZSEE2 VTQvVDV6cVUrZjZ4SHkxU3NBUVoxTVNLbEx3ZWtCSVQrNC9jTFJHcUNIam5WMApxNUgvVDZh N3Q1bVBrYnpTck9MU280cHVqK0lUb05qWXlZSURCV3pobEExOWF2T2ErcnZVam1IdEQzc0ZO N2NYCld0a0dvaThidU5jYnk0VT0KPUFMNm8KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkgQkxP Q0stLS0tLQo= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 18 Jun 2020 22:39:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------9E2164FCDEBC59462D82D6F1" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41944-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------9E2164FCDEBC59462D82D6F1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Thanks, I'd forgotten that. The performance improvement is long overdue, so I installed the attached. --------------9E2164FCDEBC59462D82D6F1 Content-Type: text/x-patch; charset=UTF-8; name="0001-cp-default-to-COW.patch" Content-Disposition: attachment; filename="0001-cp-default-to-COW.patch" Content-Transfer-Encoding: quoted-printable >From 25725f9d41735d176d73a757430739fb71c7d043 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 18 Jun 2020 22:16:24 -0700 Subject: [PATCH] cp: default to COW MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Likewise for =E2=80=98install=E2=80=99. Proposed in Bug#24400, and long = past due. * NEWS: * doc/coreutils.texi (cp invocation): * src/copy.h (enum Reflink_type): Document this. * src/cp.c (cp_option_init): * src/install.c (cp_option_init): Implement this. --- NEWS | 2 ++ doc/coreutils.texi | 19 ++++++++++++------- src/copy.h | 4 ++-- src/cp.c | 2 +- src/install.c | 2 +- 5 files changed, 18 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index 8ddd0e22f..655ff779f 100644 --- a/NEWS +++ b/NEWS @@ -15,6 +15,8 @@ GNU coreutils NEWS -= *- outline -*- =20 ** Changes in behavior =20 + cp and install now default to copy-on-write (COW) if available. + On GNU/Linux systems, ls no longer issues an error message on directory merely because it was removed. This reverts a change that was made in release 8.32. diff --git a/doc/coreutils.texi b/doc/coreutils.texi index 3432fb294..4bbb960b7 100644 --- a/doc/coreutils.texi +++ b/doc/coreutils.texi @@ -8864,12 +8864,14 @@ The @var{when} value can be one of the following: =20 @table @samp @item always -The default behavior: if the copy-on-write operation is not supported +If the copy-on-write operation is not supported then report the failure for each file and exit with a failure status. +Plain @option{--reflink} is equivalent to @option{--reflink=3Dwhen}. =20 @item auto If the copy-on-write operation is not supported then fall back to the standard copy behavior. +This is the default if no @option{--reflink} option is given. =20 @item never Disable copy-on-write operation and use the standard copy behavior. @@ -8878,12 +8880,6 @@ Disable copy-on-write operation and use the standa= rd copy behavior. This option is overridden by the @option{--link}, @option{--symbolic-lin= k} and @option{--attributes-only} options, thus allowing it to be used to configure the default data copying behavior for @command{cp}. -For example, with the following alias, @command{cp} will use the -minimum amount of space supported by the file system. - -@example -alias cp=3D'cp --reflink=3Dauto --sparse=3Dalways' -@end example =20 @item --remove-destination @opindex --remove-destination @@ -8928,6 +8924,15 @@ This is useful in creating a file for use with the= @command{mkswap} command, since such a file must not have any holes. @end table =20 +For example, with the following alias, @command{cp} will use the +minimum amount of space supported by the file system. +(Older versions of @command{cp} can also benefit from +@option{--reflink=3Dauto} here.) + +@example +alias cp=3D'cp --sparse=3Dalways' +@end example + @optStripTrailingSlashes =20 @item -s diff --git a/src/copy.h b/src/copy.h index 874d6f71c..a0ad494b9 100644 --- a/src/copy.h +++ b/src/copy.h @@ -46,10 +46,10 @@ enum Sparse_type /* Control creation of COW files. */ enum Reflink_type { - /* Default to a standard copy. */ + /* Do a standard copy. */ REFLINK_NEVER, =20 - /* Try a COW copy and fall back to a standard copy. */ + /* Try a COW copy and fall back to a standard copy; this is the defaul= t. */ REFLINK_AUTO, =20 /* Require a COW copy and fail if not available. */ diff --git a/src/cp.c b/src/cp.c index 8db2c4b9e..a4ecbbc9f 100644 --- a/src/cp.c +++ b/src/cp.c @@ -793,7 +793,7 @@ cp_option_init (struct cp_options *x) x->move_mode =3D false; x->install_mode =3D false; x->one_file_system =3D false; - x->reflink_mode =3D REFLINK_NEVER; + x->reflink_mode =3D REFLINK_AUTO; =20 x->preserve_ownership =3D false; x->preserve_links =3D false; diff --git a/src/install.c b/src/install.c index 22124d51b..a94053f4d 100644 --- a/src/install.c +++ b/src/install.c @@ -264,7 +264,7 @@ cp_option_init (struct cp_options *x) { cp_options_default (x); x->copy_as_regular =3D true; - x->reflink_mode =3D REFLINK_NEVER; + x->reflink_mode =3D REFLINK_AUTO; x->dereference =3D DEREF_ALWAYS; x->unlink_dest_before_opening =3D true; x->unlink_dest_after_failed_open =3D false; --=20 2.17.1 --------------9E2164FCDEBC59462D82D6F1-- ------------=_1592545202-28447-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Jun 2020 01:55:01 +0000 Received: from localhost ([127.0.0.1]:54750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm6FB-0001jn-2y for submit@debbugs.gnu.org; Thu, 18 Jun 2020 21:55:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:58244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm6F8-0001jf-LB for submit@debbugs.gnu.org; Thu, 18 Jun 2020 21:54:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm6F8-0005kX-Cn for bug-coreutils@gnu.org; Thu, 18 Jun 2020 21:54:58 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:51755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jm6F6-0007GK-D8 for bug-coreutils@gnu.org; Thu, 18 Jun 2020 21:54:58 -0400 Received: by mail-wm1-x336.google.com with SMTP id b82so7007267wmb.1 for ; Thu, 18 Jun 2020 18:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=colorremedies-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=TUvssW0lxv46E+LLu8z1NDGvGKkK3RDOXngdewBkcaI=; b=StUrGkvnhmsOtUvAjG/qjGetFKhuBpKoZZTdkeZkwvbeJNEtfm+AjFlUuL3LnEEGsy 8ZeRaVPSFAW1pduzUiZJIjXGPGkVRo77dduCXXMpBA41b8HV66Gzzu/DltZnwwWF2hHh uRi172DV/fgBvf1EXQfzclSDThUXiNtvKMv9H9myxGStQqAjhjim4NQ8vEhJdsGmdMGX t5vMr0ZHZAmIVqlZf6Pw1y6kw2m6wBdguT2WK2FWZJvkVq4P5Lxnfh1TlCTpm7yhNJgq aI24DDJwi27Gm6w/l6tAE3HSOatpfJmJetHNzgKjBu7hWrQ05B2bxiPRCZKyhqd/1GSj LLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TUvssW0lxv46E+LLu8z1NDGvGKkK3RDOXngdewBkcaI=; b=h9wQ+vgSXAyg8f+PRuHlX7CHG9QQMfwoCvaT08gUJNsppcPSEY+vYnXV/zoNENbjcy xQbf+NUomfG1eJUwP+Jd/CGjYLCCH/2O1KS5upxeVWg5TMTzRaL/bK6KB0Jrc7sf4NWV 90dynZTsyP/NbiOvioKGxuK6Tetn+vLWZOUaXIiTs+mk2ZIG+++qoBuGSWhcz5G2LQzX GPo3MsMpLOQoPrKMjFUxBb6kjO5dZwDA12JWRPYojU3eQvW1342KaulWCOvJUbec6EsS usaHmmNS3g5QlPQrvqBr6lU2pTq9xrWwVeTVBJzxsYVqwy1ypCdDzFYY24xiSm4rzQAF VDYA== X-Gm-Message-State: AOAM5322OebpdOmFKaFj+/vzytX5/wA20LFSPT2J/4g5ot+xCG84KM3q c/V+57vRyGoRJ4tZAPMZWs3CGfmu0J+4TFieXxqwsZC5nYWXxQ== X-Google-Smtp-Source: ABdhPJzKetK7fkqcB4xbsDtZAy/PF19ApTIRf0SeMdTl77I2q0JvrmcpRKsuOf8OeqxegYsPwMOuh7ZwEyKXXG4SxRA= X-Received: by 2002:a7b:c2a9:: with SMTP id c9mr1155989wmk.11.1592531693959; Thu, 18 Jun 2020 18:54:53 -0700 (PDT) MIME-Version: 1.0 From: Chris Murphy Date: Thu, 18 Jun 2020 19:54:38 -0600 Message-ID: Subject: cp: default to --reflink=auto, revisted To: bug-coreutils@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=chris@colorremedies.com; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, The most recent discussion I found about this: https://lists.gnu.org/archive/html/bug-coreutils/2016-09/msg00015.html It's definitely currently never. https://github.com/coreutils/coreutils/blob/master/src/cp.c#L796 However for mv, it is used (which I understand it's a different thing, the optimization for cp+rm makes even more sense than for cp alone). https://github.com/coreutils/coreutils/blob/master/src/mv.c#L113 Thanks, -- Chris Murphy ------------=_1592545202-28447-1-- From unknown Sat Aug 16 19:17:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#24400: closed (Re: bug#41944: cp: default to --reflink=auto, revisted) Message-ID: References: <4c0ff2a7-d511-4e23-a0a4-c0591f1c053f@cs.ucla.edu> X-Gnu-PR-Message: they-closed 24400 X-Gnu-PR-Package: coreutils Reply-To: 24400@debbugs.gnu.org Date: Fri, 19 Jun 2020 05:40:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1592545202-28447-3" This is a multi-part message in MIME format... ------------=_1592545202-28447-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41944: cp: default to --reflink=3Dauto? which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24400@debbugs.gnu.org. --=20 41944: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41944 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1592545202-28447-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41944-done) by debbugs.gnu.org; 19 Jun 2020 05:39:23 +0000 Received: from localhost ([127.0.0.1]:54834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9kJ-0007Nt-9q for submit@debbugs.gnu.org; Fri, 19 Jun 2020 01:39:23 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9kE-0007Nd-5X for 41944-done@debbugs.gnu.org; Fri, 19 Jun 2020 01:39:22 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CDC391600E4; Thu, 18 Jun 2020 22:39:12 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6OkqYA3w1HIu; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CE0281600E9; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bjeZPk6P-jsX; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A3B0E1600E4; Thu, 18 Jun 2020 22:39:11 -0700 (PDT) Subject: Re: bug#41944: cp: default to --reflink=auto, revisted To: Chris Murphy , 41944-done@debbugs.gnu.org References: From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDUGdRVEFRSUFL QVVDVElCeQpaQUliQXdVSkVzd0RBQVlMQ1FnSEF3SUdGUWdDQ1FvTEJCWUNBd0VDSGdFQ0Y0 QUFDZ2tRN1pmcERtS3FmalJSCkd3LytJajAzZGhZZllsL2dYVlJpdXpWMWdHcmJIayt0bmZy SS9DN2ZBZW9GelE1dFZnVmluU2hhUGtabzBIVFAKZjE4eDZJREVkQWlPOE1xbzF5cDBDdEht ekdNQ0o1MG80R3JnZmpscjZnLyt2dEVPS2JobGVzek4yWHBKdnB3TQoyUWdHdm4vbGFUTFV1 OFBIOWFSV1RzN3FKSlpLS0tBYjRzeFljOTJGZWhQdTZGT0QwZERpeWhsREFxNGxPVjJtCmRC cHpRYmlvam9aelFMTVF3anBnQ1RLMjU3MmVLOUVPRVF5U1VUaFhyU0l6NkFTZW5wNE5ZVEZI czl0dUpRdlgKazlnWkRkUFNsM2JwKzQ3ZEd4bHhFV0xwQklNN3pJT053NGtzNGF6Z1Q4bnZE WnhBNUlaSHR2cUJsSkxCT2JZWQowTGU2MVdwMHkzVGxCRGgycWRLOGVZTDQyNlc0c2NFTVN1 aWc1Z2I4T0F0UWlCVzZrMnNHVXh4ZWl2OG92V3U4CllBWmdLSmZ1b1dJK3VSbk1FZGRydVk4 SnNvTTU0S2FLdlppa2tLczJiZzFuZHRMVnpIcEo2cUZaQzdRVmplSFUKaDYvQm1ndmRqV1Ba WUZUdE4rS0E5Q1dYM0dRS0tnTjN1dTk4OHl6bkQ3TG5COThUNEVVSDFIQS9HbmZCcU1WMQpn cHpUdlBjNHFWUWluQ21Ja0VGcDgzemwrRzVmQ2pKSjNXN2l2ekNuWW80S2hLTHBGVW05N29r VEtSMkxXM3haCnpFVzRjTFNXTzM4N01USzNDekRPeDVxZTZzNGE5MVp1Wk0vai9UUWRUTERh cU5uODNrQTRIcTQ4VUhYWXhjSWgKK05kOGsvM3c2bEZ1b0swd3JPRml5d2pMeCswdXI1am1t YmVjQkdIYzF4ZGhBRkc1QWcwRVRJQnlaQUVRQUthRgo2NzhUOXd5SDR3alRyVjFQejNjREVv U25WLzBaVXJPVDM3cDFkY0d5ai9JWHExeDY3MEhSVmFoQW1rMHNacFljCjI1UEY5RDVHUFlI RldsTmp1UFU5NnJEbmRYQjNoZWRtQlJoTGRDNGJBWGpJNERWK2JtZFZlK3EvSU1ubFpSYVYK bG05RWlNQ1ZBUjZ3MTNzUmV1N3FYa1c5cjNSd1kyQXpYc2twL3RBZTRCUktyMVptYnZpMm5i blE2ZXBFQzQycgpSYngwQjFFaGpiSVFaNUpIR2syNGlQVDdMZEJnbk5tb3M1d1lqendObGtN UUQ1VDBZZHpoazdKK1V4d0E1bTQ2Cm1PaFJEQzJyRlYvQTBnbTVUTHk4RFhqdi9Fc2M0Z1lu WWFpNlNRcW5VRVZoNUx1VjhZQ0pCbmlqcytUaXc3MXgKMWljbW42eEdJNDVFdWdKT2dlYyty THlwWWdwVnA0eDBISTVUODhxQlJZQ2t4SDNLZzhRbytFV05BOUE0TFJROQpEWDhuam9uYTBn ZjBzMDN0b2NLOGtCTjY2VW9xcVB0SEJuYzRlTWdCeW1DZmxLMTJlS2ZkMllZeG55ZzljWmF6 CldBNVZzbHZUeHBtNzZoYmc1b2lBRUgvVmcvOE14SHlBblBoZnJnd3lQcm1KRWNWQmFmZHNw Sm5ZUXhCWU5jbzIKTEZQSWhsT3ZXaDhyNGF0K3MrTTNMYjI2b1VUY3psZ2RXMVNmM1NEQTc3 Qk1SbkYwRlF5RSs3QXpWNzlNQk40eQpraXFhZXpReHRhRjFGeS90dmtoZmZTbzh1K2R3RzBF Z0poK3RlMzhnVGNJU1ZyMEdJUHBsTHo2WWhqcmJIclBSCkYxQ041VXVMOURCR2p4dU4zNVJM TlZFZnRhNlJVRmxSNk5jdFRqdnJBQkVCQUFHSkFpVUVHQUVDQUE4RkFreUEKY21RQ0d3d0ZD UkxNQXdBQUNna1E3WmZwRG1LcWZqU3JIQS8rS3pBS3ZUeFJoQTlNV05MeEl5SjdTNXVKMTZn cwpUM29DalpyQktHRWhLTU9HWDRPMEdBNlZPRXJ5TzdRUkNDWWFoM294U0czOElBbk5laXdK WGdVOUJ6a2s4NVVHCmJQRWQ3SEdGL1ZTZUhDUXdXb3U2anFVRFRTRHZuOVloTlRkRzBLWFBN NzRhQyt4cjJab3cxTzJtaFhpaGdXS0QKMER3KzBMWVBuVU9zUTBLT0Z4SFhYWUhtUnJTMU9a UFU1OUJMdmMrVFJoSWhhZlNIS0x3YlhLKzZja2t4Qng2aAo4ejVjY3BHMFFzNGJGaGRGWW5G ckVpZURMb0dtbkUyWUxoZFY2c3dKOVZOQ1M2cExpRW9oVDNmbTdhWG0xNXRaCk9JeXpNWmhI UlNBUGJsWHhRMFpTV2pxOG9ScmNZTkZ4YzRXMVVScEFrQkNPWUpvWHZRZkQ1TDNscUFsOFRD cUQKVXpZeGhIL3RKaGJEZEhycUhINzY3amFEYVRCMStUYWxwLzJBTUt3Y1hOT2Rpa2xHeGJt SFZHNllHbDZnOExyYgpzdTlOWkVJNHlMbEh6dWlrdGhKV2d6KzN2WmhWR3lObHQrSE5Jb0Y2 Q2pETDJvbXU1Y0VxNFJESE00NFFxUGs2Cmw3TzBwVXZOMW1UNEIrUzFiMDhSS3BxbS9mZjAx NUUzN0hOVi9waUl2Smx4R0FZejhQU2Z1R0NCMXRoTVlxbG0KZ2RoZDkvQmFiR0ZiR0dZSEE2 VTQvVDV6cVUrZjZ4SHkxU3NBUVoxTVNLbEx3ZWtCSVQrNC9jTFJHcUNIam5WMApxNUgvVDZh N3Q1bVBrYnpTck9MU280cHVqK0lUb05qWXlZSURCV3pobEExOWF2T2ErcnZVam1IdEQzc0ZO N2NYCld0a0dvaThidU5jYnk0VT0KPUFMNm8KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkgQkxP Q0stLS0tLQo= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 18 Jun 2020 22:39:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------9E2164FCDEBC59462D82D6F1" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41944-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------9E2164FCDEBC59462D82D6F1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Thanks, I'd forgotten that. The performance improvement is long overdue, so I installed the attached. --------------9E2164FCDEBC59462D82D6F1 Content-Type: text/x-patch; charset=UTF-8; name="0001-cp-default-to-COW.patch" Content-Disposition: attachment; filename="0001-cp-default-to-COW.patch" Content-Transfer-Encoding: quoted-printable >From 25725f9d41735d176d73a757430739fb71c7d043 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 18 Jun 2020 22:16:24 -0700 Subject: [PATCH] cp: default to COW MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Likewise for =E2=80=98install=E2=80=99. Proposed in Bug#24400, and long = past due. * NEWS: * doc/coreutils.texi (cp invocation): * src/copy.h (enum Reflink_type): Document this. * src/cp.c (cp_option_init): * src/install.c (cp_option_init): Implement this. --- NEWS | 2 ++ doc/coreutils.texi | 19 ++++++++++++------- src/copy.h | 4 ++-- src/cp.c | 2 +- src/install.c | 2 +- 5 files changed, 18 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index 8ddd0e22f..655ff779f 100644 --- a/NEWS +++ b/NEWS @@ -15,6 +15,8 @@ GNU coreutils NEWS -= *- outline -*- =20 ** Changes in behavior =20 + cp and install now default to copy-on-write (COW) if available. + On GNU/Linux systems, ls no longer issues an error message on directory merely because it was removed. This reverts a change that was made in release 8.32. diff --git a/doc/coreutils.texi b/doc/coreutils.texi index 3432fb294..4bbb960b7 100644 --- a/doc/coreutils.texi +++ b/doc/coreutils.texi @@ -8864,12 +8864,14 @@ The @var{when} value can be one of the following: =20 @table @samp @item always -The default behavior: if the copy-on-write operation is not supported +If the copy-on-write operation is not supported then report the failure for each file and exit with a failure status. +Plain @option{--reflink} is equivalent to @option{--reflink=3Dwhen}. =20 @item auto If the copy-on-write operation is not supported then fall back to the standard copy behavior. +This is the default if no @option{--reflink} option is given. =20 @item never Disable copy-on-write operation and use the standard copy behavior. @@ -8878,12 +8880,6 @@ Disable copy-on-write operation and use the standa= rd copy behavior. This option is overridden by the @option{--link}, @option{--symbolic-lin= k} and @option{--attributes-only} options, thus allowing it to be used to configure the default data copying behavior for @command{cp}. -For example, with the following alias, @command{cp} will use the -minimum amount of space supported by the file system. - -@example -alias cp=3D'cp --reflink=3Dauto --sparse=3Dalways' -@end example =20 @item --remove-destination @opindex --remove-destination @@ -8928,6 +8924,15 @@ This is useful in creating a file for use with the= @command{mkswap} command, since such a file must not have any holes. @end table =20 +For example, with the following alias, @command{cp} will use the +minimum amount of space supported by the file system. +(Older versions of @command{cp} can also benefit from +@option{--reflink=3Dauto} here.) + +@example +alias cp=3D'cp --sparse=3Dalways' +@end example + @optStripTrailingSlashes =20 @item -s diff --git a/src/copy.h b/src/copy.h index 874d6f71c..a0ad494b9 100644 --- a/src/copy.h +++ b/src/copy.h @@ -46,10 +46,10 @@ enum Sparse_type /* Control creation of COW files. */ enum Reflink_type { - /* Default to a standard copy. */ + /* Do a standard copy. */ REFLINK_NEVER, =20 - /* Try a COW copy and fall back to a standard copy. */ + /* Try a COW copy and fall back to a standard copy; this is the defaul= t. */ REFLINK_AUTO, =20 /* Require a COW copy and fail if not available. */ diff --git a/src/cp.c b/src/cp.c index 8db2c4b9e..a4ecbbc9f 100644 --- a/src/cp.c +++ b/src/cp.c @@ -793,7 +793,7 @@ cp_option_init (struct cp_options *x) x->move_mode =3D false; x->install_mode =3D false; x->one_file_system =3D false; - x->reflink_mode =3D REFLINK_NEVER; + x->reflink_mode =3D REFLINK_AUTO; =20 x->preserve_ownership =3D false; x->preserve_links =3D false; diff --git a/src/install.c b/src/install.c index 22124d51b..a94053f4d 100644 --- a/src/install.c +++ b/src/install.c @@ -264,7 +264,7 @@ cp_option_init (struct cp_options *x) { cp_options_default (x); x->copy_as_regular =3D true; - x->reflink_mode =3D REFLINK_NEVER; + x->reflink_mode =3D REFLINK_AUTO; x->dereference =3D DEREF_ALWAYS; x->unlink_dest_before_opening =3D true; x->unlink_dest_after_failed_open =3D false; --=20 2.17.1 --------------9E2164FCDEBC59462D82D6F1-- ------------=_1592545202-28447-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Sep 2016 22:54:49 +0000 Received: from localhost ([127.0.0.1]:54976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biUh7-0005Yx-2y for submit@debbugs.gnu.org; Fri, 09 Sep 2016 18:54:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biUh5-0005Yl-Ck for submit@debbugs.gnu.org; Fri, 09 Sep 2016 18:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biUgz-0001s1-Hw for submit@debbugs.gnu.org; Fri, 09 Sep 2016 18:54:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biUgz-0001re-EV for submit@debbugs.gnu.org; Fri, 09 Sep 2016 18:54:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biUgx-0002ku-Bf for bug-coreutils@gnu.org; Fri, 09 Sep 2016 18:54:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biUgt-0001pq-9v for bug-coreutils@gnu.org; Fri, 09 Sep 2016 18:54:38 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biUgt-0001pl-3x for bug-coreutils@gnu.org; Fri, 09 Sep 2016 18:54:35 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A12A4160195 for ; Fri, 9 Sep 2016 15:54:33 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id F7QJ4D4wFylt for ; Fri, 9 Sep 2016 15:54:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F27A116123D for ; Fri, 9 Sep 2016 15:54:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ktkGrcx1F3c8 for ; Fri, 9 Sep 2016 15:54:32 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DB8E0160195 for ; Fri, 9 Sep 2016 15:54:32 -0700 (PDT) To: bug-coreutils@gnu.org From: Paul Eggert Subject: cp: default to --reflink=auto? Organization: UCLA Computer Science Department Message-ID: <4c0ff2a7-d511-4e23-a0a4-c0591f1c053f@cs.ucla.edu> Date: Fri, 9 Sep 2016 15:54:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Currently 'cp' defaults to not using reflinks, which can be significantly slower on a system that supports file cloning. I expect most users would prefer 'cp' to default to --reflink=auto for spped. Although there are some special cases otherwise, on balance how about if we change cp to default to --reflink=auto, and add an option --reflink=no for users who prefer the current default? ------------=_1592545202-28447-3--