From unknown Wed Sep 10 18:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41914: [PATCH] Propagate return value of auto-loaded command Resent-From: Tom de Vries Original-Sender: "Debbugs-submit" Resent-CC: bug-dejagnu@gnu.org Resent-Date: Wed, 17 Jun 2020 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41914 X-GNU-PR-Package: dejagnu X-GNU-PR-Keywords: patch To: 41914@debbugs.gnu.org X-Debbugs-Original-To: bug-dejagnu@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159239405219490 (code B ref -1); Wed, 17 Jun 2020 11:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Jun 2020 11:40:52 +0000 Received: from localhost ([127.0.0.1]:50561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlWR2-00054I-8p for submit@debbugs.gnu.org; Wed, 17 Jun 2020 07:40:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:55514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlWQz-00054A-Ih for submit@debbugs.gnu.org; Wed, 17 Jun 2020 07:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlWQz-000337-9R for bug-dejagnu@gnu.org; Wed, 17 Jun 2020 07:40:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:37410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlWQw-0002iH-2d for bug-dejagnu@gnu.org; Wed, 17 Jun 2020 07:40:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 55194AE0B for ; Wed, 17 Jun 2020 11:40:45 +0000 (UTC) From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <570aeadb-09d1-8649-c361-9581dc343561@suse.de> Date: Wed, 17 Jun 2020 13:40:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------31F68298E5B2B743F1ED0E03" Content-Language: en-US Received-SPF: pass client-ip=195.135.220.15; envelope-from=tdevries@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 00:06:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------31F68298E5B2B743F1ED0E03 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, I think I found a bug in proc unknown in lib/framework.exp. Patch describing the problem and fixing it attached below. Thanks, - Tom --------------31F68298E5B2B743F1ED0E03 Content-Type: text/x-patch; charset=UTF-8; name="0001-Propagate-return-value-of-auto-loaded-command.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Propagate-return-value-of-auto-loaded-command.patch" Propagate return value of auto-loaded command Consider a library file foo.tcl: ... $ cat lib/foo.tcl proc foo { } { return "foo-return" } ... and a test-case test.tcl: ... $ cat test.tcl \#!/usr/bin/tclsh auto_mkindex lib *.tcl lappend auto_path [pwd]/lib set res [foo] puts "RES: $res" ... which gives us: ... $ ./test.tcl RES: foo-return ... When overriding the ::unknown command using: ... rename ::unknown ::tcl_unknown proc unknown args { if {[catch {uplevel 1 ::tcl_unknown $args} msg]} { puts "ERROR: proc \"$args\" does not exist." exit } } ... we have instead: ... $ ./test.tcl RES: ... What is missing, is the propagation of the return value of foo, like this: ... puts "ERROR: proc \"$args\" does not exist." exit } -} +} else { + return $msg +} ... Fix unknown in lib/framework.exp accordingly. ChangeLog: 2020-06-17 Tom de Vries * lib/framework.exp (unknown): Propagate return value of auto-loaded command. --- lib/framework.exp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/framework.exp b/lib/framework.exp index e6ce197..c9875d2 100644 --- a/lib/framework.exp +++ b/lib/framework.exp @@ -272,6 +272,9 @@ proc unknown args { } set exit_status 2 log_and_exit + } else { + # Propagate return value. + return $msg } } --------------31F68298E5B2B743F1ED0E03-- From unknown Wed Sep 10 18:55:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tom de Vries Subject: bug#41914: closed (Re: bug#41914: [PATCH] Propagate return value of auto-loaded command) Message-ID: References: <5EEAA4E7.30001@gmail.com> <570aeadb-09d1-8649-c361-9581dc343561@suse.de> X-Gnu-PR-Message: they-closed 41914 X-Gnu-PR-Package: dejagnu X-Gnu-PR-Keywords: patch Reply-To: 41914@debbugs.gnu.org Date: Wed, 17 Jun 2020 23:20:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1592436003-6297-1" This is a multi-part message in MIME format... ------------=_1592436003-6297-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41914: [PATCH] Propagate return value of auto-loaded command which was filed against the dejagnu package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 41914@debbugs.gnu.org. --=20 41914: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41914 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1592436003-6297-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41914-done) by debbugs.gnu.org; 17 Jun 2020 23:19:26 +0000 Received: from localhost ([127.0.0.1]:52406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhKp-0001c1-Oc for submit@debbugs.gnu.org; Wed, 17 Jun 2020 19:19:26 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:44334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhKp-0001bq-61 for 41914-done@debbugs.gnu.org; Wed, 17 Jun 2020 19:19:11 -0400 Received: by mail-ot1-f52.google.com with SMTP id e5so3049940ote.11 for <41914-done@debbugs.gnu.org>; Wed, 17 Jun 2020 16:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=LkDtweu4HNFJshailx5j31OErcpCCDDw2uE+3J1OXtE=; b=JtS5BkqI7LBV8RmNZqHbD7ULJ4cBWKg/fus/mHI7dsgqHh0ZEcBoVVEO7Wf2efIOmi WwGqdu1ZojXvPp37tt8Iq/TFZrH75/aI7z10wV6MQLlsS3DIPmwIER/mERKKZTxcf+E6 8dHjNV+T78IXfHe0NRyI4IOl5A+6+cshhIl9/6l+kskzSRGLRiHbwOTzonuyt4h+S13x Xj0WLupL4CEE2/HxgjH0MMMbVvXu5jaKAAdm+PDY+udBRHRy7WdWhdFCjEo9PGbP6Uef zJlSeeMH+NcjtoAYTpQwiuy0UI+rUKO+Ah1L2WOcLdWnmk3rkaLh/hkxRWCdI0uz8HwI 4OiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:reply-to:user-agent :mime-version:to:cc:subject:references:in-reply-to :content-transfer-encoding; bh=LkDtweu4HNFJshailx5j31OErcpCCDDw2uE+3J1OXtE=; b=HNpJ0lg60bXNMB0o+95WDQE0hnBTt62pasEnYJ8TpDJYG89vahjPm4PR/91mYAlsyY oA1e1pTWwXp0r+1JSh9MLgslcrJXUvayQzX6OkRXRnqFJ3xbtC5AKE1ISpVutsAAPcdP 9uvyIMEBs2/TaEbJekpTf7oCzWmw3xWydmNtzvbOhnWuIs+3hdD8E2xRSgdWMIO8aghA rN8XNZgaoNnefZNymQXJCWk8l4dgdtUETodS+VXR7rkxT+8kGB+6HGqppRHEJj8Riu4D E1zgWMjcJPIkZvzsOK+XU4IBM/QZDdqdhfGoPm5DJuFGT+NQTRbMFv3WVzEK2t3GPGsE HWjQ== X-Gm-Message-State: AOAM530igT0Ub0c1hrdN1JGYRA+5fJiWIcsKwY3ZPG60UMtsFxCP4JWf ZO3vKrxKRhCbP9Y4L8soVE0= X-Google-Smtp-Source: ABdhPJy2Koebmnltpy0RVaAjVk0Q6UjAQQ/3y3VTuWIZkA2scjSbzkpXdKS4czB9iKX1+nl8D+iBug== X-Received: by 2002:a05:6830:1e61:: with SMTP id m1mr1156393otr.42.1592435945635; Wed, 17 Jun 2020 16:19:05 -0700 (PDT) Received: from [192.168.2.42] (adsl-70-133-145-204.dsl.ablntx.sbcglobal.net. [70.133.145.204]) by smtp.gmail.com with ESMTPSA id t18sm327202otk.42.2020.06.17.16.19.04 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Jun 2020 16:19:05 -0700 (PDT) Message-ID: <5EEAA4E7.30001@gmail.com> Date: Wed, 17 Jun 2020 18:19:03 -0500 From: Jacob Bachmeyer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0 MIME-Version: 1.0 To: Tom de Vries Subject: Re: bug#41914: [PATCH] Propagate return value of auto-loaded command References: <570aeadb-09d1-8649-c361-9581dc343561@suse.de> In-Reply-To: <570aeadb-09d1-8649-c361-9581dc343561@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41914-done Cc: 41914-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jcb62281@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Tom de Vries wrote: > I think I found a bug in proc unknown in lib/framework.exp. > > Patch describing the problem and fixing it attached below. > I found and fixed the same bug while working on the patch for bug #41824. -- Jacob ------------=_1592436003-6297-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Jun 2020 11:40:52 +0000 Received: from localhost ([127.0.0.1]:50561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlWR2-00054I-8p for submit@debbugs.gnu.org; Wed, 17 Jun 2020 07:40:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:55514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlWQz-00054A-Ih for submit@debbugs.gnu.org; Wed, 17 Jun 2020 07:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlWQz-000337-9R for bug-dejagnu@gnu.org; Wed, 17 Jun 2020 07:40:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:37410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlWQw-0002iH-2d for bug-dejagnu@gnu.org; Wed, 17 Jun 2020 07:40:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 55194AE0B for ; Wed, 17 Jun 2020 11:40:45 +0000 (UTC) To: bug-dejagnu@gnu.org From: Tom de Vries Subject: [PATCH] Propagate return value of auto-loaded command Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <570aeadb-09d1-8649-c361-9581dc343561@suse.de> Date: Wed, 17 Jun 2020 13:40:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------31F68298E5B2B743F1ED0E03" Content-Language: en-US Received-SPF: pass client-ip=195.135.220.15; envelope-from=tdevries@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 00:06:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------31F68298E5B2B743F1ED0E03 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, I think I found a bug in proc unknown in lib/framework.exp. Patch describing the problem and fixing it attached below. Thanks, - Tom --------------31F68298E5B2B743F1ED0E03 Content-Type: text/x-patch; charset=UTF-8; name="0001-Propagate-return-value-of-auto-loaded-command.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Propagate-return-value-of-auto-loaded-command.patch" Propagate return value of auto-loaded command Consider a library file foo.tcl: ... $ cat lib/foo.tcl proc foo { } { return "foo-return" } ... and a test-case test.tcl: ... $ cat test.tcl \#!/usr/bin/tclsh auto_mkindex lib *.tcl lappend auto_path [pwd]/lib set res [foo] puts "RES: $res" ... which gives us: ... $ ./test.tcl RES: foo-return ... When overriding the ::unknown command using: ... rename ::unknown ::tcl_unknown proc unknown args { if {[catch {uplevel 1 ::tcl_unknown $args} msg]} { puts "ERROR: proc \"$args\" does not exist." exit } } ... we have instead: ... $ ./test.tcl RES: ... What is missing, is the propagation of the return value of foo, like this: ... puts "ERROR: proc \"$args\" does not exist." exit } -} +} else { + return $msg +} ... Fix unknown in lib/framework.exp accordingly. ChangeLog: 2020-06-17 Tom de Vries * lib/framework.exp (unknown): Propagate return value of auto-loaded command. --- lib/framework.exp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/framework.exp b/lib/framework.exp index e6ce197..c9875d2 100644 --- a/lib/framework.exp +++ b/lib/framework.exp @@ -272,6 +272,9 @@ proc unknown args { } set exit_status 2 log_and_exit + } else { + # Propagate return value. + return $msg } } --------------31F68298E5B2B743F1ED0E03-- ------------=_1592436003-6297-1-- From unknown Wed Sep 10 18:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41914: closed (Re: bug#41914: [PATCH] Propagate return value of auto-loaded command) Resent-From: Tom de Vries Original-Sender: "Debbugs-submit" Resent-CC: bug-dejagnu@gnu.org Resent-Date: Thu, 18 Jun 2020 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41914 X-GNU-PR-Package: dejagnu X-GNU-PR-Keywords: patch To: 41914@debbugs.gnu.org Received: via spool by 41914-submit@debbugs.gnu.org id=B41914.159246602120739 (code B ref 41914); Thu, 18 Jun 2020 07:41:02 +0000 Received: (at 41914) by debbugs.gnu.org; 18 Jun 2020 07:40:21 +0000 Received: from localhost ([127.0.0.1]:52712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlp9o-0005OR-V0 for submit@debbugs.gnu.org; Thu, 18 Jun 2020 03:40:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:55962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlp9l-0005O8-VD for 41914@debbugs.gnu.org; Thu, 18 Jun 2020 03:40:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4F40DADA3 for <41914@debbugs.gnu.org>; Thu, 18 Jun 2020 07:40:10 +0000 (UTC) References: <5EEAA4E7.30001@gmail.com> <570aeadb-09d1-8649-c361-9581dc343561@suse.de> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <5fe2cd41-882b-8949-f933-3bce2d00e60c@suse.de> Date: Thu, 18 Jun 2020 09:40:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 6/18/20 1:20 AM, GNU bug Tracking System wrote: > Your bug report > > #41914: [PATCH] Propagate return value of auto-loaded command > > which was filed against the dejagnu package, has been closed. > > The explanation is attached below, along with your original report. > If you require more details, please reply to 41914@debbugs.gnu.org. > AFAICT, no fix was committed to master. So, I'm not sure I understand why this bug was closed. Thanks, - Tom From unknown Wed Sep 10 18:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41914: closed (Re: bug#41914: [PATCH] Propagate return value of auto-loaded command) Resent-From: Jacob Bachmeyer Original-Sender: "Debbugs-submit" Resent-CC: bug-dejagnu@gnu.org Resent-Date: Thu, 18 Jun 2020 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41914 X-GNU-PR-Package: dejagnu X-GNU-PR-Keywords: patch To: Tom de Vries Cc: 41914-done@debbugs.gnu.org Reply-To: jcb62281@gmail.com Received: via spool by 41914-done@debbugs.gnu.org id=D41914.159251704015620 (code D ref 41914); Thu, 18 Jun 2020 21:51:01 +0000 Received: (at 41914-done) by debbugs.gnu.org; 18 Jun 2020 21:50:40 +0000 Received: from localhost ([127.0.0.1]:54536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm2Qh-00043r-MM for submit@debbugs.gnu.org; Thu, 18 Jun 2020 17:50:39 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:37835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm2Qg-00043f-Hb for 41914-done@debbugs.gnu.org; Thu, 18 Jun 2020 17:50:38 -0400 Received: by mail-ot1-f67.google.com with SMTP id v13so5780705otp.4 for <41914-done@debbugs.gnu.org>; Thu, 18 Jun 2020 14:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=ySBU1EmNJOgPOX2HskHcQNI7JrjZyKARaeOiSIfljMA=; b=X8Z2QLIXKpTRiENw6nuenghMTHlhk0dz9ecgWEymqrq9RxZBIuPro9lyUc8YbPJTo5 jnFeIVS2NcD71+A31yYRKlO95kTpkhBmWxKUZtLzumSBc+RhRFczfImWHHxaylCVAeQa vhGzneAk6c4Q/MLz/bc1mbpPq9DgLTISRgA07jhZ9YLULtvmRbZFoqcLrFkv9S1rZRvX b1LwI01M/1e9zxxAwlCY8LqQXCIEE3d0ptNAwxsudr/HRIMbYDR3rjK75TuB434QQnbx CC5LobbRQdFE1zqBuC0vUZh31YiZXCOjo/Th4FU793duGiIGenkwHjsGMhnGTXMbGB+e gI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:reply-to:user-agent :mime-version:to:cc:subject:references:in-reply-to :content-transfer-encoding; bh=ySBU1EmNJOgPOX2HskHcQNI7JrjZyKARaeOiSIfljMA=; b=mEqKA422z9enYstYNty0zmBogFQ1fE+7Z52IQK6t+1JQmc9lpctuy3D4P44PLuvsMB MoMEI5GNM69mINuh9qb/3+0oefjbEU77t9UA06iP9Elt78vu8kiEspPG6SsePSz26C1C 7ZhyS7knVxC5H46T6oVLVKQTmy9CpXpzW9VqHNHeXwuS+/QaQzqO16xXSwEhX7rBvHzI 5owAnPDeNdYjXd/ZZx01nGPFWrlTdpkuC/MOl2r+Tf5DDDm1QT5n/NXU6BOa9HWYCRjO +v84dBtvPKykCVjpVQ82UNg83uZc3qCtZVzD7oCq4hOJ2Rq3JcP0C4KZr5FMF+UJCu7o KY5Q== X-Gm-Message-State: AOAM533al2yuaihy+qa8Bo+AA8wHmXnh0PxaS5pGa2+7+pJsszAapZM7 nHzEtL+Qcm4UaedxzAU9eso= X-Google-Smtp-Source: ABdhPJwT6Tv0rtvwO4u4OFdZ9cow1ieamXO5dzLFYCIAhE+MgdnjRzLGnbWe+7y/WqD3UVtopNHqIg== X-Received: by 2002:a9d:67ce:: with SMTP id c14mr633493otn.337.1592517032722; Thu, 18 Jun 2020 14:50:32 -0700 (PDT) Received: from [192.168.2.42] (adsl-70-133-145-204.dsl.ablntx.sbcglobal.net. [70.133.145.204]) by smtp.gmail.com with ESMTPSA id h187sm908095oib.7.2020.06.18.14.50.31 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Jun 2020 14:50:32 -0700 (PDT) Message-ID: <5EEBE1A6.8020209@gmail.com> Date: Thu, 18 Jun 2020 16:50:30 -0500 From: Jacob Bachmeyer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0 MIME-Version: 1.0 References: <5EEAA4E7.30001@gmail.com> <570aeadb-09d1-8649-c361-9581dc343561@suse.de> <5fe2cd41-882b-8949-f933-3bce2d00e60c@suse.de> In-Reply-To: <5fe2cd41-882b-8949-f933-3bce2d00e60c@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Tom de Vries wrote: > On 6/18/20 1:20 AM, GNU bug Tracking System wrote: > >> Your bug report >> >> #41914: [PATCH] Propagate return value of auto-loaded command >> >> which was filed against the dejagnu package, has been closed. >> >> The explanation is attached below, along with your original report. >> If you require more details, please reply to 41914@debbugs.gnu.org. >> >> > > AFAICT, no fix was committed to master. So, I'm not sure I understand > why this bug was closed. It was closed because a fix had been rolled into the fix for #41824. Linus' Law applied here: we both found the same bug and actually fixed it the same way. I merged the comment and ChangeLog entry from your patch into the temporary "PR41824" branch. Is there a better way to record this circumstance in debbugs than closing the second bug? -- Jacob From unknown Wed Sep 10 18:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41914: closed (Re: bug#41914: [PATCH] Propagate return value of auto-loaded command) Resent-From: Tom de Vries Original-Sender: "Debbugs-submit" Resent-CC: bug-dejagnu@gnu.org Resent-Date: Fri, 19 Jun 2020 12:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41914 X-GNU-PR-Package: dejagnu X-GNU-PR-Keywords: patch To: jcb62281@gmail.com Cc: 41914-done@debbugs.gnu.org Received: via spool by 41914-done@debbugs.gnu.org id=D41914.159257141121357 (code D ref 41914); Fri, 19 Jun 2020 12:57:01 +0000 Received: (at 41914-done) by debbugs.gnu.org; 19 Jun 2020 12:56:51 +0000 Received: from localhost ([127.0.0.1]:55393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmGZf-0005YP-9A for submit@debbugs.gnu.org; Fri, 19 Jun 2020 08:56:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:34432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmGZc-0005YA-P4 for 41914-done@debbugs.gnu.org; Fri, 19 Jun 2020 08:56:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1CC1EACA3; Fri, 19 Jun 2020 12:56:41 +0000 (UTC) References: <5EEAA4E7.30001@gmail.com> <570aeadb-09d1-8649-c361-9581dc343561@suse.de> <5fe2cd41-882b-8949-f933-3bce2d00e60c@suse.de> <5EEBE1A6.8020209@gmail.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <906125bf-25d2-acd4-0808-b9d20d4ed372@suse.de> Date: Fri, 19 Jun 2020 14:56:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <5EEBE1A6.8020209@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 6/18/20 11:50 PM, Jacob Bachmeyer wrote: > Tom de Vries wrote: >> On 6/18/20 1:20 AM, GNU bug Tracking System wrote: >>   >>> Your bug report >>> >>> #41914: [PATCH] Propagate return value of auto-loaded command >>> >>> which was filed against the dejagnu package, has been closed. >>> >>> The explanation is attached below, along with your original report. >>> If you require more details, please reply to 41914@debbugs.gnu.org. >>> >>>     >> >> AFAICT, no fix was committed to master. So, I'm not sure I understand >> why this bug was closed. > > It was closed because a fix had been rolled into the fix for #41824.  > Linus' Law applied here:  we both found the same bug and actually fixed > it the same way.  I merged the comment and ChangeLog entry from your > patch into the temporary "PR41824" branch. > > Is there a better way to record this circumstance in debbugs than > closing the second bug? Well, in my understanding, yes, by: - mentioning the circumstance without closing the bug, and - closing the bug once the fix is present on master. It's just that in all projects I worked in, this practice is adhered to, with the specific purpose of being able to track problems to completion. Of course, if the dejagnu project doesn't adhere to this, I have no issues with that. I just asked the question because I was surprised. Thanks, - Tom From unknown Wed Sep 10 18:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41914: closed (Re: bug#41914: [PATCH] Propagate return value of auto-loaded command) Resent-From: Jacob Bachmeyer Original-Sender: "Debbugs-submit" Resent-CC: bug-dejagnu@gnu.org Resent-Date: Sat, 20 Jun 2020 00:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41914 X-GNU-PR-Package: dejagnu X-GNU-PR-Keywords: patch To: Tom de Vries Cc: 41914-done@debbugs.gnu.org Reply-To: jcb62281@gmail.com Received: via spool by 41914-done@debbugs.gnu.org id=D41914.159261163212020 (code D ref 41914); Sat, 20 Jun 2020 00:08:01 +0000 Received: (at 41914-done) by debbugs.gnu.org; 20 Jun 2020 00:07:12 +0000 Received: from localhost ([127.0.0.1]:57034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmR2O-00037o-FW for submit@debbugs.gnu.org; Fri, 19 Jun 2020 20:07:12 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:46914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmR2M-00037a-3X for 41914-done@debbugs.gnu.org; Fri, 19 Jun 2020 20:07:10 -0400 Received: by mail-ot1-f66.google.com with SMTP id g7so8596230oti.13 for <41914-done@debbugs.gnu.org>; Fri, 19 Jun 2020 17:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=zlbMt8ThfUYBTyML/bmuvzCG1yM1ZWq9h5sx68q7BZQ=; b=eMo8QoasiYFPl8C9ydU+nCBdL9VMSO1QLu79C6uRHFrOn2aH9EgCyAbKlmZen/Ce6X 0I8oSTTJMOBE0XbjfJi5ejUTm8lVhwBDGT4WuiFaSZeaTs8GqRlbrEfDmzdtB8ir2pZq GmbfcMpFwak4ssv9ox2p42ipSEVs8vUw7bKeVvP8jQ0QkAR1Zka2E8ggGEFDJpsgij/9 odqaEWThHNkv5yoO31I6Q+2inRw3N0LZ2Ty4dt/5wbYbZ1LILdO3ev6rlNxjOfUzZ7nY mLtbz9YK4MWlHZvW4l4vIGmEXoXGucMhIPy9fwk4quhbeZUcdu9RwWR0D/KyYO6VeyrB lrDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:reply-to:user-agent :mime-version:to:cc:subject:references:in-reply-to :content-transfer-encoding; bh=zlbMt8ThfUYBTyML/bmuvzCG1yM1ZWq9h5sx68q7BZQ=; b=qVQ8vz96QaTG93Fbj7LWYdIoA4qTwlBIThnG8lN0I9PQHrOT7u5PkRjlbxwWg834HR 58/4gUYlYP8TT24SlNuKNiHNQyDDt/uCduYvISve/PIlLSg/pHm4Wos6oN48hA4kzPnP kiLYgbTnqjURaPLkCotmulCeCf0Y5CTiCzyvEHeJrqDJu8+BkQYYsHszQkGBRqHXQhDz uka9hnYsSSDdP5rZykRbBpEPA+xnoGYSPn7vszI1c7XUTvhDI9HvSaJwXqMA+RS/+t35 8QjogTmP/xTwyomnQx52UZooYrGPpfDBE+D/Pi4wNPwV92KzowMehQnnF6ealPSSnsFk MPxg== X-Gm-Message-State: AOAM530GZKPppERfbcSPAPolgzS+EH3uM/18jK3Xv95Ol5jN4uRDcHPU zoTiINA8hD/93YQ0IGPVt8Q= X-Google-Smtp-Source: ABdhPJwfFd5lpmrD3lOh7Q3sIuTx+kcQS5pWWJ3JyLb4C+3yfiZbX/o1aDssqdHCi/8MkZ2PVyf9ow== X-Received: by 2002:a9d:615d:: with SMTP id c29mr5044025otk.56.1592611624427; Fri, 19 Jun 2020 17:07:04 -0700 (PDT) Received: from [192.168.2.42] (adsl-70-133-145-204.dsl.ablntx.sbcglobal.net. [70.133.145.204]) by smtp.gmail.com with ESMTPSA id i72sm1585295oib.28.2020.06.19.17.07.03 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Jun 2020 17:07:03 -0700 (PDT) Message-ID: <5EED5326.4030003@gmail.com> Date: Fri, 19 Jun 2020 19:07:02 -0500 From: Jacob Bachmeyer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0 MIME-Version: 1.0 References: <5EEAA4E7.30001@gmail.com> <570aeadb-09d1-8649-c361-9581dc343561@suse.de> <5fe2cd41-882b-8949-f933-3bce2d00e60c@suse.de> <5EEBE1A6.8020209@gmail.com> <906125bf-25d2-acd4-0808-b9d20d4ed372@suse.de> In-Reply-To: <906125bf-25d2-acd4-0808-b9d20d4ed372@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Tom de Vries wrote: > On 6/18/20 11:50 PM, Jacob Bachmeyer wrote: > >> Tom de Vries wrote: >> >>> On 6/18/20 1:20 AM, GNU bug Tracking System wrote: >>> >>> >>>> Your bug report >>>> >>>> #41914: [PATCH] Propagate return value of auto-loaded command >>>> >>>> which was filed against the dejagnu package, has been closed. >>>> >>>> The explanation is attached below, along with your original report. >>>> If you require more details, please reply to 41914@debbugs.gnu.org. >>>> >>>> >>>> >>> AFAICT, no fix was committed to master. So, I'm not sure I understand >>> why this bug was closed. >>> >> It was closed because a fix had been rolled into the fix for #41824. >> Linus' Law applied here: we both found the same bug and actually fixed >> it the same way. I merged the comment and ChangeLog entry from your >> patch into the temporary "PR41824" branch. >> >> Is there a better way to record this circumstance in debbugs than >> closing the second bug? >> > > Well, in my understanding, yes, by: > - mentioning the circumstance without closing the bug, and > - closing the bug once the fix is present on master. > > It's just that in all projects I worked in, this practice is adhered to, > with the specific purpose of being able to track problems to completion. > > Of course, if the dejagnu project doesn't adhere to this, I have no > issues with that. I just asked the question because I was surprised. > Fair enough; I am new to package maintenance and probably closed the bug earlier than needed. The fix is definitely going into 1.6.3, but I was not aware of a convention of holding bugs open until the patches have landed on master. I will try to do better in the future. -- Jacob From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 01 01:28:37 2020 Received: (at control) by debbugs.gnu.org; 1 Jul 2020 05:28:37 +0000 Received: from localhost ([127.0.0.1]:52162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqVIS-00024e-TI for submit@debbugs.gnu.org; Wed, 01 Jul 2020 01:28:37 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:43512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqVIR-00024Q-03 for control@debbugs.gnu.org; Wed, 01 Jul 2020 01:28:36 -0400 Received: by mail-ot1-f45.google.com with SMTP id 95so9852306otw.10 for ; Tue, 30 Jun 2020 22:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :content-transfer-encoding; bh=4EpVLw8ApRIgmuMd8GdjizheBauVryWsf2iJbiFEgJE=; b=SSLU+P7eOG4Ghhoe2GfpB08tf2pcSGXh+MQQFSkQOFdVeWmQxnI7yhJ/Ewf4a7N44e ouA+f4t5c8x0C+Pn67FbBzPYobPA7yP1as0b8xCvqnbWQSR+HH4PjdGdVlp10rby2Ovu YxYiTkpbg90ORtpx8rNBPwG8hxbzR8RSBrZeA/SqFA5kugRmB5ZJyHt+y38rtLKSUYrV 7xFoeq4cLjbSbkRmpBtCvybFYTmzNERQZlh86gbsy0Yb6FbKQ0NBPNkzd4V2brmybyxk b+YcMMGBUrQCjeGCEKHfnAMvMEAgymms7N5K3hV03rValElThapW70PF6iKRVOuYdp4E db1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:reply-to:user-agent :mime-version:to:subject:content-transfer-encoding; bh=4EpVLw8ApRIgmuMd8GdjizheBauVryWsf2iJbiFEgJE=; b=GEyY372UN2fdPlZm1lUbRSQrxUKP4GQpmNTD32sRJDGSZL+54TDBsvhVlXRVCU63AN 3q0OtZxIH21/QJUrZ36gA4wdJNkOG66HYv9JaAx4SRltD6j6LnPfAstzxkoJZSwyFd9e G0RarUsTXzYi5NgweBa+6IvxGhdE2k6IfgxojTLjLe3Acevv1dLdJWq1BDT+C9cHtupd QRYcUMYkg/CRzgepquAVusYmbtwK9oMRqTISI8nPU0g85az4WQh6U97MwynHGQ38l9XQ DBixvek+vp6jTBgTPWmsl7yW4ZBG/6XC5BhFIIiovADXFBKmPritaqLV6PL12jNpTB2w SDLA== X-Gm-Message-State: AOAM533fOK2/hs+c6elNU6rB+wvdyrxSctb3BxMbGEyoijUEENuiCwMs UHey+nqaHdZ+Rh44TENcSIbNYaRM X-Google-Smtp-Source: ABdhPJxDCPWG7N2frWWhuKbhi5YMr/L5+Ky1Gz9ynU/k2av8nOKp+IHe4tgiiR3G1cOsc8ZcA76+bQ== X-Received: by 2002:a9d:7c3:: with SMTP id 61mr9393185oto.110.1593581308804; Tue, 30 Jun 2020 22:28:28 -0700 (PDT) Received: from [192.168.2.42] (adsl-70-133-144-251.dsl.ablntx.sbcglobal.net. [70.133.144.251]) by smtp.gmail.com with ESMTPSA id 41sm1263412otg.80.2020.06.30.22.28.27 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jun 2020 22:28:28 -0700 (PDT) Message-ID: <5EFC1EFB.70108@gmail.com> Date: Wed, 01 Jul 2020 00:28:27 -0500 From: Jacob Bachmeyer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0 MIME-Version: 1.0 To: GNU bug tracker automated control server Subject: bug administrivia 2020-06-30 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jcb62281@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) package dejagnu # Rob fixed it before I could get CVS set up owner 41823 rob@senecass.com # have patched these; waiting for patches to land on master owner 41914 ! owner 41918 ! send-detail 41823 send-detail 41914 thanks