GNU bug report logs - #41897
28.0.50; JavaScript comment filling with mhtml-mode

Previous Next

Package: emacs;

Reported by: Simen Heggestøyl <simenheg <at> runbox.com>

Date: Tue, 16 Jun 2020 17:10:01 UTC

Severity: normal

Found in version 28.0.50

Done: Alan Mackenzie <acm <at> muc.de>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> runbox.com>
Subject: bug#41897: closed (Re: bug#41897: 28.0.50; JavaScript comment
 filling with mhtml-mode)
Date: Sat, 04 Jul 2020 13:14:02 +0000

[Message part 1 (text/plain, inline)]
Your bug report

#41897: 28.0.50; JavaScript comment filling with mhtml-mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41897 <at> debbugs.gnu.org.

-- 
41897: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41897
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Alan Mackenzie <acm <at> muc.de>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: Tom Tromey <tom <at> tromey.com>, 41897-done <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#41897: 28.0.50; JavaScript comment filling with mhtml-mode
Date: Sat, 4 Jul 2020 13:13:22 +0000

Hello, Simen.

On Mon, Jun 22, 2020 at 19:17:50 +0000, Alan Mackenzie wrote:
> We're gradually converging on working code.  Since yesterday, the
> improvements are:

> (i) (slightly) better handling of auto-fill-mode, which is no longer
> automatically enabled;

> (ii) An enhancement to CC Mode, used by mhtml-mode and js-mode, which
> invalidates a CC Mode cache used by the filling code.  This gets rid of
> a few strange looking bugs;

> (iii) The inclusion of "paragraph-" in the "crucial variables" thing, so
> that paragraph-start and paragraph-separate from js-mode get into
> mhtml-mode.

I've committed more or less the patch from my post of 2020-06-22, which
I'm convinced fixes the bug.  I'm closing the bug with this post.

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).


[Message part 3 (message/rfc822, inline)]
From: Simen Heggestøyl <simenheg <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; JavaScript comment filling with mhtml-mode
Date: Tue, 16 Jun 2020 19:08:44 +0200

In js-mode, the following JavaScript comment is filled as expected when
fill-paragraph (M-q) is used with point within it:

/*
 * This is a long comment that should break over multiple lines when fill-paragraph is used.
 */

Is filled as:

/*
 * This is a long comment that should break over multiple lines when
 * fill-paragraph is used.
 */

In mhtml-mode however, the same JavaScript comment:

<html>
  <script>
    /*
     * This is a long comment that should break over multiple lines when fill-paragraph is used.
     */
  </script>
</html>

Is filled as:

<html>
  <script>
    /* * This is a long comment that should break over multiple lines
     when fill-paragraph is used.  */
  </script>
</html>
This bug report was last modified 5 years and 42 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.