From unknown Fri Aug 15 15:28:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41890 <41890@debbugs.gnu.org> To: bug#41890 <41890@debbugs.gnu.org> Subject: Status: 28.0.50; [PATCH]: Add bindings for project.el Reply-To: bug#41890 <41890@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:28:29 +0000 retitle 41890 28.0.50; [PATCH]: Add bindings for project.el reassign 41890 emacs submitter 41890 Theodor Thornhill severity 41890 normal tag 41890 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 05:50:07 2020 Received: (at submit) by debbugs.gnu.org; 16 Jun 2020 09:50:08 +0000 Received: from localhost ([127.0.0.1]:48286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl8EJ-0001Zc-NA for submit@debbugs.gnu.org; Tue, 16 Jun 2020 05:50:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:38268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl8EI-0001ZT-C6 for submit@debbugs.gnu.org; Tue, 16 Jun 2020 05:50:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8EI-0004m9-1i for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 05:50:06 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:19334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8EF-0002iO-2L for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 05:50:04 -0400 Date: Tue, 16 Jun 2020 09:49:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592300998; bh=RYXaizL7AJg/OMXk6q2f2b9R1M4EzDmqD2LUpwrgiZo=; h=Date:To:From:Reply-To:Subject:From; b=kCGSvE9yaCdysz8x4upwq8rnMA16d78AbV+LIS3jAkCiIhZQ2M2SOJ6pMUTif4Yfa tkFLfVmC2SOFMLqpnAzP0T6u1XjZYdKlu49HWM9blRAMqo/A/OdY7TWpvgDIFSa1Zk m9YQ7lf8E7DPVYgpT4R4GnKy2s8L++I8UR5qTwl81C/T++C0BlZP87gXokAC9GASna x2X9aQpr5+5hMMygmW/yiVEW47YLkDSt7aT5T08NB6Itlq5Vy3SQ4XFg/+njKKavj0 OPRAuTHtGWYyPK0P2iWXqUepj8oXjx57OKo/zf1OfowSMg3MeMAa+yP40I8lYX7sLm jeLZsvBUQacnA== To: bug-gnu-emacs@gnu.org From: Theodor Thornhill Subject: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: <87blljbarq.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Ybkw4uLHOhHYExQL1IY6kY1Nm5eyDf1Y8fKSC4cg8" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.134; envelope-from=theo@thornhill.no; helo=mail-40134.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/16 05:49:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_Ybkw4uLHOhHYExQL1IY6kY1Nm5eyDf1Y8fKSC4cg8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello again! This patch adds bindings for project.el. I followed tab-bar's example and added prefix map to subr.el, and added the= bindings to bindings.el. I guess these can be removed at any point in time= later. Also, my assignment form and disclaimer is with the fsf-clerk, and has been= for a while. I sent an email this morning, hoping to speed up the process. Theo --b1_Ybkw4uLHOhHYExQL1IY6kY1Nm5eyDf1Y8fKSC4cg8 Content-Type: text/x-patch; name=project-bindings.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-bindings.patch ZGlmZiAtLWdpdCBhL2xpc3AvYmluZGluZ3MuZWwgYi9saXNwL2JpbmRpbmdzLmVsCmluZGV4IGUz ZmM1NjM3ZmEuLjUyODkwZDE4OTYgMTAwNjQ0Ci0tLSBhL2xpc3AvYmluZGluZ3MuZWwKKysrIGIv bGlzcC9iaW5kaW5ncy5lbApAQCAtMTM5NCw2ICsxMzk0LDE4IEBAIGN0bC14LTQtbWFwCiAoZGVm aW5lLWtleSBzcGVjaWFsLWV2ZW50LW1hcCBbc2lndXNyMV0gJ2lnbm9yZSkKIChkZWZpbmUta2V5 IHNwZWNpYWwtZXZlbnQtbWFwIFtzaWd1c3IyXSAnaWdub3JlKQogCis7OyBwcm9qZWN0LmVsIGNv bW1hbmRzCisoZGVmaW5lLWtleSBwcm9qZWN0LXByZWZpeC1tYXAgImYiICdwcm9qZWN0LWZpbmQt ZmlsZSkKKyhkZWZpbmUta2V5IHByb2plY3QtcHJlZml4LW1hcCAiYiIgJ3Byb2plY3Qtc3dpdGNo LXRvLWJ1ZmZlcikKKyhkZWZpbmUta2V5IHByb2plY3QtcHJlZml4LW1hcCAicyIgJ3Byb2plY3Qt c2hlbGwpCisoZGVmaW5lLWtleSBwcm9qZWN0LXByZWZpeC1tYXAgImQiICdwcm9qZWN0LWRpcmVk KQorKGRlZmluZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwICJ2IiAncHJvamVjdC12Yy1kaXIpCiso ZGVmaW5lLWtleSBwcm9qZWN0LXByZWZpeC1tYXAgImMiICdwcm9qZWN0LWNvbXBpbGUpCisoZGVm aW5lLWtleSBwcm9qZWN0LXByZWZpeC1tYXAgImUiICdwcm9qZWN0LWVzaGVsbCkKKyhkZWZpbmUt a2V5IHByb2plY3QtcHJlZml4LW1hcCAicCIgJ3Byb2plY3Qtc3dpdGNoLXByb2plY3QpCisoZGVm aW5lLWtleSBwcm9qZWN0LXByZWZpeC1tYXAgImciICdwcm9qZWN0LWZpbmQtcmVnZXhwKQorKGRl ZmluZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwICJyIiAncHJvamVjdC1xdWVyeS1yZXBsYWNlLXJl Z2V4cCkKKwogOzsgRG9uJ3QgbG9vayBmb3IgYXV0b2xvYWQgY29va2llcyBpbiB0aGlzIGZpbGUu CiA7OyBMb2NhbCBWYXJpYWJsZXM6CiA7OyBuby11cGRhdGUtYXV0b2xvYWRzOiB0CmRpZmYgLS1n aXQgYS9saXNwL3N1YnIuZWwgYi9saXNwL3N1YnIuZWwKaW5kZXggMTBjMzdlOTQxMy4uNzVkYTFi ZThkZSAxMDA2NDQKLS0tIGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5lbApAQCAtMTI2 NSw2ICsxMjY1LDEwIEBAIHRhYi1wcmVmaXgtbWFwCiAgICJLZXltYXAgZm9yIHRhYi1iYXIgcmVs YXRlZCBjb21tYW5kcy4iKQogKGRlZmluZS1rZXkgY3RsLXgtbWFwICJ0IiB0YWItcHJlZml4LW1h cCkKIAorKGRlZnZhciBwcm9qZWN0LXByZWZpeC1tYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkKKyAg IktleW1hcCBmb3IgcHJvamVjdCBjb21tYW5kcy4iKQorKGRlZmluZS1rZXkgY3RsLXgtbWFwICJw IiBwcm9qZWN0LXByZWZpeC1tYXApCisKIAwKIDs7OzsgRXZlbnQgbWFuaXB1bGF0aW9uIGZ1bmN0 aW9ucy4KIAo= --b1_Ybkw4uLHOhHYExQL1IY6kY1Nm5eyDf1Y8fKSC4cg8-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 10:27:57 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 14:27:58 +0000 Received: from localhost ([127.0.0.1]:49344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlCZB-0002Cm-NU for submit@debbugs.gnu.org; Tue, 16 Jun 2020 10:27:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlCZA-0002CY-69 for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 10:27:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57364) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlCZ4-0008Pz-6l; Tue, 16 Jun 2020 10:27:50 -0400 Received: from [176.228.60.248] (port=3981 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlCZ1-0008Tt-HI; Tue, 16 Jun 2020 10:27:48 -0400 Date: Tue, 16 Jun 2020 17:27:29 +0300 Message-Id: <83pn9z13xq.fsf@gnu.org> From: Eli Zaretskii To: Theodor Thornhill In-Reply-To: <87blljbarq.fsf@thornhill.no> (message from Theodor Thornhill on Tue, 16 Jun 2020 09:49:51 +0000) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 16 Jun 2020 09:49:51 +0000 > From: Theodor Thornhill > > This patch adds bindings for project.el. > > I followed tab-bar's example and added prefix map to subr.el, and added the bindings to bindings.el. I guess these can be removed at any point in time later. Can you tell what is the rationale for having project.el keymap defined outside of project.el? > Also, my assignment form and disclaimer is with the fsf-clerk, and has been for a while. I sent an email this morning, hoping to speed up the process. If nothing happens within a week or two, ping them and CC me. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 12:45:04 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 16:45:04 +0000 Received: from localhost ([127.0.0.1]:49488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlEhs-0005ft-2b for submit@debbugs.gnu.org; Tue, 16 Jun 2020 12:45:04 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:37856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlEhp-0005f2-0P for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 12:45:02 -0400 Date: Tue, 16 Jun 2020 16:44:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592325894; bh=76L1rfGtS7cjFZ925ujtkAZ8O+vv4eKiFzA07qEegIo=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=cOileKn5sgecGDjApdwlSBU46PZL6IgsLiEcW/QhlI8bwmp48PjZO1fCbbayZMSoI gyUk6Hzk2MQzv2N165F+QaNju270Km1QtthtfF5WntayFIxtn6oNxQWcqVNk1dxxGz KJFg1WES7QuXAIqJO3R+VjIGgSTKkHfYJWIp3NyqPNIqDxIs63paWktBGWs3m86OYk 3k9e3pMwOs1SnlSN8kknjz+trbQakvttJHW2jv+vWmQ5n2hjfDHGRjFSN07sVJhll7 ruhWV2Q9Z+oOIXcCUpXLTSJFws6jzMVyz6zpS/ztqJujFu7mNJ7QODRcpFmTqtDMCE gDQ6E9ICW20qw== To: Eli Zaretskii From: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: <87lfknklj8.fsf@thornhill.no> In-Reply-To: <83pn9z13xq.fsf@gnu.org> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello :) "Eli Zaretskii" writes: [...] > Can you tell what is the rationale for having project.el keymap > defined outside of project.el? In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41879#23 Dmitry says: "Do we keep it in project.el or somewhere outside? Maybe the latter, since project.el is also an ELPA package, and we generally don't want packages to alter Emacs' key bindings right after installation." I guess this concern is for when users not building from master is download= ing 'project.el' from ELPA. I don't really have a strong opinion for any direction. Would you rather wa= nt them in 'project.el'?=20 [...] > If nothing happens within a week or two, ping them and CC me. He responded and said they have what they need from me and will process it = further. I guess it is done at some point soon. Theo From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 13:17:02 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 17:17:02 +0000 Received: from localhost ([127.0.0.1]:49527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlFCo-0006Rj-Az for submit@debbugs.gnu.org; Tue, 16 Jun 2020 13:17:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlFCm-0006RC-Ng for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 13:17:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60600) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlFCg-0000gz-W7; Tue, 16 Jun 2020 13:16:55 -0400 Received: from [176.228.60.248] (port=2720 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlFCg-0008Qz-Bl; Tue, 16 Jun 2020 13:16:54 -0400 Date: Tue, 16 Jun 2020 20:16:37 +0300 Message-Id: <83h7vb0w3u.fsf@gnu.org> From: Eli Zaretskii To: Theodor Thornhill In-Reply-To: <87lfknklj8.fsf@thornhill.no> (message from Theodor Thornhill on Tue, 16 Jun 2020 16:44:51 +0000) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 16 Jun 2020 16:44:51 +0000 > From: Theodor Thornhill > Cc: 41890@debbugs.gnu.org > > > Can you tell what is the rationale for having project.el keymap > > defined outside of project.el? > > In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41879#23 > Dmitry says: > > "Do we keep it in project.el or somewhere outside? Maybe the latter, since > project.el is also an ELPA package, and we generally don't want packages to > alter Emacs' key bindings right after installation." > > I guess this concern is for when users not building from master is downloading 'project.el' from ELPA. > > I don't really have a strong opinion for any direction. Would you rather want them in 'project.el'? I certainly would. It is very unusual for an optional package to have its bindings in files that are preloaded into every Emacs session. > > If nothing happens within a week or two, ping them and CC me. > > He responded and said they have what they need from me and will process it further. I guess it is done at some point soon. Well, if there's no progress within a week or two, my suggestion still stands. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 13:30:35 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 17:30:36 +0000 Received: from localhost ([127.0.0.1]:49536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlFPv-0006m0-Nb for submit@debbugs.gnu.org; Tue, 16 Jun 2020 13:30:35 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:53012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlFPu-0006ln-Ab for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 13:30:34 -0400 Date: Tue, 16 Jun 2020 17:30:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592328627; bh=Qoiz11MJ2m8hHJF4AgtDhpLHB09tWVkbBZ5gXQ6nMFY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=0OJ9oiWaUeeuRMyzZyTp7btir3TEs+Vm8c/Wtgjl1fTYypkgZUsVwAIsNt82k0OMe nhzuY4jqmYnFlUBMbo8NEawLQI7+bhMRnft9TZ+iqM2Z6vPIjdrPMXJMlCflAymAOf hFhuxoQY7p8dTWrsft8ZnoY7XrQvX2RmfPqcNhU2PkW8+HwfMeoeREkRrKbAG+QuB8 6OJmb0UU82WBEyv6W7eQpq6exeDshPnIEjrmvQWS0YDvA2n6KXbY/AoC6qmKVKQbOI YeRonMREWjh+K3K/agSx1jnkGAEsU+8fSRdNmmww3+RLr2htx0UL6Vof1M0uHei7w8 wxJY0himmDf/g== To: Eli Zaretskii From: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: <87ftaulxzr.fsf@thornhill.no> In-Reply-To: <83h7vb0w3u.fsf@gnu.org> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Ldp1fcf9B10PGLafPLoxpGiAVTAhka64tbmH7824960" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_Ldp1fcf9B10PGLafPLoxpGiAVTAhka64tbmH7824960 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, "Eli Zaretskii" writes: [...] > I certainly would. It is very unusual for an optional package to have > its bindings in files that are preloaded into every Emacs session. > Ok! I attached a new patch with them placed in project.el. Also cc'd Dmitry= so he can chime in. Maybe we should do it more customizable? [...] > Well, if there's no progress within a week or two, my suggestion still > stands. Will definitely do :) > Thanks. Thank you! Theodor --b1_Ldp1fcf9B10PGLafPLoxpGiAVTAhka64tbmH7824960 Content-Type: text/x-patch; name=project-bindings.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-bindings.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLjdiYjM4MzE2NDcgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt MTA3LDYgKzEwNywyMSBAQCBwcm9qZWN0LWZpbmQtZnVuY3Rpb25zCiAoZGVmdmFyIHByb2plY3Qt Y3VycmVudC1pbmhpYml0LXByb21wdCBuaWwKICAgIk5vbi1uaWwgdG8gc2tpcCBwcm9tcHRpbmcg dGhlIHVzZXIgaW4gYHByb2plY3QtY3VycmVudCcuIikKIAorKGRlZnZhciBwcm9qZWN0LXByZWZp eC1tYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkKKyAgIktleW1hcCBmb3IgcHJvamVjdCBjb21tYW5k cy4iKQorCisoZGVmaW5lLWtleSBjdGwteC1tYXAgInAiIHByb2plY3QtcHJlZml4LW1hcCkKKyhk ZWZpbmUta2V5IHByb2plY3QtcHJlZml4LW1hcCAiZiIgJ3Byb2plY3QtZmluZC1maWxlKQorKGRl ZmluZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwICJiIiAncHJvamVjdC1zd2l0Y2gtdG8tYnVmZmVy KQorKGRlZmluZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwICJzIiAncHJvamVjdC1zaGVsbCkKKyhk ZWZpbmUta2V5IHByb2plY3QtcHJlZml4LW1hcCAiZCIgJ3Byb2plY3QtZGlyZWQpCisoZGVmaW5l LWtleSBwcm9qZWN0LXByZWZpeC1tYXAgInYiICdwcm9qZWN0LXZjLWRpcikKKyhkZWZpbmUta2V5 IHByb2plY3QtcHJlZml4LW1hcCAiYyIgJ3Byb2plY3QtY29tcGlsZSkKKyhkZWZpbmUta2V5IHBy b2plY3QtcHJlZml4LW1hcCAiZSIgJ3Byb2plY3QtZXNoZWxsKQorKGRlZmluZS1rZXkgcHJvamVj dC1wcmVmaXgtbWFwICJwIiAncHJvamVjdC1zd2l0Y2gtcHJvamVjdCkKKyhkZWZpbmUta2V5IHBy b2plY3QtcHJlZml4LW1hcCAiZyIgJ3Byb2plY3QtZmluZC1yZWdleHApCisoZGVmaW5lLWtleSBw cm9qZWN0LXByZWZpeC1tYXAgInIiICdwcm9qZWN0LXF1ZXJ5LXJlcGxhY2UtcmVnZXhwKQorCiA7 OzsjIyNhdXRvbG9hZAogKGRlZnVuIHByb2plY3QtY3VycmVudCAoJm9wdGlvbmFsIG1heWJlLXBy b21wdCBkaXIpCiAgICJSZXR1cm4gdGhlIHByb2plY3QgaW5zdGFuY2UgaW4gRElSIG9yIGBkZWZh dWx0LWRpcmVjdG9yeScuCg== --b1_Ldp1fcf9B10PGLafPLoxpGiAVTAhka64tbmH7824960-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 14:14:46 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 18:14:46 +0000 Received: from localhost ([127.0.0.1]:49576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlG6g-0007qh-IW for submit@debbugs.gnu.org; Tue, 16 Jun 2020 14:14:46 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:53241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlG6e-0007qP-Q7 for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 14:14:45 -0400 Received: by mail-wm1-f53.google.com with SMTP id r9so3760336wmh.2 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 11:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hb9jdpW8hT2JIgh3aZFqXWRnrE1rS2Nxqg2mZ0doS/4=; b=kyXi7ExLBbu/Dft7IECXts9daXKMWAazZYEYcaNQQ2e+XStfWgvb2GtxfGn9rmAJTi h4nO6newzq0XGihllBCl2X6uhgj/VNj8+Cf3drLu7OMVvi+Opvxr4WoRBD6gCzC+m9iW MvWW8YCj8PNaH5c+2KkT+5FGrurRzLv1UPB68qTlxIitlfCYPFuqu5jlu0CQOqQumE+w hzvBGbF5bCWzIEKQbhBbFNP86PQgUPWx4wP4E98r4rl7M9ybB9AXR4ZsDk+Yej2JXPjt CKxIl5sDVzTbDERo+TkdMMZ++5TFvIqL123XBAvNxfGqMexeht1A/3pOTZgnSBLeB2ci UeQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hb9jdpW8hT2JIgh3aZFqXWRnrE1rS2Nxqg2mZ0doS/4=; b=TOgKnjRV7piw0rlJQInocqQmauugmIdUsWY1aFwnm8Rq507jxcdcjBy/gd/85s2Y1l du4TQT0iAgD+R5GrWhaYccDDpwbpkhwoROI80h1DlISoDpvdkKybNof6NM+RK9DtW0+L /ABr2QA7A6YdFpgv6R1GC7LWbm7TJXmmbtWxcWQ6EkFhPoRFZ1Z/y92YFQ3sOFtKAfgQ 3f+wEi9SCAKsjoTImkXygBKfGt3HBAfv6yCeL3RSCF7IN933fzcTAFD/zXEONmR9yytf gTagIMdD5hfqD7SsCUUvpzmnYj74rwnryGivqqHzZ7creMd47XlOxzvpLhlc6w/IMD2K Tojg== X-Gm-Message-State: AOAM530EbMJuqXbCmQZvCXHi28sktNpmgzIaApDsiBS6nmW0i75mLxne dgGadv33e3SzKb9ptAPmtZKQdA== X-Google-Smtp-Source: ABdhPJxGMtSAbaeSuyJh9cyzA/wygpeQhwLBDXiwTclBgtAUjzMceEPEW0uuXNncRJQi3JS48Gn2Qw== X-Received: by 2002:a1c:a1c5:: with SMTP id k188mr4696601wme.41.1592331278940; Tue, 16 Jun 2020 11:14:38 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id v6sm32101028wrf.61.2020.06.16.11.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 11:14:38 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> Date: Tue, 16 Jun 2020 19:14:37 +0100 In-Reply-To: <87ftaulxzr.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 17:30:25 +0000") Message-ID: <87r1ueri7m.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: Eli Zaretskii , 41890@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > +(defvar project-prefix-map (make-sparse-keymap) > + "Keymap for project commands.") > + > +(define-key ctl-x-map "p" project-prefix-map) > +(define-key project-prefix-map "f" 'project-find-file) > +(define-key project-prefix-map "b" 'project-switch-to-buffer) > +(define-key project-prefix-map "s" 'project-shell) > +(define-key project-prefix-map "d" 'project-dired) > +(define-key project-prefix-map "v" 'project-vc-dir) > +(define-key project-prefix-map "c" 'project-compile) > +(define-key project-prefix-map "e" 'project-eshell) > +(define-key project-prefix-map "p" 'project-switch-project) > +(define-key project-prefix-map "g" 'project-find-regexp) > +(define-key project-prefix-map "r" 'project-query-replace-regexp) This should be: (defvar project-prefix-map (let ((map (make-sparse-keymap))) (define-key map ...) ... map) "...") (define-key ctl-x-map "p" project-prefix-map) See the end of (info "(elisp) Tips for Defining"). Maybe it should also be autoloaded. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 15:07:51 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 19:07:51 +0000 Received: from localhost ([127.0.0.1]:49617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGw2-0000kD-Nz for submit@debbugs.gnu.org; Tue, 16 Jun 2020 15:07:51 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:54186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGw0-0000jy-1J for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 15:07:49 -0400 Date: Tue, 16 Jun 2020 19:07:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592334461; bh=AsRZ/u7DbbzwJ3ygRSVo01y1EhCpZah2UBMB/fBDet8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=m+TPOAHTSEfXSEESWdPrRNjCP+8WilzuQMbTtSixbpBkF4jFnJ0qXEnSQHgRih1dE VZp3gqJ2YBnvGq81qkZYTnuGbdr5LodIaQvF9dElt9w3I5Ly/UIdbs0X8pICJ+8DYI zPDXP9fXq1OBLR8Wh0vv5olQFARlz/Ac9zRz524Qzqr8sTGbAGChvD+DoNneEts3mi B9Xtr09ozfTyUhDh7pd+fiu73ASFVrG7+aMv7gUYjYSG2WdWPgu4mdO+XwPIUVFMxc tr8hAGhftii3vDfReUYg7SBM8+Oe2PS+jRFo8rLKTiMYCjqCDy3xfxHniulC71PMK2 2kRXuzj1h78Hg== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: <87imfqn829.fsf@thornhill.no> In-Reply-To: <87r1ueri7m.fsf@tcd.ie> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_nxsh8JfWkUpqUrTNRiIB5ZIKXpYRLFlbOp5Q0DVC8E" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_nxsh8JfWkUpqUrTNRiIB5ZIKXpYRLFlbOp5Q0DVC8E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi and thanks again for tips! > This should be: > > (defvar project-prefix-map > (let ((map (make-sparse-keymap))) > (define-key map ...) > ... > map) > "...") > > (define-key ctl-x-map "p" project-prefix-map) > > See the end of (info "(elisp) Tips for Defining"). > > Maybe it should also be autoloaded. Below is another patch with your suggestions incorporated. Is it correct to= also autoload the (define-key ctl-x-map "p" project-prefix-map)? Theo --b1_nxsh8JfWkUpqUrTNRiIB5ZIKXpYRLFlbOp5Q0DVC8E Content-Type: text/x-patch; name=project-bindings.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-bindings.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLmQzZmIzNGQ5MjUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt MTA3LDYgKzEwNywyNCBAQCBwcm9qZWN0LWZpbmQtZnVuY3Rpb25zCiAoZGVmdmFyIHByb2plY3Qt Y3VycmVudC1pbmhpYml0LXByb21wdCBuaWwKICAgIk5vbi1uaWwgdG8gc2tpcCBwcm9tcHRpbmcg dGhlIHVzZXIgaW4gYHByb2plY3QtY3VycmVudCcuIikKIAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ2 YXIgcHJvamVjdC1wcmVmaXgtbWFwCisgIChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkp KQorICAgIChkZWZpbmUta2V5IG1hcCAiZiIgJ3Byb2plY3QtZmluZC1maWxlKQorICAgIChkZWZp bmUta2V5IG1hcCAiYiIgJ3Byb2plY3Qtc3dpdGNoLXRvLWJ1ZmZlcikKKyAgICAoZGVmaW5lLWtl eSBtYXAgInMiICdwcm9qZWN0LXNoZWxsKQorICAgIChkZWZpbmUta2V5IG1hcCAiZCIgJ3Byb2pl Y3QtZGlyZWQpCisgICAgKGRlZmluZS1rZXkgbWFwICJ2IiAncHJvamVjdC12Yy1kaXIpCisgICAg KGRlZmluZS1rZXkgbWFwICJjIiAncHJvamVjdC1jb21waWxlKQorICAgIChkZWZpbmUta2V5IG1h cCAiZSIgJ3Byb2plY3QtZXNoZWxsKQorICAgIChkZWZpbmUta2V5IG1hcCAicCIgJ3Byb2plY3Qt c3dpdGNoLXByb2plY3QpCisgICAgKGRlZmluZS1rZXkgbWFwICJnIiAncHJvamVjdC1maW5kLXJl Z2V4cCkKKyAgICAoZGVmaW5lLWtleSBtYXAgInIiICdwcm9qZWN0LXF1ZXJ5LXJlcGxhY2UtcmVn ZXhwKSkKKyAgIktleW1hcCBmb3IgcHJvamVjdCBjb21tYW5kcy4iKQorCis7OzsjIyNhdXRvbG9h ZAorKGRlZmluZS1rZXkgY3RsLXgtbWFwICJwIiBwcm9qZWN0LXByZWZpeC1tYXApCisKIDs7OyMj I2F1dG9sb2FkCiAoZGVmdW4gcHJvamVjdC1jdXJyZW50ICgmb3B0aW9uYWwgbWF5YmUtcHJvbXB0 IGRpcikKICAgIlJldHVybiB0aGUgcHJvamVjdCBpbnN0YW5jZSBpbiBESVIgb3IgYGRlZmF1bHQt ZGlyZWN0b3J5Jy4K --b1_nxsh8JfWkUpqUrTNRiIB5ZIKXpYRLFlbOp5Q0DVC8E-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 15:12:24 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 19:12:24 +0000 Received: from localhost ([127.0.0.1]:49629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlH0R-0000rt-Lx for submit@debbugs.gnu.org; Tue, 16 Jun 2020 15:12:23 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:60378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlH0P-0000re-5u for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 15:12:22 -0400 Date: Tue, 16 Jun 2020 19:12:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592334734; bh=VPDJ9mbCVOl+qyo+cg70lySnL7AbFgcY3cWRe/NdjSw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=G9fufZykEZpfVBS8hPEhsQFy2PSXO0F4srmkn5pOA2+sMZ96YttDF1evFdHNb2Kas tt0oINBF3ISz2m/vIbzFsg8HNE0V7doSfaiZO0TiP5cg5/+6Uu9LldsEmXtF4mCFtz MVCakKz90+PpW7nntpyIfhJEmJW/Cjx6DxJp8Qsbm9xVz2vlf371zutYooYIeyi2Ns GSLx6u6CuGjEGtx+YnnPLj2AF9jucqKoYYVUN7DXtWLVKC+72JuFL2d5v9R5ZGQqzw lDVBfjHNqsjmuJVy5xb86OTCPads9jvR2YCh0A5uQKmvMsrZ7mjyvOvLcb3/VXC0EC /OQ9hlHX1CHqA== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: <87ftaun7ug.fsf@thornhill.no> In-Reply-To: <87imfqn829.fsf@thornhill.no> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_XNJGXdtHTgg6KDiwUNNipF0rPh7Z721Zd59OuiNk" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_XNJGXdtHTgg6KDiwUNNipF0rPh7Z721Zd59OuiNk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Theodor Thornhill" writes: > Below is another patch with your suggestions incorporated. Is it correct = to also autoload the (define-key ctl-x-map "p" project-prefix-map)? Disregard last one. It was missing a map returned at the end. Sorry for the= inconvenience. Theo --b1_XNJGXdtHTgg6KDiwUNNipF0rPh7Z721Zd59OuiNk Content-Type: text/x-patch; name=project-bindings.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-bindings.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLjA4OGM2OTgzOTggMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt MTA3LDYgKzEwNywyNSBAQCBwcm9qZWN0LWZpbmQtZnVuY3Rpb25zCiAoZGVmdmFyIHByb2plY3Qt Y3VycmVudC1pbmhpYml0LXByb21wdCBuaWwKICAgIk5vbi1uaWwgdG8gc2tpcCBwcm9tcHRpbmcg dGhlIHVzZXIgaW4gYHByb2plY3QtY3VycmVudCcuIikKIAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ2 YXIgcHJvamVjdC1wcmVmaXgtbWFwCisgIChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkp KQorICAgIChkZWZpbmUta2V5IG1hcCAiZiIgJ3Byb2plY3QtZmluZC1maWxlKQorICAgIChkZWZp bmUta2V5IG1hcCAiYiIgJ3Byb2plY3Qtc3dpdGNoLXRvLWJ1ZmZlcikKKyAgICAoZGVmaW5lLWtl eSBtYXAgInMiICdwcm9qZWN0LXNoZWxsKQorICAgIChkZWZpbmUta2V5IG1hcCAiZCIgJ3Byb2pl Y3QtZGlyZWQpCisgICAgKGRlZmluZS1rZXkgbWFwICJ2IiAncHJvamVjdC12Yy1kaXIpCisgICAg KGRlZmluZS1rZXkgbWFwICJjIiAncHJvamVjdC1jb21waWxlKQorICAgIChkZWZpbmUta2V5IG1h cCAiZSIgJ3Byb2plY3QtZXNoZWxsKQorICAgIChkZWZpbmUta2V5IG1hcCAicCIgJ3Byb2plY3Qt c3dpdGNoLXByb2plY3QpCisgICAgKGRlZmluZS1rZXkgbWFwICJnIiAncHJvamVjdC1maW5kLXJl Z2V4cCkKKyAgICAoZGVmaW5lLWtleSBtYXAgInIiICdwcm9qZWN0LXF1ZXJ5LXJlcGxhY2UtcmVn ZXhwKQorICAgIG1hcCkKKyAgIktleW1hcCBmb3IgcHJvamVjdCBjb21tYW5kcy4iKQorCis7Ozsj IyNhdXRvbG9hZAorKGRlZmluZS1rZXkgY3RsLXgtbWFwICJwIiBwcm9qZWN0LXByZWZpeC1tYXAp CisKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4gcHJvamVjdC1jdXJyZW50ICgmb3B0aW9uYWwgbWF5 YmUtcHJvbXB0IGRpcikKICAgIlJldHVybiB0aGUgcHJvamVjdCBpbnN0YW5jZSBpbiBESVIgb3Ig YGRlZmF1bHQtZGlyZWN0b3J5Jy4K --b1_XNJGXdtHTgg6KDiwUNNipF0rPh7Z721Zd59OuiNk-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 16:32:03 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 20:32:03 +0000 Received: from localhost ([127.0.0.1]:49706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlIFX-0002qJ-EF for submit@debbugs.gnu.org; Tue, 16 Jun 2020 16:32:03 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:39394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlIFV-0002pp-BU for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 16:32:02 -0400 Received: by mail-wm1-f53.google.com with SMTP id t194so4429917wmt.4 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 13:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Sop1lJOs0TayUuuDGKc3ZV4shMu6psJNIJBHt1tmlgo=; b=Vva5a4l3Tq9hkreWnu4Y9k3aVDow+GczktZdfMtx06TjhzPdCQgLRcUP0v4F7A38U2 qVexPwnJAoRgV5hDo3g2pX96j20U75ZkWkE977U317HeYrmyqxqgfnuAW8xAto0ppHB+ tXD73HNSA3tZFF6OEUDQbvalZwXASMFWKSLllHYKJGuz092EBENO+a/L188ppvqgPWuI zppCXsCcki3s99QKbgUsDf2dOucCkuZWQSC3r61nd77YoXiucDtdiVenOya4Rb6L0Xx9 +rrciDNjZPTsl9QlcV0NkEDUcFnAZB7T06tUf2aS2wiiC8jZCorPLq9VLXGU+z+bzgiU RZRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Sop1lJOs0TayUuuDGKc3ZV4shMu6psJNIJBHt1tmlgo=; b=HznFXzQgLeNpuuvlM1SnugIU8/vGfOWJUSRl7XrpyNPRFgUv2Ue3D0/JargDFAdReS QPH9FZA8XDYU6KFTw/kNAbk3ySB+09BMoXMk6eBeSJAtfAY28K+KW4jUdRhYEOtBvRgu HneCgVc4cNqY3qFVS21rXxOde1OMIQDLS7UjhBj7kWpvA7vwO6V7Z2deMpA517n0+1gw FgIc6eGWL7NeR+bhRkNbYhvAPilhV8u4mcADMp3d8YoPM1tjjN1rXyQxzZEWAuYZsFiH 0QNNVcl03DfUw8FvE4B77HyVOvWNlznzSzURz0uVCDR7bTU6CI1XNZXwsJo5i5nNdKbt Fqew== X-Gm-Message-State: AOAM5322TsVGv4DNWeZ46BWr6A8e08vX/XL9U9DYDpwWLuv9x8xmKlOj ehMMWb3T+Ic3iFhXtHgPQIYybw== X-Google-Smtp-Source: ABdhPJyJ+GUG8owf2yJqsaxPsym/1uwGI09Cx+r9qr5pFGfmbw9M/He1ZIZXVkRZUdNb7w3FM6jXYg== X-Received: by 2002:a7b:cbd9:: with SMTP id n25mr4902358wmi.30.1592339515204; Tue, 16 Jun 2020 13:31:55 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id b143sm5401178wme.20.2020.06.16.13.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 13:31:54 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> Date: Tue, 16 Jun 2020 21:31:53 +0100 In-Reply-To: <87imfqn829.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 19:07:32 +0000") Message-ID: <87imfqoipy.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: >> This should be: >> >> (defvar project-prefix-map >> (let ((map (make-sparse-keymap))) >> (define-key map ...) >> ... >> map) >> "...") >> >> (define-key ctl-x-map "p" project-prefix-map) >> >> See the end of (info "(elisp) Tips for Defining"). >> >> Maybe it should also be autoloaded. > > Below is another patch with your suggestions incorporated. Is it correct to also > autoload the (define-key ctl-x-map "p" project-prefix-map)? I'm not an autoload expert, so I'd appreciate if someone else chimed in, but according to the commentary in lisp/bookmark.el, ;;;###autoload (define-key ...) is preferable to ;;;###autoload (define-key ...) since the former is copied to lisp/ldefs-boot.el at build time and skipped at load time (since it's in a comment), so it doesn't override existing user settings. Would that do what we want? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 17:23:38 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 21:23:38 +0000 Received: from localhost ([127.0.0.1]:49774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJ3S-00046Y-Hi for submit@debbugs.gnu.org; Tue, 16 Jun 2020 17:23:38 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:41771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJ3P-00046J-PB for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 17:23:36 -0400 Received: by mail-wr1-f48.google.com with SMTP id j10so134670wrw.8 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 14:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/5xoWD1Eh1eKPB2Yb2wwS1a/PupU4hW5SQ1bJ7TOKqY=; b=R0VagcDHcH1aa04iydHXwB+5Ao6jVuIQ3cpLodVX0dUAXITm8uz/WPERZ8mfSWQdiz 4MmgJaVvcHlV6ZlLYiYPX6Sp+5BWZMJ8InPg5J01SAihEmSxR4OoQrX8e0Wvo4CkOAaf FoYmD6CLLC1hZvmMrvoQTQ6SsFrNP9wEgUPizOZDr4J6DWcUFnMoIAw3WLrs6h7UHw1h Y4aF0Ib9qg2sgchwO4ArutR/AaKTOMXgVnRBmBlZNIDIYaSivof91csQg8Z8lBCQktqQ feNRf3Bq6Z9X2uj5Sjj6vmRYpsF3nfeYQOmPEwyksJnnjTb1Y86yqte+EgCb0twD+anK GNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/5xoWD1Eh1eKPB2Yb2wwS1a/PupU4hW5SQ1bJ7TOKqY=; b=sqBHJMI3yewFwd4IPB7i6BcLtGw6aqnFcppVPRtoRdEw9ODPy1PbbwwmycCSBt3G3Z s5nB2xP7T8+yEwu4Mw6TithkRaKFnMd+mv0NwSiUCb4Dbabcv3dwTY/kD5sxtrLvgG33 7RCIdlT7O5gzj6bNWyiySPA76Gn56iVVblU7QA0RQTF1kkQU9iUjYk2Kaktf6C6T9zXg byX8UGFdCoBXXLr7N5zSJaCvOm/BnROV0Iy+LsbXtl3aIxmYr0Vtf7T9DOyuCcvSxIsO qw9ERNL50MQJQTHo0n27FFwqAyQ4Qrf9GcGskbsqYfA/LqmcjIPCiOB7IgHjlSqrGSSi 4ySg== X-Gm-Message-State: AOAM530IzH+osGZDN4Q4qcbWvHmHRc9E2jMklfv0UPxN4EDd7rZFHiGu imjabSs4bGewr3w7PQWioxy2rz3G X-Google-Smtp-Source: ABdhPJwbFghJxVgWogRazK2J91eIJPuVaqinZGHKB93bWjBlKj98gYrERPZG7EQF0/9Z9B7qTE3lKw== X-Received: by 2002:a05:6000:1003:: with SMTP id a3mr4879968wrx.111.1592342609591; Tue, 16 Jun 2020 14:23:29 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 138sm5912237wma.23.2020.06.16.14.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 14:23:28 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii , Theodor Thornhill References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> From: Dmitry Gutov Message-ID: <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> Date: Wed, 17 Jun 2020 00:23:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83h7vb0w3u.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.06.2020 20:16, Eli Zaretskii wrote: > I certainly would. It is very unusual for an optional package to have > its bindings in files that are preloaded into every Emacs session. What do you mean by "optional"? It's in Emacs 28. How is it different from the aforementioned tabs? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 17:35:37 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 21:35:37 +0000 Received: from localhost ([127.0.0.1]:49779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJF2-0004OI-Ok for submit@debbugs.gnu.org; Tue, 16 Jun 2020 17:35:36 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:32853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJF0-0004O5-Ss for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 17:35:35 -0400 Received: by mail-wm1-f42.google.com with SMTP id j198so3118876wmj.0 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 14:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gL8ByDLp9Ry9OW74HXe3o8mfuNRHGSvm6wcdiwSOozs=; b=dnUcVRh2venvcoNRpbdHNMZN5grYtbJ3PnhGFOe4NyJzeYADjrR6TmMX3qyS+znRXf 5xdxB/tElu1M4Rz2cDeWRlnzEXoVk057maNSnY0Ir8hz/v8UEnCNK7ZxqundlkXTH4IM fDQG3fMxYzDnbw5E9mhvxujMOk6lcVok8qmWux5NrWOvRxtBxflNpRPjtK24/P2diRzC rQywt5WwgVu+IpyTsGoBCaiCZYgHglzJEpInJpLQ1eON17VD1ewYG3j7IonNavxuDF7M 9otIWTObRbwDuP8hJZx00HnX2dR1Jf31JX9XwBNwJ9b1WA10Gx0IyMD6mKGPu7LSNEZM TQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gL8ByDLp9Ry9OW74HXe3o8mfuNRHGSvm6wcdiwSOozs=; b=LKsPOkAL9UP9r6c72J0uydhg9ehJlBnbNs0Aj4/xqr/02UEmC0dH3LPIDRUeGLfFi8 zaz5LPnufE5jal8EyALPHzETY5FpdTIoruuVKOC+mCfeDqqNiOSm8mS18VJmP4uwIGX9 CcqK/GzwO2VgftyjFWc0kZSvNnlTJm/LoLvdwh+/yCsxG42UAfMNaFoPahShgSiuqoLB 8VOJRPzYCeEErlWMPUwd30gn9Cd+yQ1uDtRCMNMAXeAXaxanpP6Kzq4AyIENFDlnSM1t qTXv3euegX0kN7tiZdsxwlguGl8tA6pwv7YuIMSqVtxsB9hDfh5Pfjx07NICTePZM3Vl I7qA== X-Gm-Message-State: AOAM530JslQvrHppoxI4m1kZv+HSP/Is7gS1pk2KpDFc8Uge5wG9dXsU p7BEnAlzfANKruk3bKq3LyyQ5Qan X-Google-Smtp-Source: ABdhPJzWVZYrdhT4o/Q96zN0zoZppOWBVDFAAwOIZJ19bGf+m68WuFlykj8OObtUVgNdAF8NZTv8cg== X-Received: by 2002:a05:600c:21d3:: with SMTP id x19mr5581523wmj.137.1592343328692; Tue, 16 Jun 2020 14:35:28 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id b19sm5783250wmj.0.2020.06.16.14.35.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 14:35:28 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el From: Dmitry Gutov To: Eli Zaretskii , Theodor Thornhill References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> Message-ID: <65a844bc-1242-d88e-cab0-901704da16ef@yandex.ru> Date: Wed, 17 Jun 2020 00:35:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 00:23, Dmitry Gutov wrote: > On 16.06.2020 20:16, Eli Zaretskii wrote: >> I certainly would.  It is very unusual for an optional package to have >> its bindings in files that are preloaded into every Emacs session. > > What do you mean by "optional"? It's in Emacs 28. > > How is it different from the aforementioned tabs? Let's step back, maybe. From multiple discussions, over a certain period of time, mostly here in emacs-devel, I have arrived at an impression that there exists a general desire to have global bindings for project functions, in "default" Emacs, without customization. And that the 'C-x p' prefix is both unoccupied and looks logical to use for that purpose. What do you think about that? As an aside, I'd like to do a similar thing for Flymake, with Flycheck-inspired prefix of 'C-c !' a bit later. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 18:00:22 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 22:00:22 +0000 Received: from localhost ([127.0.0.1]:49805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJd0-0004zd-CH for submit@debbugs.gnu.org; Tue, 16 Jun 2020 18:00:22 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:48379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJcy-0004zA-Bg for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 18:00:20 -0400 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 8CB2E100008; Tue, 16 Jun 2020 22:00:12 +0000 (UTC) From: Juri Linkov To: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> Date: Wed, 17 Jun 2020 00:57:56 +0300 In-Reply-To: <87ftaun7ug.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 19:12:13 +0000") Message-ID: <87v9jqfzbv.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > + (define-key map "f" 'project-find-file) > + (define-key map "b" 'project-switch-to-buffer) > + (define-key map "s" 'project-shell) > + (define-key map "d" 'project-dired) > + (define-key map "v" 'project-vc-dir) > + (define-key map "c" 'project-compile) > + (define-key map "e" 'project-eshell) > + (define-key map "p" 'project-switch-project) > + (define-key map "g" 'project-find-regexp) > + (define-key map "r" 'project-query-replace-regexp) I think your choice of keys is better than in project-switch-commands. Maybe these keys should be copied to project-switch-commands, so it will to be in sync with project-prefix-map? Or is it possible to use project-prefix-map directly in project-switch-commands? For example, by using set-transient-map? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 18:48:03 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 22:48:03 +0000 Received: from localhost ([127.0.0.1]:49850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKN9-000681-8U for submit@debbugs.gnu.org; Tue, 16 Jun 2020 18:48:03 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:39519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKN7-00067X-Hv for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 18:48:01 -0400 Received: by mail-wr1-f53.google.com with SMTP id t18so309233wru.6 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 15:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aUW1rUsYJkzT+m9JY0336R0Xc10IQ48Xz3skzSTJ8gc=; b=AqkH4NdfACpfwHssosAATG0CC50LghqqjHAsj7ouJ7Tic9clxIxlaNhdTc8Vtr1Hqk 3DTxEFt87mIW7W0q378WQ8jBo5Fxa7r41QYuuIQREz5dJ46QUiqsF4Dgz+7OVIF1sCyc cQASligXeEZ53jEgPXdIDeEmf589HJxEU90AY+kTOO/bwm7+7MZMuv9Vv8nGh6TtF7zN +nTv2VEjN6ivGXxCXY5DnYWrjtaqmHXZgkftY1r7n8ioMFW3hXETkLzPKYNhn872QbwY uRsk2KVqPX3jshPYFHp2B4rAZg7GCnJcO0Ymxd4fOWqS4GX/y+c99alzSSTqz7MNVwJg uSFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aUW1rUsYJkzT+m9JY0336R0Xc10IQ48Xz3skzSTJ8gc=; b=QH0zg2qX2yEfsxXUKdGWF+WOfr/Cu6vs7IrS0HvGKQ5LWLplN5doIEx+zmQQBMpAXg lKnNMVyuBN/Ng+KeizcZp4grq7lt/e1U/1GmoH89Z7sRyPntsQWmbX+O0DOEMi7AmltE o0FkEq4dzUV//ZLTXFeFZcWdN2czlWpq4OgMODL9w2Dh1w2T+9k+p7f4EAOHTmBY7h7h 5iS6+3s3Wy7bExUvLWCmdplGmtIoKd9lWTFIZz9qqVy3tUw7w9GFBDc7yzpADo4DfIqR kcw+wNHyl/uz8seMIWPm814CdS0i2eZ46auh6WdZLrbTTcusAIfwe/fs6uM+kEFf6EkE bouA== X-Gm-Message-State: AOAM530/jmK9thopDTTm8Q7i6YwpgRdCXK31qq5nVsarJieTJBMWPztf exayrGSb4hcFy9EAhmP4XNRtRShC X-Google-Smtp-Source: ABdhPJzZZGm0RrQqZsc+eakk9qsHAVhMbiRVkuW83MMCB4Iyfh3zgihsFRqC0tATX9u2GYdkzZ05ag== X-Received: by 2002:a5d:6a03:: with SMTP id m3mr5167069wru.293.1592347675402; Tue, 16 Jun 2020 15:47:55 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o82sm6034275wmo.40.2020.06.16.15.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 15:47:54 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov , Theodor Thornhill References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> Date: Wed, 17 Jun 2020 01:47:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87v9jqfzbv.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 00:57, Juri Linkov wrote: >> + (define-key map "f" 'project-find-file) >> + (define-key map "b" 'project-switch-to-buffer) >> + (define-key map "s" 'project-shell) >> + (define-key map "d" 'project-dired) >> + (define-key map "v" 'project-vc-dir) >> + (define-key map "c" 'project-compile) >> + (define-key map "e" 'project-eshell) >> + (define-key map "p" 'project-switch-project) >> + (define-key map "g" 'project-find-regexp) >> + (define-key map "r" 'project-query-replace-regexp) > > I think your choice of keys is better than in project-switch-commands. > Maybe these keys should be copied to project-switch-commands, so it will to be > in sync with project-prefix-map? I'll make sure to keep them compatible in the default setup. > Or is it possible to use project-prefix-map directly in project-switch-commands? > For example, by using set-transient-map? We discussed that with Simen in private previously. The current implementation is "visual", which is good for discoverability. I think that kind of limits us, however, to showing only the most "essential" commands (think: ones that the user is most likely to use right after switching to a different project), and not the whole set. Or else people will spend more time searching for the key they need to press. And they won't use most of the entries in the list anyway. For that reason also, I just removed the project-shell entry from that list because we haven't reached to solid conclusion WRT shell vs eshell, and yet it was time to do a release. FWIW, I'm fine with either option, but we probably don't need both in the list (we should be fine with having both in project-prefix-map, however). I also forgot to mention that in the commit message (3bff583). Sorry! From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 19:25:46 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 23:25:46 +0000 Received: from localhost ([127.0.0.1]:49895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKxe-0005mj-6W for submit@debbugs.gnu.org; Tue, 16 Jun 2020 19:25:46 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:41623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKxc-0005mT-Je for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 19:25:45 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D06AE1BF203; Tue, 16 Jun 2020 23:25:36 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> Date: Wed, 17 Jun 2020 02:24:41 +0300 In-Reply-To: <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> (Dmitry Gutov's message of "Wed, 17 Jun 2020 01:47:53 +0300") Message-ID: <87eeqefvba.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > For that reason also, I just removed the project-shell entry from that list > because we haven't reached to solid conclusion WRT shell vs eshell, and yet > it was time to do a release. FWIW, I'm fine with either option, but we > probably don't need both in the list (we should be fine with having both in > project-prefix-map, however). > > I also forgot to mention that in the commit message (3bff583). Sorry! Very sad, this is the keybinding that I used most often :( From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 19:42:21 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 23:42:21 +0000 Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlLDg-0006CY-VX for submit@debbugs.gnu.org; Tue, 16 Jun 2020 19:42:21 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:32880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlLDd-0006CK-LI for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 19:42:19 -0400 Received: by mail-wr1-f47.google.com with SMTP id l11so431475wru.0 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 16:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6+FnpSOBzaKpd82FbvYuDfv+BWJ2GFv0VSaABXHbeDo=; b=XsTVQ+1zje0GJISj2+/xJgE/kgrC6hWyTQxhRmjwNVcFWCFdH2pelBuwpfB6olRIPI okAqcE1HSKiWfVIGc72YqRXWvsdjbyh9YnVudpV30HJTufEyMQXtljy8+Az1W6TIIH3o INoWXIKkMHHYcR+GYSf9CfOVia4VgGYJgV2LBbMdRlA6MMnHmNqzbyL5jQTD9gxStMoa SViIkVwRsqIf3dT4CpBDh3OdabpdqXLdBoU6uTstjVzts5Wpz2CsicTWnOJjmujCl7BN nyP3uMPmifLt2U4w6/72Lj8MNWe6Y9j0XXActvPqiKquuPbGct29txpf18RoRicHhtHX 6YcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6+FnpSOBzaKpd82FbvYuDfv+BWJ2GFv0VSaABXHbeDo=; b=eu5aI15TJ3gpuYKt0VpZ6wUODVxLhNSc7qFCDmPdKrqk0s72HiGlEDpr6geRpBtnsN LFzpyuOk2FU4cTmSAyXakPcQgUgpPm4Ib6jIAhnFx7LSbYb3p91ydJ2ZHlaIOG9x3oyN fq4m/OhYsq7DlJS0+ITXIHNsLNKSv1OQuaRB1wgrAdQbeFXVlr2OS8hJNVI8roarDW5+ GetMD3sZlE5NVzoe7p00z4qfTVNc169Y1s9uiVAlXfz5NdolM0VMrE3MSyCoYLmDRHZR UgOkCmX70LLqX+iT+3CuBD+4MT4uOSWWkPilE+1Nm0LmK04zr+yIzNxkPMQPWXIRACf7 oeOg== X-Gm-Message-State: AOAM530t0cPoWH2liI8ckNr9tgKgbt3trW0wMCHuLpRDfxNlSaKx0zfP rxmfoUPhDxmrVVr18CRQPv4= X-Google-Smtp-Source: ABdhPJx04Lf5VAoMxdjdkOgDQq4/KWsR8IG4wYm9ydaJW73YgOYrvq63kz5rzM/V4L4ZM3aMMJRi1A== X-Received: by 2002:adf:f54c:: with SMTP id j12mr5215643wrp.369.1592350931842; Tue, 16 Jun 2020 16:42:11 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id w1sm5798809wmi.13.2020.06.16.16.42.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 16:42:09 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> Date: Wed, 17 Jun 2020 02:42:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87eeqefvba.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 02:24, Juri Linkov wrote: > Very sad, this is the keybinding that I used most often:( Did you really use it in project-switch-project specifically, or because there are no global bindings for project commands yet? Would you like to whip up a poll, on emacs-devel or Reddit, about which of eshell or shell is more popular? We'll put the winner on ?e in project-switch-commands, and we can put the other one on "E" in project-prefix-map as well. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 07:07:42 2020 Received: (at submit) by debbugs.gnu.org; 17 Jun 2020 11:07:42 +0000 Received: from localhost ([127.0.0.1]:50536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlVuv-00026E-Vn for submit@debbugs.gnu.org; Wed, 17 Jun 2020 07:07:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:54750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlVus-000263-Tc for submit@debbugs.gnu.org; Wed, 17 Jun 2020 07:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlVus-0002Dd-Ot for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 07:07:38 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:44261) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlVuq-0005yq-1A for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 07:07:38 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 73F8A5C00FF for ; Wed, 17 Jun 2020 07:07:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 17 Jun 2020 07:07:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= resent-from:resent-date:resent-to:from:to:subject:references :date:in-reply-to:message-id:mime-version:content-type :resent-message-id; s=fm3; bh=87NQVWBv/+PLl3cpu9gyzfchnCEL8oFwVL //VGr1TiQ=; b=VyuzMP0z9QTE1M+UcXFNwTfWjFEbANhTuQlpRn8Q7zLe6tT6u1 zXjbbXUlCCpBTtJiANDjci/BeU3AiCVCwmCXgsZQ04eo2q8OEffV/L9WM7vIEqZ4 CC4l8O3whr4PZ9EOooZgaiKiEVEHKgw8YeMbVsnOvm1eYoWks4uwK0eUovKefj+2 kP3fgK8VavqqY80NJ+coK04dj7AlJHlWy4u8u1eIYAmsojgUk16MQYYum+yojoeV wmoCOWrac8ZMzPUhJSPyVJJQgb8NVKq/uIpfHz2ntVhtvxsXH9AExk4dB39urKo2 Dl+nZObz+OV94FvbXQE+A3ObkXcvTRrZRnjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:resent-date:resent-from :resent-message-id:resent-to:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=87NQVWBv/+PLl3cpu 9gyzfchnCEL8oFwVL//VGr1TiQ=; b=ay2tbwJsHx2xPcEDNiNKmntSxb4TOk1qf pBfuX4SNPO3bBxvENBBPSsUojzrr9hVzEC7eAeaTb2cZsAfwKxHjEaAhurzyyoiQ MuvTANU98u+/y42NeVYOLGgusRcRTvtolT94pJTRGgKBZkf7P4tpsnDD2ADQDYH9 NCBP5WqLtJOTh/5/xsXQe7KLmhGMQZm2A6MWztlt+qmR6hhdE50dliiPrhqmPHzt qsBw38xCvFAVvqUT3hzCmBzJwX1sNSMBg61DMEQMVM7M1iXMykkWFysgi3IQ0nj6 oQ2tzMjz0DrAEo88CnxrlMhjc/BxoPtZTzTgs+arggZZaUDnUtOiA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehmtderredtredtnecuhfhrohhmpedfrfhhihhl ihhpucfmrddfuceophhhihhlihhpseifrghrphhmrghilhdrnhgvtheqnecuggftrfgrth htvghrnhepveeigefgkeeghfelvdejieehvdfghffftdeivdehjeefveeltdefgeeikeel feeinecukfhppeejledrvdduledrudelledrvdduheenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphesfigrrhhpmhgrihhlrdhn vght X-ME-Proxy: Received: from localhost (p4fdbc7d7.dip0.t-ipconnect.de [79.219.199.215]) by mail.messagingengine.com (Postfix) with ESMTPA id F055D3060FE7 for ; Wed, 17 Jun 2020 07:07:33 -0400 (EDT) Resent-From: philip@warpmail.net Resent-Date: 17 Jun 2020 13:07:31 +0200 Resent-To: bug-gnu-emacs@gnu.org From: "Philip K." To: Juri Linkov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> X-Draft-From: ("gmane.emacs.bugs" 182051) Date: Wed, 17 Jun 2020 12:51:07 +0200 In-Reply-To: <87v9jqfzbv.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 17 Jun 2020 00:57:56 +0300") Message-ID: <87tuzaotic.fsf@warpmail.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-RMAIL-ATTRIBUTES: -------- Resent-Message-Id: <20200617110733.F055D3060FE7@mailuser.nyi.internal> Received-SPF: pass client-ip=66.111.4.29; envelope-from=philip@warpmail.net; helo=out5-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 07:07:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Juri Linkov writes: > I think your choice of keys is better than in project-switch-commands. > Maybe these keys should be copied to project-switch-commands, so it will to be > in sync with project-prefix-map? > > Or is it possible to use project-prefix-map directly in project-switch-commands? > For example, by using set-transient-map? I tried implementig it, and it seems to work. The patch below isn't a full commit, since I changed the structure of project-switch-commands (it's now mapping command to description), but didn't update the docstring. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index c5301dccd3..6cb9811d3d 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -860,12 +879,12 @@ project-prompt-project-dir ;;;###autoload (defvar project-switch-commands - '((?f "Find file" project-find-file) - (?r "Find regexp" project-find-regexp) - (?d "Dired" project-dired) - (?v "VC-Dir" project-vc-dir) - (?s "Shell" project-shell) - (?e "Eshell" project-eshell)) + '((project-find-file "Find file") + (project-find-regexp "Find regexp") + (project-dired "Dired") + (project-vc-dir "VC-Dir") + (project-shell "Shell") + (project-eshell "Eshell")) "Alist mapping keys to project switching menu entries. Used by `project-switch-project' to construct a dispatch menu of commands available upon \"switching\" to another project. @@ -877,9 +896,10 @@ project-switch-commands (defun project--keymap-prompt () "Return a prompt for the project swithing dispatch menu." (mapconcat - (pcase-lambda (`(,key ,label)) + (pcase-lambda (`(,cmd ,label)) (format "[%s] %s" - (propertize (key-description `(,key)) 'face 'bold) + (propertize (key-description (where-is-internal cmd project-prefix-map t)) + 'face 'bold) label)) project-switch-commands " ")) @@ -890,14 +910,10 @@ project-switch-project The available commands are picked from `project-switch-commands' and presented in a dispatch menu." (interactive) - (let ((dir (project-prompt-project-dir)) - (choice nil)) - (while (not choice) - (setq choice (assq (read-event (project--keymap-prompt)) - project-switch-commands))) - (let ((default-directory dir) - (project-current-inhibit-prompt t)) - (call-interactively (nth 2 choice))))) + (let ((default-directory (project-prompt-project-dir)) + (project-current-inhibit-prompt t)) + (message "%s" (project--keymap-prompt)) + (set-transient-map project-prefix-map))) (provide 'project) ;;; project.el ends here --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 10:27:49 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 14:27:49 +0000 Received: from localhost ([127.0.0.1]:51959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlZ2b-0005a0-Dd for submit@debbugs.gnu.org; Wed, 17 Jun 2020 10:27:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlZ2Y-0005Zn-Ms for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 10:27:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45757) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlZ2S-00069n-O4; Wed, 17 Jun 2020 10:27:40 -0400 Received: from [176.228.60.248] (port=1294 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlZ2H-0007fq-AM; Wed, 17 Jun 2020 10:27:30 -0400 Date: Wed, 17 Jun 2020 17:27:13 +0300 Message-Id: <838sgl22f2.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> (message from Dmitry Gutov on Wed, 17 Jun 2020 00:23:27 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 41890@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 17 Jun 2020 00:23:27 +0300 > > On 16.06.2020 20:16, Eli Zaretskii wrote: > > I certainly would. It is very unusual for an optional package to have > > its bindings in files that are preloaded into every Emacs session. > > What do you mean by "optional"? I mean it isn't preloaded, but is loaded on demand. > How is it different from the aforementioned tabs? tab-bar _is_ preloaded. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 10:28:54 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 14:28:55 +0000 Received: from localhost ([127.0.0.1]:51964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlZ3e-0005bo-OA for submit@debbugs.gnu.org; Wed, 17 Jun 2020 10:28:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlZ3c-0005bY-Tg for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 10:28:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45780) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlZ3X-0006NQ-8H; Wed, 17 Jun 2020 10:28:47 -0400 Received: from [176.228.60.248] (port=1376 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlZ3V-0000rl-B7; Wed, 17 Jun 2020 10:28:46 -0400 Date: Wed, 17 Jun 2020 17:28:30 +0300 Message-Id: <837dw522cx.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <65a844bc-1242-d88e-cab0-901704da16ef@yandex.ru> (message from Dmitry Gutov on Wed, 17 Jun 2020 00:35:26 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <65a844bc-1242-d88e-cab0-901704da16ef@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Cc: 41890@debbugs.gnu.org > Date: Wed, 17 Jun 2020 00:35:26 +0300 > > From multiple discussions, over a certain period of time, mostly here > in emacs-devel, I have arrived at an impression that there exists a > general desire to have global bindings for project functions, in > "default" Emacs, without customization. > > And that the 'C-x p' prefix is both unoccupied and looks logical to use > for that purpose. > > What do you think about that? > > As an aside, I'd like to do a similar thing for Flymake, with > Flycheck-inspired prefix of 'C-c !' a bit later. I don't think I'd object, but this is orthogonal to the issue on which I commented: where are the key bindings defined. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 11:50:04 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 15:50:04 +0000 Received: from localhost ([127.0.0.1]:52003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlaK8-0007cy-Ll for submit@debbugs.gnu.org; Wed, 17 Jun 2020 11:50:04 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:50711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlaK4-0007ch-FA for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 11:49:59 -0400 Received: by mail-wm1-f43.google.com with SMTP id l17so2331867wmj.0 for <41890@debbugs.gnu.org>; Wed, 17 Jun 2020 08:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Yq7MKr6yd4KKrFxAcrwxTJgIzKPFyGVjYNiwN9V27CU=; b=KAxPE9aMhFHRpjXkymTXpWPFjjAi7RGFz7tyCYlO1cB96p4w7eRso2Am5BtRclEHgo J6pIb5Ys93xxZOM8jzyplkVCr18XqBrUgj+riSWiAnSBG9RZlDQjf7jU+5kgUoCc8Isv DFYYZjSvCALNKWQ+V2RPYAadiWebiJzm84puV87EO9IffwVjeNLqrPc/tphztE/fRyKh ySxFsbHomdswJzIGj0QmHDxHr4s0EuVcdbNwJ1qwH78xeTOrex/BALUx4bPhsLOw3N7p ItYTHQdjnmAXalt7IrNdC2VcEUdlLEZU5ToOSrQ9c3yNgLS8s8oNBimulm/EDQLqrES2 q7aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Yq7MKr6yd4KKrFxAcrwxTJgIzKPFyGVjYNiwN9V27CU=; b=W45CRxZps9/98ntQY8PT+I2Xp0oSfATvpxmVwZewYXUZsbPVErdRk/zN0HUgxYg3Z+ gcy+JwUVH4jB2QdQ4g/u66+2jb3eFccfERiKsGBRyFXVlRfn3PCuzRrgSftPOKXVLzp6 ebjc/L2nSM15wmTnhv1CNRWe4ntG4+1ywE5wEe4MABIV6UZztKacb8W4ncogbCxhL6xz VIWKurBYGpfn6543Pc3Ix6+I4tZB+/HCvaKaClg9B1h9LJ7kL3tTIxTyCrwvm+xU/dZU Qoc14rPymz3BOZNvO+gj8TejEAsOSn2VIJsQqcQ0BdsWbQLbXAILCNuM02/7jg0fsnP9 38gQ== X-Gm-Message-State: AOAM5305oIJ1DSI0IdUmVPsO7dOrqC8/DM4lpNWlYsV7qdfTTNjTQYrU fLzcTJp45iF9VEdEK9DHnYbKxgEE X-Google-Smtp-Source: ABdhPJzMhKd/tPXnPg4K/aI7JmpkE27o/TWmS7aqG8ficP5zzi8g05n85niv5S3w0AxCTLFpkLAnkw== X-Received: by 2002:a1c:1d94:: with SMTP id d142mr9356120wmd.42.1592408990182; Wed, 17 Jun 2020 08:49:50 -0700 (PDT) Received: from [192.168.0.58] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id 138sm199473wma.23.2020.06.17.08.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 08:49:49 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> From: Dmitry Gutov Message-ID: <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> Date: Wed, 17 Jun 2020 18:49:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <838sgl22f2.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 17:27, Eli Zaretskii wrote: > I mean it isn't preloaded, but is loaded on demand. Okay, but... the commands in the keymap will all be autoloaded. So whenever somebody calls them, the aforementioned optional package will get loaded. I'm not sure what the practical issue with that is. The issue on the other side (keeping the keymap definition in project.el) is that it's an ELPA package as well. And so far we've said that ELPA packages shouldn't significantly modify a user's Emacs just by the virtue of being installed. OTOH, if these bindings will be defined in Emacs 28, perhaps this rule can be given exception in these two cases. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 12:33:26 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 16:33:26 +0000 Received: from localhost ([127.0.0.1]:52049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlb0A-0000J1-JO for submit@debbugs.gnu.org; Wed, 17 Jun 2020 12:33:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlb06-0000Ii-Un for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 12:33:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47635) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlb01-0003um-7z; Wed, 17 Jun 2020 12:33:17 -0400 Received: from [176.228.60.248] (port=1243 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlb00-0004An-19; Wed, 17 Jun 2020 12:33:16 -0400 Date: Wed, 17 Jun 2020 19:33:00 +0300 Message-Id: <835zbp1wlf.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> (message from Dmitry Gutov on Wed, 17 Jun 2020 18:49:47 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: theo@thornhill.no, 41890@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 17 Jun 2020 18:49:47 +0300 > > On 17.06.2020 17:27, Eli Zaretskii wrote: > > I mean it isn't preloaded, but is loaded on demand. > > Okay, but... the commands in the keymap will all be autoloaded. So > whenever somebody calls them, the aforementioned optional package will > get loaded. I'm not sure what the practical issue with that is. I don't see how this is related to the issue at hand. All I'm saying is that a package, including its key bindings, shouldn't be loaded until some of its feature is invoked. Therefore, the best place for a package's keybindings is in the package itself. What you describe seems to fit this principle. > The issue on the other side (keeping the keymap definition in > project.el) is that it's an ELPA package as well. And so far we've said > that ELPA packages shouldn't significantly modify a user's Emacs just by > the virtue of being installed. We could make the keybindings autoloaded without having them defined them when the package loads, couldn't we? By having the define-key on the same line as the autoload cookie, like bookmark.el does. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 15:10:40 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 19:10:40 +0000 Received: from localhost ([127.0.0.1]:52209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jldSK-00046j-Kw for submit@debbugs.gnu.org; Wed, 17 Jun 2020 15:10:40 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:57447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jldSH-00046U-PO for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 15:10:39 -0400 Date: Wed, 17 Jun 2020 19:10:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592421030; bh=39CjkoOXTRGp4I+5vlWkImN4VTVhaanbT82QX5GlG7c=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=jjAtE1aPQEookr0zsJtsDM/vVGUPcbNlv3A7W1ujwRws8eqHNVj0wRaUvTm1q2ovu LGK/p1epHQWCZqXiwIthOMQMd3VYH0TfRy35FvecWIYycSLWj7ZavSWjyw5Gi4Viox fo1DJDeAlGJmYXH7oZNHsEuz1ed2rJdr9e+sNwLV5Z6zatWvssqeV326PSt99sQJpQ wq76V8IKbgso4sINSmjfujub7m9shGRWV7mmebPCZE4fWcj4PMKMjRxIQTE1ic2m7h MlnwUyioGBi6eJnWhNa/Irm2gTwujrJJl4zTuHnKK58xllIq/eUjuyGbsQhQGUJeg/ x87QeBHP1rugw== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: <87y2olfqzw.fsf@thornhill.no> In-Reply-To: <87imfqoipy.fsf@tcd.ie> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87imfqoipy.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_QT0ZtRRnPb42aq5krtRcyfU3VpFrklaM43QE8q582aE" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_QT0ZtRRnPb42aq5krtRcyfU3VpFrklaM43QE8q582aE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! "Basil L. Contovounesios" writes: > ;;;###autoload (define-key ...) > > is preferable to > > ;;;###autoload > (define-key ...) > Nice idea! Did not know about this :) Since Eli also mentioned this, I've attached such a patch. Theo --b1_QT0ZtRRnPb42aq5krtRcyfU3VpFrklaM43QE8q582aE Content-Type: text/x-patch; name=project-bindings.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-bindings.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLjg3Y2QwMTU5MjQgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt MTA3LDYgKzEwNywyNCBAQCBwcm9qZWN0LWZpbmQtZnVuY3Rpb25zCiAoZGVmdmFyIHByb2plY3Qt Y3VycmVudC1pbmhpYml0LXByb21wdCBuaWwKICAgIk5vbi1uaWwgdG8gc2tpcCBwcm9tcHRpbmcg dGhlIHVzZXIgaW4gYHByb2plY3QtY3VycmVudCcuIikKIAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ2 YXIgcHJvamVjdC1wcmVmaXgtbWFwCisgIChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkp KQorICAgIChkZWZpbmUta2V5IG1hcCAiZiIgJ3Byb2plY3QtZmluZC1maWxlKQorICAgIChkZWZp bmUta2V5IG1hcCAiYiIgJ3Byb2plY3Qtc3dpdGNoLXRvLWJ1ZmZlcikKKyAgICAoZGVmaW5lLWtl eSBtYXAgInMiICdwcm9qZWN0LXNoZWxsKQorICAgIChkZWZpbmUta2V5IG1hcCAiZCIgJ3Byb2pl Y3QtZGlyZWQpCisgICAgKGRlZmluZS1rZXkgbWFwICJ2IiAncHJvamVjdC12Yy1kaXIpCisgICAg KGRlZmluZS1rZXkgbWFwICJjIiAncHJvamVjdC1jb21waWxlKQorICAgIChkZWZpbmUta2V5IG1h cCAiZSIgJ3Byb2plY3QtZXNoZWxsKQorICAgIChkZWZpbmUta2V5IG1hcCAicCIgJ3Byb2plY3Qt c3dpdGNoLXByb2plY3QpCisgICAgKGRlZmluZS1rZXkgbWFwICJnIiAncHJvamVjdC1maW5kLXJl Z2V4cCkKKyAgICAoZGVmaW5lLWtleSBtYXAgInIiICdwcm9qZWN0LXF1ZXJ5LXJlcGxhY2UtcmVn ZXhwKQorICAgIG1hcCkKKyAgIktleW1hcCBmb3IgcHJvamVjdCBjb21tYW5kcy4iKQorCis7Ozsj IyNhdXRvbG9hZCAoZGVmaW5lLWtleSBjdGwteC1tYXAgInAiIHByb2plY3QtcHJlZml4LW1hcCkK KwogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBwcm9qZWN0LWN1cnJlbnQgKCZvcHRpb25hbCBtYXli ZS1wcm9tcHQgZGlyKQogICAiUmV0dXJuIHRoZSBwcm9qZWN0IGluc3RhbmNlIGluIERJUiBvciBg ZGVmYXVsdC1kaXJlY3RvcnknLgo= --b1_QT0ZtRRnPb42aq5krtRcyfU3VpFrklaM43QE8q582aE-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 15:40:19 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 19:40:19 +0000 Received: from localhost ([127.0.0.1]:52223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jldv1-0004nm-DJ for submit@debbugs.gnu.org; Wed, 17 Jun 2020 15:40:19 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:34399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlduy-0004nV-B8 for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 15:40:17 -0400 Received: by mail-wr1-f46.google.com with SMTP id r7so3651451wro.1 for <41890@debbugs.gnu.org>; Wed, 17 Jun 2020 12:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/5VNP3NnjL2kHdFDpRlzGGmZUXF56dS5PVOg+scqB5A=; b=Iy+DcnU7ShCHENLFlLiYZJ8TrmiTk/jQkUn23DMFmg8UU+zwNPJRfVyR7gvjDNznp3 ldLE3s9JmuSULd+oVGhEjzQQo/aKlosO+NhAh8BzxZOcocRSVjJaAFnABsvCkQD9HuGr c25jp96A5nFxS/pmB0nvDTFQl8gTa028OogOhKnTJLTAYp1j/CURlgKsJkfuwFijnwiq eYY6EdXru7V0m5mhC6RJXNf7b6T5D5/bQsCy6HBmDRZeMMiApTa33MKBy9GimSEIXAz9 PHQqtjIAy7FnVdinKNwB6OJGI4GEO4dtMFExZ0mh8chvr+OpH6a/qddzfn5Eu1gBe4TD extQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/5VNP3NnjL2kHdFDpRlzGGmZUXF56dS5PVOg+scqB5A=; b=KmgcogYJWF9oFpEjFxsIao4xIjumB76hqq9bqOL3T/eT2BjZoaMAYkIRuXmsVTmkBG +h3w5rHa3x/qCztLyCAsr12po/qwF+VVewdWbMEXGPM7AQWXk4iHUml8gY7fMoQUo9Qy YDs4QOQOdNKsneQMpcJ7NkTSqg70RIQwU+nGgyIl/cxJThUkcZMvLrm3pK9Wb8I7/6VP OFVPNzFNrb9xTey7eIHcCxSyd6RpgZ5z3z/jaKeHsKoxne7AL2wlVMmcLZmblij+CKR/ 8nTAgraz91BLBLz92r4ssJipUprZaiYKNdmWHcd7ojEHT+ZfNp9XKL9il9a89YOUgi1Z 1Dig== X-Gm-Message-State: AOAM531GzcfverWmivhfpBOl9HCE23F4nBsfC7x1UY025UiDG6kg9RWY U+FQuE3ib4wW3u9dgaII5M2H9A== X-Google-Smtp-Source: ABdhPJy+itPvHbU4PHImeIHCcPwTwLOFOg/Y4jkaXrcLd5wAL912oJqhp917FkTFNJoms17cZgHz1A== X-Received: by 2002:adf:f64c:: with SMTP id x12mr750638wrp.281.1592422810349; Wed, 17 Jun 2020 12:40:10 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id o10sm674189wrj.37.2020.06.17.12.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 12:40:09 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87imfqoipy.fsf@tcd.ie> <87y2olfqzw.fsf@thornhill.no> Date: Wed, 17 Jun 2020 20:40:08 +0100 In-Reply-To: <87y2olfqzw.fsf@thornhill.no> (Theodor Thornhill's message of "Wed, 17 Jun 2020 19:10:24 +0000") Message-ID: <87tuz9bhwn.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > "Basil L. Contovounesios" writes: > >> ;;;###autoload (define-key ...) >> >> is preferable to >> >> ;;;###autoload >> (define-key ...) > > Nice idea! Did not know about this :) > > Since Eli also mentioned this, I've attached such a patch. LGTM, thanks. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 17:25:54 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 21:25:54 +0000 Received: from localhost ([127.0.0.1]:52293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlfZC-0007I3-3V for submit@debbugs.gnu.org; Wed, 17 Jun 2020 17:25:54 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlfZ8-0007HL-J3 for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 17:25:51 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 045BCFF805; Wed, 17 Jun 2020 21:25:42 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> Date: Thu, 18 Jun 2020 00:23:53 +0300 In-Reply-To: <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> (Dmitry Gutov's message of "Wed, 17 Jun 2020 02:42:08 +0300") Message-ID: <87tuz9crt6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Very sad, this is the keybinding that I used most often:( > > Did you really use it in project-switch-project specifically, or because > there are no global bindings for project commands yet? I think global bindings for project commands are more important than project-switch-project specifically. > Would you like to whip up a poll, on emacs-devel or Reddit, about which of > eshell or shell is more popular? No, it's not an important question. > We'll put the winner on ?e in project-switch-commands, and we can put the > other one on "E" in project-prefix-map as well. Do you want to remove this intuitive binding 's' from 'shell' command because you want to use 's' for some other command? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 18:17:03 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 22:17:03 +0000 Received: from localhost ([127.0.0.1]:52350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgMh-00006x-9r for submit@debbugs.gnu.org; Wed, 17 Jun 2020 18:17:03 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:39286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgMc-00006L-M6 for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 18:17:02 -0400 Received: by mail-wr1-f49.google.com with SMTP id t18so4007203wru.6 for <41890@debbugs.gnu.org>; Wed, 17 Jun 2020 15:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lGfaB/d6vOgMOTCHVKlu4SEBlFnLTr/ynxD2va2B1Fk=; b=aBrYxaghQtbO9VVkRaB3L2OOwFCIBQR4K5HoCk/+HwJyWqjE8wPH9/yNkWCS40Qv5n ZzanEV8e8o9qHBxkBkt9+cQp8HmAHgdWHiwIkcR1vuajRTw3U8ksZz0OVd2HvMyhI7i5 IbcudsZqvq7tnkiojloWEiFlmoZW9hAq3tYjxlpFtU1xC73Lb7r1vm8nkgu0DfPotAN0 sP1/K+Mxr/xr32nOPU8U6OopIOanS/WUXt7NzeKE1SpN+9VrKV+t0E/gUx+wTcXbG9p9 GLRnPa+YY3BBRDmjw8UDdehEt6oJ0enDuprcA0Ois/d6gPkX3LiGGxu22YkozCabzAVo P5Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lGfaB/d6vOgMOTCHVKlu4SEBlFnLTr/ynxD2va2B1Fk=; b=sZ/fc+iOug6OF8CNqOVIow6bnZEZtH0G3kvvYQ6NKuVuzcVidcdqRMu8HFdA7i+63o icND3gR2bl8eYVfj4ZQwsFHONf1m9SZ7SSwBkxJeCt9Ra0dLKR7OMGpVD1KB7lq7qg3K RP6WPbF5uTRgduZgAHQG/g8PTYskkCudubZgKyPl1woyjzLimBLQIh17xdqY3ByW+e7H b5WxAUfeuFsX1c+4h9KaFIN47jp/bPWpva5BPvd9ptUZxDwvPUSWBr4w7fqk2VQCn2kZ z/MQXGvbXv+T+MSH7/g9JkBZt3mvp1bnHMgJu8uh821y5hMdWWtR7f6xGosdyBvcrdv7 +uBg== X-Gm-Message-State: AOAM5309WArlmJ/jL4G3t9rphm7qBlK6QBgMDuQKVcAYoWAi+q7Rujg3 iirjkyJtTfZrEbEhXSPVDJk= X-Google-Smtp-Source: ABdhPJylASL/nVvlhazhIcPPvWY7rsCn7LseW1JgEl01cqh1ZL026xbsPGTDl6MyRZNejXIQHHDfvw== X-Received: by 2002:a5d:4e03:: with SMTP id p3mr1366973wrt.350.1592432212849; Wed, 17 Jun 2020 15:16:52 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id g3sm1180012wrb.46.2020.06.17.15.16.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 15:16:52 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> Date: Thu, 18 Jun 2020 01:16:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87tuz9crt6.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 00:23, Juri Linkov wrote: >>> Very sad, this is the keybinding that I used most often:( >> >> Did you really use it in project-switch-project specifically, or because >> there are no global bindings for project commands yet? > > I think global bindings for project commands are more important > than project-switch-project specifically. Very good. >> We'll put the winner on ?e in project-switch-commands, and we can put the >> other one on "E" in project-prefix-map as well. > > Do you want to remove this intuitive binding 's' from 'shell' command > because you want to use 's' for some other command? Maybe project-isearch? I recall you wanted that one day. If not, I'm fine with keeping project-shell on 's' for now. But if reach the shortage of characters on this keymap someday, and some unbound command would really fit that letter, I'd rather not dedicate two different characters to shell-like functionality. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 18:23:35 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 22:23:35 +0000 Received: from localhost ([127.0.0.1]:52354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgT1-0000GJ-0Y for submit@debbugs.gnu.org; Wed, 17 Jun 2020 18:23:35 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:36089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgSy-0000G5-Th for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 18:23:33 -0400 Received: by mail-wr1-f49.google.com with SMTP id q11so4031051wrp.3 for <41890@debbugs.gnu.org>; Wed, 17 Jun 2020 15:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y6IHkoIH9TNHeuXnji8uuvWCKKYP/99c3KansyNdxa0=; b=uASy6i8Jk4LLV4BfpF7wU1eKFJFYBYo6QTdfYn7Kfd2LQZ7zbbw5Mom4NBqWhji1HQ penPm7J+EiY6pFkyg+9KuRdqTN/zPawBuQH/4ayf9IZAuAn3m8IHBiemfvOnCrlwuHu+ rJsvrI1Ma+eHszO9dt1ouKecwXTjQcxsC1y1Uzvuuvw9uBdUxzZgSeK/H97Ju2xC+NmA KHt0T8TyfbdvfyiYD8WpvufCj68JHfrz9MI0CIexgPBepw1/CDC1jtg+GUDToVCElfAE szBoq76x/gfyYGvEhbFmUirS3YX8nKp0YO3mlSmirjhme7HLoDxZgglKPJotOwoiveQ5 5HTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y6IHkoIH9TNHeuXnji8uuvWCKKYP/99c3KansyNdxa0=; b=MrxDwRPTS6l0GNhvmE2hzwUdoFU/9CivfdzmqYPh8tQk+tWfMh9OHVQOj3JD8UvJNs X+X76iw+WvfyNN+eqJvj2fDkwIsPsR0n8KZJQti1WPQ32OZKydO7rvP7qWSKlEH8AnDv 02stK8bd3RwUMLOlGxT1guKf79K55QKOY5Fk23A9EbvaUKRB7BiWIYZ0gH9P2VtKm85F 3aC+yL8q5S6Ur4pe6Ls1ZOOuL0hNOpjhC0UwSTpRZWEcf7GuAfzkzt9CIQZxAu4fDoUg gce/8eynyelsHp0Bu/3VCNTaGEye4trQxZuV3y891h91Qo5sNaR7bHkxn6R4kjGl/aHZ g6VA== X-Gm-Message-State: AOAM532VGmnsrA9qFEMiO10whzuA0ofLuh6XW/Ur/BAmTdthBY6Rpui6 2OMnFSjvvPFi5Kgs5Qpb+zY= X-Google-Smtp-Source: ABdhPJz8BT3v+pu6Q7J0MhITTYfr1zdiqLSyI/09GNm1EyMaZkDJVXBn82To6YmshfqCKVKXD6GWAg== X-Received: by 2002:adf:dd46:: with SMTP id u6mr1300623wrm.44.1592432607142; Wed, 17 Jun 2020 15:23:27 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 4sm1083364wrf.74.2020.06.17.15.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 15:23:26 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> <835zbp1wlf.fsf@gnu.org> From: Dmitry Gutov Message-ID: <783b3a39-62ca-46b5-83a4-1989e8ec2062@yandex.ru> Date: Thu, 18 Jun 2020 01:23:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <835zbp1wlf.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 19:33, Eli Zaretskii wrote: >> On 17.06.2020 17:27, Eli Zaretskii wrote: >>> I mean it isn't preloaded, but is loaded on demand. >> >> Okay, but... the commands in the keymap will all be autoloaded. So >> whenever somebody calls them, the aforementioned optional package will >> get loaded. I'm not sure what the practical issue with that is. > > I don't see how this is related to the issue at hand. All I'm saying > is that a package, including its key bindings, shouldn't be loaded > until some of its feature is invoked. But if we autoload the bindings definition forms, wouldn't that have essentially the same effect? > Therefore, the best place for a > package's keybindings is in the package itself. What you describe > seems to fit this principle. Okay. >> The issue on the other side (keeping the keymap definition in >> project.el) is that it's an ELPA package as well. And so far we've said >> that ELPA packages shouldn't significantly modify a user's Emacs just by >> the virtue of being installed. > > We could make the keybindings autoloaded without having them defined > them when the package loads, couldn't we? By having the define-key on > the same line as the autoload cookie, like bookmark.el does. That would generally be considered problematic because the keymap would take effect right after the user updates to the newest version of project.el. Because package.el also compiles and evaluates autoloads. Anyway, I'll apply this patch now, but we can continue this discussion. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 18:30:35 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 22:30:35 +0000 Received: from localhost ([127.0.0.1]:52359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgZm-0000Rb-OM for submit@debbugs.gnu.org; Wed, 17 Jun 2020 18:30:34 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:48977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgZi-0000RL-Uq for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 18:30:32 -0400 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7C435100003; Wed, 17 Jun 2020 22:30:19 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> Date: Thu, 18 Jun 2020 01:27:59 +0300 In-Reply-To: <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 01:16:50 +0300") Message-ID: <87r1ud9vkg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Do you want to remove this intuitive binding 's' from 'shell' command >> because you want to use 's' for some other command? > > Maybe project-isearch? I recall you wanted that one day. project-isearch should use 'C-x p C-s' like it's used in e.g. M-s a C-s dired-do-isearch M-s a C-s vc-dir-isearch > If not, I'm fine with keeping project-shell on 's' for now. > > But if reach the shortage of characters on this keymap someday, and some > unbound command would really fit that letter, I'd rather not dedicate > two different characters to shell-like functionality. I don't insist on 's' for shell. Maybe 's' is more suitable for 'project-search'. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 18:39:07 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 22:39:07 +0000 Received: from localhost ([127.0.0.1]:52373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlgi3-0000eH-1b for submit@debbugs.gnu.org; Wed, 17 Jun 2020 18:39:07 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:37701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlghz-0000dj-TW for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 18:39:05 -0400 Received: by mail-wm1-f53.google.com with SMTP id y20so3672799wmi.2 for <41890@debbugs.gnu.org>; Wed, 17 Jun 2020 15:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t8d91hB+7sLabsMX4ldrJvMrQHMwMzG6TOKKiz2K03E=; b=Nj1rz74umOk2ZpnVTJiBnyDighMIPxOFGCnG2Co0oW9NSdUAvhbkTeAVShzjXBp9tR 11dwpFgSN6PYTcQ4rmtLwlJZ6ouxSz3GOzePUP/UPDXuVQodO620I5fkDmOOg2K4cd2B IRgxSWf969HPR10nu52p4st3QbkjHf7oBF7bQFvRV0ct0e8bIRhjDhIyYhxJirmk4CdW Hb/WbWMBdiCUnMZbYlNmpYzFFd7OFiFP3tylgu7FMcbP7I5OdMaIY4z1cyyMnceoVNbD oSLtQFtfzsiNn6Z9qiQO9puVplMlLjIzHyH124Vg3C1uCN7Q2hRBx9Bsu0iw/9lLxmHa RtaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t8d91hB+7sLabsMX4ldrJvMrQHMwMzG6TOKKiz2K03E=; b=lyxHWRopdNGeEY25rhMrybJZHamhwD6dG+SMvT5tvkipULPYu31EUCtO0lnOU8YkIX zy28sWFq/zOuGzHXD4GbAIPyNq8M6/aIVnzshiZgbVuZXijW9kgO6PfHjHKWBhMy9D55 ggV7F0ceNaEVyESe8yXnU31k3uWQxmLWkS77DnUgOU7ugCWdU1gEoblKUnjPdml4mJFm MfXGIJwd27zvE0VBwWuxfIewza4NRtN5y2miyxQxyZ0+NM9Aq8ZmLstqABS2lQmjzBnB zlwMf4NCxLuAIqCDnpO4/Otum1YJbFPdY6QZDLoMFknwbhzAPqsD1oyuPTOrmGpyQqih Yf5g== X-Gm-Message-State: AOAM531RK6iHG8vsvSCUSXf+wUnsPmZLreyMFajno1/C6jfG8cnaJWvy LewSBUpiMhsaGB8ciaLToqc= X-Google-Smtp-Source: ABdhPJxk/VcQd+x3Dnj4KV8o1UFgLO/n7lTbexbSh1yiXKBd/eCB4J3EMulblneGAoMxyLFawn/NGg== X-Received: by 2002:a1c:3c08:: with SMTP id j8mr855511wma.158.1592433537839; Wed, 17 Jun 2020 15:38:57 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u7sm1141153wrm.23.2020.06.17.15.38.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 15:38:57 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> Date: Thu, 18 Jun 2020 01:38:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87r1ud9vkg.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 01:27, Juri Linkov wrote: >>> Do you want to remove this intuitive binding 's' from 'shell' command >>> because you want to use 's' for some other command? >> >> Maybe project-isearch? I recall you wanted that one day. > > project-isearch should use 'C-x p C-s' like it's used in e.g. > > M-s a C-s dired-do-isearch > M-s a C-s vc-dir-isearch Sounds good. >> If not, I'm fine with keeping project-shell on 's' for now. >> >> But if reach the shortage of characters on this keymap someday, and some >> unbound command would really fit that letter, I'd rather not dedicate >> two different characters to shell-like functionality. > > I don't insist on 's' for shell. Maybe 's' is more suitable for 'project-search'. Perhaps. As it is currently, though, I'm not in a hurry to advertise this command because of its performance characteristics. And because it can simply give up with "gpg: decrypt_message failed: Unexpected error". From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 19:07:24 2020 Received: (at 41890-done) by debbugs.gnu.org; 17 Jun 2020 23:07:24 +0000 Received: from localhost ([127.0.0.1]:52388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlh9Q-0001Jw-LM for submit@debbugs.gnu.org; Wed, 17 Jun 2020 19:07:24 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:39564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlh9O-0001Jh-7K for 41890-done@debbugs.gnu.org; Wed, 17 Jun 2020 19:07:22 -0400 Received: by mail-wm1-f50.google.com with SMTP id t194so3703851wmt.4 for <41890-done@debbugs.gnu.org>; Wed, 17 Jun 2020 16:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OHgNPMesEqAFEMpZNCuCDZVgTHWZBXx2X6PjWMVZ7tA=; b=S8Moiy1Xf26wQRmpafe+O4JSuLV/WbVo6nxnd2l3yV9ODssvKqEWZtdbYZhNZAsNXr mH4tAtUkMdnQmZwEvNfwZkdq3cLSjOB4YAIXPHcxojJ5WtETh9HFwVhYL2G+jlVyf9FD TD+DkGIU10OxXSByaLIVYh91OHgprqo9VH0zJh5WZ2F6c9+KJYitDYi+ViUSSnN0a3e0 v2fPjCRFUAn3R2vJaS7LP4NXsl3VxrJWEHMfSNKJ7H1wzxSRCgzEY+XmY+OlTo6m+W9G v+mS2QSRwZuBQp4p5rhJbl33421ckmiZaKLlEtkMZb6zs/WxtctGLdlbccREuB47Hknp 8M7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OHgNPMesEqAFEMpZNCuCDZVgTHWZBXx2X6PjWMVZ7tA=; b=cn5DsYE0bc/Y0uPnR3gA6XNYjtfr9vC2gxoWJAwCx/o7n9c9BGe0VzsAZtSjeMObMM ZmZBfCIuth9ATSn1ETxeUWnhaiN5EHRMhtVVi7dS6xzGQkP4bpFTcbF/dpQbYw0QNzw2 fYFibED4xTsikWBe1S9ePcG7CP8T+Tz3K57EFPIcffE/l2/sgbXBsXA7/UrYUPgbFMXO Wr2/qLHpFXPMehttjFT6tteRacm0ez8iWqHOogugyVODBiCfSIMWaK3oi2hUEKCYZU6B rS+yN6D8MccdUvlMN/52KRvj9RMwwPRuwofGK/7W4SDtwXvCdhmtYIs/up5E0AgwifsE l7aA== X-Gm-Message-State: AOAM530l3SjSlacXJ4MkRnhbgJoNyPN/nalAbhGfZltnjg/YAJJ1eHCq LqoWTcLp2HRYOUizerY7/NjzdrEb X-Google-Smtp-Source: ABdhPJx0RRuJRlcSDDA/1/C6nntQzkp1IMN848S1xnp4yqMMOTmaCo3I2n7greSUJl/bg78ygyhoIg== X-Received: by 2002:a1c:a444:: with SMTP id n65mr884707wme.99.1592435236023; Wed, 17 Jun 2020 16:07:16 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id y16sm1104779wro.71.2020.06.17.16.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 16:07:15 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Theodor Thornhill , "Basil L. Contovounesios" References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87imfqoipy.fsf@tcd.ie> <87y2olfqzw.fsf@thornhill.no> From: Dmitry Gutov Message-ID: Date: Thu, 18 Jun 2020 02:07:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87y2olfqzw.fsf@thornhill.no> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890-done Cc: 41890-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 22:10, Theodor Thornhill wrote: > Since Eli also mentioned this, I've attached such a patch. Applied, thank you! In the future, though, please include commit messages with the patches (at least, as soon as you're reasonably confident the patch will be accepted). See CONTRIBUTE for the message requirements. Also, I'm happy to report that your assignment is now on file. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 19:27:29 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 23:27:29 +0000 Received: from localhost ([127.0.0.1]:52429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhSr-0001pa-NU for submit@debbugs.gnu.org; Wed, 17 Jun 2020 19:27:29 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:48881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhSp-0001pI-HZ for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 19:27:28 -0400 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id AFBE0100003; Wed, 17 Jun 2020 23:27:19 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> Date: Thu, 18 Jun 2020 02:23:02 +0300 In-Reply-To: <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 01:38:56 +0300") Message-ID: <87mu518eg9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I don't insist on 's' for shell. Maybe 's' is more suitable for >> 'project-search'. > > Perhaps. As it is currently, though, I'm not in a hurry to advertise this > command because of its performance characteristics. And because it can > simply give up with "gpg: decrypt_message failed: Unexpected error". BTW, shouldn't 'C-x p v' be bound to the whole vc prefix map? So 'C-x p v d' will run vc-dir in the project root dir, 'C-x p v =' - vc-root-diff in the project root dir, 'C-x p v v' - project's vc-next-action, etc. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 19:37:00 2020 Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 23:37:00 +0000 Received: from localhost ([127.0.0.1]:52434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhc4-00023t-J6 for submit@debbugs.gnu.org; Wed, 17 Jun 2020 19:37:00 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:40877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhc1-00023d-Vt for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 19:36:59 -0400 Received: by mail-wm1-f44.google.com with SMTP id r15so3752283wmh.5 for <41890@debbugs.gnu.org>; Wed, 17 Jun 2020 16:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GpKYKn8Q4Fzkeo9QeLG7XBCKrx++9E9o1TnOUrLr9y4=; b=f++a74HBXLA9Im0pd7wd/gqnTgOXg1WhBauqKV8pLeOqpswjmWUOkbSiz76etm1oln ba/DGwUBHEL/QxSkM12A+b8u5itrDjBCINXp8T2YT2YaFmCnME/Q784fc0RVPbsvtoXJ jgTrez1l3Uqk9iwF6YyKaUO/ZNK8z/P3xnyCcBtNJO6dDg3aMZdPchMXnkz0qAnUyy1a ji9T0hIffRY84nrKgf+4gm9fu3dkje6+NoSS29Ux+ZqCCaXtXs9cWYIeuh/SqPCnH1PS Jr/+zXNtXahAvyqmRq05F79NyMNB9d5wuRnD4+BKCneaXBgudjYx6bEd/OPXQ8gy97+H YtQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GpKYKn8Q4Fzkeo9QeLG7XBCKrx++9E9o1TnOUrLr9y4=; b=N5BjEVnxyKbaqP+JLiJRYYLwe7VNulK1xuy8b5ews6YfZeqWCdjA6F331OaqYHhB6+ Fp87OhsgQwN6LnzKE1dde7RUeeNXI2Mc6iQ0VJMe/vhSKUJPTENAK/89KZYs3a6okuxs PpBdsFHM98KwaruTnWttfpPqe6I0FeyMtOacWfZ0gZI/xhFbE0aXFMO2V5Me5sEPJQE9 IdoB/K48ykTnUj4bpTG7DOTHy+Q6ssrzo6SMji/W4T2zdtUvh8ssVQYh4VXLxGWhzXYT TR6MQPjS0J01F0G1Okj1ej+GW4loI4NM/oeiKRqw8gIH/5j9kTxsd+yz1B71CRBeoMkw d6LA== X-Gm-Message-State: AOAM532vcOo5T3j46756j6tWjEsGNDIA6uO7X1rGaABWQ+eP+OOIQwMp k6jc/B+xmz5UyTipw+MPNWU= X-Google-Smtp-Source: ABdhPJythzKzb2DtXolIqYp6e6DDT92/UZL7mFmCLNvRImRnBtHI6T4dpvFSqwsrDVWSii3s9gFJpg== X-Received: by 2002:a1c:491:: with SMTP id 139mr972002wme.99.1592437012012; Wed, 17 Jun 2020 16:36:52 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u3sm1241744wrw.89.2020.06.17.16.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 16:36:51 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> <87mu518eg9.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> Date: Thu, 18 Jun 2020 02:36:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87mu518eg9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 02:23, Juri Linkov wrote: > BTW, shouldn't 'C-x p v' be bound to the whole vc prefix map? > So 'C-x p v d' will run vc-dir in the project root dir, > 'C-x p v =' - vc-root-diff in the project root dir, > 'C-x p v v' - project's vc-next-action, etc. That might be over-engineering it a bit. Considering that in the vast majority of cases the VC root and the project root are going to be the same. So the users will get the same results from 'C-x p v =' as from 'C-x v D', and 'C-x p v d' would usually be the same as 'C-x v d' (but having one binding for the cases when it's different is fine, I guess). How would 'C-x p v v' differ from 'C-x v v'? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 09:39:15 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 13:39:15 +0000 Received: from localhost ([127.0.0.1]:53229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlul8-0001jK-VL for submit@debbugs.gnu.org; Thu, 18 Jun 2020 09:39:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlul5-0001j5-90 for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 09:39:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40412) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlukz-0000Z5-93; Thu, 18 Jun 2020 09:39:05 -0400 Received: from [176.228.60.248] (port=2951 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlukt-0005tJ-LX; Thu, 18 Jun 2020 09:39:03 -0400 Date: Thu, 18 Jun 2020 16:38:46 +0300 Message-Id: <83sgesze6x.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <783b3a39-62ca-46b5-83a4-1989e8ec2062@yandex.ru> (message from Dmitry Gutov on Thu, 18 Jun 2020 01:23:25 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> <835zbp1wlf.fsf@gnu.org> <783b3a39-62ca-46b5-83a4-1989e8ec2062@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 41890@debbugs.gnu.org, theo@thornhill.no > From: Dmitry Gutov > Date: Thu, 18 Jun 2020 01:23:25 +0300 > > > I don't see how this is related to the issue at hand. All I'm saying > > is that a package, including its key bindings, shouldn't be loaded > > until some of its feature is invoked. > > But if we autoload the bindings definition forms, wouldn't that have > essentially the same effect? How is this different from bookmark.el? And if we don't want these key bindings to be available always, we could have a separate autoloads file for project.el. Some packages do that already. > > We could make the keybindings autoloaded without having them defined > > them when the package loads, couldn't we? By having the define-key on > > the same line as the autoload cookie, like bookmark.el does. > > That would generally be considered problematic because the keymap would > take effect right after the user updates to the newest version of > project.el. Because package.el also compiles and evaluates autoloads. Why is that a problem? A user who updates project.el is most probably going to use it, right? And if we do care about this, we could use a separate autoloads file. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 11:41:16 2020 Received: (at submit) by debbugs.gnu.org; 18 Jun 2020 15:41:16 +0000 Received: from localhost ([127.0.0.1]:54142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlwfE-0004zb-FD for submit@debbugs.gnu.org; Thu, 18 Jun 2020 11:41:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:47954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlwfB-0004zT-LU for submit@debbugs.gnu.org; Thu, 18 Jun 2020 11:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlwfB-00044B-Av for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 11:41:13 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:38113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlwf7-0000eH-0f for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 11:41:13 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id E7B8E90F for ; Thu, 18 Jun 2020 11:41:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 18 Jun 2020 11:41:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= resent-from:resent-date:resent-to:from:to:cc:subject:in-reply-to :date:message-id:mime-version:content-type:resent-message-id; s= fm3; bh=N7WBnsWUed3wSLVdvyQdPu7BQ3/rOt8AgsijUq2kBrY=; b=hH7yY+JJ EHKnqrKZ2x1mfotGUFH9AEVSfIE+9Rc1sYU5/nPFAMHSADeAUN9EI/67xdCb+nSI I0BJbL9wJomdRKxBa4cj+ATQZXuErFOu4ICUqBTqW78058CbnHDVZmfXKZFJGweX M3FJa2tEx/omJQVt184TI/hMFTyogpC4SUpToXoXgdPDMEm3fnL8MjmXNnO6vb7B /f11KJwjNYky4gVJgferaOPaPUc0GKYkrnvevyAI2Rrs0bzU8qnwQNchkXBi6iTz N7x9tdBfV6hwEDmitlhap3AdbkD1/AEFYZGs5pvijB/awjNyBr6GMeee2d56M7eL IFP2uJtDyUdM0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:resent-date:resent-from :resent-message-id:resent-to:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=N7WBnsWUed3wSLVdv yQdPu7BQ3/rOt8AgsijUq2kBrY=; b=f7GVBg4f8NRlXlPTHdKzmblXLpR3ybBLz zpWVeyYWu/NZ4IsWxZA77e9CZbBV6i0KfA5bQDUHghfzF7+BXtXoUgMZLOplrz4m euuWlVsb4ruYPaj7r7CJTpsitduJ4jbKX5SjXgRJKwEul0UJWJSQZ1jfHDHH2Nvl 27HUuAKZD/S40dRGCQTJBvkmhzZe4b9eXDo0PPzlFTql3HqL5uzt38dEjC3wh7To X2hFLUSD4PAaWi1bcdQkwT3LFRW9g615CyalSAvG39c0d99MzC7I9rqTlUesUQ8j N4u3KET+AreLRZ2fbJUpeu7XUh1ZiVoGu67NQuyKrf9jWOUhWlcRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne fouhhlthhiphgrrhhtucgvrhhrohhrucdlfedtmdenucfjughrpefhvffujgffkfggtges mhdtreertddttdenucfhrhhomhepfdfrhhhilhhiphcumfdrfdcuoehphhhilhhiphesfi grrhhpmhgrihhlrdhnvghtqeenucggtffrrghtthgvrhhnpeejieeuvdellefffefgueet keelkeegveffieeffffhgfeuueehvdelvdeuvefhgeenucfkphepjeelrddvudelrddule elrddvudehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p4fdbc7d7.dip0.t-ipconnect.de [79.219.199.215]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A79F3280059 for ; Thu, 18 Jun 2020 11:41:02 -0400 (EDT) Resent-From: philip@warpmail.net Resent-Date: 18 Jun 2020 17:41:00 +0200 Resent-To: bug-gnu-emacs@gnu.org From: "Philip K." To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <3ad1ecbb-36d6-79c0-7a7b-6ff3a561e512@yandex.ru> (message from Dmitry Gutov on Thu, 18 Jun 2020 01:06:49 +0300) X-Draft-From: ("gmane.emacs.devel" 252309) Date: Thu, 18 Jun 2020 16:09:03 +0200 Message-ID: <87ftasea9s.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-RMAIL-ATTRIBUTES: -------- Resent-Message-Id: <20200618154103.0A79F3280059@mailuser.nyi.internal> Received-SPF: pass client-ip=64.147.123.21; envelope-from=philip@warpmail.net; helo=wout5-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/18 11:41:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_TVD_MIME_EPI=0.01, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Dmitry Gutov writes: > On 18.06.2020 00:05, Juri Linkov wrote: >>>> I tried implementig it, and it seems to work. The patch below isn't a >>>> full commit, since I changed the structure of project-switch-commands >>>> (it's now mapping command to description), but didn't update the >>>> docstring. >>> >>> This is looking pretty good. >> >> I agree. >> >>> It's a backward incompatibility, though. >> >> Not a problem since it was added recently. > > Here's another concern: right now, if the user types some other > character by accident, the command will keep showing the prompt until > the user hits one of the chars corresponding to the displayed options. > > If we just look in the (bigger) project keymap, in some cases we would > call commands that are not shown at the screen as a result of accidental > presses. And that's a negative. > > Perhaps we could add a user option that would default to the current > behavior? But then the implementation couldn't use the transient map, > though. The patch below fixes that, but allows changing if you only want the listed keys to be valid (the default) or every key in project-prefix-map. It turned out that the transiment map approach didn't work, as it ignored the value in default-directory, thus running all commands in whatever the current project was. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Use-same-keys-in-project-switch-project-as-in-projec.patch >>From 608a94a2fee42b89b0ae395ce9d5622cb884d9d1 Mon Sep 17 00:00:00 2001 From: Philip K Date: Thu, 18 Jun 2020 16:06:19 +0200 Subject: [PATCH] Use same keys in project-switch-project as in project-prefix-map * project.el (project-switch-commands): Convert to user option and change structure. (project-switch-use-entire-map): Add new option. (project--keymap-prompt): Adapt to change in project-switch-commands (project-switch-project): Use project-prefix-map instead of project-switch-commands to query valid commands. --- lisp/progmodes/project.el | 63 +++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index e24d81c1b4..33946f78a8 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -900,27 +900,46 @@ project-prompt-project-dir ;;; Project switching ;;;###autoload -(defvar project-switch-commands - '((?f "Find file" project-find-file) - (?g "Find regexp" project-find-regexp) - (?d "Dired" project-dired) - (?v "VC-Dir" project-vc-dir) - (?e "Eshell" project-eshell)) - "Alist mapping keys to project switching menu entries. +(defcustom project-switch-commands + '((project-find-file . "Find file") + (project-find-regexp . "Find regexp") + (project-dired . "Dired") + (project-vc-dir . "VC-Dir") + (project-shell . "Shell") + (project-eshell . "Eshell")) + "Alist mapping commands to descriptions. Used by `project-switch-project' to construct a dispatch menu of commands available upon \"switching\" to another project. -Each element looks like (KEY LABEL COMMAND), where COMMAND is the -command to run when KEY is pressed. LABEL is used to distinguish -the choice in the dispatch menu.") +Each element looks like (COMMAND LABEL), where COMMAND should be +bound in `project-prefix-map'. LABEL is used to distinguish the +choice in the dispatch menu." + :type '(alist :key-type function + :value-type string) + :options (mapcan (lambda (ent) + (and (commandp (cdr ent)) + (list (cdr ent)))) + (cdr project-prefix-map)) + :version "28.1") + +(defcustom project-switch-use-entire-map t + "Make `project-switch-project' use entire `project-prefix-map'. +If nil, `project-switch-project' will only recognize commands +listed in `project-switch-commands', and signal an error when +others are invoked. Otherwise, all keys in +`project-switch-commands', are legal even if they aren't listed +in the minibuffer." + :type 'bool + :version "28.1") (defun project--keymap-prompt () "Return a prompt for the project swithing dispatch menu." (mapconcat - (pcase-lambda (`(,key ,label)) - (format "[%s] %s" - (propertize (key-description `(,key)) 'face 'bold) - label)) + (pcase-lambda (`(,cmd . ,label)) + (let ((key (where-is-internal cmd project-prefix-map t))) + (format "[%s] %s" + (propertize (key-description key) 'face 'bold) + label))) project-switch-commands " ")) @@ -930,14 +949,14 @@ project-switch-project The available commands are picked from `project-switch-commands' and presented in a dispatch menu." (interactive) - (let ((dir (project-prompt-project-dir)) - (choice nil)) - (while (not choice) - (setq choice (assq (read-event (project--keymap-prompt)) - project-switch-commands))) - (let ((default-directory dir) - (project-current-inhibit-prompt t)) - (call-interactively (nth 2 choice))))) + (let* ((default-directory (project-prompt-project-dir)) + (project-current-inhibit-prompt t) + (key (read-key-sequence-vector (project--keymap-prompt))) + (cmd (lookup-key project-prefix-map key))) + (if (and cmd (or project-switch-use-entire-map + (assq cmd project-switch-commands))) + (call-interactively cmd) + (user-error "%s is undefined" (key-description key))))) (provide 'project) ;;; project.el ends here -- 2.20.1 --=-=-=-- >>From nobody Thu Jun 18 16:11:26 2020 From: "Philip K." To: Dmitry Gutov Cc: contovob@tcd.ie, 41868@debbugs.gnu.org Subject: Re: bug#41868: [PATCH] Add project-clean-up command In-Reply-To: (message from Dmitry Gutov on Thu, 18 Jun 2020 16:04:17 +0300) X-Draft-From: ("gmane.emacs.devel" 252309) Date: Thu, 18 Jun 2020 16:11:26 +0200 Message-ID: <87d05wea5t.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: text/plain Dmitry Gutov writes: > On 18.06.2020 09:46, Philip K. wrote: > >>> Thank you, I pushed with some minor changes. >>> >>> - Docstring further rephrased based on Basil's suggestion. >>> - The variable renamed to project-kill-buffers-skip-conditions, hope you >>> don't mind. >> >> I don't mind, I just thought that I had sent a patch fixing that >> already? > > If you did, I couldn't find it. Sorry. My mistake, it seems like I never sent the mail :/ But since it was mostly the same, it's irrelevant. >>> Should we add a key binding for it as well? >> >> I think 'k' in project-prefix-map would fit well, as soon as that gets >> merged. > > Sounds good. > > Unless we also wanted a project-scoped version of kill-buffer? I'm not sure how interesting that would be. Buf in that case, I think 'k' would be better for that command, and 'K' for kill all the buffers. -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 11:47:48 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 15:47:48 +0000 Received: from localhost ([127.0.0.1]:54156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlwlX-0007Il-Rn for submit@debbugs.gnu.org; Thu, 18 Jun 2020 11:47:48 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:42959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlwlW-0007IX-6i for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 11:47:47 -0400 Received: by mail-wr1-f48.google.com with SMTP id p5so6547068wrw.9 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 08:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Y6b6xwPq4Bg1BJtXXKv2jyAymmHPzGpD+3uOdfO4so=; b=J//t+xq5COWYmcE4iOkvodjaUxXniiwCCTGWjcY77Ovlb0y3UwYYkBrS9zIDV1tbrp XYAwlUsgLm9d38vIDkZ49xP+CuA6Mml/qxUEo5cSoJW4hE8Yqg0Qfm89jv9A+Qiod+Dr rYDW3O9hzNdouEipZ6vG6agatDKrB0Ad4HDtN/+s2+RKxGsJ2bXC5LBbbSXLwjUIkAI7 l4Hs3woe+beTecJOzPzUCLj0SGt0Tkgc31pYfnyHB9uYMwe4udIVmyhatGxxUFICK2PN OOKKnUmxhQA2ZgIv65GuoTkyy59zBD20+g+2En5JHUoTZUMmBl+BDoKEwrIQcNG/K87N 72BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Y6b6xwPq4Bg1BJtXXKv2jyAymmHPzGpD+3uOdfO4so=; b=nMezdF3R25nbT3EAlo57fvSvHoz4hqbjHs4rlg2Njc0x3NWVWEXzxhJRKOUgoRzCrv vZmD3UdYaDdH5tZiOGZ2I291pPB5RwriRSSw2KdplRFsDaIE8o/vDdWGLk6xX3O09Jic sJaTquHEWS4mYG1SzkqZXfHXt0PEeVRGoRdOUztVjhTn9dbQzs8r6eKn0C0wIGx78rQa FczN30d+UAnFfuJTIpuYXXqAH/XI99TTBcnJKmpfypVg9s6hiAejSoHXK3OLziurl69w VYJ+Gqbq/Xl5zi92k70byvgye9vdiDuRJS3sSMnxmYh3suLyqd1s1PSwEZn8yrf6gA06 AdbA== X-Gm-Message-State: AOAM532iMxpSmKhx/3F/TnJ9d8+3ZxGo6VZ3NPKWoJEA92YV4zO5M2bB xwfu4HMMj6x0IfNnSuvMW6w= X-Google-Smtp-Source: ABdhPJwOZAXMEmiS9ZnodL3oyZ5j4micpZ/RScqJRJ2b43/+qIY2P7ZrG6JDVjGFlO5ayUgAk8s/Kw== X-Received: by 2002:adf:f4c1:: with SMTP id h1mr2794019wrp.328.1592495260225; Thu, 18 Jun 2020 08:47:40 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 67sm4235280wrk.49.2020.06.18.08.47.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 08:47:39 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> <835zbp1wlf.fsf@gnu.org> <783b3a39-62ca-46b5-83a4-1989e8ec2062@yandex.ru> <83sgesze6x.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Thu, 18 Jun 2020 18:47:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83sgesze6x.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 16:38, Eli Zaretskii wrote: >> Cc: 41890@debbugs.gnu.org, theo@thornhill.no >> From: Dmitry Gutov >> Date: Thu, 18 Jun 2020 01:23:25 +0300 >> >>> I don't see how this is related to the issue at hand. All I'm saying >>> is that a package, including its key bindings, shouldn't be loaded >>> until some of its feature is invoked. >> >> But if we autoload the bindings definition forms, wouldn't that have >> essentially the same effect? > > How is this different from bookmark.el? I don't really know much about bookmark.el, or the way it was written and why. > And if we don't want these key bindings to be available always, we > could have a separate autoloads file for project.el. Some packages do > that already. We might not want them when the package is simply installed through ELPA. But we'll probably always want them on by default in Emacs 28 and newer. I'm curious what Stefan thinks about it. >>> We could make the keybindings autoloaded without having them defined >>> them when the package loads, couldn't we? By having the define-key on >>> the same line as the autoload cookie, like bookmark.el does. >> >> That would generally be considered problematic because the keymap would >> take effect right after the user updates to the newest version of >> project.el. Because package.el also compiles and evaluates autoloads. > > Why is that a problem? A user who updates project.el is most > probably going to use it, right? Probably. But it's also a dependency of certain packages like eglot or xref, so it's not a given that the user chose to update it intentionally. > And if we do care about this, we could use a separate autoloads file. Which the users would have to (require '...)? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 12:25:35 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 16:25:35 +0000 Received: from localhost ([127.0.0.1]:54201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlxM6-0001zd-TR for submit@debbugs.gnu.org; Thu, 18 Jun 2020 12:25:35 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlxM3-0001zP-9K for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 12:25:34 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B0B321012E2; Thu, 18 Jun 2020 12:25:25 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CC3881007CA; Thu, 18 Jun 2020 12:25:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1592497523; bh=l6V/PvcUCVMytPWq2xOmMDb9DonVM33uX/XdOURRZQA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fKEDadehHve/mmmAoMT8P5ZRa9YyAQPu/NMmT7n41ooE9X5PvJlbkFKCHier44cJX RyAItp8MUsCJXk6+TJPAwwiVKFCBJNV7dqpTnMfXeN+qUKzjYvd5ukxnHDAk1Se7a+ cmN2kySQKXLSM4OWKPQNw0vvmnRpi6ybAk5TN5+ovZGCbLHkphHO7jo4+JT4aKyWq0 NAoMtsR2qJfRifklnHVDO4jOnAVMy/jAAXAcJJq/vJFHjYAt4upbJ96cpUJOIRCnqE oH8aGYY8VC3TczSVLa0dqUxXAOaQJoUKZFIliSp4qsLSXg0mBpkSu+mJ5YVwbWhMJe 0VUljNLS4NJhA== Received: from alfajor (unknown [216.154.55.41]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 47617120046; Thu, 18 Jun 2020 12:25:23 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Message-ID: References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> Date: Thu, 18 Jun 2020 12:25:22 -0400 In-Reply-To: <83h7vb0w3u.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Jun 2020 20:16:37 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I certainly would. It is very unusual for an optional package to have > its bindings in files that are preloaded into every Emacs session. [ I'm not sure if your objection is on where the bindings are located in the source code (which could be adjusted by moving them to project.el with an appropriate autoload cookie), or whether the bindings are placed in the global map. I'll assume below that the problem is with the actual bindings rather than their source location. ] It's the case for rect.el bindings, for gud-key-prefix bindings, bookmark bindings, a few others, tho. [ I'd put register.el bindings in that same boat because I consider this package just as optional (I never use it), tho it's admittedly preloaded ] The question is whether project.el is special enough to warrant changing the default global map. If not, then the only other sane way is to link them to a minor mode and only activate the bindings when that minor mode is enabled. My own take on what Emacs is mostly used for makes me feel that the notion of project is probably important enough to justify its place in the default keymap. But I must admit I haven't looked at the actual bindings that are discussed, so feel free to ignore me. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 13:22:44 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 17:22:44 +0000 Received: from localhost ([127.0.0.1]:54260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyFQ-0003Ul-4d for submit@debbugs.gnu.org; Thu, 18 Jun 2020 13:22:44 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:46865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyFN-0003UT-SA for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 13:22:43 -0400 Received: by mail-qk1-f177.google.com with SMTP id r22so4828326qke.13 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 10:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AgPK90tJ7htC0u1j5dyzhRx49Qg4+m6HF+htF7KvGV0=; b=nl5hvUsVkVK7+agveRHEppJBY5qfsCMlnrYaiHe9AWKnCZDxPPa1RBZGp54k9WXr0N alQupFnjULMe8Rgmtkts3ZNbhaWIuqLkhwQcAGWUKxK2gHj7RPQjIpnIS5SxWm/16Ts9 Bid1GBXepyQT1Sy/v9t8J5CeKv4kknM2H3/G6YKnad99tR8kGz/GY5xcKqoNDvbSMY7S FuUJhVr5J4vnITJ0KqrPG5SIxIQJIs6evuokXCriwMgOah2/1q5VOcmAaeOYLT1iOTkw I6Q3YQAVWY/RiXFfib0Fa8XUxAdk8z4CJBUprNZGM+m1CCqV+eYvhAg6xHbJLqZPkIom SofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AgPK90tJ7htC0u1j5dyzhRx49Qg4+m6HF+htF7KvGV0=; b=oVnOopUbgUmCJXhOBWA9oyPEkFj13AiyhaQey13zZHd3FdUvvOhX2Jp3SV2Xm6FL+S F+0Zf7BYAXmvEl2icyqyblKtddToN0u1BapIzAXq+JLMeQ/enz8nQGrnSK3IQuq++j5I igbpcU8ZA9Kbgq2DObz9mVJ6g1TEiGNFZYAq/tuZiEgRPk9l2x8cxBeCgghn8FhqXgsf fU5ygDE5NGdv+BJFkVub9wmOnzCAcgjtCeJGNZhrSff1beuvjK9y6YtEp8uCTXErNCfs UCTrb0rIWU6CVWG6SoW4f8KCnkKfWCHGDqxmGl1yFmXppdgdTqLw+U6m6O7+7WlEt+GK q0yA== X-Gm-Message-State: AOAM5308k5aqGyBVY7TX7N70wmLFu/04rXPYqLp7ZQQiVj9dDFbLMPay hTm/qMwpjLZdGPsCxUzkKSdxXw== X-Google-Smtp-Source: ABdhPJzDSbxPER1VqJhjqH9pXn2KQuHBMW/BwRKW4WflNu1/0ASmvNhlVqkRJH562BTl/TDKAqSgxg== X-Received: by 2002:a37:2d42:: with SMTP id t63mr4619819qkh.291.1592500956223; Thu, 18 Jun 2020 10:22:36 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id f30sm3728119qtg.79.2020.06.18.10.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 10:22:35 -0700 (PDT) From: "Basil L. Contovounesios" To: "Philip K." Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <87ftasea9s.fsf@warpmail.net> Date: Thu, 18 Jun 2020 18:22:33 +0100 In-Reply-To: <87ftasea9s.fsf@warpmail.net> (Philip K.'s message of "Thu, 18 Jun 2020 16:09:03 +0200") Message-ID: <874kr8jnl2.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Just some minor nits from me. > From: Philip K > Date: Thu, 18 Jun 2020 16:06:19 +0200 > Subject: [PATCH] Use same keys in project-switch-project as in > project-prefix-map > > * project.el (project-switch-commands): Convert to user option and > change structure. > (project-switch-use-entire-map): Add new option. > (project--keymap-prompt): Adapt to change in project-switch-commands Nit: Missing full stop. > (project-switch-project): Use project-prefix-map instead of > project-switch-commands to query valid commands. > --- > lisp/progmodes/project.el | 63 +++++++++++++++++++++++++-------------- > 1 file changed, 41 insertions(+), 22 deletions(-) > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index e24d81c1b4..33946f78a8 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -900,27 +900,46 @@ project-prompt-project-dir > ;;; Project switching > > ;;;###autoload > -(defvar project-switch-commands > - '((?f "Find file" project-find-file) > - (?g "Find regexp" project-find-regexp) > - (?d "Dired" project-dired) > - (?v "VC-Dir" project-vc-dir) > - (?e "Eshell" project-eshell)) > - "Alist mapping keys to project switching menu entries. > +(defcustom project-switch-commands > + '((project-find-file . "Find file") > + (project-find-regexp . "Find regexp") > + (project-dired . "Dired") > + (project-vc-dir . "VC-Dir") > + (project-shell . "Shell") > + (project-eshell . "Eshell")) > + "Alist mapping commands to descriptions. > Used by `project-switch-project' to construct a dispatch menu of > commands available upon \"switching\" to another project. > > -Each element looks like (KEY LABEL COMMAND), where COMMAND is the > -command to run when KEY is pressed. LABEL is used to distinguish > -the choice in the dispatch menu.") > +Each element looks like (COMMAND LABEL), where COMMAND should be ^^^^^^^^^^^^^^^ (COMMAND . LABEL) > +bound in `project-prefix-map'. LABEL is used to distinguish the > +choice in the dispatch menu." > + :type '(alist :key-type function > + :value-type string) > + :options (mapcan (lambda (ent) > + (and (commandp (cdr ent)) > + (list (cdr ent)))) > + (cdr project-prefix-map)) > + :version "28.1") > + > +(defcustom project-switch-use-entire-map t > + "Make `project-switch-project' use entire `project-prefix-map'. > +If nil, `project-switch-project' will only recognize commands > +listed in `project-switch-commands', and signal an error when > +others are invoked. Otherwise, all keys in > +`project-switch-commands', are legal even if they aren't listed ^^^ Nit: Unnecessary comma. > +in the minibuffer." > + :type 'bool > + :version "28.1") Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 13:24:34 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 17:24:34 +0000 Received: from localhost ([127.0.0.1]:54274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyHC-0003Yz-0p for submit@debbugs.gnu.org; Thu, 18 Jun 2020 13:24:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyHA-0003Yl-84 for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 13:24:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44376) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlyH4-0004TN-8U; Thu, 18 Jun 2020 13:24:26 -0400 Received: from [176.228.60.248] (port=4919 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlyH2-0006Cl-Gy; Thu, 18 Jun 2020 13:24:25 -0400 Date: Thu, 18 Jun 2020 20:24:10 +0300 Message-Id: <83pn9wz3r9.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Thu, 18 Jun 2020 18:47:37 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> <835zbp1wlf.fsf@gnu.org> <783b3a39-62ca-46b5-83a4-1989e8ec2062@yandex.ru> <83sgesze6x.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 41890@debbugs.gnu.org, theo@thornhill.no, > Stefan Monnier > From: Dmitry Gutov > Date: Thu, 18 Jun 2020 18:47:37 +0300 > > > How is this different from bookmark.el? > > I don't really know much about bookmark.el, or the way it was written > and why. > > > And if we don't want these key bindings to be available always, we > > could have a separate autoloads file for project.el. Some packages do > > that already. > > We might not want them when the package is simply installed through ELPA. So is Tramp. Maybe Michael could share his experience with the separate autoloads file. > But we'll probably always want them on by default in Emacs 28 and newer. I suggest to think about crossing that bridge when we get to it. > >> That would generally be considered problematic because the keymap would > >> take effect right after the user updates to the newest version of > >> project.el. Because package.el also compiles and evaluates autoloads. > > > > Why is that a problem? A user who updates project.el is most > > probably going to use it, right? > > Probably. But it's also a dependency of certain packages like eglot or > xref, so it's not a given that the user chose to update it intentionally. I don't think it matters whether project.el is update on its own right or as a dependency. It will be used regardless, so having its autoloads loaded doesn't sound like a serious problem. > > And if we do care about this, we could use a separate autoloads file. > > Which the users would have to (require '...)? Do they do that with the likes of tramp-loaddefs.el? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 13:30:40 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 17:30:41 +0000 Received: from localhost ([127.0.0.1]:54290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyN6-0004M0-Li for submit@debbugs.gnu.org; Thu, 18 Jun 2020 13:30:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyN5-0004Fx-B3 for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 13:30:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44479) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlyMz-0005t0-TO; Thu, 18 Jun 2020 13:30:33 -0400 Received: from [176.228.60.248] (port=1329 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlyMy-0000bl-AV; Thu, 18 Jun 2020 13:30:32 -0400 Date: Thu, 18 Jun 2020 20:30:19 +0300 Message-Id: <83mu50z3h0.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 18 Jun 2020 12:25:22 -0400) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Theodor Thornhill , 41890@debbugs.gnu.org > Date: Thu, 18 Jun 2020 12:25:22 -0400 > > > I certainly would. It is very unusual for an optional package to have > > its bindings in files that are preloaded into every Emacs session. > > [ I'm not sure if your objection is on where the bindings are located in > the source code (which could be adjusted by moving them to project.el > with an appropriate autoload cookie), or whether the bindings are > placed in the global map. I'll assume below that the problem is with > the actual bindings rather than their source location. ] It's with both, actually. > My own take on what Emacs is mostly used for makes me feel that the > notion of project is probably important enough to justify its place in > the default keymap. I hope this will be the case in some not too distant future. But until it does, I see no reason to hurry with that. (Assuming I understand correctly what you meant here.) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:18:38 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 18:18:38 +0000 Received: from localhost ([127.0.0.1]:54381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlz7W-00075L-9j for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:18:38 -0400 Received: from mout.gmx.net ([212.227.17.20]:43021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlz7T-000756-Qw for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 14:18:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1592504305; bh=FIFWaPGakM/BB9NGmhxr9GDXdazdAwd6ISAuT25+yYs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Jk/27qYQupset6mddvegzow8qA4J/VfBpbGO9YKY/iEaFW4/BOL1z8eqqgG6oZI/Y 6co8zDao2+b5ebC1LWvmu9eFfZ3NLGUyRU69NWWXYQG3UKWmqYnhPbwhJAupuyJaYU P4jQRyK837zBBO6EJ3eYVMziE3IKz2Mkb5DNiDW8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.50.242]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7zFj-1ipsCw0tL1-014yAf; Thu, 18 Jun 2020 20:18:25 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> <835zbp1wlf.fsf@gnu.org> <783b3a39-62ca-46b5-83a4-1989e8ec2062@yandex.ru> <83sgesze6x.fsf@gnu.org> <83pn9wz3r9.fsf@gnu.org> Date: Thu, 18 Jun 2020 20:18:23 +0200 In-Reply-To: <83pn9wz3r9.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Jun 2020 20:24:10 +0300") Message-ID: <87lfkki6fk.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:aBP9LVtbfh9tpvy1NfTq+i0c1c9O4Q5jAuVovSDWMdGvkq8ooBx d9JgTKQmz/XpVoFghWVyTi/ROHWGVXua7f8Fdt/QJbFB0GXmZS+MJk/zPvL8u2kMajrD+go ERyQobzdrRDTLSrNjuWm6Tgh/Os1DBUk3y5fQeCkhGZ8hdYCj4gZNnj/9oxJkyhSif2iEFs 0ITV5dhPHvX3R3uXMpBGg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KGrzaJUeDHQ=:J5AcaCjPfHgPDYBsJUEpue BYKCjYRCCZCUw7wo4b2U0Ua3LZiDK5C+ZSwi387fvH8dlTYaS2EXxWaGG8R1QyhLuiawMeHn8 NSXU4ValusG3g4++xc8hmjzMgBwWtCyk7PrDAM53xq1QkjutEhYM7DPYt0Tw4a1/ra3ayPG1u xyrjVcE2y6jfoAh7mqsAQXpariID0M5cJmQA3ey/PIuyNlKo/UERRUVpqVdtK3C1JRWu+n5rL moVdPDT1UvgIGyTJlJuSVe12neLgKey9NzlOphTsclbpRCOepTilo9LVrQFHX+UIglMml2Kyd Ak0js6QR0xRG7i876dKOS6OaV6QD/GJyoAWeoyh1lHnFHkbq+qhBp1qCtE4m8CcVgMmqunD7c sRyrjtJbkQde3Be7t5oqUgpaMUNvbICSoBaSbIUDNprrv8VnKZCTkYGQem8Ooq2r+d7OeIjM5 9XNKKCrhLa26B93MsIv2Tk5W7nKNae6UiWlyStVSn0KwOTedYiQM1lb5TmDUmtPmtyD4DR571 rIkXbodM/888HSD/5VydefjJUcmYB5PsDhHXhPUm/i4QIrb0Dk6IuoUjQ/4iOiY7tUwLDrki5 Oh1udqLPLs+PNQt/6RQV0CBCY0YiMTQIVFYMpdMB/StoqJf0WvhYM7HcDdnZaKpYLEFiIQNuL ILF/OnLTXEfd6QB/ze/cE5BF81PslbPfRRg9hDBfQ81Au3ASe+U5R891nZMMvKVvRlGxzEAKY eMzy9Q4osCKz2n7NdaXBcJJ0VIvKDitsPyozoLu+LrwtDh/coDtmnzVdwSR8RMCT46vziyzQ/ W9gJDjiebA5AG6xe4MjKTsh1kT4SelbUzJBtcxjvvEJmXEqPM620nkOzGJEJLILjHrUB76Pwl FLq9xW3fER/hA08CIkObnJDc9MdA54+zWd62L1OzfdTmSB8zWI78GupbEoeE2ZDIH+bJWarxE gs1uD9YwNymjO4zos9nfX+9f52CY3YdT4lraEeQEa9BCN+iovd+zmi4FyvZhMWZ+PISfbAWtE VsGPuA50Egl9NO4O9LBPlRqrAXrkbwRFC5N9zkb/3JGMGOyfxlP7sO9qtFkca3KosyO/q0kez vwBF6ZMaZ5eKMvKh6mxIkAtQIcORQgHw+MhoUvf9N8k0XbkdX/xLgTEr1chN6Alx5s4b/t1hQ iM2hFJ7NUM3Vu+CwDM5rvsEy3fA2850sRnuCUWe46p8oq8LTN12PxRIxHBQIovyG7DRrt2CRI 8Z43+TWUfdJncMgG7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> > And if we don't want these key bindings to be available always, we >> > could have a separate autoloads file for project.el. Some packages do >> > that already. >> >> We might not want them when the package is simply installed through ELPA. > > So is Tramp. Maybe Michael could share his experience with the > separate autoloads file. There's no magic. Tramp isn't used by many users, so it tries to keep calm. Only the absolute minimum of functions and variables are ;;;###autoloaded. Everything else, which needs to be autoloaded in Tramp (mainly objects which are shared by different tramp-*.el files), are autoloaded with the ";;;###tramp-autoload" cookie. A file tramp-loaddefs.el is generated during compilation, and this file is required once the Tramp basic file, tramp.el, is loaded. That's it. Such a *-loaddefs.el could also contain key bindings, which are activated once the *.loaddefs.el file is loaded. Tramp doesn't define own key bindings, so there's no need for it in tramp-loaddefs.el. >> > And if we do care about this, we could use a separate autoloads file. >> >> Which the users would have to (require '...)? > > Do they do that with the likes of tramp-loaddefs.el? Of course not! It is required tramp.el. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:22:51 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 18:22:51 +0000 Received: from localhost ([127.0.0.1]:54389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzBb-0007Bu-0v for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:22:51 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzBY-0007Bf-FT for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 14:22:49 -0400 Received: by mail-wr1-f43.google.com with SMTP id e1so7098287wrt.5 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 11:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FyIjdonZWvfOtqHXS1HQxGrEWeDPHTpVKLnYhwuDI68=; b=GSXOmUG7ud2grSg9RAJ28Mc37iQP5ga4GQBaDP9XkEYWSboMlxyk52u6mJPKIc5MwP DpbPwCcRom64PZsctolTujOqoT+S2AgYwFwxmY1M6NF8IHbHZhu92OdsOhqkq0auRRZ2 DK2eYOBlu2r2Lj4XqVZR5uEE20vOS4KVjGzesAXqvWqMikIwlWVf9QcvEnHhiWH5tnQB DljxEV+5BfjWpHIa2yfumQrw5fWMVd96mwZ61QQT5wIJHeg475LHzadhfwhZlQiWm2hf S0j09U8F+Uf3sX5Lts+1ili/VXVF3f8jrKt73CWFL4jRVIlnp11azRY2nn4PGk+bNS/U UIGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FyIjdonZWvfOtqHXS1HQxGrEWeDPHTpVKLnYhwuDI68=; b=k/tFo5+ZXHHAEFRBo/IEAs5Q9N6bBLi/hL9mjzdE0pJsPBHi+1xQvPJvxKfAgfBkJA N6q1b4xf5/Oieel4jTc1e4hhlMteiE6SnotrwLDty/JeusMHkHZtb/kupsUas5hkCHeY ZLxjdFXX/6SZYTMn5fTunuBIU0GxDHZ40QgdqdJ7ZQEI8HCQo5JsgN9PpmQ9r7GqqWZi QfTXr8ae9ygrkB7i29u4eWhRrU3kUzVvlgSzTWPt0oHB9QoPohk+sdLyU/GvzvawnI8F u0sjL2VxsSX4qlO71B1+ptrKUfCe/v5oYdbF0VHII/j86DSfDNZ9lzdIE7ySOOWQOTTM +eeA== X-Gm-Message-State: AOAM532i16sD6WNGMV2hoR6eTOiw5AklL/SZLHCY5ntUCu+TQQv3EiD/ MVWuGPmkg/9OspH5r3het7Y= X-Google-Smtp-Source: ABdhPJzRq3SI732/iH1cYFNSJbdjFid5z2DwmSuV0TEfj+LvpNQt+wvq40mUVG0BfXvAgD8PtIJtoA== X-Received: by 2002:a5d:554b:: with SMTP id g11mr5995123wrw.260.1592504562482; Thu, 18 Jun 2020 11:22:42 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id k16sm4389632wrp.66.2020.06.18.11.22.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 11:22:41 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii , Stefan Monnier References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83mu50z3h0.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Thu, 18 Jun 2020 21:22:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83mu50z3h0.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 20:30, Eli Zaretskii wrote: >> My own take on what Emacs is mostly used for makes me feel that the >> notion of project is probably important enough to justify its place in >> the default keymap. > I hope this will be the case in some not too distant future. But > until it does, I see no reason to hurry with that. (Assuming I > understand correctly what you meant here.) I must admit, I have lost track of this discussion. Eli, do you have problems with what has been added to project.el last night? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:42:32 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 18:42:32 +0000 Received: from localhost ([127.0.0.1]:54402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzUd-0007fC-Qj for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:42:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzUZ-0007er-PP for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 14:42:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45827) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlzUT-00035J-BW; Thu, 18 Jun 2020 14:42:21 -0400 Received: from [176.228.60.248] (port=1727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlzUN-0000dr-6Y; Thu, 18 Jun 2020 14:42:17 -0400 Date: Thu, 18 Jun 2020 21:42:01 +0300 Message-Id: <83ftasz05i.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Thu, 18 Jun 2020 21:22:39 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83mu50z3h0.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 41890@debbugs.gnu.org, theo@thornhill.no > From: Dmitry Gutov > Date: Thu, 18 Jun 2020 21:22:39 +0300 > > Eli, do you have problems with what has been added to project.el last night? Please specify the commit(s), as "last night" is too ambiguous, and there were a lot of commits in project.el lately. I could easily make a mistake. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:50:58 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 18:50:58 +0000 Received: from localhost ([127.0.0.1]:54415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzco-0007s7-3k for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:50:58 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzcl-0007ru-UW for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 14:50:56 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8930E5C011D; Thu, 18 Jun 2020 14:50:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 18 Jun 2020 14:50:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm3; bh=7Ozjg7iriNwlsgJlEWoQ6td4LX+Upa0ODeTNt3j 4IgM=; b=Oa/p2AGaiu1wL/vyw47h8OrTuFLkZkDf8Slrop+cyR+Boo9OVwaUVTP ReUfldKtCZpzV0gUvMoxNH1NUGHnWKnX38OEa8E3ffW1oEvGZU9oFR7iyaczt2Ip 9lAxomuw5Jwg+j1wLIfosQ3gsaexaXHjtCAy+RKt8oVlfn94SLTiZtGx6QZPKKtO ZrA0d4XX5ySd+FTeevHW73yrgJmEfTKslI/tFb5qJiZ7239Z85axnQupwJ6Glog0 1EQlIjk5PFr85i1S0/3pOFijKHWTOgcjj/xf7+bjvdkKrwRxDQrd3DejfKbW+IX0 xw6An3dFNt2aypAYIx/kel81+1U99aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=7Ozjg7iriNwlsgJlE WoQ6td4LX+Upa0ODeTNt3j4IgM=; b=Qix7SRFdOSpQlFlpG130NeUoraiql2wDZ GiDdW5RTAq85p7+ow+wacN/LjDFKz5+8md9C/Fzt+OPK2FQcSngJi+6I5mzDsR2h ot2NilP0jlECRSaR+N+4ipXWcl/cKQ3yktEcAxN2t3ez1spG88/9D60vjfdYAGn6 rQQj/LgzVI0QAlpI6RErjj7DIuOHhVod6ys5Nzh2N9oC2jeNlQMchp2xg57pObv/ /R7cLlejmlxwNIxb0SQY4XvWoRblBqMJ3RqstQrGoLjbZB68da7+7u6+tPBxN9hp TnxGQbVT8ZR4GwOG0jW16gmkVdKj1BHGmlitV2Fex60C+5Jh5I3dw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgedgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujgffkfggtgesmhdtreertddttdenucfhrhhomhepfdfrhhhilhhi phcumfdrfdcuoehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrghtth gvrhhnpeejieeuvdellefffefgueetkeelkeegveffieeffffhgfeuueehvdelvdeuvefh geenucfkphepjeelrddvudelrdduleelrddvudehnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgv th X-ME-Proxy: Received: from localhost (p4fdbc7d7.dip0.t-ipconnect.de [79.219.199.215]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E2AD30614FA; Thu, 18 Jun 2020 14:50:49 -0400 (EDT) From: "Philip K." To: "Basil L. Contovounesios" Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <874kr8jnl2.fsf@tcd.ie> (contovob@tcd.ie) Date: Thu, 18 Jun 2020 20:50:46 +0200 Message-ID: <87mu50b43d.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Thanks, the fixed patch is below. Another minor change to the last patch is settign project-switch-use-entire-map to nil, so that by default not all keys in project-prefix-map are usable, as to avoid the potential for confusion mentioned before. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Use-same-keys-in-project-switch-project-as-in-projec.patch >From 8418074a6f73ad5dcafe1fbcbfc847155dc4c485 Mon Sep 17 00:00:00 2001 From: Philip K Date: Thu, 18 Jun 2020 16:06:19 +0200 Subject: [PATCH] Use same keys in project-switch-project as in project-prefix-map * project.el (project-switch-commands): Convert to user option and change structure. (project-switch-use-entire-map): Add new option. (project--keymap-prompt): Adapt to change in project-switch-commands. (project-switch-project): Use project-prefix-map instead of project-switch-commands to query valid commands. --- lisp/progmodes/project.el | 63 +++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index e24d81c1b4..cf214719e5 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -900,27 +900,46 @@ project-prompt-project-dir ;;; Project switching ;;;###autoload -(defvar project-switch-commands - '((?f "Find file" project-find-file) - (?g "Find regexp" project-find-regexp) - (?d "Dired" project-dired) - (?v "VC-Dir" project-vc-dir) - (?e "Eshell" project-eshell)) - "Alist mapping keys to project switching menu entries. +(defcustom project-switch-commands + '((project-find-file . "Find file") + (project-find-regexp . "Find regexp") + (project-dired . "Dired") + (project-vc-dir . "VC-Dir") + (project-shell . "Shell") + (project-eshell . "Eshell")) + "Alist mapping commands to descriptions. Used by `project-switch-project' to construct a dispatch menu of commands available upon \"switching\" to another project. -Each element looks like (KEY LABEL COMMAND), where COMMAND is the -command to run when KEY is pressed. LABEL is used to distinguish -the choice in the dispatch menu.") +Each element looks like (COMMAND . LABEL), where COMMAND should be +bound in `project-prefix-map'. LABEL is used to distinguish the +choice in the dispatch menu." + :type '(alist :key-type function + :value-type string) + :options (mapcan (lambda (ent) + (and (commandp (cdr ent)) + (list (cdr ent)))) + (cdr project-prefix-map)) + :version "28.1") + +(defcustom project-switch-use-entire-map nil + "Make `project-switch-project' use entire `project-prefix-map'. +If nil, `project-switch-project' will only recognize commands +listed in `project-switch-commands', and signal an error when +others are invoked. Otherwise, all keys in +`project-switch-commands' are legal even if they aren't listed +in the minibuffer." + :type 'bool + :version "28.1") (defun project--keymap-prompt () "Return a prompt for the project swithing dispatch menu." (mapconcat - (pcase-lambda (`(,key ,label)) - (format "[%s] %s" - (propertize (key-description `(,key)) 'face 'bold) - label)) + (pcase-lambda (`(,cmd . ,label)) + (let ((key (where-is-internal cmd project-prefix-map t))) + (format "[%s] %s" + (propertize (key-description key) 'face 'bold) + label))) project-switch-commands " ")) @@ -930,14 +949,14 @@ project-switch-project The available commands are picked from `project-switch-commands' and presented in a dispatch menu." (interactive) - (let ((dir (project-prompt-project-dir)) - (choice nil)) - (while (not choice) - (setq choice (assq (read-event (project--keymap-prompt)) - project-switch-commands))) - (let ((default-directory dir) - (project-current-inhibit-prompt t)) - (call-interactively (nth 2 choice))))) + (let* ((default-directory (project-prompt-project-dir)) + (project-current-inhibit-prompt t) + (key (read-key-sequence-vector (project--keymap-prompt))) + (cmd (lookup-key project-prefix-map key))) + (if (and cmd (or project-switch-use-entire-map + (assq cmd project-switch-commands))) + (call-interactively cmd) + (user-error "%s is undefined" (key-description key))))) (provide 'project) ;;; project.el ends here -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:55:09 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 18:55:10 +0000 Received: from localhost ([127.0.0.1]:54420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzgr-0007yT-Pq for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:55:09 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:53511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzgp-0007y2-R8 for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 14:55:08 -0400 Received: by mail-wm1-f49.google.com with SMTP id l26so6190819wme.3 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 11:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X6HnRbhmQJuFX5meITpHgiQvVvCKPN6hMtST/Utu5QE=; b=s+blaAX4h3XRYaRXgQSAzoKtR3AMi/dlo3E0RJho5PxIA3pzl9d9ABNIqRaQJPTYS1 PUIKTxyg6BB6vqp1WGy/pG2EGacihRtP6BT3EFdboMa4E3RJ9pDFAP1hBGa0WqJVmLEO rDv5tyPYvZusdasGxNt4t6dmW+1XaS8aXG60GXYnwIeErSNBGh7x7MdfmoHFnJgejR+F Trc7l5DZ+fW90hpqGKV0n8ovLfEiEoOKW8ae6fDxWnvkHppcOx0mnV2/Z+wT2DpDJDpj ypvdbQosk1fKveyDS/r0sDjxKKbfTekSTmlmZtbmbPOb9lFL0V9BeIjGghVAhn7XL4sX PmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X6HnRbhmQJuFX5meITpHgiQvVvCKPN6hMtST/Utu5QE=; b=pTSUtnndVadXmF7Q/EY2oPGGTCEoISx8q7D/kTtsPbxGVUzjuIzChLaLlEzac0g7nh fLVrX9pigw8/ONzSu1wVYTcBRRFYs9JL6968UsXJd0zBJGVgdOga0VJWvyLk+FLFioC4 let6XXXCJ5/CdkUzccSA5859cF4gTQ1BzChP35LjzyCUX/olaG8GjfvhtwG6Be+5oa9x TgMqs5+ygZFDIjbG/vJ3BURhDri3TECxYNak3RiiEqQ0xFd7bmo+4/B9rcrDXquXtAhm NB0fY8RUBQH03bIlqpr8yNqWXN2AoIsrnGL/BE/KG3ZCQKBXl93JNLzQK6EBExx5XuJS dh2g== X-Gm-Message-State: AOAM5306fvQs5jAg8eKV96tX02jh+tIodNFQPoKpDE2PY0b35vH+Yh3J cssLO1mdJUex4FKALRVKzlo= X-Google-Smtp-Source: ABdhPJxvyQ5XWpQdL0aMw4DjApyURJOvC4Xxh/GW8cyQgpKx2dHevw64dkO/Y6G7xS6nAYSQvxNB/w== X-Received: by 2002:a1c:3286:: with SMTP id y128mr5135047wmy.29.1592506501898; Thu, 18 Jun 2020 11:55:01 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id c70sm4351805wme.32.2020.06.18.11.55.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 11:55:01 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83mu50z3h0.fsf@gnu.org> <83ftasz05i.fsf@gnu.org> From: Dmitry Gutov Message-ID: <31c994ec-9fa3-02c4-ad94-84cff0e59846@yandex.ru> Date: Thu, 18 Jun 2020 21:54:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83ftasz05i.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 21:42, Eli Zaretskii wrote: > Please specify the commit(s), as "last night" is too ambiguous, and > there were a lot of commits in project.el lately. I could easily make > a mistake. Commit 2f231fcfb7. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 15:04:54 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 19:04:54 +0000 Received: from localhost ([127.0.0.1]:54439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzqI-0008E7-5I for submit@debbugs.gnu.org; Thu, 18 Jun 2020 15:04:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzqD-0008Do-9M for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 15:04:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46145) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlzq5-0006xK-9D; Thu, 18 Jun 2020 15:04:41 -0400 Received: from [176.228.60.248] (port=3093 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlzq4-0004hE-Mr; Thu, 18 Jun 2020 15:04:41 -0400 Date: Thu, 18 Jun 2020 22:04:27 +0300 Message-Id: <83d05wyz44.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <31c994ec-9fa3-02c4-ad94-84cff0e59846@yandex.ru> (message from Dmitry Gutov on Thu, 18 Jun 2020 21:54:59 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83mu50z3h0.fsf@gnu.org> <83ftasz05i.fsf@gnu.org> <31c994ec-9fa3-02c4-ad94-84cff0e59846@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca > From: Dmitry Gutov > Date: Thu, 18 Jun 2020 21:54:59 +0300 > > On 18.06.2020 21:42, Eli Zaretskii wrote: > > Please specify the commit(s), as "last night" is too ambiguous, and > > there were a lot of commits in project.el lately. I could easily make > > a mistake. > > Commit 2f231fcfb7. No objection here. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 17:12:42 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 21:12:42 +0000 Received: from localhost ([127.0.0.1]:54511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm1py-00039Q-A5 for submit@debbugs.gnu.org; Thu, 18 Jun 2020 17:12:42 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:38236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm1pu-00039A-IJ for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 17:12:40 -0400 Received: by mail-wr1-f45.google.com with SMTP id e1so7603270wrt.5 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 14:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h3PEp0mt9+jDUFLxvGpc2QE6oMXzVVinZWI4ptca/3Q=; b=GYE9pD+R+c+egye5mj3r0/rI0A8SnKQ8WaQrJASyeNDX4FGDQauLdbUguTJkVvW9gx XIMMSVLnMyGhePbI3v+Cw/RW8gf3zsNcD+2SeCbpl65USuem3EuxaAYxnkIR9LussJvF ZfrNcsXAVVv0UKd1r4xB/dsJMGzt2bCxo9VjlRJmvcKfuS1hUgOSAfbQ2v6Zl5Yv5LoL tUcke27kFiaCWaDpAB/qu9BPAHPzkEmq1xH0AeJ3QK6qupQdCLaRkB8wNuu+mUgvlRff iuPSNAWB5D8jzx118l1VWi889fnx2g51gDndHwbAXzOP/2vHdRqFVEYJWIkn8Inbfv6V 6p6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h3PEp0mt9+jDUFLxvGpc2QE6oMXzVVinZWI4ptca/3Q=; b=T+XpHxE9hhLL3VPKmn9ilIKXouu1YPPLp4g+GqrpdETMlhr7AwLYPmjjpgKP2zzbcg Iv8EQuAgWP7e60QVXHdXsdPfBAJSqxAtSi6TD6sTYkH3VkcltnQFAlp/13WZJOvQMsTr CAkxn43zRds2fWgJApu1NWkDxLF+i78jp4KaoM04iBmU1N0Xg5FBtx8HnEsr4DF5mMUq yLnd2/vRpuXkeikWRqtPYq1sdA46brQxV1j5w0Yu/qEKIBaVBU2b5aJodtp7LI72ri3B qUnMMp+B2aDu9V4kvBrFjYPLt4U4W6h1G9ldJYTzGYGXWfP/PxYmuJBsfwMPnzHG2nhN CZUA== X-Gm-Message-State: AOAM532MCTcBl1Si1dUF5ht+Dk5KsJy1Z8lqY85keiuONCXW0U8tT1MK 0spCGMySmhuLttWWiV5bCQU= X-Google-Smtp-Source: ABdhPJwUbzv1R1AzzMf4OMYe4k5vU0HCnpMHTYt6LZwkwuD0ak3E61cHdsV3wJUFUn5H0M9KXmvwvQ== X-Received: by 2002:adf:e587:: with SMTP id l7mr427043wrm.352.1592514752741; Thu, 18 Jun 2020 14:12:32 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id b81sm5355789wmc.5.2020.06.18.14.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 14:12:31 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Eli Zaretskii References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83mu50z3h0.fsf@gnu.org> <83ftasz05i.fsf@gnu.org> <31c994ec-9fa3-02c4-ad94-84cff0e59846@yandex.ru> <83d05wyz44.fsf@gnu.org> From: Dmitry Gutov Message-ID: <5d478a48-5363-e8f2-afbf-ebb0ce86a873@yandex.ru> Date: Fri, 19 Jun 2020 00:12:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83d05wyz44.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 22:04, Eli Zaretskii wrote: >> Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> Date: Thu, 18 Jun 2020 21:54:59 +0300 >> >> On 18.06.2020 21:42, Eli Zaretskii wrote: >>> Please specify the commit(s), as "last night" is too ambiguous, and >>> there were a lot of commits in project.el lately. I could easily make >>> a mistake. >> >> Commit 2f231fcfb7. > > No objection here. Thank you. So what did you mean by "in some not too distant future" and "no reason to hurry"? Project commands are functional, and they are in the global map, for all practical purposes. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 18:36:47 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 22:36:47 +0000 Received: from localhost ([127.0.0.1]:54616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm39L-0005FZ-NB for submit@debbugs.gnu.org; Thu, 18 Jun 2020 18:36:47 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:38259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm39J-0005F8-Rj for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 18:36:46 -0400 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 35528200003; Thu, 18 Jun 2020 22:36:37 +0000 (UTC) From: Juri Linkov To: "Philip K." Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> Date: Fri, 19 Jun 2020 01:10:40 +0300 In-Reply-To: <87mu50b43d.fsf@warpmail.net> (Philip K.'s message of "Thu, 18 Jun 2020 20:50:46 +0200") Message-ID: <87zh90nh0v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Another minor change to the last patch is settign > project-switch-use-entire-map to nil, so that by default not all keys in > project-prefix-map are usable, as to avoid the potential for confusion > mentioned before. I realized there is a question: why we need to bind project-switch-project to 'C-x p p'? For example, why we need to duplicate such key sequences: 'C-x p d' - project dired without dispatch prompt 'C-x p p d' - the same with dispatch prompt Couldn't 'C-x p' display the same dispatch prompt (that actually is just an echo-area hint) after a short delay? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 19:01:59 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 23:01:59 +0000 Received: from localhost ([127.0.0.1]:54633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3Xj-0005re-DY for submit@debbugs.gnu.org; Thu, 18 Jun 2020 19:01:59 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:42876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3Xh-0005rS-Ut for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 19:01:58 -0400 Received: by mail-wr1-f44.google.com with SMTP id o11so91022wrv.9 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 16:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eIRjOQ2EZc4tRw8zzQ/w0S9FCc30zG9Vh3qiksGJ1hA=; b=N+M4qdorLqyPr6b7qJfk/Y/7mqRckXeTCWa0zext+/zKsM3nqM2EdjqnL7WHNYL4Pu NxPD+sV0POZvcgSENyqfICQ78XY+nK9Sx+UWxCxiiKuO3xHh0gw36IE+phreZWjlOi6n 4cZ4FFCCmVYpKwvYK/71KIdakf4kPFzFvcr9X83742Jh/H7xzHuIn2HGMUrqxzHEc5hG gJ8kGt5QDrNAWk0KadodBY9aFkNZZ2BFAvK1wN2+kv8YrgpIwNIAhhivTcxJahrkF/bV JsO1d72miPzAX6vyfPEaYIDoI11728pYBcmL3DZDvuapTEunvaxQaZLVscjT8c7EkBX0 L2Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eIRjOQ2EZc4tRw8zzQ/w0S9FCc30zG9Vh3qiksGJ1hA=; b=pGI7Qmv/jGpECEU9JdLExDpMFQbq23+a7SYiHQInuWvmZFdGkLB/q4k+SAlOwDqmjh /A2qahre1G2J1qkq0bEtUAFm9bKlNKLCo3zB9GJeAUM94Ac+p+nlshxScvDL/F7mrBSi 3q+dC8c0W51B7yMAy4j+r4iBaVTDocwFxmCzlwUDzmj7h9R02uOsH7/cam8cvDE/4JHc TjSEpXDNyNzIT1r4KGK7PlBnIXLG7wdnxE6B6Gkw3j9edMAwktu+jOUGsAmG6a0l9lSw Wc1g2FWY/94z9Uuc415C9dJMcDGSbKfO0fGW+4lTnSx0lVO7dDiNuYm8MXwon9Skempo BJ4g== X-Gm-Message-State: AOAM532riHGOf8lPLOQ+T/PgIJQtZpijpmskgePWnxONt9dMhSyp8LpP tOsCcD/GQdoeCjJ8lT8BAjrQSObA X-Google-Smtp-Source: ABdhPJyXgKBzUXDapPfgmFWogtQNlc9w9Vlw2a+bUxOKWdTx3yb2IE9BlQ60v9I+SmB2KNe5pBGx+A== X-Received: by 2002:a5d:4dd0:: with SMTP id f16mr820390wru.117.1592521312007; Thu, 18 Jun 2020 16:01:52 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l17sm5000289wmi.16.2020.06.18.16.01.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 16:01:51 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov , "Philip K." References: <87mu50b43d.fsf@warpmail.net> <87zh90nh0v.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <4d13a021-0c79-38c7-5acb-78333a353975@yandex.ru> Date: Fri, 19 Jun 2020 02:01:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87zh90nh0v.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.06.2020 01:10, Juri Linkov wrote: > 'C-x p d' - project dired without dispatch prompt > 'C-x p p d' - the same with dispatch prompt It's not the same. It asks you to select a _different_ project. > Couldn't 'C-x p' display the same dispatch prompt (that actually is > just an echo-area hint) after a short delay? Sounds like which-key-mode. But it would dispatch on commands for the current project. Not a different one. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 19:04:20 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 23:04:20 +0000 Received: from localhost ([127.0.0.1]:54641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3a0-0005vc-3B for submit@debbugs.gnu.org; Thu, 18 Jun 2020 19:04:20 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3Zx-0005vL-LS for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 19:04:18 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 8C890E0005; Thu, 18 Jun 2020 23:04:09 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> <87mu518eg9.fsf@mail.linkov.net> <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> Date: Fri, 19 Jun 2020 01:59:48 +0300 In-Reply-To: <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 02:36:49 +0300") Message-ID: <87a710m13v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> BTW, shouldn't 'C-x p v' be bound to the whole vc prefix map? >> So 'C-x p v d' will run vc-dir in the project root dir, >> 'C-x p v =' - vc-root-diff in the project root dir, >> 'C-x p v v' - project's vc-next-action, etc. > > That might be over-engineering it a bit. > > Considering that in the vast majority of cases the VC root and the project > root are going to be the same. > > So the users will get the same results from 'C-x p v =' as from 'C-x v D', > and 'C-x p v d' would usually be the same as 'C-x v d' (but having one > binding for the cases when it's different is fine, I guess). > > How would 'C-x p v v' differ from 'C-x v v'? Actually my question would be better formulated like this: Should we reserve the key 'C-x p v' as a prefix map for possible future extensions when such need to add more vc keys will arise? Currently I see no such need, but who knows. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 19:09:06 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 23:09:06 +0000 Received: from localhost ([127.0.0.1]:54649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3eb-00062w-Re for submit@debbugs.gnu.org; Thu, 18 Jun 2020 19:09:06 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:37010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3eZ-00062O-LT for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 19:09:04 -0400 Received: by mail-wm1-f53.google.com with SMTP id y20so7373878wmi.2 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 16:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2kVNOwKh5j0hbK1GJQzxsUXLTu5Gjy4FKPcO5Y9YPx0=; b=l5GOyROG4fk8eXQ+iOf65p/WtJGj3Huiot0GzV1viRYBb2kKzPDdw4+3dTocxJmKoZ awxmx8116UcZeg3kqG52zBKUZcTWvfDXTigfI81wnv2FibL+7GkY3BKWyCJahXtT4Z0m HVmCUB8CxhfiHA3amyUKb4vh7vSXzhoFxB/mmLyfOx50HOTQLllRIygvUO4XnRdBt4Cm BHQjRohitrontVPuhaK+BpYvVu7ltqq8zg7Nrq4LE6TAOWt+zp5QboqhCwT336dsaoJP P48woxMhqYBgR0eyPL+Zy2sKzdkbr6JjtUwpG/ISI8W6jDAkE6uHUaKQCDndh5lZDLTW 0/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2kVNOwKh5j0hbK1GJQzxsUXLTu5Gjy4FKPcO5Y9YPx0=; b=cEPx2VQDXeOdBSfQ80+HdkAD3RTuFqyRNShYnFq0mYWr2o1DZ25ftpF3PGsmb1Tj+z 4zEgHL/UmR2iV1zGWf4WbepY2MKfxwenE9u/9vHAS0ulbhwAe6whe2odrP804YYQJzV+ 0PJjvBWeDxiulZgOhGZ9VvrZJi5kRxPwVuM7BkqepO1ZuMvQs9T0sxApZBaBv9TQBpvP 71XUIdKc1ZESQcO1FoFMfFTz00zERFOjnVnexoEYGLKt/zZLolYkqDsshookMlnRW+pq rtv34BLKApFqb5gBe+x/Ko8InmTNRwVd9vjwI6ZNQunz5NyvgkGyA5rXpwY16/MKkO/D sODw== X-Gm-Message-State: AOAM531zM+TNWAHCzZK0FdFlI4ey3ZSXyA09wRvLzjJrCDY1sCgyYkLH e3wyack61yX0xSt0XzQGkwo= X-Google-Smtp-Source: ABdhPJzYuUiHgzDbeVAv5c/UKqLZcKgTyN773SXhNXmPaHwk9Bbq3uJdS4lWIPIRNLP4e04dCn4OcA== X-Received: by 2002:a1c:a3c5:: with SMTP id m188mr602099wme.152.1592521737954; Thu, 18 Jun 2020 16:08:57 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id k64sm5069647wmf.34.2020.06.18.16.08.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 16:08:57 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> <87mu518eg9.fsf@mail.linkov.net> <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> <87a710m13v.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Fri, 19 Jun 2020 02:08:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87a710m13v.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.06.2020 01:59, Juri Linkov wrote: > Actually my question would be better formulated like this: > > Should we reserve the key 'C-x p v' as a prefix map for possible future > extensions when such need to add more vc keys will arise? > Currently I see no such need, but who knows. I'd rather keep it as is. And if such actual need arises, we can change the binding for project-vc-dir. It already "reserves" it, in a way. :-) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 19:25:39 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 23:25:39 +0000 Received: from localhost ([127.0.0.1]:54661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3uc-0006S1-Rb for submit@debbugs.gnu.org; Thu, 18 Jun 2020 19:25:39 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3ua-0006Ra-DY for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 19:25:37 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0D3F4FF805; Thu, 18 Jun 2020 23:25:28 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87zh90nh0v.fsf@mail.linkov.net> <4d13a021-0c79-38c7-5acb-78333a353975@yandex.ru> Date: Fri, 19 Jun 2020 02:24:40 +0300 In-Reply-To: <4d13a021-0c79-38c7-5acb-78333a353975@yandex.ru> (Dmitry Gutov's message of "Fri, 19 Jun 2020 02:01:50 +0300") Message-ID: <87sgesj6tj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> 'C-x p d' - project dired without dispatch prompt >> 'C-x p p d' - the same with dispatch prompt > > It's not the same. It asks you to select a _different_ project. Oh, I forgot it's about switching projects. I'm not sure how frequently this key will be used. If not often, then better to use easier-to-type 'C-x p p' for other more frequent commands, such as using it as a prefix for any command to run in the project root dir, for example, 'C-x p p M-! git pull' will run git commands in the project root dir. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 19:31:38 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 23:31:38 +0000 Received: from localhost ([127.0.0.1]:54670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm40P-0006cF-Ok for submit@debbugs.gnu.org; Thu, 18 Jun 2020 19:31:38 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:38161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm40M-0006bz-Mc for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 19:31:36 -0400 Received: by mail-wm1-f44.google.com with SMTP id f185so7417661wmf.3 for <41890@debbugs.gnu.org>; Thu, 18 Jun 2020 16:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M2hkBLk5rNIvDfrhLvHCw2gDWU2FpUMzb/4Xv7C/G2o=; b=dKkjNBJR7ZSG7xY1eTMEgKsU/QIr+tYRTth/wbtfqGD0k60gRK3fmxPNQEh3s3zvPw 3tw4ts5R9P9/8tGgCv2JlO9N1rrpbpNhgWJKxOFDCi+dRPlXCZU71qR8w7ak3vIdWXqd vKvbfbrzBRmXGX9EC0u/11QPWmogz0uhCjWUsKDJjLJ4sD34wpDltw9OyWQZcOoSvOKx EutXdnzB10vRnfS1bCPhtFhUWW6ll9jU7Jtq9lVx9x4mX2r+RdAwb6nzSZA0nXec4U/o u7x1qBTCQfBMWZQcTj7EGcvsifQrRoAaV3EvLXyOKqpVBqQM5zPv8z3U/lBnN0wfVgKq izQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M2hkBLk5rNIvDfrhLvHCw2gDWU2FpUMzb/4Xv7C/G2o=; b=iqPk9LoZVZfo/AN1jqS2WRMJdp91Wr4G1mdMWTpy8H+BwJz5F53cwZTE9jCh8sWyvp UBka648wBxZQGBOcA0S16ZWWsiTCZsB6Q5AuvSkkWSzBUDUTLhxI9yAh2V8XkhYlknlB 7q9lri38pI4TnETsie2TON3Piws6uPdG0LcIPa17617loia1EQ0Nu0OImK8GvUtYNakZ xC1MtgGIZOXKNG48XRobAAqLxH32O1c2PreKRENp6vO66GKJgMeC+6i03Un6QceAyRuc dlXOdayHuFGk3zTqbEHpSMlURoJQAbQpW4GArJuPni2k8V5J3aIf9U/mDl50BVJuRid3 nfgA== X-Gm-Message-State: AOAM530A1aI1BGYmajnVcpVGVQCyZDyD6jMj5P89Xq1gDQjVh8xcaWF0 Ld+d+2ilcSXCLWSY6M3nsdxfK8md X-Google-Smtp-Source: ABdhPJxSMFtDMfMx/aLz4eLOMQAU59kZajuo8PM5BnxY2NDboKJnEpRhvirYNjXG5cU6wvG88cLDlA== X-Received: by 2002:a1c:ed17:: with SMTP id l23mr648079wmh.175.1592523088707; Thu, 18 Jun 2020 16:31:28 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id q5sm5292443wrm.62.2020.06.18.16.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 16:31:28 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87mu50b43d.fsf@warpmail.net> <87zh90nh0v.fsf@mail.linkov.net> <4d13a021-0c79-38c7-5acb-78333a353975@yandex.ru> <87sgesj6tj.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <7ab0d534-5bd3-82ec-51c1-14744b75ee71@yandex.ru> Date: Fri, 19 Jun 2020 02:31:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87sgesj6tj.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.06.2020 02:24, Juri Linkov wrote: > I'm not sure how frequently this key will be used. I think it's rather handy. Some actual usage data would be good, but we're unlikely to get that with any accuracy. > If not often, then better to use easier-to-type 'C-x p p' > for other more frequent commands, such as using it as > a prefix for any command to run in the project root dir, > for example, 'C-x p p M-! git pull' will run git commands > in the project root dir. If you like to implement such a prefix command, please go ahead. Either way, 'C-x p P' is free. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 02:11:52 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jun 2020 06:11:52 +0000 Received: from localhost ([127.0.0.1]:54849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmAFk-0001qm-8o for submit@debbugs.gnu.org; Fri, 19 Jun 2020 02:11:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmAFg-0001qX-N5 for 41890@debbugs.gnu.org; Fri, 19 Jun 2020 02:11:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56885) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmAFa-0006w2-0N; Fri, 19 Jun 2020 02:11:42 -0400 Received: from [176.228.60.248] (port=3963 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jmAFZ-0000yN-2m; Fri, 19 Jun 2020 02:11:41 -0400 Date: Fri, 19 Jun 2020 09:11:29 +0300 Message-Id: <83a70zzisu.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <5d478a48-5363-e8f2-afbf-ebb0ce86a873@yandex.ru> (message from Dmitry Gutov on Fri, 19 Jun 2020 00:12:30 +0300) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83mu50z3h0.fsf@gnu.org> <83ftasz05i.fsf@gnu.org> <31c994ec-9fa3-02c4-ad94-84cff0e59846@yandex.ru> <83d05wyz44.fsf@gnu.org> <5d478a48-5363-e8f2-afbf-ebb0ce86a873@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 41890@debbugs.gnu.org, theo@thornhill.no, monnier@iro.umontreal.ca > From: Dmitry Gutov > Date: Fri, 19 Jun 2020 00:12:30 +0300 > > So what did you mean by "in some not too distant future" and "no reason > to hurry"? Project commands are functional, and they are in the global > map, for all practical purposes. I'm glad to see project.el being actively worked on, but IMO it has yet some turf to cover before it becomes useful enough for us to think about preloading it. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 06:13:22 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jun 2020 10:13:22 +0000 Received: from localhost ([127.0.0.1]:55163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmE1R-0007s1-P8 for submit@debbugs.gnu.org; Fri, 19 Jun 2020 06:13:21 -0400 Received: from aibo.runbox.com ([91.220.196.211]:47162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmE1O-0007rq-Ol for 41890@debbugs.gnu.org; Fri, 19 Jun 2020 06:13:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Type:MIME-Version:Message-ID:Date:References:Subject: Cc:To:From; bh=j5zpKcr9crHQW0IWgJymT1XHiKqnRuMV1p7K7qR4LVY=; b=kqaUDDNV52UchZ vJa2A6TbfXg+IulqW5iI6c8qypIx9GweWXnV/YadhhQHTunHQ34GwwAU9XgKpNQdobQS9A+K3oRPN Fm9oJV44Ca5IFkGO2zJDEgQyfMgsoW94hXqu/upsLzrc3ONsUdzlGMC/zibRygVvAHCF/ATu0imSH vkpjotOXh2KwCWta3wLbE5nCxvtxQGNPpmNqbKveFRMZqKGIGdwJbr7ADNd/TLs9NqXuPgsQGp1P1 nECr8U4HNiKXOE6oLlRCFThLhcRvzjHYo976qrgDfEt/m/1K1JqeF6s3vq2ivp0sOH4ViHkXj28Ab eNM9UM/Th2+MdMlANSkw==; Received: from [10.9.9.202] (helo=mailfront20.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jmE1M-00027e-3Y; Fri, 19 Jun 2020 12:13:16 +0200 Received: by mailfront20.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jmE1B-0007IE-PT; Fri, 19 Jun 2020 12:13:05 +0200 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87blljbarq.fsf@thornhill.no> <87ftasea9s.fsf@warpmail.net> <902001d0-ab1c-b697-bfd0-b8ec195dc65f@yandex.ru> Date: Fri, 19 Jun 2020 12:13:05 +0200 Message-ID: <87a70zqs7i.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, "Philip K." , juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: > On 18.06.2020 17:09, Philip K. wrote: > >> The patch below fixes that, but allows changing if you only want the >> listed keys to be valid (the default) or every key in >> project-prefix-map. >> It turned out that the transiment map approach didn't work, as it >> ignored the value in default-directory, thus running all commands in >> whatever the current project was. > > Looks reasonable to me. But let's also hear from the original author. > > Simen, what do you think? The patch is at > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41890#127. Looks good to me too! My only gripe would be that it makes it a bit harder to add new commands, since it now requires modifying both project-switch-commands and project-prefix-map. Maybe we could reintroduce the helper function we had for that purpose earlier. -(defvar project-switch-commands - '((?f "Find file" project-find-file) - (?g "Find regexp" project-find-regexp) - (?d "Dired" project-dired) - (?v "VC-Dir" project-vc-dir) - (?e "Eshell" project-eshell)) - "Alist mapping keys to project switching menu entries. +(defcustom project-switch-commands + '((project-find-file . "Find file") + (project-find-regexp . "Find regexp") + (project-dired . "Dired") + (project-vc-dir . "VC-Dir") + (project-shell . "Shell") + (project-eshell . "Eshell")) The project-shell command is added here, don't know if that was intentional? Also why not stick with the easier extensible list format? I could imagine for instance adding long descriptions as an optimal third element for the commands later on. -- Simen From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 06:16:03 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jun 2020 10:16:03 +0000 Received: from localhost ([127.0.0.1]:55168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmE43-0007wV-79 for submit@debbugs.gnu.org; Fri, 19 Jun 2020 06:16:03 -0400 Received: from aibo.runbox.com ([91.220.196.211]:57674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmE41-0007w4-Np for 41890@debbugs.gnu.org; Fri, 19 Jun 2020 06:16:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=kI1t08d/bkMOOqXXd6IHbjQRThTeAYVPmsek1im4F3A=; b=mrDiceTPMjeDVWhChkw7Iugsqb boo0X0tEOpGG5plGt6YTX9mxvxP0tjyoutlNZ4a9JVO9NPMHUvJRB1Lcu7+TyojjzmLM4cFlTGgJs w0r3Y4CytGwHhRUcQI1o7cnt0zhLnoutk7nbIjA1BtrGGOVdeqx02mP/k4LCWR4nk+aQXU6K3mstU LpfGN38kPqwLrKLTZRcfwcY/aACfdAyp+aRDQq+5GvaZ7tbPpewyHSwYc3T/zbjPwxMjFbpUgoiud UOCH4R+goHHhKHSZnvBXui7idOVuTw/GngVB1LhqeELD86zqPVZ/IDnH+TshtEtMLsMNslF5NubZz 6yUYJgcw==; Received: from [10.9.9.202] (helo=mailfront20.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jmE40-0007c1-Sh; Fri, 19 Jun 2020 12:16:01 +0200 Received: by mailfront20.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jmE3e-0008Os-ET; Fri, 19 Jun 2020 12:15:38 +0200 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87mu50b43d.fsf@warpmail.net> <87zh90nh0v.fsf@mail.linkov.net> <4d13a021-0c79-38c7-5acb-78333a353975@yandex.ru> <87sgesj6tj.fsf@mail.linkov.net> <7ab0d534-5bd3-82ec-51c1-14744b75ee71@yandex.ru> Date: Fri, 19 Jun 2020 12:15:38 +0200 In-Reply-To: <7ab0d534-5bd3-82ec-51c1-14744b75ee71@yandex.ru> (Dmitry Gutov's message of "Fri, 19 Jun 2020 02:31:26 +0300") Message-ID: <874kr7qs39.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: > On 19.06.2020 02:24, Juri Linkov wrote: >> I'm not sure how frequently this key will be used. > > I think it's rather handy. Some actual usage data would be good, but > we're unlikely to get that with any accuracy. Another data point: I use it very often. -- Simen From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 06:27:04 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jun 2020 10:27:04 +0000 Received: from localhost ([127.0.0.1]:55179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmEEe-0008H9-Df for submit@debbugs.gnu.org; Fri, 19 Jun 2020 06:27:04 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:58981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmEEY-0008Gs-Pb for 41890@debbugs.gnu.org; Fri, 19 Jun 2020 06:26:58 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 480D75C011A; Fri, 19 Jun 2020 06:26:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 19 Jun 2020 06:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type:content-transfer-encoding; s=fm3; bh=yuMuz8WWJYIDD rpDp2Z3TyjSw7tyKOD/q6kNy3b78Yg=; b=kSPJLr+NLOBUHLRTjTXoIrC6oTCOk 4Sg9RDlM/hRhlOa0Quc12L3cVFNImZYb4E4Oy6cK342AYnFpl5ESUDQ1ypcdhe5r BOw2veKXrCUV87sB6xXWQ8ZvmJS2cgUaOmy0+6Wgr3TwAT2QnsINuTWwcsJ9Oq8J OJHMQKnm51mO6ZliFV1oFm5uyenZyipCEvHAxTTkHdSYfEhdB3rOxxVScB7q0OWQ YX7foYbkAhHiGAzrkQiARe4Izdqgev2wr4VEYJanPdfuPspw3ZDtEAhFSL6iAcdM IxMnAS77S3i5imD/vI76ctty8spfiilLFvVIDFMQp562lvYc6NZzsE3tQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=yuMuz8WWJYIDDrpDp2Z3TyjSw7tyKOD/q6kNy3b78Yg=; b=Jgb+cJLS UQZ+sqI0+2sh7I7kQFbf5wnmVjcbopfAUfGLmulIkiqK+yDyVPW/qloARVTMffXg 2qIn6BtLMyWIaTyWeAjRI09iSAVhicO8D1l5s2s26UlAfL6/AIe5fI2Vk4BMRYk9 1IENg+GIGBYD9CYF9uwR7G7ZId8zCZEpDS2/BhEJvU1SxWcCBYITHx957pzPggCm 8kLiea6i0ItAo7D+UKjQS1csyYE+Vsj1EfxE9vkPoR7+TqP8YuBf8qWDrHJnxKVJ T7hZfpl8qT4Eq89v8PCUWfTCFIgkw7FaoeJyhSCbD10C4d+pBiahdU7D0VTPO5th w8hi7gxZkC1txw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejiedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtgfesthhqredttddtjeenucfhrhhomhepfdfrhhhilhhi phcumfdrfdcuoehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrghtth gvrhhnpeeuuefgkefhtdeuhfeghefhgfevheevleejvdehuedukeduieehhfevgfekfeef leenucffohhmrghinhepghhnuhdrohhrghenucfkphepjeelrddvudelrdduleelrddvud ehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhh ihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p4fdbc7d7.dip0.t-ipconnect.de [79.219.199.215]) by mail.messagingengine.com (Postfix) with ESMTPA id 12856306215A; Fri, 19 Jun 2020 06:26:47 -0400 (EDT) From: "Philip K." To: Simen =?utf-8?Q?Heggest=C3=B8yl?= Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87a70zqs7i.fsf@runbox.com> (message from Simen =?utf-8?Q?Heg?= =?utf-8?Q?gest=C3=B8yl?= on Fri, 19 Jun 2020 12:13:05 +0200) Date: Fri, 19 Jun 2020 12:26:45 +0200 Message-ID: <87h7v7qrkq.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Simen Heggest=C3=B8yl writes: > Dmitry Gutov writes: > >> On 18.06.2020 17:09, Philip K. wrote: >> >>> The patch below fixes that, but allows changing if you only want the >>> listed keys to be valid (the default) or every key in >>> project-prefix-map. >>> It turned out that the transiment map approach didn't work, as it >>> ignored the value in default-directory, thus running all commands in >>> whatever the current project was. >> >> Looks reasonable to me. But let's also hear from the original author. >> >> Simen, what do you think? The patch is at >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41890#127. > > Looks good to me too! > > My only gripe would be that it makes it a bit harder to add new > commands, since it now requires modifying both project-switch-commands > and project-prefix\-map.=20 As in for developers, when they want to contribute a new project-* function or users who want to just change stuff (I know the line might be blury)? > Maybe we could reintroduce the helper function we had for that purpose > earlier. I missed when this happened. In what commit was it removed, or was it just in a patch? > -(defvar project-switch-commands > - '((?f "Find file" project-find-file) > - (?g "Find regexp" project-find-regexp) > - (?d "Dired" project-dired) > - (?v "VC-Dir" project-vc-dir) > - (?e "Eshell" project-eshell)) > - "Alist mapping keys to project switching menu entries. > +(defcustom project-switch-commands > + '((project-find-file . "Find file") > + (project-find-regexp . "Find regexp") > + (project-dired . "Dired") > + (project-vc-dir . "VC-Dir") > + (project-shell . "Shell") > + (project-eshell . "Eshell")) > > The project-shell command is added here, don't know if that was > intentional? No, this must have been a local git mistake. > Also why not stick with the easier extensible list format? I could > imagine for instance adding long descriptions as an optimal third > element for the commands later on. The main reason I changed it was so that the alist was recognized as an alist in customize, but I agree that changing this would be good for forwards compatibility. --=20 Philip K. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 06:51:11 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jun 2020 10:51:11 +0000 Received: from localhost ([127.0.0.1]:55205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmEc3-0000S2-9r for submit@debbugs.gnu.org; Fri, 19 Jun 2020 06:51:11 -0400 Received: from aibo.runbox.com ([91.220.196.211]:59878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmEbx-0000Rp-Df for 41890@debbugs.gnu.org; Fri, 19 Jun 2020 06:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=BcOtDIK26oackQ2Yj5gqll320AH3BB9NIsLzAX3YtOM=; b=RkgbS6vfO/GH+RFRoefJMlrf+g o3VfIPXFcsdEzq0N603T0TBcTkNLEjgFcHQM7rQZkjfu8fvunDn3J5YlaZ/jdFfv0S/Lp6/2WgDHH czpOFTEa5ujCIZiKHTJG4xsmGUkONYX9dJarbILaDv8IiUBzxKUWPYvkguN+qUlfX21MNAkPT4d2B XYMplh2ErZhLhJaLoJEhTg5m8QWomDfKNlqIYxy9xmDpIL/gOoXs4EDKcbPRVPCLqARedQuYqmpW3 +Duprr26CUXDuvbtFn5a8fGMgw9bOBWdQTON8Ky77EKfHSCcvIZlAyeoz4GJuhkul1uNjEVqBkV7x DX0LJdtw==; Received: from [10.9.9.202] (helo=mailfront20.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jmEbu-0002I4-Va; Fri, 19 Jun 2020 12:51:03 +0200 Received: by mailfront20.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jmEbT-0006hk-QC; Fri, 19 Jun 2020 12:50:35 +0200 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: "Philip K." Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87h7v7qrkq.fsf@warpmail.net> Date: Fri, 19 Jun 2020 12:50:35 +0200 In-Reply-To: <87h7v7qrkq.fsf@warpmail.net> (Philip K.'s message of "Fri, 19 Jun 2020 12:26:45 +0200") Message-ID: <87imfnz5vo.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) "Philip K." writes: > Simen Heggest=C3=B8yl writes: > >> My only gripe would be that it makes it a bit harder to add new >> commands, since it now requires modifying both project-switch-commands >> and project-prefix\-map. > > As in for developers, when they want to contribute a new project-* > function or users who want to just change stuff (I know the line might > be blury)? The latter. For the former case I think it's fine. >> Maybe we could reintroduce the helper function we had for that purpose >> earlier. > > I missed when this happened. In what commit was it removed, or was it > just in a patch? Sorry, yes, it was just a patch. Maybe it could look something like this: ;;;###autoload (defun project-add-switch-command (key command label) (define-key project-prefix-map key command) (add-to-list 'project-switch-commands (list command label) t)) -- Simen From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 08:25:27 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jun 2020 12:25:27 +0000 Received: from localhost ([127.0.0.1]:55352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmG5H-0004nU-3P for submit@debbugs.gnu.org; Fri, 19 Jun 2020 08:25:27 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:36299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmG5D-0004nF-Eg for 41890@debbugs.gnu.org; Fri, 19 Jun 2020 08:25:25 -0400 Received: by mail-wr1-f53.google.com with SMTP id q11so9519432wrp.3 for <41890@debbugs.gnu.org>; Fri, 19 Jun 2020 05:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=S5FGr85TlFswtVU+Cl9rZ/lJ8sCUQpWMZWMIo8bZ49g=; b=IDHL8ioa6eGK0D6og7DNYUOoOH0RyTqJxZfmtbNp4pt1znmFAQwgHYLs4mb3/NaU2B yaaKM2peYidB5wePZ2tXPX3y/UTw+N5bPavatOMi7sEPCIIz6n5QJTk6AOlGmYavPYX1 4JlGFn78l8A0DCDzhCj5yWQqtIi3KRXNDfqjbRUPqTYMuemMe+SjZzuIIW+ZqRKWxu37 rCfuuTYY+f1fbn4VzVOLQThA11Wra5QS8JwmOj4V7VRCY6XApNGzKM/O5cj1XKBkNsFX y+/NVXJS2E7JFSWtSfKpAFBn42DwivgjEUni2wgeJGt7NUyQkbm3E7JN98N+++/HkLSB kwYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S5FGr85TlFswtVU+Cl9rZ/lJ8sCUQpWMZWMIo8bZ49g=; b=kl+vk1AHkPRZZo6NQcZCMMi2N3Mee4i+VrBt6PMbOs4rokJM4XGdNI5j70MvqOwfHy CQVXJYJI/O599dLGNMZSLokKMV7JKBdB4fzyXM24VPcngwoUvx1QZ8WvSYRCWuPqsU4E ju6EeqGnEbaT8GM9OB46Q6SH2HOfv5M9Qi2/SQm2UzgModdZGUgXYIsGh2LGtdUwcq/C +KKwMZ9VKFj2sbQYw+LDsdG6pBQ8WAgRdcniSz30HmRWwVX7TNjmRN51QoHcKvcsvGZ1 d8R1iDXZ+X99EHWFlJ6ONyMt/0U68GIqxM7j6iMlS3QVkqAhAnO+btJbJ0ijld5d5ygv 7iqA== X-Gm-Message-State: AOAM5338+5Srp7frPZwFF0V+KgsgayxfcFHCenrGP1vgxcs7IVlLppm1 yZXCet3J3pPdRsJGFGCrGTX5JI99 X-Google-Smtp-Source: ABdhPJz8WzzVsJM8jCtz+GYxDT2eNkKHFbGqjCUhKrx+ZR3+i+2nPYUjznWUFYqTkQNAx/YV5njtHw== X-Received: by 2002:a5d:5551:: with SMTP id g17mr3662953wrw.45.1592569517177; Fri, 19 Jun 2020 05:25:17 -0700 (PDT) Received: from [192.168.0.60] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id n7sm7069106wrx.82.2020.06.19.05.25.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 05:25:16 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: =?UTF-8?Q?Simen_Heggest=c3=b8yl?= , "Philip K." References: <87h7v7qrkq.fsf@warpmail.net> <87imfnz5vo.fsf@runbox.com> From: Dmitry Gutov Message-ID: <885d610c-c39d-06c2-d857-8cd1b521d3b0@yandex.ru> Date: Fri, 19 Jun 2020 15:25:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87imfnz5vo.fsf@runbox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.06.2020 13:50, Simen Heggestøyl wrote: >>> My only gripe would be that it makes it a bit harder to add new >>> commands, since it now requires modifying both project-switch-commands >>> and project-prefix\-map. >> As in for developers, when they want to contribute a new project-* >> function or users who want to just change stuff (I know the line might >> be blury)? > The latter. For the former case I think it's fine. > >>> Maybe we could reintroduce the helper function we had for that purpose >>> earlier. >> I missed when this happened. In what commit was it removed, or was it >> just in a patch? > Sorry, yes, it was just a patch. Maybe it could look something like > this: > > ;;;###autoload > (defun project-add-switch-command (key command label) > (define-key project-prefix-map key command) > (add-to-list 'project-switch-commands (list command label) t)) Not sure the above will change things too much. It's a function, not a Customize interface (which could be added for the current format of project-switch-commands), and its valid values would have to be documented and understood by the user anyway. We could as well put its body in the documentation as customization instructions. Now, I think the current setup is pretty good already. The extra capability that the patch brings will be the ability to turn on project-switch-use-entire-map in their local configs. Are there people here who intend to do that? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 19:59:02 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jun 2020 23:59:02 +0000 Received: from localhost ([127.0.0.1]:58944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnO1-0002HH-U1 for submit@debbugs.gnu.org; Sat, 20 Jun 2020 19:59:02 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnNz-0002GX-FB for 41890@debbugs.gnu.org; Sat, 20 Jun 2020 19:59:00 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 19390C0004; Sat, 20 Jun 2020 23:58:49 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> <87mu518eg9.fsf@mail.linkov.net> <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> Date: Sun, 21 Jun 2020 02:41:46 +0300 In-Reply-To: <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 02:36:49 +0300") Message-ID: <877dw1b8zp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> BTW, shouldn't 'C-x p v' be bound to the whole vc prefix map? >> So 'C-x p v d' will run vc-dir in the project root dir, >> 'C-x p v =' - vc-root-diff in the project root dir, >> 'C-x p v v' - project's vc-next-action, etc. > > That might be over-engineering it a bit. > > Considering that in the vast majority of cases the VC root and the project > root are going to be the same. > > So the users will get the same results from 'C-x p v =' as from 'C-x v D', > and 'C-x p v d' would usually be the same as 'C-x v d' (but having one > binding for the cases when it's different is fine, I guess). So now we finally have a key sequence 'C-x p v' with the same length as 'C-x v d' but that doesn't require confirmation by RET? Nice. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 20:25:32 2020 Received: (at 41890) by debbugs.gnu.org; 21 Jun 2020 00:25:32 +0000 Received: from localhost ([127.0.0.1]:58965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnng-0002vo-6c for submit@debbugs.gnu.org; Sat, 20 Jun 2020 20:25:32 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:38145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnne-0002vb-2J for 41890@debbugs.gnu.org; Sat, 20 Jun 2020 20:25:31 -0400 Received: by mail-wr1-f51.google.com with SMTP id z13so1467778wrw.5 for <41890@debbugs.gnu.org>; Sat, 20 Jun 2020 17:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xPCn/Ki1kXCCE26hqs3Rpl9o9IR8Ec4+LOeDOTYfG2A=; b=agg/k150ZL51njY2TeFpGfSEHJgnZxNk9RPbgbAsn8KrVmRKeMwzLePYjBfwdU6nP4 Rl4vk6jlXOD1le9N/ZkiI2PeFDbGS6nVvUuqClvNU1y2G5p6YPelLR93IOgG/7+jMXdm sDpqswNa+qi8nYa1Z+O9/ofrbbsUWrVhKFq1sq4tVxFRas5/IZ8zAfur+BU9g9juosCQ cnD0/+0jZj/Hygaew+4/5qARdI6/nS+ZsXMRkdYGD8HlzfrG8P+nZRwhUUh4nPCArDj9 WAgPbW93c05qU1nCuL7BRt6H/0aAQg33bW0AKuNTrRel4ZPqJhYZOmtbtH/k+C1nNfR+ No3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xPCn/Ki1kXCCE26hqs3Rpl9o9IR8Ec4+LOeDOTYfG2A=; b=cr/WqVFtXpfEu4gNeO7m4q6KyF1fz1RTeDl2VsQ2WdjyiuUUfM3HZmRuu7544Eno7v vbCT4/JeVGZ9HmAWxtdt5y1RTmQ+kDm1Ob/aA9hNOFNEj7gZiGgx+TKiO2XRJfVSaA3e bhCFlcxSgg2zHSTsqoiZLduEYKnARyYEWJzBVIpJ3gRgXLlTdu9U65N3iIJKZ/7ZPDQr nrv8EtiQxJtM9BvYbvyOsnjHqzwij904TeO/CAu4l2gPxoL1RufRL2qjsZ4fzwKu+BHQ t0hl6YtMiTFMtGfr3hiAZpqEw2MfUj7z9w9OWw3s9LRcywdEknOK/4qumRyqIJSObMWx eCZw== X-Gm-Message-State: AOAM530nLVw96XGHI6GS0pxDhLf01fztYT81t70x/cx3VmdgG9B+DKbF lXm/IajVbflXcQexPgMyFf0= X-Google-Smtp-Source: ABdhPJyy1o7ngci+59GvrrCBrymCCBU0jM/VquhUV7+k4/vMoBNzUNEolGItTgHQnpSO/g2Qkz04Lg== X-Received: by 2002:adf:a34d:: with SMTP id d13mr10899983wrb.270.1592699124081; Sat, 20 Jun 2020 17:25:24 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l190sm58380wml.12.2020.06.20.17.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2020 17:25:23 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> <87mu518eg9.fsf@mail.linkov.net> <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> <877dw1b8zp.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <2ff7755f-5612-9d50-7a5d-0970f53c9acd@yandex.ru> Date: Sun, 21 Jun 2020 03:25:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <877dw1b8zp.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.06.2020 02:41, Juri Linkov wrote: > So now we finally have a key sequence 'C-x p v' with the same length > as 'C-x v d' but that doesn't require confirmation by RET? Nice. Indeed. It can fail with non-default project backends, but we'll get there when we get there. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 11 13:07:47 2020 Received: (at 41890) by debbugs.gnu.org; 11 Jul 2020 17:07:47 +0000 Received: from localhost ([127.0.0.1]:44854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juIyZ-00016c-4q for submit@debbugs.gnu.org; Sat, 11 Jul 2020 13:07:47 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juIyW-00016M-VJ for 41890@debbugs.gnu.org; Sat, 11 Jul 2020 13:07:45 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 97D2F5C009E; Sat, 11 Jul 2020 13:07:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 11 Jul 2020 13:07:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=DJyiWcEwB9P3DNZlfEte6b43jh wvS+cxZ6k46cbL+nA=; b=E9DYLEqzJYqS7VOYGcjfZw5upLir/AvG3CisSxi2z/ 6DW5E7OtGSJBRfGkn+n2iQ42dyn2TQ0S913DpRCFTpakmz1TtU8B2cbqsP99HcBW oN8mbQV+Gs3yU0gNSinvvINEE23eLjDbvgCApNT0eQech4tlQb/virlj1E4i0fqX vy8TI0kCVEm+X/1Kr+8wX5NU6+5EW6fJvCIHw2hIxCGLma6YV3UUTMs2pgkSr5vf czkDMnl5vwMNNN65rQIRBSLdCxUxMaWEL67tna3TUWZ0PbZcDHVCWphDkDGRgh1X EuJPzgzOYpcLAzqJqbq/AeMVNJIeA0yhshvToV/O8isw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=DJyiWc EwB9P3DNZlfEte6b43jhwvS+cxZ6k46cbL+nA=; b=W5oX+tmhzsT85gISmdcud0 sNWdc/O3f+koHyr+w24eEJs+xse71reqQF2+J7MKfZqxSwX+nq9e1Huy1x+/q0tl ihyF1BJcw+yFLogdXBE3W5j1M+RItO3Dzdh90u9SUCxKrEFOwBs2UccYQ2MjK/Qe enkehsGin+LI87gUq5Ky3N3jn2d/cKoXTKIkBMt2ETMu0P+a0LWs2BT6LSfwCL9i 1pcg6KRMQw4rieXIwBy/frg2giYqdVl2zJZfgJTO+E+kP3+Bz3yHq+CI3AVDFc5p ToLVnJ/ZCBiyBrgQEVmvrl50WoWPOzIcyQFDMvLaSwXs4kKlsliEo1aGCdD452uA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdefgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: "Philip K." , "Basil L. Contovounesios" Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87mu50b43d.fsf@warpmail.net> References: <87mu50b43d.fsf@warpmail.net> Date: Sat, 11 Jul 2020 10:07:37 -0700 Message-ID: <87pn92t1ye.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, dgutov@yandex.ru, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 18 Jun 2020 at 08:50PM +02, Philip K. wrote: > From: Philip K > Date: Thu, 18 Jun 2020 16:06:19 +0200 > Subject: [PATCH] Use same keys in project-switch-project as in > project-prefix-map > > * project.el (project-switch-commands): Convert to user option and > change structure. > (project-switch-use-entire-map): Add new option. > (project--keymap-prompt): Adapt to change in project-switch-commands. > (project-switch-project): Use project-prefix-map instead of > project-switch-commands to query valid commands. > --- > lisp/progmodes/project.el | 63 +++++++++++++++++++++++++-------------- > 1 file changed, 41 insertions(+), 22 deletions(-) I hope no-one will object if I ping to ask about the status of this patch -- is it likely to get applied soon? Over in #42210 I'm looking to add a project-other-place-commands defcustom following the lead of this patch, and I'll need to generalise project--keymap-prompt a bit, so I'd prefer to see this patch committed before working on that, if that's possible. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 12 11:18:53 2020 Received: (at 41890) by debbugs.gnu.org; 12 Jul 2020 15:18:53 +0000 Received: from localhost ([127.0.0.1]:46626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1judkj-0001me-9b for submit@debbugs.gnu.org; Sun, 12 Jul 2020 11:18:53 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1judkg-0001mQ-6T for 41890@debbugs.gnu.org; Sun, 12 Jul 2020 11:18:52 -0400 Received: by mail-wm1-f48.google.com with SMTP id f139so10516607wmf.5 for <41890@debbugs.gnu.org>; Sun, 12 Jul 2020 08:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n+yNfNbzlFRv1gO38qwLpk2WAYSWnnM01YTY4Omq67Q=; b=N+dctVW0EcuOHjH69X+CJtTkXtrVqkwTih84Tcz9Beze2Q7XeoIJS5SIHGssRXX1eJ oQYGh9AJVHHUXtyfs1etQ2p3r0FzDLi1/F6xsdK4t3+PL1FOFHToUwHUQyMaq85A2lWq xY/B4fefpclwBrz7WZ6F05VdJtpwKibIdWYtZ0WrapX6kdvpGlG9ij8s2Po9IZZDaaJf +CO1CJYnmmR86HXwe7gqa5Ihn7yPpoS0+QulwchHEZ+cTLbHJm3HaxsLYdO77DjR70RO W5+GVt7ZuG5oW9kYJ08E+ylypKr6zlb+PHW9G6Knyfi+hA0dql9LEYtnHsg5iiiKpdwl imEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n+yNfNbzlFRv1gO38qwLpk2WAYSWnnM01YTY4Omq67Q=; b=EHINz9TLaphka1Tz3YvXNMiTHyqqdHe19sC3vfEgXdJCU14LUCz1ez6MDGTD8cG8Ci z7hG7zT2qG83BboVp0GZ6MsaWUo3tj9LpnlgH0SDenYQKeFJHLo1tu1qFtFmpqmZuQUN aoT+MXecTBLhd21gWYqRXzzP1frOXaTGQblMm5DGGdwcHecNZGzuW9jCRAouuYBW1a+w Ej2TzQlXZ2uAJ+77UE5VyMRg1ztsvF7N9hyQ7Mfx39nLmqSd4qP+3ZVsy8MGxwby7LiR VHgLVqQpeXtYPpU2D8vbtOXHfnHspzI4wvWBSaP4tp3reN+J5nKSSWfBUx4jTX0MkonF kwPQ== X-Gm-Message-State: AOAM531J0w7MF7HZzRNxGNDxMdVuYyufPNb/5rp9SL/4zDUJjBxZsd8L fi2rA4VPtHqKqcBB5e1vqhHqOi/5 X-Google-Smtp-Source: ABdhPJwgvmblIFwha+wOY7pi5kPa+wETcHyY3DVifmNROHMdzEujBCm741cfIAKF98GqlRvEXpsQEA== X-Received: by 2002:a1c:b007:: with SMTP id z7mr14199490wme.37.1594567124096; Sun, 12 Jul 2020 08:18:44 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id b10sm17334473wmj.30.2020.07.12.08.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2020 08:18:43 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , "Philip K." , "Basil L. Contovounesios" References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: Date: Sun, 12 Jul 2020 18:18:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn92t1ye.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! On 11.07.2020 20:07, Sean Whitton wrote: > I hope no-one will object if I ping to ask about the status of this > patch -- is it likely to get applied soon? As the most recent message to this report probably indicated, I'm on the fence. > Over in #42210 I'm looking to add a project-other-place-commands > defcustom following the lead of this patch, and I'll need to generalise > project--keymap-prompt a bit, so I'd prefer to see this patch committed > before working on that, if that's possible. You can post the patch you are working on, even if it depends on this one. But why project--keymap-prompt, though? I thought you were going to do something that would look like a "normal" prefix keymap. They don't prompt. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 12 12:25:00 2020 Received: (at 41890) by debbugs.gnu.org; 12 Jul 2020 16:25:00 +0000 Received: from localhost ([127.0.0.1]:46668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juemi-0003La-Hy for submit@debbugs.gnu.org; Sun, 12 Jul 2020 12:25:00 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juemf-0003LI-6z for 41890@debbugs.gnu.org; Sun, 12 Jul 2020 12:24:59 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C7F835C00F2; Sun, 12 Jul 2020 12:24:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 12 Jul 2020 12:24:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=HODl5sgaZnZlo2iwenJ8CxJ5ES 9B8Q3cf+dWADXOIQI=; b=G5M5hYUu+hmQOQkhIDjXtmlbypOZw1BszLDuEMdj6Y 10YZNDv/ZsYKlL17mmexiCFrnRc3LQdLhFcjbKpXPFk+NRAFg64983htq3HsZDxd w1h1nTGxKqtl9K4Kax0ozI7q7pOHCZISHOMfGA8NWI5LOauuxfpWxAtiEwrbAuMr teDGLBAMz5nfOIC4cm5gtbJAOOdVTOZtNU6R4qDorNSumojjI8MBfEHiuWN47kM/ rqb2nh01hkLYp/E0pwOYg1dx/iCiA6TA/JlrfIkF1v73Bshf2NwEys7A64rQ47xE 2coVNCrSVmW8BeymrgBXkfQTu6vN44DmKezZS5piSTSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=HODl5s gaZnZlo2iwenJ8CxJ5ES9B8Q3cf+dWADXOIQI=; b=CUWCA1B6udneu82ZG4tvet 2L6Pi0/9ZUy3W28rPpmugejJGi1ghFxzn+4HxlRLTfbnktgGG0t7q+68XOApYQ2m k1z9tkI8JXn13N9gaKbUI9q6AjC4OyWRGNmQz4RKErETUZRgAqqa3hKYogqQVA96 D251kLMCY4zaL0j1EUkLkpKjgjlZyBWwF8HddeBfFB6pgRWWeJPfknDqc8T3hfbw hwsA6h3swqJ+Ec/Y95ddIsUBpXMirPtv6WA4tSnTvgnNgwD5mHN31oSxF8zslob1 c1oHiTH5dtvk5kg9ERO3sdUznpZyqJjrN6dI8VGFbcn6+gZonl7XPdH3Ji/1OYCw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdeigddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , "Philip K." , "Basil L. Contovounesios" Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> Date: Sun, 12 Jul 2020 09:24:50 -0700 Message-ID: <874kqcsnu5.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Dmitry, Thank you for your reply. On Sun 12 Jul 2020 at 06:18PM +03, Dmitry Gutov wrote: > You can post the patch you are working on, even if it depends on this one. > > But why project--keymap-prompt, though? I thought you were going to do > something that would look like a "normal" prefix keymap. They don't prompt. Over in the other bug I received feedback from Juri which I understood as saying that only a patch using the prompting approach would be likely to be merged, so I've been working on that. Sounds like things are more undecided than I thought? I myself am mostly neutral between the standard prefix and prompting approaches. Since I'm waiting on assign@gnu.org anyway, maybe it would be best to wait a bit longer on this discussion. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 12 16:18:51 2020 Received: (at 41890) by debbugs.gnu.org; 12 Jul 2020 20:18:51 +0000 Received: from localhost ([127.0.0.1]:46812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juiR1-0000cd-4I for submit@debbugs.gnu.org; Sun, 12 Jul 2020 16:18:51 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:41234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juiQw-0000cM-3l for 41890@debbugs.gnu.org; Sun, 12 Jul 2020 16:18:50 -0400 Received: by mail-lj1-f175.google.com with SMTP id z24so13091236ljn.8 for <41890@debbugs.gnu.org>; Sun, 12 Jul 2020 13:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xyqurmUWS0AyFPn3EHTZqKTuz52HTo8wuGl1uNzxV0U=; b=ZcS+RyVdp/HmeWxKs2Fi+2iwvHkhDBtZY/BlZ/ikD/rovP8OiZqDXjIf11TGFISlRB ZS7HWAq/vYbxO2O5pKM6RURlDoHTN91cG00o7s5LZVfcYKUkSoTFNSSrlk4IW58e4tZ1 y785KlhFFCSKKYc9uaBgSQhDOGkNe8r9xmKcxX+o9w+puRtjBbK+4Xw5y0DEHCucBr9k EpDRMI7yQOPRYkQp1G2cRj6+IhcZHOgAR8cWv+GgPBaYEqVUyzKgB/U1NNXZnrKMf8Mz TLPF0B0sinxvsLD8+Pip4s3UHbzdScWwzrk28UB1WrJKFPUsQCnBuEeZ1unkrC9Va7US pTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xyqurmUWS0AyFPn3EHTZqKTuz52HTo8wuGl1uNzxV0U=; b=MXD8Lb4OZxYuLdXs6/LG9+Pm+5brevSS0QvRZIXkw/7RKWtafsOV5XymuHK7kkb0Kh wWUTd+8l7MZfVAX9QU6vl9H4MIxZYEny/YI3ZdgDyWAbUGyRQLWBpohsDFdWDfK1yeoc +T+pZB6i6Q7qti4Ab+2+BJxS3O3NR8cuSaYo024sCbxI048CQTLU3zhvG3ytDmDTTr5E 0aCfyNClbDH6kOAL4bZQY7XaU7hUsxS3NKJKgSdSF42Wj9P35hBFhokTZrgBnzATr4W7 V6m0NJGme2VYHEFU74wwNdz3r4B2IscmusSJwnz6TK4J4RK4nLw6W+dgXuvY9X1AZL5L OmLA== X-Gm-Message-State: AOAM5306BGWUwNYLQgLdD2hIgCsKBld4TqYh8UHRl5+I0zqKODdDzEB+ 5GUs5mP6sgSKEaFO4iykdNFhizO4 X-Google-Smtp-Source: ABdhPJxpTjyeCBlraXo4AQf+wjWrfkw7kc4B2gi9FGuJ4ySKFYrVCTPX+5NhUPXMQsLH1ymJFtEdEw== X-Received: by 2002:adf:f0ce:: with SMTP id x14mr73631473wro.137.1594584749835; Sun, 12 Jul 2020 13:12:29 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id g14sm20892536wrm.93.2020.07.12.13.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2020 13:12:29 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , "Philip K." , "Basil L. Contovounesios" References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> Date: Sun, 12 Jul 2020 23:12:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874kqcsnu5.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12.07.2020 19:24, Sean Whitton wrote: > Hello Dmitry, > > Thank you for your reply. > > On Sun 12 Jul 2020 at 06:18PM +03, Dmitry Gutov wrote: > >> You can post the patch you are working on, even if it depends on this one. >> >> But why project--keymap-prompt, though? I thought you were going to do >> something that would look like a "normal" prefix keymap. They don't prompt. > > Over in the other bug I received feedback from Juri which I understood > as saying that only a patch using the prompting approach would be likely > to be merged, so I've been working on that. Sounds like things are more > undecided than I thought? There's no decision indeed. I'd like to know what people think, and if there's no strong opinion, how the proposal would look in practice. So unless you're strapped for time, a prototype patch would help. But we can of course first ask Juri what UI did he mean exactly in his feedback. Juri, could you clarify? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 12 19:50:09 2020 Received: (at 41890) by debbugs.gnu.org; 12 Jul 2020 23:50:09 +0000 Received: from localhost ([127.0.0.1]:47141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juljO-0005mU-Tl for submit@debbugs.gnu.org; Sun, 12 Jul 2020 19:50:09 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:35855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juljM-0005lt-Ut for 41890@debbugs.gnu.org; Sun, 12 Jul 2020 19:50:01 -0400 X-Originating-IP: 91.129.103.18 Received: from mail.gandi.net (m91-129-103-18.cust.tele2.ee [91.129.103.18]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8BE081C0002; Sun, 12 Jul 2020 23:49:52 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> Date: Mon, 13 Jul 2020 02:48:12 +0300 In-Reply-To: <874kqcsnu5.fsf@iris.silentflame.com> (Sean Whitton's message of "Sun, 12 Jul 2020 09:24:50 -0700") Message-ID: <875zasthvn.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> But why project--keymap-prompt, though? I thought you were going to do >> something that would look like a "normal" prefix keymap. They don't prompt. > > Over in the other bug I received feedback from Juri which I understood > as saying that only a patch using the prompting approach would be likely > to be merged, so I've been working on that. Sounds like things are more > undecided than I thought? Sorry for the confusion. Actually I referred to the patch that sets the transient map. The fact that it also displays a prompt is a minor detail, not needed for your patch. The patch that I referred to was posted by Philip in https://debbugs.gnu.org/41890#50 This patch uses set-transient-map to set project-prefix-map, and the prompt is displayed by ‘message’. But later Philip sent another patch in https://debbugs.gnu.org/41890#100 that doesn't use set-transient-map for the reasons that I don't understand. Providing the explanation Philip said: It turned out that the transient map approach didn't work, as it ignored the value in default-directory, thus running all commands in whatever the current project was. Maybe the same function can set default-directory to solve the problem to be able to use set-transient-map? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 12 20:13:47 2020 Received: (at 41890) by debbugs.gnu.org; 13 Jul 2020 00:13:47 +0000 Received: from localhost ([127.0.0.1]:47179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jum6M-0006Rk-Un for submit@debbugs.gnu.org; Sun, 12 Jul 2020 20:13:47 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:44837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jum6J-0006RT-4O for 41890@debbugs.gnu.org; Sun, 12 Jul 2020 20:13:45 -0400 Received: by mail-wr1-f48.google.com with SMTP id b6so12600560wrs.11 for <41890@debbugs.gnu.org>; Sun, 12 Jul 2020 17:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MI0pJ+OYWJeUBN2GCavAsghC9XFaMxOtn/vTC0KkpAo=; b=cmk4v3BBuKMHk6l+kO2nSoHXLNxfwveRY1stOSOKNIhke38QXaAcG/ekCG3EjpKy0/ Iyj0bsWSA+QQVk6x/swbKdorIaniH+IPYN+EFHVRghDQOlWFmWWd7quyoZbUPxBeavV4 HFuCYW0vmb2Yp6Q9IU0q9eYZ+9cqzEoiIR1xIt+DMxfpCc8LPPpAcq7xIub9jeC4afOD FolEx54BVUC3xijpSB0V0wX+PzyiItlLEACzKWTGha90EJKwZb/XZEjIKVW+tc5WiEhu ttMN4ksSCKLrwyWq1+MUuoIikiBv+zPUuhnyAHLKXHQiXWvUELLfrueNhJ/2PFxJ6UTL X7wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MI0pJ+OYWJeUBN2GCavAsghC9XFaMxOtn/vTC0KkpAo=; b=ADDbDEGBBowK8VwkoSbVvcPb7JTwOSLPGswAjOoLXrxVNoB0YPaNmNuJU2kvxuRcZJ tlyy+ubx5T8/tipf8An7u0XqQd5zA4RrjP/eFksSf+tpLaCirIfbqNWdXO9vJdU5PyIB saw1yKz0eplf1Chq7fcJEahsgLpU4gZLUMGQptxhnxjpe8eITSRI4u4Rlz8gd1BsdWIl je2LNCBm7E4hFSzhW623zlDUG0BooVPcs6yzL4WU38j8i0p8bjcda0jJ/2wvp/Rzg2Cw rgC6r4l8Tz7L46crXl9GrAN4ps0fkqRlEI6u+1NCSRoHS9I+VFAyFscAMaXJlJkuTgrk l2iA== X-Gm-Message-State: AOAM533D55IsbjhTudJa/FwnUGBDRplUgqtbNONh5pZXskplzpwy8aUS xAOR9s2EhCX0OdyNXw8TJSWHLCkr X-Google-Smtp-Source: ABdhPJyrLAA5vifS6kg6P0W7adi2lNSt+eqWMk8c/IOGG1OBTKUgIv3lzTupyQmqsCHsC9dHI2BRZg== X-Received: by 2002:a5d:6912:: with SMTP id t18mr76137593wru.411.1594599217014; Sun, 12 Jul 2020 17:13:37 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u8sm21199150wrt.28.2020.07.12.17.13.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2020 17:13:36 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov , Sean Whitton References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <875zasthvn.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 13 Jul 2020 03:13:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875zasthvn.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.07.2020 02:48, Juri Linkov wrote: > But later Philip sent another patch in > https://debbugs.gnu.org/41890#100 > that doesn't use set-transient-map > for the reasons that I don't understand. > Providing the explanation Philip said: > > It turned out that the transient map approach didn't work, as it > ignored the value in default-directory, thus running all commands in > whatever the current project was. > > Maybe the same function can set default-directory > to solve the problem to be able to use set-transient-map? I think I can explain that: you can set the transient map to handle the next command, but you can let-bind a variable to only have the binding have the effect during the next command. And you can't exactly setq that value either, or else it would overwrite the buffer-local default-directory value in the current buffer. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 12 20:45:01 2020 Received: (at 41890) by debbugs.gnu.org; 13 Jul 2020 00:45:01 +0000 Received: from localhost ([127.0.0.1]:47197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jumab-0007KC-2T for submit@debbugs.gnu.org; Sun, 12 Jul 2020 20:45:01 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jumaY-0007Jy-Vc for 41890@debbugs.gnu.org; Sun, 12 Jul 2020 20:44:59 -0400 X-Originating-IP: 91.129.103.18 Received: from mail.gandi.net (m91-129-103-18.cust.tele2.ee [91.129.103.18]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 46FD0E0003; Mon, 13 Jul 2020 00:44:49 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <875zasthvn.fsf@mail.linkov.net> Date: Mon, 13 Jul 2020 03:23:33 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 13 Jul 2020 03:13:34 +0300") Message-ID: <87v9isqm6i.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> It turned out that the transient map approach didn't work, as it >> ignored the value in default-directory, thus running all commands in >> whatever the current project was. >> Maybe the same function can set default-directory >> to solve the problem to be able to use set-transient-map? > > I think I can explain that: you can set the transient map to handle the > next command, but you can let-bind a variable to only have the binding > have the effect during the next command. > > And you can't exactly setq that value either, or else it would overwrite > the buffer-local default-directory value in the current buffer. project-switch-project could set a new global variable project-default-directory and project commands could use it. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 13 02:56:55 2020 Received: (at 41890) by debbugs.gnu.org; 13 Jul 2020 06:56:55 +0000 Received: from localhost ([127.0.0.1]:47460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jusOU-0001ri-So for submit@debbugs.gnu.org; Mon, 13 Jul 2020 02:56:55 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jusOQ-0001rM-DE for 41890@debbugs.gnu.org; Mon, 13 Jul 2020 02:56:53 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4A6A65C017D; Mon, 13 Jul 2020 02:56:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 13 Jul 2020 02:56:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:message-id:date:mime-version :content-type; s=fm3; bh=fGKiy9J0V71HAtPjbrdtkr97Xlas22DMCAqPNcZ 4RZ8=; b=AGXxh07PDCdCu1lkdPT7yNmAJckaI0xxhKSwe036FVofPH97khjGehK s/MdnffRW5Q+ZEAjlHwqLKNEiGcphoGCVymX4+WFX8U0bMymw+HEQFUIjIsVY1v+ QhJd9gVnb1kRH2dRuqW1wdNdiIF6C4eJxwStf3ZF660vGgF7jC9/U6EMVxeldbH3 pXb8rWvpqsW0V9j6XufT9tXgC1O8m0e3rduBKioCVgMbV3jR/oePAeSH3HL/pTqc dU3UY+tGFYRuFzb+DiYyGTB5f9pEqfgvd7SBe5wWwoUbvVZhpM9AlHQ5u7Up7qiQ RgC2sg0XaUJ/AmSg8VAer8sRIF4mEJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=fGKiy9J0V71HAtPjb rdtkr97Xlas22DMCAqPNcZ4RZ8=; b=hl28Awst1M3wyjKzbIFWxUMjBl8kvbzTh TePYMDDHU4w5KzyCbZ0zBNTjkvZG2o373ak1hr3PXQ7eircsJ8fI4EbYFPBS3wM7 XQluMBD6Ue5+psUH+Groa1y8ZKFFSYs0y9N3IcKV1V5ctvfjWXNxGSPcutz2q1sc +MLaOMcdE1Tt8sjCnvLVn8CmjgTEZFRnrqKi9Ag8hEkyXmo4Md/3yZ8xWfdO8Sy4 RsI4+4kPrmUfpq8BuirQnDP2i5pY6ZB9LxlJHlz3BBeDPla2yZo2tXV9mbg4c1sE kqiXq/nsj3TCUqHzHE8wZuTd9iY8HXMIUy68t/l2fjt0D/3UP+jpg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdejgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjkfffgggtsehttdertddttddtnecuhfhrohhmpedfrfhhihhlihhp ucfmrddfuceophhhihhlihhpseifrghrphhmrghilhdrnhgvtheqnecuggftrfgrthhtvg hrnhepleffvefhgfelieegheetkedtveehleeliedutdduhedtieejhffhtdegkeejkeet necukfhppeekjedrudeghedrudegrddujeegnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p57910eae.dip0.t-ipconnect.de [87.145.14.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FBDF328005A; Mon, 13 Jul 2020 02:56:43 -0400 (EDT) From: "Philip K." To: Juri Linkov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87v9isqm6i.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 13 Jul 2020 03:23:33 +0300) Message-ID: <875zarnciz.fsf@warpmail.net> Date: Mon, 13 Jul 2020 08:56:41 +0200 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > project-switch-project could set a new global variable > project-default-directory and project commands could use it. Is there something wrong with the second approach? I'd have to try it out myself, but getting a global variable could introduce a double-state situation where when I switch to a project using C-x p p, open another on and then manually switch back to the first one (C-x b), that the global variable project-switch-project would still indicate that the second project is "open". As I said, I haven't tried anything out, and maybe the issue doesn't exist or is circumventable (eg. by having every function reset the global value after using it), but is that really worth it just to use a transient map? Or did I miss something? -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 13 06:47:58 2020 Received: (at 41890) by debbugs.gnu.org; 13 Jul 2020 10:47:58 +0000 Received: from localhost ([127.0.0.1]:47649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juw05-0001W0-TV for submit@debbugs.gnu.org; Mon, 13 Jul 2020 06:47:58 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:55273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juw04-0001Vm-9X for 41890@debbugs.gnu.org; Mon, 13 Jul 2020 06:47:56 -0400 Received: by mail-wm1-f48.google.com with SMTP id o8so12826798wmh.4 for <41890@debbugs.gnu.org>; Mon, 13 Jul 2020 03:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=59fpUf/Zoom8hwCl2NiNEul0PwF/777vfhArPJQI8Dg=; b=OmhqtwS3OQxs/HIZqBA+La3Ff6KgC7jZE42LjbociLtc6D/10uKq4PmJLtg1WMXynG p6Q1zAayqvnkvhkT9zt3y0pJGC2fD/rbEwGH8nnzUZ3mw1CspXmmNwcWRw5U9838uJWq KbldTZHJYWMmdEdlohXmTwOIV7QMwxHe7sEbpxlYQkx3JbR8qFCSt88LgobEGGrsBCzm 8sWJf9ZJapQYNypqGWXLphqkEOq1gTJAkF/rA334uuBWjTZx9R/1RrXp/pPPlPTTFNXA kRDnn7no722PwO/dVEqyFJW0oJ6WXEK0eFB2fbIUN82fmCYT5WKFezhpxJYb+x++Oot7 p98g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=59fpUf/Zoom8hwCl2NiNEul0PwF/777vfhArPJQI8Dg=; b=OfbwCq6fXbtCars8o0ws7MjUQa0O5lNDwZbrLV3coEjPt3ASJDfEUdNKhRFNQYQkbV Nk/Nx5AAFW0T2tE/Dtn4XZAItN7Jl48gIrwbkwQ0cuR/b5b7FOUJcTX3gjAS4lRd9G8E lsVFIo0IeKgt0+JXRlJ+SfGQvy5SJgyyBUqRHelltkz+ydBX83ybmgg89Kt3TLeI4+AP oyLB+E3aNgVoP7BiiGf3yx//seLeI7VpquPkFxJwxUpyeIlcIUIyC4J8gufJUqs6Y/08 WX5ZjNMjhv1UfCpleOl5ynYx6MhszS3jLE5KFEZNKHX3rfonH25vbwS8UYx5WJlcmZxh eKdw== X-Gm-Message-State: AOAM530A0fxbgfqQ+/VaGGu88z/AoEycCMA3HjT2s9kWfZ630sVAZTut Pw5cW/kyesVxb3Lnyhpfi7HNRG13 X-Google-Smtp-Source: ABdhPJwgNZePsN9D489hR0ZuCiBKJRjf9RPFuVDlm7xL4VZz1ya3/pPCiRWuZEExbPnWEg21aq94TA== X-Received: by 2002:a05:600c:2116:: with SMTP id u22mr17983518wml.82.1594637270006; Mon, 13 Jul 2020 03:47:50 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id a123sm23482710wmd.28.2020.07.13.03.47.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 03:47:49 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: "Philip K." , Juri Linkov References: <875zarnciz.fsf@warpmail.net> From: Dmitry Gutov Message-ID: Date: Mon, 13 Jul 2020 13:47:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875zarnciz.fsf@warpmail.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.07.2020 09:56, Philip K. wrote: > Juri Linkov writes: > >> project-switch-project could set a new global variable >> project-default-directory and project commands could use it. > Is there something wrong with the second approach? I think it's fine. Juri's suggestion could work as well, but it sounds like it would require more fiddly management of the new global variable. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 13 06:51:07 2020 Received: (at 41890) by debbugs.gnu.org; 13 Jul 2020 10:51:07 +0000 Received: from localhost ([127.0.0.1]:47658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juw39-0001dh-Af for submit@debbugs.gnu.org; Mon, 13 Jul 2020 06:51:07 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:54609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juw37-0001dE-Uo for 41890@debbugs.gnu.org; Mon, 13 Jul 2020 06:51:06 -0400 Received: by mail-wm1-f48.google.com with SMTP id o8so12835469wmh.4 for <41890@debbugs.gnu.org>; Mon, 13 Jul 2020 03:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Is3yKdau/2xZMWlHmL071aknn4aQEWSjtdZ5qVPwLho=; b=EpV2n0NfLrT3GMQbaN/K3OWpiKMGtJHaN/rzSon3zghFoVbyNH8Jxokl2ZdGFe+hFw MZHHor47FWQe6sSTuVdR5k8LcTUEwjk7ZebynfOXeKLdOQkN/V/y7L88Z0PVYfwHlLA/ u30Hj7PRE4mLV1gKc4aG4PoATHBAh74uJHsoXnfqpzZTlkyIqMkUCyLNfUBU4eimsux7 oYIk2d15PtiWr9MpSWJmRdrHG96FRvi4YNR8gIR4k/si3zbAagQ/YP7DOaJd5+TbvfLY b4wINUN8tlzhIo0EjHxydWWO9kqjahXSrzAPaLG8gjd+erlzISDrKfqGn/qwvz0uCqep 3MNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Is3yKdau/2xZMWlHmL071aknn4aQEWSjtdZ5qVPwLho=; b=l6HnnnReFQJ+vekNjEDF7K4HcXfvfBn5ctqMB12l9nhkPw81DVhZcpkCsqHKGJu3KM ayOjHUZ8eqv/TwFNPlg2TlGzW60vQa3yy8WpB+5z/yrxJxWJvj4jPHAN1sB+dWvw5+8w 8iOgVbLceUUwdUjgaZzwPaSyK8T4BXk5CFQukGmkL+pUInPR2QGG77nhduyxMoMbMTuy YLb1fdCGWaQCWLNzNLopzhtX3lFk2N8neMYm3vDXeis/vcotx5v3oayt001rfhV0Qcyc VszVPK1ZAg3zbpb/akzYXg4b4VXlp/JzKi+OEGiT1EhL06nVNrP49gkfsBwmTn9XFXcr FH9A== X-Gm-Message-State: AOAM530QVAjdYiuyvINYAIb9+2mRprmIHX+9MzUnWET68l1/jcXog0+h NGmP6uZWesXKAtVGLR4utH8QsJRK X-Google-Smtp-Source: ABdhPJyg8Ehlm78VOFaidgJl4YM7T9HLmIPwf/KuLxWDM3mpeduCpYeV5ebOxzPyZpqVOInB3vvG6Q== X-Received: by 2002:a1c:4343:: with SMTP id q64mr18446170wma.20.1594637460070; Mon, 13 Jul 2020 03:51:00 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id w16sm27640064wrg.95.2020.07.13.03.50.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 03:50:59 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el From: Dmitry Gutov To: "Philip K." , Juri Linkov References: <875zarnciz.fsf@warpmail.net> Message-ID: Date: Mon, 13 Jul 2020 13:50:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.07.2020 13:47, Dmitry Gutov wrote: > > Juri's suggestion could work as well, but it sounds like it would > require more fiddly management of the new global variable. ...but the same problem might not exist for Sean's patch. So he can very well try that approach. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 13 07:02:44 2020 Received: (at 41890) by debbugs.gnu.org; 13 Jul 2020 11:02:45 +0000 Received: from localhost ([127.0.0.1]:47676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juwEO-0001vq-P0 for submit@debbugs.gnu.org; Mon, 13 Jul 2020 07:02:44 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juwEN-0001vd-0N for 41890@debbugs.gnu.org; Mon, 13 Jul 2020 07:02:44 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8CB765C0106; Mon, 13 Jul 2020 07:02:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 13 Jul 2020 07:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm3; bh=rfnBNvkaHESEXtZcYku3JMcGCtPSLKgchQv2OGl 3scs=; b=mVJE+P7+vg5uVPDCF4QYlFnu52h3JMP9ewgUlfpusTQNihwHQYZZtdt Jwem1fa+l3rgJzxF3Kyz2+LY/iibZ+RQowKTqckbSDk6+mXwS7Rx+tt1F6nQbSD8 4g8qnfTgsw7nX70juJViEcAOFVudeAiObkMFnZfSF08RNIOubq3kRKlq86rK7IGD 5IGZJuFGj075HlRpbK0pCEhgKeT28/rpab2L/vfHeLYq3ea16s5zCzEUEPuNdepP 82ON5tquZ3t7VOx6jvtsGQ82e6uJGnDQCuKuK6zn1yTXEnXuDvuMUvEOrnE1rZmS hVKOTYiudR69l69YuVjbUFPLl5poS1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rfnBNvkaHESEXtZcY ku3JMcGCtPSLKgchQv2OGl3scs=; b=k9F0lK9UOVY9jIKGaj1izPWK3URUoIanx ZpHdXMtcRPrPwzGhHHUmtSecDFMw0dYi0Fe5L85OGJ05aFfb/KhSGMYx1MAHoWJP gEYRQo271RCLWKTx7dMK/CsjgOeTCUJ/d0prh7xRoM2K8JgVx8+w7MUktqtF6PqT 8Vpj3ptEGR8zXc867roYx+E9UHh5u/HLDnnmMIHId4Jj352tgRFSnAPdRP32fz6n xLBJErsOjnozb3nDq5ssnoPqWSQIeRQWIV8gOt+WHWXnNZxh3sdz4dZ3itHQQ1Q9 6W+8WarJ6oUO3eRLNwEHhloS3TpE0uxjW4v2x1r1oadilWSCr/f8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdekgdefiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujgffkfggtgesthdtredttddttdenucfhrhhomhepfdfrhhhilhhiphcu mfdrfdcuoehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrghtthgvrh hnpeehueeiffevveekteffueefkeefjeekkeekfeejleeufedtudffudfgueeigeffhfen ucfkphepkeejrddugeehrddugedrudejgeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphesfigrrhhpmhgrihhlrdhnvght X-ME-Proxy: Received: from localhost (p57910eae.dip0.t-ipconnect.de [87.145.14.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 402803280063; Mon, 13 Jul 2020 07:02:36 -0400 (EDT) From: "Philip K." To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: (message from Dmitry Gutov on Mon, 13 Jul 2020 13:50:58 +0300) Date: Mon, 13 Jul 2020 13:02:33 +0200 Message-ID: <87o8ojhe46.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: > On 13.07.2020 13:47, Dmitry Gutov wrote: >> >> Juri's suggestion could work as well, but it sounds like it would >> require more fiddly management of the new global variable. > > ...but the same problem might not exist for Sean's patch. I'm missing the context, what exactly is the issue? Or what part of this patch would Sean want to depend on? I hope I understand correctly that this is the patch that should merge C-x 4 4 C-x p f into C-x 4 p f? -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 13 20:55:23 2020 Received: (at 41890) by debbugs.gnu.org; 14 Jul 2020 00:55:24 +0000 Received: from localhost ([127.0.0.1]:49657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jv9EB-0001BL-Mx for submit@debbugs.gnu.org; Mon, 13 Jul 2020 20:55:23 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:14567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jv9EA-0001B4-3e for 41890@debbugs.gnu.org; Mon, 13 Jul 2020 20:55:22 -0400 X-Originating-IP: 91.129.103.18 Received: from mail.gandi.net (m91-129-103-18.cust.tele2.ee [91.129.103.18]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B13E8240005; Tue, 14 Jul 2020 00:55:13 +0000 (UTC) From: Juri Linkov To: "Philip K." Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <875zarnciz.fsf@warpmail.net> Date: Tue, 14 Jul 2020 02:49:44 +0300 In-Reply-To: <875zarnciz.fsf@warpmail.net> (Philip K.'s message of "Mon, 13 Jul 2020 08:56:41 +0200") Message-ID: <874kqa9azb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > As I said, I haven't tried anything out, and maybe the issue doesn't > exist or is circumventable (eg. by having every function reset the > global value after using it), but is that really worth it just to use a > transient map? Or did I miss something? A new variable could introduce a new notion of "the current project". This implies that some commands used in other buffers will be applied to the currently active project. This is similar to the notion of next-error-last-buffer - the most recent buffer for next-error commands. I don't know if a real need exists for such thing, so please leave project-switch-project without a transient map if it already works well. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 14 03:04:04 2020 Received: (at 41890) by debbugs.gnu.org; 14 Jul 2020 07:04:04 +0000 Received: from localhost ([127.0.0.1]:49986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvEyx-0001iK-4C for submit@debbugs.gnu.org; Tue, 14 Jul 2020 03:04:04 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:32901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvEyu-0001ho-Qp for 41890@debbugs.gnu.org; Tue, 14 Jul 2020 03:04:01 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D1F985C0139; Tue, 14 Jul 2020 03:03:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 14 Jul 2020 03:03:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm3; bh=5imGyz1qDJ7o45o6jjtv3CjqSg0Ct2hjHfeEtyt xuUU=; b=FO3DAuY/SW66mdVvPF3bdNxJIc9NPOEZ9PUXidDLzDRl+SLDf+2ud2q TtPnyXduTcwD0+PwNukwx1ywHi+wqzZqu5v+9aQNqL9iMVZB7IU140HCzKTYvx6R 79bMSSMBo0TTnayQqctmKBTRN/LrR1qHl1JD6u8x4ehNHbsH0cDGjdRtSM8gARHL FuPSN2cFjmydLT4caNQagDOv+UkanAlDbkWicvI7keOoxplsY6b/dC0zGFh2hWC5 i1oBlnzpnDRVpHH7/aM4gHP4NR0hJJSbwN0tzlxdAsAhrE/T+IlKUQ4uvpR26sfX chsedkCTtzj5b88dfnUEBZbuCcx27cQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5imGyz1qDJ7o45o6j jtv3CjqSg0Ct2hjHfeEtytxuUU=; b=HkFjpkRmSlDc5ZsYR5B3jYjeqbQIFj8+s xE4AJUdw0pwMLsEr/4fbRecoRFLj6GokKUVWwlDxerWGcMonvNQJGelTOvzi3BI+ 5uqZbNOfAndWSp2mnkq+flDX6RdCDShL4A178GsR+cWOgxJXVBKnrexKSwJUhq+g Nc8by8yeTJyOaUICyu+DlmcX8xmz0vzEGbZb0crPc0QV0C0Mdrf0kfkM7ukX4xyZ zhTwrVmjcEGUCex+Cm0YXRD+rBuEga+L9229ueAe8YGJURyngghdRQBAWQ4VTkfR BvNsN3ki8YPeBv/8zgiCUDyZbyEI1UGTXnaAsNlfdz8oB7PqjyiKw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdelgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtsehttdertddttddtnecuhfhrohhmpedfrfhhihhlihhp ucfmrddfuceophhhihhlihhpseifrghrphhmrghilhdrnhgvtheqnecuggftrfgrthhtvg hrnhepheeuieffveevkeetffeufeekfeejkeekkeefjeelueeftdduffdugfeuieegfffh necukfhppeekjedrudeghedrudegrddujeegnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p57910eae.dip0.t-ipconnect.de [87.145.14.174]) by mail.messagingengine.com (Postfix) with ESMTPA id EE915328005E; Tue, 14 Jul 2020 03:03:52 -0400 (EDT) From: "Philip K." To: Juri Linkov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <874kqa9azb.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 14 Jul 2020 02:49:44 +0300) Date: Tue, 14 Jul 2020 09:03:50 +0200 Message-ID: <87imeqh92h.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: >> As I said, I haven't tried anything out, and maybe the issue doesn't >> exist or is circumventable (eg. by having every function reset the >> global value after using it), but is that really worth it just to use a >> transient map? Or did I miss something? > > A new variable could introduce a new notion of "the current project". > This implies that some commands used in other buffers will be applied > to the currently active project. I'd get a "last active project" variable, as in a fallback when the project cannot be determined after switching buffer or opening new files. But when I hear current project, I'd assume you would have to manually change, which would turn project.el from a tool that assists your workflow to one that dictates it. > This is similar to the notion of next-error-last-buffer - the most > recent buffer for next-error commands. So we're talking about a "last active project"? > I don't know if a real need exists for such thing, so please leave > project-switch-project without a transient map if it already works > well. Fine by me, I'm just asking in case there's a need to update the patch. -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 14 18:51:34 2020 Received: (at 41890) by debbugs.gnu.org; 14 Jul 2020 22:51:34 +0000 Received: from localhost ([127.0.0.1]:51752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvTlu-00074t-7k for submit@debbugs.gnu.org; Tue, 14 Jul 2020 18:51:34 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:38465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvTlp-00074J-To for 41890@debbugs.gnu.org; Tue, 14 Jul 2020 18:51:32 -0400 X-Originating-IP: 91.129.103.18 Received: from mail.gandi.net (m91-129-103-18.cust.tele2.ee [91.129.103.18]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 813F960002; Tue, 14 Jul 2020 22:51:21 +0000 (UTC) From: Juri Linkov To: "Philip K." Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87imeqh92h.fsf@warpmail.net> Date: Wed, 15 Jul 2020 01:34:02 +0300 In-Reply-To: <87imeqh92h.fsf@warpmail.net> (Philip K.'s message of "Tue, 14 Jul 2020 09:03:50 +0200") Message-ID: <874kq93e5h.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> This is similar to the notion of next-error-last-buffer - the most >> recent buffer for next-error commands. BTW, a question for related discussion: should next-error-find-buffer-function provide an option to support project-local value of next-error-find-buffer? So calling ‘next-error’ on the current project's files will use the last next-error buffer belonging to the same project. > So we're talking about a "last active project"? Or maybe "the most recently used project" if put in other words. >> I don't know if a real need exists for such thing, so please leave >> project-switch-project without a transient map if it already works >> well. > > Fine by me, I'm just asking in case there's a need to update the patch. Then it seems you patch doesn't need more updates. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 14 19:32:54 2020 Received: (at 41890) by debbugs.gnu.org; 14 Jul 2020 23:32:54 +0000 Received: from localhost ([127.0.0.1]:51784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvUPu-0008J8-2j for submit@debbugs.gnu.org; Tue, 14 Jul 2020 19:32:54 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:44823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvUPs-0008Iv-H9 for 41890@debbugs.gnu.org; Tue, 14 Jul 2020 19:32:53 -0400 Received: by mail-wr1-f46.google.com with SMTP id b6so437266wrs.11 for <41890@debbugs.gnu.org>; Tue, 14 Jul 2020 16:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MCuVyviKuJoGsHOOU8diVcHh3dcc9z4J/QF8V2zmaTA=; b=LnGeIDdkoYtOw56N3bDN7hSSD6i7CDct/9iNsR3jzEh0W1879saKFIlCGz7PukSnTk zz3B4dYpN4P65dJ2DVhOWGcMygFwyQZMxZ0kQ+W5ztNPU1APM5qxzBz8e13uTp9L+OFY GA0zi9aaLlPVguuMoBxmTgFTTX8MTiEiFK9vUJJj5r6PfnPnfcxaqckBvzDrRvYGGSK6 q/YFs4w6y0LeBF5f4vqSsJeW7IduI0iFJaiAcuxuawJ/64rRxoQnIFGZ9rEetDnlGtFN U9EBw2BL7xzhpZ6VL2cDhNOHOqfhAO+fC9lE2cnc7kX+IB9kDqNHrfq07jkak4UTX0iv 6tdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MCuVyviKuJoGsHOOU8diVcHh3dcc9z4J/QF8V2zmaTA=; b=f65+Ifb8QNecPLxZ9ef15a5D6EUgtbimUgm2z5M9P1r/wFBRSK4hn3U2pwPwxefU4h ipzrbolvCukL4ZXaWMzLmm28td9ofAVtMk4IKCg72Lbnek/cgfSg6+CtDcupCWxO4eJD lTzg1xNHhqOhYW/8XmLdKh2EHmORdLg1IjJsX1m6rDn/D64qL204uE1Zmcrw7QxYe4hH mNT4fnEvl0PXlSqKwHaN+8NtSsb5lDhYzBkyUj9XjTlCufkx0rI03McaSLmG4YXl1Y/R ydXxy3Iv1Uh1xWZ8z5VtbyC/1xpY0GHS/vsf2jILfUkQPhChHrDP98XTHbVkgsMbGvNg HeQg== X-Gm-Message-State: AOAM531jdli0Xk2DAdUcpvObLTgFrTdfMSnX/IhrzoCDfYXjy+DUqlqh kgywbA+5QZtlIqmFmmRVFc28dkVA X-Google-Smtp-Source: ABdhPJyQGqCaL9nWZl4wUhtZwcK9v2VSnlxb64AMPs/IgU8TZCL5wIX1hPJwRmW3aCs6xXNAABL5uA== X-Received: by 2002:adf:ecc8:: with SMTP id s8mr8448554wro.317.1594769566360; Tue, 14 Jul 2020 16:32:46 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id b10sm515244wmj.30.2020.07.14.16.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2020 16:32:45 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov , "Philip K." References: <87imeqh92h.fsf@warpmail.net> <874kq93e5h.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <37b0c696-a447-c8ca-0a00-2a0bd1425be5@yandex.ru> Date: Wed, 15 Jul 2020 02:32:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874kq93e5h.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 15.07.2020 01:34, Juri Linkov wrote: > BTW, a question for related discussion: should next-error-find-buffer-function > provide an option to support project-local value of next-error-find-buffer? > So calling ‘next-error’ on the current project's files will use the last > next-error buffer belonging to the same project. Would that work as an optional value for next-error-find-buffer-function? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 15 15:21:19 2020 Received: (at 41890) by debbugs.gnu.org; 15 Jul 2020 19:21:19 +0000 Received: from localhost ([127.0.0.1]:53646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvmxz-0001cF-9g for submit@debbugs.gnu.org; Wed, 15 Jul 2020 15:21:19 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvmxw-0001c1-2V for 41890@debbugs.gnu.org; Wed, 15 Jul 2020 15:21:18 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A0E7A5C00E5; Wed, 15 Jul 2020 15:21:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 15 Jul 2020 15:21:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type:content-transfer-encoding; s=fm3; bh=aGeKAy9BuoWX1 pMO4BrJvACFon5mi98rW2zV0ZAVi3M=; b=NIp150pYWEFtOEPhjBPEw8C1ZFy2O n4HaO3zT3o0+H78TVgVH5RKKtAvqJyePMo2TbthalErEJ8o61v1R1pPFG/c3adQO YOGvuCapurdMDwzrM9Ru0rykGx4nQGbUd1515RC/SPXeuJzYPK5E7NSiaFTj/twK lM5Qr7LmYYGtzRQv9DFw1wUaLhN56BZTZP7dcF9GlizAEiWXujf++NsxYtJbaC36 3oe2wZNLlAMAt2QxuTBYGyZgTeUGjkDRWH0mPXkX3741FUvkDGMD5ENHgBa4j4Q3 LSZPDt/wxHYlPP5tqzZYFcIh7CcdsHDXzdtacj9qHIXOr4Q/wjMhys3Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=aGeKAy9BuoWX1pMO4BrJvACFon5mi98rW2zV0ZAVi3M=; b=I3byg4V7 qgPusHDcvKdnD6IZHZAZ8swBcwicIbqqFthtJStIQduD4TVN851jEEn4Peran6Qy RFBGwxSWxpAe2MSRmmt7dPCasoJgK1o2V3mp0Ltg49xSJe40v3vq+8utfY4WNoNL fkOYvDm4xfui8XxwkqjhNvU4N3laRaSV+kal3HgdXcEAFb+9SRoIHeaxkcLGmk/P bL8KUI4DLGKtQtDodqvbRMz7d9umeL7Qo6v+35MB4Pm1d22ywVfoPPsn3UmIrhzM gFj4ak0u7CqBhY0K+ftmZnTW3zj4fKlLf5H1QxmK6tcm5Mx2hYcwAfNqm9vQyINe fZvyTQ6XEjhHAQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfedvgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtgfesthhqredttddtjeenucfhrhhomhepfdfrhhhilhhi phcumfdrfdcuoehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrghtth gvrhhnpefhudejveduvdfftedugffhuddvgfevffeufedvleejueffjeehledufedtudff feenucfkphepkeejrddugeehrddtrdduheeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p5791009c.dip0.t-ipconnect.de [87.145.0.156]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D7A83280063; Wed, 15 Jul 2020 15:21:08 -0400 (EDT) From: "Philip K." To: Juri Linkov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <874kq93e5h.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 15 Jul 2020 01:34:02 +0300) Date: Wed, 15 Jul 2020 21:21:06 +0200 Message-ID: <87blkgk2jh.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: >>> This is similar to the notion of next-error-last-buffer - the most >>> recent buffer for next-error commands. > > BTW, a question for related discussion: should next-error-find-buffer-fun= ction > provide an option to support project-local value of next-error-find-buffe= r? > So calling =E2=80=98next-error=E2=80=99 on the current project's files wi= ll use the last > next-error buffer belonging to the same project. Related to this, it might also be worth considering a project-local xref stack. If I don't clear the stack before switching between projects (or even just my scratch buffer), I can easily get surprised by landing somewhere I didn't expect. --=20 Philip K. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 15 19:35:39 2020 Received: (at 41890) by debbugs.gnu.org; 15 Jul 2020 23:35:39 +0000 Received: from localhost ([127.0.0.1]:54137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvqw7-0007kk-Hy for submit@debbugs.gnu.org; Wed, 15 Jul 2020 19:35:39 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:44034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvqw3-0007kT-BS for 41890@debbugs.gnu.org; Wed, 15 Jul 2020 19:35:38 -0400 Received: by mail-wr1-f52.google.com with SMTP id b6so4804283wrs.11 for <41890@debbugs.gnu.org>; Wed, 15 Jul 2020 16:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vB2TB0FmSR48wPl/UlWDj5/Bkco+tugrjpIITecsl3I=; b=hzuOfg3QYzQ7GI5guosuDkwdgAc04RRSMEF8v5Ocg7l5Qv3YBSz73dcjO/IZ4bc7bK lvePipfXcma4+x0WIrtyPqPwCtd9NZg5qPDlmOuacazwZvL7tJpGMpUMXIh12Lbxhoi0 WpEHz8+8j7V5sptM7KG+hAPJvrvvygxu7ilzl/xBtE75nXBsOwj+2hucY+xSxocc9XWo 3T+JtTK8Lu7ZCa+rnjrtX1GixNEONdjG93jGAj5WDYRwTgLl6clb5U6V+CbhqE60pghF iRPeEKyVFIbJMWgqMNw+IxASSd7pbwwc+Norgj9sb91QURkKLrrHXELo0RGzKijeXBSK U95Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vB2TB0FmSR48wPl/UlWDj5/Bkco+tugrjpIITecsl3I=; b=nlqFcpZFgYeIz2IhFlvEx6KsiO6wstq3eHbUxWpp1MzNpNHWBNDKR+wvO0QeEVSMS9 XlTBpbHBNNF7WN3Z2le7Wuir+L8w4dNx9MymIiibGhXgc7JO6ZI6CPbk5tGK0fdmQGpx wZZIxUZOPVKFrhz8n+6PmRxcBA2HwgKNlc+f65fo8Rx4lbk+bT7dfP4od5QA0Y8oE1EL QmsZ9mlV67Fi+Jj+7vAPI9Un3ej+L6TSFiKb943meCMCxskfXoug1xRg/wy3v/3ijAe8 aVxOgmm9kIpb8KLfWGX9+g6jcYIwbWpWmRk7T7yAK+OHhctV3Vg1jfuwC/4F4PgHgNLr p+0Q== X-Gm-Message-State: AOAM530vgXct8ZT4dyDiI7GtDky6Z5dhIej1Kjw37syvEampPZ4AZNAF YNqLvoxUrCI8Eac+ZpU45iSs309r X-Google-Smtp-Source: ABdhPJxP0yW9Vcwa6p4a904OTyg5p6BO3BMhBgfG9cJJ1tHTQ2AgCj5DasZmMEVLunaGmsQ9XbeVMg== X-Received: by 2002:a5d:43d2:: with SMTP id v18mr1987459wrr.196.1594856128988; Wed, 15 Jul 2020 16:35:28 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l15sm5578949wro.33.2020.07.15.16.35.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 16:35:28 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: "Philip K." , Juri Linkov References: <87blkgk2jh.fsf@warpmail.net> From: Dmitry Gutov Message-ID: <0e42bcc7-bea5-f4c1-2936-4729cbf28786@yandex.ru> Date: Thu, 16 Jul 2020 02:35:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87blkgk2jh.fsf@warpmail.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 15.07.2020 22:21, Philip K. wrote: > Related to this, it might also be worth considering a project-local xref > stack. If I don't clear the stack before switching between projects (or > even just my scratch buffer), I can easily get surprised by landing > somewhere I didn't expect. Interesting thought. We can make the xref stack storage pluggable. One or two user options should do the trick. Personally, I've been using window-local locations history (via a third-party package), that can become another value of said options. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 15 20:03:11 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jul 2020 00:03:11 +0000 Received: from localhost ([127.0.0.1]:54157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvrMl-0008OM-Fb for submit@debbugs.gnu.org; Wed, 15 Jul 2020 20:03:11 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jvrMj-0008O7-OQ for 41890@debbugs.gnu.org; Wed, 15 Jul 2020 20:03:10 -0400 X-Originating-IP: 91.129.103.18 Received: from mail.gandi.net (m91-129-103-18.cust.tele2.ee [91.129.103.18]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C577F40004; Thu, 16 Jul 2020 00:03:01 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87imeqh92h.fsf@warpmail.net> <874kq93e5h.fsf@mail.linkov.net> <37b0c696-a447-c8ca-0a00-2a0bd1425be5@yandex.ru> Date: Thu, 16 Jul 2020 02:59:31 +0300 In-Reply-To: <37b0c696-a447-c8ca-0a00-2a0bd1425be5@yandex.ru> (Dmitry Gutov's message of "Wed, 15 Jul 2020 02:32:43 +0300") Message-ID: <87r1tcba5g.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, "Philip K." , spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> BTW, a question for related discussion: should next-error-find-buffer-function >> provide an option to support project-local value of next-error-find-buffer? >> So calling ‘next-error’ on the current project's files will use the last >> next-error buffer belonging to the same project. > > Would that work as an optional value for next-error-find-buffer-function? I believe it should be possible with a new value of next-error-find-buffer-function. Want give it a try? ;-) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 09:38:29 2020 Received: (at 41890) by debbugs.gnu.org; 16 Jul 2020 13:38:29 +0000 Received: from localhost ([127.0.0.1]:55000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw45l-0005WD-E3 for submit@debbugs.gnu.org; Thu, 16 Jul 2020 09:38:29 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:39251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw45j-0005Vz-52 for 41890@debbugs.gnu.org; Thu, 16 Jul 2020 09:38:28 -0400 Received: by mail-wm1-f45.google.com with SMTP id w3so11636790wmi.4 for <41890@debbugs.gnu.org>; Thu, 16 Jul 2020 06:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=daZZA2ZouhMT/o0EQiaRTZNFFmUtagoja9CaBvj++Vk=; b=emY1Npz5cAfxBvxBxFYteOZk+s8fFp4/sK6wq1GIWthlKYJelgepLX2lz9srzlSHLS WYJIZZo8lvz2f241zx6eIY8r/4l22aDzeu58m+/nE9vK6dUHGvH5Eng3BxoQBYynXKsY JpOgkHJW8R7B4s5pyQDzKnWuLNcDlS8yz21u3erYx1/1pIKMsDRcFvOJvY3hvUfOLdu2 JtCl974bdqswJG4ecVPtQIemGLX8m+KSjNB3pfpkiTpVbfG3eogSZkirBx0NobfYBCKi zYZeviomlWtIhJ8wQu+/xdRYiASXkokkT+g5hTiZzxuaYgVuBj9rREedffVSzYDI1qql fjOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=daZZA2ZouhMT/o0EQiaRTZNFFmUtagoja9CaBvj++Vk=; b=SdbzkJ1ckkdfEY9Orx2yRraDNRPwrP5dTK5JmQSMk2W5vADBzZD1gkO+WFOJ90id6u RhAI5r5JPOuElPxuILPp83yfoeXXg3FHUK0FrUX5u9hW8NggbfKZJ/uSmgNzkh5Mo5Px OBMk/Tvn8l2BK1ABemsOafyK43XAjvlD7+d5nch3u/74pD3Rc/O7UvwcusJAheYUY5ha O5zJ8/y4EkHo+2tW9AhGhwlQKRe0i04SiZQtTgJQwBNvfSJBIMQ+aMMLLefJ7nCdWS6d 1L0/tyjNXCfV1EVroE7CMhkQi9Pp3MWW/cchPZGSgtyzZxkwbd+zaXrBWNZI0nJHLtbH HJHQ== X-Gm-Message-State: AOAM531OWFU/yJwn3LXdCM2Dt5+X/wR+rnIHY5zitqVj2GP7inkq23TK c7nVltjM/7k8BLJdxBV4ZjeNCfBX X-Google-Smtp-Source: ABdhPJw+WQ+LI1VLv2DqRHNzzTQ/rXjcEIcO/vex35WrvMn6y6yiVFqChJljcpkxMMtlwMk8XOvoPw== X-Received: by 2002:a1c:1fc2:: with SMTP id f185mr4447282wmf.0.1594906701068; Thu, 16 Jul 2020 06:38:21 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id h13sm9060773wml.42.2020.07.16.06.38.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 06:38:20 -0700 (PDT) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87imeqh92h.fsf@warpmail.net> <874kq93e5h.fsf@mail.linkov.net> <37b0c696-a447-c8ca-0a00-2a0bd1425be5@yandex.ru> <87r1tcba5g.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6000d94c-f25a-8925-5a43-ef9ca14aa9a1@yandex.ru> Date: Thu, 16 Jul 2020 16:38:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87r1tcba5g.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, "Philip K." , spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 16.07.2020 02:59, Juri Linkov wrote: >>> BTW, a question for related discussion: should next-error-find-buffer-function >>> provide an option to support project-local value of next-error-find-buffer? >>> So calling ‘next-error’ on the current project's files will use the last >>> next-error buffer belonging to the same project. >> Would that work as an optional value for next-error-find-buffer-function? > I believe it should be possible with a new value of next-error-find-buffer-function. > Want give it a try?;-) I like the idea, but I'm not sure I'm going to use this myself. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 11:19:36 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jul 2020 15:19:37 +0000 Received: from localhost ([127.0.0.1]:59191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwoci-0003A8-G8 for submit@debbugs.gnu.org; Sat, 18 Jul 2020 11:19:36 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwocg-00039q-0L for 41890@debbugs.gnu.org; Sat, 18 Jul 2020 11:19:34 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B8E8D5C010C; Sat, 18 Jul 2020 11:19:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 18 Jul 2020 11:19:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=DZ9usMFQ78mReR7zNmAp+nOWW5 ibcwRcj4Esc/Cm8Go=; b=TfFNR3FkUO6omsSs+mJ+lFBTiE4ghH/p3vehYElQim 9z5/zc8of53x7j28zU403Zk1uMDfS3E+9xX35qfTN18yBN3y0VZH0gwzcWVzdTYS KSRfh8mbQMueRhShAYfZrbUP0nzgQY80HfF6tlW6d2j9lBkfJ6ozhZs9nkriPxeb JLe0ePZ3yTndrXPyE1liGdvvnitE/ypOrzVbrjunx2VXRLv3MvCIBYePqDHqMkP5 nmYpm3pKyG82KyjkaCVEKDswZSJ9G/wdDK6yPn63sPEo+4AVzIOg3ROj2e7077Hc I8sW+IXMANhfYpQVSOmVrNtXLHXB3ECSaGjU8ssKqsbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=DZ9usM FQ78mReR7zNmAp+nOWW5ibcwRcj4Esc/Cm8Go=; b=CqO1Li3uvDfRu7BMQOR4BE HPngpORQ22+MCj1aqs8yTkQhvTvh0zFJsSEBtiE4j4hVH1FzHvwE5gvGJmmeaZUt mt6GvVmYR18xjwkLLuJ5SDJ+TDGU0s6zjcB/jLDkMV7V23nDNXKSk3ZrlP3ddudc aeCclXi7AGPYxHQ4RN4pNgt6TSW9WGwiF0ZgvGhtdQXa5e/h/zpyqMtJtE12w4dY up2M/EN5539/E2Zw+hjwV6oVGSaEAIiQKMiMi0g+34XybM/5QUAaafnDMInxaaNs 7RXbalJzXW41fWOVkZaDmRB696it3fj7YQaD2WusKlWBqK/ymGZXsrnoPRUlZOYA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeelgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: "Philip K." , Dmitry Gutov Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87o8ojhe46.fsf@warpmail.net> References: <87o8ojhe46.fsf@warpmail.net> Date: Sat, 18 Jul 2020 08:19:25 -0700 Message-ID: <871rl8hmv6.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Philip, On Mon 13 Jul 2020 at 01:02PM +02, Philip K. wrote: > Dmitry Gutov writes: > >> On 13.07.2020 13:47, Dmitry Gutov wrote: >>> >>> Juri's suggestion could work as well, but it sounds like it would >>> require more fiddly management of the new global variable. >> >> ...but the same problem might not exist for Sean's patch. > > I'm missing the context, what exactly is the issue? Or what part of this > patch would Sean want to depend on? I hope I understand correctly that > this is the patch that should merge C-x 4 4 C-x p f into C-x 4 p f? Yes, that one. Juri suggested that I try to make C-x 4 p work like C-x p p, so my patch is probably going to need to generalise some of the code which powers C-x p p, but it seems there is some disagreement right now about how C-x p p is going to work. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 12:06:35 2020 Received: (at 41890) by debbugs.gnu.org; 18 Jul 2020 16:06:35 +0000 Received: from localhost ([127.0.0.1]:59230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwpMB-0004Hw-4F for submit@debbugs.gnu.org; Sat, 18 Jul 2020 12:06:35 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:57129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwpM8-0004He-O2; Sat, 18 Jul 2020 12:06:34 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 76F7F5809BE; Sat, 18 Jul 2020 12:06:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 18 Jul 2020 12:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=7PLsnE35wnNAk0su08Gl2/3ERF DxqZxfH3bu7zZMYXM=; b=ozkqTbmyYDhkuwT2kVMNha8q6V6PSX1+9yN3VwCgiW +n7kY4ArUdH5d9+1TU7FS8q7gnhAvsVYpLT+rFnsP+o55QqRuDvdZa5uiEJeqbpe fknKt6RxzYApahQ1KUY/hcfRY+aTXWvrKFOFIhUfspP2+195toOWHK1qjCX+AH7X p5A/XdIMK4FpN7IwJAC9wB2ASsCSS+Zrz6HY3xnFoglVlwbNZdD20cRuemYW/hC+ PTsytHmaW5m0N4NXXBPL1b1W+/pMNFlrqo0TpNXNzUMziK7/aUW8SXYRCQw2XC8u yWpsPcQiL60/MkbcjPw3YT8PvxZ7YCiRWwrUSP5FWr3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=7PLsnE 35wnNAk0su08Gl2/3ERFDxqZxfH3bu7zZMYXM=; b=C6JcWZ0mq8tIUHPbPG/k6Y jXYwQVB0w/vYk58bW6gZhJ80JhBpaSP+osUAD7asnBqBwn8J02wLOqRbqQldLR30 cN2azeM5KLtkY2E2FuYHPBa9uouY9bjF7rSvlGh4ElBrvqhw/fyfBgbJHkNPgGkT WAsp0C79tmwA59DeFb9I0TIpxj8zOCEmxbxfhLZNqbPxcRpOxFHIlMmcuqOJIYvr MkOHygsWrOZuClUA9eDoeC45ZFJGRrAAecONzb4oNjwdZcIU2U68bN1ZjvMVzoYJ azIIKSrSJZt/WK8Pl974/O737FlaSlLbt/gFX6TP4V3gS3/9gStjzK+gXo2+r43Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeelgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenog fhohhrsghiugguvghnufhorhhtjfgurhculdehtddtmdenucfjughrpefhvffujghffffk gggtsehmtderredttddtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhh hithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepieff hfffudfhjefgfeeuleeutdevtdektdehiefgieetleevveekgeduhedtudefnecuhfhorh gsihguuggvnhfuohhrthfjughrpeffhffkuffvgggjtghfsehmtderredttddtnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtth honhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , "Philip K." , "Basil L. Contovounesios" Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> Date: Sat, 18 Jul 2020 09:06:25 -0700 Message-ID: <87y2ngg64e.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello Dmitry and others, On Sun 12 Jul 2020 at 11:12PM +03, Dmitry Gutov wrote: > There's no decision indeed. I'd like to know what people think, and if > there's no strong opinion, how the proposal would look in practice. > > So unless you're strapped for time, a prototype patch would help. Okay, here's a prototype. I had to rebase Philip's patch so I thought I might as well attach my version of that too. I have been wanting the new C-x 4 p bindings all week as C-x p f with fido-mode has replaced a lot of my use of C-x C-f, so I hope I can replace my use of C-x 4 f with C-x 4 p f soon :) -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-same-keys-in-project-switch-project-as-in-projec.patch >From c9f20a5a547631ab12cd3cf8da2ca51b71cfb28e Mon Sep 17 00:00:00 2001 From: Philip K Date: Thu, 18 Jun 2020 16:06:19 +0200 Subject: [PATCH 1/2] Use same keys in project-switch-project as in project-prefix-map * project.el (project-switch-commands): Convert to user option and change structure. (project-switch-use-entire-map): Add new option. (project--keymap-prompt): Adapt to change in project-switch-commands (project-switch-project): Use project-prefix-map instead of project-switch-commands to query valid commands. --- lisp/progmodes/project.el | 63 +++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 67ce3dc7d9..4f0233c8b7 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -974,27 +974,46 @@ project-known-project-roots ;;; Project switching ;;;###autoload -(defvar project-switch-commands - '((?f "Find file" project-find-file) - (?g "Find regexp" project-find-regexp) - (?d "Dired" project-dired) - (?v "VC-Dir" project-vc-dir) - (?e "Eshell" project-eshell)) - "Alist mapping keys to project switching menu entries. +(defcustom project-switch-commands + '((project-find-file . "Find file") + (project-find-regexp . "Find regexp") + (project-dired . "Dired") + (project-vc-dir . "VC-Dir") + (project-shell . "Shell") + (project-eshell . "Eshell")) + "Alist mapping commands to descriptions. Used by `project-switch-project' to construct a dispatch menu of commands available upon \"switching\" to another project. -Each element is of the form (KEY LABEL COMMAND), where COMMAND is the -command to run when KEY is pressed. LABEL is used to distinguish -the menu entries in the dispatch menu.") +Each element looks like (COMMAND LABEL), where COMMAND should be +bound in `project-prefix-map'. LABEL is used to distinguish the +choice in the dispatch menu." + :type '(alist :key-type function + :value-type string) + :options (mapcan (lambda (ent) + (and (commandp (cdr ent)) + (list (cdr ent)))) + (cdr project-prefix-map)) + :version "28.1") + +(defcustom project-switch-use-entire-map t + "Make `project-switch-project' use entire `project-prefix-map'. +If nil, `project-switch-project' will only recognize commands +listed in `project-switch-commands', and signal an error when +others are invoked. Otherwise, all keys in +`project-switch-commands', are legal even if they aren't listed +in the minibuffer." + :type 'bool + :version "28.1") (defun project--keymap-prompt () "Return a prompt for the project swithing dispatch menu." (mapconcat - (pcase-lambda (`(,key ,label)) - (format "[%s] %s" - (propertize (key-description `(,key)) 'face 'bold) - label)) + (pcase-lambda (`(,cmd . ,label)) + (let ((key (where-is-internal cmd project-prefix-map t))) + (format "[%s] %s" + (propertize (key-description key) 'face 'bold) + label))) project-switch-commands " ")) @@ -1004,14 +1023,14 @@ project-switch-project The available commands are presented as a dispatch menu made from `project-switch-commands'." (interactive) - (let ((dir (project-prompt-project-dir)) - (choice nil)) - (while (not choice) - (setq choice (assq (read-event (project--keymap-prompt)) - project-switch-commands))) - (let ((default-directory dir) - (project-current-inhibit-prompt t)) - (call-interactively (nth 2 choice))))) + (let* ((default-directory (project-prompt-project-dir)) + (project-current-inhibit-prompt t) + (key (read-key-sequence-vector (project--keymap-prompt))) + (cmd (lookup-key project-prefix-map key))) + (if (and cmd (or project-switch-use-entire-map + (assq cmd project-switch-commands))) + (call-interactively cmd) + (user-error "%s is undefined" (key-description key))))) (provide 'project) ;;; project.el ends here -- 2.27.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-WIP-Add-project-other-place-commands-and-functions-w.patch >From 37bc752289bd101ceb725446b425944630971f61 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sat, 18 Jul 2020 08:59:19 -0700 Subject: [PATCH 2/2] WIP: Add project-other-place-commands and functions which use it --- lisp/progmodes/project.el | 51 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 4f0233c8b7..f67698ac96 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -985,6 +985,36 @@ project-switch-commands Used by `project-switch-project' to construct a dispatch menu of commands available upon \"switching\" to another project. +Each element looks like (COMMAND LABEL), where COMMAND should be +bound in `project-prefix-map'. LABEL is used to distinguish the +choice in the dispatch menu." + :type '(alist :key-type function + :value-type string) + :options (mapcan (lambda (ent) + (and (commandp (cdr ent)) + (list (cdr ent)))) + (cdr project-prefix-map)) + :version "28.1") + +;; "other-place" because non-prototype patch will also add an entry +;; in ctl-x-5-map and under C-x t p +(defcustom project-other-place-commands + '((project-find-file . "Find file") + (project-switch-to-buffer . "Switch to buffer") + (project-dired . "Dired") + ;; Eshell uses the current window by default, but Shell defaults + ;; to using the other window. If a user has added an entry to + ;; `display-buffer-alist' for Shell, they probably want to add an + ;; entry here, too + (project-eshell . "Eshell") + (project-switch-project . "Switch project")) + "Alist mapping commands to descriptions. +Used by `project-other-window-command' to construct a dispatch menu of +commands available to be displayed in another window. + +Commands in this list should be ones which normally display their +buffer in the current window. + Each element looks like (COMMAND LABEL), where COMMAND should be bound in `project-prefix-map'. LABEL is used to distinguish the choice in the dispatch menu." @@ -1006,7 +1036,7 @@ project-switch-use-entire-map :type 'bool :version "28.1") -(defun project--keymap-prompt () +(defun project--keymap-prompt (cmds) "Return a prompt for the project swithing dispatch menu." (mapconcat (pcase-lambda (`(,cmd . ,label)) @@ -1014,7 +1044,7 @@ project--keymap-prompt (format "[%s] %s" (propertize (key-description key) 'face 'bold) label))) - project-switch-commands + cmds " ")) ;;;###autoload @@ -1025,12 +1055,27 @@ project-switch-project (interactive) (let* ((default-directory (project-prompt-project-dir)) (project-current-inhibit-prompt t) - (key (read-key-sequence-vector (project--keymap-prompt))) + (key (read-key-sequence-vector + (project--keymap-prompt project-switch-commands))) (cmd (lookup-key project-prefix-map key))) (if (and cmd (or project-switch-use-entire-map (assq cmd project-switch-commands))) (call-interactively cmd) (user-error "%s is undefined" (key-description key))))) +(defun project-other-window-command () + (interactive) + (let* ((key (read-key-sequence-vector + (project--keymap-prompt project-other-place-commands))) + (cmd (lookup-key project-prefix-map key))) + (if (and cmd (assq cmd project-other-place-commands)) + (let ((display-buffer-overriding-action + '((display-buffer-pop-up-window) + (inhibit-same-window . t)))) + (call-interactively cmd)) + (user-error "%s is undefined" (key-description key))))) + +;;;###autoload (define-key ctl-x-4-map "p" 'project-other-window-command) + (provide 'project) ;;; project.el ends here -- 2.27.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 19:47:03 2020 Received: (at 41890) by debbugs.gnu.org; 19 Jul 2020 23:47:03 +0000 Received: from localhost ([127.0.0.1]:33262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxJ1K-000567-PR for submit@debbugs.gnu.org; Sun, 19 Jul 2020 19:47:02 -0400 Received: from mail-ed1-f46.google.com ([209.85.208.46]:46721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxJ1I-00055V-5L; Sun, 19 Jul 2020 19:47:01 -0400 Received: by mail-ed1-f46.google.com with SMTP id dm19so11498722edb.13; Sun, 19 Jul 2020 16:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Z/39zvZQs9Xkx174wkHbuc/q3LQtZFMhEAKAC0sV8j4=; b=ta5k3Vf35d9xOGUeTGphyHo9a96+3ljXH5vQZ9aNfi7DJ40fRjVzzrcqYKuXdxIFeV F56h09Tv7esxCq8dfalBL9YO/2yI0KU3h1KnS189+1caR1I/lSuaVgMYYV8Gxx0JNf1x mpTo+xkxL/6RlW1mQaydIJd/S32vibZFJ9bDT9waPkvuPN3EslDC8f8Jy0cpKzL/HsRC LU+xc45hjH05NHKVd/yQdzaWqownteaty2UO3azWjVh3flhFWPJgq7WyiuJtttHcvd0G Hli6zexb37WSoBk5Cv5m4uE6C8cilY2Ekguw3jKat2AfINCvfW06My/OpskvVm+0vP+F q76A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z/39zvZQs9Xkx174wkHbuc/q3LQtZFMhEAKAC0sV8j4=; b=ZX3i6jXlhuOJQqTnrfCWvBjwQw6GoySrBLKwWwrYRH/k/inxepmRotFonmmpaWkPcW 7sr5R68ck/FD7pBfQE9pmwkKUY7T1flUQgttNYMK+NKr+h7AXK1pUZ1y84WPqACHIMaS 0Vo7O07LmSj1ikCgSdVPeoP3CTQfQF9lEQTWoM2JBtabpw1wq7aaSnMoWUOT0OMr7WV+ 5xVqhPNLW0WHoCS5sKasEkYKlOb868g2ehKoFEMs8s9VgepeJHApnlJeOhABsGp9G88n f52QgkiWv/viO2PGTr+ZDHDhiPy14fbIEzAwudPZR1MPm+e38aDdzEEkXGUeJyhaShBF pagQ== X-Gm-Message-State: AOAM530AmyVrqE+ZpZcOH4V9V8rwb9lNwIBaD9qbWLXe/JPqSqpo9DBF a7VPeC3m9N3ZUBhJJIPUHxs= X-Google-Smtp-Source: ABdhPJzQ3hSyr5hxxMBRRBEG1o6GY3uGJycPojo1+Vt8sb9jM5TDwmA61tn2FLflNkUMFHLr4ZXH+w== X-Received: by 2002:a50:ee01:: with SMTP id g1mr18534412eds.264.1595202414275; Sun, 19 Jul 2020 16:46:54 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id cq7sm14164771edb.66.2020.07.19.16.46.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2020 16:46:53 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , "Philip K." , "Basil L. Contovounesios" References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> Date: Mon, 20 Jul 2020 02:46:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87y2ngg64e.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 18.07.2020 19:06, Sean Whitton wrote: > Okay, here's a prototype. I had to rebase Philip's patch so I thought I > might as well attach my version of that too. The code LGTM, but I still wonder whether we do need the prompt in this case. The downsides are that we'll need to keep the list up-to-date, and at some point (maybe) it will grow too big to fit in the prompt. Will we need a variable project-other-place-use-entire-map too? Juri, did you have this particular approach in mind, or something different? > I have been wanting the new C-x 4 p bindings all week as C-x p f with > fido-mode has replaced a lot of my use of C-x C-f, so I hope I can > replace my use of C-x 4 f with C-x 4 p f soon:) I'm happy to hear that. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 20:39:20 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 00:39:20 +0000 Received: from localhost ([127.0.0.1]:33305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxJpv-0006OM-Sl for submit@debbugs.gnu.org; Sun, 19 Jul 2020 20:39:20 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:60207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxJpu-0006O5-7X; Sun, 19 Jul 2020 20:39:18 -0400 X-Originating-IP: 91.129.108.250 Received: from mail.gandi.net (m91-129-108-250.cust.tele2.ee [91.129.108.250]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 0E643C0002; Mon, 20 Jul 2020 00:39:08 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> Date: Mon, 20 Jul 2020 03:30:54 +0300 In-Reply-To: <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> (Dmitry Gutov's message of "Mon, 20 Jul 2020 02:46:52 +0300") Message-ID: <87wo2zjadd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Okay, here's a prototype. I had to rebase Philip's patch so I thought I >> might as well attach my version of that too. > > The code LGTM, but I still wonder whether we do need the prompt in this > case. The downsides are that we'll need to keep the list up-to-date, and > at some point (maybe) it will grow too big to fit in the prompt. Will we > need a variable project-other-place-use-entire-map too? > > Juri, did you have this particular approach in mind, or something different? Indeed, this approach. I think it's a step forward. Actually two steps forward. Both patches improve this part of project functionality greatly. Regarding project-other-place-use-entire-map, I don't know, first need to try using new commands for some time to see what's missing. Currently to open a new project in a new tab I have to type: ‘C-x t t C-x p p’ then a project dir and some key e.g. ‘v’. When Sean will turn the prototype into the final patch, then the key sequence will be much shorter: ‘C-x t p v’. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 21:04:47 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 01:04:47 +0000 Received: from localhost ([127.0.0.1]:33324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxKEZ-00070s-Ja for submit@debbugs.gnu.org; Sun, 19 Jul 2020 21:04:47 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:33043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxKEW-00070Z-LU; Sun, 19 Jul 2020 21:04:46 -0400 Received: by mail-ej1-f47.google.com with SMTP id n26so16402593ejx.0; Sun, 19 Jul 2020 18:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ClVkgfYXrBqBGpQ0nA32EFk5WGXkPGIxD1uLI22shfc=; b=Qchfo6gu158nWVjsjWNrpzroLAsHbeBtrukQNqqVNJiu0rh7giWMMhE4iNYjM5G7fg 5ZZtrh6Idirp8gv6VlHv1XazR4Tx4uaXqW13A5GpQFW3JrVplMX8qsRKASVqEp/yaYz+ 6StYkL50tsM6OkyuNsvoezzU3rqxKcGRefvX3nuPyboTJddgp6Zy6Cr8XSDyC/hp2Dhq cCNII3iylt1Z2Q+gwQX0ZMkP9CIvNITI/tk9DcaL2StBi69M9+mTsMHDWXdzztTfcc/R i+QMfyjjjVwYeU/7/Q3LW5LpS+Juks2AT4cdTESwMtvvKyFEEPNIE334pbD6emTyk9br 4d3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ClVkgfYXrBqBGpQ0nA32EFk5WGXkPGIxD1uLI22shfc=; b=NjEWypQHzTfRBdy8PgRR/0n0MICcu1WT+WLAFBqWdAMUYxw8F8VddzFrda2nfm1WR7 czcLT2JtlGt85Hm0lZrJcnx4IeQvJ0hY8WKBZbW4eZMPPpAUrBXFFGhNNjH6lwyPwoZp yJiKD2hD84+8HTrpdJO0ygfZqvCQX8eKqvsEcSt1ndiTe+H7CdycoQk3DHyIR98A8GyV fnRh2dZh+GOczqDcxZdcyFlKFAq+S4UFZ85g4Vb8hJe8jrCGNWMgcLATJcODs8l/U4WT 7sP4YmboWViCLSjRKr0c/mXQb+3XWpKOOguST8brLAln6iKYcYH7F7+sfXed/uOFVXJB Vh+w== X-Gm-Message-State: AOAM533YjZsdWIBH5oaUnpcds1STJ/xqrU3XfLSLWYfhInqh7e+RsVGF a/OV9SdmaUfnMegxHezENfc= X-Google-Smtp-Source: ABdhPJw6WvtivUPRfzmrTi/tZDfNnt4T03bHlZkVIgk4eRowFURki+cqqzndWs6yGpwTZVcEc0NPIA== X-Received: by 2002:a17:906:4e87:: with SMTP id v7mr18368052eju.242.1595207078852; Sun, 19 Jul 2020 18:04:38 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id cb7sm13791006ejb.12.2020.07.19.18.04.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2020 18:04:38 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <87wo2zjadd.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 20 Jul 2020 04:04:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87wo2zjadd.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 20.07.2020 03:30, Juri Linkov wrote: > Indeed, this approach. I think it's a step forward. Actually two steps forward. > Both patches improve this part of project functionality greatly. > > Regarding project-other-place-use-entire-map, I don't know, first need > to try using new commands for some time to see what's missing. OK then, here's a question: Should project-other-place-commands include an entry for project-or-external-find-file? > Currently to open a new project in a new tab I have to type: > ‘C-x t t C-x p p’ then a project dir and some key e.g. ‘v’. > When Sean will turn the prototype into the final patch, > then the key sequence will be much shorter: > ‘C-x t p v’. Sounds neat. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 06:21:35 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 10:21:35 +0000 Received: from localhost ([127.0.0.1]:33931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxSvP-0004Jr-4G for submit@debbugs.gnu.org; Mon, 20 Jul 2020 06:21:35 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxSvL-0004JW-U6 for 41890@debbugs.gnu.org; Mon, 20 Jul 2020 06:21:33 -0400 Received: by mail-wr1-f41.google.com with SMTP id z2so17302828wrp.2 for <41890@debbugs.gnu.org>; Mon, 20 Jul 2020 03:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7vquCWRl+rwWff6GIy8ltCV6GrS/j1qrcu0mk0QXkIs=; b=UTuA8ualP8njPvzS/XkbX5dRs3IedRxkskjlM0xhu9iuGyu4373nlUP+Nl1wL+okul xxi0QNaR0HoSyJBmSd1H5Ktr0uaBZAH/9Tvw4CsiqZ/DqyTb3shpReNxX4KPuvTKNtEr BlNp2CehXj9oX0JVT+DpsvvFhOO/ev6aUtuk/h03iZJTINDRx5ZtDe7JJH1iBrjMJ/Vc Zmcs3tpq8QvkHFQqxSBxukox75uIa8j3lllhwl/6HmPVwBye8IUTOWz+hJg0mS+0M0jI rH6I64PTGKsS+/Pk3VzKiwF8OOHqIxmm+mhYaUEch4q2FPruETRT+XcwubiLJq/k8Iho 4qbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7vquCWRl+rwWff6GIy8ltCV6GrS/j1qrcu0mk0QXkIs=; b=VVQhbht73/NV4V6gWHekBIkV5SIa8NahRUuFdZZv73a1aqj5ZnKOyH2HCcbykwerMI LfY4bBs4hm1K3oXMYK6iMD85BhWJTSr3Jbx2uemK2mKrzw8wPbxCpjQKyKYsqdnszG/O vtY2a1euc+Ww4Kq/0wG34Iue7Ahi1dNNU2xTZvJbZtZzNsMCiZNmVGwUJyNk4RQ6MkL5 5B7Y2KJEUomqD5VFBq/2YrfhwROuhDF8dLNn0FVxaLT3KdVPinE5l1yTynFuSEmQNEoB lt6u7kdl3G9rSacST93ummhd0ulwrEsCkifnl/5EivXbf4Ycjmy5Ec/+64tBqBk5PN4F AtTw== X-Gm-Message-State: AOAM533A+RDAS2EoFbeMgWgd3sojOJC8/eNzdDXLCw7M74L62yGXql7/ Q/gm3SzSTJl2p5S8CxemMwapvQ== X-Google-Smtp-Source: ABdhPJxTHtRMafeDX3+aDvXuHa/v2aLtD3hkoL13OKEP4HSI8SLtL3bK4eGbiWAqqhtjhFUC/xUCNw== X-Received: by 2002:adf:f74f:: with SMTP id z15mr20302914wrp.233.1595240485978; Mon, 20 Jul 2020 03:21:25 -0700 (PDT) Received: from localhost ([80.233.38.38]) by smtp.gmail.com with ESMTPSA id c7sm33132608wrq.58.2020.07.20.03.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 03:21:24 -0700 (PDT) From: "Basil L. Contovounesios" To: Sean Whitton Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> Date: Mon, 20 Jul 2020 13:21:22 +0300 In-Reply-To: <87y2ngg64e.fsf@iris.silentflame.com> (Sean Whitton's message of "Sat, 18 Jul 2020 09:06:25 -0700") Message-ID: <878sfe5vx9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, juri@linkov.net, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > +(defcustom project-switch-use-entire-map t > + "Make `project-switch-project' use entire `project-prefix-map'. > +If nil, `project-switch-project' will only recognize commands > +listed in `project-switch-commands', and signal an error when > +others are invoked. Otherwise, all keys in > +`project-switch-commands', are legal even if they aren't listed ^^^ superfluous comma > +in the minibuffer." > + :type 'bool ^^^ ean > + :version "28.1") [...] > +;; "other-place" because non-prototype patch will also add an entry > +;; in ctl-x-5-map and under C-x t p > +(defcustom project-other-place-commands > + '((project-find-file . "Find file") > + (project-switch-to-buffer . "Switch to buffer") > + (project-dired . "Dired") > + ;; Eshell uses the current window by default, but Shell defaults > + ;; to using the other window. If a user has added an entry to > + ;; `display-buffer-alist' for Shell, they probably want to add an > + ;; entry here, too ^^ missing full stop > + (project-eshell . "Eshell") > + (project-switch-project . "Switch project")) > + "Alist mapping commands to descriptions. > +Used by `project-other-window-command' to construct a dispatch menu of > +commands available to be displayed in another window. > + > +Commands in this list should be ones which normally display their > +buffer in the current window. > + > Each element looks like (COMMAND LABEL), where COMMAND should be > bound in `project-prefix-map'. LABEL is used to distinguish the > choice in the dispatch menu." Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 10:45:38 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 14:45:38 +0000 Received: from localhost ([127.0.0.1]:35818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxX2w-0000xY-1g for submit@debbugs.gnu.org; Mon, 20 Jul 2020 10:45:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxX2p-0000x6-2C; Mon, 20 Jul 2020 10:45:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35822) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxX2h-0006xn-WE; Mon, 20 Jul 2020 10:45:24 -0400 Received: from [176.228.60.248] (port=1650 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxX2h-0003D5-1Z; Mon, 20 Jul 2020 10:45:23 -0400 Date: Mon, 20 Jul 2020 17:45:17 +0300 Message-Id: <83mu3ugs8y.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <878sfe5vx9.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <878sfe5vx9.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, philip@warpmail.net, dgutov@yandex.ru, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Date: Mon, 20 Jul 2020 13:21:22 +0300 > Cc: "Philip K." , 41890@debbugs.gnu.org, > 42210@debbugs.gnu.org, Dmitry Gutov , juri@linkov.net > > Sean Whitton writes: > > > +(defcustom project-switch-use-entire-map t > > + "Make `project-switch-project' use entire `project-prefix-map'. > > +If nil, `project-switch-project' will only recognize commands > > +listed in `project-switch-commands', and signal an error when > > +others are invoked. Otherwise, all keys in > > +`project-switch-commands', are legal even if they aren't listed > ^^^ > superfluous comma Also, GNU standards frown on using "legal" when you actually mean "valid". "Legal" and "illegal" should be reserved to describing issues pertaining to laws and breaking the laws. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 12:49:12 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 16:49:12 +0000 Received: from localhost ([127.0.0.1]:35945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxYyW-00043c-3u for submit@debbugs.gnu.org; Mon, 20 Jul 2020 12:49:12 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxYyT-00043J-IB; Mon, 20 Jul 2020 12:49:11 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51FDD5C01E6; Mon, 20 Jul 2020 12:49:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 20 Jul 2020 12:49:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=9Erm/FBl892fGlnnW3a9S+dgUt caHcKtzCXDfoGXOa4=; b=d6kAPWu5n9PZxqVfHoQgrJ4W5GA+Kx0BhBqR1DRWlI egDvy3zqQ6BJrmCTpkd/fXe9nTNW427xbGasqxii3Pg75BfalDgHONQ2oyX2d6t1 ocfaAz901OmoECM6h6j3liOMKtiMkSYjUX3kPNQrU/QvzJgodrqhwK3uErLGDdUT QrEN5oK9RBP9i/oGfvj8UCJF6bFjFOZqMG8tce+PDqLU4rbKFD0BLGSQXVobCk3O q/rEB77btLRlwy0/9u/I5x91g8um+vyPP9A3vh4uX9HI6G4Oe45mf+12rznhQIXr mLzU5gN3GvqewvB4N/N2cwVncZQ93mAAX5UmazmzoBgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=9Erm/F Bl892fGlnnW3a9S+dgUtcaHcKtzCXDfoGXOa4=; b=qLgZau78h9GivcViK6Zyyk f6ibcU/ejwkxoTG///dJV0YOrFwlxGH+IrBeyaox33ofNnbw9OqYU2H9+0O/uB9/ E4IRWXNb/l1IqFSKpOgHVJeBWF0s7oaUTRBGhYG8KVTPe8kIrVJj2XAvLa9YeEjY m4OADspKFKRUmCLSgziZRHwhe3dzdR0zNQE/y6/DcOrOpgOprGuNMxSPIPte4wcF ae0aUmWD9jA/0nWNMotBy4gLFY96lk5nRV4d7X3+9RC/OR/C0KWluxKzeoZc+7b1 99t2uuIioHQqqRLABFI0XDg9ZNlHaiJjWpCQou3CEk4erS0OUCmQDNAJjClCpnog == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeeggdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , "Philip K." , "Basil L. Contovounesios" Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> Date: Mon, 20 Jul 2020 09:49:02 -0700 Message-ID: <871rl6gmip.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Mon 20 Jul 2020 at 02:46AM +03, Dmitry Gutov wrote: > On 18.07.2020 19:06, Sean Whitton wrote: >> Okay, here's a prototype. I had to rebase Philip's patch so I thought I >> might as well attach my version of that too. > > The code LGTM, but I still wonder whether we do need the prompt in this > case. The downsides are that we'll need to keep the list up-to-date, and > at some point (maybe) it will grow too big to fit in the prompt. Will we > need a variable project-other-place-use-entire-map too? If all one has in mind is C-x 4, then it doesn't seem like this is a big danger -- many commands display in the other window by default, such as project-find-regexp, and it reasonable to guess that a good proportion of new commands which get added will also be like this. However, if you have C-x 5 and C-x t in mind as well, then it starts to seem like we'll want project-other-place-use-entire-map. How about having a project-other-window-commands defcustom for C-x 4 p, and using the entirety of project-prefix-map for C-x 5 p and C-x t t? C-x 4 p can prompt as per my patch, and C-x 5 p and C-x t t could just put a static message in the minibuffer like other-frame-prefix and other-tab-prefix do at present. >> I have been wanting the new C-x 4 p bindings all week as C-x p f with >> fido-mode has replaced a lot of my use of C-x C-f, so I hope I can >> replace my use of C-x 4 f with C-x 4 p f soon:) > > I'm happy to hear that. I intended to say a bit more: C-x p f has replaced a lot of my use of C-x b too. It is very nice not to have to guess whether something is already visited and just complete across all the project's files. I use C-x 4 b a lot so I'm looking forward to C-x 4 p f. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 16:56:14 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 20:56:14 +0000 Received: from localhost ([127.0.0.1]:36381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcpa-00040U-GN for submit@debbugs.gnu.org; Mon, 20 Jul 2020 16:56:14 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcpX-0003zt-Ky; Mon, 20 Jul 2020 16:56:12 -0400 X-Originating-IP: 91.129.108.250 Received: from mail.gandi.net (m91-129-108-250.cust.tele2.ee [91.129.108.250]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4FBAC60005; Mon, 20 Jul 2020 20:56:01 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> Date: Mon, 20 Jul 2020 23:41:54 +0300 In-Reply-To: <871rl6gmip.fsf@iris.silentflame.com> (Sean Whitton's message of "Mon, 20 Jul 2020 09:49:02 -0700") Message-ID: <87365mdj2d.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > How about having a project-other-window-commands defcustom for C-x 4 p, > and using the entirety of project-prefix-map for C-x 5 p and C-x t t? > C-x 4 p can prompt as per my patch, and C-x 5 p and C-x t t could just > put a static message in the minibuffer like other-frame-prefix and > other-tab-prefix do at present. Currently there are separate key sequences ‘C-x p’ and ‘C-x p p’ followed by almost the same list of possibles suffixes, where e.g. ‘C-x p f’ visits a file of the current project, whereas ‘C-x p p f’ prompts for another project and visits its file. Should the same distinction be preserved in other-place commands? Then ‘C-x 4 p f’ will visit a file of the current project in another window, whereas ‘C-x 4 p p f’ will prompt for another project and visit its file in another window. The same distinction could apply also to ‘C-x 5 p f’ / ‘C-x 5 p p f’ and ‘C-x t p f’ / ‘C-x t p p f’. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 16:56:19 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 20:56:19 +0000 Received: from localhost ([127.0.0.1]:36386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcpf-000411-1S for submit@debbugs.gnu.org; Mon, 20 Jul 2020 16:56:19 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:48203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcpb-00040B-HO; Mon, 20 Jul 2020 16:56:16 -0400 Received: from mail.gandi.net (m91-129-108-250.cust.tele2.ee [91.129.108.250]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id C5982240004; Mon, 20 Jul 2020 20:56:06 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <87wo2zjadd.fsf@mail.linkov.net> Date: Mon, 20 Jul 2020 23:47:22 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 20 Jul 2020 04:04:36 +0300") Message-ID: <87blk9dit9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > OK then, here's a question: > > Should project-other-place-commands include an entry for > project-or-external-find-file? I don't see why someone might want to use such commands as project-or-external-find-file or project-or-external-find-regexp. These commands operate on some obscure directories (copied from the output of '(project-external-roots (project-current t))'): "/usr/local/share/emacs/site-lisp/" "/usr/share/emacs/site-lisp/autoconf/" "/usr/share/emacs/site-lisp/gtk-doc-tools/" ... I don't know why the user might want to find files or search in such non-project directories as /usr/share/emacs/site-lisp/gtk-doc-tools/. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 17:01:04 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 21:01:05 +0000 Received: from localhost ([127.0.0.1]:36447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcuG-0004By-Li for submit@debbugs.gnu.org; Mon, 20 Jul 2020 17:01:04 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:44685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcuE-0004BF-3A; Mon, 20 Jul 2020 17:01:02 -0400 Received: by mail-ej1-f53.google.com with SMTP id ga4so19470395ejb.11; Mon, 20 Jul 2020 14:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qbq9UzwspDD8P42I1ZVxpJtvB6Z7Q+ikB03SWgf0wTY=; b=BhpbHC+DWNGZyN6AWckQj2IK3MmHpAQRcqhA2d0EGa66tQdoJKBtMInrCPvRizJJjV P1PM2IIVx32Zd6tVgQice/WEOZzd4KCLubVxc71ppEwYxVyN3KkAg7BxnEjgbggiUBxC e7PW3kgbbbOB3KXWxE7jQczAcAl2Bjekw7u1/yydiss0FmKEYMjpXbsNL1ZuOmkzX163 PzcmMJAv5P7qTv1Qk4IuE1ZLQ2SJPjR0iOL6YZY+2K3gBpe3NCN0NkmELyXc7Yr8n8Bx 4CYVKgKr3/uv/1mcgYwO3A0GJyaQJvDT8Tf6qPE7PSMFcD82zXYCTOgaWejdTsl3VhvD yK/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qbq9UzwspDD8P42I1ZVxpJtvB6Z7Q+ikB03SWgf0wTY=; b=cfi/Pmm8rL3eolQUoQmlaj0GJL6EGYTsFWFj/XEG7WqVla4gMPDkqvgdFaACXSHjyp 1KgE76Hb0r/Y6QvRtD8uF06n47HhOzCtCtvJT3ECIoCdBqKv+inH7p9cCjPSJdm3Y3Lh FnFti/+V4jarskP6Bhto4NMKo/25WCclOdX574dKuXKgn1F0edkKMcwrR7ZUf85rPaHe nWNV0UJwYvi/G9WCSR1jEQtPoqLPpObKITRF1pLSWw8pwKLAUYsacgGDuirst/H5mmQe D/uwOBEVYilxGdPPzkRfucLocxrGQxD3xdjTUAl2nPHdtvWxInuxjr2bFwhTEbPSOnSt efeQ== X-Gm-Message-State: AOAM532rVnShbK65s9CzL4E+6DPsYV1irrlzjDQbBcMm2vOLAubjZl6z uQEvgw2Wz9qPqVMEOPb3fpU= X-Google-Smtp-Source: ABdhPJz+R10G1nAl+DuXk1CHb3Evtv3v/bIWGjN5Wwz3x9anr+Kq+8roSKlNFZOFqkldYBZRbtiwdQ== X-Received: by 2002:a17:906:35cd:: with SMTP id p13mr22203188ejb.172.1595278856226; Mon, 20 Jul 2020 14:00:56 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id t20sm15270408ejd.124.2020.07.20.14.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 14:00:55 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <87wo2zjadd.fsf@mail.linkov.net> <87blk9dit9.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Tue, 21 Jul 2020 00:00:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87blk9dit9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 20.07.2020 23:47, Juri Linkov wrote: > I don't know why the user might want to find files or search in such > non-project directories as/usr/share/emacs/site-lisp/gtk-doc-tools/ Apparently these directories are in your load-path. I think it makes sense to search for files across your load path sometimes. Or if you have multiple tag files loaded, it would search across directories containing those files. And that's just with the built-in backend. Other projects can have other examples of what constitutes external roots. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 17:03:07 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 21:03:07 +0000 Received: from localhost ([127.0.0.1]:36454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcwF-0004FK-9V for submit@debbugs.gnu.org; Mon, 20 Jul 2020 17:03:07 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:35801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcwD-0004Ek-EJ; Mon, 20 Jul 2020 17:03:05 -0400 Received: by mail-ej1-f53.google.com with SMTP id rk21so19515173ejb.2; Mon, 20 Jul 2020 14:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ItkclD6NDoRX7HmYNL1s3+9anLTqMgM0/gXMdvLLlvw=; b=k5oeE7jUp8EXNu/jgvK3NIM9oVYu5Tk/KWgrG+FTmFtODh3Tq6C0v0e6WGuR38ZHUC b2yKx2YIkZqMscrpiM6KqYxbEbgVN0G1XYmNKEs6OXMNSyqpMzXURlHy7ouW+2ncBky+ V8G42uTK4N8eyyirm5sIZ+qHrv9Q4KhaC/ClIqpB+JzQG3dRTOA7A+f04Cedzd0ZajX8 BNJfLyCqtPd7rY0vWlOVnpEykkyipXTVyh4FSPiLE1m+eVTLciakUMth0PS/quQLcA4p F8N3lMfuKCCBvnKSUjrnnvOaEY90qrOiICCC+o9cEnxqj+hh5jQi2Sw2zTCEgfVMqd+o 3MiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ItkclD6NDoRX7HmYNL1s3+9anLTqMgM0/gXMdvLLlvw=; b=jN3DPYp/32LQU06YlfN3XoAmFhixkCuERsquGEfKP6tGCylHwY9d7hQwuMjfvxCBy7 jUmCLF53Gl27wE7eDnf5bG0jHVXC+5AeT5PeumQ1I5MnihKyHjoMi5Z0IudZANvsRRfF y1TwyE3ejHAXGUSKjMTS7fafsYLgqIIonQ1e7WhKfEqC8xslUFMFIBBXwx2Y36Mxs64Y FZyDU90g4xuY68cK+xx126RF+hmArVo/AxW5S4NMrB75Cys8NYZR4AjaBFXsx7FMo5ak vfDXGyYlKlcU6kx8JYNlSZom8grTzD0wlLERJY9mQBdf9CYeNUYn8mF4kon5Kqi5fe7Z S78g== X-Gm-Message-State: AOAM531PMeO+uCv4fr2UycFWFlwLtatTox8MHK5cZKcbtGQABl1DcAbS eOg/jJaZDavy9m9vnZ4/AOEFcK/3 X-Google-Smtp-Source: ABdhPJzehray/Uz79mLX3hZynndohz1LAMCMAzKrBZJoMTQD88TQRgkBIJjdXM3wxupcsZqalnIFeQ== X-Received: by 2002:a17:906:6847:: with SMTP id a7mr21911798ejs.306.1595278979561; Mon, 20 Jul 2020 14:02:59 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 23sm16239254edw.63.2020.07.20.14.02.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 14:02:58 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov , Sean Whitton References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <87365mdj2d.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <79669bad-5c46-239b-b72d-c37f68acd77b@yandex.ru> Date: Tue, 21 Jul 2020 00:02:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87365mdj2d.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 20.07.2020 23:41, Juri Linkov wrote: > Should the same distinction be preserved in other-place commands? > Then ‘C-x 4 p f’ will visit a file of the current project in another > window, whereas ‘C-x 4 p p f’ will prompt for another project and visit > its file in another window. Sure. Doesn't this work with the latest proposed patch? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 17:24:52 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 21:24:52 +0000 Received: from localhost ([127.0.0.1]:36525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxdHH-0004oI-Sb for submit@debbugs.gnu.org; Mon, 20 Jul 2020 17:24:52 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxdHF-0004nr-US; Mon, 20 Jul 2020 17:24:50 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9FDA65C0124; Mon, 20 Jul 2020 17:24:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 20 Jul 2020 17:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=fm3; bh= qNROtPs/ols/aZ3vSNQQXivI+GvveI0zcGnzpJsVF+M=; b=MmKM9tow3zQpZeRJ ByQ1plqFcRnwDallIZIubDUQesPsRrYm1Dt9NVbL3f3Hylj0BZQBjjZI4VBR9bkR tL7YOGsVGLSfbp2cvfUfq8/e/AshQrDbAVaJfrUta0w0Xrm+e11Y/6VKLInEfV3V m2D2fh9x55Aazjs7SpdjY8VFt3XpLvM058WP4ME7ZBIZByvAr5+rib17trmooOjn E4X6Cda84devO3odoJXwS2HNMDJsMiXcFRddGPlpq+XXivSVGrQf2sYz3pQVdRBX YFgxTfqWsDz8njDbFHuByvgcbNBRrZt4+eiKUmgBMva4OyIGTwiWLA16Qb7cyLbz KPor5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=qNROtPs/ols/aZ3vSNQQXivI+GvveI0zcGnzpJsVF +M=; b=BiFCaMtsX/9J7T10I6oEStQvcUP52bQXV5HddHbTsoyaD8DGThpIAJl/k SDKJ++UP5qrOOWg2o2tmHKCPmQ+LhT7KVQ85kbDJhbdZW9vzT6oVvXBjFD8zWOPa m190ZTQ+ePIlRE7Mui5sZ0Uac+LjSHzqPAahUZ0Yh6/gkEhAIJxv+cmGzjNw9Yc+ IAv8sM7AqQKsyEUWVYyIi4nA3Yp6V8wfaixo7D9jNzLYp7+cFV7VB8XaP3CkrDy6 xSqzej1JjCPqTCdr0+yj9uRKqpBO8M8DX2OWJMJ4luttEZ+h7xjgMtEEPKU+kIH9 ZvBPRbxKmQQpbdAJF3n0V0cGyH2RQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeeggddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgfgsehtqhertddttdejnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepvdfgkeevtdetvedvhffhgeevleelfeekveeuveehffduvdei udfhgeelvefghfehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Juri Linkov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87365mdj2d.fsf@mail.linkov.net> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <87365mdj2d.fsf@mail.linkov.net> Date: Mon, 20 Jul 2020 14:24:42 -0700 Message-ID: <87ft9ldgmd.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Juri, On Mon 20 Jul 2020 at 11:41PM +03, Juri Linkov wrote: >> How about having a project-other-window-commands defcustom for C-x 4 p, >> and using the entirety of project-prefix-map for C-x 5 p and C-x t t? >> C-x 4 p can prompt as per my patch, and C-x 5 p and C-x t t could just >> put a static message in the minibuffer like other-frame-prefix and >> other-tab-prefix do at present. > > Currently there are separate key sequences =E2=80=98C-x p=E2=80=99 and = =E2=80=98C-x p p=E2=80=99 > followed by almost the same list of possibles suffixes, where e.g. > =E2=80=98C-x p f=E2=80=99 visits a file of the current project, whereas = =E2=80=98C-x p p f=E2=80=99 > prompts for another project and visits its file. > > Should the same distinction be preserved in other-place commands? > Then =E2=80=98C-x 4 p f=E2=80=99 will visit a file of the current project= in another > window, whereas =E2=80=98C-x 4 p p f=E2=80=99 will prompt for another pro= ject and visit > its file in another window. The same distinction could apply also to > =E2=80=98C-x 5 p f=E2=80=99 / =E2=80=98C-x 5 p p f=E2=80=99 and =E2=80=98= C-x t p f=E2=80=99 / =E2=80=98C-x t p p f=E2=80=99. Yes, I think so, but I'm not sure how that directly addresses the suggestion of mine you quote. --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 18:00:17 2020 Received: (at 41890) by debbugs.gnu.org; 20 Jul 2020 22:00:17 +0000 Received: from localhost ([127.0.0.1]:36582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxdpY-0005yV-L7 for submit@debbugs.gnu.org; Mon, 20 Jul 2020 18:00:16 -0400 Received: from mail-ej1-f44.google.com ([209.85.218.44]:46121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxdpT-0005ml-Lm; Mon, 20 Jul 2020 18:00:14 -0400 Received: by mail-ej1-f44.google.com with SMTP id l4so3383010ejd.13; Mon, 20 Jul 2020 15:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ajKd2N0/O9efJKjxCWOdNbzCtbWXb2i5VpFoWSanIlk=; b=LwiZuXS1Usi9a8el9iFR2RdheN3u2efqgqCR5KeJZ1yHX9eRG549LbYuqvM5nEIpS4 sqjLHSbPff0dnrjpONxL3cA+j2HwoA/tmpnc2tMIyk1uCxoLupeFheWdyFwX6LOmB51k hI20zXeYwgfIDdVd2dnKTQpS9fd8yJO44eCcnZ1jkmC+Aw+V1NYAeBEHAJbhJDEmtaOC JVpsR2tMveiUBcU1KcVGQXwHx8nJ+dND7itzWswsbQtJUOIW1D6G0OlxAuNLajJr4Sto qlVcT5gBBAuTYqTaHlakH8e9v6sA2ffGouPpl2DCy7CQ728PDI38uRW+UZXoJ2ObdbEJ CwQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ajKd2N0/O9efJKjxCWOdNbzCtbWXb2i5VpFoWSanIlk=; b=ONxqsX9ARWKUFZqGu5rqEMEY/PSgBp785xaDD5Z6Jf3WDcpCCuSvG29WH8HDPZ5RSX KcfltzebSZmaJ8IBgD/1ggK3ZPyu9JLsHFjp/YROAAoESQC4c90X+K/mCPSA6o1Trq7T Ty7g35/u7C8QoQdkJeObnKhJ6mc3SfSigSQGw4UrTXItDNx3KC8nd2eSoJ7GAEo09BPx rXyjWCjbcahQFb1PS6lMWqcvLm93ZpGUm0JQ9bEXBaTIVVoFvo9/cod0LPvcKUZ+CNPH hc4LQ8KO7hvltKzYI4MH52V17zoxapYtI6F4/S/K+GnOBSLmcaHqt/Mz0LZX9rQAPsat uWMg== X-Gm-Message-State: AOAM531XnVRLj3Bxq8caYYyWHiTu+Gdz4cyImOnh3Ra/eDpVwg39Y31b VoqRn6PKqQngTLuJKZXDLUw= X-Google-Smtp-Source: ABdhPJylD4RQwGAqEDzT4BFz1P7LWbh00xeYdHXE/8dNqXUXNHA9DFEmEIwGUTMEMU1Ru0XFtlnHDw== X-Received: by 2002:a17:906:140e:: with SMTP id p14mr22885042ejc.430.1595282405628; Mon, 20 Jul 2020 15:00:05 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id ce15sm15531692ejc.86.2020.07.20.15.00.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 15:00:04 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , "Philip K." , "Basil L. Contovounesios" References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: Date: Tue, 21 Jul 2020 01:00:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <871rl6gmip.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 20.07.2020 19:49, Sean Whitton wrote: > How about having a project-other-window-commands defcustom for C-x 4 p, > and using the entirety of project-prefix-map for C-x 5 p and C-x t t? > C-x 4 p can prompt as per my patch, and C-x 5 p and C-x t t could just > put a static message in the minibuffer like other-frame-prefix and > other-tab-prefix do at present. Just to clarify: are you proposing this because you really like how the prompt works, yet can't find a good way to incorporate it for the two other prefixes? > I intended to say a bit more: C-x p f has replaced a lot of my use of > C-x b too. It is very nice not to have to guess whether something is > already visited and just complete across all the project's files. I use > C-x 4 b a lot so I'm looking forward to C-x 4 p f. Right! That mirrors my experience: it's often handy to just search across the project files because you're guaranteed to find the needed file, and because there is no ambiguity caused by having only the base name available. One can also "guess" the eventual file name based on the partial matches in its name and in its parent directories' names. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 20:33:17 2020 Received: (at 41890) by debbugs.gnu.org; 21 Jul 2020 00:33:17 +0000 Received: from localhost ([127.0.0.1]:36837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxgDd-0003E7-DT for submit@debbugs.gnu.org; Mon, 20 Jul 2020 20:33:17 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:47281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxgDY-0003Dg-K5; Mon, 20 Jul 2020 20:33:16 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 985F75C0113; Mon, 20 Jul 2020 20:33:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 20 Jul 2020 20:33:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=4H8B4G2BKZN+kJz8te0pBEDSsK Z0/g2Qu3BRJbAWANk=; b=KnPJhbAvBcZ8wS/9NE1vXS0W8II6DLJP1B9Kg2Sf83 JCd0EAmRE/8n3peljw4aNWltvOQ5gGZQl/fcbKUypt61Agjza4/U8hl/lLT1/BfM t8H1wpOAfWfUUaYO7AsJ0J0zPzQAMXsxTUQVP3NaO4cjRctDTdYHs1CiRKuK7kGR cEuaQHZpIbsE7vV04HotZNiFylkLlI/ETy1yqoWkKjo9pK/j+N5+G0vqv/wZw/o6 eXWZTQ+4xNWvDZg1w5GYRCjKTJPFCWSRP2nyJ+Pi7TeZIVD3rvXxElqA/MTYYg+y OkGGOX6vQwCKu/OyLGYBIbMDwTpmTqGUVao/MlK7sPPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=4H8B4G 2BKZN+kJz8te0pBEDSsKZ0/g2Qu3BRJbAWANk=; b=lgCOV8yGOOqRCjDjP5ESV/ UKcFSWe5KrOpzlXt8XIddJDJq75yywv3Ykm9YYAvS0jA8ntL2BBQXGf5oOLiS/pj RfN+musKAHXoIVZh9hSGc7mjMVjS2VHAootOh0JRHBM/1pzjzmChKzjAdDhpcuRd QlRms5/KS3QeK64L9Jc9x/qlFe5qGFPm8oExvNFXtFIGZ5XZYo5pWTHaOvQtfhDv LySY0lmGlZjuzNetMlnhbThnuFlGkJVsOHPPsSkoGUzBJXytOc+ifttwJT9yRfs9 LMZ0zBkkvP5PFMVg7b2xhGWeoCryXXngC4g4GeUItoOei7inDDrOqXS+zA+w3/9Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeehgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , "Philip K." , "Basil L. Contovounesios" Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> Date: Mon, 20 Jul 2020 17:33:04 -0700 Message-ID: <874kq1d7wf.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 21 Jul 2020 at 01:00AM +03, Dmitry Gutov wrote: > On 20.07.2020 19:49, Sean Whitton wrote: > >> How about having a project-other-window-commands defcustom for C-x 4 p, >> and using the entirety of project-prefix-map for C-x 5 p and C-x t t? >> C-x 4 p can prompt as per my patch, and C-x 5 p and C-x t t could just >> put a static message in the minibuffer like other-frame-prefix and >> other-tab-prefix do at present. > > Just to clarify: are you proposing this because you really like how the > prompt works, yet can't find a good way to incorporate it for the two > other prefixes? I wouldn't say that I really like the prompt, but it could be useful to someone to see the bindings available to them, when we're sure it's going to fit. I do think we should avoid binding commands under C-x 4 where the versions under C-x p would already display in another window -- I think it is potentially quite confusing to have bindings with identical behaviour under both C-x 4 p and C-x p. But that means we need the defcustom, because a user could use display-buffer-alist to change which commands under C-x p will use another window. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 21 19:40:36 2020 Received: (at 41890) by debbugs.gnu.org; 21 Jul 2020 23:40:36 +0000 Received: from localhost ([127.0.0.1]:40666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy1sC-0004sx-Im for submit@debbugs.gnu.org; Tue, 21 Jul 2020 19:40:36 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy1s9-0004sc-7Y; Tue, 21 Jul 2020 19:40:35 -0400 X-Originating-IP: 91.129.108.250 Received: from mail.gandi.net (m91-129-108-250.cust.tele2.ee [91.129.108.250]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3ABB0C0002; Tue, 21 Jul 2020 23:40:23 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> Date: Wed, 22 Jul 2020 02:38:52 +0300 In-Reply-To: <874kq1d7wf.fsf@iris.silentflame.com> (Sean Whitton's message of "Mon, 20 Jul 2020 17:33:04 -0700") Message-ID: <87zh7s8mlv.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> How about having a project-other-window-commands defcustom for C-x 4 p, >>> and using the entirety of project-prefix-map for C-x 5 p and C-x t t? >>> C-x 4 p can prompt as per my patch, and C-x 5 p and C-x t t could just >>> put a static message in the minibuffer like other-frame-prefix and >>> other-tab-prefix do at present. >> >> Just to clarify: are you proposing this because you really like how the >> prompt works, yet can't find a good way to incorporate it for the two >> other prefixes? > > I wouldn't say that I really like the prompt, but it could be useful to > someone to see the bindings available to them, when we're sure it's > going to fit. While the prompt is active, the key '?' and 'C-h' could (and I think should) display a list of *ALL* available key bindings from the project keymap in the *Help* buffer (like e.g. 'query-replace' does after typing 'C-h'). > I do think we should avoid binding commands under C-x 4 where the > versions under C-x p would already display in another window -- I think > it is potentially quite confusing to have bindings with identical > behaviour under both C-x 4 p and C-x p. Shouldn't some key sequence force displaying the project buffer in the same window (when a version under C-x p displays it in another window)? > But that means we need the defcustom, because a user could use > display-buffer-alist to change which commands under C-x p will use > another window. I now understand that your top message above implies that a user could customize display-buffer-alist to display a buffer in another window, but usually users don't customize display-buffer-alist to display a buffer in another frame/tab? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 21 20:38:37 2020 Received: (at 41890) by debbugs.gnu.org; 22 Jul 2020 00:38:38 +0000 Received: from localhost ([127.0.0.1]:40757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy2mL-0006SV-Hm for submit@debbugs.gnu.org; Tue, 21 Jul 2020 20:38:37 -0400 Received: from mail-ej1-f51.google.com ([209.85.218.51]:38077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy2mI-0006S6-4P; Tue, 21 Jul 2020 20:38:36 -0400 Received: by mail-ej1-f51.google.com with SMTP id br7so360383ejb.5; Tue, 21 Jul 2020 17:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=joGSbz88cFMAFeu+VCIRo4GF0ozbNIJ5rrsNp5gExpw=; b=tUoq2m3VAk9heVPh6+T8jTvjaaJGFTW+2nber9AHsU6Q57gOXVbEnMFgC8iRlGCvpp ll4lq9BfbnfblUmTdNTNbAy9Z6EMzeAfbuj39E6fYvsRIDlcNWqmRx8sHwMQooIj+9Q2 mRHq0RMls7/yptoBHj98b13/9bHEkI5BkAioGDeXVg3p29mYUU0xDTDy5diyRruvUYyV Uk55LH20/Zed6YxxX4VZLTV3ycuHNu9p6rwoeynpeTaPtHB8JWHrtfYG01j/L2QSn1EO 8kTCxLp8aFPJQuXggVC+T/MiPMZ8pUKoMNcDFm1A0VCjykoIrhdTPjOhAyu3dKk3hANt w4OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=joGSbz88cFMAFeu+VCIRo4GF0ozbNIJ5rrsNp5gExpw=; b=ZAunGLho+V3ux8cwBNjBo7Jxdf5Mrm9Dd1BEAzrFhEdikcZZz04Fns5FEmYjop6Jop EN18/woeNFs9C3fcMmbwjhkd86B4JluP8nfuIR9CJ8kG+n8Peqesa7wmB2m2Ay0FcH6u Egrw8n4FHJx2EGsvjocFgbwrnrBPDtbhUTCjT/bie4ARv8IEmLQHby2H9kmT8DnvUAH9 ebtdw2DF/5lzvanPeULzRTTdfXH9zG38XrQ5qsgebnoL31UuOOugPmbnotBgDdFD8FmZ w8iOOJ9rQ9KgvNUYIHGl55FrtPKGKqU99Tm0bFKY1M07qe1W/AhmaO3YEHvQVxuOlSCl 4GCw== X-Gm-Message-State: AOAM533zlOUVzlznKbj+PaErHleQvkLnFKhY+C+XCaIRERnnR7kUe7ve Y1Dr7Rs4JEZANDjQB1Ojz7EQyfmV X-Google-Smtp-Source: ABdhPJwmavh3srBctDWofTxEXykjLLr2OA5+Fmj4Qh5haQgTC9N7m4zEVQC1Lcu1ocXJEdsIu5eNfA== X-Received: by 2002:a17:906:248a:: with SMTP id e10mr25859182ejb.454.1595378307949; Tue, 21 Jul 2020 17:38:27 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u60sm18626001edc.59.2020.07.21.17.38.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2020 17:38:26 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Juri Linkov , Sean Whitton References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Wed, 22 Jul 2020 03:38:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87zh7s8mlv.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22.07.2020 02:38, Juri Linkov wrote: >>> Just to clarify: are you proposing this because you really like how the >>> prompt works, yet can't find a good way to incorporate it for the two >>> other prefixes? >> >> I wouldn't say that I really like the prompt, but it could be useful to >> someone to see the bindings available to them, when we're sure it's >> going to fit. That's a valid benefit. There is also a package called 'which-key', but I think it's incompatible with the implementation strategy here. > While the prompt is active, the key '?' and 'C-h' could (and I think should) > display a list of *ALL* available key bindings from the project keymap > in the *Help* buffer (like e.g. 'query-replace' does after typing 'C-h'). If we're using the prompt, it shows all allowed bindings already. > Shouldn't some key sequence force displaying the project buffer in the > same window (when a version under C-x p displays it in another window)? At the moment, there's none. >> But that means we need the defcustom, because a user could use >> display-buffer-alist to change which commands under C-x p will use >> another window. > > I now understand that your top message above implies that a user > could customize display-buffer-alist to display a buffer in another window, > but usually users don't customize display-buffer-alist to display a buffer > in another frame/tab? Either way, I think the concern that someone could type 'C-x p 4 g' and see that the search results are *still* displayed in another window (gasp), is not too significant. Like, there's no other behavior that should result from key sequence, and if someone wanted to make doubly sure the resulting buffer will be displayed in the other window, why not let them. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 21 21:31:41 2020 Received: (at 41890) by debbugs.gnu.org; 22 Jul 2020 01:31:41 +0000 Received: from localhost ([127.0.0.1]:40785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy3bh-00081z-3u for submit@debbugs.gnu.org; Tue, 21 Jul 2020 21:31:41 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy3be-00081j-S7; Tue, 21 Jul 2020 21:31:39 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9DA025C0057; Tue, 21 Jul 2020 21:31:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 21 Jul 2020 21:31:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=BDAWUu8Di5GkRhUILsLWgTNXhY dqMpftyrTUkzM1o3A=; b=fEcd1VOfNhLvUgy/Sh/4necRjX1x7B5UrqDvY57OWv qa1jvUwQ+Q6GerNA6VhHhz+C2X7rPIqYT1nDTtKO0dzI3ItGOXia876TQBUEYHDh iM7BRH9KeIdDXgI/ORLVMM7alAVUmL6DnjE8fckfjMkf3WB2UfCkdJa48sSfjL5L 3/HXg7zFvYZwbnztgSisAdibkFuDPZGxh7Zn7hcURt4/cUNaqRcn29YkX3Y+GAi9 7NbvbfN/yMAq2kVqycQTopzCdOo6wl9g5mv/Ga1UYyxvthmTlPZ3wjqEXLd8S0bL mF1P6h5w8AfigWqGaAlKgyKYKJxSeqglw+hYl/dJaymQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=BDAWUu 8Di5GkRhUILsLWgTNXhYdqMpftyrTUkzM1o3A=; b=Nz1y9EnYvolEg+cTI/V6bY jjOiSkiP4kHkbeODbq0MDj8vFwG6n/DzlRkMVQHZzRSsVghPXwCR2xCpoaF3K5+6 Z/BORM1JnaIN4b4Wjk5jTf2hu/VC3G/vyS/r7NLbkeltRTsfbS07ZgLjGZ1WD+Xv RDB0IEI+4cwjCkPe3mDxXr4h1QxUxxCVQnxNxLjTxmJt2Wc6dz2E5ghtPe1b/svw V91KCe8z6aSLXq7tERNo0ooWX28Hk7I/jr8UoEBtUeb8biPx9r78alVX4z8bCorF ivRK1Key/8JJJRbRi1XxWrsSHdslsmqcEylleGa3+lEhByHfYuywKXUNDx9evfyg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeekgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Juri Linkov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87zh7s8mlv.fsf@mail.linkov.net> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> Date: Tue, 21 Jul 2020 18:31:31 -0700 Message-ID: <87eep449os.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 22 Jul 2020 at 02:38AM +03, Juri Linkov wrote: > While the prompt is active, the key '?' and 'C-h' could (and I think should) > display a list of *ALL* available key bindings from the project keymap > in the *Help* buffer (like e.g. 'query-replace' does after typing 'C-h'). What would determine which of the bindings get shown in the prompt, then, supposing there were too many to fit them all? >> I do think we should avoid binding commands under C-x 4 where the >> versions under C-x p would already display in another window -- I think >> it is potentially quite confusing to have bindings with identical >> behaviour under both C-x 4 p and C-x p. > > Shouldn't some key sequence force displaying the project buffer in the > same window (when a version under C-x p displays it in another window)? It's hard to know what key sequence to use. >> But that means we need the defcustom, because a user could use >> display-buffer-alist to change which commands under C-x p will use >> another window. > > I now understand that your top message above implies that a user > could customize display-buffer-alist to display a buffer in another window, > but usually users don't customize display-buffer-alist to display a buffer > in another frame/tab? I exclusively use it to display buffers in other windows :) -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 21 21:33:40 2020 Received: (at 41890) by debbugs.gnu.org; 22 Jul 2020 01:33:40 +0000 Received: from localhost ([127.0.0.1]:40795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy3db-00085M-Pt for submit@debbugs.gnu.org; Tue, 21 Jul 2020 21:33:39 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy3dZ-000855-Ig; Tue, 21 Jul 2020 21:33:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6D8D05C00A8; Tue, 21 Jul 2020 21:33:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 21 Jul 2020 21:33:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=K+BIoZ5ZiufDpd1cQ5LG1pLX+X CxCAFAjKVbifnZcOE=; b=CU1ooe6SzQrwXrpeFJDlIMfzT20nipYtNiSGoO1rqf MV/zgLTZYNhVGBlIbeXLyIsZFkG50yK52hnPaD6Ju6rstxk/5vWyJorQOUEfwabl 470E/VvGkw2Csqu1E92EgE0I9AcM6q/RIifkiUUc2NWVVc0lWCVzTw/hr56G9S4s 1WfRgltr9JvD0nw+L65F0kI6KIHlC7NI+BlbhG+Qqr1SplL93kN1/LgVlGnpJreO veDaR2waWzO7VJwHZ9/SWQCROdyTeUKf5fyd8Dqe0K/fwepZjwIoX3U5N8v8FhRH 6USGS4dsQ7PrRBgo8t0o5Sr5S7p1tpdqPeJF5l7tS1wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=K+BIoZ 5ZiufDpd1cQ5LG1pLX+XCxCAFAjKVbifnZcOE=; b=L37tK3LoySpJ+Japlq9h7C zQDtbqq0Uzj7OQVm3PRSOfsoORXueF5XkujRynKyo9bNIPsf/WnYDWlln+Mq1fkg NdFf36PEepamFNnVfHM7OBovnixvcDa7DlrHVjsazifxPkXmAPUiK7LguGRkU0EZ eHgag5PHVD8FntggilZzDu5XWuEWTupnrlWIiwe759Ug+pfEvNcfw4wHse7JZmPt rtEHph70sWNyd32tZ5k7tPKbiG9ZNByltOopHqInsMtcE7FxTfbRN+2ZbatqBcPp +oHJD3DImgqD2agfEc024KTuzV+IJOMxhm6q+hzNqOYpOenZ8LnNYwRPhoz81Zkw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeekgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , Juri Linkov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> Date: Tue, 21 Jul 2020 18:33:30 -0700 Message-ID: <87blk849lh.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 22 Jul 2020 at 03:38AM +03, Dmitry Gutov wrote: > Either way, I think the concern that someone could type 'C-x p 4 g' and > see that the search results are *still* displayed in another window > (gasp), is not too significant. I think it could be a barrier to learning how to use project.el -- it's weird for the same thing to be bound to two places, so the user might think they've misunderstood something when they see it happen. > Like, there's no other behavior that should result from key sequence, > and if someone wanted to make doubly sure the resulting buffer will be > displayed in the other window, why not let them. This makes sense, and would be useful, so probably overrides my worry about it being harder to learn. So, shall I prepare a new patch which just uses the whole prefix map and drops the defcustom? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 15:30:05 2020 Received: (at 41890) by debbugs.gnu.org; 22 Jul 2020 19:30:05 +0000 Received: from localhost ([127.0.0.1]:43089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyKRI-0003MJ-RL for submit@debbugs.gnu.org; Wed, 22 Jul 2020 15:30:05 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyKRF-0003LH-EB; Wed, 22 Jul 2020 15:30:03 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2518E5C0110; Wed, 22 Jul 2020 15:29:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 22 Jul 2020 15:29:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=IIOUPlN9BHIYbQWehwVFF7+mCW IH3MdTpF9c6x/Qr3U=; b=IwqH23IMG8k6dJ/mj1QWm1AepFSeMogBMbORBB1mj3 NC7S7qOPRqQRB96SY/PQZ6W5TuMo7QkBOj/IIxiY+aZ6mVIhE0Wq6v+0jKMeo1oC zVy7FMlKkGi16h8JPd9hhQ9F4EN3hAkgWiSmayZbVLp8J6taG8DKQbH8elSKrr/+ E//nPZ80CBfxjgNLQd23Hjch8TqKyPMGvAj/Q2fYaQRLQqvSG/lk51ihjLa81mdj PSpEtfbZhM4PgHkAQUZPIDvRn1hJNYUquEoNfEQllX7IkDEd2JFAgHlaVThzIbeP nSPtFj2wXinGMK6aYGSbKju/ZWL/vX8A2rPKwmrvAoRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=IIOUPl N9BHIYbQWehwVFF7+mCWIH3MdTpF9c6x/Qr3U=; b=useVGB0FkcMYxn1IqkJHEn F6UWGQkDPS7I9WGpRVG8hrJvg33Jbl3jdk0noMXucSXD7guaB+72wAFyIniZW3ww uluTAlwta6TQHCp4QkPMVv2Fgbi70p+a6qGzzUO8SmiHmEIOj68HgHU//EmTxq0k T4rVOMg78BC3xrE+PA0RK443k0OeIHIiE5I2Ot8TuWWm/u6UOVK9VixjHzctEGUL 0WSzYHYEr7X0rTjtXpVJxr8T/9vOYys6vTuSFbc7Ag4gEzLZEnMlRApLoBzrqCCL +yKqdNPD0WNPl3oai9Vfb9fW23MBqF5xY/4PKLbHMzdmpsvUw9P8qquI7JmTjRpQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeelgddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , Juri Linkov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87blk849lh.fsf@iris.silentflame.com> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> Date: Wed, 22 Jul 2020 12:28:51 -0700 Message-ID: <87tuxz2vt8.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 21 Jul 2020 at 06:33PM -07, Sean Whitton wrote: > On Wed 22 Jul 2020 at 03:38AM +03, Dmitry Gutov wrote: > >> Like, there's no other behavior that should result from key sequence, >> and if someone wanted to make doubly sure the resulting buffer will be >> displayed in the other window, why not let them. > > This makes sense, and would be useful, so probably overrides my worry > about it being harder to learn. So, shall I prepare a new patch which > just uses the whole prefix map and drops the defcustom? Hmm, a further complication: I would like to be able to bind C-x 4 p C-o to work like C-x 4 C-o. I think this could be achieved by having an additional keymap, and the command bound to C-x 4 p can look up keys in both project-prefix-map and this new keymap. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 20:36:56 2020 Received: (at 41890) by debbugs.gnu.org; 23 Jul 2020 00:36:56 +0000 Received: from localhost ([127.0.0.1]:43393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyPEG-0002bB-CF for submit@debbugs.gnu.org; Wed, 22 Jul 2020 20:36:56 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyPED-0002ag-C0; Wed, 22 Jul 2020 20:36:55 -0400 X-Originating-IP: 91.129.108.250 Received: from mail.gandi.net (m91-129-108-250.cust.tele2.ee [91.129.108.250]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 86A37C0009; Thu, 23 Jul 2020 00:36:43 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Organization: LINKOV.NET References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87eep449os.fsf@iris.silentflame.com> Date: Thu, 23 Jul 2020 03:32:07 +0300 In-Reply-To: <87eep449os.fsf@iris.silentflame.com> (Sean Whitton's message of "Tue, 21 Jul 2020 18:31:31 -0700") Message-ID: <87sgdjcbqw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> While the prompt is active, the key '?' and 'C-h' could (and I think should) >> display a list of *ALL* available key bindings from the project keymap >> in the *Help* buffer (like e.g. 'query-replace' does after typing 'C-h'). > > What would determine which of the bindings get shown in the prompt, > then, supposing there were too many to fit them all? Maybe it's possible to show all them by using 'read-char-choice' when only the initial letters are displayed in the prompt like "(f, g, d, v, s, ?): " or using 'read-answer' or 'read-multiple-choice', e.g.: (read-multiple-choice "Select project" '((?f "Find file") (?g "Find regexp") (?d "dired") (?v "vc-dir") (?s "shell"))) >>> I do think we should avoid binding commands under C-x 4 where the >>> versions under C-x p would already display in another window -- I think >>> it is potentially quite confusing to have bindings with identical >>> behaviour under both C-x 4 p and C-x p. >> >> Shouldn't some key sequence force displaying the project buffer in the >> same window (when a version under C-x p displays it in another window)? > > It's hard to know what key sequence to use. Indeed, it's hard to find a key prefix analogous to 'C-x 4 1'. Maybe 'C-x 4 1 p'? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 11:07:10 2020 Received: (at 41890) by debbugs.gnu.org; 23 Jul 2020 15:07:10 +0000 Received: from localhost ([127.0.0.1]:45820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jycoP-0003jB-RI for submit@debbugs.gnu.org; Thu, 23 Jul 2020 11:07:10 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jycoL-0003ic-8w; Thu, 23 Jul 2020 11:07:08 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1CE505C00A6; Thu, 23 Jul 2020 11:07:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 23 Jul 2020 11:07:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=3mIqSQ7D3x9MXOomvrFSI8Iy9u E+58h28BImC8PhUs4=; b=qXVXUV16ulth+idIh0FiL5l9USH5QgGLgXg/ZYetdf A1pHyqhWqXM7mnxj2yImopKUCTjtlEKi550rpd/sceNysXVyFoj+l0K/uB2CPSiB Lh6tzZ1EWWRJqUtnDexKkwkpaH6ZYXFxzF90z/1WtaxTz9pg2elVw7FdTliAEDeG HKaaQpu9nzh//W5c+0SAFLK4kYnCkFX95YkhtAcFxes5dFRQpN6Tdy3ITdF+iqh2 MHbmze/667XiKl9c2vI3v8ursbv7q/jNVOZ0qNbUzZb16pAQ5JYnduDB3vGLZEgV H0gZQI1/ak8X9adfqvW0UVto/zkRG7aHyhwAgmH98n6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=3mIqSQ 7D3x9MXOomvrFSI8Iy9uE+58h28BImC8PhUs4=; b=tELP65Z/OXxi7N8M7epCE/ Sw2kSwJ3Pwsaov8RoBIWJyR8UpTpaKS5xg6vkYTPjObdyYukLPDFA3Rs5rVuUMwn 7FzpjjImhg8OOjG5zU0SvRCWqbiGPklKFwIeyXf6EFP/y8VQx0BkUUrXWg/zfPNd WEQ+e8kHHKi28K2CELufrz/Zym90Jb7YiNAnHGDyJHZZw886PpBmza/37OJUOGAT +40odFzgyM7J1SeyUC4CmtLLt+hu5Qvg8cNQtr4oH+VHo815/IQvf96dmOYuzhs6 8U9pCrR8VeFHiMFoU4cmi5Bidlu+bMY4XiAr9Fqvkqh1ogPvmVAXJ5GTwu6EOn2g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrhedugdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Juri Linkov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <87sgdjcbqw.fsf@mail.linkov.net> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87eep449os.fsf@iris.silentflame.com> <87sgdjcbqw.fsf@mail.linkov.net> Date: Thu, 23 Jul 2020 08:06:57 -0700 Message-ID: <87k0yutgmm.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Juri, On Thu 23 Jul 2020 at 03:32AM +03, Juri Linkov wrote: >>> While the prompt is active, the key '?' and 'C-h' could (and I think should) >>> display a list of *ALL* available key bindings from the project keymap >>> in the *Help* buffer (like e.g. 'query-replace' does after typing 'C-h'). >> >> What would determine which of the bindings get shown in the prompt, >> then, supposing there were too many to fit them all? > > Maybe it's possible to show all them by using 'read-char-choice' when only > the initial letters are displayed in the prompt like "(f, g, d, v, s, ?): " > or using 'read-answer' or 'read-multiple-choice', e.g.: > > (read-multiple-choice "Select project" > '((?f "Find file") > (?g "Find regexp") > (?d "dired") > (?v "vc-dir") > (?s "shell"))) If we're only displaying single letters, then I'm not sure there is much point in prompting at all? Either someone knows what letter to press or they don't -- in either case the prompt seems useless. >>>> I do think we should avoid binding commands under C-x 4 where the >>>> versions under C-x p would already display in another window -- I think >>>> it is potentially quite confusing to have bindings with identical >>>> behaviour under both C-x 4 p and C-x p. >>> >>> Shouldn't some key sequence force displaying the project buffer in the >>> same window (when a version under C-x p displays it in another window)? >> >> It's hard to know what key sequence to use. > > Indeed, it's hard to find a key prefix analogous to 'C-x 4 1'. > Maybe 'C-x 4 1 p'? I'd be cautious about this, because it breaks the general semantics of C-x 4 1. It seems reasonable that someone might have a major-mode in which 'p' displays another buffer, and then they might want to use C-x 4 1 to reuse the same window. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 19:46:47 2020 Received: (at 41890) by debbugs.gnu.org; 23 Jul 2020 23:46:47 +0000 Received: from localhost ([127.0.0.1]:46324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jykvG-0003z7-U9 for submit@debbugs.gnu.org; Thu, 23 Jul 2020 19:46:47 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:36475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jykvD-0003yn-Bc; Thu, 23 Jul 2020 19:46:45 -0400 Received: by mail-wm1-f42.google.com with SMTP id y24so2518213wma.1; Thu, 23 Jul 2020 16:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Zsfz97p2u51w21HhBtcsA1un7gj/TZVMlt/8wF1e3jo=; b=EUe3nmztJwNOIZNvxg1QtcsY9Wwg5rEY/gYAllbdSxn3f4wjE9jl9D/yPy4hE3WIeW FnH9SKEwphBl9gLgHPp54VajmZycxYDazNWOSYZ22LI0gzxhJgsO51cAD6uIBbr/gGfQ bHs+YJN9HDqanvkTQP4ExLpZ6kcn2ZxL7a3wBC/Kcz/436yiV33JphQ5GBfMigSVD9OA ddcqi3XAvlvGqpOOoQpC5Jitu5BLqrTJDbIqsm/O7/cfYXGMzkppwqocKDyMxdTA1Um2 e6ovEWxUFI8FYWzDsDamaPm9S7F0Hifm/kS4OVT35QzkqNSOejhr1ZdGz870GdfvitPU SuzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Zsfz97p2u51w21HhBtcsA1un7gj/TZVMlt/8wF1e3jo=; b=hKzkzmDZX6N5YEv7s9JP6ebRFhmJ5fIwxA0R48+T4m0UOxS/uL9XcH5zIpjNzSSky1 ZIcwrkIS4FBSsmepBKAHCq/xwNrc/oDkLp0V7dV7Tt/oP+71d7sx/c/R1+wuj3QyP/sf KnB149eLTvzl/58JqLexcS0zL15Q3CRmIDjfH1HLbUkL7f8C0ASJ/hcjibk/wkVaimRw E7Z/plsLV0ffckmxWOWVIZq9k6h1F9RDM3u0ELq3ql0Fce3CmEIqM/I8Nx2FqWoXFzLW hpvu0yz3Vcs+qC9yJvrCiA/X7V9NPoNOplOj/6/MkG+fjxbNjvFjdjuw7SOrZzVQz4YD wT2A== X-Gm-Message-State: AOAM532GNH4Sq74NxH7nwyohiZudC2Dsh1PiLec8xt8tuMgyLBEiDSY2 lecUL/A7upfCVAzJIv6Ezy/ljBpI X-Google-Smtp-Source: ABdhPJz4eNdRHZvq9rmtCQwdFg4cCtMaPq2CcFC9qFdWJmi1MkInKrhnjy5Czt71ahJ19gsVSM1wUA== X-Received: by 2002:a7b:ce04:: with SMTP id m4mr6025839wmc.1.1595547996953; Thu, 23 Jul 2020 16:46:36 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id p25sm4832133wma.39.2020.07.23.16.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2020 16:46:36 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , Juri Linkov References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> Date: Fri, 24 Jul 2020 02:46:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87tuxz2vt8.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) On 22.07.2020 22:28, Sean Whitton wrote: >> This makes sense, and would be useful, so probably overrides my worry >> about it being harder to learn. So, shall I prepare a new patch which >> just uses the whole prefix map and drops the defcustom? Since we're struggling between the choices, and you don't feel a strong attachment to the prompt either, yes, please. Then we can install it and maybe continue the discussion of an optional patch which will add the prompt on top of it. > Hmm, a further complication: I would like to be able to bind C-x 4 p C-o > to work like C-x 4 C-o. > > I think this could be achieved by having an additional keymap, and the > command bound to C-x 4 p can look up keys in both project-prefix-map and > this new keymap. Yup. The new keymap could inherit from project-prefix-map, then the lookup should be just one funcall. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 22:04:24 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 02:04:24 +0000 Received: from localhost ([127.0.0.1]:46372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyn4R-0007O4-JS for submit@debbugs.gnu.org; Thu, 23 Jul 2020 22:04:24 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:46785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyn4O-0007Nm-U8; Thu, 23 Jul 2020 22:04:22 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id A72645801EB; Thu, 23 Jul 2020 22:04:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 23 Jul 2020 22:04:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=aavMk66eQx9ZYn3YpJ79EQtPyg 3845N/U1qf18rDvKk=; b=CpolAEDld9FhlFsi8otHfhNgSKSJmg8tTYMjJvX0+O ujs6bVTv1cZs2FV9FxaeUpA8sKLsv/KWyyvW9DBQnWFo/uGpDkiMhed47HU42Rur 1Xp0TRg4IMeP/h7a8xfHp8EOg/8jTgaEoZtBF5y2zV7gwi4EqDmGbzGD602H+8fb oJ+mOl0sFsyL92H4C+7Y34h1HOM3pypJrp8/+G16AKuFEDTZfHPFewXSeI6c1sxd MDkXu/1kvgNPYnQkU6GyjwIsHA16ZFGsLFyQ5TL8J9J3gkcxEAUBXyQ0S40lM/Ci ba1XgMBTE/0SCvknBiuciiiZKhTT2XEyPwcspJKnGe6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=aavMk6 6eQx9ZYn3YpJ79EQtPyg3845N/U1qf18rDvKk=; b=Xd0zDN4MXnPds3FozE9yc8 v+CJmIJy7GqBKS5hqZQiJhKF5eTm9k2I3dmiu32pc02AHuf/OMHTuB+hG07IocCA FifzNlir+Zag4McOVrymAjQnH5cq7aoKpv7dABXtGWjFX5QQgZDSHLYQvo+lTGud nzzvjgqXTfPCDt82BX5RhF6lWiDMTP/xMGHDyVswusBo6VevACijPmcAQStAbUmo CzXmNXEdMVMcUGG918sroknJRy5EFk1f6km49zPlqx/Kna6jcxduujzZ2I4puzNo CtlCdQI2O5DfYPoKjWv6OgyPkHE9JNCtym2Pllfw7VUv/95ULXnE8meUcm77alAw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrhedvgdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenog fhohhrsghiugguvghnufhorhhtjfgurhculdehtddtmdenucfjughrpefhvffujghffffk gggtsehmtderredttddtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhh hithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepieff hfffudfhjefgfeeuleeutdevtdektdehiefgieetleevveekgeduhedtudefnecuhfhorh gsihguuggvnhfuohhrthfjughrpeffhffkuffvgggjtghfsehmtderredttddtnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtth honhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , Juri Linkov Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> Date: Thu, 23 Jul 2020 19:04:13 -0700 Message-ID: <878sf9u0rm.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, "Philip K." , 42210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Fri 24 Jul 2020 at 02:46AM +03, Dmitry Gutov wrote: > On 22.07.2020 22:28, Sean Whitton wrote: >>> [...] > > Since we're struggling between the choices, and you don't feel a strong > attachment to the prompt either, yes, please. > > Then we can install it and maybe continue the discussion of an optional > patch which will add the prompt on top of it. Cool, what do you think to the attached? >> Hmm, a further complication: I would like to be able to bind C-x 4 p C-o >> to work like C-x 4 C-o. >> >> I think this could be achieved by having an additional keymap, and the >> command bound to C-x 4 p can look up keys in both project-prefix-map and >> this new keymap. > > Yup. The new keymap could inherit from project-prefix-map, then the > lookup should be just one funcall. In the end I didn't use inheritance; hopefully it is clear from the patch why I thought this would not be a good idea. -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-project-display-buffer-and-project-display-buffe.patch >From 5a55c6376a5ccec957adee88e03503f651ee7448 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Thu, 23 Jul 2020 18:00:59 -0700 Subject: [PATCH 1/2] Add project-display-buffer and project-display-buffer-other-frame * lisp/progmodes/project.el (project-switch-to-buffer): Add optional switching-function argument. * lisp/progmodes/project.el (project-display-buffer, project-display-buffer-other-frame): Add commands. --- lisp/progmodes/project.el | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index a0930553bd..f47e6bcc1c 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -878,12 +878,15 @@ project-compile (compile command comint))) ;;;###autoload -(defun project-switch-to-buffer () +(defun project-switch-to-buffer (&optional switching-function) "Switch to another buffer belonging to the current project. This function prompts for another buffer, offering as candidates buffers that belong to the same project as the current buffer. Two buffers belong to the same project if their project instances, -as reported by `project-current' in each buffer, are identical." +as reported by `project-current' in each buffer, are identical. + +Optional argument SWITCHING-FUNCTION is the function used to +switch the buffer. It defaults to `switch-to-buffer'." (interactive) (let* ((pr (project-current t)) (current-buffer (current-buffer)) @@ -896,7 +899,7 @@ project-switch-to-buffer (equal pr (with-current-buffer (cdr buffer) (project-current))))))) - (switch-to-buffer + (funcall (or switching-function #'switch-to-buffer) (read-buffer "Switch to buffer: " (when (funcall predicate (cons other-name other-buffer)) @@ -904,6 +907,24 @@ project-switch-to-buffer nil predicate)))) +;;;###autoload +(defun project-display-buffer () + "Display a buffer of the current project without selecting it. + +See `project-switch-to-buffer' for what it means for a buffer to +belong to the current project." + (interactive) + (project-switch-to-buffer #'display-buffer)) + +;;;###autoload +(defun project-display-buffer-other-frame () + "Display a buffer of the current project, preferably in another frame. + +See `project-switch-to-buffer' for what it means for a buffer to +belong to the current project." + (interactive) + (project-switch-to-buffer #'display-buffer-other-frame)) + (defcustom project-kill-buffers-ignores '("\\*Help\\*") "Conditions for buffers `project-kill-buffers' should not kill. -- 2.27.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-Add-project-other-place-commands.patch >From c303620b4a9c04771fe9188b500fc5a8e88c8ea6 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Thu, 23 Jul 2020 18:55:42 -0700 Subject: [PATCH 2/2] Add project other place commands * lisp/progmodes/project.el (project-other-window-map, project-other-frame-map, project--other-place-command, project-other-window-command, project-other-frame-command, project-other-tab-command): Add these functions and maps. * lisp/progmodes/project.el: Bind project-other-window-command to C-x 4 p, project-other-frame-command to C-x 5 p and project-other-tab-command to C-x t p. --- lisp/progmodes/project.el | 67 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index f47e6bcc1c..13b1eafe3e 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -592,6 +592,73 @@ project-prefix-map ;;;###autoload (define-key ctl-x-map "p" project-prefix-map) +;; We can't have these place-specific maps inherit from +;; project-prefix-map because project--other-place-command needs to +;; know which map the key binding came from, as if it came from one of +;; these maps, we don't want to set display-buffer-overriding-action + +(defvar project-other-window-map + (let ((map (make-sparse-keymap))) + (define-key map "\C-o" #'project-display-buffer) + map) + "Keymap for additional project commands to display in other windows.") + +(defvar project-other-frame-map + (let ((map (make-sparse-keymap))) + (define-key map "\C-o" #'project-display-buffer-other-frame) + map) + "Keymap for additional project commands to display in other frames.") + +(defun project--other-place-command (action &optional map) + (let* ((key (read-key-sequence-vector nil t)) + (place-cmd (lookup-key map key)) + (generic-cmd (lookup-key project-prefix-map key)) + (display-buffer-overriding-action (unless place-cmd action))) + (if-let ((cmd (or place-cmd generic-cmd))) + (call-interactively cmd) + (user-error "%s is undefined" (key-description key))))) + +;;;###autoload +(defun project-other-window-command () + "Invoke a project command but display its buffer in another window. + +The following commands are available: + +\\{project-prefix-map} +\\{project-other-window-map}" + (interactive) + (project--other-place-command '((display-buffer-pop-up-window) + (inhibit-same-window . t)) + project-other-window-map)) + +;;;###autoload (define-key ctl-x-4-map "p" #'project-other-window-command) + +;;;###autoload +(defun project-other-frame-command () + "Invoke a project command but display its buffer in another frame. + +The following commands are available: + +\\{project-prefix-map} +\\{project-other-frame-map}" + (interactive) + (project--other-place-command '((display-buffer-pop-up-frame)) + project-other-frame-map)) + +;;;###autoload (define-key ctl-x-5-map "p" #'project-other-frame-command) + +;;;###autoload +(defun project-other-tab-command () + "Invoke a project command but display its buffer in another tab. + +The following commands are available: + +\\{project-prefix-map}" + (interactive) + (project--other-place-command '((display-buffer-in-new-tab)))) + +;;;###autoload (define-key tab-prefix-map "p" #'project-other-tab-command) + (defun project--value-in-dir (var dir) (with-temp-buffer (setq default-directory dir) -- 2.27.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 02:01:57 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 06:01:57 +0000 Received: from localhost ([127.0.0.1]:46527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyqmL-0004qZ-6C for submit@debbugs.gnu.org; Fri, 24 Jul 2020 02:01:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyqmG-0004qE-R3; Fri, 24 Jul 2020 02:01:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33076) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyqm9-0003g9-M1; Fri, 24 Jul 2020 02:01:45 -0400 Received: from [176.228.60.248] (port=2127 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jyqm9-0007PU-0K; Fri, 24 Jul 2020 02:01:45 -0400 Date: Fri, 24 Jul 2020 09:01:27 +0300 Message-Id: <83sgdhe9jc.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <878sf9u0rm.fsf@iris.silentflame.com> (message from Sean Whitton on Thu, 23 Jul 2020 19:04:13 -0700) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jul 2020 19:04:13 -0700 > Cc: "Basil L. Contovounesios" , > "Philip K." , 41890@debbugs.gnu.org, > 42210@debbugs.gnu.org > > -(defun project-switch-to-buffer () > +(defun project-switch-to-buffer (&optional switching-function) > "Switch to another buffer belonging to the current project. > This function prompts for another buffer, offering as candidates > buffers that belong to the same project as the current buffer. > Two buffers belong to the same project if their project instances, > -as reported by `project-current' in each buffer, are identical." > +as reported by `project-current' in each buffer, are identical. > + > +Optional argument SWITCHING-FUNCTION is the function used to > +switch the buffer. It defaults to `switch-to-buffer'." > (interactive) This interface strikes me as unusual and even unexpected for a command that switches to another buffer. I would expect it to have an API similar to that of switch-to-buffer: that it should accept the buffer to switch to as an argument, and set up that argument in the 'interactive' spec according to the preferences of this command (offering buffers in the same project etc.). The API you propose makes it awkward, to say the least, to invoke this command from Lisp. Granted, the original API doesn't allow such invocation, either, but as long as we are changing this API, let's try fixing that, okay? > +(defun project-display-buffer () > + "Display a buffer of the current project without selecting it. This doesn't say where that buffer will be displayed. Please add that important detail to the doc string. > +(defun project-display-buffer-other-frame () > + "Display a buffer of the current project, preferably in another frame. > + > +See `project-switch-to-buffer' for what it means for a buffer to > +belong to the current project." The "preferably" part needs to be explained some more, perhaps by pointing to display-buffer-other-frame for the details. Otherwise it leaves some of the command's MO a mystery. > +(defvar project-other-window-map > + (let ((map (make-sparse-keymap))) > + (define-key map "\C-o" #'project-display-buffer) > + map) > + "Keymap for additional project commands to display in other windows.") Do you mean "commands _that_ display in other windows"? If so, please use "that" instead of "to". Also, I think the doc string should explain what do those commands display in those other windows. > +(defvar project-other-frame-map > + (let ((map (make-sparse-keymap))) > + (define-key map "\C-o" #'project-display-buffer-other-frame) > + map) > + "Keymap for additional project commands to display in other frames.") Same here. > +;;;###autoload > +(defun project-other-window-command () > + "Invoke a project command but display its buffer in another window. ^ Comma is missing there. More importantly, the "its" part is ambiguous. What does it allude to? > +(defun project-other-frame-command () > + "Invoke a project command but display its buffer in another frame. Same here. > +(defun project-other-tab-command () > + "Invoke a project command but display its buffer in another tab. Same here, except that in this case even the idea of "displaying in a tab" is unclear. This needs rewording. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 11:12:23 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 15:12:23 +0000 Received: from localhost ([127.0.0.1]:48533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyzN1-0006p7-CY for submit@debbugs.gnu.org; Fri, 24 Jul 2020 11:12:23 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyzMy-0006on-Ro; Fri, 24 Jul 2020 11:12:21 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A6B775C005C; Fri, 24 Jul 2020 11:12:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 24 Jul 2020 11:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=XY46UX1XaCegjz8LWYcGgGrGxM 3SQ9qdXdmEX/KDQoE=; b=ePxWrCGojbq1pPzPiN90Ukp2c3r+2qXuAcPa+FBon9 XK2Q5laajrm5cn3WSlW+6S7dL0/czVgmXBUWAELyHL3HnAD8gq/7Fumpy99ODNAi cB/IQs0LhKeW2WjWofodSHBdAsXHNGZ9Ghf7Mx/D4Gl+JzuaRiFgqAkqNKTomz6A DEvLqscIRCednLYEWaQ388qfcNK5H9h62soJ8ALkWCoVtA60msXA9ezOwTBcZFOV K6PtSzXhTTedOv/hfWe1NlYtfMHeTpWQryV3c/zZ3KQ2jzJttAZggidk9w38GsuI nz55VTT27xLO0Punimul1VA34A54MWlQQRjMYbw/3wKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=XY46UX 1XaCegjz8LWYcGgGrGxM3SQ9qdXdmEX/KDQoE=; b=twQiJqYU1nB1Kt2qVZER0u hygT40gxWt0jVK2xBWiH5deizmLbsogR3b5PwrH1IVvScHTBsOMkiq7H8iIzohJp mHv0psH06Rie8hxShnD4JskCRs0AuO6WQ9p4DZVKmo+HwOClVITcpBR2zMM6VS5Q qTOKw0c2exBF0dyiyvDqCjq7NDFlSoId4kcbrJ89fY8XYn7FGDnv8BJ98nePrYk9 MIwmdfpfv13WVEvEO5is0daX2DiXpxAtKA8YkdpSA+f9Wc6xg2RaMyTYKZG0dLAi 2N2TUd29cGXIU1LyxFHqQAESeShLrocWDx9hZq5oCl5mUN68Yhv+Quyl2sheUnyg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrheefgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <83sgdhe9jc.fsf@gnu.org> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> Date: Fri, 24 Jul 2020 08:12:13 -0700 Message-ID: <871rl1t0aa.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Eli, On Fri 24 Jul 2020 at 09:01AM +03, Eli Zaretskii wrote: >> Date: Thu, 23 Jul 2020 19:04:13 -0700 >> Cc: "Basil L. Contovounesios" , >> "Philip K." , 41890@debbugs.gnu.org, >> 42210@debbugs.gnu.org >> >> -(defun project-switch-to-buffer () >> +(defun project-switch-to-buffer (&optional switching-function) >> "Switch to another buffer belonging to the current project. >> This function prompts for another buffer, offering as candidates >> buffers that belong to the same project as the current buffer. >> Two buffers belong to the same project if their project instances, >> -as reported by `project-current' in each buffer, are identical." >> +as reported by `project-current' in each buffer, are identical. >> + >> +Optional argument SWITCHING-FUNCTION is the function used to >> +switch the buffer. It defaults to `switch-to-buffer'." >> (interactive) > > This interface strikes me as unusual and even unexpected for a command > that switches to another buffer. I would expect it to have an API > similar to that of switch-to-buffer: that it should accept the buffer > to switch to as an argument, and set up that argument in the > 'interactive' spec according to the preferences of this command > (offering buffers in the same project etc.). The API you propose > makes it awkward, to say the least, to invoke this command from Lisp. I added the argument just so I could reuse the code in project-switch-to-buffer, so a simple alternative for the purposes of my patch would be to factor that code out into a new project--select-project-buffer defun. Then no existing APIs would be changed. Would that be sufficient? > Granted, the original API doesn't allow such invocation, either, but > as long as we are changing this API, let's try fixing that, okay? This is a bit tricky actually -- what should the function do if some Lisp code passes it a buffer which is not part of the current project? Throw an error? But then surely the Lisp code would prefer to just check if the buffer is part of the project itself, and use switch-to-buffer. I'd be grateful if you could say more about the sort of Lisp code you have in mind. I'm struggling to imagine wanting to call this function from Lisp except via call-interactively. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 12:13:14 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 16:13:14 +0000 Received: from localhost ([127.0.0.1]:48605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz0Jq-0008Kl-Uf for submit@debbugs.gnu.org; Fri, 24 Jul 2020 12:13:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz0Jj-0008K7-ND; Fri, 24 Jul 2020 12:13:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55397) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jz0Jc-0005dP-JO; Fri, 24 Jul 2020 12:12:56 -0400 Received: from [176.228.60.248] (port=3004 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jz0Jb-000763-5a; Fri, 24 Jul 2020 12:12:56 -0400 Date: Fri, 24 Jul 2020 19:12:39 +0300 Message-Id: <83ft9gevt4.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <871rl1t0aa.fsf@iris.silentflame.com> (message from Sean Whitton on Fri, 24 Jul 2020 08:12:13 -0700) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: dgutov@yandex.ru, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, > 41890@debbugs.gnu.org, 42210@debbugs.gnu.org > Date: Fri, 24 Jul 2020 08:12:13 -0700 > > > This interface strikes me as unusual and even unexpected for a command > > that switches to another buffer. I would expect it to have an API > > similar to that of switch-to-buffer: that it should accept the buffer > > to switch to as an argument, and set up that argument in the > > 'interactive' spec according to the preferences of this command > > (offering buffers in the same project etc.). The API you propose > > makes it awkward, to say the least, to invoke this command from Lisp. > > I added the argument just so I could reuse the code in > project-switch-to-buffer, so a simple alternative for the purposes of my > patch would be to factor that code out into a new > project--select-project-buffer defun. Then no existing APIs would be > changed. > > Would that be sufficient? What you added is not my problem, my problem is that there's no easy way of calling this function from Lisp. > > Granted, the original API doesn't allow such invocation, either, but > > as long as we are changing this API, let's try fixing that, okay? > > This is a bit tricky actually -- what should the function do if some > Lisp code passes it a buffer which is not part of the current project? Just switch to that buffer, I think. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 17:21:11 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 21:21:11 +0000 Received: from localhost ([127.0.0.1]:48808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz57u-0007PJ-S1 for submit@debbugs.gnu.org; Fri, 24 Jul 2020 17:21:11 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:50363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz57r-0007Os-76; Fri, 24 Jul 2020 17:21:09 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 21B0D58052C; Fri, 24 Jul 2020 17:21:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 24 Jul 2020 17:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=IK/2gPXXPBNscTmc1cNdW3O1hF O2g4AjsJt5bI45Q4A=; b=FwbrS/1SY58eQ5FweXbM1Z6puq5BRljZiqgla7zN5W H1VqYpddXx5/MU0Ftya6au+I0E0b1JXIelbC2FfflF9DJ0GnQ6/HuifffbNDSDgz vdbO6T2cT3fzaLTXVz2Z0qrsJnqDXJiNjYOGfvUHa6t/iKICrBwiGDh/QtIJrCKa n0liDxfBNL/voW2uEJAlKAP+Y9cWymtqHuPPrFNbnhzBM1W691SPFaLN5hzHiYXt 4m15baLL5qbUlqYCeZEuGsph0WpTc/GRwaWvOBjs3nOBsXopgaT/t0jaH1QIh1Nn OksSL9qY7ZLtoW6JR7LHxn7g5ba+9GKSgfXUlVPqaDHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=IK/2gP XXPBNscTmc1cNdW3O1hFO2g4AjsJt5bI45Q4A=; b=nKoqwHPuhjScqvMTuG72yn wiIPeeTDbw9/C3Ny2QVMNubX0C1DwZVh2SsUOi879ADLOEsnhZyqL7b8aEVBKVkE Xer7+eWPZWKe/HnqfWeu80K1KYaVULwH/flzOvP3lmtAGu53RJH5liFZdV8UEEyJ legUuURh2StS2O+jxa+GNTnaJFvGkv/qkFYC/1g58U87khP/t66nfZpovibGEckT aGri1yOHhslvTVrcatHYFj8Rn909pjBqbNjpFw4oj9NfC5xl5GXCP6NgS/gO9jLj 9vutjx/oAsas/ZK5gpzkScaKhFToV8+87mF08xhJpbfTaRn4rC1faMuCvwoYkQ9Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrheefgdduieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gohfhorhgsihguuggvnhfuohhrthfjughrucdlhedttddmnecujfgurhephffvufgjfhff kfggtgesmhdtreertddttdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfi hhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeei fffhffduhfejgfefueeluedtvedtkedtheeigfeiteelveevkeegudehtddufeenucfhoh hrsghiugguvghnufhorhhtjfgurhepfffhkffuvfggjggtfhesmhdtreertddttdenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhith htohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <83ft9gevt4.fsf@gnu.org> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> Date: Fri, 24 Jul 2020 14:20:59 -0700 Message-ID: <87wo2swqx0.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Fri 24 Jul 2020 at 07:12PM +03, Eli Zaretskii wrote: > Just switch to that buffer, I think. Okay, then I think the attached addresses feedback received. Thanks! -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v2-0001-Factor-out-project-read-project-buffer-from-proje.patch >From 08394aa143a5e0fc627e259b4deee3a1c3317960 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Fri, 24 Jul 2020 13:36:39 -0700 Subject: [PATCH v2 1/3] Factor out project--read-project-buffer from project-switch-buffer * lisp/progmodes/project.el (project--read-project-buffer): New function extracted from project-switch-buffer. * lisp/progmodes/project.el (project-switch-buffer): Instead of unconditionally reading a project buffer from the user, add buffer-or-name argument, and populate it using project--read-project-buffer when called interactively. Update docstring. --- lisp/progmodes/project.el | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index a0930553bd..9534eb2ef6 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -877,14 +877,7 @@ project-compile (default-directory (project-root pr))) (compile command comint))) -;;;###autoload -(defun project-switch-to-buffer () - "Switch to another buffer belonging to the current project. -This function prompts for another buffer, offering as candidates -buffers that belong to the same project as the current buffer. -Two buffers belong to the same project if their project instances, -as reported by `project-current' in each buffer, are identical." - (interactive) +(defun project--read-project-buffer () (let* ((pr (project-current t)) (current-buffer (current-buffer)) (other-buffer (other-buffer current-buffer)) @@ -896,13 +889,22 @@ project-switch-to-buffer (equal pr (with-current-buffer (cdr buffer) (project-current))))))) - (switch-to-buffer - (read-buffer - "Switch to buffer: " - (when (funcall predicate (cons other-name other-buffer)) - other-name) - nil - predicate)))) + (read-buffer + "Switch to buffer: " + (when (funcall predicate (cons other-name other-buffer)) + other-name) + nil + predicate))) + +;;;###autoload +(defun project-switch-to-buffer (buffer-or-name) + "Display buffer BUFFER-OR-NAME in the selected window. +When called interactively, prompts for a buffer belonging to the +current project. Two buffers belong to the same project if their +project instances, as reported by `project-current' in each +buffer, are identical." + (interactive (list (project--read-project-buffer))) + (switch-to-buffer buffer)) (defcustom project-kill-buffers-ignores '("\\*Help\\*") -- 2.27.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v2-0002-Add-project-display-buffer-and-project-display-bu.patch >From a86e847607b281643603865c7231e52fb467da9c Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Fri, 24 Jul 2020 13:54:49 -0700 Subject: [PATCH v2 2/3] Add project-display-buffer and project-display-buffer-other-frame * lisp/progmodes/project.el (project-display-buffer, project-display-buffer-other-frame): Add commands. --- lisp/progmodes/project.el | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 9534eb2ef6..f674749497 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -906,6 +906,30 @@ project-switch-to-buffer (interactive (list (project--read-project-buffer))) (switch-to-buffer buffer)) +;;;###autoload +(defun project-display-buffer (buffer-or-name) + "Display BUFFER-OR-NAME in some window, without selecting it. +When called interactively, prompts for a buffer belonging to the +current project. Two buffers belong to the same project if their +project instances, as reported by `project-current' in each +buffer, are identical." + (interactive (list (project--read-project-buffer))) + (display-buffer buffer)) + +;;;###autoload +(defun project-display-buffer-other-frame (buffer-or-name) + "Display BUFFER-OR-NAME preferably in another frame. +When called interactively, prompts for a buffer belonging to the +current project. Two buffers belong to the same project if their +project instances, as reported by `project-current' in each +buffer, are identical. + +This function uses `display-buffer-other-frame' as a subroutine, +which see for how it is determined where the buffer will be +displayed." + (interactive (list (project--read-project-buffer))) + (display-buffer-other-frame buffer)) + (defcustom project-kill-buffers-ignores '("\\*Help\\*") "Conditions for buffers `project-kill-buffers' should not kill. -- 2.27.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v2-0003-Add-project-other-place-commands.patch >From f2b038a73a6868a0b6a3b1396ce670cdeeeb75cc Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Thu, 23 Jul 2020 18:55:42 -0700 Subject: [PATCH v2 3/3] Add project other place commands * lisp/progmodes/project.el (project-other-window-map, project-other-frame-map, project--other-place-command, project-other-window-command, project-other-frame-command, project-other-tab-command): Add these functions and maps. * lisp/progmodes/project.el: Bind project-other-window-command to C-x 4 p, project-other-frame-command to C-x 5 p and project-other-tab-command to C-x t p. --- lisp/progmodes/project.el | 67 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index f674749497..7a0bf1fdbf 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -592,6 +592,73 @@ project-prefix-map ;;;###autoload (define-key ctl-x-map "p" project-prefix-map) +;; We can't have these place-specific maps inherit from +;; project-prefix-map because project--other-place-command needs to +;; know which map the key binding came from, as if it came from one of +;; these maps, we don't want to set display-buffer-overriding-action + +(defvar project-other-window-map + (let ((map (make-sparse-keymap))) + (define-key map "\C-o" #'project-display-buffer) + map) + "Keymap for project commands that display buffers in other windows.") + +(defvar project-other-frame-map + (let ((map (make-sparse-keymap))) + (define-key map "\C-o" #'project-display-buffer-other-frame) + map) + "Keymap for project commands that display buffers in other frames.") + +(defun project--other-place-command (action &optional map) + (let* ((key (read-key-sequence-vector nil t)) + (place-cmd (lookup-key map key)) + (generic-cmd (lookup-key project-prefix-map key)) + (display-buffer-overriding-action (unless place-cmd action))) + (if-let ((cmd (or place-cmd generic-cmd))) + (call-interactively cmd) + (user-error "%s is undefined" (key-description key))))) + +;;;###autoload +(defun project-other-window-command () + "Run project command, displaying resultant buffer in another window. + +The following commands are available: + +\\{project-prefix-map} +\\{project-other-window-map}" + (interactive) + (project--other-place-command '((display-buffer-pop-up-window) + (inhibit-same-window . t)) + project-other-window-map)) + +;;;###autoload (define-key ctl-x-4-map "p" #'project-other-window-command) + +;;;###autoload +(defun project-other-frame-command () + "Run project command, displaying resultant buffer in another frame. + +The following commands are available: + +\\{project-prefix-map} +\\{project-other-frame-map}" + (interactive) + (project--other-place-command '((display-buffer-pop-up-frame)) + project-other-frame-map)) + +;;;###autoload (define-key ctl-x-5-map "p" #'project-other-frame-command) + +;;;###autoload +(defun project-other-tab-command () + "Run project command, displaying resultant buffer in a new tab. + +The following commands are available: + +\\{project-prefix-map}" + (interactive) + (project--other-place-command '((display-buffer-in-new-tab)))) + +;;;###autoload (define-key tab-prefix-map "p" #'project-other-tab-command) + (defun project--value-in-dir (var dir) (with-temp-buffer (setq default-directory dir) -- 2.27.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 18:54:34 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 22:54:34 +0000 Received: from localhost ([127.0.0.1]:48922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz6aI-0001Jj-9h for submit@debbugs.gnu.org; Fri, 24 Jul 2020 18:54:34 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:45028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz6aE-0001JP-CM; Fri, 24 Jul 2020 18:54:32 -0400 Received: by mail-wr1-f47.google.com with SMTP id b6so9602685wrs.11; Fri, 24 Jul 2020 15:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=1YS9bHxz6jQaO40wFhUqfodd5s6nEQ77xrf6eFqiA2A=; b=PumJ/Jj00OYdb72yasL346AgB+bmgSTfH8odkAz5AlmAt35WOGq4BF9PqegmOYYAeP AK0qrCEvdqLSWP5pK/0MPdipIs+M315RJBA2i1w7CBEAmoVq+05Q9BaC2PkTds4a8WpE 1FimEwg+JNcOUKNrv/IdLEn9p7p0+1dNjAvvU8n6wVCItoXm45BUfWBglNVdtZiBrEMY HwLS7Y8sALQSloHVbj1wkRzEmeDjiS/+Why+RTrKcscBFPd3guge6tlO0SGgyAHnwvUm iSTYdk5G2ZYDGqEJwD/8SeDzMB7uXMTO1I6gtlKL79a9rReAcxZW39OyiVEQoK5k7K/U 2pwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=1YS9bHxz6jQaO40wFhUqfodd5s6nEQ77xrf6eFqiA2A=; b=RqeJS/t+FdO6xiDZKQLJ2HA/OePWJmmbb7OjpPvW+iI7tUFn96ov93h/K+Hm7yQwG9 9IumMbvf+1cppuSB/kvCLTmhjEFDdJygvj5NdEy4RBT7eo2ymExGeLeovnCTIt2Eo4AE b0D3uyw8yPydo0Z/zOSypdbJfPuqrN7docIlDReCmMYJgryByvCaPYtZk7w6Q40HbLrx /ae5deLPeKYwEGd2UB2cpNUf6jEPWs4v3sgGwlkd9IAT34Iwrr8/JYhVuDGLdudkUtMj 7OlTMy3CKOn3HVr8LKtLgWrb1rMuB5WIsbQvkTrbsL2NRefBc5BGKNR+S4bpXiWy9obr wUIA== X-Gm-Message-State: AOAM532+JEVGH88Nk57erlZ62v9Mb6PXt4IkVLkFcdFGyOKu4JS7FVpw QVxJiH+w43+UgXQ7PiVanh8= X-Google-Smtp-Source: ABdhPJzLkfbuJ9G7GBX0LWyoQMRKAlP1IYpeHEYuqqgYd2FgC853mfCN8caEs8doXCW2Lo6OBvpqjw== X-Received: by 2002:adf:ea0f:: with SMTP id q15mr10136637wrm.113.1595631264284; Fri, 24 Jul 2020 15:54:24 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id q4sm8787186wme.31.2020.07.24.15.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 15:54:23 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , Eli Zaretskii References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> <87wo2swqx0.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: <9e7c9ce3-5f1a-fcfd-c87e-8e549cf4f580@yandex.ru> Date: Sat, 25 Jul 2020 01:54:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87wo2swqx0.fsf@iris.silentflame.com> Content-Type: multipart/mixed; boundary="------------DF21B87F1071D9272AAA3A5E" Content-Language: en-US X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, philip@warpmail.net, 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) This is a multi-part message in MIME format. --------------DF21B87F1071D9272AAA3A5E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sean, On 25.07.2020 00:20, Sean Whitton wrote: > Okay, then I think the attached addresses feedback received. Thanks! These are good patches, working well. But here's a change on top of yours that simplified things a little, and makes a few things unnecessary (I think). All by using the variable called switch-to-buffer-obey-display-actions. What do you and others think? I'll easily admit to being out of my depth when it comes to window management, so if there are reasons to go with the full-on approach, no objections from me. --------------DF21B87F1071D9272AAA3A5E Content-Type: text/x-patch; charset=UTF-8; name="project-other-place-shorter.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="project-other-place-shorter.diff" diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 7a0bf1fdbf..2cad66e705 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -592,29 +592,12 @@ project-prefix-map ;;;###autoload (define-key ctl-x-map "p" project-prefix-map) -;; We can't have these place-specific maps inherit from -;; project-prefix-map because project--other-place-command needs to -;; know which map the key binding came from, as if it came from one of -;; these maps, we don't want to set display-buffer-overriding-action - -(defvar project-other-window-map - (let ((map (make-sparse-keymap))) - (define-key map "\C-o" #'project-display-buffer) - map) - "Keymap for project commands that display buffers in other windows.") - -(defvar project-other-frame-map - (let ((map (make-sparse-keymap))) - (define-key map "\C-o" #'project-display-buffer-other-frame) - map) - "Keymap for project commands that display buffers in other frames.") - -(defun project--other-place-command (action &optional map) +(defun project--other-place-command (action) (let* ((key (read-key-sequence-vector nil t)) - (place-cmd (lookup-key map key)) - (generic-cmd (lookup-key project-prefix-map key)) - (display-buffer-overriding-action (unless place-cmd action))) - (if-let ((cmd (or place-cmd generic-cmd))) + (cmd (lookup-key project-prefix-map key)) + (display-buffer-overriding-action action) + (switch-to-buffer-obey-display-actions t)) + (if cmd (call-interactively cmd) (user-error "%s is undefined" (key-description key))))) @@ -628,8 +611,7 @@ project-other-window-command \\{project-other-window-map}" (interactive) (project--other-place-command '((display-buffer-pop-up-window) - (inhibit-same-window . t)) - project-other-window-map)) + (inhibit-same-window . t)))) ;;;###autoload (define-key ctl-x-4-map "p" #'project-other-window-command) @@ -642,8 +624,7 @@ project-other-frame-command \\{project-prefix-map} \\{project-other-frame-map}" (interactive) - (project--other-place-command '((display-buffer-pop-up-frame)) - project-other-frame-map)) + (project--other-place-command '((display-buffer-pop-up-frame)))) ;;;###autoload (define-key ctl-x-5-map "p" #'project-other-frame-command) @@ -971,31 +952,7 @@ project-switch-to-buffer project instances, as reported by `project-current' in each buffer, are identical." (interactive (list (project--read-project-buffer))) - (switch-to-buffer buffer)) - -;;;###autoload -(defun project-display-buffer (buffer-or-name) - "Display BUFFER-OR-NAME in some window, without selecting it. -When called interactively, prompts for a buffer belonging to the -current project. Two buffers belong to the same project if their -project instances, as reported by `project-current' in each -buffer, are identical." - (interactive (list (project--read-project-buffer))) - (display-buffer buffer)) - -;;;###autoload -(defun project-display-buffer-other-frame (buffer-or-name) - "Display BUFFER-OR-NAME preferably in another frame. -When called interactively, prompts for a buffer belonging to the -current project. Two buffers belong to the same project if their -project instances, as reported by `project-current' in each -buffer, are identical. - -This function uses `display-buffer-other-frame' as a subroutine, -which see for how it is determined where the buffer will be -displayed." - (interactive (list (project--read-project-buffer))) - (display-buffer-other-frame buffer)) + (switch-to-buffer buffer-or-name)) (defcustom project-kill-buffers-ignores '("\\*Help\\*") --------------DF21B87F1071D9272AAA3A5E-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 19:13:30 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 23:13:30 +0000 Received: from localhost ([127.0.0.1]:48942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz6sb-0001nK-TZ for submit@debbugs.gnu.org; Fri, 24 Jul 2020 19:13:30 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz6sZ-0001n2-Ce; Fri, 24 Jul 2020 19:13:28 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 553AC5C00F5; Fri, 24 Jul 2020 19:13:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 24 Jul 2020 19:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=oPJoFxyPdr07yP78nt8oKIOwxy tcTm+lVNErXMGF7Dc=; b=TRAcoe2m3yVn9v87upclASHuPG05FGqtgWX+fOwQEx 4UJcSXvVmgrhsQ4mPDIkqq187Irk1pqJ2IS0K71RICZOgIRB8tPt+L5vNKPhyjxl Ezj8VlJcSFlki4kPZymS7pIuk8OkYWIGz+s8fxvqBLK5R4ZDNBj8mmF7iCd4iOQz 6aBx6C0clK8owf3uCYNsWPWLTnBTP3tj2GZ1wLF9j0G5eHnui3fuI5mXcY7unahS 0XS018P/Z/FBhUE99hO6Q2rpN01+DSvT6N7XOVltAwsF1eWrgEj2hoaWQ/sApGNl 29QtVunJgb2+ECeYl8qFFZSlguZMlv2meD8r+7y6h12Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oPJoFx yPdr07yP78nt8oKIOwxytcTm+lVNErXMGF7Dc=; b=dhSqk3gGk0OAeliPBcd+Wy 7lT8mw8gR9vh64RrXLwKQ21NgZBAjKjqVF5E7OqbWto3890m3o1nA+6tKIhiKiP3 R5/BSVrrZkOn6C6pLu3aJ0JSCJEy8vRaGxGQnJKP6QD0CAaRcfVSq7xpT74p/gXA du19s1hF1oTU4042y1DU/uP27gJPUcIeT8dG8MFART8iritmdGI8+SANydKUjreT rk19H0PWBBt4ktZOgfu9tWYXmYBIQYORu8b4MjLKAFsPHK/FmSqlnxP4KJxVpddQ voE2eIAf8zmPWWv3HAfUMAYPJuvN1WRGMvWS82fTm/vsLFwNYZWUislIes/XFFTw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrheeggddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepgedtvdehgeffhfffvdeffefhgfejffelhfetveffffektefgtdej tdeivddtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Dmitry Gutov , Eli Zaretskii Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <9e7c9ce3-5f1a-fcfd-c87e-8e549cf4f580@yandex.ru> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> <87wo2swqx0.fsf@iris.silentflame.com> <9e7c9ce3-5f1a-fcfd-c87e-8e549cf4f580@yandex.ru> Date: Fri, 24 Jul 2020 16:13:20 -0700 Message-ID: <87lfj8wlpr.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, philip@warpmail.net, 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Dmitry, Thanks for taking a look. On Sat 25 Jul 2020 at 01:54AM +03, Dmitry Gutov wrote: > On 25.07.2020 00:20, Sean Whitton wrote: >> Okay, then I think the attached addresses feedback received. Thanks! > > These are good patches, working well. > > But here's a change on top of yours that simplified things a little, and > makes a few things unnecessary (I think). All by using the variable > called switch-to-buffer-obey-display-actions. > > What do you and others think? I don't think this is going to work, for two reasons: - for consistency with the existing C-x 4 C-o binding, C-x 4 p C-o should be bound to project-display-buffer, but C-x p C-o should not, so we cannot add the C-o binding to project-prefix-map, so another map is needed - I suspect that by relying on switch-to-buffer-obey-display-actions, when you use project-display-buffer the other window will end up selected, which is not meant to happen. > I'll easily admit to being out of my depth when it comes to window > management, so if there are reasons to go with the full-on approach, no > objections from me. Right, it's really complicated, so I wrote the patch as conservatively as possible. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 24 19:45:47 2020 Received: (at 41890) by debbugs.gnu.org; 24 Jul 2020 23:45:47 +0000 Received: from localhost ([127.0.0.1]:48957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz7Nr-0002Zp-5o for submit@debbugs.gnu.org; Fri, 24 Jul 2020 19:45:47 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:39747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jz7Np-0002ZX-5N; Fri, 24 Jul 2020 19:45:45 -0400 Received: by mail-wm1-f44.google.com with SMTP id t142so3224036wmt.4; Fri, 24 Jul 2020 16:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NUiuz4dlsJiYw8FuqUjZLG1HUerg1ixJHiVEXWl0aBk=; b=VHApLReUk44V20WSwnHsjN1yJEnPuGDrUt5Jh40Sjxb3E9Wos6JyLLL2qpx9W4M7Li G3qIZKk8MNWr0sIJdLdM+xj3skvErL1IlVZ9qMvxZDQH/svcxute8TSZh7gdCLlzXbUv aV+eR+Dc3W92s4PjqnG80qTGOAnTmSAtda1NH75uQbhCrOhVAxb69qG2WNxyJJeiNAD6 RSsB/FfQqls6+UHdI7FnMYwPnGvv7aizu2uDy7VKhZ0iuFFn0KUCYGRqX9VUpdwFMycG NiNSLub4IquhU0rWqGBUM2UIOQafO+k2FUxML4Phma3aCaDTbpLw3Ey/wxTAUFyVlIwa SOMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NUiuz4dlsJiYw8FuqUjZLG1HUerg1ixJHiVEXWl0aBk=; b=F2Q26QPsF4Ubq8BGeWAKylHW6VuJDVI5w7BHYY4XwzAIzivzGbE0FLlJQqZmqXQedM VQQawesMFFyQKARQldzzPgm/VoJOjBPH5jOOw63u+5cHyKvnXFSVWKpwl10Ep2x40TPe RanWWeTsoQYVWPDRYXNII1dQI/AN7LjhzL4+KbN8/giroRdEuCJ7KEaHGN7bmIWbfDYR y268wb26tSuq0mo4NpHvxTElP0SlmRSyBn/Q9yEVa25eceRPNKkU+kbAtSChJuaRqkRD 3uz0Gy3JbRCEi2WrINToack0+vIKsmyi4rXy0KjevGj2aRreHfNHEs54pjerqn3NlxDa AqPw== X-Gm-Message-State: AOAM533vN78QH7KHekZRbDBkumX1MYrOT2mixAnwq5R1P4YEROpfRZEo hLt1pB2dwVzLN3f3L/rmiPE= X-Google-Smtp-Source: ABdhPJwHp12aj1pJQrjPYSI/YvBruVlzF0ZyJxLtKj8LUIiAcqWJ/jHNFLr8YbYnHTKwNAu9fCmeGQ== X-Received: by 2002:a1c:7511:: with SMTP id o17mr11353212wmc.49.1595634339010; Fri, 24 Jul 2020 16:45:39 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id x204sm13235019wmg.2.2020.07.24.16.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 16:45:37 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , Eli Zaretskii References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> <87wo2swqx0.fsf@iris.silentflame.com> <9e7c9ce3-5f1a-fcfd-c87e-8e549cf4f580@yandex.ru> <87lfj8wlpr.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: <9138a744-5cbe-ced3-b177-14144686163e@yandex.ru> Date: Sat, 25 Jul 2020 02:45:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87lfj8wlpr.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, philip@warpmail.net, 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On 25.07.2020 02:13, Sean Whitton wrote: > I don't think this is going to work, for two reasons: > > - for consistency with the existing C-x 4 C-o binding, C-x 4 p C-o > should be bound to project-display-buffer, but C-x p C-o should not, > so we cannot add the C-o binding to project-prefix-map, so another map > is needed > > - I suspect that by relying on switch-to-buffer-obey-display-actions, > when you use project-display-buffer the other window will end up > selected, which is not meant to happen. Fair enough, thank you. I'll wait a day or two for the others to have a chance to leave some closing feedback, and then it's off to master. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 25 02:15:26 2020 Received: (at 41890) by debbugs.gnu.org; 25 Jul 2020 06:15:26 +0000 Received: from localhost ([127.0.0.1]:49195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzDSt-0004MI-Ej for submit@debbugs.gnu.org; Sat, 25 Jul 2020 02:15:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzDSm-0004Ls-Jk; Sat, 25 Jul 2020 02:15:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40882) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzDSg-0000Nx-QY; Sat, 25 Jul 2020 02:15:10 -0400 Received: from [176.228.60.248] (port=2715 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jzDSf-0004vB-Ti; Sat, 25 Jul 2020 02:15:10 -0400 Date: Sat, 25 Jul 2020 09:14:56 +0300 Message-Id: <837dusdstb.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87wo2swqx0.fsf@iris.silentflame.com> (message from Sean Whitton on Fri, 24 Jul 2020 14:20:59 -0700) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> <87wo2swqx0.fsf@iris.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41890 Cc: 41890@debbugs.gnu.org, 42210@debbugs.gnu.org, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: dgutov@yandex.ru, juri@linkov.net, contovob@tcd.ie, philip@warpmail.net, > 41890@debbugs.gnu.org, 42210@debbugs.gnu.org > Date: Fri, 24 Jul 2020 14:20:59 -0700 > > Okay, then I think the attached addresses feedback received. Thanks! Thanks, I have only one minor comment: > +(defun project-display-buffer (buffer-or-name) > + "Display BUFFER-OR-NAME in some window, without selecting it. > +When called interactively, prompts for a buffer belonging to the > +current project. Two buffers belong to the same project if their > +project instances, as reported by `project-current' in each > +buffer, are identical." This doc string should mention display-buffer, for the same reasons and with the same surrounding test as how project-display-buffer-other-frame mentions display-buffer-other-frame. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 26 01:15:39 2020 Received: (at 41890) by debbugs.gnu.org; 26 Jul 2020 05:15:39 +0000 Received: from localhost ([127.0.0.1]:51615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzZ0c-0006x9-LH for submit@debbugs.gnu.org; Sun, 26 Jul 2020 01:15:39 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:39477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzZ0b-0006wu-76; Sun, 26 Jul 2020 01:15:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id E0AE5580246; Sun, 26 Jul 2020 01:15:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 26 Jul 2020 01:15:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=sb2cPq3wvHPQlJRpL3v5b695Wv hP+6gzeL4JYENx/1o=; b=qXMnp4eg5SXG4w45Q0UFzZBimpOnIJGxTDeXVw8bC3 Uixjkd36JB8Ul17xowGjQGsEJ2rDjAuPZ+Vh2aQR/MT+Q/hqcKk8y8ROhXe3U2x1 nZVG0FqqUPvGljWSMhLDWAOjjAhfUqp4OzepgjCmIP7suOqAjvCthuD7D13Qb9iW J4EmRo9k6sBhbUG1svSWyXXGFIZSJX/cKSPC2XBNzETbPAT8tpFso3XNCBTeoViL 6q85YHcyiJFXPKb/Ygc6hfyXYtPaZ9RzAf8ycYfrALexrBZXSnSj4FDOwXxvoDTU a0qnQfJpndwcy+jg6PxqmKqqfiYxcUOEt2bqaP5Dos0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=sb2cPq 3wvHPQlJRpL3v5b695WvhP+6gzeL4JYENx/1o=; b=Mj0bCOZS7d1Fq3+60o+QQl YKlq0wPcPrY1wnqBpD6UAKphqXjTGX2cIrT+XltALRkX9nFhB5St6F7EEFV2R3mn GkrAr13KcBO1uGWX2aSuiOcYP879M3SLcbQZ6gfn0Sd7ydEAbzVLQEBUFF9T7P9z wj19IZgz6DhC8HDtvwsuq6vUesARZeMBGy/CYMdeoWlqjbtsqEeOVPLNobhP4q5G XMPGZ3OCycUlsY8Ra0TyvS+Sasu4nWkwT1f67BRhelJxGu3LYxdBBuQMUIhHv8N9 WU74qW4yw5Hvh3s6/MOvYGzgpi8FcKpi9UeVh69iqcPAdaO9UANDoFikoI4sy2XA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrheeigdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenog fhohhrsghiugguvghnufhorhhtjfgurhculdehtddtmdenucfjughrpefhvffujghffffk gggtsehmtderredttddtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhh hithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepieff hfffudfhjefgfeeuleeutdevtdektdehiefgieetleevveekgeduhedtudefnecuhfhorh gsihguuggvnhfuohhrthfjughrpeffhffkuffvgggjtghfsehmtderredttddtnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtth honhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Eli Zaretskii , dgutov@yandex.ru Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el In-Reply-To: <837dusdstb.fsf@gnu.org> References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> <87wo2swqx0.fsf@iris.silentflame.com> <837dusdstb.fsf@gnu.org> Date: Sat, 25 Jul 2020 22:15:30 -0700 Message-ID: <87365ec0wd.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, philip@warpmail.net, 42210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Sat 25 Jul 2020 at 09:14AM +03, Eli Zaretskii wrote: > This doc string should mention display-buffer, for the same reasons > and with the same surrounding test as how > project-display-buffer-other-frame mentions > display-buffer-other-frame. Thank you, fixed, along with fixing some references to function arguments which were incorrect in the previous series (they were 'buffer-or-name' in one place but 'buffer' in another). -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v3-0001-Factor-out-project-read-project-buffer-from-proje.patch >From 08394aa143a5e0fc627e259b4deee3a1c3317960 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Fri, 24 Jul 2020 13:36:39 -0700 Subject: [PATCH v3 1/3] Factor out project--read-project-buffer from project-switch-buffer * lisp/progmodes/project.el (project--read-project-buffer): New function extracted from project-switch-buffer. * lisp/progmodes/project.el (project-switch-buffer): Instead of unconditionally reading a project buffer from the user, add buffer-or-name argument, and populate it using project--read-project-buffer when called interactively. Update docstring. --- lisp/progmodes/project.el | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index a0930553bd..9534eb2ef6 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -877,14 +877,7 @@ project-compile (default-directory (project-root pr))) (compile command comint))) -;;;###autoload -(defun project-switch-to-buffer () - "Switch to another buffer belonging to the current project. -This function prompts for another buffer, offering as candidates -buffers that belong to the same project as the current buffer. -Two buffers belong to the same project if their project instances, -as reported by `project-current' in each buffer, are identical." - (interactive) +(defun project--read-project-buffer () (let* ((pr (project-current t)) (current-buffer (current-buffer)) (other-buffer (other-buffer current-buffer)) @@ -896,13 +889,22 @@ project-switch-to-buffer (equal pr (with-current-buffer (cdr buffer) (project-current))))))) - (switch-to-buffer - (read-buffer - "Switch to buffer: " - (when (funcall predicate (cons other-name other-buffer)) - other-name) - nil - predicate)))) + (read-buffer + "Switch to buffer: " + (when (funcall predicate (cons other-name other-buffer)) + other-name) + nil + predicate))) + +;;;###autoload +(defun project-switch-to-buffer (buffer-or-name) + "Display buffer BUFFER-OR-NAME in the selected window. +When called interactively, prompts for a buffer belonging to the +current project. Two buffers belong to the same project if their +project instances, as reported by `project-current' in each +buffer, are identical." + (interactive (list (project--read-project-buffer))) + (switch-to-buffer buffer)) (defcustom project-kill-buffers-ignores '("\\*Help\\*") -- 2.27.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v3-0002-Add-project-display-buffer-and-project-display-bu.patch >From 61fc6615a7c438777ca80f71934979dfd029f0de Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Fri, 24 Jul 2020 13:54:49 -0700 Subject: [PATCH v3 2/3] Add project-display-buffer and project-display-buffer-other-frame * lisp/progmodes/project.el (project-display-buffer, project-display-buffer-other-frame): Add commands. --- lisp/progmodes/project.el | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 9534eb2ef6..0288635fb8 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -904,7 +904,34 @@ project-switch-to-buffer project instances, as reported by `project-current' in each buffer, are identical." (interactive (list (project--read-project-buffer))) - (switch-to-buffer buffer)) + (switch-to-buffer buffer-or-name)) + +;;;###autoload +(defun project-display-buffer (buffer-or-name) + "Display BUFFER-OR-NAME in some window, without selecting it. +When called interactively, prompts for a buffer belonging to the +current project. Two buffers belong to the same project if their +project instances, as reported by `project-current' in each +buffer, are identical. + +This function uses `display-buffer' as a subroutine, which see +for how it is determined where the buffer will be displayed." + (interactive (list (project--read-project-buffer))) + (display-buffer buffer-or-name)) + +;;;###autoload +(defun project-display-buffer-other-frame (buffer-or-name) + "Display BUFFER-OR-NAME preferably in another frame. +When called interactively, prompts for a buffer belonging to the +current project. Two buffers belong to the same project if their +project instances, as reported by `project-current' in each +buffer, are identical. + +This function uses `display-buffer-other-frame' as a subroutine, +which see for how it is determined where the buffer will be +displayed." + (interactive (list (project--read-project-buffer))) + (display-buffer-other-frame buffer)) (defcustom project-kill-buffers-ignores '("\\*Help\\*") -- 2.27.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v3-0003-Add-project-other-place-commands.patch >From 5cc1998dc965d41955ebf8ee2deed7dbcd8e96a8 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Thu, 23 Jul 2020 18:55:42 -0700 Subject: [PATCH v3 3/3] Add project other place commands * lisp/progmodes/project.el (project-other-window-map, project-other-frame-map, project--other-place-command, project-other-window-command, project-other-frame-command, project-other-tab-command): Add these functions and maps. * lisp/progmodes/project.el: Bind project-other-window-command to C-x 4 p, project-other-frame-command to C-x 5 p and project-other-tab-command to C-x t p. --- lisp/progmodes/project.el | 67 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 0288635fb8..3efe0c1ce3 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -592,6 +592,73 @@ project-prefix-map ;;;###autoload (define-key ctl-x-map "p" project-prefix-map) +;; We can't have these place-specific maps inherit from +;; project-prefix-map because project--other-place-command needs to +;; know which map the key binding came from, as if it came from one of +;; these maps, we don't want to set display-buffer-overriding-action + +(defvar project-other-window-map + (let ((map (make-sparse-keymap))) + (define-key map "\C-o" #'project-display-buffer) + map) + "Keymap for project commands that display buffers in other windows.") + +(defvar project-other-frame-map + (let ((map (make-sparse-keymap))) + (define-key map "\C-o" #'project-display-buffer-other-frame) + map) + "Keymap for project commands that display buffers in other frames.") + +(defun project--other-place-command (action &optional map) + (let* ((key (read-key-sequence-vector nil t)) + (place-cmd (lookup-key map key)) + (generic-cmd (lookup-key project-prefix-map key)) + (display-buffer-overriding-action (unless place-cmd action))) + (if-let ((cmd (or place-cmd generic-cmd))) + (call-interactively cmd) + (user-error "%s is undefined" (key-description key))))) + +;;;###autoload +(defun project-other-window-command () + "Run project command, displaying resultant buffer in another window. + +The following commands are available: + +\\{project-prefix-map} +\\{project-other-window-map}" + (interactive) + (project--other-place-command '((display-buffer-pop-up-window) + (inhibit-same-window . t)) + project-other-window-map)) + +;;;###autoload (define-key ctl-x-4-map "p" #'project-other-window-command) + +;;;###autoload +(defun project-other-frame-command () + "Run project command, displaying resultant buffer in another frame. + +The following commands are available: + +\\{project-prefix-map} +\\{project-other-frame-map}" + (interactive) + (project--other-place-command '((display-buffer-pop-up-frame)) + project-other-frame-map)) + +;;;###autoload (define-key ctl-x-5-map "p" #'project-other-frame-command) + +;;;###autoload +(defun project-other-tab-command () + "Run project command, displaying resultant buffer in a new tab. + +The following commands are available: + +\\{project-prefix-map}" + (interactive) + (project--other-place-command '((display-buffer-in-new-tab)))) + +;;;###autoload (define-key tab-prefix-map "p" #'project-other-tab-command) + (defun project--value-in-dir (var dir) (with-temp-buffer (setq default-directory dir) -- 2.27.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 26 20:01:18 2020 Received: (at 41890) by debbugs.gnu.org; 27 Jul 2020 00:01:18 +0000 Received: from localhost ([127.0.0.1]:53572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzqZy-0004oE-9g for submit@debbugs.gnu.org; Sun, 26 Jul 2020 20:01:18 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:40222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzqZv-0004nw-Bm; Sun, 26 Jul 2020 20:01:17 -0400 Received: by mail-wm1-f49.google.com with SMTP id k20so5342249wmi.5; Sun, 26 Jul 2020 17:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DvBQVsiHKoCOXFyXzl+goJ6CcLTF5hnJVpjqz+Io/NM=; b=UUq7BIWLI0cJvUNWOMtwyyW9xAcbsdf/7Ka/VvJP9SFZFCB0xQY9Pc4OKkST5mPp83 I0Q+7Z9I7yl2mem05R1FiycyDraVBRNsOpMaz3HtiBtC6lGnEwFnpYR4QhnWzrs8Ta1V wPYxekKWCcAamVkhJjY2oENUqd3fjhQxBm6opeWkr++l564o8OYXYBxYDbqHa+RMdVnu F3+hBadDgzXfhgv6Rfm5IyUktPx+fsrYXIDl7EP0ZsUDqN/bSdP1PsNDIA1RyxJHc415 iKv2gjTDqxHjcZAM89RBhG2nmspieldcrKTnj4pYHrdYtb9eWpX5p4v8zh5UCh6f6XM+ vVyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DvBQVsiHKoCOXFyXzl+goJ6CcLTF5hnJVpjqz+Io/NM=; b=BT9aTVfzFVwNS9OJBeA2cQuagz+B3ebCq+eHG0Zmgzi7dIORCAzoOigXq4DFA6fm7f FtIn+rdbBNvJsgtyOEHBdQ3VZzDy+kAda1jYasBs0//SUbths9pwTIxb4qNUvO/hUo8M vwkC3kT2j1x51YXz5vog3cfJx35kM1+YM+pb/9VM4SKhCncx3Tw8ke0hs53wMUXifack DCrCW90rzauJh8G5L/X33IBAjTau30vsXCdK3TfRaV1T1HTpDgFbnwLleTBM88LKoYx3 eIHKwENcWcWbGj7nGc2iqbxyn31J59CMzfQa1q9T1RW2PiOVXkP9B2273cklvelo7Q4a RrFA== X-Gm-Message-State: AOAM533InICHJZfX5vpooAr/fBy6GorrI/PwSulk338shSknmSCg2Zoh 2hGBVmIBd+vgdEGTAJt2s0k= X-Google-Smtp-Source: ABdhPJxu4CTPBzrKn9i/VBZPzTtmyaHJBK5swdbW5n7t4MBQ4ArC3pjNmjpWs6Vx5hXMxQ/HAtAqbw== X-Received: by 2002:a1c:e405:: with SMTP id b5mr19304446wmh.54.1595808069315; Sun, 26 Jul 2020 17:01:09 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id t133sm17079449wmf.0.2020.07.26.17.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jul 2020 17:01:08 -0700 (PDT) Subject: Re: bug#42210: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el To: Sean Whitton , Eli Zaretskii References: <87mu50b43d.fsf@warpmail.net> <87pn92t1ye.fsf@iris.silentflame.com> <874kqcsnu5.fsf@iris.silentflame.com> <54a1ed24-9d0e-4671-eb70-9d8c253e7aac@yandex.ru> <87y2ngg64e.fsf@iris.silentflame.com> <99e82681-e645-2888-3d24-26698ee0c7e0@yandex.ru> <871rl6gmip.fsf@iris.silentflame.com> <874kq1d7wf.fsf@iris.silentflame.com> <87zh7s8mlv.fsf@mail.linkov.net> <87blk849lh.fsf@iris.silentflame.com> <87tuxz2vt8.fsf@iris.silentflame.com> <1d2621fe-2e06-cc2d-3c3f-b44d61427ac2@yandex.ru> <878sf9u0rm.fsf@iris.silentflame.com> <83sgdhe9jc.fsf@gnu.org> <871rl1t0aa.fsf@iris.silentflame.com> <83ft9gevt4.fsf@gnu.org> <87wo2swqx0.fsf@iris.silentflame.com> <837dusdstb.fsf@gnu.org> <87365ec0wd.fsf@iris.silentflame.com> From: Dmitry Gutov Message-ID: <66172cd6-3464-fe83-feda-e89e7b9a3338@yandex.ru> Date: Mon, 27 Jul 2020 03:01:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87365ec0wd.fsf@iris.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 41890 Cc: contovob@tcd.ie, 41890@debbugs.gnu.org, philip@warpmail.net, 42210-done@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) On 26.07.2020 08:15, Sean Whitton wrote: > Thank you, fixed, along with fixing some references to function > arguments which were incorrect in the previous series (they were > 'buffer-or-name' in one place but 'buffer' in another). Applied and pushed. Thanks all! With that, I'm closing the associated bug report. Please file new reports for any follow-up patches. From unknown Fri Aug 15 15:28:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Aug 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator