Subject: bug#41888: closed (Re: bug#41888: 27.0.91; fix ACTION argument of display-buffer)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 28 Jun 2020 14:08:02 +0000

Your bug report

#41888: 27.0.91; fix ACTION argument of display-buffer

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41888: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41888
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#41888: 27.0.91; fix ACTION argument of display-buffer
From: Eli Zaretskii <[email-masked]>
To: martin rudalics <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Sun, 28 Jun 2020 17:06:47 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> Cc: [email-masked]
> From: martin rudalics <[email-masked]>
> Date: Sun, 28 Jun 2020 08:37:56 +0200
> 
>  >> gud-common-init function in emacs 27 seems to have a bug in how it calls
>  >> display-buffer. The second argument passed is ACTION. According to
>  >> docstring of display-buffer, the list of functions need to be a list
>  >> within a list. The attached patch adds the missing extra pair of
>  >> parenthesis.
>  >
>  > Martin, any comments or suggestions?
> 
> I think that Richard is right and his patch will fix the problem.

Thanks, pushed to the emacs-27 branch.

Richard, in the future please accompany your changes with a
ChangeLog-style commit log message, as described in CONTRIBUTE.  (I
wrote the log message for you this time.)

Subject: 27.0.91; fix ACTION argument of display-buffer
From: Richard Kim <[email-masked]>
To: [email-masked]
Date: Mon, 15 Jun 2020 23:30:08 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

gud-common-init function in emacs 27 seems to have a bug in how it calls
display-buffer. The second argument passed is ACTION. According to
docstring of display-buffer, the list of functions need to be a list
within a list. The attached patch adds the missing extra pair of
parenthesis.

>From f89f87c6997fe26b4d8859dafd85c886c753a5c6 Mon Sep 17 00:00:00 2001
From: Richard Kim <[email-masked]>
Date: Mon, 15 Jun 2020 23:20:57 -0700
Subject: [PATCH] fixed ACTION argument of display-buffer call

---
 lisp/progmodes/gud.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index d5fd1dce6f..540bc9ce7f 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -2621,9 +2621,9 @@ comint mode, which see."
     (select-window
      (display-buffer
       (get-buffer-create (concat "*gud" filepart "*"))
-      '(display-buffer-reuse-window
-        display-buffer-in-previous-window
-        display-buffer-same-window display-buffer-pop-up-window)))
+      '((display-buffer-reuse-window
+         display-buffer-in-previous-window
+         display-buffer-same-window display-buffer-pop-up-window))))
     (when (and existing-buffer (get-buffer-process existing-buffer))
       (error "This program is already being debugged"))
     ;; Set the dir, in case the buffer already existed with a different dir.
-- 
2.25.1

In GNU Emacs 27.0.91 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.18)
 of 2020-06-12 built on kimr-laptop
Repository revision: 22f4fba8a903874ba63f8f479fa40b1dfe12850f
Repository branch: emacs-27
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Ubuntu 20.04 LTS

Recent messages:
Saving file /home/kimr/repos/e/emacs/lisp/progmodes/gud.el...
Wrote /home/kimr/repos/e/emacs/lisp/progmodes/gud.el
~/repos/e/emacs/lisp/progmodes 
Quit
Mark set [2 times]
Using try-expand-line
No further expansions found
No expansion found [5 times]
Quit
Mark set [5 times]

Configured using:
 'configure '--program-transform-name=s/^ctags$/ctags.emacs/'
 --with-file-notification=yes --with-imagemagick --with-modules
 --with-pdumper=yes --with-sound=yes --with-x-toolkit=yes --with-xml2
 --without-compress-install --with-gif=no --prefix
 /home/kimr/opt/emacs27/20200612 CFLAGS=-O3'

Configured features:
XPM JPEG TIFF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER LCMS2 GMP