GNU bug report logs - #41879
28.0.50; [Patch]: Add project-switch-to-buffer in project.el

Previous Next

Full log

Message #41 received at 41879 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 41879 <at> debbugs.gnu.org, "Philip K." <philip <at> warpmail.net>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in
 project.el
Date: Tue, 16 Jun 2020 15:02:13 +0100

Theodor Thornhill <theo <at> thornhill.no> writes:

>>> +      (lambda (buffer)
>>> +        (when-let ((file (buffer-file-name (cdr buffer))))
>>
>> Nit: Neither the manual nor read-buffer's docstring documents what
>> (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something
>> along those lines would be nice.
> It kind of does, though indirectly? But sure, I can add a small comment.
>
> Documentation states that:
>
>  "It will be called with each potential candidate, in the form of either a
> string or a cons cell whose ‘car’ is a string, and should return non-nil to
> accept the candidate for completion, nil otherwise."

I know, but this says nothing about the cdr.

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.