GNU bug report logs - #41879
28.0.50; [Patch]: Add project-switch-to-buffer in project.el

Previous Next

Full log

Message #17 received at 41879 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Theodor Thornhill <theo <at> thornhill.no>, 41879 <at> debbugs.gnu.org
Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in
 project.el
Date: Tue, 16 Jun 2020 02:38:21 +0300

Thank you.

On 16.06.2020 01:05, Theodor Thornhill wrote:
> What do you think?

A few more notes. :-)

> +      "Switch-to-buffer: " nil nil

The REQUIRE-MATCH argument should be t, I think.

> +      (lambda (buffer)
> +        (when-let* ((path (buffer-file-name (cdr buffer)))

The word "path" is reserved for something else (e.g. exec-path) in the 
GNU project.

Call it file or file-name.

> +                    (true (file-truename path)))

Do we need this conversion? It'll add some runtime overhead, and I'm not 
sure in which conditions the result will be different.

> +          (when (file-in-directory-p true (project-root pr))
> +            'buffer)))))))

Why 'buffer and not t?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.