Subject: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el

From: Dmitry Gutov <[email-masked]>
Date: Tue, 16 Jun 2020 02:38:21 +0300

Thank you.

On 16.06.2020 01:05, Theodor Thornhill wrote:
> What do you think?

A few more notes. :-)

 > +      "Switch-to-buffer: " nil nil

The REQUIRE-MATCH argument should be t, I think.

 > +      (lambda (buffer)
 > +        (when-let* ((path (buffer-file-name (cdr buffer)))

The word "path" is reserved for something else (e.g. exec-path) in the 
GNU project.

Call it file or file-name.

 > +                    (true (file-truename path)))

Do we need this conversion? It'll add some runtime overhead, and I'm not 
sure in which conditions the result will be different.

 > +          (when (file-in-directory-p true (project-root pr))
 > +            'buffer)))))))

Why 'buffer and not t?