From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 13:51:41 2020 Received: (at submit) by debbugs.gnu.org; 15 Jun 2020 17:51:41 +0000 Received: from localhost ([127.0.0.1]:47455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jktGn-00037Q-Dq for submit@debbugs.gnu.org; Mon, 15 Jun 2020 13:51:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:55260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jktGm-00037I-1P for submit@debbugs.gnu.org; Mon, 15 Jun 2020 13:51:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jktGl-00029P-PO for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 13:51:39 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:63170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jktGi-0006DP-PM for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 13:51:38 -0400 Date: Mon, 15 Jun 2020 17:45:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592243155; bh=VvtoNw+g4Hc47l3XDIxAW3qi76eoJOCYDQGQgVRUa3c=; h=Date:To:From:Reply-To:Subject:From; b=HwuEij62Xm2TIXoEGsUdk9IwDM4fBoFe2qsNHIbtpVX3blKbmB+7dggh7NaO6QqAq XiPUcx7cVps9uKm4lIJjaDcZmwY2jx6k7RNCRFTkOZGUoZnk8QgC5Aqnb+eOv7/OWQ 9HwaOFWWEB+E056pl7SbXwjysUA4INXSjvqPW9U9CD3oIGIpPhmd4+AA13DICgntBj xEZMx5enUCzyG/etpsU5rF2nk9SwfhMDuPvWle/QnUYgv9MvrIZiDF0xPkT7Kd2Q9u hqItqHMkVCY/ZVPFRg3HD5J/HriHMoQhAyGc2EHuDsOnQLPbYcndSin76cCH3lkshL hEaxQDY9aLmZA== To: bug-gnu-emacs@gnu.org From: Theodor Thornhill Subject: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87bllk2pfc.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_GIguMFWdao1cmdnuAQbvNtwwYsYSZsOR09Qy7s4PE" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.131; envelope-from=theo@thornhill.no; helo=mail-40131.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 13:51:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_GIguMFWdao1cmdnuAQbvNtwwYsYSZsOR09Qy7s4PE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! This patch is directly dependent on https://debbugs.gnu.org/cgi/bugreport.c= gi?bug=3D41868 since I reused one of the functions added by Philip K. For now I rely on that report to be resolved before this. However, attached is a patch for project-switch-to-buffer, where only file-= bound buffers are included. I believe the function should be kind of self e= xplanatory. I use this daily, but stole the buffer list function since it was better th= an my initial one, and seems to be accepted soon :) I find this useful, and hope others will as well. I bind it myself to 'C-x = p b'. The 'project--list-buffers' will not be part of the final patch, but I want= ed to provide it so that you have a working example. Theodor --b1_GIguMFWdao1cmdnuAQbvNtwwYsYSZsOR09Qy7s4PE Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IDIxODA1OGIxOTUuLjY1ZjMyODU3MDUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzUzLDYgKzc1MywzNSBAQCBwcm9qZWN0LWNvbXBpbGUKICAgICAgICAgIChkZWZhdWx0LWRpcmVj dG9yeSAocHJvamVjdC1yb290IHByKSkpCiAgICAgKGNvbXBpbGUgY29tbWFuZCBjb21pbnQpKSkK IAorKGRlZnVuIHByb2plY3QtLWxpc3QtYnVmZmVycyAocHIpCisgICJSZXR1cm4gYSBsaXN0IG9m IGFsbCBidWZmZXJzIGluIHByb2plY3QgUFIuIgorICAobGV0ICgocm9vdCAocHJvamVjdC1yb290 IHByKSkKKyAgICAgICAgYnVmcykKKyAgICAoZG9saXN0IChidWYgKGJ1ZmZlci1saXN0KSkKKyAg ICAgICh3aGVuLWxldCogKChwYXRoIChvciAoYnVmZmVyLWZpbGUtbmFtZSBidWYpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGJ1ZmZlci1sb2NhbC12YWx1ZSAnZGVmYXVsdC1kaXJlY3Rv cnkgYnVmKSkpCisgICAgICAgICAgICAgICAgICAodHJ1ZSAoZmlsZS10cnVlbmFtZSBwYXRoKSkp CisgICAgICAgICh3aGVuIChmaWxlLWluLWRpcmVjdG9yeS1wIHRydWUgcm9vdCkKKyAgICAgICAg ICAocHVzaCBidWYgYnVmcykpKSkKKyAgICBidWZzKSkKKworKGRlZnVuIHByb2plY3QtLWJ1ZmZl ci1maWxlLW5hbWVzIChwcikKKyAgIlJldHVybiB0aGUgYnVmZmVycyBpbiBwcm9qZWN0IFBSIGFz c29jaWF0ZWQgd2l0aCBhIGZpbGUuIgorICAobWFwY2FyICMnYnVmZmVyLW5hbWUKKyAgICAgICAg ICAoY2wtcmVtb3ZlLWlmLW5vdAorICAgICAgICAgICAobGFtYmRhIChidWZmZXIpIChidWZmZXIt ZmlsZS1uYW1lIGJ1ZmZlcikpCisgICAgICAgICAgIChwcm9qZWN0LS1saXN0LWJ1ZmZlcnMgcHIp KSkpCisKKzs7OyMjI2F1dG9sb2FkCisoZGVmdW4gcHJvamVjdC1zd2l0Y2gtdG8tYnVmZmVyICgp CisgICJTd2l0Y2ggdG8gYSBidWZmZXIgaW4gdGhlIGN1cnJlbnQgcHJvamVjdC4iCisgIChpbnRl cmFjdGl2ZSkKKyAgKGxldCAoKHByIChwcm9qZWN0LWN1cnJlbnQgdCkpKQorICAgIChzd2l0Y2gt dG8tYnVmZmVyCisgICAgIChwcm9qZWN0LS1jb21wbGV0aW5nLXJlYWQtc3RyaWN0CisgICAgICAi U3dpdGNoIHRvIGJ1ZmZlciIKKyAgICAgIChwcm9qZWN0LS1idWZmZXItZmlsZS1uYW1lcyBwcikp KSkpCisKIAwKIDs7OyBQcm9qZWN0IGxpc3QKIAo= --b1_GIguMFWdao1cmdnuAQbvNtwwYsYSZsOR09Qy7s4PE-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 14:31:02 2020 Received: (at submit) by debbugs.gnu.org; 15 Jun 2020 18:31:03 +0000 Received: from localhost ([127.0.0.1]:47503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jktss-00047E-KD for submit@debbugs.gnu.org; Mon, 15 Jun 2020 14:31:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:49352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jktsp-00046l-JW for submit@debbugs.gnu.org; Mon, 15 Jun 2020 14:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jktsp-0005mx-BN for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 14:30:59 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jktsn-00041n-H5 for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 14:30:59 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id B23F05C0118 for ; Mon, 15 Jun 2020 14:30:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 15 Jun 2020 14:30:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= resent-from:resent-date:resent-to:from:to:subject:references :date:in-reply-to:message-id:mime-version:content-type :resent-message-id; s=fm3; bh=5c9qH3/IgMCJ5AHQOgD/0oZwVXXkIBaWsX M5JzHu7y8=; b=deSktiCbyh2iAkUW/eGVqigg03RxriuoKOpMCGlClNIpidA9Ab FxMg/3/Z8XAiE7CYoSLKr9V1pcuNdgXAHmfov/PMAqmptSsRdseO/r2uNQ/O+KSi H6JmNdtwLIRWNIR/uo/IkFrmni/aun/WlnWsoir46tyKY9O1zLSQY6yI9exgJFWH +HTCmyWPGPmYVo8IXGODVm1qmnkLhZ1TIfvQjkKgbF4iVYuKoN73drS1wuKmK0AP C5tzbhjYi2+butOR4JgnDIF3rprwbe6Cw+3hPvvKpNyE9oNTQ2l8ff4B156sgiDu q6p+DoMG/GpZv4dC00xZjkAqfPxk2o4KhJ1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:resent-date:resent-from :resent-message-id:resent-to:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5c9qH3/IgMCJ5AHQO gD/0oZwVXXkIBaWsXM5JzHu7y8=; b=cDSt0pQzR4t7kOhj9bOuelntZYgdADjr6 nvYcU3puymChd/haaDYRsdY4T9RSbisWb9u0zSmiFKWEjgsrMWb40mIwl2m21Xmr XUq1ZraY/5Kq4Bt/eCLYGAoFsCal8oueDShls7C/ZI+D1FYyl8iynVRgzgdiYLf0 Fu9VyBJOwYSnLD9kV9fLKDn7FBntERQ9FHI+iM8Ivp84tzP06MW1zBHB6LGtKPqU vIEWYQhDE0ulPy4ff0sBJ2Z7b+mIHSK9IopmKeuPYqmcijCfj7ZRynnbM/IH7FjP u0TuiStqt6EVpC+IIfjdZ3cBt3UorVX50ZGHvvcXktQ6if38aGP6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeikedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepfdfrhhhi lhhiphcumfdrfdcuoehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrg htthgvrhhnpedukeeuveelgfefieeghfegleetveeihefhteejgfeiudehgedvhfffjefh ffelffenucfkphepjeelrddvudelrdduleelrddvudehnecuvehluhhsthgvrhfuihiivg epudenucfrrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdr nhgvth X-ME-Proxy: Received: from localhost (p4fdbc7d7.dip0.t-ipconnect.de [79.219.199.215]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B35830614FA for ; Mon, 15 Jun 2020 14:30:55 -0400 (EDT) Resent-From: philip@warpmail.net Resent-Date: 15 Jun 2020 20:30:51 +0200 Resent-To: bug-gnu-emacs@gnu.org From: "Philip K." To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> X-Draft-From: ("gmane.emacs.bugs" 181991) Date: Mon, 15 Jun 2020 20:29:52 +0200 In-Reply-To: <87bllk2pfc.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 15 Jun 2020 17:45:53 +0000") Message-ID: <87mu54qj1b.fsf@warpmail.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-RMAIL-ATTRIBUTES: -------- Resent-Message-Id: <20200615183056.0B35830614FA@mailuser.nyi.internal> Received-SPF: pass client-ip=66.111.4.27; envelope-from=philip@warpmail.net; helo=out3-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 14:30:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Cool! Just note that in the following patch I renamed the function to project--buffer-list, so that it looks and acts more like buffer-list. Sorry for the inconvenience though, didn't expect anyone to pick the function up that quickly. -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 16:55:29 2020 Received: (at 41879) by debbugs.gnu.org; 15 Jun 2020 20:55:29 +0000 Received: from localhost ([127.0.0.1]:47588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkw8c-0001Gm-4a for submit@debbugs.gnu.org; Mon, 15 Jun 2020 16:55:29 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:39786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkw8a-0001GZ-9s for 41879@debbugs.gnu.org; Mon, 15 Jun 2020 16:55:24 -0400 Received: by mail-wm1-f54.google.com with SMTP id t194so951948wmt.4 for <41879@debbugs.gnu.org>; Mon, 15 Jun 2020 13:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MLfh/96Mn0ilu2SzXgXTGeQhGXjD6R39hxjG1MxJ2mY=; b=HSpLgzRhBedy05xejxWbD8KI2pZ2frHivpSU5fKhTKbkdBsg+zjU76rotPU6Y+DD7Y txrKaE9qIfZMsRh0jMhw2/AXMlUUH2FSfwrek3h1endZw0kuAyX+emyCHpzYspi8GZ0S 2FvSmy5NzOCDKtqdniKh40Jfnnuu3fgz2cg2tCQHuealjxB/tGZ2vaMtnwPISs/NEJ6H d7TvWOr5FYLqhoI4SpQCYS5p/QXf7dyvQLlFcZdiYrYo/+dYGkiuZ7WMqNLqU7D68hjJ WlEz/XzQ+qZ1cwb1IuxTWSO3cdthSIRIlB0HdoDov6woislUPKTEV2pmD9TwixnEWh+m wc+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MLfh/96Mn0ilu2SzXgXTGeQhGXjD6R39hxjG1MxJ2mY=; b=Dz8YdiDjQYwNIJAQdMr712Ny+9SFt7KNIxxug4l59TbWENf4R42PPRBw8qXHgYnlGt n/YdLNtm7ankZLrV5n8rcjDYgMyh7RxPCnJ5DC8A2B0KKkTPv7QL8Qox1knO/gzJxX7i AZ3Q8L92axYgGqSLC4H0St3ulGQEYtqdZVXdxtSf7HxWXrlP/xLsA+OZVfb9YgN+JhKv o/ecWl/FzcpIXTWt2zgf40rqOXlOVr8ePd+q53RyLk9wtY3EgihGnTn9SCYLzBflBa9D zfD3dWAh7GagbFEFOIQxnobPOA+xKvKv5LY7qSiYHMehZAK5k/4oqgn2GtM5x9muZarH AzLA== X-Gm-Message-State: AOAM530FmOT8emqcymrR8wkkT6PZ8ytZc0RwzaGe1jlG/PYn7z6W0XHI 7Lq60YyvRA0RTo26s61U+nj+2vHh X-Google-Smtp-Source: ABdhPJxrXbhrorlCGvv5hPdGjYfuxKzulEbMMh9dzcHFZE4Gay86MIICoE2LzsAjTuaUYB3OJ4PJWg== X-Received: by 2002:a7b:c385:: with SMTP id s5mr1181530wmj.121.1592254518187; Mon, 15 Jun 2020 13:55:18 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id d11sm26657767wrm.64.2020.06.15.13.55.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 13:55:17 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Theodor Thornhill , 41879@debbugs.gnu.org References: <87bllk2pfc.fsf@thornhill.no> From: Dmitry Gutov Message-ID: Date: Mon, 15 Jun 2020 23:55:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87bllk2pfc.fsf@thornhill.no> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 15.06.2020 20:45, Theodor Thornhill wrote: > I find this useful, and hope others will as well. I bind it myself to 'C-x p b'. Sounds good. > The 'project--list-buffers' will not be part of the final patch, but I wanted to provide it so that you have a working example. I see that the code uses project--completing-read-strict. I'm not entirely happy with that function, yet. Have you tried calling read-buffer with a PREDICATE argument instead? That would require extracting some code from project--list-buffers (defined in Philip's patch), but it should be straightforward. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 18:06:12 2020 Received: (at 41879) by debbugs.gnu.org; 15 Jun 2020 22:06:12 +0000 Received: from localhost ([127.0.0.1]:47621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkxF6-0002xy-Hf for submit@debbugs.gnu.org; Mon, 15 Jun 2020 18:06:12 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:63047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkxF2-0002xi-4U for 41879@debbugs.gnu.org; Mon, 15 Jun 2020 18:06:10 -0400 Date: Mon, 15 Jun 2020 22:05:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592258761; bh=Fy8jK36mufNUy6hoSv5BrxrJqSw0wF28DWhfnS43M0o=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:From; b=P8DNoQv7rLnfS0nAFVKLpGlaVRfNiev6MD7DcilTPZCAbb2nhZhJZT9J1GvGQDuYb 28HuJutMIW9ni9UXpwqIEOjdyPzRkrix32FLim87ogiQ8ArzYE3/IsNilCvA65sieq s3ntSVzBrmIX4ySRuZGGRntMu8fQrSicKfj1jSKtPyCRCe6+FmAmFp0OsXA/6ybmUa vue6udeW6BrDzvO8Mh5ZGstq4rkXmwfbGgjXfoaULQyKUg9Ev5dHkVlFq/yfvV/loh IQSKSPJv8DiMFneqH7yr3E0lRcukmlkFVVvsSM/e6lei0VD3ig6NCiPR2iClTOoukE aSAdR8HlYn1/A== To: Dmitry Gutov , 41879@debbugs.gnu.org From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87sgew7zni.fsf@thornhill.no> In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Aw1Jz2JkpNdzHIdWju17VI34GUDAhLSXFrfrZQEO584" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_Aw1Jz2JkpNdzHIdWju17VI34GUDAhLSXFrfrZQEO584 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey, "Dmitry Gutov" writes: [...] > I see that the code uses project--completing-read-strict. I'm not > entirely happy with that function, yet. Ok, I just thought I'd use something already written :) > > Have you tried calling read-buffer with a PREDICATE argument instead? > That would require extracting some code from project--list-buffers > (defined in Philip's patch), but it should be straightforward. The attached patch works fine, and is also not reliant on Philip's patch. I= omitted the DEF argument, since then I had to do the filtering beforehand,= and also in the PREDICATE function. Just seems a little redundant to me, b= ut maybe it should be there The complete patch is a lot smaller now as well! What do you think? Theo --b1_Aw1Jz2JkpNdzHIdWju17VI34GUDAhLSXFrfrZQEO584 Content-Type: text/x-patch; name=pr-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=pr-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IDIxODA1OGIxOTUuLmZhNTBiYmU1N2IgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzUzLDYgKzc1MywyMCBAQCBwcm9qZWN0LWNvbXBpbGUKICAgICAgICAgIChkZWZhdWx0LWRpcmVj dG9yeSAocHJvamVjdC1yb290IHByKSkpCiAgICAgKGNvbXBpbGUgY29tbWFuZCBjb21pbnQpKSkK IAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBwcm9qZWN0LXN3aXRjaC10by1idWZmZXIgKCkKKyAg IlN3aXRjaCB0byBhIGJ1ZmZlciBpbiB0aGUgY3VycmVudCBwcm9qZWN0LiIKKyAgKGludGVyYWN0 aXZlKQorICAobGV0KiAoKHByIChwcm9qZWN0LWN1cnJlbnQgdCkpKQorICAgIChzd2l0Y2gtdG8t YnVmZmVyCisgICAgIChyZWFkLWJ1ZmZlcgorICAgICAgIlN3aXRjaC10by1idWZmZXI6ICIgbmls IG5pbAorICAgICAgKGxhbWJkYSAoYnVmZmVyKQorICAgICAgICAod2hlbi1sZXQqICgocGF0aCAo YnVmZmVyLWZpbGUtbmFtZSAoY2RyIGJ1ZmZlcikpKQorICAgICAgICAgICAgICAgICAgICAodHJ1 ZSAoZmlsZS10cnVlbmFtZSBwYXRoKSkpCisgICAgICAgICAgKHdoZW4gKGZpbGUtaW4tZGlyZWN0 b3J5LXAgdHJ1ZSAocHJvamVjdC1yb290IHByKSkKKyAgICAgICAgICAgICdidWZmZXIpKSkpKSkp CisKIAwKIDs7OyBQcm9qZWN0IGxpc3QKIAo= --b1_Aw1Jz2JkpNdzHIdWju17VI34GUDAhLSXFrfrZQEO584-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 19:38:32 2020 Received: (at 41879) by debbugs.gnu.org; 15 Jun 2020 23:38:32 +0000 Received: from localhost ([127.0.0.1]:47665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkygR-0007Ld-Nf for submit@debbugs.gnu.org; Mon, 15 Jun 2020 19:38:32 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:42319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkygQ-0007LR-1D for 41879@debbugs.gnu.org; Mon, 15 Jun 2020 19:38:30 -0400 Received: by mail-wr1-f51.google.com with SMTP id p5so18831059wrw.9 for <41879@debbugs.gnu.org>; Mon, 15 Jun 2020 16:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YfVWW0vwPpoj06W3o9tlAnzZOlsxfJWjgS8oWjqp3WM=; b=L+XbCxdeqO9ZQu/OpRj7jkj6TLva2QRLzn/bGw85aCssT1s0vyDVTiiqXmdbGgypIl 23h/p8AfKDdpGRD1CTET5+gSocDGy1aQiTAM7uc+goXTpB3EfXKtOls2cZZsHHnjuNlz gKFrkaj3slORV/kRsdQVbNH0pmPsCCceKVz+F8y1KgqzD/mqF6WiKJiZoCytzXN0p/Um 9cEbb16xoCmDOagsxmi55NUN/JeZyPbBIuXA2x4vgF4SCEysSuPtYMvhZOwx5L7/+Hjx 1X+snE44zTbTn0vcrkYdbXmUj/ZtaZeiEbMqsjjJxhsj91wPtEIspALwH/TQuzadqGXu Fvbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YfVWW0vwPpoj06W3o9tlAnzZOlsxfJWjgS8oWjqp3WM=; b=un2ivuFjV8HSjo1CN22wRqKk+7oRLtpqPzI039WnH5KN8e97pNeIBNjIPGam2PF+7K Ct47YiL2GfbHH+IWISsv4QOceib+ik6lCrTi8/3boRmOcXc2hwLnmyKPLmUQfNuvWH4t 2vawozwAmg8Xgm37cloiTF0/9BUraqJfUrtiuEjdYJTDBLVQkYTSCigP4LaJRNa0VJDU 9dgwieu87C2Qjs2zR9xnzNUxdhi87awyOJ0wug2fWeRGER24Hemq0I7WYhcMkHjdaexk KFapkBiClTirIryriQuGVozd14WCsKKbzxPwjMZQSN3jxAD55y73bojjwMbtdY95PzJh bwow== X-Gm-Message-State: AOAM531BqVQ0vYcCc+sog9KYqWIlCWjm/6z1wU2BqSXzk4lgZHJ8YpeW n9UJ3Ub2a0a5Ae5LB4JlXI2TV1PF X-Google-Smtp-Source: ABdhPJxV0UU8ejpijgevinsp4bBrX9wdt+3vgV99z3TNgUhyFalyqcQMQWUAdS+6Ewpm+VJCsxQqDg== X-Received: by 2002:a5d:5303:: with SMTP id e3mr30786412wrv.321.1592264303747; Mon, 15 Jun 2020 16:38:23 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id z7sm25956313wrt.6.2020.06.15.16.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 16:38:23 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Theodor Thornhill , 41879@debbugs.gnu.org References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> From: Dmitry Gutov Message-ID: <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> Date: Tue, 16 Jun 2020 02:38:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87sgew7zni.fsf@thornhill.no> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Thank you. On 16.06.2020 01:05, Theodor Thornhill wrote: > What do you think? A few more notes. :-) > + "Switch-to-buffer: " nil nil The REQUIRE-MATCH argument should be t, I think. > + (lambda (buffer) > + (when-let* ((path (buffer-file-name (cdr buffer))) The word "path" is reserved for something else (e.g. exec-path) in the GNU project. Call it file or file-name. > + (true (file-truename path))) Do we need this conversion? It'll add some runtime overhead, and I'm not sure in which conditions the result will be different. > + (when (file-in-directory-p true (project-root pr)) > + 'buffer))))))) Why 'buffer and not t? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 20:03:02 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 00:03:02 +0000 Received: from localhost ([127.0.0.1]:47694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkz4A-0007xW-7x for submit@debbugs.gnu.org; Mon, 15 Jun 2020 20:03:02 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:39203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkz48-0007wa-D4 for 41879@debbugs.gnu.org; Mon, 15 Jun 2020 20:03:00 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 6AE6960002; Tue, 16 Jun 2020 00:02:52 +0000 (UTC) From: Juri Linkov To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Organization: LINKOV.NET References: <87bllk2pfc.fsf@thornhill.no> Date: Tue, 16 Jun 2020 02:10:23 +0300 In-Reply-To: <87bllk2pfc.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 15 Jun 2020 17:45:53 +0000") Message-ID: <87k107c3wo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > However, attached is a patch for project-switch-to-buffer, where only > file-bound buffers are included. I believe the function should be > kind of self explanatory. > > I find this useful, and hope others will as well. I bind it myself to 'C-x p b'. Nice, I consider your new project-switch-to-buffer as an accompanying command with the existing project-find-file (that could get a keybinding too, the most natural would be 'C-x p f'). From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 20:21:38 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 00:21:38 +0000 Received: from localhost ([127.0.0.1]:47710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkzMA-00025s-GJ for submit@debbugs.gnu.org; Mon, 15 Jun 2020 20:21:38 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:37172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkzM7-00025c-Vv for 41879@debbugs.gnu.org; Mon, 15 Jun 2020 20:21:36 -0400 Received: by mail-wm1-f50.google.com with SMTP id y20so1318790wmi.2 for <41879@debbugs.gnu.org>; Mon, 15 Jun 2020 17:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iUxqcx3XlGqibqvRo8Ycj+HNnAEzXob/+lDwYF0E6Y8=; b=Fq6KayjK7njJlhv7bzclqqkTHFSxU0zPiyQ4EHxCegxbC8NcSho676nrA9V/3LJ3zQ 3sQVlORw/qUpSMBJO2Ov2Pbc3qqJm3bptv4IaSMpmOPIo045A3Vg2wThyTr1c3lbXyUZ ooHHOiRvffE2KvMzFL2pn/a+ImcBYiwSan8vh1KZSiHBUM9izOvH4B7Lvk2akfsr+Ysg LDDIWoApBKRJUcCqs1ivawybNruDo6d/K0/KKZfS0+x1oHE/nsai2LFxYR0NwuZj5JoX 3rugAhCqjv1HVGvUV8n+QCEWzCWhBLNv87I6F39BJeeI8LxMTZUeVaMR52icsF890ejX WOJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iUxqcx3XlGqibqvRo8Ycj+HNnAEzXob/+lDwYF0E6Y8=; b=M8d2AijwMflOfoGHvdokrCn6o7Ge4i5mF95n/od/8g3fHERo68IFYj+djB4MCEc5lY HM93EYZBSpED1oesT1lobgIypEzqyT/VD30TcIjGsVvBwX+iziRrxuglm34hFKIA0SlE 6Z/PGDV3g3mf8t64qK6Hjk4gjb8WmD3LzlyIZwGOl3i//vHzwlpZIYdmDLyWZ6Xpab4D S9SGPPEqeQlEFCGDwgW0D+8hbDv0ltKCyIADz3Am6oNMI99S+Nr3uOohTwAXVQXUL/GB BEKN3PQ8Uj53/rjazY75XfRaDggljxg/gc2Rj0+HMNIU1pY/TMRmUaYImlGy48Z40k+F eZEw== X-Gm-Message-State: AOAM530hw0mExvz5PPVG0qce5cdpJXkqMJrTjP0j37UfR9+4IS+I2oXc 5FpWdSoBO69/xwLXHYpPLa0nT2hq X-Google-Smtp-Source: ABdhPJyMAB/kAC6qXpgDzCQ+g6TJFT2Qqb3YEvM1ZjqRgDQislcfnEmutmz5tHF7OxjNP71Rd+aS3w== X-Received: by 2002:a05:600c:2945:: with SMTP id n5mr375772wmd.189.1592266889694; Mon, 15 Jun 2020 17:21:29 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o15sm27219067wrv.48.2020.06.15.17.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 17:21:28 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Juri Linkov , Theodor Thornhill References: <87bllk2pfc.fsf@thornhill.no> <87k107c3wo.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6accee1d-64e7-c18f-553d-117a63a1bd5a@yandex.ru> Date: Tue, 16 Jun 2020 03:21:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87k107c3wo.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.06.2020 02:10, Juri Linkov wrote: > Nice, I consider your new project-switch-to-buffer as an accompanying > command with the existing project-find-file (that could get a keybinding too, > the most natural would be 'C-x p f') Would you like to create a patch that adds a global keymap for project related commands? I've been putting it off myself. The question I've been considering: Do we keep it in project.el or somewhere outside? Maybe the latter, since project.el is also an ELPA package, and we generally don't want packages to alter Emacs' key bindings right after installation. OTOH, if the prefix is customizable, that can also be fine. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 01:45:50 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 05:45:50 +0000 Received: from localhost ([127.0.0.1]:47987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl4Pu-00043x-8k for submit@debbugs.gnu.org; Tue, 16 Jun 2020 01:45:50 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:42157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl4Pr-00043i-JK for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 01:45:48 -0400 Date: Tue, 16 Jun 2020 05:45:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592286340; bh=5sAmovjM1YBM8YPhG3sgrqSQ3XTKDUFqfaok56EPlE8=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:From; b=eV6WUUe1HQWRAEEo8PUtG+QJKpj9uW8S85RZ0wjrf+3TciDyv/B8FLSW3ylF0Eabq RY13IHxTe5Fw0GpgdreXHYspH9q0PaniJw47CfhVau3D222Pe5Q1s4lYvdyJypFFSq G86MCNVOO3xCTM60pQNxJC2Krs+pkdMhhO+so5CCSUcGhQvc9Zp2LKQoof7Pb4Q/HH rxcnzqVV0YWutSTmi3bHe0eEOma4GuHdHViHDo519M6Kf1A7zG34PVxQVtyGUVjo/V SwUs6MYIx9QIqUTwOsiECyab8jZQaMB2XLHFYQDI8p3z2qnC/ztaEB6YP8Ew/IDj5X Zk1ZeZtdjqudQ== To: Dmitry Gutov , 41879@debbugs.gnu.org From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87o8pj8sy2.fsf@thornhill.no> In-Reply-To: <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_zTWe9aRO31eB4k9l5ZyILAIDH9O5OI7h6uuq5mTmMA" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_zTWe9aRO31eB4k9l5ZyILAIDH9O5OI7h6uuq5mTmMA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks alot for your comments! "Dmitry Gutov" writes: [...] > The REQUIRE-MATCH argument should be t, I think. Done. > > + (lambda (buffer) > > + (when-let* ((path (buffer-file-name (cdr buffer))) [...] > Call it file or file-name. Done. > > + (true (file-truename path))) > > Do we need this conversion? It'll add some runtime overhead, and I'm not > sure in which conditions the result will be different. I removed it, seems to work fine :). > > + (when (file-in-directory-p true (project-root pr)) > > + 'buffer))))))) > > Why 'buffer and not t? I just figured it as readable, but t is there now! Theo --b1_zTWe9aRO31eB4k9l5ZyILAIDH9O5OI7h6uuq5mTmMA Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IDIxODA1OGIxOTUuLjMwZDFkNWEzZGQgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzUzLDYgKzc1MywxOSBAQCBwcm9qZWN0LWNvbXBpbGUKICAgICAgICAgIChkZWZhdWx0LWRpcmVj dG9yeSAocHJvamVjdC1yb290IHByKSkpCiAgICAgKGNvbXBpbGUgY29tbWFuZCBjb21pbnQpKSkK IAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBwcm9qZWN0LXN3aXRjaC10by1idWZmZXIgKCkKKyAg IlN3aXRjaCB0byBhIGJ1ZmZlciBpbiB0aGUgY3VycmVudCBwcm9qZWN0LiIKKyAgKGludGVyYWN0 aXZlKQorICAobGV0ICgocm9vdCAocHJvamVjdC1yb290IChwcm9qZWN0LWN1cnJlbnQgdCkpKSkK KyAgICAoc3dpdGNoLXRvLWJ1ZmZlcgorICAgICAocmVhZC1idWZmZXIKKyAgICAgICJTd2l0Y2gt dG8tYnVmZmVyOiAiIG5pbCB0CisgICAgICAobGFtYmRhIChidWZmZXIpCisgICAgICAgICh3aGVu LWxldCAoKGZpbGUgKGJ1ZmZlci1maWxlLW5hbWUgKGNkciBidWZmZXIpKSkpCisgICAgICAgICAg KHdoZW4gKGZpbGUtaW4tZGlyZWN0b3J5LXAgZmlsZSByb290KQorICAgICAgICAgICAgdCkpKSkp KSkKKwogDAogOzs7IFByb2plY3QgbGlzdAogCg== --b1_zTWe9aRO31eB4k9l5ZyILAIDH9O5OI7h6uuq5mTmMA-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 02:11:58 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 06:11:58 +0000 Received: from localhost ([127.0.0.1]:48029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl4pB-0004jZ-Qc for submit@debbugs.gnu.org; Tue, 16 Jun 2020 02:11:57 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:35349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl4p9-0004jH-M5 for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 02:11:56 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id ACE99715; Tue, 16 Jun 2020 02:11:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 16 Jun 2020 02:11:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=fm3; bh=uwZw7n1tM4D676kdRF2FqVjs81 OIht2dps0K1BcBSGw=; b=HIcqOKz1wX1RiYjU/+/cKarCG8o97Om//xgLreOrIN T9dmK4Tm0zPuU699oNy/x/Lm/EOC/45xWT6aKBrjywE9RBlkollsFKYYVUOCU6VH I/fmt4Z+YdXfemL8iYM3cUERVbh7FgAjU5txrI2X7AUP46ezNxK+ccQAtVhMn2On npSkSK06jqc2q2mVryQxTI2eGRKLFmssk8fg0q5kdgrmmeJgfq4p6U9GY11gqw8t ud1mVwDN9lmR8jrkRSRzk49tdMPLY2MXpkqV7T7CvZDRv2+k+Uk7HZaDaMIpgVi/ m6KCJpkc4xG5ryXW0ohfbtR9g0t0n/dJqT0sbG6RdEcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uwZw7n 1tM4D676kdRF2FqVjs81OIht2dps0K1BcBSGw=; b=sOW609rs8qbGovnEW+pNNs +6GNcQErzJ5U2KjVluBGlSD1WJkw3Vqw/W5qqGUutsCKmmRURTLtqiSI4QG6ED+C WlLHlhcVahDVr9ei4u2KEFaXPN+BAyL/vr9TR5B3mAqEQd5CwW2zzOYEcxXFJKJW jz5H2kTam41IY2HyA2LPkCbvwm+dAAxrwH9anc/DW06n2TI18lNjIhjOXcsRGPtx UdpclATFa9wF7eyo+QRr85sTeI/ZKQzmiSPq+iIfSIS6e4t8x/g+jus3vAX57oDE a3nYWTplaQfGgFp+GsUZ/etU4M8l7UKtUFDhI3aoXc4a85cQ4aW8+9BjWURCi77g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeiledguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepfdfrhhhi lhhiphcumfdrfdcuoehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrg htthgvrhhnpedukeeuveelgfefieeghfegleetveeihefhteejgfeiudehgedvhfffjefh ffelffenucfkphepjeelrddvudelrdduleelrddvudehnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdr nhgvth X-ME-Proxy: Received: from localhost (p4fdbc7d7.dip0.t-ipconnect.de [79.219.199.215]) by mail.messagingengine.com (Postfix) with ESMTPA id C059F3060F09; Tue, 16 Jun 2020 02:11:48 -0400 (EDT) From: "Philip K." To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> Date: Tue, 16 Jun 2020 08:11:46 +0200 In-Reply-To: <87o8pj8sy2.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 05:45:34 +0000") Message-ID: <87d05zr13x.fsf@warpmail.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Theodor Thornhill writes: > +;;;###autoload > +(defun project-switch-to-buffer () > + "Switch to a buffer in the current project." > + (interactive) > + (let ((root (project-root (project-current t)))) > + (switch-to-buffer > + (read-buffer > + "Switch-to-buffer: " nil t > + (lambda (buffer) > + (when-let ((file (buffer-file-name (cdr buffer)))) > + (when (file-in-directory-p file root) > + t))))))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Shouldn't this just be (file-in-directory-p file root), without the (when ... t)? -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 02:49:15 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 06:49:15 +0000 Received: from localhost ([127.0.0.1]:48111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl5PH-0005gy-72 for submit@debbugs.gnu.org; Tue, 16 Jun 2020 02:49:15 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:23877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl5PD-0005gj-Bt for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 02:49:13 -0400 Date: Tue, 16 Jun 2020 06:49:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592290144; bh=Jrx5ZPaP+cQbAh2uA1lLTrzw2Su33wTsUmrjl39hXME=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=CFCU71kkYb/IlzGrCllArKnnrcdihgRLQW7go1f848qGrP6nffiSNIywwchuufS51 arNzph/FjDr5wSS9St0qdAUho6ERppEyA6EjnnvoKI8VyU4tZlwfgoMPq9lbGIXjM3 2PRg7Re6okv/cfYFDGrH2A8mr1VgbkH7Yp41NMFxgQtmW8n7rb1NfH9YUxgga3kEQ1 vLx2eVrZ6Z+rsugk60ISIhMvQkYRbP/xFIPzuF1hTlmFDTGJu6P6YWvR6fbcy+0yj6 4FELvu6k+3gEH73z5gq2sBioNFW3ZAKgU09ruLHP97AMwTZFOVtvFAoWhFeHFhfoLI sreZ3COn9yXsg== To: "Philip K." From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87lfkn8q0a.fsf@thornhill.no> In-Reply-To: <87d05zr13x.fsf@warpmail.net> References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_5OKWwLNUm3I9QN8bXTLgQcGjMWrL6I4akXQrKDZrnb8" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_5OKWwLNUm3I9QN8bXTLgQcGjMWrL6I4akXQrKDZrnb8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! "Philip K." writes: [...] > Shouldn't this just be (file-in-directory-p file root), without the > (when ... t)? Yes! Thanks a lot :) Theo --b1_5OKWwLNUm3I9QN8bXTLgQcGjMWrL6I4akXQrKDZrnb8 Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IDIxODA1OGIxOTUuLmE2MWIyOWFiZTYgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzUzLDYgKzc1MywxOCBAQCBwcm9qZWN0LWNvbXBpbGUKICAgICAgICAgIChkZWZhdWx0LWRpcmVj dG9yeSAocHJvamVjdC1yb290IHByKSkpCiAgICAgKGNvbXBpbGUgY29tbWFuZCBjb21pbnQpKSkK IAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBwcm9qZWN0LXN3aXRjaC10by1idWZmZXIgKCkKKyAg IlN3aXRjaCB0byBhIGJ1ZmZlciBpbiB0aGUgY3VycmVudCBwcm9qZWN0LiIKKyAgKGludGVyYWN0 aXZlKQorICAobGV0ICgocm9vdCAocHJvamVjdC1yb290IChwcm9qZWN0LWN1cnJlbnQgdCkpKSkK KyAgICAoc3dpdGNoLXRvLWJ1ZmZlcgorICAgICAocmVhZC1idWZmZXIKKyAgICAgICJTd2l0Y2gt dG8tYnVmZmVyOiAiIG5pbCB0CisgICAgICAobGFtYmRhIChidWZmZXIpCisgICAgICAgICh3aGVu LWxldCAoKGZpbGUgKGJ1ZmZlci1maWxlLW5hbWUgKGNkciBidWZmZXIpKSkpCisgICAgICAgICAg KGZpbGUtaW4tZGlyZWN0b3J5LXAgZmlsZSByb290KSkpKSkpKQorCiAMCiA7OzsgUHJvamVjdCBs aXN0CiAK --b1_5OKWwLNUm3I9QN8bXTLgQcGjMWrL6I4akXQrKDZrnb8-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 06:26:15 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 10:26:15 +0000 Received: from localhost ([127.0.0.1]:48353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl8nH-0002Wv-H0 for submit@debbugs.gnu.org; Tue, 16 Jun 2020 06:26:15 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:39732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl8nE-0002Wh-Qd for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 06:26:13 -0400 Received: by mail-wm1-f52.google.com with SMTP id t194so2493138wmt.4 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 03:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uEmO+kgCoi5xZXnMy2WSWelhhAFDZjpVEPETDh/ixek=; b=MYopT6ol+S0qiMGVoKWK6j2vxvF4cvqgj77yEZCdYKVFqEn7L9z15PGmIj7vZhtjaO W2PoRTC2w25c0cNWz5J7wvf4WxCq8+s61m/KXDS3QUpFBkJYUYTBQCmaSYgZIhM6aqVi sUoHkaUCBWQVTp8c35aI/ru4i5uFRx/uu7HGdaO1BcmENhdsAyK5Rh55JnhooJ3JhE69 QHcVf5jrlk60KF9fi9lAFYKclYoKWzuZVf0bLle0e/jQRYU+2f5MgzB1lB9V0wY9iIaS p5msmmCCxT/3euoo37X7VTCR/RfleSnwfVGMAdo1AxMGGLRykDwMBsojjxJdpwSmZy07 E+Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uEmO+kgCoi5xZXnMy2WSWelhhAFDZjpVEPETDh/ixek=; b=j7WzYaoIrHqhA9bTxG4GMmeMDksx3dvYXDEvJLpWweV2r53eKGHUsprGWQ56ZI4N/O 8KvQVKFmqk8rUMOeU/bSihsNEDDZDsDHYJpZXcqPMFBibUv9lzzm1G5o3Wyt2wit/KIa feAJ/JT8IyVqyK8az6ziL4UdGwDnSlqn87+ajlYvpMU52rJNn3/RRY7twr1tCPfbznev MCmhFoJBVXZlzNBPrr3Un3L2aJcbTwrO7LEDME7SSWbQHRzwq5T7joPiJ3AXlwrMPGWB QJFlT7qM8+a1mVp6tNgxxMzXNntJ9niWcMkpkHkfDYimW1F5y1k42vuWZEstOrObdVgd 7bWg== X-Gm-Message-State: AOAM530HY5J6SgwO7zZX1cb10iW/vdTAm2zr+HMBWp7Q98qf4IDAnKSU n/JnwF73/hkx1+uZWf7+QNDB3A== X-Google-Smtp-Source: ABdhPJwAFqeYo/+wAWLnHaApdxH19EiPsFYxXNSb2A2VQPZ0/UQT7MIdJuqc9xI7jWfW+6LQakz/Xg== X-Received: by 2002:a7b:c246:: with SMTP id b6mr2361883wmj.96.1592303166871; Tue, 16 Jun 2020 03:26:06 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id 4sm23154287wrf.74.2020.06.16.03.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 03:26:06 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> Date: Tue, 16 Jun 2020 11:26:04 +0100 In-Reply-To: <87lfkn8q0a.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 06:49:01 +0000") Message-ID: <87mu53i9xf.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 218058b195..a61b29abe6 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -753,6 +753,18 @@ project-compile > (default-directory (project-root pr))) > (compile command comint))) > > +;;;###autoload > +(defun project-switch-to-buffer () > + "Switch to a buffer in the current project." > + (interactive) > + (let ((root (project-root (project-current t)))) > + (switch-to-buffer > + (read-buffer > + "Switch-to-buffer: " nil t Nit: For consistency with switch-to-buffer, this should be "Switch to buffer: " without the hyphens. > + (lambda (buffer) > + (when-let ((file (buffer-file-name (cdr buffer)))) Nit: Neither the manual nor read-buffer's docstring documents what (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something along those lines would be nice. > + (file-in-directory-p file root))))))) > + Otherwise LGTM, thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 09:29:35 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 13:29:35 +0000 Received: from localhost ([127.0.0.1]:48498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlBeh-0000bA-Et for submit@debbugs.gnu.org; Tue, 16 Jun 2020 09:29:35 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:53743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlBed-0000aw-W1 for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 09:29:34 -0400 Date: Tue, 16 Jun 2020 13:29:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592314165; bh=XptfQj7nUfX2YGMAdyCAfz5MzKMxHYWPSd0YbFx/k3I=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=sEzUCDP/aFnMvrVN1SywzIJs/zEWC8UGNY51x3NqsZ+3VVg96k4/TQ874eBm/tD5R KRBWlv9S7h1vumJTVjInRshIqyGJbpmz3yX+eExjNX94WtMaqDUdaevvpDV5A/QN8v EUOOvnangAuuYbKnFlRXcmF7HQZz6QeQt/A+BIHaBU1+0h9uupSSS5hSRVUJW9pWxO y9dXC8gY1qxFTlAecKkcBYPQbhMM5sPLe9WSsJHmATUL+Bggs+3gVmb7zapGAjuNHf WSlhlQFhhWYF5TCjz7yFoNIYXHJ1hjNXKtD3ZjZL6yJolDDb78QQCVV6vpxZKOwf98 o2UWrbAPYqRMg== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87o8pjkuld.fsf@thornhill.no> In-Reply-To: <87mu53i9xf.fsf@tcd.ie> References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello! "Basil L. Contovounesios" writes: [...] > Nit: For consistency with switch-to-buffer, > this should be "Switch to buffer: " without the hyphens. Yes, absolutely! >> + (lambda (buffer) >> + (when-let ((file (buffer-file-name (cdr buffer)))) > > Nit: Neither the manual nor read-buffer's docstring documents what > (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something > along those lines would be nice. It kind of does, though indirectly? But sure, I can add a small comment. Documentation states that: "It will be called with each potential candidate, in the form of either a string or a cons cell whose =E2=80=98car=E2=80=99 is a string, and should r= eturn non-nil to accept the candidate for completion, nil otherwise." [...] > Otherwise LGTM, thanks, Nice From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 10:02:23 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 14:02:23 +0000 Received: from localhost ([127.0.0.1]:49318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlCAR-0001af-Bh for submit@debbugs.gnu.org; Tue, 16 Jun 2020 10:02:23 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:46519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlCAP-0001aQ-74 for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 10:02:22 -0400 Received: by mail-wr1-f45.google.com with SMTP id x6so20860915wrm.13 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 07:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Dw/8FMtR6Ldg4m843VTQC38S0wKLt77Ivf0fIe9Ckfk=; b=etF/Ew+SnfBi1683hd6taFWZRasBnACaG3UJqunlS1qSbjNNOgIgUvR6CPVV6EHycT h3gRfGucTTe9YtE6EMIRQlGBQhQFXqkP1qkT2hZTRcHEXvdyp4hEhcbNZ4pbA0ePbXZt 9BAmb17GaS7O6HVPFCNVf2/MR1p0K+ITedxQINMBjimZEa3VAgVriNYtspNuo/rlfP+a arsGAiQ1dDjzk9Vslpe9Osls22Q8NxaViZu1weLKIP+kfezz182cCtmk4C0OUyy+UfVM b+znRkfZVDOjvo6u4azrSlZdPGWpTMlzUJRf0OLf5xXUCgaZ5wbNiBJP/7NRJH/RwTyj 7F0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Dw/8FMtR6Ldg4m843VTQC38S0wKLt77Ivf0fIe9Ckfk=; b=Z/WOQXFzSAXaV5gYKJJByUsGP/i73Y/h+luLSoblkoH/uDvLSr4z8XpkZ/MBZbxkZc z2yPdg70vjQmnjxW30csCUZtmc9/wuGyoW5lvrtdqxJdnqp8JdNh/vKnpwBGzCwuGyj0 Wp1EfDQwYVtWgk6nP1hxiCkgy8XKZwMS6IWLw7tEFMr8BbcOUxKk2+VnQkwCPeXlsqlP igIGRckwDM6NKyiM077vKkiQmotyQWYmAlGHeIWCwDI5QrHBOIn7wwDEa/afYL8RSuv4 Yo4MUI36faQkg4iD2Nkz6Gz53UOBnRBb/Po+Jb/hmG2vHTmfyigQ/ODpoF9BsHjTuQ/Q OqBQ== X-Gm-Message-State: AOAM5336BpcvNJSnFnz7ULMIaFOhtDbTSOC8wvEnl6XbeBPNIsXedI13 Yri2CvNpC0wYQ6a6MIeZosFUsg== X-Google-Smtp-Source: ABdhPJxkbIOzZLQ5t0Z7r+2hTmOQ3UoXTe9fqZeTng4vb2X+mHERMqQqGZWD8l2MYnKZd17ZWRpsvQ== X-Received: by 2002:adf:f003:: with SMTP id j3mr3262440wro.228.1592316135138; Tue, 16 Jun 2020 07:02:15 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id d18sm28559510wrn.34.2020.06.16.07.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 07:02:14 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> Date: Tue, 16 Jun 2020 15:02:13 +0100 In-Reply-To: <87o8pjkuld.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 13:29:19 +0000") Message-ID: <87366vun16.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: >>> + (lambda (buffer) >>> + (when-let ((file (buffer-file-name (cdr buffer)))) >> >> Nit: Neither the manual nor read-buffer's docstring documents what >> (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something >> along those lines would be nice. > It kind of does, though indirectly? But sure, I can add a small comment. > > Documentation states that: > > "It will be called with each potential candidate, in the form of either a > string or a cons cell whose =E2=80=98car=E2=80=99 is a string, and should= return non-nil to > accept the candidate for completion, nil otherwise." I know, but this says nothing about the cdr. --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 12:53:13 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 16:53:13 +0000 Received: from localhost ([127.0.0.1]:49498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlEpk-0005rv-UT for submit@debbugs.gnu.org; Tue, 16 Jun 2020 12:53:13 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:51703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlEpi-0005rh-MM for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 12:53:11 -0400 Date: Tue, 16 Jun 2020 16:53:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592326384; bh=Wz3sskNNt3XkhB5ZJ+6qep5tD07/Pw8H64FDcSSO2Vs=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=rTw4nRFG0awW62YRerVO8Br7bpD8cXKiCKu4HlFcabxELy9iWzEhWfGjyrLZ+/kEO w43iObP17kCRHcfeDg144bspuFMga8kfsWimqI0SJj3O9I2XRtHL1bhTVy9SzFBKEJ zsqMhgviK9WWdopKZZ5Fq/3CqnO+WGDOVW7I7pyfbJAjkgF++p+WPwKC9kMgh9bQlp +fG4y0bWUkC7c+3lR4MYIQXaLZznlrM4zkEx92Azk3VDeSAYFrHIcuISXVHyLFkbab M94FXhF0s9ZqDu+GhCPs11QXykXmCT1xagAyqgqvfnVV76XpELruGv3+kCwi/jXMH4 Quqq3a44ilZXQ== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87imfrkl5o.fsf@thornhill.no> In-Reply-To: <87366vun16.fsf@tcd.ie> References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Z2cck13jV7uaLjo3lXvLa3aoAWzpxR8rSYmzSdxjkxY" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_Z2cck13jV7uaLjo3lXvLa3aoAWzpxR8rSYmzSdxjkxY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, "Basil L. Contovounesios" writes: > I know, but this says nothing about the cdr. Maybe like this? Theo --b1_Z2cck13jV7uaLjo3lXvLa3aoAWzpxR8rSYmzSdxjkxY Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLjAzNjFhM2VjZGQgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzQ0LDYgKzc0NCwxOSBAQCBwcm9qZWN0LWNvbXBpbGUKICAgICAgICAgIChkZWZhdWx0LWRpcmVj dG9yeSAocHJvamVjdC1yb290IHByKSkpCiAgICAgKGNvbXBpbGUgY29tbWFuZCBjb21pbnQpKSkK IAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBwcm9qZWN0LXN3aXRjaC10by1idWZmZXIgKCkKKyAg IlN3aXRjaCB0byBhIGJ1ZmZlciBpbiB0aGUgY3VycmVudCBwcm9qZWN0LiIKKyAgKGludGVyYWN0 aXZlKQorICAobGV0ICgocm9vdCAocHJvamVjdC1yb290IChwcm9qZWN0LWN1cnJlbnQgdCkpKSkK KyAgICAoc3dpdGNoLXRvLWJ1ZmZlcgorICAgICAocmVhZC1idWZmZXIKKyAgICAgICJTd2l0Y2gg dG8gYnVmZmVyOiAiIG5pbCB0CisgICAgICAobGFtYmRhIChidWZmZXIpCisgICAgICAgIDs7IGJ1 ZmZlciBpcyBhIGFsaXN0IG9mICgiZmlsZW5hbWUiIC4gIzxidWZmZXIgZmlsZW5hbWU+KQorICAg ICAgICAod2hlbi1sZXQgKChmaWxlIChidWZmZXItZmlsZS1uYW1lIChjZHIgYnVmZmVyKSkpKQor ICAgICAgICAgIChmaWxlLWluLWRpcmVjdG9yeS1wIGZpbGUgcm9vdCkpKSkpKSkKKwogDAogOzs7 IFByb2plY3QgbGlzdAogCg== --b1_Z2cck13jV7uaLjo3lXvLa3aoAWzpxR8rSYmzSdxjkxY-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 14:19:50 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 18:19:50 +0000 Received: from localhost ([127.0.0.1]:49582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGBa-0007z6-6v for submit@debbugs.gnu.org; Tue, 16 Jun 2020 14:19:50 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:38111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGBZ-0007yu-18 for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 14:19:49 -0400 Received: by mail-wr1-f46.google.com with SMTP id e1so21815308wrt.5 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 11:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jJKKi7u+mipJWKA+RL9KhWCYkFHrDy4ObgdJvlR5kX8=; b=Bqe95Svl/jyVoF1PUwNI4R9yP9ZehxP9okjgre0lmxP0u+OXsUTleKL0U3M2jDPY+6 YSBBUYUytpZ6/lRBhp1R3mWokpEc/rJITpQze5Fj8OvIcIxnilL2b4XerTZhitZ7Vs5h 7r7jbrW6kiyWTNaKArnRLw++e6JwWJozYue9cjhPCvSAwH23xDdRJTybtpYakjXw1RKG TY7KCCL4VOwhILmdjlhRkPnVR+WqBIPgwZ631ABJ4FYXJpH9s6Vb403+VOsDhqh0M0P6 nW0kERdOgPS68x1vsuyJlaM2EpQhesyLwft13p/FsROl554XYQMfzb4glbprsyGsCl7K pu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jJKKi7u+mipJWKA+RL9KhWCYkFHrDy4ObgdJvlR5kX8=; b=Wh+jFthI/T5tWWza7MH00saVmAZTtmKeMV4JLvJ9bJnbHjpdq6xoyg71Hx5Mq9q4qI sW/OH+qa8I2ve1v5/VX+vh/HlCTJeiI8u9C9F2IWArHo7FUrCtdXnUAbk6bjKAkXkidz 05pnGOGbxFfRs4lQXQHWMSd2w2KQWggVC1s1OgA/cT7fsMnHhVZ17H4TIb/ryFxJ/aiv DqDtH/ZOnuXDA4Uzp6d5SaBBI4/VqYtghd98ib7ZrwtiknCJGSYSyBD2e4wigcP5CB+9 BTKpFNZpzeJs7oFjMljYZOGC4wv7rBgzeQwag3BkitBv/nADj4Ydskgj/s4WrnBScZEW BQ5w== X-Gm-Message-State: AOAM531Je7WPmuWHOwWhTs0j5+5wE1uOWE1NILkshiCOD8swWfDcEaRd wUyvmFKltSaVhY7Kayfv1+7c5g== X-Google-Smtp-Source: ABdhPJya5DMZYEJkzN/NOOkUtpZFrI1iqV4QTovKP6bwW5k3c3MdHFyjMh6rOmx1u9GwBQRzArlPZQ== X-Received: by 2002:adf:ea90:: with SMTP id s16mr4289330wrm.299.1592331583166; Tue, 16 Jun 2020 11:19:43 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id p1sm29291060wrx.44.2020.06.16.11.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 11:19:42 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> Date: Tue, 16 Jun 2020 19:19:41 +0100 In-Reply-To: <87imfrkl5o.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 16:53:01 +0000") Message-ID: <87h7varhz6.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > +;;;###autoload > +(defun project-switch-to-buffer () > + "Switch to a buffer in the current project." > + (interactive) > + (let ((root (project-root (project-current t)))) > + (switch-to-buffer > + (read-buffer > + "Switch to buffer: " nil t > + (lambda (buffer) > + ;; buffer is a alist of ("filename" . #) That's not right: BUFFER is a flat cons cell, not an alist. Please also start sentences with a capital letter and end them with a full stop. I'd write something like this: ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. > + (when-let ((file (buffer-file-name (cdr buffer)))) > + (file-in-directory-p file root))))))) Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 14:58:51 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 18:58:51 +0000 Received: from localhost ([127.0.0.1]:49609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGnK-0000Vz-Oh for submit@debbugs.gnu.org; Tue, 16 Jun 2020 14:58:50 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:47639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGnI-0000Vk-I9 for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 14:58:49 -0400 Date: Tue, 16 Jun 2020 18:58:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592333921; bh=cv5ZdS+S2ZGPtAlx9YcWMygov0LMIw02IvwYRIYrhAU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=P/wxhBpo5V8W4cvWzqFgZm233QTrC0IVkEvb77UZftLROMU3mJ/V0J5RloLpc27nt fRBYjKDHer7WOW0KdJ/1UB0CrPpwihA/dLNB40CmP8NUpigxZrwFggj/82J/+7oKRX j4tNu0o4w2+LJ26kC3PvjnHyiVt5YzPvJaPcdU2EYw8Xp9MG10FL9MA5qcKTlbcBRa ZVtjT5riXnbXOWPNarIz+8rbWCvKo6zbrUxEI2Ny6igDlp/Ms291G2RL1gJAsVk0w7 YSS8KVN3TKUKAzSlNamtDaGePrCIpaKZRrDmLLBvhk/a0d/rhFopEvIgA3HYlIwjJ1 4nzbc2fxCg++Q== To: "Basil L. Contovounesios" From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87lfkmn8h8.fsf@thornhill.no> In-Reply-To: <87h7varhz6.fsf@tcd.ie> References: <87bllk2pfc.fsf@thornhill.no> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_FEu5ETuQHaL6ROTxvSfy7VdKzSYL5ksFzAfqp6wg" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_FEu5ETuQHaL6ROTxvSfy7VdKzSYL5ksFzAfqp6wg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Thanks for your keen eye :) > I'd write something like this: > > ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. > Got it. I stole your comment - I hope that is OK? Theo --b1_FEu5ETuQHaL6ROTxvSfy7VdKzSYL5ksFzAfqp6wg Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLjUyZThlZjRmZjkgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzQ0LDYgKzc0NCwxOSBAQCBwcm9qZWN0LWNvbXBpbGUKICAgICAgICAgIChkZWZhdWx0LWRpcmVj dG9yeSAocHJvamVjdC1yb290IHByKSkpCiAgICAgKGNvbXBpbGUgY29tbWFuZCBjb21pbnQpKSkK IAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBwcm9qZWN0LXN3aXRjaC10by1idWZmZXIgKCkKKyAg IlN3aXRjaCB0byBhIGJ1ZmZlciBpbiB0aGUgY3VycmVudCBwcm9qZWN0LiIKKyAgKGludGVyYWN0 aXZlKQorICAobGV0ICgocm9vdCAocHJvamVjdC1yb290IChwcm9qZWN0LWN1cnJlbnQgdCkpKSkK KyAgICAoc3dpdGNoLXRvLWJ1ZmZlcgorICAgICAocmVhZC1idWZmZXIKKyAgICAgICJTd2l0Y2gg dG8gYnVmZmVyOiAiIG5pbCB0CisgICAgICAobGFtYmRhIChidWZmZXIpCisgICAgICAgIDs7IEJV RkZFUiBpcyBhbiBlbnRyeSAoQlVGLU5BTUUgLiBCVUYtT0JKKSBvZiBWYnVmZmVyX2FsaXN0Lgor ICAgICAgICAod2hlbi1sZXQgKChmaWxlIChidWZmZXItZmlsZS1uYW1lIChjZHIgYnVmZmVyKSkp KQorICAgICAgICAgIChmaWxlLWluLWRpcmVjdG9yeS1wIGZpbGUgcm9vdCkpKSkpKSkKKwogDAog Ozs7IFByb2plY3QgbGlzdAogCg== --b1_FEu5ETuQHaL6ROTxvSfy7VdKzSYL5ksFzAfqp6wg-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 16:37:35 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 20:37:35 +0000 Received: from localhost ([127.0.0.1]:49712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlIKt-0002xo-3N for submit@debbugs.gnu.org; Tue, 16 Jun 2020 16:37:35 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:39122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlIKr-0002xc-Kg for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 16:37:34 -0400 Received: by mail-wr1-f42.google.com with SMTP id t18so32273wru.6 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 13:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Lwc2hkmQzjKW7dd2wiRXchpd+MPYRdlmmCmHKKrnMEk=; b=HsnAWIg1ytHYt2JcgvGQoNIRtH3xV8dZ5g3Ze4SerfgxB+j+TEOspGqe1qPs7J4OBb wjn5zsZX9Q4uf7xZ9bW3xrHNWzOKZ5I7Bz8Zs712/Ht7u6WyYYuYwZfii9iKwNSu+D0c u0M7m/peR7K8pqXJ7454nZ4dx41CKQVkcuNXfGqLB/9YGTb7kIvGr/h5ZpcVZWs3rnCx U//j5vApPguASWmtsqYjkOwriMlGO3XEN9fsiRVr8Frdorwicsi+ggsxbUlTpMOC679h 7rPuI/4Y397cD9o7FiL9QCZ9Gtw5e1czl2WQ7kQgVR50aL8zibVDpfZOrhhIhIvrWSms IK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Lwc2hkmQzjKW7dd2wiRXchpd+MPYRdlmmCmHKKrnMEk=; b=dUjq2iKFH251kcZL4iiZoFgAACsYiK+zgHsMAdkF2BR7tg6IMGMORdv4H+/umtuh3w QzPORM0LFEUjY1qsZpLHKggw0bTkBKXG+SjYZZTWIfiq7634o00+JNVw2f0okCITQkMq 21qf6siVCAei5lBA9CAOz3/bN74EFaGd412aWF7kzJyMfH/qqODK4hycM4uML7SlCoQw MLvSKZaTlfH7Uvm5yB01J+reZNFSa3S94QGjYkCea8Lov4ks/4a1+Tw7dvuAeTwEdV/L 7jahD3MWEZrcP/wlvD7L31A7mocM1Vm88Bly3HN5eQ07B7c1wwhCXAVIfzbu/o0zbAWw LYZQ== X-Gm-Message-State: AOAM530A7g62PSAYnNOea1QwHr/fCzfxzUHt3bJVgvcsPpOW3AV3Sm/8 ulOAC9+YDOK+Yg58Xfbygsg4HA== X-Google-Smtp-Source: ABdhPJx5PNr2YtnVRmtxnjL7kJHa9J64MvWgQfmj+VmENbxhQ4n79asgdNDGyfFhmoj5mW6LG4j7nQ== X-Received: by 2002:adf:e3c1:: with SMTP id k1mr4482246wrm.33.1592339847779; Tue, 16 Jun 2020 13:37:27 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id c6sm5789995wma.15.2020.06.16.13.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 13:37:27 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> <87lfkmn8h8.fsf@thornhill.no> Date: Tue, 16 Jun 2020 21:37:26 +0100 In-Reply-To: <87lfkmn8h8.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 18:58:33 +0000") Message-ID: <87y2omn3w9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Thanks for your keen eye :) Thanks for all your useful contributions! >> I'd write something like this: >> >> ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. >> > > Got it. I stole your comment - I hope that is OK? Of course. In decreasing order of preference: improved > stolen > ignored. ;) > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index f3df44fa7b..52e8ef4ff9 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -744,6 +744,19 @@ project-compile > (default-directory (project-root pr))) > (compile command comint))) > > +;;;###autoload > +(defun project-switch-to-buffer () > + "Switch to a buffer in the current project." > + (interactive) > + (let ((root (project-root (project-current t)))) > + (switch-to-buffer > + (read-buffer > + "Switch to buffer: " nil t > + (lambda (buffer) > + ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. > + (when-let ((file (buffer-file-name (cdr buffer)))) > + (file-in-directory-p file root))))))) LGTM, thanks. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 17:40:34 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 21:40:34 +0000 Received: from localhost ([127.0.0.1]:49783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJJq-0004VB-Cr for submit@debbugs.gnu.org; Tue, 16 Jun 2020 17:40:34 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:40759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJJo-0004Uy-VJ for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 17:40:33 -0400 Received: by mail-wr1-f46.google.com with SMTP id h5so181978wrc.7 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 14:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JnkAS+y+Fx/uwow2LCvXv5LePc8axBzAYYzEh/GXj30=; b=AUiBi7CyE7DJi+sK0qc3Umci7IZXHItuGR79nMgu6svmZFsurJA7cyipR3jL6DbvO7 WFs0nh50ujbBPfdHMmuYXz1q/fhLUM55+De88dOf6qoqbFm59MzrQgnkE9NV1Swgro/R 1E3fPJ1fHs5zPuq1c+jcIttDK/686GL/x9hCnqQAzOPlHZSftnVX3FVTmvs50R5QQFwz ettc9ocFy8FBuPjKkjL4bTHc9oqFMJa7jaTNRU5txM8a8OYsm5dpXFx9DrR9fnRdx1uZ pPoJf5bCz3u4fPEgw1MvcjhAx1XDWahQ7pn+P2oBpXxyp0LpL3hMCiOHgZdeucieD2LY Zezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JnkAS+y+Fx/uwow2LCvXv5LePc8axBzAYYzEh/GXj30=; b=hnznw+xt+DEFWdqInHgUVBb87eaFtWvhR9fTG6eiFnGX+706hsyR2Qq3iAgma6eg4W aGRHFo3wLdRNhMxqDA5hc803t9lX0JexLYUuBwu/KosJk+7MQz7kZrYDDLyXdovFuINi LbjqT9vuRc9LgiaKN2m4oCbS6G0pEGFmgwhugOHzn99eRP6epbezj0wAlt5k50SVq/F5 JgkeQWs+A3RTlI9BN6EB0ywaZH8tAIIkQEM++46CBR2kbSlgF1564zGX9b7zZ84z5KVQ 0GbK0MJ7+NQ+ZvPCx98ERo8/Oa+V5Q5IxEZtp7u0aznQgiGPPTV/PYxrWaOizIfh1icr uw8g== X-Gm-Message-State: AOAM531I1JyaTixM2ndndZAdqPIpF3u3gv+nbkr6zEgw5O2C7Dd8akh6 v7UCyzX0k7iryME4EVOuy98= X-Google-Smtp-Source: ABdhPJy7Jcf9aNcfHBAuWs/q6vKbsKtHhp63KotJB+44Rbat1/QPnXP5pJ5k95Lf2e8dKp7thpbKmw== X-Received: by 2002:adf:e84c:: with SMTP id d12mr4937164wrn.284.1592343627231; Tue, 16 Jun 2020 14:40:27 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u13sm5548365wmm.6.2020.06.16.14.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 14:40:26 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: "Basil L. Contovounesios" , Theodor Thornhill References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> From: Dmitry Gutov Message-ID: <98a353cf-407b-0eeb-c564-0adc977973de@yandex.ru> Date: Wed, 17 Jun 2020 00:40:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87h7varhz6.fsf@tcd.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.06.2020 21:19, Basil L. Contovounesios wrote: > ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. I don't think we can/should refer to C level variables from Lisp documentation. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 17:58:22 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 21:58:22 +0000 Received: from localhost ([127.0.0.1]:49798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJb4-0004ux-KM for submit@debbugs.gnu.org; Tue, 16 Jun 2020 17:58:22 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:34373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJb2-0004uj-Oe for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 17:58:21 -0400 Received: by mail-wm1-f41.google.com with SMTP id u26so3140431wmn.1 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 14:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZwkQoMW56s71UyfarJVWqAwh2LorBf9VWwkTzl15FVk=; b=ABlBCAa4Yp+9t3QsrFdes1U1a2jxlbxrmHLOklNYY8sqvqhvd/WT61M2n2x3L78SZI bpplspSknxc3LkzeXt6GJt0DNi0W/DDkyywrFBOxcbqmY7EspSUmUFzJjKBVyvG1wSHX j/RzjcWuuDtYXwb2MntajNFGjvzH4xPmaDZdNNIjennkrZMd1RbNDBXNX513WuNqRBb9 kNJJF+PqtJIJMv5/aCA9BKbAqB5c7RArmaRLBUoVuxiTmxN3bODjBoWnPyaWjY5rmFIH 9cXQ0CwHQ+X7DqFn14SZNMu6MVxwbGinenqxliIBLjLJcjx1cxLIBigqdBrCapvtMj1U 5gxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZwkQoMW56s71UyfarJVWqAwh2LorBf9VWwkTzl15FVk=; b=fb01wbIuFAxLKRa+dLsedzQRHmiHQMoMV/l/Xx1f0T2uPYp9PNUzcP70fUz1YegsyJ ylVoguXLc448O795LvqUaJ69aoRaX1DCYmZ02x2Je1gDQ/eex/XZ7la9kmdJnpNioIpm TlFvYcrGgQz7ILh8Y/binxTdWEOMUJDJesMrw8VSfckUVNdmgeZmcfwwwDe2OHioAdoc yiA3ACQ9apDvr85am7809Y8QxafvKfOR8y7/vQrfLWRdZ9PDRnuzJnTrNdwbF1vxTtq0 9t7QztivW5ng7RREElN6UP7gJXRg5QQ9RGp+4JVwJ+u89eZeyF69a/CZECE+jcZcAwKq e0FQ== X-Gm-Message-State: AOAM530m6SBPb82r5zmstYqL4lgkwgqd+iLIT4xh7rGyaOtV3zAbjvFE NdULFczCdKD5jCRbDjPdtRPNJQ== X-Google-Smtp-Source: ABdhPJz0M2CkgvwBx/1M56b4I46DPtMGFgCvdNWeghDHjO9UXQqlCJXg+zgklK78WMwk5RNf7VE7cw== X-Received: by 2002:a1c:544d:: with SMTP id p13mr5564854wmi.25.1592344694752; Tue, 16 Jun 2020 14:58:14 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id g18sm5777034wme.17.2020.06.16.14.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 14:58:13 -0700 (PDT) From: "Basil L. Contovounesios" To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> <98a353cf-407b-0eeb-c564-0adc977973de@yandex.ru> Date: Tue, 16 Jun 2020 22:58:12 +0100 In-Reply-To: <98a353cf-407b-0eeb-c564-0adc977973de@yandex.ru> (Dmitry Gutov's message of "Wed, 17 Jun 2020 00:40:25 +0300") Message-ID: <87h7van05n.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 16.06.2020 21:19, Basil L. Contovounesios wrote: >> ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. > > I don't think we can/should refer to C level variables from Lisp documentation. This is a source comment, not public documentation, and the relevant code relies on an undocumented C-level implementation detail (the use of Vbuffer_alist as a completion collection in read-buffer) so I think the comment (or something along those lines; feel free to suggest improvements) is appropriate. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 18:11:44 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 22:11:44 +0000 Received: from localhost ([127.0.0.1]:49811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJo0-0005FB-FM for submit@debbugs.gnu.org; Tue, 16 Jun 2020 18:11:44 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:54183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlJnz-0005Ez-10 for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 18:11:43 -0400 Received: by mail-wm1-f50.google.com with SMTP id l26so4310581wme.3 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 15:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ciQpi9/BybirSKrxFmMkYdX2OOw/n7Rz8F2mw6DhIIw=; b=rw9Y5/YEHYU7oAvrwV3Xgfd0/Rgy0gketkhuR3AzH+UkS8mderIGhcQsiOdQu8Q5/e 6FyXO3pqSIg2HTYl4emTmxc5FxtMHlvVkTXHepJKADNhwFv+GVPXh3pCW0wViIl6Kc07 g5IrAxmWgqX/g4IhDaVsBhve8KAgTXB11aPacG/vOxG+Pbha1K0E76ZWFedEMQO6pfp2 +o9/N/FOUxtmmXrnqznjVRVkpcXqwkzP93xJIZKJbaDJAZ+OF9DoFzlbPkeP8apteLGc 9e+QF7B/g4j3+MpM+CEqxQqZogUpjtTonfEw/aYxO094RNByWoj3rXFZojBeQx3StWBc aWiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ciQpi9/BybirSKrxFmMkYdX2OOw/n7Rz8F2mw6DhIIw=; b=X6vOC8Jcj1g1DJlPjD27WKA1QUn7WfIoSBsY/knPjzO9OVtNUQuloxRpxcN8V/dySo SmERHEPJf9H14/Prfuglch47BlrY3aVIP9NCdfsg+AIKCpQGiz06//3psjiQyGeQ2LHq qMUdXUgrS+8q/naTirJUNHUMz8Bb8jM5NWVWrVqofYfoChFXAo4ecYSCKc/oLj4D+yhu GO5OWjJ/0qgpVGYz4Ve5vae4eyQqS5XbZlUAptEQswS30wv9vBRTYPncN2XOF4DcbNuF vzJZBHWroFBPc1+GlQpIUTfr7fJX2i+een/Of1ABKkeEPy51jqFHyc0AsBwXN1BFqm+J VydA== X-Gm-Message-State: AOAM533grfNwfOumRNRPuUcvp4iitxMwum+6kf3Y1YIUHxcDH7R0n4lS +G+jTqYXKVOpaqXwqw04eZU= X-Google-Smtp-Source: ABdhPJzFB7gU7Fv4ddpBSlkUxAeUH3gmmZnOU4x0qAB1UZrqdBaHaiRM5JlT0Y7zvsw+6US5eVtYQw== X-Received: by 2002:a1c:7505:: with SMTP id o5mr5087941wmc.164.1592345497103; Tue, 16 Jun 2020 15:11:37 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id n7sm31567852wrx.82.2020.06.16.15.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 15:11:36 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: "Basil L. Contovounesios" References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> <98a353cf-407b-0eeb-c564-0adc977973de@yandex.ru> <87h7van05n.fsf@tcd.ie> From: Dmitry Gutov Message-ID: <03769815-a844-6445-1638-f8bce4d273b6@yandex.ru> Date: Wed, 17 Jun 2020 01:11:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87h7van05n.fsf@tcd.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, "Philip K." , Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2020 00:58, Basil L. Contovounesios wrote: > This is a source comment, not public documentation, and the relevant > code relies on an undocumented C-level implementation detail (the use of > Vbuffer_alist as a completion collection in read-buffer) so I think the > comment (or something along those lines; feel free to suggest > improvements) is appropriate. I see. All right then. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 18:39:52 2020 Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 22:39:52 +0000 Received: from localhost ([127.0.0.1]:49846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKFE-0005vV-Cn for submit@debbugs.gnu.org; Tue, 16 Jun 2020 18:39:52 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:38304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKFC-0005vH-3v for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 18:39:50 -0400 Received: by mail-wr1-f47.google.com with SMTP id e1so304227wrt.5 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 15:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rAuXUYdshhoNtvhEK9NKDVIUvAEyxz9L4vgqBDFnrcc=; b=nOVfwDScKxOl08HzieOF1KQ1KGoO88EzFoB15c5Rmc5PfiisYLLgfKLYkrA9khxerL NyPoSV9mgvCZqNQ6nNh+uPuTV9FpPFc8xVROBKD8EQd5dFh3mF9m7V4jsTEA30A9pGJg M1UmaJTyjoSBXxEMkmwShHBjafPJcmBJHOGfdNL4m2fV/kiaqN6sXvQs3ORmhB4g8rdl vAABt/fd16xOhhfr0mDmN5pGaaCjMbfq71icW3iXKUx8kBEwJVLE+fy8f1j7u1nhHXsQ KJA5pb+/ycJ2fFreelTY0nx8GzYIofNTmG1/GD088Q4gvlLZxsHJw55gBZBd2Y/SE+wX A4ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rAuXUYdshhoNtvhEK9NKDVIUvAEyxz9L4vgqBDFnrcc=; b=REtRt7RlKY/z52uDVWfhiqQMp4zjnYe2K2s+2F8AhJ4NffGqaO3Iq5RXLYkRIyQKT4 RigbfBQ5eoHrdSzfjIvIdIgbvCAw8DWymvMiaA6OporGUtakh95X64k3ycuBJ9EOWBmA 9NmuZJgYkGKesHKUPsADzDzia4c0s873hQJgbPUtvoQPrqOycCT/vCBjpB0TwsJIGvuS qsjbQXDWM0jafygELeY2IwzX9sYa1iuDzssVRNbL49IvXiC1ET+p3CWNM4sWolUII7wK I56YfQhB+xkvTytK3x1fi07mytQbcAAn7LWn05BD0gcXYJ8av2EV9WxAHogkHA8FnHYa J1PQ== X-Gm-Message-State: AOAM531bT0N0L8UZD8Z0jO4/+1aY6gacSCfminVDrEiLBk+LxrMYWT7T uwU8MVvChWWSiXhXA+kwqD/O6MGK X-Google-Smtp-Source: ABdhPJz13DNsu5GcVBd2ZfuT8mbMWcMm7CZrQxtSoIXdT8UQrozggheYeNBwR31O3DGKpzCnWNqkdQ== X-Received: by 2002:adf:a306:: with SMTP id c6mr5195242wrb.122.1592347184283; Tue, 16 Jun 2020 15:39:44 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id b201sm5864545wmb.36.2020.06.16.15.39.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 15:39:43 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Theodor Thornhill , "Basil L. Contovounesios" References: <87bllk2pfc.fsf@thornhill.no> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> <87lfkmn8h8.fsf@thornhill.no> From: Dmitry Gutov Message-ID: Date: Wed, 17 Jun 2020 01:39:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87lfkmn8h8.fsf@thornhill.no> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.06.2020 21:58, Theodor Thornhill wrote: > Got it. I stole your comment - I hope that is OK? Looking good, thanks. I'll install it tomorrow or so. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 19:11:04 2020 Received: (at 41879-done) by debbugs.gnu.org; 17 Jun 2020 23:11:04 +0000 Received: from localhost ([127.0.0.1]:52395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhCy-0001Po-47 for submit@debbugs.gnu.org; Wed, 17 Jun 2020 19:11:04 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:40469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlhCu-0001PG-Ew for 41879-done@debbugs.gnu.org; Wed, 17 Jun 2020 19:11:02 -0400 Received: by mail-wr1-f48.google.com with SMTP id h5so4108998wrc.7 for <41879-done@debbugs.gnu.org>; Wed, 17 Jun 2020 16:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GXGI5ZShzQ+UHDqvuPX16ARRg9BTNi0rMY761UXttvc=; b=ql1FOPffPZiEShBEUQRfg6No+392M1p450euzxdoIUBeSwkSod4E+ipW7X44FDv4t3 4+RCbpkX6Tl8OILLH45i/EFC+nRKA/+74w4OhIAtv8wWGjhwODfb4Q6FvL8SlQiwRxmL VaFZxBQEgSMT4oZBsEpd93vAJAI+MxauN6HP5CO64MBfP1layJnY8cq/GHsOrJGMuIlP JRSvIN2txNVaOiEIW7hCXkv0SVACvOJOcRwf2ng3/Np5OTsSNQQELdzehC1SxyvB10dO DKntTmIghwcw//rXyGt+DnCH0bkAxIvaKNhJ5BWdbQDEal5En1NR5S8mwZfXpqWItgCm YeeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GXGI5ZShzQ+UHDqvuPX16ARRg9BTNi0rMY761UXttvc=; b=NY4nuXPlROvR7W9IaA2bFxCHdlkyAJPMuaN0zetgQKoOdLsKXHs5aG1+nrvEPluv2B o3sbeAuS8i1AGp/pYnCYUV79kvHOBfDVZW6v9veztVcKpLH03a62n0Ze8vbvTFILsnLc YahPf76yntBZpKqJmZgHF+yDETbsUMIjasztQwoWcQiJoabt/X9Sm/FZdRiRaC2yWNo2 Cb8qVFtK8StANdZBcofzJCumnyMCjYBoe5xfBM4xLmuwwK3FNeQ0mNtoc+S5JQJviYeH lP+uXUTujWExvk4k3HF6iBYR6Ca10eau5gR/IgayWDsDmmYHnvfgwevPM+GSkuxo9IND NDDQ== X-Gm-Message-State: AOAM532l6dwbm5iNqheSXBnULXbWBJj/KtMTCpaF6vkPI+tq0NGgc9f8 6z/ayp3fMueNO89AnwzeWE4Ql7nF X-Google-Smtp-Source: ABdhPJy7yZ6OsYjW3+1fxXuNbvLEOgu7+BZrwdCxZUgL38FgxPlZ46KsvYVuUQzJrkXWdOxS7VBUpQ== X-Received: by 2002:a5d:4e88:: with SMTP id e8mr1620017wru.188.1592435454397; Wed, 17 Jun 2020 16:10:54 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id r5sm1278403wrq.0.2020.06.17.16.10.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 16:10:53 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Theodor Thornhill , "Basil L. Contovounesios" References: <87bllk2pfc.fsf@thornhill.no> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> <87mu53i9xf.fsf@tcd.ie> <87o8pjkuld.fsf@thornhill.no> <87366vun16.fsf@tcd.ie> <87imfrkl5o.fsf@thornhill.no> <87h7varhz6.fsf@tcd.ie> <87lfkmn8h8.fsf@thornhill.no> From: Dmitry Gutov Message-ID: Date: Thu, 18 Jun 2020 02:10:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87lfkmn8h8.fsf@thornhill.no> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879-done Cc: 41879-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.06.2020 21:58, Theodor Thornhill wrote: > Got it. I stole your comment - I hope that is OK? Also installed. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 05:41:49 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 09:41:49 +0000 Received: from localhost ([127.0.0.1]:52779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlr3M-00023J-OR for submit@debbugs.gnu.org; Thu, 18 Jun 2020 05:41:49 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:33398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlr3K-000235-VY for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 05:41:48 -0400 Received: by mail-lj1-f193.google.com with SMTP id s1so6468717ljo.0 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 02:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+lVfFvl95MqCiiuTDIA5PrBTKE6bypeD1ZKir9W1CI0=; b=XoOHbpc9bubAPf08N7qZ7n5Vff9+OhVtcfH76RhZA6ZOqbWH83vfxnUDv6UX/OJm84 q3AZhcSoELeVY1isDCsvgD5ZGRwIayGaIi7uV/uJf9Q0bE8kG3AfdQ5JB3rMNX0MoRzv e39F6FAtaaGvPPBNJy7ShZ6b5m+K1aV65UhWNVmaM8c5XLusRhy+OhhMvWyvzRhY6ABV IeWDtyVfkjCG9JqqwCPUiyVU0hpr66Z12xQfixugei5A6ciAEWJ/u8YYMF/sdloPeWwG q2F5IR6N7tJ6/HWw8Sg7Gwdrpeioh0ahg0lXel4c5d23XAZ/tvQrmoO0pN9bzpWDtSIw PGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+lVfFvl95MqCiiuTDIA5PrBTKE6bypeD1ZKir9W1CI0=; b=dWj1sn8frCN6MKB4Eoi6R1QAF8OHDFLbxxQrA6MRyx6MdKZF3PeMZfGn4UXU4YQHdZ w2s4FYtQgmYHm3YCz1PpUbSTCEH/NSDI2SQK1DyXe4haDMkVz3VMrrdNABsigAefoVeG 2OpH9BokHTJWsj7/67Q44I9u5/Sg75ldCEcEafhXz9WZ5bYq3eo7Ed359E+bMhLO0fPv 3XuXsNs6BxbPVAwuI4xyJBHVfbIIi8AWHxKaivFcmYe5y1jqqoBhKjsB9meSnZsLPAIt pbrNyO2V0Bo3t0y73JiloByHBz2y5eEVbejto67diEIh8NyqLCwdDHFYej7E/BXUGkFQ uMJg== X-Gm-Message-State: AOAM532dTYwtKS395gQqJ0QtmAM5h4uQgTzYfGcWZF/fHFKfkp1ynUQy Cz3/acuvgz3Si/+iYVN7o+ZWORcE X-Google-Smtp-Source: ABdhPJx3SBteJ9Wfdd2e8yO30nG5oybYFze30SqW9KSD8QUT1LRju5w55j+oGrzPscwzg+7PukkueQ== X-Received: by 2002:a2e:9987:: with SMTP id w7mr1777174lji.215.1592473300429; Thu, 18 Jun 2020 02:41:40 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id b25sm527569ljo.16.2020.06.18.02.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 02:41:39 -0700 (PDT) From: Andrii Kolomoiets To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> Date: Thu, 18 Jun 2020 12:41:30 +0300 In-Reply-To: <87bllk2pfc.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 15 Jun 2020 17:45:53 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Theodor, > However, attached is a patch for project-switch-to-buffer, where only > file-bound buffers are included. I believe the function should be kind > of self explanatory. Can you please tell why only file-bound buffers are included? I have some buffers with inferior python process in each project, would be nice to switch to them with project-switch-to-buffer. Also consider to provide default value like: (buffer-name (other-buffer (current-buffer))) This way one can switch to recent project buffer with just RET, same way as switch-to-buffer. Thanks for your work! From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 06:11:36 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 10:11:36 +0000 Received: from localhost ([127.0.0.1]:52814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlrWC-0002l3-I9 for submit@debbugs.gnu.org; Thu, 18 Jun 2020 06:11:36 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:17847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlrW8-0002kn-6W for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 06:11:35 -0400 Date: Thu, 18 Jun 2020 10:11:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592475085; bh=6+TzgEEKTrgpyZnavpqMgpqbcqnTQq2kem2/lOLWZyk=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=sO0BeGtIsd4s9l1ABeE4e91GN7Wv0uIEYi7+c2/Cr42cSc1M0qMRyWOQZGnV7MTmO GjBFacvQ9KPRKrgpwRBoQyOEeFLxZG4YLZSF3ZFvTdASOb02o/PYfLHe3hibXgjyBZ 0vW7v7nz2mYH0yVEibY/6bq8054q13Op9KCPTtxqxCoXDNgzpeYO+uceSM+E7kxzrS +iVHRYvLCbQ7GjFeCXTW9E/L3lZW8/bamNNpVKHt7w33SZLIZLSj3W6emLSWdmHUl9 /KPEIfGIp2LQ2k5JRKjsC0+mCttGlOBs8Y+tXhf5nZ5ghY0zJ2SgENImBqlpnlTcZt YSB/Rh2/+MkTw== To: Andrii Kolomoiets From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <877dw4of9a.fsf@thornhill.no> In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Hi Theodor, Hi! > Can you please tell why only file-bound buffers are included? I have > some buffers with inferior python process in each project, would be nice > to switch to them with project-switch-to-buffer. Well, I tried a few different ways of including other buffers as well, but = emacs seemed to want to include earlier used minibuffers and all sorts of '= junk'. I agree that these inferior processes should be interesting to incl= ude, though. I can try to find some way to filter out the cruft a bit bett= er! Do you have a specific idea in mind to go from? =20 > Also consider to provide default value like: > > (buffer-name (other-buffer (current-buffer))) > > This way one can switch to recent project buffer with just RET, same way > as switch-to-buffer. This seems smart! I'll look into that as well :) Thanks! Theo From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 06:31:38 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 10:31:38 +0000 Received: from localhost ([127.0.0.1]:52888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlrpa-0003OY-8t for submit@debbugs.gnu.org; Thu, 18 Jun 2020 06:31:38 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:29469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlrpY-0003OI-4M for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 06:31:36 -0400 Date: Thu, 18 Jun 2020 10:31:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592476289; bh=j+uWQtWpPUsIpg1bCdyrXeNoG7IBEVjg+Y3KzyxFDjU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=U/AQ5tyETqBa9GqVsDwNhIjmxLms+Wc12tMLQJi/9FcY4aRDPkOCovPYHyAvK8SzE bA58bUYdVH9isp3F/IfTXJs5/b4z185Qu8HKxdS3B2fZ2VCe8MjyAJCgWcWJI8Oh/X N+DnqKHR5DIiss1J7XO6OsWe4lF4KLOKWQ3/grImAYBlEpAiXLhlDBlOY1Xat8/VB3 pL3ghKjcaSTgpGto+NuILvBGaKaqzk/XO12/2O8qpJWNDUG2ooON3M8OppRO+bSHHc HvMIu84BlnAg3V+MINyvT9niyUAnPo3YRBY1U2qUt3SAp5FLR78tHh0wmyUe+IGoUs Ih5U/gkIfl79w== To: Andrii Kolomoiets From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87wo44mzrb.fsf@thornhill.no> In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_KWg2mVyWNdfOZxuUezhudIegU3JcOiL6sp9Ywh4gY" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_KWg2mVyWNdfOZxuUezhudIegU3JcOiL6sp9Ywh4gY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable That was a lousy diff, sorry... Theo --b1_KWg2mVyWNdfOZxuUezhudIegU3JcOiL6sp9Ywh4gY Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGUyNGQ4MWMxYjQuLmQ0YTJiNzcwN2UgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt Nzc5LDEwICs3NzksMTIgQEAgcHJvamVjdC1zd2l0Y2gtdG8tYnVmZmVyCiAgIChsZXQgKChyb290 IChwcm9qZWN0LXJvb3QgKHByb2plY3QtY3VycmVudCB0KSkpKQogICAgIChzd2l0Y2gtdG8tYnVm ZmVyCiAgICAgIChyZWFkLWJ1ZmZlcgotICAgICAgIlN3aXRjaCB0byBidWZmZXI6ICIgbmlsIHQK KyAgICAgICJTd2l0Y2ggdG8gYnVmZmVyOiAiCisgICAgICAoYnVmZmVyLW5hbWUgKG90aGVyLWJ1 ZmZlciAoY3VycmVudC1idWZmZXIpKSkKKyAgICAgIHQKICAgICAgIChsYW1iZGEgKGJ1ZmZlcikK ICAgICAgICAgOzsgQlVGRkVSIGlzIGFuIGVudHJ5IChCVUYtTkFNRSAuIEJVRi1PQkopIG9mIFZi dWZmZXJfYWxpc3QuCi0gICAgICAgICh3aGVuLWxldCAoKGZpbGUgKGJ1ZmZlci1maWxlLW5hbWUg KGNkciBidWZmZXIpKSkpCisgICAgICAgICh3aGVuLWxldCAoKGZpbGUgKGJ1ZmZlci1sb2NhbC12 YWx1ZSAnZGVmYXVsdC1kaXJlY3RvcnkgKGNkciBidWZmZXIpKSkpCiAgICAgICAgICAgKGZpbGUt aW4tZGlyZWN0b3J5LXAgZmlsZSByb290KSkpKSkpKQogCiAoZGVmY3VzdG9tIHByb2plY3Qta2ls bC1idWZmZXJzLXNraXAtY29uZGl0aW9ucwo= --b1_KWg2mVyWNdfOZxuUezhudIegU3JcOiL6sp9Ywh4gY-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 06:31:43 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 10:31:43 +0000 Received: from localhost ([127.0.0.1]:52899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlrpf-0003P6-7V for submit@debbugs.gnu.org; Thu, 18 Jun 2020 06:31:43 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:53230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlrpd-0003OQ-AY for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 06:31:41 -0400 Date: Thu, 18 Jun 2020 10:26:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592475970; bh=2hUmQ8q7MbMU8w/e5slKBDWalEJoMPFqY/76d8ej1M4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=utg2/gOjYHZ3bW6hdgNck7WpOo94kAAWGJusPiKam34yfoapS0X8IGTAbNY5Kfs+P qnEWpbcky6Xkb8DEw6dHOr2ca0+xSiv0KytYPMUCiwWaD/meKbkhdT4DoCR7V8fJvk j1JZubCRQYJ4s3P8UV84ZUE76HH2S5JxxVYcdpwSaMmBTnR2JyEkk96rDLCcDrHaak C0zqKLtUCLpICtecY5GP+r7zdDbPX2Cr3yENJ3EX/bM2p5Pc6hBdKwmC9my69dwyFg 4M0tirk3qtreMNUbRHFluLou7MOv3UtpVaY0dfsWxZAMOaWOnsvnr0AAfXVNVwI1xx RlGLKGSIM0nPQ== To: Andrii Kolomoiets From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87zh90n008.fsf@thornhill.no> In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_yeXQOgpBNmQXaDrhILDelG7czQT7kiloZBas1LKzU" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_yeXQOgpBNmQXaDrhILDelG7czQT7kiloZBas1LKzU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On the other hand, what do you think about this one? Now you will get buffers such as '*xref*' and I assume your inferior buffer= s as well. Could you try this? I added your 'other-buffer' thing also for g= ood measure :) Theo --b1_yeXQOgpBNmQXaDrhILDelG7czQT7kiloZBas1LKzU Content-Type: text/x-patch; name=project-switch-to-buffer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-switch-to-buffer.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGUyNGQ4MWMxYjQuLmU5MzVjYWUyODAgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt NzE0LDExICs3MTQsMjAgQEAgcHJvamVjdC12Yy1kaXIKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1 biBwcm9qZWN0LXNoZWxsICgpCi0gICJPcGVuIFNoZWxsIGluIHRoZSBjdXJyZW50IHByb2plY3Qu IgorICAiT3BlbiBTaGVsbCBpbiB0aGUgY3VycmVudCBwcm9qZWN0LgorV2l0aCBcXFt1bml2ZXJz YWwtYXJndW1lbnRdIHByZWZpeCwgY3JlYXRlIHN1YnNlcXVlbnQgc2hlbGwgYnVmZmVycword2l0 aCB1bmlxdWlmaWVkIG5hbWVzLiIKICAgKGludGVyYWN0aXZlKQotICAobGV0ICgoZGVmYXVsdC1k aXJlY3RvcnkgKHByb2plY3Qtcm9vdCAocHJvamVjdC1jdXJyZW50IHQpKSkpCi0gICAgOzsgVXNl IOKAmGNyZWF0ZS1maWxlLWJ1ZmZlcuKAmSB0byB1bmlxdWlmeSBzaGVsbCBidWZmZXIgbmFtZXMu Ci0gICAgKHNoZWxsIChjcmVhdGUtZmlsZS1idWZmZXIgIipzaGVsbCoiKSkpKQorICAobGV0KiAo KGRlZmF1bHQtZGlyZWN0b3J5IChwcm9qZWN0LXJvb3QgKHByb2plY3QtY3VycmVudCB0KSkpCisg ICAgICAgICAoZGVmYXVsdC1wcm9qZWN0LXNoZWxsLW5hbWUKKyAgICAgICAgICAgKGNvbmNhdCAi KiIgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkKKyAgICAgICAgICAgICAgICAgICAgICAgIChkaXJl Y3RvcnktZmlsZS1uYW1lCisgICAgICAgICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJl Y3RvcnkgZGVmYXVsdC1kaXJlY3RvcnkpKSkKKyAgICAgICAgICAgICAgICAgICAiLXNoZWxsKiIp KQorICAgICAgICAgKHNoZWxsLWJ1ZmZlciAoZ2V0LWJ1ZmZlciBkZWZhdWx0LXByb2plY3Qtc2hl bGwtbmFtZSkpKQorICAgIChpZiAoYW5kIHNoZWxsLWJ1ZmZlciAobm90IGN1cnJlbnQtcHJlZml4 LWFyZykpCisgICAgICAgIChwb3AtdG8tYnVmZmVyIHNoZWxsLWJ1ZmZlcikKKyAgICAgIChzaGVs bCAoZ2VuZXJhdGUtbmV3LWJ1ZmZlci1uYW1lIGRlZmF1bHQtcHJvamVjdC1zaGVsbC1uYW1lKSkp KSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBwcm9qZWN0LWVzaGVsbCAoKQpAQCAtNzc5LDEw ICs3ODgsMTIgQEAgcHJvamVjdC1zd2l0Y2gtdG8tYnVmZmVyCiAgIChsZXQgKChyb290IChwcm9q ZWN0LXJvb3QgKHByb2plY3QtY3VycmVudCB0KSkpKQogICAgIChzd2l0Y2gtdG8tYnVmZmVyCiAg ICAgIChyZWFkLWJ1ZmZlcgotICAgICAgIlN3aXRjaCB0byBidWZmZXI6ICIgbmlsIHQKKyAgICAg ICJTd2l0Y2ggdG8gYnVmZmVyOiAiCisgICAgICAoYnVmZmVyLW5hbWUgKG90aGVyLWJ1ZmZlciAo Y3VycmVudC1idWZmZXIpKSkKKyAgICAgIHQKICAgICAgIChsYW1iZGEgKGJ1ZmZlcikKICAgICAg ICAgOzsgQlVGRkVSIGlzIGFuIGVudHJ5IChCVUYtTkFNRSAuIEJVRi1PQkopIG9mIFZidWZmZXJf YWxpc3QuCi0gICAgICAgICh3aGVuLWxldCAoKGZpbGUgKGJ1ZmZlci1maWxlLW5hbWUgKGNkciBi dWZmZXIpKSkpCisgICAgICAgICh3aGVuLWxldCAoKGZpbGUgKGJ1ZmZlci1sb2NhbC12YWx1ZSAn ZGVmYXVsdC1kaXJlY3RvcnkgKGNkciBidWZmZXIpKSkpCiAgICAgICAgICAgKGZpbGUtaW4tZGly ZWN0b3J5LXAgZmlsZSByb290KSkpKSkpKQogCiAoZGVmY3VzdG9tIHByb2plY3Qta2lsbC1idWZm ZXJzLXNraXAtY29uZGl0aW9ucwo= --b1_yeXQOgpBNmQXaDrhILDelG7czQT7kiloZBas1LKzU-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 06:48:24 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 10:48:24 +0000 Received: from localhost ([127.0.0.1]:52949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jls5o-0003oF-Ic for submit@debbugs.gnu.org; Thu, 18 Jun 2020 06:48:24 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:36899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jls5k-0003nz-QQ for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 06:48:23 -0400 Received: by mail-lj1-f195.google.com with SMTP id e4so6655088ljn.4 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 03:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=O7dXPOgZ8dqwvbEdPtSL40SLWCUip6nKGsqDZUhiH5U=; b=m1FImFc9S9WcbZ/ROtCiy7yjRNbqJGakfqojtLPMqB/1zzr+mhFsafMTF2cEDCenAx JgSQFUfVCotG1SVPNtEo0RgoIYitO9Uc+sabWwIrsFdas3hI/qM5avGqEQS4Z59av0yw Z7c8iCslufRmPBiX5cMTAW8i2r8pv+ht0UGpkyTE/VtMll7olwT1Gu7C559oSjMK78sJ mSzoB0acXiBQvvnMm2Xa6qtuP5FAEqA5NmOn43PBNLZkz1OIZQ8AYXToWnKoyS3Kz4WW xu5QzEfgZp2tfd7IH963VCg6TMPEvYQLb4fyVBhtKC1IRoPyyOkIqu4VTi8i4hI2rvz4 Ft/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=O7dXPOgZ8dqwvbEdPtSL40SLWCUip6nKGsqDZUhiH5U=; b=Awh0WUWFhJB5Xdr2VPUThKu6Iop06Xx5SnlGIA4TIHdsWqS1dqDgBTgtwjGwT2ZYM5 LfqpKLDv5JKJrWZDoRZyLzpnC618r5w+LDvp/g0mBgUHB4XQ2D3Ypym5GhmMzeyy9XTU VN22GW3cuciNwj/gGvolrHE9VSWv5qNP+LnzAvNbSbfvuwFtnp1ccwtZA8TLJeSTB5p4 ASed3w3Oxx25oSImXRZ2t+6deRNS/K3vRzETELCqAErXXTFyRMd+M4a9f2+F8bJiA3eD ma5NFzP/QR20v1MSMW+GyQm1n3oISHlN50RYNzbOgYRKOeS2CvqhqAzruDSCqJ334K+3 W+Ow== X-Gm-Message-State: AOAM530/xREVtV16SL0B3Jvm9SVFFPP22EUGhJfrgTRPzNGR7H7w9Ka2 bdJ8Lelw6JKxgYZR6gOWQeX5WUVV X-Google-Smtp-Source: ABdhPJzqZc/z4r/UHRLY5gjvVwX2/nMQh9A9HJtvc75XxDNdtDZar5mIZLyYre3WNAwGzR2cSQrmjA== X-Received: by 2002:a05:651c:2cf:: with SMTP id f15mr1963921ljo.105.1592477294258; Thu, 18 Jun 2020 03:48:14 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id h15sm555894ljk.24.2020.06.18.03.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 03:48:13 -0700 (PDT) From: Andrii Kolomoiets To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> Date: Thu, 18 Jun 2020 13:48:12 +0300 In-Reply-To: <87wo44mzrb.fsf@thornhill.no> (Theodor Thornhill's message of "Thu, 18 Jun 2020 10:31:28 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > That was a lousy diff, sorry... Much better! Few more things: - Check if other-buffer is passes the predicate function. The buffer from another project must not be the default. - Exclude the current buffer from the buffers list to switch to. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 07:07:53 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 11:07:53 +0000 Received: from localhost ([127.0.0.1]:52953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlsOf-0004G0-5f for submit@debbugs.gnu.org; Thu, 18 Jun 2020 07:07:53 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:38903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlsOa-0004Fk-2q for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 07:07:52 -0400 Received: by mail-wr1-f50.google.com with SMTP id e1so5609781wrt.5 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 04:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/NS7PRVMdLFeK684GL6nah/22Ql4wAIn5/KyG0N53Ok=; b=vNkFX5yE8CEsMya9+Yg+CjkZMzwXUQMBDTBJnw+ZICzqPWJr9VnEwX/pI2twaEkbDd iXda5cPXKjeWH5bGCFhj59Ep2v9GelF7pwLKeW2q6Ez4kFZPfB/9xvdCpescXG0vyz6U tqGuagydwj/sHDwiOuxd80zSo81Zeas9lAM/I1Tyx27P9VTToJUm4TS8IDPw9ZryQcrf XxdmaRj9mwnw+WgIvxg73/AswNVSPDSakz7DadM5Yy3GGOFeoszPwur2mEGOIoiR1lDg Uxzd8F5EVCsn8D/R5eXjn+I2aQ46ujbVhA9DOlovOR/hdcLCNO99ZB3avp2UbX1I21xT an+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/NS7PRVMdLFeK684GL6nah/22Ql4wAIn5/KyG0N53Ok=; b=UC0J6DikzXUwMTlb7rMWkEsosaJkUx893zJfr/Qa1eYPsvb5c9zRZLSuZk+rNColPH r1gi+M/7rpu4UNGMKPvHCnWTbM7DBkXcQBolsnAcM9BXtFVYG0dcTEgdSAzvcghIYAFE nm/BZg3iLJ8BNyKLb3V7SbnXAa7/Pu1DpBXKnFL1jj+hOA+4+NyiZoo/Vx/t95wClicP SNpXZ55zqrgUBBco+khG/DG3e9G8U5CVClz6DFyRFC30I7iEyTjxu5yxbJlPz6Iik26i 9E+SoD4YA+gd8altiaQmE3MmIqkf6epFRyIOKYJVKPef66NTrHkWGGXiPRc8J/OtCPOI d/8A== X-Gm-Message-State: AOAM5328zoi/JEljZAycZz3GLR9+F3BljpdQWfZKMuDPepFvNW9p52zQ fAGVyjLzT2PBafTKXifOzZx2AzfA X-Google-Smtp-Source: ABdhPJwWEfRo4Xo+oibGeYM7/WS/QPCVihYBIpqno8fP5yW5ld3QpaQPjBaxUNvCQqET3PwQNOs7UQ== X-Received: by 2002:a5d:6b8c:: with SMTP id n12mr4052743wrx.61.1592478461911; Thu, 18 Jun 2020 04:07:41 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v24sm3594840wrd.92.2020.06.18.04.07.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 04:07:40 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets , Theodor Thornhill References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> From: Dmitry Gutov Message-ID: <77453219-1157-9013-aae6-ee9d9fcd9a14@yandex.ru> Date: Thu, 18 Jun 2020 14:07:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 13:48, Andrii Kolomoiets wrote: > Much better! > > Few more things: > > - Check if other-buffer is passes the predicate function. The buffer > from another project must not be the default. > - Exclude the current buffer from the buffers list to switch to. Perhaps a good idea is to follow the example of internal-complete-buffer-except (called from read-buffer-to-switch). From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 07:30:45 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 11:30:45 +0000 Received: from localhost ([127.0.0.1]:52959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlskn-0005Tq-2P for submit@debbugs.gnu.org; Thu, 18 Jun 2020 07:30:45 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:39490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlskj-0005Lm-ED for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 07:30:43 -0400 Received: by mail-lj1-f194.google.com with SMTP id a9so6782203ljn.6 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 04:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=v59Q7eHajwk2IXRgqnIv2RF6suPBjp26d9WDLp42bXY=; b=qawEAgD1qCVTQI1r5U5dlWhIsojrm51AfAv2q+1rSDzwvKuScuNp/bKo8hMFXaQUwg Dr7DtSvVtF/cGlvu40fEzGWGANezAjFbnH+1bXEUf14ZjxZFo0/CA+ctZKBXkj0yQRba KxNl3ptAbe7rhIOivcZaF2tjc1FQFDDiZu6vpz0nwqqyybPl0sqDRb0H02lRlo056vDP s3PEDf9vVU0ibDGl3EbYZ3A/SEfOvCaqDorkzCm6b+NqAcs9m3gdMZNb/LUxTUM8bteP bnvj5Fiw26EEecTcx6IAFCOsQSyt5mSfnGatQmJNiloVo/eODRjx60TRJtwxl/PsufFW IRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=v59Q7eHajwk2IXRgqnIv2RF6suPBjp26d9WDLp42bXY=; b=D+gK5CV0v1a+4FFCwiZ5FayHVL7esyVjYHIapP7dUgKKjJ6QhFTeK8tqMm9oEWSw2d Vzt6tYk8oX2bdEZQT7tHCnxueRjbHxaKRrqcZeSaZsp9Y5IJPyFB5eaHGuWYr23IFrLt K15+KXai1uls6JIPZ5hVvQZyzx8FYb2YpN2uOKDc3/sN3v4544b1DI8ntqpXAklxZrhF Pa61Rg7r/UR/P85WJtZxa+dSQDviowWg4ChN8H9YA/qha2/zjB9/nKPAy+0U5bC1B23D B4BSBMbekt94/60bsiWAJfOo9jS9IqlmJoLt1z0tqk1g5PaxZOHdC/RL0Mt8Csxq8pD1 qLQA== X-Gm-Message-State: AOAM530H9i2CUzdxgwvbwp/Pm+j7GuB21e47DZ9lpuDzjCeEGc0TP45G plVmfyGaNpV1plG8UoyO+ORw6bbu X-Google-Smtp-Source: ABdhPJxwndykWVuteDbyoEee4oholU+Qm9qWGrQbDml7XTGgIwpsGKWotIRxp3doZ0PihXG9ejpj0w== X-Received: by 2002:a2e:960b:: with SMTP id v11mr2139325ljh.77.1592479835000; Thu, 18 Jun 2020 04:30:35 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id a5sm602270lfh.15.2020.06.18.04.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 04:30:34 -0700 (PDT) From: Andrii Kolomoiets To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <77453219-1157-9013-aae6-ee9d9fcd9a14@yandex.ru> Date: Thu, 18 Jun 2020 14:30:32 +0300 In-Reply-To: <77453219-1157-9013-aae6-ee9d9fcd9a14@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 14:07:39 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 18.06.2020 13:48, Andrii Kolomoiets wrote: >> Much better! >> Few more things: >> - Check if other-buffer is passes the predicate function. The >> buffer >> from another project must not be the default. >> - Exclude the current buffer from the buffers list to switch to. > > Perhaps a good idea is to follow the example of > internal-complete-buffer-except (called from read-buffer-to-switch). Isn't it enough to check `(not (eq (cdr buffer) (current-buffer)))` in the predicate function? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 07:35:24 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 11:35:24 +0000 Received: from localhost ([127.0.0.1]:52972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlspH-00072p-VE for submit@debbugs.gnu.org; Thu, 18 Jun 2020 07:35:24 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:38231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlspG-00072a-7x for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 07:35:23 -0400 Received: by mail-wm1-f54.google.com with SMTP id f185so5292635wmf.3 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 04:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4NZ3wJk9G8A0R90e++/4dWM8fgyoYqAheEAo1/G39Tw=; b=RK05WIU9CEi9ZwCS/WTXmKNfg91qW9aT9Qq13Ant6VKwi5koWmGEAgTE9lrWLAQQgY Fh9liKjDn8nMmqhf/9DnPUfCZwYSJ0FB6Fr0EQmQxbw/DlRXJioUKbrM4AVCRosqKrJm /6LNBgJ5LGwqo7Hk9oKBw1szN7hUXj8LNKaxfyoX0iP5cmr1baOqH0+gQRZEBCgD0oGH Zc2Jt+xFmLxvpbY2cQUKH1fv0Mj4Eyc3Rekplfmw9pRWFBNCGUEUpiwjRoiilxkJNiKB X5P4jm+jL68YRGZ3SALrsQodKkeMYQf+/w2wLJZFPfhY/puOSj8Hhy8HuRwFnLHL2quu nmrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4NZ3wJk9G8A0R90e++/4dWM8fgyoYqAheEAo1/G39Tw=; b=IfyhaIiZKYQ+hEEPk/81VrdO9lQHYSKATAn2xGcqExEIfKbRCVDo4f7ZAz5LqrGnEZ NT9P+6MOPX3Ap/fakT1KeeIqhWDUJV+1wvVOY9i8OywsGixf3lJLB7hesWov08INy87A Def1SZLivLtPU6Iu/9WwYf3+WdWpMpP5dwnphTpzI5vj0LSQo5BPwacnF8unKu1Lgr8c qX1X5Ih6EBUOH5Coo8Ud0iR2ptdbI2g9LngQqWM4zecjAAnWl2rouvVeH58Eexq1zB0x L2d4ET6V4kH1h2JMelm7o1yZiW7rOxCe9QyZX7R6vdfA/f2yQIRG09LtwrdDuvZoRDWw SglQ== X-Gm-Message-State: AOAM531HxPwdUQr1hLUxYg76JuOpKhbkhqeULjR9YWeO/MCNjf/yw/27 wAnkWPcHDPtzwqz+uB1D1u+F/sgV X-Google-Smtp-Source: ABdhPJwVtoRGEKk+1SNNRc0skQGl6ePoWVVyx6JrwLKIMWsg99aBIwWu/c8Rd1E2BbLxPGnOSjvCjA== X-Received: by 2002:a1c:96ce:: with SMTP id y197mr3743195wmd.55.1592480116150; Thu, 18 Jun 2020 04:35:16 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id k14sm2994419wrq.97.2020.06.18.04.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 04:35:15 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <77453219-1157-9013-aae6-ee9d9fcd9a14@yandex.ru> From: Dmitry Gutov Message-ID: <55503aec-9c78-cb2e-a206-29718fe11c4d@yandex.ru> Date: Thu, 18 Jun 2020 14:35:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 14:30, Andrii Kolomoiets wrote: > Isn't it enough to check `(not (eq (cdr buffer) (current-buffer)))` in > the predicate function? It should also filter out the buffers where the names start with whitespace. Unless there are no other completions. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 07:48:03 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 11:48:04 +0000 Received: from localhost ([127.0.0.1]:52987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlt1X-0007LR-Mg for submit@debbugs.gnu.org; Thu, 18 Jun 2020 07:48:03 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:38441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlt1S-0007Kt-MH for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 07:48:01 -0400 Received: by mail-lf1-f66.google.com with SMTP id d27so3281345lfq.5 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 04:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=i+uYp1hXD3kQHkkNf4QBx0ibwLmCMi2YQi+B/ye7I0w=; b=InnrGUmwHJczte3cgzH+s1vt1ESRgWoWHoGLJc74gPz7fR9k1pZsU69hNtPklj8JSc 77LwqGjUsM127GdE0/+r/dt1bE4il+swmM43V6n4FwacQQgB1dPu9d+0ZmRLY/wLh+aN Q7MhVna1F5dt3TEKKPhX6Kj2mbh7EzCxJANKDAz1kBoLnU54hCXBwUKSt/zpHwcZh6Gk JuAEurAPkEdIt8p1yVL6krJomaATuc3z1wQ3geoA5UoU4K9YUBlismplfb4KhklqVY8A s5QjCQt6SKOX5FY/LLwlTSV3oVOtUMUAKCbDyaVYUIqSdlKfvd4w/zGks15zoK1w3Tb7 kLew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=i+uYp1hXD3kQHkkNf4QBx0ibwLmCMi2YQi+B/ye7I0w=; b=oHLLoLGIzCGvqFjFp85OUaiYGywUui8rx8xTifAJ36S3OcRxMPbtll82ZYo7VOEnk0 Bs6qAJG3FKLpA8BWuMeGdg4TsTs1ihmFTbpzfHYQy/x5DWtwBX+jScsB9ib+rYwb4cda 3c+ML3mmwRgPdGD2c/BUZKDHPI5xw7RycFM79ut0OCJKXZOYd8xgCDXXYTVrUf0oEuOw P6+gIb8Fk5MwxZG797T+5zrFSPfoLRC8Xd3Rmhv9Z/6zu2OYFl4x/bm8koaiw3pH8Bki nNPScDuuGkzkCg4AfuUgxLs98ptC9zNBBK7j5kGnqWWIimpmQVW9vINyX2fMOwEYFMsq /Zxw== X-Gm-Message-State: AOAM531/DWekyTspJLsSj7HSsiof4d5+xMs/oD45HEKdgfd2cQSWLWYp WpI3kAmXq1WXMeY75HUOMxja+zip X-Google-Smtp-Source: ABdhPJwepPaNjV6B4z+ULiYbt9nkZ8dK7U8cWmp3N6h9H8fjbcwUf/DCbk1lKPbLfwGTablSb9UbbA== X-Received: by 2002:ac2:52ac:: with SMTP id r12mr2161409lfm.175.1592480872080; Thu, 18 Jun 2020 04:47:52 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id a5sm611426lfh.15.2020.06.18.04.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 04:47:51 -0700 (PDT) From: Andrii Kolomoiets To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <77453219-1157-9013-aae6-ee9d9fcd9a14@yandex.ru> <55503aec-9c78-cb2e-a206-29718fe11c4d@yandex.ru> Date: Thu, 18 Jun 2020 14:47:50 +0300 In-Reply-To: <55503aec-9c78-cb2e-a206-29718fe11c4d@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 14:35:13 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 18.06.2020 14:30, Andrii Kolomoiets wrote: >> Isn't it enough to check `(not (eq (cdr buffer) (current-buffer)))` in >> the predicate function? > > It should also filter out the buffers where the names start with > whitespace. Unless there are no other completions. No, it shouldn't. read-buffer already shows normal buffers as completions on TAB and shows hidden buffers as completions after SPC is entered. See internal-complete-buffer. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 09:00:49 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 13:00:49 +0000 Received: from localhost ([127.0.0.1]:53052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlu9x-0000hl-Hp for submit@debbugs.gnu.org; Thu, 18 Jun 2020 09:00:49 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:39375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlu9v-0000hW-B0 for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 09:00:47 -0400 Received: by mail-wr1-f50.google.com with SMTP id t18so5971288wru.6 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 06:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZraWzjmuRSd6AgvfJS8PMJ/3ZB8GfiLYMyzDWDe1o3k=; b=lp6OAtold8EZs8jpHOpRjze6QUi329V3YNaqKq1E391dRQMLOlTRlo0CEwm17Qg69z jXqSETc+ea440gWNttaN4uvYSK9dB6k39nDJN3dHbiJrUkfPS8nI6zeP94xJAgBBgSfC dJ1jkR9oJtyqNByhbtbbddyWwER0n8QujncrTMSRgy9F+p1HkA1dp+MgXJlClMOV2bO4 NM8i3JPNqRbYg7Ao2jv/UYfOklpXR/BGfg7boY710Ai+GBThBXUF4rtMN3HZSqMlfr1F 1wd1Hh1BBNMf8cPGktbPf96C39ktn+qkAUtNHJ0sa6NcqdxtReyddMM4KVbUJc5PR8mD QNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZraWzjmuRSd6AgvfJS8PMJ/3ZB8GfiLYMyzDWDe1o3k=; b=qIFGhyf3w+O4iPe5MOarc3G8mAkhhg4Olak+mo7DKQSOMWUJHyp1txSf/u/Tkw4OLa oUIPKKPsmhfHhoRhveTrzv7IWz+5LMiufqj5lUETVTE/nbWimbgy9tvzXSUXDSSbJL/p Rhfh93r69v+KvaoV5vx2akYt0CPFQ9OeWyB0MXoLDq7HG249k5HSnsRkZ/N7QbajXSwM T8UnKw3RETOtFU0MgY4ZDROeTwLfAJDo/g4yjOZ8t6ahKOgKeJBE8W+I90bebtK//BUI Q6iJ7iH4rz0BVu9tXIqyysORjNcTny1tGag1Y1Zd6LQ8yLPQIUt+1aBVgRqv3RxFep1h 1Erw== X-Gm-Message-State: AOAM533t6JECcLIGEY+FioTvdlbz7P6q7nxt/8/OE62CCG5M0OGNscG5 dm0V7/803uNxq6lXRtBwFpTDJH1W X-Google-Smtp-Source: ABdhPJx7egrmGUM6u99OdicZGNY3RY8kdfePzJO6J0/uPeiuNuTlCmvVYNQ+A1l2ZOENEnKFWpg7kw== X-Received: by 2002:adf:e3c5:: with SMTP id k5mr3439749wrm.121.1592485241170; Thu, 18 Jun 2020 06:00:41 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id x14sm3479949wrt.60.2020.06.18.06.00.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 06:00:40 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <77453219-1157-9013-aae6-ee9d9fcd9a14@yandex.ru> <55503aec-9c78-cb2e-a206-29718fe11c4d@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 18 Jun 2020 16:00:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 14:47, Andrii Kolomoiets wrote: > No, it shouldn't. read-buffer already shows normal buffers as > completions on TAB and shows hidden buffers as completions after SPC > is entered. See internal-complete-buffer. Ah, you're right. internal-complete-buffer is used either way. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:03:26 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 18:03:26 +0000 Received: from localhost ([127.0.0.1]:54361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlysn-0006it-Vy for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:03:26 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:38722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlysk-0006ie-Je for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 14:03:24 -0400 Received: by mail-lf1-f68.google.com with SMTP id d27so4020146lfq.5 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 11:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ge5zUtB3lwm/U4GqiIJx1nmjlj7p1tZnyds+Ulf6+To=; b=EzXNsWa9AoaozF4DYcb9+s1d5Ut2l0jz4f/fCvxaFylQoV8cLZUvM4oG0e0zcPdGIO bMAcAlWnfG+HLvBKpFCDZyar6xAWBlrXPIv38+EtO/RikKN7Chh2buqzAmOIFKRc3RZd TrWzpbqdj0m3qxQHyNQzi3eFpT80pXd9kv7ff7vw4pE1TUY9ZRzi1+/7XdpSLRhJeic7 N9VCIyNU65sO8bYscBx/N51ce8UACToEmhiqMvddcTUlHt+LDgZn9Gjm0vwh2ZiYGazF zilEqsY6AdbzT8v/C5FEs1WDkg6EF38SpvLzNtG7VigzI9xIjn+M534vvRqHEprIfLYv IZ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ge5zUtB3lwm/U4GqiIJx1nmjlj7p1tZnyds+Ulf6+To=; b=LRWtGeKus+F/sMC7rZXfE2LUJGUCYV/AEnu1IPDwATmAZk1Emc0GWV9KgjAOrZyvz/ D3P8JI1BE0Hw248OP+2QxcAtPtyzFv9/oK72Zlsj1xunNoUQreaTQn8KyF6SdR9OEDKs SYIcZz74+M85xu0gAXILEP2h79ITPDak14682E8+Mx9nxUr4KI6ho+WPFCwBznQn9VBS JEbfVW/T+A0WPQeNkOmpTOhST/lZqXmEorKonYIRoQXVvxtNSQ1eA0Kt10er9NPDLoE8 uEGiJFNT0JWgpsc4KfIOy7cogGfCPUVccFOIbTHCSwcC2oU5OSlZpACmXWCOpDSmDX8j 8aIg== X-Gm-Message-State: AOAM530hp/cccZh2tzvWAwMG7PpRAECfgIJe5pZGhnEjuExbl+YiwMbM 5irpAAVGs8Flx1nDx6lEPNhKqm9x X-Google-Smtp-Source: ABdhPJy85J6SUBjYARODHAFQia2OQJwv/7XFnxFGNAWcs2QMiYMUP9M0Bk2pjHyd5VuLvV0Vmwz5oQ== X-Received: by 2002:ac2:5c09:: with SMTP id r9mr3028354lfp.176.1592503395980; Thu, 18 Jun 2020 11:03:15 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id x30sm534330lfn.3.2020.06.18.11.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 11:03:14 -0700 (PDT) From: Andrii Kolomoiets To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> Date: Thu, 18 Jun 2020 21:03:13 +0300 In-Reply-To: (Andrii Kolomoiets's message of "Thu, 18 Jun 2020 13:48:12 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Theodor, Please take a look at the attached patch. It's based on your patch and resolves this: > - Check if other-buffer is passes the predicate function. The buffer > from another project must not be the default. > - Exclude the current buffer from the buffers list to switch to. Thanks! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=project-switch-to-buffer.patch diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 7a41df614b..b8d5731a71 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -777,14 +777,23 @@ project-compile (defun project-switch-to-buffer () "Switch to a buffer in the current project." (interactive) - (let ((root (project-root (project-current t)))) + (let* ((root (project-root (project-current t))) + (current-buffer (current-buffer)) + (other-buffer (other-buffer current-buffer)) + (other-name (buffer-name other-buffer)) + (predicate + (lambda (buffer) + ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. + (and (not (eq (cdr buffer) current-buffer)) + (when-let ((file (buffer-local-value 'default-directory (cdr buffer)))) + (file-in-directory-p file root)))))) (switch-to-buffer (read-buffer - "Switch to buffer: " nil t - (lambda (buffer) - ;; BUFFER is an entry (BUF-NAME . BUF-OBJ) of Vbuffer_alist. - (when-let ((file (buffer-file-name (cdr buffer)))) - (file-in-directory-p file root))))))) + "Switch to buffer: " + (when (funcall predicate (cons other-name other-buffer)) + other-name) + t + predicate)))) (defcustom project-kill-buffers-skip-conditions '("\\*Help\\*") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 14:50:09 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 18:50:09 +0000 Received: from localhost ([127.0.0.1]:54410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzc0-0007qu-RV for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:50:09 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:46167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzby-0007qG-NV for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 14:50:07 -0400 Date: Thu, 18 Jun 2020 18:49:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592506200; bh=oodhNI5lzBHoUr6BYgMTtxJ9SYCGKomkNw5HsIff+sI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=TNLdMsbRY/Ed2HIOzqSeigC9Snvk2/S2i0sdaKA5/6NpwfhcpxLsLl3yn00o8DURr +CvCqoulrGkGTMQvu49P5i3yQrOufLH0znwGhp7WZ/XvFVCZBAjjUu680M2IuXPzmh iI3JtSnNQ6TuU015i6b+i30Vtuo6A5eKhQ7D5J7mjNPMhfHEqbDgSxoWMQJo5vHU3y scvojZtZFAXqnH9GqCFDTT0Mh0NRJnBA+92Vy0NOI3lUdiojSNg2PrxWEitp49l2J3 JUwFpLcUdmiZLOxXev5or5SyVYH/BRasKI9YjBKx3ymroCuAAQkUY+admo8fHr/Mwe LCMxqebrP+hcQ== To: Andrii Kolomoiets From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: <87r1ucmcok.fsf@thornhill.no> In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Hi Theodor, Hi! > Please take a look at the attached patch. =20 That's very cool! I was sitting right now doing something similar, but you = beat me to it. Sorry for not getting to it faster - life happened :) I was struggling a little with the default buffer part, which you solved by= kinda not solving it. I was trying to determine in some way what buffer w= ould be reasonable to offer as default value if that predicate fails. Mayb= e it is best to just return nil there as you do.=20 Maybe just one thing. Eli addressed the docstring in one of the other func= tions as being a little ambiguous. Maybe update it to something like: "Switch to an open buffer in the current project." In addition, maybe adding a small comment above the default value predicate= , explaining the relation to the undocumentet structure used in this functi= on. Or not, maybe it is clear enough given the preceeding comment.=20 Thank you for bringing this up - and fixing it! Theo From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 15:36:12 2020 Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 19:36:13 +0000 Received: from localhost ([127.0.0.1]:54465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm0Ka-0000gC-M0 for submit@debbugs.gnu.org; Thu, 18 Jun 2020 15:36:12 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:54213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm0KV-0000fe-7U for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 15:36:11 -0400 Received: by mail-wm1-f47.google.com with SMTP id l26so6308823wme.3 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 12:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LOzXU2hg/5ds+Lqv5i5FwKGEbcYGj+Xhm1nuyS9GQZA=; b=cd+MiT7PjfcTTzmuRjXvHI6NzRlv4KQs5F7jeZ8VUsT2jGQeBJnmUSWDu72+GczrIj IK9qmyBOiw3POztVlA04PlYyPbDC8dBpwoBNLY+up5lgxDhkTcf8ELXzhoPO0G34vDzp AO7qJ0aFIKcjUp3im3ZCuVCn0T3NWViqjjOIbjDLlvz3brCrE/B8mCMA/pPUe8tvGDiP VU09+pdzqSUeMADiUm9Myrvs5w5Vqma2KmFu2/iFkOTOTnH4ZO+QKwETyQp39q00cHXD eKTkC2I2rRyDwfuh2GR5GUfXv0beG4B52eVETQo9yW4Ll2RxgjsiDlbID2ZVAXfufcIs MOeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LOzXU2hg/5ds+Lqv5i5FwKGEbcYGj+Xhm1nuyS9GQZA=; b=pj1Mq1+MnrV1utQaL/r6cX+vty2GLaJJcU1vlmEyH0+x/EJVYfIqbI2Yhhj7/VkZ// XfJszasH5uyN3fSOXF5F4KuGA86nViATZicm13OfshvJG0++hGb0Dz4s2/7AsvU8KmhL HYq5JD2ZjP9mXpzhWj2uwvwGYgZZadUBsNQiA0vE62Zmn/+PLam3Fo0PFt8qC/WqGuQO 5MOb2tLI9RAAggADS2VlSFOYYmqIFV+H6n65G1SM59ysABg0Y4iu+BA6EYV0FgF0ZTSc GBFYuWXwdEkQOYyqQvLAltUetuGqaAnw3ccco5zevBf6lfvCwGLGQkIghB43AtYJ6i0R /rLg== X-Gm-Message-State: AOAM533CDIdrBuXRrqOjaEJXSm6Dh2EoogzQq9yUl9D7JDQyNpo8M4mT O+uCpoanqtVqfQPwwNFhAqnzOA== X-Google-Smtp-Source: ABdhPJxnBv9Q8eyuAbfqCwv3c5QkKLG3keI/DqYA2qJtLsu6HdctO1/CFhJAiZmfJVKfHP7DqthwIA== X-Received: by 2002:a1c:e914:: with SMTP id q20mr5393251wmc.145.1592508961301; Thu, 18 Jun 2020 12:36:01 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id z12sm5153824wrg.9.2020.06.18.12.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 12:36:00 -0700 (PDT) From: "Basil L. Contovounesios" To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <87r1ucmcok.fsf@thornhill.no> Date: Thu, 18 Jun 2020 20:35:59 +0100 In-Reply-To: <87r1ucmcok.fsf@thornhill.no> (Theodor Thornhill's message of "Thu, 18 Jun 2020 18:49:52 +0000") Message-ID: <87tuz85fq8.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Maybe just one thing. Eli addressed the docstring in one of the other functions > as being a little ambiguous. Maybe update it to something like: > > "Switch to an open buffer in the current project." FWIW, it is unclear what "open" means in this context, as it is not a term commonly used to describe buffers. Possible alternatives include whether it's displayed somewhere or buried, whether it's live or killed, etc. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 20:43:30 2020 Received: (at 41879) by debbugs.gnu.org; 19 Jun 2020 00:43:30 +0000 Received: from localhost ([127.0.0.1]:54725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm57y-0008Mv-5H for submit@debbugs.gnu.org; Thu, 18 Jun 2020 20:43:30 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:55377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm57v-0008Md-Ao for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 20:43:28 -0400 Received: by mail-wm1-f47.google.com with SMTP id a6so3525392wmm.5 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 17:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6kozbbVsd63FUywN32U8Pj4/zzOJowL7JqEuQ6cUmpU=; b=pxPI99SKGDGN4lA2f6YJh5/sTHWFqCihs818jPiEqB1Soh9h8hwamgQhGe23UbkS4d ujQRa9BajaCXfjO++PRarNwKVnWxU9ICf11RzkqfwkYWmMRnOySMmrJAjiZVKU+Rtrwv WwW5Cde8qIsfrq2Li4I6aQFiUNJ1CQVaP65nYha65ij4ePI1abauVy9xV8TyqBhNp7d6 kf4h5A1GJzafhJTg0LqOYpnR8M+slF6QjPRgW2OLMqFdv5pbFOxGQZwx7wGNLgNC7pXi stjqvkWNISEZiTl5PeveN6jwVyxfkWWKgmaYwjHJDjZn0uvIha28K/C6ZYG5hjdKSv4D pc/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6kozbbVsd63FUywN32U8Pj4/zzOJowL7JqEuQ6cUmpU=; b=i1+MVI1pr4RJdqJZanQjuYern92PK59oltyJv+Dz27fBTd+xC6UHPXTBmMpbHmgZ8M qsOCqA/D/bbeO4N8h6/dlx9qijFLG51Yd1ilAnGeMdHBZzFiHw224WBiyLsJLIjQYPZ8 jCV1ZbUvf6o+MXGitT4eg03prdwxWtveIp7893YL2wyN6O23gf1pBxipB3PfNfFpeu8w 7sIoHTpJBZtC2uMaxRohNGMKVA90ZtnFhjSzdKbuHuXe4tE4l0ERN43mY+HUa6wrVg1J mMc6kaeeOysuWUCZaqnlTGnvj8l+PI8QhumqWp5O41RzY5jYGKGUxC2VF7MFyt1l7yBx LZyg== X-Gm-Message-State: AOAM530HHA9TfORIndVCccb9D4lHm+1PSbFSOyF/FrTOsTKe2+iQyiIi QaHxJrRUT8SaRk6moGX3A4g= X-Google-Smtp-Source: ABdhPJzu2ph1EfIK54bzJyPzIZpaIvnqr1sq5gCK1lmVOkyxciQeCA3tdH9XYKa9klJZRgAW4akf9g== X-Received: by 2002:a1c:2901:: with SMTP id p1mr955120wmp.144.1592527401485; Thu, 18 Jun 2020 17:43:21 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id j41sm5632722wre.12.2020.06.18.17.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 17:43:20 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: "Basil L. Contovounesios" , Theodor Thornhill References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <87r1ucmcok.fsf@thornhill.no> <87tuz85fq8.fsf@tcd.ie> From: Dmitry Gutov Message-ID: Date: Fri, 19 Jun 2020 03:43:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87tuz85fq8.fsf@tcd.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 22:35, Basil L. Contovounesios wrote: > FWIW, it is unclear what "open" means in this context, as it is not a > term commonly used to describe buffers. Possible alternatives include > whether it's displayed somewhere or buried, whether it's live or killed, > etc. And it's not like any command is going to help you switch to a killed buffer. "Open" sounds like a tautology indeed. Here's a option from me: "Switch to another buffer belonging to the current project". But personally, I think the current docstring is easy to understand already. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 18 20:45:54 2020 Received: (at 41879) by debbugs.gnu.org; 19 Jun 2020 00:45:54 +0000 Received: from localhost ([127.0.0.1]:54729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm5AI-0008RM-JA for submit@debbugs.gnu.org; Thu, 18 Jun 2020 20:45:54 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:42452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm5AH-0008R5-1e for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 20:45:53 -0400 Received: by mail-wr1-f48.google.com with SMTP id o11so258760wrv.9 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 17:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i9fKYPOS2mUZsKeOA+58+DFY78Yxs6LJqwesRsngxzw=; b=mre9GNBsMtwcwYjWEE3Sb33QevMhiKahvYkNsG+4cWEM6dV3TSYwBMFAyk19vzOgaT PJSMh0HcEDn8szJMURR+HwZm3x4+5sAQG6Y74VQu1D4ZFvI5+etmUbF69VgWYR1i4aFy 1zKLzZyrEptNX1FQ83IP+Mjvjj+FiXJxG0dazemwYc09opZqEiZvo+BFJ5Nm3liiLHpV cRX01P1g2PiE0p4y6AV100+9JmQGM3Ejh+YBqnnFGaRxg2z8IwPqhc1aZoDdItaBqJ49 VIhNGWXf06y6hEqPzZCVWajF/Eb5GtoSe48J62NrDzBa63e2mxjXw1U/svJY0PUFEig2 MA/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i9fKYPOS2mUZsKeOA+58+DFY78Yxs6LJqwesRsngxzw=; b=sX1IcuUQo5e0sVtZ4u0t5lzVIU28YiMd7EDqqcEhcJQFQV2WdfYoEq/6rLR8gJq5gt jrrV+w6bARa/XNrd54J0Phfhl0CqSXGBTJCJX+TJeEHMhecbArabbqxIX6E7peap4f9G XtUzqYKfqTIaWB8GaPWWW9xobFMW8FZOZoFMOldKXuktDkHv1KwLizfbDbo4YSD42OEG ephxtjlAipPeF3Z9eY1v5CWW/RXvZyV7pfKf/a3c670h7Mm5nPA5I2QANFFt3wEttHva ayYV1ijrHp126c7IoOGOesXVab9uQrj/MePxVvHTK/UjdV6x4MGBux/TtMHZXGy2P2CQ L+QQ== X-Gm-Message-State: AOAM5332uqRLFZENUg20UF1q17fmLxRVJGb1gA+dhJN6LZC+8SrowhuX AEcB+7dl+8PkIgFhEap7s+aU05Kh X-Google-Smtp-Source: ABdhPJxXHV39AIqsTcetL/weJYsD7PcfmJGZ0wQWTrSZDdwsu123e9//wW7KfT2pt4T2kyc0fPp/5A== X-Received: by 2002:adf:a306:: with SMTP id c6mr1156313wrb.122.1592527546923; Thu, 18 Jun 2020 17:45:46 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u13sm4886784wmm.6.2020.06.18.17.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 17:45:46 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets , Theodor Thornhill References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> From: Dmitry Gutov Message-ID: <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> Date: Fri, 19 Jun 2020 03:45:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.06.2020 21:03, Andrii Kolomoiets wrote: > Please take a look at the attached patch. It's based on your patch and > resolves this: > >> - Check if other-buffer is passes the predicate function. The buffer >> from another project must not be the default. >> - Exclude the current buffer from the buffers list to switch to. > Thanks! Thanks! Pushed. Something to consider: switch-to-buffer still allows you to choose the current buffer. And the new command doesn't. I'm not sure of the original logic behind this, though. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 00:50:42 2020 Received: (at 41879) by debbugs.gnu.org; 19 Jun 2020 04:50:42 +0000 Received: from localhost ([127.0.0.1]:54800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm8zB-00061T-VE for submit@debbugs.gnu.org; Fri, 19 Jun 2020 00:50:42 -0400 Received: from mail-lj1-f176.google.com ([209.85.208.176]:43593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm8z9-00061F-TJ for 41879@debbugs.gnu.org; Fri, 19 Jun 2020 00:50:41 -0400 Received: by mail-lj1-f176.google.com with SMTP id n24so9918070lji.10 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 21:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sOyqS/6QFYBgf8ToM3ePxKWsEndPoALvsJs3lIpFeJU=; b=qkNDaVEsQAgAqTs0PLtc1CpeIZaxlhqow8fmJsYTlYKmXrupz5paybbpEdWcKXle8D 9QqRTb6IcYzX2G6GuL7yGtSvk2bTsP9QcKixKx9PhoyKUaIUdblq6i3HWEiC5CM6AhMz K5WoOqYIue6H3qPM4uIXKEDZknOIMXlUUXvXcr5eN642357NjA9Ko3XulxN+qkb7qP+K O71AEYnH5c+jlvFZBc+bPWKmJE7Qr9ZLHe7bC2zsWXx8oQqB62R4qJZkzDVf4d0AbFmK ZykPRw4gtORGARdKVv7PbnwNHDubHd/4kSVpv2E6p9xFKlDvRkgqn8eArzvFIMF4nrA4 SW3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sOyqS/6QFYBgf8ToM3ePxKWsEndPoALvsJs3lIpFeJU=; b=gy0Fx6y7oowOFFbxEkSkwqv35kha+sTjK1SkBwQb01gxTZGSY44yAhagtxS8r3aZ8M PNrgoqyuqH9WDdV3mTDCmSN3V+P4SXl7YcnfBcm4MC6yPd3OrGEIpuGTA9p025v/6Wzt 3a2CUjRXTP2uuYDgAiFV9pUHCOPGVFFt8YEokXNBwLkl8MwqrVpX3OEWN/45zAkOH3PY h8b7jkGusHx9KXDAcTgc9AY92X5hSx37p3tlzgEtoBYOKdAWNWN8O+eQ73MF9NGhO7un 4oE2PhnfUnCu3cDkMG8vQaAzEDNYe1MLaZauAmONMxBeXzPNPjDPwxY9M2rDD81rA/t3 xniw== X-Gm-Message-State: AOAM530ug1n97DuIcG9ndEs5LMUYUSyw5RGM4UE7U4i2QM4CCa/VDoNC E2v61bF8BMH4/4pWEE8+2GDSGiKk X-Google-Smtp-Source: ABdhPJxFETSd2vEmRIAv4L8Fabfx5aUUcpNS0pIX2DVvoqGT3fUGsy2o5KJd9eLh5d0S+l/BEY8gKg== X-Received: by 2002:a2e:541e:: with SMTP id i30mr797512ljb.156.1592542233360; Thu, 18 Jun 2020 21:50:33 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id 24sm1170832lfy.59.2020.06.18.21.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 21:50:32 -0700 (PDT) From: Andrii Kolomoiets To: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <87r1ucmcok.fsf@thornhill.no> Date: Fri, 19 Jun 2020 07:50:30 +0300 In-Reply-To: <87r1ucmcok.fsf@thornhill.no> (Theodor Thornhill's message of "Thu, 18 Jun 2020 18:49:52 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > you beat me to it. Sorry for not getting to it faster - life happened > :) No problem at all. > I was struggling a little with the default buffer part, which you > solved by kinda not solving it. I was trying to determine in some way > what buffer would be reasonable to offer as default value if that > predicate fails. Maybe it is best to just return nil there as you do. Or we can pass the predicate function to the `other-buffer` function so it will return only buffer from the current project too! We just need to make `other-buffer` accept predicate first :) > Thank you for bringing this up - and fixing it! And thank you for the original command! One local function less ;) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 00:59:28 2020 Received: (at 41879) by debbugs.gnu.org; 19 Jun 2020 04:59:28 +0000 Received: from localhost ([127.0.0.1]:54805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm97f-0006DY-SU for submit@debbugs.gnu.org; Fri, 19 Jun 2020 00:59:28 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:40982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm97d-0006DK-VC for 41879@debbugs.gnu.org; Fri, 19 Jun 2020 00:59:27 -0400 Received: by mail-lj1-f171.google.com with SMTP id 9so9969537ljc.8 for <41879@debbugs.gnu.org>; Thu, 18 Jun 2020 21:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ts2s2FAfWHpeiIXmv5HZAKrwODjLSUr5RleXN6PDB80=; b=DL0smT+0ud48gTzVYcowVG4DatKN1qsq+ftiagtUbhUfT5FM3IncrQlgT13HF7vnjW 21ku7s7VfX3/ukCMDZzAttytci0KAtR86MrdAKlEWqoccPwDEK12osilGpRhCVHv3V2M Vo6qnWl0MOZO609bMvrz6ET76k9Hdqkc09I9F8kXfEoOtDjfkatZfk9r3WiFFkRkc/yo GUdI8t90zyP5hyMYtO9unx1tqQaIhPvLvgNuaVxcA7jlvW+xnXndPl90whci4kJ9rGx3 fZpHxCMir3Z2bnjTMkie4JpvB5Wk89GkSFGp8H+Xl3SG5QFDiRaiIR4zMgM4NSuz4RXO OwZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ts2s2FAfWHpeiIXmv5HZAKrwODjLSUr5RleXN6PDB80=; b=bYKiUGOeX/o6TNdzVJtt+fOrSzkJ8yYkLSoNEKJnT/McncwoJtGMTrJjYpZjJrzuwv 1SaRfeMIv2wFAQbKFIIuKLJEaGgQLbL2vZw1AVgoR521hBbz90OnsRJGpJUAYuVb/jNO HGUxJc+w6kh2CGXSIF4RwtxIfcfW/0SGF+m5FArQ8oXw56QA7AelZDqNmQdQMEWLuE6W De25e4/pumbi/VhJJg8D0zFjDk1cJztTxvGdceQyndpX71xWwF5RemyHQiNp2ZDXDL0d UwGSWmztRbh+EFYW+KIX9IpsyyMt6bSrTc3qvBXHJ1CxA2jJK9tyUL69lbxp2Upw0CzF VeQw== X-Gm-Message-State: AOAM531uXFQSYdQn+U188a73VVRzS02kCCRwk2qVqocMpULDt5g0VTJl UabeM4QrkaiV1UJPWrLxjUWqvEry X-Google-Smtp-Source: ABdhPJzCcErUI3wjTzbWwlfyzkXYC2A7Yx2dqpDw087idA7ofgSkrsi24oThZmkdFgE3B01y26tdNA== X-Received: by 2002:a2e:3603:: with SMTP id d3mr790930lja.259.1592542759513; Thu, 18 Jun 2020 21:59:19 -0700 (PDT) Received: from muffinmac.local ([91.206.110.148]) by smtp.gmail.com with ESMTPSA id w20sm1174523lfk.56.2020.06.18.21.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 21:59:18 -0700 (PDT) From: Andrii Kolomoiets To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> Date: Fri, 19 Jun 2020 07:59:17 +0300 In-Reply-To: <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> (Dmitry Gutov's message of "Fri, 19 Jun 2020 03:45:44 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Something to consider: switch-to-buffer still allows you to choose the > current buffer. And the new command doesn't. Furthermore, by not requiring a match, switch-to-buffer allows to create buffers. > I'm not sure of the original logic behind this, though. Theodor, can you please tell the reason why is REQUIRE-MATCH set to t in the read-buffer call? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 01:28:10 2020 Received: (at 41879) by debbugs.gnu.org; 19 Jun 2020 05:28:10 +0000 Received: from localhost ([127.0.0.1]:54810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9ZS-000715-7h for submit@debbugs.gnu.org; Fri, 19 Jun 2020 01:28:10 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:26599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm9ZO-00070U-Iv for 41879@debbugs.gnu.org; Fri, 19 Jun 2020 01:28:09 -0400 Date: Fri, 19 Jun 2020 05:27:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592544480; bh=4xutuNhBFSV8Q7MaX5qEzRmFDJ3kitp5tT31M14JISw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Tal82mWCKiSrs/kfNiBkADKOiEqru8XXPPpa9rmMl4YRhhQnl3rWmgshUFy1/2Pin fDa6oe6Pt72TmUn838YqJrLfiYYFwj8t458S1V52YQBH0oeVym5PbaS8S91sN/ksiO W4KrPwGHHWlVIPyraY3EFx1LwAWYJDnbT7wYdEiI2Vs961nGnok16xTlu/5q63uczW Jwk59pXbD1Mlrf18nBKEozT/EI1rk9NHZ3ptGcnbw+XvURCBbYE6vyG87kZrkCEU4n YGTdVteVODCUQnB2tyvdL6eEMutrk1MfsV+nVdD6FjQb1DE5qr4Gu+2AGBgVWw6uyQ NDBNKiLf4wquw== To: Andrii Kolomoiets , Dmitry Gutov From: Theodor Thornhill Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Message-ID: In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_NnFkNSe6MSFyP04iNF2fAyf0FsTJcPHEkWYN1HTppGs" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Theodor Thornhill Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_NnFkNSe6MSFyP04iNF2fAyf0FsTJcPHEkWYN1HTppGs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 PiBUaGVvZG9yLCBjYW4geW91IHBsZWFzZSB0ZWxsIHRoZSByZWFzb24gd2h5IGlzIFJFUVVJUkUt TUFUQ0ggc2V0IHRvIHQgaW4KPiB0aGUgcmVhZC1idWZmZXIgY2FsbD8KCkkgYmVsaWV2ZSBEbWl0 cnkgdG9sZCBtZSB0bywgYWN0dWFsbHkuIEkgY2FuIHNlZSBpZiBJIGNhbiBmaW5kIHRoZSBtYWls LiBJ4oCZbSBmaW5lIHdpdGggaXQgYmVpbmcgbmlsLCBhcyBpdCB3YXMgaW4gdGhlIGZpcnN0IHBh dGNoLgoKVGhlbwoKPg== --b1_NnFkNSe6MSFyP04iNF2fAyf0FsTJcPHEkWYN1HTppGs Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 ICAgIDxkaXY+PGJyPjwvZGl2PjxibG9ja3F1b3RlIGNsYXNzPSJwcm90b25tYWlsX3F1b3RlIiB0 eXBlPSJjaXRlIj5UaGVvZG9yLCBjYW4geW91IHBsZWFzZSB0ZWxsIHRoZSByZWFzb24gd2h5IGlz IFJFUVVJUkUtTUFUQ0ggc2V0IHRvIHQgaW48YnI+dGhlIHJlYWQtYnVmZmVyIGNhbGw/PC9ibG9j a3F1b3RlPjxkaXY+PGJyPjwvZGl2PkkgYmVsaWV2ZSBEbWl0cnkgdG9sZCBtZSB0bywgYWN0dWFs bHkuIEkgY2FuIHNlZSBpZiBJIGNhbiBmaW5kIHRoZSBtYWlsLiBJ4oCZbSBmaW5lIHdpdGggaXQg YmVpbmcgbmlsLCBhcyBpdCB3YXMgaW4gdGhlIGZpcnN0IHBhdGNoLjxkaXY+PGJyPjwvZGl2Pjxk aXY+VGhlbzxjYXJldD48L2NhcmV0Pjxicj48YmxvY2txdW90ZSBjbGFzcz0icHJvdG9ubWFpbF9x dW90ZSIgdHlwZT0iY2l0ZSI+PGJyPjwvYmxvY2txdW90ZT48ZGl2Pjxicj48L2Rpdj48ZGl2Pjxi cj48L2Rpdj48L2Rpdj4= --b1_NnFkNSe6MSFyP04iNF2fAyf0FsTJcPHEkWYN1HTppGs-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 07:00:39 2020 Received: (at 41879) by debbugs.gnu.org; 19 Jun 2020 11:00:39 +0000 Received: from localhost ([127.0.0.1]:55213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmElD-0000gQ-GO for submit@debbugs.gnu.org; Fri, 19 Jun 2020 07:00:39 -0400 Received: from mail-ej1-f50.google.com ([209.85.218.50]:36520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmElA-0000g4-85 for 41879@debbugs.gnu.org; Fri, 19 Jun 2020 07:00:37 -0400 Received: by mail-ej1-f50.google.com with SMTP id dr13so9737663ejc.3 for <41879@debbugs.gnu.org>; Fri, 19 Jun 2020 04:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I9nCnFxcB1tmJk6o5tBS+O+DtMXNplI3InCZtPIJs8g=; b=P5JRa/et/vcNTk3ifEyUfTX/zWzIkyZIU0/4fA5K0PGotI1tzbP7mT3p5XH6gYTzKb qNk4How3gSqHsHBuHjXmnHicZ2HImqgxLpaHmnjWuCi6+WfTzSqqdktHeyAMCFnOoDAl wLJiP8+lfeqbC+6SgWPKKr9pQ5v2FoF/WW2Bo9U9yKrzqIYer8R9BjJvANeFcPiWNsT9 mXZ3mPSL42V+rUIicPz/U4HIWFA+Ohvk3dz53de1kkiIpIjlXwHM9PTU7Id4TM7tSckX hRPyQyrCifFZDHSc2Iiz8PNo6BuYEAbg9ltuG9iDxdOo9ITkqF7BojksUSLoveob9v9D SpRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I9nCnFxcB1tmJk6o5tBS+O+DtMXNplI3InCZtPIJs8g=; b=L65FUAyKLcxquQMYRwCSIYqCyB/gxUni8BFBW7fF45qwMN0kIve+i6fa1QFoy/+pFa lWSDLf4O2gu9NTTpUBTmqExP+y2nzj1l8ENpwjQubp07xcgoJ1B13HblMUwia1EzV2cj BvCO48WBMieFb+Zpf4gGyt/A3CFRP/5y2e+5jRWuVioBIJsrdQZSFUI31ncYLD6uKXqE P3ydPD1+pZz7lpz0GiuYa4hN7w0vBgdEmVylpVfvWV98HWAo5sRaT/eAoBkzAhiQbz27 SO3fesNvXnLR2kFwtZIwY//zFQesaIkQVGgHzmdS9CL0IrD36GnPzU2hi8cBqO6c1f6V eODw== X-Gm-Message-State: AOAM532Q2Bdh31NvOMBsjCpqv6yeNyTlyJM2xWxJckibUWlPIHHed5t5 cUT1a+WK8reYS+uMRUJOMaE= X-Google-Smtp-Source: ABdhPJwrOLD6dKurXKH41K89WcfN6ia80I7W7PY7wwUfaYrYWI58AbKuonu+H69u3TtD0AxomsZn6g== X-Received: by 2002:a17:906:5e07:: with SMTP id n7mr3015074eju.48.1592564430102; Fri, 19 Jun 2020 04:00:30 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id fw16sm4483042ejb.55.2020.06.19.04.00.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 04:00:29 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> From: Dmitry Gutov Message-ID: <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> Date: Fri, 19 Jun 2020 14:00:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.06.2020 07:59, Andrii Kolomoiets wrote: > Furthermore, by not requiring a match, switch-to-buffer allows to create > buffers. Right. Do you need this ability? I would imagine switch-to-buffer is always available for that. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 04:36:12 2020 Received: (at 41879) by debbugs.gnu.org; 20 Jun 2020 08:36:12 +0000 Received: from localhost ([127.0.0.1]:57261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmYyy-0006xR-L3 for submit@debbugs.gnu.org; Sat, 20 Jun 2020 04:36:12 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:37110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmYyu-0006xD-ED for 41879@debbugs.gnu.org; Sat, 20 Jun 2020 04:36:11 -0400 Received: by mail-lf1-f41.google.com with SMTP id i8so6884906lfo.4 for <41879@debbugs.gnu.org>; Sat, 20 Jun 2020 01:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=t442OTnxoFtxz60ZYyNeaMlsHtAv/WtyYZRq652Uivo=; b=TfI5Jw+3pOQRhcdMg42ZmRTd94TcNSb3rkFICUjkwam2epr6com9qlayNAn5Puw/e7 FZBvwPsv2DJJdp/vVgl2QTxNVS37YiG3WumoxDBfU70Ef3PE9nZ2LAgMb+9fgRVT3V6O /YkPpMu8sqrCqyv39sKOrFExVsAlFO7G3l6M0gxexcvvVApI2yVr6yc1t88hBRN7QrBn O5dnWaNwJ8Yibb4kyu/esC+fjceyvRiBiQIyPm7Y7yAoAUNGK6fy9Qx/CeeqThH1mKum byPPfT/hsK9L5o0CDJ1SPT0wbAud4bomGO8SHYMY919yk+ChtVjyqcKU6IQCeMx4ZVzq ttDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=t442OTnxoFtxz60ZYyNeaMlsHtAv/WtyYZRq652Uivo=; b=hBkTquYp8rij26Si1G1oCIKUxg/mF29mxrGByr7oqOnTDF/o5ABpIrU/lGjeCW2LHu mKT7qjOCly2+QvoiA3x8JgYZUNhfXgXIVucSB254xYOdeyRne8X21baGC9MUMdG53UwG /ZYvtT0DdlhxuTyny3YvSX/dVTpXlYdAAJENsM8llr4pgKtGfd2cDPy99tzrRE/tGFI5 9EdINavJ7l+9qC0m5CER4OuCIQO5hs1XwJETm8bOGIXr23s1tSlS8BfjqG+lHpfyopoE IWc0OggoOtXPvVmbGNqhDf8BYguCNxi9VeO1eKVCS3JUM9Zs3zi31izInvpWYyHGMmla V+Xg== X-Gm-Message-State: AOAM530llegHZGzUk7Y8KtL6ghjz8Pc4P3cTPXd9+CFG/7+EHYL1nYaf H/WfYfTG0+h/LsMLjKJTii0= X-Google-Smtp-Source: ABdhPJwLKZp4PwkpU9GMiJn5u8w8swGVgJYfLr+BUdyjEsJRE6k+lL0swZsRil+rpx76Ga7Hwwa/JQ== X-Received: by 2002:a19:740e:: with SMTP id v14mr4142273lfe.62.1592642162149; Sat, 20 Jun 2020 01:36:02 -0700 (PDT) Received: from muffinmac.local ([91.206.110.131]) by smtp.gmail.com with ESMTPSA id j17sm1586167lja.30.2020.06.20.01.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 01:36:01 -0700 (PDT) From: Andrii Kolomoiets To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> Date: Sat, 20 Jun 2020 11:35:59 +0300 In-Reply-To: <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> (Dmitry Gutov's message of "Fri, 19 Jun 2020 14:00:27 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 19.06.2020 07:59, Andrii Kolomoiets wrote: >> Furthermore, by not requiring a match, switch-to-buffer allows to create >> buffers. > > Right. > > Do you need this ability? I would imagine switch-to-buffer is always > available for that. Well, I rarely use this ability of switch-to-buffer. I can't say I really need this in project-switch-to-buffer. But to keep consistency with switch-to-buffer, project-switch-to-buffer should behave the same. Also, in my understanding, match is should be required on e.g. killing buffers when existing buffer is required. Because switch-to-buffer is able to create buffers, I can't see the reason why project-switch-to-buffer should require the match. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 21:05:08 2020 Received: (at 41879) by debbugs.gnu.org; 21 Jun 2020 01:05:08 +0000 Received: from localhost ([127.0.0.1]:58985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmoQ0-0003sZ-25 for submit@debbugs.gnu.org; Sat, 20 Jun 2020 21:05:08 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:37538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmoPy-0003rv-2v for 41879@debbugs.gnu.org; Sat, 20 Jun 2020 21:05:07 -0400 Received: by mail-wr1-f52.google.com with SMTP id a6so11300073wrm.4 for <41879@debbugs.gnu.org>; Sat, 20 Jun 2020 18:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Phh+N1WKkcWEy1KVUAohzEFiVbq5g0cWddpTTahm7sk=; b=UuKAKfS8UKfUUBfqdXgocrN46g1yy55nvVVYdO/iOc34Gf2M3I3HSSVP2GZOAqZhJK 0zOrYLrCo2DrbIHmAm/6JETCOYkSzztnBY9yToIw7ImAZ3pe1xz9Vhx9krjrM400MI7K Re/Tt08ixj4PYGIW4PNp+nccpXjVmHttBal6McmANDdg+cBPRp0i20mvPe6+uFuT2pT+ 05CYPHTCU562NxLNOUxbNzPOdecJKxfo6LpJjNR1OJtc9q18d7x+AsNzbQ4r2mWMc8Wn QuPp/XIR32Td0azSCJdpTlpDWtyrB0soikoEsi1Y16gXDI9Bm3Ut7T8Xq1GYgjnAe+19 XpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Phh+N1WKkcWEy1KVUAohzEFiVbq5g0cWddpTTahm7sk=; b=G+RET6oVtN5844Q5z0o6cAuvg7Lp2/AymEcrHUOfdBBv8+7GDOB1PhfNX2Nhn1hm+4 KBWyvzLsYgLrrDRKUJkVGBXL4EEi32qN9DolFw/agtARTmXNBemQLfoFwCU10Cam1fkt oL0dAP0SXm4kqv1Uiqm4JfXBKZwo/cxtqCw0F/MfmSi2K7SjO4Kml60xYxTAS0h/vJy/ Hwrnfpszp7o349J05kUhtuHdwLHwXUUmCVHEMIrBHPH+jC4M9JC/01uhyjyilEYNPzj9 uJndZZQ6eKYFRavnYvzCjj7fcyO65TGJoXhzIDeNHceQsNG9xMt6UzsKsmfyPpY2hgrz GqVg== X-Gm-Message-State: AOAM530P9u+KgEGrntkEDmTX2hVRg7lySkmpTa70RWgy5iRNf1Fv19BG gegxnVDDj1vi2s8seLhOTPE= X-Google-Smtp-Source: ABdhPJyhx4moRPspG60wr2Pp+C+6oPhsmZuQkU3878kd8UfHtSybVGnbPunxmc0YpHTAwVGUn56Uuw== X-Received: by 2002:adf:c3c7:: with SMTP id d7mr11167385wrg.51.1592701500348; Sat, 20 Jun 2020 18:05:00 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v24sm13900334wrd.92.2020.06.20.18.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2020 18:04:59 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> From: Dmitry Gutov Message-ID: <075ba6a5-4659-fd0c-91ed-53b242fa884a@yandex.ru> Date: Sun, 21 Jun 2020 04:04:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 20.06.2020 11:35, Andrii Kolomoiets wrote: > Dmitry Gutov writes: > >> On 19.06.2020 07:59, Andrii Kolomoiets wrote: >>> Furthermore, by not requiring a match, switch-to-buffer allows to create >>> buffers. >> >> Right. >> >> Do you need this ability? I would imagine switch-to-buffer is always >> available for that. > > Well, I rarely use this ability of switch-to-buffer. I can't say I > really need this in project-switch-to-buffer. > > But to keep consistency with switch-to-buffer, project-switch-to-buffer > should behave the same. There are other differences, too. The arglist, for example. > Also, in my understanding, match is should be required on e.g. killing > buffers when existing buffer is required. Because switch-to-buffer is > able to create buffers, I can't see the reason why > project-switch-to-buffer should require the match. To better protect from typos? It's not a very strong argument, of course. But "just for consistency" isn't one either. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 05:31:07 2020 Received: (at 41879) by debbugs.gnu.org; 22 Jun 2020 09:31:07 +0000 Received: from localhost ([127.0.0.1]:33318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnInC-0007qb-Pi for submit@debbugs.gnu.org; Mon, 22 Jun 2020 05:31:06 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:33227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnInA-0007q6-0q for 41879@debbugs.gnu.org; Mon, 22 Jun 2020 05:31:05 -0400 Received: by mail-lj1-f171.google.com with SMTP id s1so18513218ljo.0 for <41879@debbugs.gnu.org>; Mon, 22 Jun 2020 02:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/cD0/25Nkno629t/OnJbXY+rAo/yUAJC+iiP6LDcCJs=; b=A/p3AJsiLzEJtFYRsWC/uPRjANCfNrXmDydWtLpiLRLtxuzEKtfIQ8A9YWuW3umIlL HP/VOuMVOadSMMofodMWEdr4/FP8N7V9YCvDLrRp4QJ/ugdOsfZEJ6IPnlYlCo3p+rH/ N9TPJgmUbbWmHLlcLX7P9f4Am4GNp6agq4COyi/dJx7JBK4WS8Tr2s2bkykQhyC72q0l XfEupdWbMHR8U53iDolnPAewtyDoLTn+wW5vlKcRNOFSwGFUelOniVq5gxXTzqk76XL7 6ymAQSDxabg7z2dMzuPdtcLmvT2CCceSZZrvAgyhkf8HviZGGiAYUWUazFMr6pnDtf+M dgKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/cD0/25Nkno629t/OnJbXY+rAo/yUAJC+iiP6LDcCJs=; b=h+hNh8J+db+kOx55JuN397nxTejeTPWlnaHt5N9LexFT66M0B33mJH4v20xTyeWKCB pS7/upNstZnqx4QWN7OJCMgfiHIT58DtoiQWduHhKpj2xEZ4FI8e7O36nbGhrGD2Nw46 wD4Wmn1jdEGOu9Wipo9c1vKwoAGzsJx4+W3fVdCffOlXijSscPQJtlQSGnftiB3Z81Uw 5UPmH3AIEBRUfnCsxW2hJsT3BAH6DRxVeXXmeVO7U19s2JvQmizjUvSsRlaDQ4LG3TZb pmYqeyxZzP6nl9F7X12czVI6GM2gm9sC+JDIaLlKUFZQyPIOcvubnorTyB/tvXeJcCfc ZG2g== X-Gm-Message-State: AOAM533TioErQoB7xyn4beznnZZgpnprccztsu7AN9aMNm2K1h+YuyXA jZGXvYkLtY0wdico3No2wQk= X-Google-Smtp-Source: ABdhPJxVCasKngl3gT1B0waWJByhgUTegGv6jQewwrHbVKD57V15SatA1JPiLLpGa5iOlxBnTgyKHA== X-Received: by 2002:a2e:6a05:: with SMTP id f5mr8380104ljc.385.1592818257957; Mon, 22 Jun 2020 02:30:57 -0700 (PDT) Received: from 10-1-1-139.office.area (102-26-207-82.ip.ukrtel.net. [82.207.26.102]) by smtp.gmail.com with ESMTPSA id a5sm3262889lfh.15.2020.06.22.02.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 02:30:57 -0700 (PDT) From: Andrii Kolomoiets To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> <075ba6a5-4659-fd0c-91ed-53b242fa884a@yandex.ru> Date: Mon, 22 Jun 2020 12:30:55 +0300 In-Reply-To: <075ba6a5-4659-fd0c-91ed-53b242fa884a@yandex.ru> (Dmitry Gutov's message of "Sun, 21 Jun 2020 04:04:57 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: >> But to keep consistency with switch-to-buffer, >> project-switch-to-buffer >> should behave the same. > > There are other differences, too. The arglist, for example. Well, NORECORD and FORCE-SAME-WINDOW can be passed to switch-to-buffer easily if there is the need to. >> buffers when existing buffer is required. Because switch-to-buffer is >> able to create buffers, I can't see the reason why >> project-switch-to-buffer should require the match. > > To better protect from typos? It's not a very strong argument, of > course. But "just for consistency" isn't one either. How about "To be able to create buffers"? ;) This way there are no need to use switch-to-buffer for those who will use project-switch-to-buffer solely. Imagine project-switch-to-buffer is in your muscle memory. You need to perform additional steps to create the buffer (C-g C-x b type-buffer-name-again) just because the project-switch-to-buffer can't create buffers with no reason. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 09:46:14 2020 Received: (at 41879) by debbugs.gnu.org; 22 Jun 2020 13:46:14 +0000 Received: from localhost ([127.0.0.1]:33500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnMm5-0007sW-VY for submit@debbugs.gnu.org; Mon, 22 Jun 2020 09:46:14 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:35206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnMm3-0007sJ-LH for 41879@debbugs.gnu.org; Mon, 22 Jun 2020 09:46:12 -0400 Received: by mail-wm1-f52.google.com with SMTP id g21so11333277wmg.0 for <41879@debbugs.gnu.org>; Mon, 22 Jun 2020 06:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HU9JQgpZ4lTvq5siAkNTY9CkzKS9X6yHE2K8OERIzZw=; b=uNSJXFrFRxjevPnvq/VbnGHSh0qV9IDOAX7HaPvviAocX2Y896THZG2bOawIkzAV+Q xH8h35W1uNabbMI4n+NkreNx9+/CVYa5S+dAJRg16ciGFAbkYr7vRHC2G2YEKJaxWWcB RofrvDh3qGdzfDbFJBwUCav9GBV44+BdvzvIzrGDsWK+7v9eaNu3/fKb0cy7xwupXHBQ sr6zYsrKhl69jE1yu7THlomf95DEBQewPbZlVN0nm4Uq9NKRPWhtEcY6RQ2GOnvqDP5m 0u/r9bjp3Nj50VSaFl5nEqWbm+nna3K4mTTmEe8zuyb0SBB7Num6hJeD7iiiFMqWHQIC Xz4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HU9JQgpZ4lTvq5siAkNTY9CkzKS9X6yHE2K8OERIzZw=; b=g1Vf0GrVRnqBPoVfaYVzgLJlZcNDmVh0a1Kh0rPHaApIGP1qM9Ha3FK27DzT0ODyzI 1YCoRIuKGXIWy/jgPQ4GCE4gPmLb0Ib2mgsQdkyFPjm72JEGUiVLKjTRgdBq0phCTNEl TLj9a0txfHI1ree5Vgc402si5MxilxEvBQ7WtcCgAIaTdZVy0+vsvzjBL2rfcdfwZbzB TpTlfYsN6RXWF1Mqxchz3B40M2dyNfjY9OFviXrTJPiy6BJ/+Nz5/b4F5389iN1s5yhf d3TvZi4gEZb6RkTKjPW/zM/3rq8wTAFaSfZ2qU+UyCunqM9NaYju3iGFjzp56I2CBo5Q ROiw== X-Gm-Message-State: AOAM533GPBZFrP7voHf7j3V49ufzYcnleuI/Xe/NHTn9k7tXvHEcGu1j 3VpktfHnwq04+S+gSdNEQ/s= X-Google-Smtp-Source: ABdhPJx5tSQcJUQ0Rsa+B3Oohko/zMY3eTehGbAThtQCBiFgKZXY8asy+gBdSfz2LVuKtHzUmUul5w== X-Received: by 2002:a1c:a3c5:: with SMTP id m188mr18136767wme.152.1592833565815; Mon, 22 Jun 2020 06:46:05 -0700 (PDT) Received: from [192.168.0.111] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id t2sm5490900wma.43.2020.06.22.06.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 06:46:04 -0700 (PDT) Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el To: Andrii Kolomoiets References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> <075ba6a5-4659-fd0c-91ed-53b242fa884a@yandex.ru> From: Dmitry Gutov Message-ID: Date: Mon, 22 Jun 2020 16:46:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22.06.2020 12:30, Andrii Kolomoiets wrote: >>> But to keep consistency with switch-to-buffer, >>> project-switch-to-buffer >>> should behave the same. >> >> There are other differences, too. The arglist, for example. > > Well, NORECORD and FORCE-SAME-WINDOW can be passed to switch-to-buffer > easily if there is the need to. Everything can be added later. Adding new function arguments could be a bit more problematic than a slight change in semantics like REQUIRE-MATCH=nil, though. >>> buffers when existing buffer is required. Because switch-to-buffer is >>> able to create buffers, I can't see the reason why >>> project-switch-to-buffer should require the match. >> >> To better protect from typos? It's not a very strong argument, of >> course. But "just for consistency" isn't one either. > > How about "To be able to create buffers"? ;) This way there are no need > to use switch-to-buffer for those who will use project-switch-to-buffer > solely. > Imagine project-switch-to-buffer is in your muscle memory. You need to > perform additional steps to create the buffer (C-g C-x b > type-buffer-name-again) just because the project-switch-to-buffer can't > create buffers with no reason. All right. I'll change it to nil now. Not sure I understand the passion behind your argument, though, since you said you're not going to need this yourself. But perhaps I misunderstood. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 09:54:25 2020 Received: (at 41879) by debbugs.gnu.org; 22 Jun 2020 13:54:25 +0000 Received: from localhost ([127.0.0.1]:33520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnMu1-00084V-6k for submit@debbugs.gnu.org; Mon, 22 Jun 2020 09:54:25 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:36650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnMtz-00084I-NW for 41879@debbugs.gnu.org; Mon, 22 Jun 2020 09:54:24 -0400 Received: by mail-lf1-f47.google.com with SMTP id c21so9658114lfb.3 for <41879@debbugs.gnu.org>; Mon, 22 Jun 2020 06:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nIsvkCTTyY0dpkumpnyun0JymH4qr3OVt6pZA80Gk04=; b=ML+fmt1OUg9UOiF0nifk7aobMCktyTNNQFRrBB33uL4/qFizQguuypS+bv72c4lSHC g/6Xh67SnQVQ/w89679hbzetJ0K9nDmWLWL8sVw/1TcwOYClnSLJY1uLitCDhn4aXXI9 RNZERF7dO88+RfIZSMShhhzLaFq88PxgEGocasybAHsTbulm4u435hAXkkAaE1rVA87q DyRCsyibQeg5XC56JPXj35Eo5A6l6rNntlXJCHFKuQid6wqRTT02GcGciCHZ2vvhvJux Qeu3bcXcAw5Wtv6sIdn+CfCaktbI6D8HzUPQr6CKEz+3euxTM1FapAzvYMv1f3QgaalU 4Iaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nIsvkCTTyY0dpkumpnyun0JymH4qr3OVt6pZA80Gk04=; b=jbTQ3XGBCteWlBwrRbUlROKEZCeUfwSZ7qVysbh9gF3GpiONsnaikatBh0H7X0tyn6 4g63mJxCrOsCpXPS8DMQxtcKuYOz2wizK692k3zB6szvgeoSLwxNcxNk4r3/jWkCGJ1j 6LUc5EZKTSaobvQHoUMARf8RJxpR8edZEDJ1GdcTUiOXpMC+/ze/eTJorJbwgBk3F7z8 FhOEZNDzQ1uStDW7ob2HIPQ9jDvO3apP2MEe/VuJO6YODkGB0ZE1pLCjGY7OcT+/nmU/ 4maHIM0jc6wNzH12OA0qzPvR9s1Oxg4Zy7lzkwT3S7VDWWW1Hv91NX+jNNU9h9R6aMGs dm+g== X-Gm-Message-State: AOAM533iUbIO2Tw1BfClnvqYxoAht8C7L6GIKcrNMPJq/0obGdI2Kxgv ZP94WgK3EEq9EtyZ8oul4sM= X-Google-Smtp-Source: ABdhPJzJD+jFmJRf35jPJejInT9pJylm5AHg/Gh31hxTGv2zhhO05StqcnhjOf/wFklboBbfExab3g== X-Received: by 2002:a05:6512:64:: with SMTP id i4mr7638466lfo.113.1592834057503; Mon, 22 Jun 2020 06:54:17 -0700 (PDT) Received: from 10-1-1-139.office.area (102-26-207-82.ip.ukrtel.net. [82.207.26.102]) by smtp.gmail.com with ESMTPSA id m15sm3479835lfk.65.2020.06.22.06.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 06:54:16 -0700 (PDT) From: Andrii Kolomoiets To: Dmitry Gutov Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> <075ba6a5-4659-fd0c-91ed-53b242fa884a@yandex.ru> Date: Mon, 22 Jun 2020 16:54:15 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 22 Jun 2020 16:46:03 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: 41879@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: >> Imagine project-switch-to-buffer is in your muscle memory. You need to >> perform additional steps to create the buffer (C-g C-x b >> type-buffer-name-again) just because the project-switch-to-buffer can't >> create buffers with no reason. > > All right. I'll change it to nil now. > > Not sure I understand the passion behind your argument, though, since > you said you're not going to need this yourself. But perhaps I > misunderstood. I'm rarely use this feature, but when I'll need it it's great that `project-switch-to-buffer` support it. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 10:59:22 2020 Received: (at 41879) by debbugs.gnu.org; 22 Jun 2020 14:59:22 +0000 Received: from localhost ([127.0.0.1]:34299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnNur-0001TC-VH for submit@debbugs.gnu.org; Mon, 22 Jun 2020 10:59:22 -0400 Received: from forward500j.mail.yandex.net ([5.45.198.250]:52495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnNup-0001Sx-9H for 41879@debbugs.gnu.org; Mon, 22 Jun 2020 10:59:20 -0400 Received: from mxback1q.mail.yandex.net (mxback1q.mail.yandex.net [IPv6:2a02:6b8:c0e:39:0:640:25b3:aea5]) by forward500j.mail.yandex.net (Yandex) with ESMTP id E11FD11C2027; Mon, 22 Jun 2020 17:59:11 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback1q.mail.yandex.net (mxback/Yandex) with ESMTP id AzT1HqK6kB-xBnGpXKt; Mon, 22 Jun 2020 17:59:11 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1592837951; bh=kDSZiwagFxzG58DgDHuqOgK90XJjzFrcjL2IIYZ6tVI=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=EvRsh8Ms90jiODe08HkIYqlhXBGovh4JwVCmbQYu78XVfW5vU/6elnGKOAoTEWbD3 NDcKp+czM0fpNqiE6vCDHbUpvxe4I51ylLsAoxxeR1yVtm3PzTcwmrbu7ddVnKffqu e/cuImLZrH1yL/E9DKLZHTdVeloz9WP5QawlGSXQ= Authentication-Results: mxback1q.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by vla1-c7cd0219e008.qloud-c.yandex.net with HTTP; Mon, 22 Jun 2020 17:59:11 +0300 From: Dmitry Gutov To: Andrii Kolomoiets In-Reply-To: References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> <85d1f04d-d926-bbfd-031e-1898b5c081b3@yandex.ru> <2d760293-3db0-d46e-07ec-16dc86ff4041@yandex.ru> <075ba6a5-4659-fd0c-91ed-53b242fa884a@yandex.ru> Subject: Re: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 22 Jun 2020 17:59:11 +0300 Message-Id: <4962901592837951@vla1-c7cd0219e008.qloud-c.yandex.net> Content-Transfer-Encoding: 7bit Content-Type: text/html X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41879 Cc: "41879@debbugs.gnu.org" <41879@debbugs.gnu.org>, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 16:55, June 22, 2020, Andrii Kolomoiets <andreyk.mad@gmail.com>:

I'm rarely use this feature, but when I'll need it it's great that
`project-switch-to-buffer` support it.

Very good, then.

Thank you!

No problem. From unknown Fri Jun 20 07:14:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Jul 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator