GNU bug report logs - #41875
[PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Mon, 15 Jun 2020 16:24:02 UTC

Severity: normal

Tags: patch

Done: iyzsong <at> member.fsf.org (宋文武)

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brice Waegeneire <brice <at> waegenei.re>
Subject: bug#41875: closed (Re: [bug#41875] [PATCH] system: Add 'sg' and
 'newgrp' to %SETUID-PROGRAMS.)
Date: Sun, 21 Jun 2020 03:38:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#41875: [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41875 <at> debbugs.gnu.org.

-- 
41875: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41875
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: iyzsong <at> member.fsf.org (宋文武)
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 41875-done <at> debbugs.gnu.org
Subject: Re: [bug#41875] [PATCH] system: Add 'sg' and 'newgrp' to
 %SETUID-PROGRAMS.
Date: Sun, 21 Jun 2020 11:36:58 +0800
Brice Waegeneire <brice <at> waegenei.re> writes:

> * gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.

Pushed, thank you!

[Message part 3 (message/rfc822, inline)]
From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.
Date: Mon, 15 Jun 2020 18:23:28 +0200
* gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.
---

Without it 'newgrp' is unusable:

--8<---------------cut here---------------start------------->8---
$ whoami
bricewge
$ cat /etc/group | grep wireshark
wireshark:x:970:bricewge
$ groups
users libvirt adbusers plugdev kvm lp netdev audio video input dialout wheel
$ newgrp wireshark
setgroups: Operation not permitted
setgid: Operation not permitted
--8<---------------cut here---------------end--------------->8---

I also added 'sg' since, in the shadow package, it's a symlink to 'newgrp'.

 gnu/system.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/system.scm b/gnu/system.scm
index 06bbc9e9c8..3e3d1927c2 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -932,7 +932,9 @@ use 'plain-file' instead~%")
   ;; Default set of setuid-root programs.
   (let ((shadow (@ (gnu packages admin) shadow)))
     (list (file-append shadow "/bin/passwd")
+          (file-append shadow "/bin/sg")
           (file-append shadow "/bin/su")
+          (file-append shadow "/bin/newgrp")
           (file-append shadow "/bin/newuidmap")
           (file-append shadow "/bin/newgidmap")
           (file-append inetutils "/bin/ping")
-- 
2.26.2




This bug report was last modified 4 years and 332 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.