GNU bug report logs - #41873
[PATCH] gnu: Add ebusd.

Previous Next

Package: guix-patches;

Reported by: Danny Milosavljevic <dannym <at> scratchpost.org>

Date: Mon, 15 Jun 2020 15:43:01 UTC

Severity: normal

Tags: patch

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 41873 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 41873 <at> debbugs.gnu.org
Subject: Re: [bug#41873] [PATCH] gnu: Add ebusd.
Date: Sun, 21 Jun 2020 11:57:11 +0200
Hey Danny,

> +              (uri (git-reference
> +                     (url "https://github.com/john30/ebusd.git")
> +                     (commit (string-append "v" version))))

Indentation is off here and a bit below.

> +               (copy-recursively (string-append (assoc-ref inputs "config")
> +                                                "/ebusd-2.1.x")

Maybe you could use the "latest" file here?

> +    (synopsis "Daemon for communicating with eBUS devices")
> +    (description "This package provides @command{ebusd}, a daemon for
> +handling communication with eBUS devices connected to a 2-wire bus system
> +(\"energy bus\" used by numerous heating systems).")

I think you can turn this into a full sentence.

Otherwise, it look fine.

Thanks,

Mathieu




This bug report was last modified 4 years and 252 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.