Subject: bug#41855: closed (Re: bug#41855: [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 19 Jun 2020 08:45:02 +0000

Your bug report

#41855: [PATCH 0/2] hurd-boot: Cleanups: Remove MAKEDEV, then use setxattr (on the Hurd).

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41855: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41855
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#41855: [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV.
From: Jan Nieuwenhuizen <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Fri, 19 Jun 2020 10:44:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès writes:

Hi!

> Jan Nieuwenhuizen <[email-masked]> skribis:

>> Similarly, "linux-boot" defines "make-essential-device-nodes", which
>> could be called from GNU/Hurd when we cross build a linux VM.
>
> Right.
>
>> Haven't made this change yet, let me know you want; or feel free to make
>> the change yourself :-)
>
> Yeah, we can leave that for later.  :-)

"Good" :-)

>> From 1e27aabb8bf32e85547517e1f0e35f789a08933d Mon Sep 17 00:00:00 2001
>> From: "Jan (janneke) Nieuwenhuizen" <[email-masked]>
>> Date: Mon, 8 Jun 2020 13:02:13 +0200
>> Subject: [PATCH v2 1/2] hurd-boot: Create individual translators instead of
>>  running MAKEDEV.
>>
>> * guix/build/utils.scm
>
> Something’s wrong!

Oops, removed this mid-way change-of-mind sublimation.

>> * gnu/build/hurd-boot.scm (make-hurd-device-nodes): Do not create
>> dev/{null,zero,full,random,urandom} mount points.
>> (passive-translator-xattr?, passive-translator-installed?, translated?,
>> set-hurd-device-translators): New procedures.
>> (false-if-EEXIST): New macro.
>> (boot-hurd-system): Use them instead of running MAKEDEV.
>
> [...]
>
>> +(define* (set-translator! file-name command #:optional (mode #o600))
>
> Nitpick: there shouldn’t be a bang here (just like for ‘mkdir’, etc.).

...ah, interesting.  ! is for scheme'y imperativeness.

> Otherwise LGTM, thank you!

Pushed this serie master as f25e8f76fec03e5a31c221e7427d6962ece1aa67

That was all I have all from wip-hurd-vm.  At least until we decide to
risk using the linux xattr patch (looks like that will be in linux-5.8).

Janneke

-- 
Jan Nieuwenhuizen <[email-masked]> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Subject: [PATCH 0/2] hurd-boot: Cleanups: Remove MAKEDEV, then use setxattr (on the Hurd).
From: "Jan (janneke) Nieuwenhuizen" <[email-masked]>
To: [email-masked]
Cc: Jan Nieuwenhuizen <[email-masked]>
Date: Sun, 14 Jun 2020 18:54:30 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Jan Nieuwenhuizen <[email-masked]>

Hi!

Several variants of these patches were present on wip-hurd-vm before.

Currently, we are running MAKEDEV from activation, and thus need hurd, bash,
coreutils and sed in PATH.

The first patch replaces that with scheme code, which seems a no-brainer to
me.  Then we only need hurd in PATH for settrans and gettrans.

The second patch then switches to using setxattr instead of settrans; alas we
still need gettrans as getxattr behaves "funny" on translated nodes.  I
suppose that would be a question for the bug-hurd?

Greetings,
Janneke

Jan (janneke) Nieuwenhuizen (2):
  hurd-boot: Create individual translators instead of running MAKEDEV.
  hurd-boot: Use 'setxattr' instead of invoking settrans.

 gnu/build/hurd-boot.scm | 172 +++++++++++++++++++++++++++++-----------
 gnu/system.scm          |   1 +
 2 files changed, 126 insertions(+), 47 deletions(-)

-- 
Jan Nieuwenhuizen <[email-masked]> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com