GNU bug report logs - #41850
[PATCH] maint: Avoid signed integer overflows

Previous Next

Package: coreutils;

Reported by: Tobias Stoeckmann <tobias <at> stoeckmann.org>

Date: Sun, 14 Jun 2020 12:48:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tobias Stoeckmann <tobias <at> stoeckmann.org>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 41850 <at> debbugs.gnu.org
Subject: bug#41850: [PATCH] maint: Avoid signed integer overflows
Date: Wed, 17 Jun 2020 20:15:16 +0200

Hi,

On Mon, Jun 15, 2020 at 11:11:57PM +0100, Pádraig Brady wrote:
> How did you notice BTW. This wasn't exposed in existing tests.

it was a manual code review.

I like coreutils for having such a high quality and its goal of being as
portable as possible. The former means that it's challenging and
educational to find bugs or standard violations and the latter that
fixes have a high change of being accepted. Last but not least, small
programs make it easy to trigger issues with a simple call for easy
reproducability.

> I've updated your patch (attached) to add tests for this.

Thanks, the test suite looks nice.


Tobias
This bug report was last modified 3 years and 112 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.