From unknown Tue Jun 17 20:12:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41850 <41850@debbugs.gnu.org> To: bug#41850 <41850@debbugs.gnu.org> Subject: Status: [PATCH] maint: Avoid signed integer overflows Reply-To: bug#41850 <41850@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:12:35 +0000 retitle 41850 [PATCH] maint: Avoid signed integer overflows reassign 41850 coreutils submitter 41850 Tobias Stoeckmann severity 41850 normal tag 41850 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 14 08:47:18 2020 Received: (at submit) by debbugs.gnu.org; 14 Jun 2020 12:47:18 +0000 Received: from localhost ([127.0.0.1]:43101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkS2g-00037v-5N for submit@debbugs.gnu.org; Sun, 14 Jun 2020 08:47:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:37984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkS2f-00037o-71 for submit@debbugs.gnu.org; Sun, 14 Jun 2020 08:47:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkS2e-0001Hh-Uu for bug-coreutils@gnu.org; Sun, 14 Jun 2020 08:47:16 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:35289) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkS2d-0004FC-83 for bug-coreutils@gnu.org; Sun, 14 Jun 2020 08:47:16 -0400 Received: from localhost ([178.142.98.240]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M3lsh-1jkBBs2cZ1-000pLJ for ; Sun, 14 Jun 2020 14:47:11 +0200 Date: Sun, 14 Jun 2020 14:47:11 +0200 From: Tobias Stoeckmann To: bug-coreutils@gnu.org Subject: [PATCH] maint: Avoid signed integer overflows Message-ID: <20200614124711.ypabis4dagnzqycp@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Provags-ID: V03:K1:KVFeHKUXy3w1u0YviGi0vxboZpaNUeEw6kZ7zPZkw0CfjXbS9W7 Ncmo+Bl5o76PRhVtZb/1FfaA+bIPbS4pyaGIyQJmDcrP6qA2woOUjMhoHsk+VammQUd6DzI /cIxCPPx5B7DjKIvkITIGIaKXWCzVHMYLnlT0Y78QsPqjR3gQ62Z7x/gItejM4bw0ZQ5CM0 5V7KIxF1XBbl5lxokQ3KQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uk0v4wWi8CE=:t0yhnAdP0+RIApTZQwIt+A qnHXfYItLiD0eUA4QeJPNjFZr0cd1KGviU65vJxYY1YLY4xpUaRhnKD2COCdRdUhyJa9+W0V0 nEJLgQ+VB66Z29XcutDxuiR6wnB/toT2oaCPdlof62plhPe7KnVdCkTsY00vnlgW1TnMnywyM bJcsRplP2yx0YNVf7uxdkq5BkibDmlGIMJ8rTZlxgGQHx6z6bT4Z88bwbGbdNWbALPEFVDHA2 Ka0xCKfKKxKRpjAh2a+BIAnYeNL1ZmAqp+1EqnUbgIIgHSwOi+tfnpqkeMw4uT3Bz2HTf7WBG +ibmlAL8MJTcZzvLtr1nbT3IMavB2jcekYfP9FLWpExnPZhhwxoDZKV65iV9NADT+/Q1g2rUw WEMU9WIttA1Z3Ncbu7j2lVI2uxTOCCcfoH+VVbFKNMwDs6V08alNg4Y7KH7TFNk2qJZi71cE8 tLnHUUQ5qY5oUl7phGtig3k95lLml9q6HBRCc59EPBqpmtl7ufmKoJLIsY6qHQEKJVJDkYQG2 zVXGUl+Y7Qbb5N0jzKdw5siPcrNd6zLRN1iqPwNaJ28R6NorTaSR5WYcsR4/lr/6v/lPArmwO Dx4YhCQEc9cJ35H90IoTb7sM0Ey/zN7hdN+1my2WeoDCPEVEbUaKKilfUtbql7+lDHU4yZbO7 NXea8ufpbf0j0kkZdhaNhoH7c9/IYrNNCLdMEpcMPPbXChI9vZdhB+Z1gc3XDKBLUuFiOwCLD CCJz506lquCz4cfrvukdws2Roh5ztPofsbn0q5puGpDHhzQYdZndphNY9bYI9slBuK2RvibXx uSwb4lqda+lgD3ei+sfGJKoIf7YrnlAYSNObSR9vQHMMmcVS20EtbbvB4b1I4Mqd1OEJDX0 Received-SPF: none client-ip=212.227.126.133; envelope-from=tobias@stoeckmann.org; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/14 08:47:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Since -LONG_MIN results in LONG_MIN again, the operation itself is a signed integer overflow. This can be observed with the following calls (best if compiled with -ftrapv or -fsanitize=undefined): $ numfmt --padding=-9223372036854775808 $ seq 1e-9223372036854775808 Technically, the change in seq "reduces" the precision, but a double or long double that small would be represented as 0 anyway. --- src/numfmt.c | 2 +- src/seq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/numfmt.c b/src/numfmt.c index 8869791b0..8871a8c01 100644 --- a/src/numfmt.c +++ b/src/numfmt.c @@ -1496,7 +1496,7 @@ main (int argc, char **argv) case PADDING_OPTION: if (xstrtol (optarg, NULL, 10, &padding_width, "") != LONGINT_OK - || padding_width == 0) + || padding_width == 0 || padding_width < -LONG_MAX) die (EXIT_FAILURE, 0, _("invalid padding value %s"), quote (optarg)); if (padding_width < 0) diff --git a/src/seq.c b/src/seq.c index ddb63b642..2ca1e4f7b 100644 --- a/src/seq.c +++ b/src/seq.c @@ -197,7 +197,7 @@ scan_arg (const char *arg) e = strchr (arg, 'E'); if (e) { - long exponent = strtol (e + 1, NULL, 10); + long exponent = MAX (strtol (e + 1, NULL, 10), -LONG_MAX); ret.precision += exponent < 0 ? -exponent : - MIN (ret.precision, exponent); /* Don't account for e.... in the width since this is not output. */ -- 2.27.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 18:12:11 2020 Received: (at 41850) by debbugs.gnu.org; 15 Jun 2020 22:12:11 +0000 Received: from localhost ([127.0.0.1]:47625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkxKq-00036H-6g for submit@debbugs.gnu.org; Mon, 15 Jun 2020 18:12:11 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:40736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkxKn-00035n-Vq for 41850@debbugs.gnu.org; Mon, 15 Jun 2020 18:12:06 -0400 Received: by mail-wr1-f49.google.com with SMTP id h5so18740127wrc.7 for <41850@debbugs.gnu.org>; Mon, 15 Jun 2020 15:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=yPin4ldKPYJkmKIKklx2cvpdlujOOq36Na0A4v01cjo=; b=o5RPj/qKm9rEVIDtxwDtBx7Caw6vJ9RBj4Tyx00HNfxp9iYyzLOxN+a+W35Db7Z6dS 766D2ZLN1K8OTnQ+hWimrq3979diBDFXBXPWO+zlv93tjDVG3AXvA/pvGZqrnH9ZdAWz asqwZSzCiBiQAgEab7K2jYgQInW29CDPy1kaOwEkH5NTDL7YsBeX//I4J2Gc4Gr2cSwl dsT2Yx7+tjvjAI7V3MTvXa50tUb/MXOBjuIBOURfRCH9WuYn0IaZunKHpL1XypnjQ9cE RCUm3BJwSV67wpakIgW90kOVZDuKLqQkzCXkKgC5whO8mHIWx2k4O29BEH5DnW4FqlKN 9W1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=yPin4ldKPYJkmKIKklx2cvpdlujOOq36Na0A4v01cjo=; b=dlYdbFZuEJEDsaMtFNAohSR4CZ22c8Xv9dS15mSdEr+JUV4ilfjlofGGAy86paq0Lp LATWqr6w6AbP1W+9sy7Z2gzxOLLrTPR5AmZUSNCAWKpFwOpDP+l4rBS1RCgAXXS86dDT q3hPZZMd0bRIYEaVy+aJY/7ptAdKj9sOuBQKqbHjU/pYh6qYaKobB5WnKuSo+Tvr7xs3 94txxzJjW1pwwjAdAalNuAdXN53RINnreM2yJvteLUbmPCVMf+vIWxwZg+TD+pmL2OSz Ib+2CtGsZgPRryBMt8R5qldRmRELZwX+lZoXOaTSyNGdUwrjP7PhNbVsYtaCwzEq4xl3 YlIw== X-Gm-Message-State: AOAM532JlWTaTK8Mjg1/SQBLZYgEvIOk2i1LYZ20S1/9F2y79vH0jHLU oMrVyH2xKxhkmfV+58yGkNK1kC51xI4= X-Google-Smtp-Source: ABdhPJyPgdDCCNGRIdV5a12eaQO9Rlmz/2qBgncg1KBnpUoR1hmfm/rKPT9jWGZRgBLdBCbqrXfD/Q== X-Received: by 2002:adf:f988:: with SMTP id f8mr33386794wrr.81.1592259119708; Mon, 15 Jun 2020 15:11:59 -0700 (PDT) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with ESMTPSA id n23sm1110987wmc.0.2020.06.15.15.11.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 15:11:58 -0700 (PDT) Subject: Re: bug#41850: [PATCH] maint: Avoid signed integer overflows To: Tobias Stoeckmann , 41850@debbugs.gnu.org References: <20200614124711.ypabis4dagnzqycp@localhost> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <8486a640-30e1-3756-e3f9-c7fc4bdcabc8@draigBrady.com> Date: Mon, 15 Jun 2020 23:11:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200614124711.ypabis4dagnzqycp@localhost> Content-Type: multipart/mixed; boundary="------------A2AE3C1A377EFCBCE294BB07" Content-Language: en-US X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41850 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------A2AE3C1A377EFCBCE294BB07 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 14/06/2020 13:47, Tobias Stoeckmann wrote: > Since -LONG_MIN results in LONG_MIN again, the operation itself is > a signed integer overflow. > > This can be observed with the following calls (best if compiled > with -ftrapv or -fsanitize=undefined): > > $ numfmt --padding=-9223372036854775808 > $ seq 1e-9223372036854775808 > > Technically, the change in seq "reduces" the precision, but a double > or long double that small would be represented as 0 anyway. Thanks for fixing those -fsanitize=undefined issues. I can confirm with GCC 10 -fsanitize=undefined was giving: src/numfmt.c:1505:31: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int' How did you notice BTW. This wasn't exposed in existing tests. I've updated your patch (attached) to add tests for this. cheers, Pádraig --------------A2AE3C1A377EFCBCE294BB07 Content-Type: text/x-patch; charset=UTF-8; name="numfmt-seq-ubsan.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="numfmt-seq-ubsan.patch" >From 0fe9fdece735234819ead2cad7902ba9a6cd8487 Mon Sep 17 00:00:00 2001 From: Tobias Stoeckmann Date: Sun, 14 Jun 2020 14:47:11 +0200 Subject: [PATCH] maint: avoid signed integer overflows Since -LONG_MIN results in LONG_MIN again, the operation itself is a signed integer overflow. This can be observed with the following calls (best if compiled with -ftrapv or -fsanitize=undefined): $ numfmt --padding=-9223372036854775808 $ seq 1e-9223372036854775808 Technically, the change in seq "reduces" the precision, but a double or long double that small would be represented as 0 anyway. * src/numfmt.c: Explicitly disallow --padding=LONG_MIN. * src/seq.c: Treat 1e$LONG_MIN as 1e-$LONG_MAX. * tests/misc/numfmt.pl: Add a test case. * tests/misc/seq-precision.sh: Likewise. Fixes https://bugs.gnu.org/41850 --- src/numfmt.c | 2 +- src/seq.c | 2 +- tests/misc/numfmt.pl | 3 +++ tests/misc/seq-precision.sh | 6 ++++++ 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/numfmt.c b/src/numfmt.c index 8869791b0..8871a8c01 100644 --- a/src/numfmt.c +++ b/src/numfmt.c @@ -1496,7 +1496,7 @@ main (int argc, char **argv) case PADDING_OPTION: if (xstrtol (optarg, NULL, 10, &padding_width, "") != LONGINT_OK - || padding_width == 0) + || padding_width == 0 || padding_width < -LONG_MAX) die (EXIT_FAILURE, 0, _("invalid padding value %s"), quote (optarg)); if (padding_width < 0) diff --git a/src/seq.c b/src/seq.c index ddb63b642..2ca1e4f7b 100644 --- a/src/seq.c +++ b/src/seq.c @@ -197,7 +197,7 @@ scan_arg (const char *arg) e = strchr (arg, 'E'); if (e) { - long exponent = strtol (e + 1, NULL, 10); + long exponent = MAX (strtol (e + 1, NULL, 10), -LONG_MAX); ret.precision += exponent < 0 ? -exponent : - MIN (ret.precision, exponent); /* Don't account for e.... in the width since this is not output. */ diff --git a/tests/misc/numfmt.pl b/tests/misc/numfmt.pl index a78e9c302..47ff34444 100755 --- a/tests/misc/numfmt.pl +++ b/tests/misc/numfmt.pl @@ -178,6 +178,9 @@ my @Tests = ['pad-3.1', '--padding=0 5', {ERR => "$prog: invalid padding value '0'\n"}, {EXIT => '1'}], + ['pad-3.2', "--padding=$limits->{LONG_MIN} 0", + {ERR => "$prog: invalid padding value '$limits->{LONG_MIN}'\n"}, + {EXIT => '1'}], ['pad-4', '--padding=10 --to=si 50000', {OUT=>' 50K'}], ['pad-5', '--padding=-10 --to=si 50000', {OUT=>'50K '}], diff --git a/tests/misc/seq-precision.sh b/tests/misc/seq-precision.sh index b5b167783..08f9863ed 100755 --- a/tests/misc/seq-precision.sh +++ b/tests/misc/seq-precision.sh @@ -18,6 +18,7 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ seq +getlimits_ # Integer only. Before v8.24 these would switch output format @@ -76,4 +77,9 @@ seq -w 1.10000e5 1.10000e5 > out || fail=1 printf "%s\n" 110000 > exp || framework_failure_ compare exp out || fail=1 +# Ensure no undefined behavior which failed with <= 8.32 +# This test would fail with: -fsanitize=undefined +seq 1e$LONG_MIN 2> err || fail=1 +compare /dev/null err || fail=1 + Exit $fail -- 2.26.2 --------------A2AE3C1A377EFCBCE294BB07-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 02:32:12 2020 Received: (at 41850) by debbugs.gnu.org; 16 Jun 2020 06:32:12 +0000 Received: from localhost ([127.0.0.1]:48053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl58l-0005Fq-VY for submit@debbugs.gnu.org; Tue, 16 Jun 2020 02:32:12 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:45503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl58k-0005Fb-KB for 41850@debbugs.gnu.org; Tue, 16 Jun 2020 02:32:11 -0400 Received: from [192.168.101.10] ([91.1.209.5]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MiaHf-1jIMAG2z2t-00flhq; Tue, 16 Jun 2020 08:32:03 +0200 Subject: Re: bug#41850: [PATCH] maint: Avoid signed integer overflows To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Tobias Stoeckmann , 41850@debbugs.gnu.org References: <20200614124711.ypabis4dagnzqycp@localhost> <8486a640-30e1-3756-e3f9-c7fc4bdcabc8@draigBrady.com> From: Bernhard Voelker Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: <1e504fb5-bc44-61fd-500d-e8e8fd1eef2c@bernhard-voelker.de> Date: Tue, 16 Jun 2020 08:32:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <8486a640-30e1-3756-e3f9-c7fc4bdcabc8@draigBrady.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:jbkeebXaoCOgowGHWPa5y1zKWWvylcaYU69s+cKRKYMhQGrqClP FaPOHkboURsn+zj/yWah59wtIwlQ8sry+d80ID3FBdD/5pxnpk8a1IgE6dCGDww1u1JhOUB gE/U4o1bbk+5buyrsmNphkoenR+V0rU1iHvzk440MZUkNLeH6+XDU6HfrpiC7gX9rWm6Xdl XFjRaJPVpEjY02lRFPxPA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FSkTg2dD/+I=:3nmMTBbQgTPY0TLitjArCS 7yMo/Q4Ak7mq6TkoEiytiFKh9XBbE7UYIoYBGUSIvMFr607f2R+CaR6lOhq4IL94UDxNbNOVh 0KG2gM8kQGafPn8GLqBm4MeaOAk8/MTUyyFK3o5xN7lmZ5FHbjqVu6znPhhvhlZhC46W1INy8 pUkEso47H4cOiAUpW8tHldrRI5/U94A++0PM55SkVuAtigYmaZoocLdGh0LChz3DoxzJgUXzQ O537SXTcMM5xF3y03oLZ2AQmMJNmyIjktkHElh4iosmiMKBDq/dyC7D/cQ2Za80AdJdu9faxR jvzVGYoyylSWbH4G85Kn3Hm9ck7KFNnWDBynj6rrwxAdz+Jxa4mg5iZg4GkDz54H182nn+MPT zHfKdINwMe1IXiE4sLc+FP3jOx0gj9jic5i4PQMuO4bB75ZrmyVYBS6wsvEFplS7xroHpo8m9 E8XWjn7lhXt3KqCqAFSN6w0vsZCO8hczWn2ODMo5p4lLMzjiCCWJLjl47TpvTKTCSRtswtxrb 4vxAQ7xoEfyrl/VkmBZwGn1gDypmuiRhm5NThICf8k8eYsW/LxO5LGKmbUsdTv+YE0P2NAuaV HDwfc5bMJUMnpvzabwPeMYr6yRtYZqELm1YvW/ypKLzlJjnoghMD246TR2kOzYPsQQTGlaW6J rscARlOesUlfVPB40gsmb7Kz4gdlT4/0o0/kgA8087gsB21MosIkOUvc7+rvFhGyzHGxhQYB8 ihR4PAwJSmPLgQYCicHHpQ7+l+qfYCMTUz0/BHBg3sGe4EilEgTihX4FgRsYH805YTDM9qwb5 ZQyKfew5xLfBtTqadY569GAkSfqMO0J6tOeg2sBeEjqjAb2vgKO0B0HSqkW+DhIyR2GBZOl X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41850 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-06-16 00:11, Pádraig Brady wrote: > I've updated your patch (attached) to add tests for this. nice, thanks. Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 14:15:28 2020 Received: (at 41850) by debbugs.gnu.org; 17 Jun 2020 18:15:28 +0000 Received: from localhost ([127.0.0.1]:52170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlcau-0002o5-7g for submit@debbugs.gnu.org; Wed, 17 Jun 2020 14:15:28 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:40583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlcap-0002nm-Ol for 41850@debbugs.gnu.org; Wed, 17 Jun 2020 14:15:26 -0400 Received: from localhost ([178.142.103.207]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MHFsE-1jhErV0aZc-00DGSr; Wed, 17 Jun 2020 20:15:17 +0200 Date: Wed, 17 Jun 2020 20:15:16 +0200 From: Tobias Stoeckmann To: =?utf-8?Q?P=C3=A1draig?= Brady Subject: Re: bug#41850: [PATCH] maint: Avoid signed integer overflows Message-ID: <20200617181516.lvbju7gj74wi4is4@localhost> References: <20200614124711.ypabis4dagnzqycp@localhost> <8486a640-30e1-3756-e3f9-c7fc4bdcabc8@draigBrady.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8486a640-30e1-3756-e3f9-c7fc4bdcabc8@draigBrady.com> X-Provags-ID: V03:K1:jeGTgIZMo+azDqkMU3JZQBaOccMklf84V3oB0AZWNn3OvtQskza y3eGRMLSxiZJdpQLToiigh5HgS8wKBZyumrwr1LX+EgxxMa9LkSeh7cYpMk1U4glh5stziP 3IHMeuANohWya47OHHW8NY9sNWHLPLl6ssHcDX8PaqmzmUZTTbBnxU0YxTYbdfSpreOxc0z i1/ssa38LJd09yqc+U1kg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nRjVakgJYYw=:km+q3T5ReXNgSAo37rSBNM oJr62MVcYYg6+xBPjXdfdUrceuenaqD8SqVozc5iLwIweRv8Sa57Q28smxpAEZz5fJL81+TFj s7xEzDOwgTguVL3uGLnChob/I1pYmn6k7AiGn1QuySFt5QTa4AYSYOvGghwJL/wwvY5z84uYO jW6cqS0KorULD2km/cKINefStlXpi1SXG3cNljAUdH1HbPJ0sP+y56RAYlxrzsfbvvmUw7KVU GIiw3BSYhr6ME0vK34HKu8Bef5sngSWf+bxjmnmr2Rdi5oGKptqDtFt7taK4UFU/ncP+P8ZNU J/oMhPB8PEeop5Jk0i25BvQV0wv9Q9TR9+xMnBE0SXHyD6ekoeZjGMbr/DnX2OpPh0tE5WCRE AOIQ9J+eoKriOrX4DBotBt8VZyGbWVB7JRS1sNGL3/rnU0ynUnSUWmQoT7ifVm0olTHpMQgsC ahBiLo4Iegc9wuiBJ1SWq39KUQNSUQVX3YA4ViPuXXTY89tChO0skGWonh/73Z1gT7CqasTeT 9nlfJXGudUDwmw21P0nJGEMANgcWqDiJ4CZU3aNaxvW4xvf/k3u1OQzX4b9gVTKZQpSaRVHkz HQjReNXpNZEWyxZAPL47nmwh6m+1vRFfNAdWtNuVvEkUdT0kWpsqBnOrkGTyeY0+uy6Mw465s ttAPlalxbKDI/5KrLTUzono8/jlHKi0A3EsF+TbsiseIwA3/iW1/t34I8W3PS50ZUka/B48fr ZQgJj9Hqc26JKQXtOQgGSDBgXLZYq/CahUQTBuHzwhi+sPyd6LXfK5Ivclh9IMENmOShB/IWe SXK/PbfPOsFfzdNo+SYs6FPq5AQDCHxPLcoGyqbPeFyLP8sv+ZREiRidT+N/LsIqrEHsJ3i X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41850 Cc: 41850@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Mon, Jun 15, 2020 at 11:11:57PM +0100, Pádraig Brady wrote: > How did you notice BTW. This wasn't exposed in existing tests. it was a manual code review. I like coreutils for having such a high quality and its goal of being as portable as possible. The former means that it's challenging and educational to find bugs or standard violations and the latter that fixes have a high change of being accepted. Last but not least, small programs make it easy to trigger issues with a simple call for easy reproducability. > I've updated your patch (attached) to add tests for this. Thanks, the test suite looks nice. Tobias From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 27 20:28:28 2022 Received: (at control) by debbugs.gnu.org; 28 Jan 2022 01:28:28 +0000 Received: from localhost ([127.0.0.1]:56988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDG3w-0000aQ-44 for submit@debbugs.gnu.org; Thu, 27 Jan 2022 20:28:28 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDG3r-0000a5-4D for control@debbugs.gnu.org; Thu, 27 Jan 2022 20:28:26 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 499D51600FF for ; Thu, 27 Jan 2022 17:28:16 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AnEYmdj_Y_om for ; Thu, 27 Jan 2022 17:28:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9C7CE160126 for ; Thu, 27 Jan 2022 17:28:15 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id L4jQhRrbEcnc for ; Thu, 27 Jan 2022 17:28:15 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 79C5A1600FF for ; Thu, 27 Jan 2022 17:28:15 -0800 (PST) Message-ID: <9cfa0d88-baef-d9d0-7f52-6cd3443c112a@cs.ucla.edu> Date: Thu, 27 Jan 2022 17:28:15 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: control@debbugs.gnu.org From: Paul Eggert Subject: close 41850 Organization: UCLA Computer Science Department Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 41850 thanks Bug has been fixed. From unknown Tue Jun 17 20:12:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Feb 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator