GNU bug report logs - #41849
[PATCH] Add frozen-bubble

Previous Next

Full log

Message #13 received at 41849-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41849-done <at> debbugs.gnu.org
Subject: Re: [bug#41849] [PATCH] Add frozen-bubble
Date: Wed, 17 Jun 2020 12:05:23 +0200

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Please add a comment stating why we’re pick this revision.

Done.

>> +           (add-after 'unpack 'fix-permissions
>> +             (lambda _ (invoke "chmod" "-R" "+w" "server")))
>
> How about: (for-each make-file-writable
>                      (find-files "servers" "." #:directories? #t))

OK.

I also removed the #:module-build-flags argument in frozen-bubble
package, as it didn't seem to be necessary, and I was not sure why I had
added it in the first place.

> I can’t wait to try it again, so many years later.  :-)

Heh.

Thank you for the review. I pushed the changes.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.